--- chromium-69.0.3472.3/third_party/crashpad/crashpad/compat/non_win/dbghelp.h.gcc7 2018-06-26 06:33:19.000000000 +0200 +++ chromium-69.0.3472.3/third_party/crashpad/crashpad/compat/non_win/dbghelp.h 2018-07-07 12:30:05.410672630 +0200 @@ -29,7 +29,7 @@ //! //! A hex dump of a little-endian minidump file will begin with the string //! “MDMP”. -#define MINIDUMP_SIGNATURE ('PMDM') // 0x4d444d50 +#define MINIDUMP_SIGNATURE (0x4d444d50) // 'PMDM' //! \brief The version of a minidump file, stored in MINIDUMP_HEADER::Version. #define MINIDUMP_VERSION (42899) --- chromium-69.0.3472.3/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc.gcc7 2018-06-26 06:32:58.000000000 +0200 +++ chromium-69.0.3472.3/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc 2018-07-07 13:47:27.816647653 +0200 @@ -156,6 +156,7 @@ } } } + return false; } StateChangeReason DiscardReasonToStateChangeReason( @@ -168,6 +169,7 @@ case LifecycleUnitDiscardReason::URGENT: return StateChangeReason::SYSTEM_MEMORY_PRESSURE; } + return StateChangeReason::BROWSER_INITIATED; } struct FeatureUsageEntry { --- chromium-69.0.3472.3/components/previews/core/previews_black_list.cc.gcc7 2018-06-26 06:33:01.000000000 +0200 +++ chromium-69.0.3472.3/components/previews/core/previews_black_list.cc 2018-07-07 15:41:14.295381780 +0200 @@ -34,6 +34,7 @@ case blacklist::BlacklistReason::kAllowed: return PreviewsEligibilityReason::ALLOWED; } + return PreviewsEligibilityReason::LAST; } } --- chromium-69.0.3472.3/base/callback_helpers.h.gcc7 2018-06-26 06:32:56.000000000 +0200 +++ chromium-69.0.3472.3/base/callback_helpers.h 2018-07-07 16:00:33.724127746 +0200 @@ -91,7 +91,7 @@ void ReplaceClosure(OnceClosure closure); // Releases the Closure without calling. - OnceClosure Release() WARN_UNUSED_RESULT; + OnceClosure Release(); private: OnceClosure closure_; --- chromium-69.0.3472.3/device/bluetooth/bluetooth_remote_gatt_characteristic.cc.gcc7 2018-06-26 06:33:02.000000000 +0200 +++ chromium-69.0.3472.3/device/bluetooth/bluetooth_remote_gatt_characteristic.cc 2018-07-07 21:00:37.557253268 +0200 @@ -362,14 +362,15 @@ Properties properties = GetProperties(); bool hasNotify = (properties & PROPERTY_NOTIFY) != 0; bool hasIndicate = (properties & PROPERTY_INDICATE) != 0; - if (!notification_type) - return hasNotify || hasIndicate; - switch (notification_type.value()) { - case NotificationType::kNotification: - return hasNotify; - case NotificationType::kIndication: - return hasIndicate; + if (notification_type) { + switch (notification_type.value()) { + case NotificationType::kNotification: + return hasNotify; + case NotificationType::kIndication: + return hasIndicate; + } } + return hasNotify || hasIndicate; } } // namespace device --- chromium-69.0.3472.3/pdf/out_of_process_instance.cc.gcc7 2018-06-26 06:33:05.000000000 +0200 +++ chromium-69.0.3472.3/pdf/out_of_process_instance.cc 2018-07-07 22:24:15.654709688 +0200 @@ -471,7 +471,6 @@ text_input_ = std::make_unique<pp::TextInput_Dev>(this); - bool enable_javascript = false; const char* stream_url = nullptr; const char* original_url = nullptr; const char* top_level_url = nullptr; @@ -491,8 +490,6 @@ } else if (strcmp(argn[i], "top-toolbar-height") == 0) { success = base::StringToInt(argv[i], &top_toolbar_height_in_viewport_coords_); - } else if (strcmp(argn[i], "javascript") == 0) { - enable_javascript = (strcmp(argv[i], "allow") == 0); } if (!success) return false; --- chromium-69.0.3472.3/ui/views/layout/layout_provider.cc.gcc7 2018-06-26 06:33:24.000000000 +0200 +++ chromium-69.0.3472.3/ui/views/layout/layout_provider.cc 2018-07-07 22:46:19.302390595 +0200 @@ -145,7 +145,7 @@ int LayoutProvider::GetCornerRadiusMetri const gfx::Size& size) const { switch (emphasis_metric) { case views::EMPHASIS_NONE: - return 0; + break; case EMPHASIS_LOW: case EMPHASIS_MEDIUM: return 4; @@ -154,13 +154,14 @@ int LayoutProvider::GetCornerRadiusMetri case EMPHASIS_MAXIMUM: return std::min(size.width(), size.height()) / 2; } + return 0; } int LayoutProvider::GetShadowElevationMetric( EmphasisMetric emphasis_metric) const { switch (emphasis_metric) { case views::EMPHASIS_NONE: - return 0; + break; case views::EMPHASIS_LOW: return 1; case views::EMPHASIS_MEDIUM: @@ -170,6 +171,7 @@ int LayoutProvider::GetShadowElevationMe case views::EMPHASIS_MAXIMUM: return 16; } + return 0; } gfx::ShadowValues LayoutProvider::MakeShadowValues(int elevation, --- chromium-69.0.3472.3/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc.gcc7 2018-06-26 06:33:19.000000000 +0200 +++ chromium-69.0.3472.3/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc 2018-07-08 10:57:14.446270568 +0200 @@ -707,7 +707,7 @@ PageSchedulerImpl::PageLifecycleStateTra switch (old_state) { case PageLifecycleState::kUnknown: // We don't track the initial transition. - return base::nullopt; + break; case PageLifecycleState::kActive: switch (new_state) { case PageLifecycleState::kHiddenForegrounded: @@ -716,8 +716,8 @@ PageSchedulerImpl::PageLifecycleStateTra return PageLifecycleStateTransition::kActiveToHiddenBackgrounded; default: NOTREACHED(); - return base::nullopt; } + break; case PageLifecycleState::kHiddenForegrounded: switch (new_state) { case PageLifecycleState::kActive: @@ -729,8 +729,8 @@ PageSchedulerImpl::PageLifecycleStateTra return PageLifecycleStateTransition::kHiddenForegroundedToFrozen; default: NOTREACHED(); - return base::nullopt; } + break; case PageLifecycleState::kHiddenBackgrounded: switch (new_state) { case PageLifecycleState::kActive: @@ -742,8 +742,8 @@ PageSchedulerImpl::PageLifecycleStateTra return PageLifecycleStateTransition::kHiddenBackgroundedToFrozen; default: NOTREACHED(); - return base::nullopt; } + break; case PageLifecycleState::kFrozen: switch (new_state) { case PageLifecycleState::kActive: @@ -754,9 +754,10 @@ PageSchedulerImpl::PageLifecycleStateTra return PageLifecycleStateTransition::kFrozenToHiddenBackgrounded; default: NOTREACHED(); - return base::nullopt; } + break; } + return base::nullopt; } FrameSchedulerImpl* PageSchedulerImpl::SelectFrameForUkmAttribution() { --- chromium-69.0.3497.4/components/policy/core/common/policy_proto_decoders.cc.gcc7 2018-07-21 09:12:56.000000000 +0200 +++ chromium-69.0.3497.4/components/policy/core/common/policy_proto_decoders.cc 2018-07-21 21:38:32.566870921 +0200 @@ -43,6 +43,7 @@ case em::PolicyOptions::UNSET: return false; } + return false; } // Convert a BooleanPolicyProto to a bool base::Value. --- chromium-69.0.3497.4/components/password_manager/core/browser/browser_save_password_progress_logger.cc.gcc7 2018-07-21 09:12:55.000000000 +0200 +++ chromium-69.0.3497.4/components/password_manager/core/browser/browser_save_password_progress_logger.cc 2018-07-21 23:21:48.274812853 +0200 @@ -76,6 +76,7 @@ std::string VoteTypeToString( case AutofillUploadContents::Field::FIRST_USE: return "First use"; } + return ""; } std::string FormSignatureToDebugString(autofill::FormSignature form_signature) { --- chromium-69.0.3497.4/content/browser/renderer_host/input/mouse_wheel_event_queue.cc.gcc7 2018-07-21 09:13:03.000000000 +0200 +++ chromium-69.0.3497.4/content/browser/renderer_host/input/mouse_wheel_event_queue.cc 2018-07-21 23:53:41.085484269 +0200 @@ -178,13 +178,11 @@ bool current_phase_ended = false; bool scroll_phase_ended = false; bool momentum_phase_ended = false; - bool has_phase_info = false; if (event_sent_for_gesture_ack_->event.phase != blink::WebMouseWheelEvent::kPhaseNone || event_sent_for_gesture_ack_->event.momentum_phase != blink::WebMouseWheelEvent::kPhaseNone) { - has_phase_info = true; scroll_phase_ended = event_sent_for_gesture_ack_->event.phase == blink::WebMouseWheelEvent::kPhaseEnded || event_sent_for_gesture_ack_->event.phase == --- chromium-69.0.3497.4/content/browser/web_package/signed_exchange_handler.cc.gcc7 2018-07-21 20:30:02.788552807 +0200 +++ chromium-69.0.3497.4/content/browser/web_package/signed_exchange_handler.cc 2018-07-22 00:32:42.325559060 +0200 @@ -541,7 +541,7 @@ void SignedExchangeHandler::OnVerifyCert error_message = base::StringPrintf( "CT verification failed. result: %s, policy compliance: %d", net::ErrorToShortString(error_code).c_str(), - ct_result.policy_compliance); + int(ct_result.policy_compliance)); result = SignedExchangeLoadResult::kCTVerificationError; } else { error_message = --- chromium-69.0.3497.4/services/viz/public/cpp/gpu/command_buffer_metrics.cc.gcc7 2018-07-21 09:13:14.000000000 +0200 +++ chromium-69.0.3497.4/services/viz/public/cpp/gpu/command_buffer_metrics.cc 2018-07-22 02:02:14.833006828 +0200 @@ -97,6 +97,7 @@ std::string ContextTypeToString(ContextT case ContextType::XR_COMPOSITING: return "XRCompositing"; } + return "Unexpected"; } void UmaRecordContextInitFailed(ContextType type) { --- chromium-69.0.3497.4/third_party/blink/renderer/modules/peerconnection/rtc_rtp_transceiver.cc.gcc7 2018-07-21 09:13:41.000000000 +0200 +++ chromium-69.0.3497.4/third_party/blink/renderer/modules/peerconnection/rtc_rtp_transceiver.cc 2018-07-22 02:11:31.506330451 +0200 @@ -29,6 +29,7 @@ case webrtc::RtpTransceiverDirection::kInactive: return "inactive"; } + return ""; } String OptionalTransceiverDirectionToString( --- chromium-69.0.3497.4/media/blink/watch_time_reporter.cc.gcc7 2018-07-21 09:13:09.000000000 +0200 +++ chromium-69.0.3497.4/media/blink/watch_time_reporter.cc 2018-07-22 03:13:23.483720815 +0200 @@ -572,6 +572,7 @@ case DisplayType::kPictureInPicture: return DISPLAY_TYPE_KEY(DisplayPictureInPicture); } + return DISPLAY_TYPE_KEY(All); } #undef DISPLAY_TYPE_KEY --- chromium-69.0.3497.4/third_party/blink/renderer/core/css/style_environment_variables.cc.gcc7 2018-07-21 09:13:40.000000000 +0200 +++ chromium-69.0.3497.4/third_party/blink/renderer/core/css/style_environment_variables.cc 2018-07-22 10:53:45.772448293 +0200 @@ -63,6 +63,7 @@ case UADefinedVariable::kSafeAreaInsetRight: return "safe-area-inset-right"; default: + return ""; break; } --- chromium-69.0.3497.4/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc.gcc7 2018-07-21 09:13:41.000000000 +0200 +++ chromium-69.0.3497.4/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc 2018-07-22 12:12:33.199377829 +0200 @@ -1800,9 +1800,6 @@ void XMLHttpRequest::DidSendData(uint64_ void XMLHttpRequest::DidReceiveResponse(uint64_t identifier, const ResourceResponse& response) { - // TODO(yhirano): Remove this CHECK: see https://crbug.com/570946. - CHECK(&response); - NETWORK_DVLOG(1) << this << " didReceiveResponse(" << identifier << ")"; ScopedEventDispatchProtect protect(&event_dispatch_recursion_level_); --- chromium-69.0.3497.4/third_party/blink/renderer/modules/cookie_store/cookie_change_event.cc.gcc7 2018-07-21 09:13:41.000000000 +0200 +++ chromium-69.0.3497.4/third_party/blink/renderer/modules/cookie_store/cookie_change_event.cc 2018-07-22 12:42:37.155347296 +0200 @@ -56,6 +56,7 @@ } NOTREACHED(); + return ""; } } // namespace --- chromium-69.0.3497.42/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer.cc.gcc7 2018-08-17 03:05:19.000000000 +0200 +++ chromium-69.0.3497.42/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer.cc 2018-08-18 23:31:30.084822331 +0200 @@ -286,7 +286,9 @@ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); if (ShouldIgnoreFeatureUsageEvent(feature_type)) + { return; + } (writer_.get()->*method)(); } --- chromium-69.0.3497.42/third_party/blink/renderer/modules/peerconnection/peer_connection_tracker.cc.gcc7 2018-08-17 03:05:35.000000000 +0200 +++ chromium-69.0.3497.42/third_party/blink/renderer/modules/peerconnection/peer_connection_tracker.cc 2018-08-19 10:00:21.171828248 +0200 @@ -144,6 +144,7 @@ String SerializeDirection(webrtc::RtpTra case webrtc::RtpTransceiverDirection::kInactive: return "'inactive'"; } + return ""; } String SerializeOptionalDirection( --- chromium-69.0.3497.42/third_party/blink/renderer/core/html/media/media_controls.cc.gcc7 2018-08-17 03:06:24.000000000 +0200 +++ chromium-69.0.3497.42/third_party/blink/renderer/core/html/media/media_controls.cc 2018-08-19 12:30:24.128429583 +0200 @@ -39,6 +39,7 @@ } NOTREACHED(); + return AtomicString(); } MediaControls::MediaControls(HTMLMediaElement& media_element)