--- chromium-73.0.3683.75/media/learning/common/labelled_example.cc.gcc8 2019-03-11 23:00:59.000000000 +0100 +++ chromium-73.0.3683.75/media/learning/common/labelled_example.cc 2019-03-16 22:24:12.068011327 +0100 @@ -17,7 +17,7 @@ LabelledExample::LabelledExample(std::in LabelledExample::LabelledExample(const LabelledExample& rhs) = default; -LabelledExample::LabelledExample(LabelledExample&& rhs) noexcept = default; +LabelledExample::LabelledExample(LabelledExample&& rhs) = default; LabelledExample::~LabelledExample() = default; --- chromium-73.0.3683.75/third_party/webrtc/pc/dtls_transport.cc.gcc8 2019-03-11 23:08:14.000000000 +0100 +++ chromium-73.0.3683.75/third_party/webrtc/pc/dtls_transport.cc 2019-03-17 17:09:41.262096771 +0100 @@ -31,9 +31,9 @@ DtlsTransportState TranslateState(cricke return DtlsTransportState::kClosed; break; case cricket::DTLS_TRANSPORT_FAILED: - return DtlsTransportState::kFailed; break; } + return DtlsTransportState::kFailed; } } // namespace --- chromium-73.0.3683.75/third_party/webrtc/modules/audio_processing/audio_processing_impl.cc.gcc8 2019-03-11 23:08:08.000000000 +0100 +++ chromium-73.0.3683.75/third_party/webrtc/modules/audio_processing/audio_processing_impl.cc 2019-03-17 17:41:37.256312669 +0100 @@ -123,9 +123,9 @@ NoiseSuppression::Level NsConfigLevelToI return NoiseSuppression::Level::kHigh; case NsConfig::kVeryHigh: return NoiseSuppression::Level::kVeryHigh; - default: - RTC_NOTREACHED(); } + RTC_NOTREACHED(); + return NoiseSuppression::Level::kLow; } GainControl::Mode Agc1ConfigModeToInterfaceMode( --- chromium-73.0.3683.75/media/audio/audio_input_device.cc.gcc8 2019-03-11 23:00:59.000000000 +0100 +++ chromium-73.0.3683.75/media/audio/audio_input_device.cc 2019-03-17 18:22:38.765345928 +0100 @@ -51,8 +51,9 @@ base::ThreadPriority ThreadPriorityFromP case AudioInputDevice::Purpose::kUserInput: return base::ThreadPriority::REALTIME_AUDIO; case AudioInputDevice::Purpose::kLoopback: - return base::ThreadPriority::NORMAL; + break; } + return base::ThreadPriority::NORMAL; } } // namespace --- chromium-73.0.3683.75/media/base/supported_types.cc.gcc8 2019-03-17 18:44:50.562746764 +0100 +++ chromium-73.0.3683.75/media/base/supported_types.cc 2019-03-17 18:54:33.504821670 +0100 @@ -186,6 +186,8 @@ bool IsAudioCodecProprietary(AudioCodec case kUnknownAudioCodec: return false; } + NOTREACHED(); + return true; } bool IsDefaultSupportedAudioType(const AudioType& type) { @@ -257,6 +259,8 @@ bool IsVideoCodecProprietary(VideoCodec case kCodecAV1: return false; } + NOTREACHED(); + return true; } // TODO(chcunningham): Add platform specific logic for Android (move from --- chromium-73.0.3683.75/components/previews/core/previews_lite_page_redirect.cc.gcc8 2019-03-11 23:00:57.000000000 +0100 +++ chromium-73.0.3683.75/components/previews/core/previews_lite_page_redirect.cc 2019-03-17 19:05:27.524601525 +0100 @@ -16,7 +16,7 @@ std::string ServerLitePageStatusToString case ServerLitePageStatus::kUnknown: // Unknown penalty metrics are not recorded. NOTREACHED(); - return "Unknown"; + break; case ServerLitePageStatus::kSuccess: return "Success"; case ServerLitePageStatus::kBypass: @@ -30,6 +30,7 @@ std::string ServerLitePageStatusToString NOTREACHED(); return "Control"; } + return "Unknown"; } bool IsLitePageRedirectPreviewDomain(const GURL& url) { --- chromium-73.0.3683.75/net/dns/host_resolver_mdns_listener_impl.cc.gcc8 2019-03-11 23:01:01.000000000 +0100 +++ chromium-73.0.3683.75/net/dns/host_resolver_mdns_listener_impl.cc 2019-03-17 19:27:38.168722885 +0100 @@ -25,6 +25,7 @@ HostResolver::MdnsListener::Delegate::Up case net::MDnsListener::RECORD_REMOVED: return HostResolver::MdnsListener::Delegate::UpdateType::REMOVED; } + return net::HostResolver::MdnsListener::Delegate::UpdateType(0); } } // namespace --- chromium-73.0.3683.75/net/dns/host_resolver_mdns_task.cc.gcc8 2019-03-11 23:01:01.000000000 +0100 +++ chromium-73.0.3683.75/net/dns/host_resolver_mdns_task.cc 2019-03-17 19:29:16.803025405 +0100 @@ -219,6 +219,7 @@ HostCache::Entry HostResolverMdnsTask::P return ParseHostnameResult(parsed->rdata<SrvRecordRdata>()->target(), parsed->rdata<SrvRecordRdata>()->port()); } + return HostCache::Entry(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN); } void HostResolverMdnsTask::CheckCompletion(bool post_needed) { --- chromium-73.0.3683.75/cc/trees/layer_tree_host.cc.gcc8 2019-03-11 23:00:52.000000000 +0100 +++ chromium-73.0.3683.75/cc/trees/layer_tree_host.cc 2019-03-17 19:34:15.025887235 +0100 @@ -1157,8 +1157,10 @@ void LayerTreeHost::SetViewportSizeAndSc float device_scale_factor, const viz::LocalSurfaceIdAllocation& local_surface_id_allocation_from_parent) { +#if defined(OS_MACOSX) const viz::LocalSurfaceId previous_local_surface_id = local_surface_id_allocation_from_parent_.local_surface_id(); +#endif SetLocalSurfaceIdAllocationFromParent( local_surface_id_allocation_from_parent); --- chromium-73.0.3683.75/services/media_session/audio_focus_manager.cc.gcc8 2019-03-11 23:01:01.000000000 +0100 +++ chromium-73.0.3683.75/services/media_session/audio_focus_manager.cc 2019-03-17 19:52:48.908690179 +0100 @@ -312,8 +312,9 @@ bool AudioFocusManager::ShouldSessionBeS return false; case mojom::EnforcementMode::kDefault: NOTIMPLEMENTED(); - return false; + break; } + return false; } bool AudioFocusManager::ShouldSessionBeDucked( @@ -329,8 +330,9 @@ bool AudioFocusManager::ShouldSessionBeD return false; case mojom::EnforcementMode::kDefault: NOTIMPLEMENTED(); - return false; + break; } + return false; } void AudioFocusManager::EnforceSingleSession(AudioFocusRequest* session, --- chromium-73.0.3683.75/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc.gcc8-5 2019-03-17 16:29:17.913280114 +0100 +++ chromium-73.0.3683.75/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc 2019-03-17 20:17:22.060274195 +0100 @@ -280,8 +280,9 @@ bool UpdateServerMetadata(AutofillTable* return table->UpdateServerCardMetadata(metadata); case WalletMetadataSpecifics::UNKNOWN: NOTREACHED(); - return false; + break; } + return false; } } // namespace --- chromium-73.0.3683.75/components/download/internal/common/download_item_impl.cc.gcc8-5 2019-03-17 16:29:19.104259012 +0100 +++ chromium-73.0.3683.75/components/download/internal/common/download_item_impl.cc 2019-03-17 20:25:57.404313744 +0100 @@ -593,7 +593,7 @@ void DownloadItemImpl::UpdateResumptionI bytes_wasted_ = 0; } - auto_resume_count_ = user_resume ? 0 : ++auto_resume_count_; + auto_resume_count_ = user_resume ? 0 : auto_resume_count_+1; } void DownloadItemImpl::Cancel(bool user_cancel) { --- chromium-73.0.3683.75/components/invalidation/public/invalidator_state.cc.gcc8 2019-03-11 23:00:56.000000000 +0100 +++ chromium-73.0.3683.75/components/invalidation/public/invalidator_state.cc 2019-03-17 20:27:30.702671478 +0100 @@ -27,6 +27,7 @@ const char* InvalidatorStateToString(Inv case NOT_STARTED_NO_REFRESH_TOKEN: return "NOT_STARTED_NO_REFRESH_TOKEN"; } + return ""; } } // namespace syncer --- chromium-73.0.3683.75/services/network/public/cpp/host_resolver_mojom_traits.cc.gcc8-5 2019-03-17 16:29:20.281238158 +0100 +++ chromium-73.0.3683.75/services/network/public/cpp/host_resolver_mojom_traits.cc 2019-03-17 20:35:22.596375800 +0100 @@ -370,6 +370,7 @@ EnumTraits<MdnsListenClient::UpdateType, case net::HostResolver::MdnsListener::Delegate::UpdateType::REMOVED: return MdnsListenClient::UpdateType::REMOVED; } + return MdnsListenClient::UpdateType::CHANGED; } // static @@ -388,6 +389,7 @@ bool EnumTraits<MdnsListenClient::Update *output = net::HostResolver::MdnsListener::Delegate::UpdateType::REMOVED; return true; } + return false; } // static --- chromium-73.0.3683.75/components/invalidation/impl/fcm_network_handler.cc.gcc8 2019-03-11 23:00:56.000000000 +0100 +++ chromium-73.0.3683.75/components/invalidation/impl/fcm_network_handler.cc 2019-03-17 20:43:19.481009130 +0100 @@ -288,6 +288,7 @@ std::string FCMNetworkHandlerDiagnostic: case instance_id::InstanceID::NETWORK_ERROR: return "InstanceID::NETWORK_ERROR"; } + return ""; } } // namespace syncer --- chromium-73.0.3683.75/components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate.cc.gcc8 2019-03-11 23:00:57.000000000 +0100 +++ chromium-73.0.3683.75/components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate.cc 2019-03-17 20:49:48.146201385 +0100 @@ -292,8 +292,9 @@ bool MutableProfileOAuth2TokenServiceDel case GaiaAuthConsumer::TokenRevocationStatus::kInvalidToken: case GaiaAuthConsumer::TokenRevocationStatus::kInvalidRequest: case GaiaAuthConsumer::TokenRevocationStatus::kUnknownError: - return false; + break; } + return false; } void MutableProfileOAuth2TokenServiceDelegate::RevokeServerRefreshToken:: --- chromium-73.0.3683.75/ui/accessibility/mojom/ax_tree_id_mojom_traits.h.gcc8 2019-03-11 23:01:18.000000000 +0100 +++ chromium-73.0.3683.75/ui/accessibility/mojom/ax_tree_id_mojom_traits.h 2019-03-17 21:04:36.260411552 +0100 @@ -16,10 +16,11 @@ struct UnionTraits<ax::mojom::AXTreeIDDa static ax::mojom::AXTreeIDDataView::Tag GetTag(const ui::AXTreeID& p) { switch (p.type()) { case ax::mojom::AXTreeIDType::kUnknown: - return ax::mojom::AXTreeIDDataView::Tag::UNKNOWN; + break; case ax::mojom::AXTreeIDType::kToken: return ax::mojom::AXTreeIDDataView::Tag::TOKEN; } + return ax::mojom::AXTreeIDDataView::Tag::UNKNOWN; } static uint8_t unknown(const ui::AXTreeID& p) { return 0; } static const base::UnguessableToken token(const ui::AXTreeID& p) { --- chromium-73.0.3683.75/ui/views/layout/flex_layout_types.cc.gcc8 2019-03-11 23:01:19.000000000 +0100 +++ chromium-73.0.3683.75/ui/views/layout/flex_layout_types.cc 2019-03-17 21:25:16.948916466 +0100 @@ -59,6 +59,7 @@ int InterpolateSize(MinimumFlexSizeRule case MaximumFlexSizeRule::kUnbounded: return available_size; } + return 0; } // A view's minimum size can in some cases be expensive to compute. This --- chromium-73.0.3683.75/chrome/browser/apps/platform_apps/audio_focus_web_contents_observer.h.gcc8 2019-03-11 23:00:53.000000000 +0100 +++ chromium-73.0.3683.75/chrome/browser/apps/platform_apps/audio_focus_web_contents_observer.h 2019-03-17 21:44:42.711684224 +0100 @@ -22,7 +22,6 @@ class AudioFocusWebContentsObserver private: friend class content::WebContentsUserData<AudioFocusWebContentsObserver>; - friend class AudioFocusWebContentsObserver; friend class AudioFocusWebContentsObserverBrowserTest; explicit AudioFocusWebContentsObserver(content::WebContents*); --- chromium-73.0.3683.75/components/safe_browsing/content/browser/threat_details.cc.gcc8 2019-03-11 23:00:57.000000000 +0100 +++ chromium-73.0.3683.75/components/safe_browsing/content/browser/threat_details.cc 2019-03-17 22:50:32.914419357 +0100 @@ -115,8 +115,9 @@ ClientSafeBrowsingReportRequest::ReportT // Gated by SafeBrowsingBlockingPage::ShouldReportThreatDetails. NOTREACHED() << "We should not send report for threat type: " << threat_type; - return ClientSafeBrowsingReportRequest::UNKNOWN; + break; } + return ClientSafeBrowsingReportRequest::UNKNOWN; } // Clears the specified HTTPS resource of any sensitive data, only retaining --- chromium-73.0.3683.75/content/browser/cache_storage/cache_storage_cache_entry_handler.cc.gcc8 2019-03-11 23:00:57.000000000 +0100 +++ chromium-73.0.3683.75/content/browser/cache_storage/cache_storage_cache_entry_handler.cc 2019-03-17 23:06:10.861905396 +0100 @@ -364,6 +364,7 @@ CacheStorageCacheEntryHandler::CreateCac std::move(blob_storage_context)); } NOTREACHED(); + return nullptr; } blink::mojom::SerializedBlobPtr CacheStorageCacheEntryHandler::CreateBlob( --- chromium-73.0.3683.75/content/browser/media/hardware_key_media_controller.cc.gcc8 2019-03-11 23:00:57.000000000 +0100 +++ chromium-73.0.3683.75/content/browser/media/hardware_key_media_controller.cc 2019-03-17 23:20:53.762650819 +0100 @@ -194,6 +194,7 @@ HardwareKeyMediaController::MediaSession case MediaSessionAction::kExitPictureInPicture: return base::nullopt; } + return base::nullopt; } } // namespace content --- chromium-73.0.3683.75/content/browser/cache_storage/cache_storage_histogram_utils.cc.gcc8 2019-03-11 23:00:57.000000000 +0100 +++ chromium-73.0.3683.75/content/browser/cache_storage/cache_storage_histogram_utils.cc 2019-03-17 23:40:14.543806924 +0100 @@ -34,6 +34,7 @@ base::StringPiece UMAToName(CacheStorage case CacheStorageSchedulerUMA::kQueueLength: RETURN_LITERAL_STRING_PIECE("QueueLength"); } + return ""; } base::StringPiece ClientToName(CacheStorageSchedulerClient client_type) { @@ -45,6 +46,7 @@ base::StringPiece ClientToName(CacheStor case CacheStorageSchedulerClient::kStorage: RETURN_LITERAL_STRING_PIECE("CacheStorage"); } + return ""; } bool ShouldRecordOpUMA(CacheStorageSchedulerOp op_type) { @@ -83,12 +85,13 @@ base::StringPiece OpToName(CacheStorageS RETURN_LITERAL_STRING_PIECE("SizeThenClose"); case CacheStorageSchedulerOp::kTest: NOTREACHED(); - return ""; + break; case CacheStorageSchedulerOp::kWriteIndex: RETURN_LITERAL_STRING_PIECE("WriteIndex"); case CacheStorageSchedulerOp::kWriteSideData: RETURN_LITERAL_STRING_PIECE("WriteSideData"); } + return ""; } std::string GetClientHistogramName(CacheStorageSchedulerUMA uma_type, --- chromium-73.0.3683.75/third_party/blink/renderer/modules/mediastream/media_stream_constraints_util_audio.cc.gcc8-5 2019-03-17 16:29:20.433235465 +0100 +++ chromium-73.0.3683.75/third_party/blink/renderer/modules/mediastream/media_stream_constraints_util_audio.cc 2019-03-18 02:02:58.536812396 +0100 @@ -994,6 +994,7 @@ class ProcessingBasedContainer { GetMinMaxLatenciesForAudioParameters(device_parameters); return DoubleRangeSet(min_latency, max_latency); } + return DoubleRangeSet(); } // The priority of each processing-based container depends on the default @@ -1014,6 +1015,7 @@ class ProcessingBasedContainer { case ProcessingType::kApmProcessed: return use_processing_by_default ? 3 : 1; } + return 0; } ProcessingType processing_type_; --- chromium-73.0.3683.75/third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc.gcc8 2019-03-11 23:01:03.000000000 +0100 +++ chromium-73.0.3683.75/third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc 2019-03-18 04:09:21.642290612 +0100 @@ -765,8 +765,8 @@ bool NGOutOfFlowLayoutPart::IsContaining // closest parent block flow. if (candidate.inline_container) { DCHECK( - candidate.node.Style().GetPosition() == EPosition::kAbsolute && - candidate.inline_container->CanContainAbsolutePositionObjects() || + (candidate.node.Style().GetPosition() == EPosition::kAbsolute && + candidate.inline_container->CanContainAbsolutePositionObjects()) || (candidate.node.Style().GetPosition() == EPosition::kFixed && candidate.inline_container->CanContainFixedPositionObjects())); return container_builder_->GetLayoutObject() == --- chromium-73.0.3683.75/third_party/blink/renderer/core/trustedtypes/trusted_types_util.cc.gcc8 2019-03-11 23:01:03.000000000 +0100 +++ chromium-73.0.3683.75/third_party/blink/renderer/core/trustedtypes/trusted_types_util.cc 2019-03-18 04:50:55.458016032 +0100 @@ -243,6 +243,7 @@ String GetStringFromSpecificTrustedType( execution_context, exception_state); } } + return g_empty_string; } String GetStringFromSpecificTrustedType( --- chromium-73.0.3683.75/third_party/blink/renderer/platform/fonts/opentype/open_type_caps_support.cc.gcc8 2019-03-11 23:01:04.000000000 +0100 +++ chromium-73.0.3683.75/third_party/blink/renderer/platform/fonts/opentype/open_type_caps_support.cc 2019-03-18 22:35:49.814430618 +0100 @@ -152,8 +152,8 @@ OpenTypeCapsSupport::FontFormat OpenType hb_blob_get_length(mort_blob.get()); bool has_gsub = hb_ot_layout_has_substitution(hb_face); font_format_ = has_morx_or_mort&& !has_gsub - ? font_format_ = FontFormat::kAat - : font_format_ = FontFormat::kOpenType; + ? FontFormat::kAat + : FontFormat::kOpenType; } return font_format_; } --- chromium-73.0.3683.75/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc.gcc8 2019-03-11 23:01:04.000000000 +0100 +++ chromium-73.0.3683.75/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc 2019-03-18 22:43:19.959852726 +0100 @@ -664,6 +664,8 @@ const Vector<CanvasResourceType>& GetRes kCompositedFallbackList.begin(), kCompositedFallbackList.end())); + static const Vector<CanvasResourceType> kEmptyFallbackList; + switch (usage) { case CanvasResourceProvider::ResourceUsage::kSoftwareResourceUsage: return kSoftwareFallbackList; @@ -688,6 +690,7 @@ const Vector<CanvasResourceType>& GetRes return kEmptyList; } NOTREACHED(); + return kEmptyFallbackList; } } // unnamed namespace