--- chromium-76.0.3809.46/base/message_loop/message_pump.cc.gcc8 2019-06-27 23:59:00.000000000 +0200 +++ chromium-76.0.3809.46/base/message_loop/message_pump.cc 2019-07-01 01:13:08.903490091 +0200 @@ -80,6 +80,7 @@ std::unique_ptr<MessagePump> MessagePump return std::make_unique<MessagePumpDefault>(); #endif } + return nullptr; } } // namespace base --- chromium-76.0.3809.46/base/task/promise/abstract_promise.cc.gcc8 2019-06-27 23:59:00.000000000 +0200 +++ chromium-76.0.3809.46/base/task/promise/abstract_promise.cc 2019-07-01 01:21:10.315469832 +0200 @@ -365,8 +365,9 @@ bool AbstractPromise::OnPrerequisiteCanc // cancellation. if (IsResolvedWithPromise()) OnCanceled(); - return false; + break; } + return false; } void AbstractPromise::OnResolveDispatchReadyDependents() { --- chromium-76.0.3809.46/components/prefs/scoped_user_pref_update.cc.gcc8 2019-06-27 23:59:19.000000000 +0200 +++ chromium-76.0.3809.46/components/prefs/scoped_user_pref_update.cc 2019-07-01 01:26:56.050011380 +0200 @@ -30,7 +30,9 @@ base::Value* ScopedUserPrefUpdateBase::G // side-stepping CHECKs built into base::Value. Thus we need to be certain // that the type matches. if (value_) + { CHECK_EQ(value_->type(), type); + } return value_; } --- chromium-76.0.3809.46/third_party/angle/src/libANGLE/renderer/vulkan/ContextVk.cpp.gcc8 2019-06-28 00:04:20.000000000 +0200 +++ chromium-76.0.3809.46/third_party/angle/src/libANGLE/renderer/vulkan/ContextVk.cpp 2019-07-01 20:48:07.669481311 +0200 @@ -878,9 +878,6 @@ angle::Result ContextVk::submitFrame(con vk::PrimaryCommandBuffer &&commandBuffer) { ANGLE_TRACE_EVENT0("gpu.angle", "RendererVk::submitFrame"); - VkFenceCreateInfo fenceInfo = {}; - fenceInfo.sType = VK_STRUCTURE_TYPE_FENCE_CREATE_INFO; - fenceInfo.flags = 0; VkDevice device = getDevice(); vk::DeviceScoped<CommandBatch> scopedBatch(device); --- chromium-76.0.3809.46/sql/recover_module/parsing.cc.gcc8 2019-06-27 23:59:34.000000000 +0200 +++ chromium-76.0.3809.46/sql/recover_module/parsing.cc 2019-07-01 20:59:19.606507557 +0200 @@ -99,9 +99,9 @@ base::StringPiece ColumnTypeToSql(Module case ModuleColumnType::kRowId: return kIntegerSql; // rowids are ints. case ModuleColumnType::kAny: - return base::StringPiece(); + break; } - NOTREACHED(); + return base::StringPiece(); } } // namespace --- chromium-76.0.3809.46/third_party/webrtc/pc/rtc_stats_collector.cc.gcc8 2019-06-28 00:04:49.000000000 +0200 +++ chromium-76.0.3809.46/third_party/webrtc/pc/rtc_stats_collector.cc 2019-07-01 21:08:19.618953457 +0200 @@ -202,7 +202,7 @@ const char* QualityLimitationReasonToRTC QualityLimitationReason reason) { switch (reason) { case QualityLimitationReason::kNone: - return RTCQualityLimitationReason::kNone; + break; case QualityLimitationReason::kCpu: return RTCQualityLimitationReason::kCpu; case QualityLimitationReason::kBandwidth: @@ -210,6 +210,7 @@ const char* QualityLimitationReasonToRTC case QualityLimitationReason::kOther: return RTCQualityLimitationReason::kOther; } + return RTCQualityLimitationReason::kNone; } double DoubleAudioLevelFromIntAudioLevel(int audio_level) { --- chromium-76.0.3809.46/third_party/crashpad/crashpad/util/misc/pdb_structures.h.gcc8 2019-07-01 00:48:12.411760753 +0200 +++ chromium-76.0.3809.46/third_party/crashpad/crashpad/util/misc/pdb_structures.h 2019-07-01 21:41:07.470903154 +0200 @@ -131,7 +131,7 @@ struct CodeViewRecordBuildID { //! //! In a hex dump, this will appear as “LEpB” when produced by a little-endian //! machine. - static const uint32_t kSignature = 'BpEL'; + static const uint32_t kSignature = 0x4270454c; // 'BpEL' //! \brief The magic number identifying this structure version, the value of //! #kSignature. --- chromium-76.0.3809.46/chrome/browser/notifications/scheduler/internal/proto_conversion.cc.gcc8 2019-07-01 00:48:14.428722404 +0200 +++ chromium-76.0.3809.46/chrome/browser/notifications/scheduler/internal/proto_conversion.cc 2019-07-01 21:55:48.844531001 +0200 @@ -206,6 +206,7 @@ proto::ScheduleParams_Priority ScheduleP case Priority::kNoThrottle: return proto::ScheduleParams_Priority_NO_THROTTLE; } + return proto::ScheduleParams_Priority_LOW; } // Converts ScheduleParams::Priority from proto buffer type. @@ -220,6 +221,7 @@ ScheduleParams::Priority ScheduleParamsP case proto::ScheduleParams_Priority_NO_THROTTLE: return Priority::kNoThrottle; } + return Priority::kLow; } // Converts ScheduleParams to proto buffer type. --- chromium-76.0.3809.46/base/logging.h.gcc8 2019-07-01 22:12:12.066751801 +0200 +++ chromium-76.0.3809.46/base/logging.h 2019-07-01 22:12:28.864495229 +0200 @@ -1036,6 +1036,7 @@ inline std::ostream& operator<<(std::ost #endif #define NOTIMPLEMENTED() DLOG(ERROR) << NOTIMPLEMENTED_MSG +#if DCHECK_IS_ON() #define NOTIMPLEMENTED_LOG_ONCE() \ do { \ static bool logged_once = false; \ @@ -1043,5 +1044,7 @@ inline std::ostream& operator<<(std::ost logged_once = true; \ } while (0); \ EAT_STREAM_PARAMETERS - +#else +#define NOTIMPLEMENTED_LOG_ONCE() EAT_STREAM_PARAMETERS +#endif // DCHECK_IS_ON() #endif // BASE_LOGGING_H_ --- chromium-76.0.3809.46/v8/src/compiler/bytecode-graph-builder.cc.gcc8 2019-06-28 00:04:31.000000000 +0200 +++ chromium-76.0.3809.46/v8/src/compiler/bytecode-graph-builder.cc 2019-07-02 00:02:52.377557951 +0200 @@ -2973,7 +2973,7 @@ void BytecodeGraphBuilder::VisitTestType Node* object = environment()->LookupAccumulator(); auto literal_flag = interpreter::TestTypeOfFlags::Decode( bytecode_iterator().GetFlagOperand(0)); - Node* result; + Node* result = nullptr; switch (literal_flag) { case interpreter::TestTypeOfFlags::LiteralFlag::kNumber: result = NewNode(simplified()->ObjectIsNumber(), object); --- chromium-76.0.3809.46/v8/src/compiler/code-assembler.cc.gcc8 2019-06-28 00:04:31.000000000 +0200 +++ chromium-76.0.3809.46/v8/src/compiler/code-assembler.cc 2019-07-02 00:07:49.856153279 +0200 @@ -1005,7 +1005,7 @@ void CodeAssembler::StoreToObject(Machin TNode<HeapObject> object, TNode<IntPtrT> offset, Node* value, StoreToObjectWriteBarrier write_barrier) { - WriteBarrierKind write_barrier_kind; + WriteBarrierKind write_barrier_kind = WriteBarrierKind::kNoWriteBarrier; switch (write_barrier) { case StoreToObjectWriteBarrier::kFull: write_barrier_kind = WriteBarrierKind::kFullWriteBarrier; --- chromium-76.0.3809.46/v8/src/compiler/js-heap-broker.cc.gcc8 2019-06-28 00:04:31.000000000 +0200 +++ chromium-76.0.3809.46/v8/src/compiler/js-heap-broker.cc 2019-07-02 00:11:37.008059434 +0200 @@ -1769,7 +1769,7 @@ CellData* SourceTextModuleData::GetCell( "module cell " << cell_index << " on " << this); return nullptr; } - CellData* cell; + CellData* cell = nullptr; switch (SourceTextModuleDescriptor::GetCellIndexKind(cell_index)) { case SourceTextModuleDescriptor::kImport: cell = imports_.at(SourceTextModule::ImportIndex(cell_index)); --- chromium-76.0.3809.46/v8/src/compiler/linkage.cc.gcc8 2019-06-28 00:04:31.000000000 +0200 +++ chromium-76.0.3809.46/v8/src/compiler/linkage.cc 2019-07-02 00:16:03.265292900 +0200 @@ -412,7 +412,7 @@ CallDescriptor* Linkage::GetStubCallDesc } // The target for stub calls depends on the requested mode. - CallDescriptor::Kind kind; + CallDescriptor::Kind kind = CallDescriptor::kCallCodeObject; MachineType target_type; switch (stub_mode) { case StubCallMode::kCallCodeObject: --- chromium-76.0.3809.46/v8/src/heap/scavenger.cc.gcc8 2019-06-28 00:04:31.000000000 +0200 +++ chromium-76.0.3809.46/v8/src/heap/scavenger.cc 2019-07-02 00:43:11.188390273 +0200 @@ -460,7 +460,7 @@ void Scavenger::Process(OneshotBarrier* } } - struct PromotionListEntry entry; + struct PromotionListEntry entry = { .size = 0 }; while (promotion_list_.Pop(&entry)) { HeapObject target = entry.heap_object; IterateAndScavengePromotedObject(target, entry.map, entry.size); --- chromium-76.0.3809.46/v8/src/interpreter/bytecode-array-builder.cc.gcc8 2019-06-28 00:04:31.000000000 +0200 +++ chromium-76.0.3809.46/v8/src/interpreter/bytecode-array-builder.cc 2019-07-02 00:48:13.449810212 +0200 @@ -608,7 +608,7 @@ BytecodeArrayBuilder& BytecodeArrayBuild } BytecodeArrayBuilder& BytecodeArrayBuilder::LoadLiteral(AstSymbol symbol) { - size_t entry; + size_t entry = 0; switch (symbol) { case AstSymbol::kHomeObjectSymbol: entry = HomeObjectSymbolConstantPoolEntry(); --- chromium-76.0.3809.46/v8/src/objects/js-date-time-format.cc.gcc8 2019-06-28 00:04:31.000000000 +0200 +++ chromium-76.0.3809.46/v8/src/objects/js-date-time-format.cc 2019-07-02 00:53:00.457549682 +0200 @@ -1039,7 +1039,7 @@ icu::DateFormat::EStyle DateTimeStyleToE icu::UnicodeString ReplaceSkeleton(const icu::UnicodeString input, Intl::HourCycle hc) { icu::UnicodeString result; - char16_t to; + char16_t to = 0; switch (hc) { case Intl::HourCycle::kH11: to = 'K'; --- chromium-76.0.3809.46/v8/src/objects/literal-objects.cc.gcc8 2019-06-28 00:04:31.000000000 +0200 +++ chromium-76.0.3809.46/v8/src/objects/literal-objects.cc 2019-07-02 00:58:24.387664620 +0200 @@ -530,7 +530,7 @@ Handle<ClassBoilerplate> ClassBoilerplat continue; } - ClassBoilerplate::ValueKind value_kind; + ClassBoilerplate::ValueKind value_kind = ClassBoilerplate::kData; switch (property->kind()) { case ClassLiteral::Property::METHOD: value_kind = ClassBoilerplate::kData; --- chromium-76.0.3809.46/cc/trees/layer_tree_host_impl.cc.gcc8 2019-07-02 03:01:14.954915412 +0200 +++ chromium-76.0.3809.46/cc/trees/layer_tree_host_impl.cc 2019-07-02 03:01:27.344698437 +0200 @@ -290,7 +290,7 @@ LayerTreeHostImpl::FrameData::FrameData( LayerTreeHostImpl::FrameData::~FrameData() = default; LayerTreeHostImpl::UIResourceData::UIResourceData() = default; LayerTreeHostImpl::UIResourceData::~UIResourceData() = default; -LayerTreeHostImpl::UIResourceData::UIResourceData(UIResourceData&&) noexcept = +LayerTreeHostImpl::UIResourceData::UIResourceData(UIResourceData&&) = default; LayerTreeHostImpl::UIResourceData& LayerTreeHostImpl::UIResourceData::operator=( UIResourceData&&) = default; --- chromium-76.0.3809.46/components/services/heap_profiling/public/cpp/profiling_client.cc.gcc8 2019-06-27 23:59:19.000000000 +0200 +++ chromium-76.0.3809.46/components/services/heap_profiling/public/cpp/profiling_client.cc 2019-07-02 03:05:28.670471739 +0200 @@ -149,6 +149,7 @@ mojom::AllocatorType ConvertType( case base::PoissonAllocationSampler::AllocatorType::kBlinkGC: return mojom::AllocatorType::kOilpan; } + return mojom::AllocatorType::kMalloc; } } // namespace --- chromium-76.0.3809.46/media/filters/source_buffer_stream.cc.gcc8 2019-06-27 23:59:29.000000000 +0200 +++ chromium-76.0.3809.46/media/filters/source_buffer_stream.cc 2019-07-02 03:30:58.185802349 +0200 @@ -670,7 +670,6 @@ bool SourceBufferStream::IsDtsMonotonica const BufferQueue& buffers) { DCHECK(!buffers.empty()); DecodeTimestamp prev_dts = last_appended_buffer_decode_timestamp_; - bool prev_is_keyframe = last_appended_buffer_is_keyframe_; for (BufferQueue::const_iterator itr = buffers.begin(); itr != buffers.end(); ++itr) { DecodeTimestamp current_dts = (*itr)->GetDecodeTimestamp(); @@ -701,7 +700,6 @@ bool SourceBufferStream::IsDtsMonotonica } prev_dts = current_dts; - prev_is_keyframe = current_is_keyframe; } return true; } --- chromium-76.0.3809.46/chrome/browser/banners/app_banner_manager.cc.gcc8 2019-06-27 23:59:05.000000000 +0200 +++ chromium-76.0.3809.46/chrome/browser/banners/app_banner_manager.cc 2019-07-02 04:51:39.588355276 +0200 @@ -653,8 +653,7 @@ bool AppBannerManager::IsRunning() const base::string16 AppBannerManager::GetInstallableWebAppName( content::WebContents* web_contents) { AppBannerManager* manager = FromWebContents(web_contents); - if (!manager) - return base::string16(); + if (manager) { switch (manager->installable_web_app_check_result_) { case InstallableWebAppCheckResult::kUnknown: case InstallableWebAppCheckResult::kNo: @@ -663,6 +662,8 @@ base::string16 AppBannerManager::GetInst case InstallableWebAppCheckResult::kPromotable: return manager->GetAppName(); } + } + return base::string16(); } bool AppBannerManager::IsProbablyPromotableWebApp() const { @@ -678,6 +679,7 @@ bool AppBannerManager::IsProbablyPromota case InstallableWebAppCheckResult::kPromotable: return true; } + return false; } bool AppBannerManager::MaybeConsumeInstallAnimation() { --- chromium-76.0.3809.46/services/network/public/cpp/host_resolver_mojom_traits.cc.gcc8 2019-07-02 01:53:22.488772803 +0200 +++ chromium-76.0.3809.46/services/network/public/cpp/host_resolver_mojom_traits.cc 2019-07-02 05:04:16.779081053 +0200 @@ -112,8 +112,7 @@ bool ReadDnsOverHttpsServerData( OptionalSecureDnsMode ToOptionalSecureDnsMode( base::Optional<net::DnsConfig::SecureDnsMode> optional) { - if (!optional) - return OptionalSecureDnsMode::NO_OVERRIDE; + if (optional) { switch (optional.value()) { case net::DnsConfig::SecureDnsMode::OFF: return OptionalSecureDnsMode::OFF; @@ -122,6 +121,8 @@ OptionalSecureDnsMode ToOptionalSecureDn case net::DnsConfig::SecureDnsMode::SECURE: return OptionalSecureDnsMode::SECURE; } + } + return OptionalSecureDnsMode::NO_OVERRIDE; } } // namespace @@ -130,7 +131,7 @@ base::Optional<net::DnsConfig::SecureDns OptionalSecureDnsMode mode) { switch (mode) { case OptionalSecureDnsMode::NO_OVERRIDE: - return base::nullopt; + break; case OptionalSecureDnsMode::OFF: return net::DnsConfig::SecureDnsMode::OFF; case OptionalSecureDnsMode::AUTOMATIC: @@ -138,6 +139,7 @@ base::Optional<net::DnsConfig::SecureDns case OptionalSecureDnsMode::SECURE: return net::DnsConfig::SecureDnsMode::SECURE; } + return base::nullopt; } // static --- chromium-76.0.3809.46/components/signin/public/identity_manager/account_info.cc.gcc8 2019-06-27 23:59:19.000000000 +0200 +++ chromium-76.0.3809.46/components/signin/public/identity_manager/account_info.cc 2019-07-02 08:38:27.491124480 +0200 @@ -47,12 +47,12 @@ CoreAccountInfo::~CoreAccountInfo() = de CoreAccountInfo::CoreAccountInfo(const CoreAccountInfo& other) = default; -CoreAccountInfo::CoreAccountInfo(CoreAccountInfo&& other) noexcept = default; +CoreAccountInfo::CoreAccountInfo(CoreAccountInfo&& other) = default; CoreAccountInfo& CoreAccountInfo::operator=(const CoreAccountInfo& other) = default; -CoreAccountInfo& CoreAccountInfo::operator=(CoreAccountInfo&& other) noexcept = +CoreAccountInfo& CoreAccountInfo::operator=(CoreAccountInfo&& other) = default; bool CoreAccountInfo::IsEmpty() const { @@ -69,7 +69,7 @@ AccountInfo::AccountInfo(AccountInfo&& o AccountInfo& AccountInfo::operator=(const AccountInfo& other) = default; -AccountInfo& AccountInfo::operator=(AccountInfo&& other) noexcept = default; +AccountInfo& AccountInfo::operator=(AccountInfo&& other) = default; bool AccountInfo::IsEmpty() const { return CoreAccountInfo::IsEmpty() && hosted_domain.empty() && --- chromium-76.0.3809.46/device/vr/util/gamepad_builder.cc.gcc8 2019-06-27 23:59:25.000000000 +0200 +++ chromium-76.0.3809.46/device/vr/util/gamepad_builder.cc 2019-07-02 08:44:30.063698145 +0200 @@ -24,6 +24,7 @@ GamepadHand MojoToGamepadHandedness(devi } NOTREACHED(); + return GamepadHand::kNone; } } // anonymous namespace @@ -55,6 +56,7 @@ bool GamepadBuilder::IsValid() const { } NOTREACHED(); + return false; } base::Optional<Gamepad> GamepadBuilder::GetGamepad() { --- chromium-76.0.3809.46/components/history/core/browser/history_types.cc.gcc8 2019-06-27 23:59:17.000000000 +0200 +++ chromium-76.0.3809.46/components/history/core/browser/history_types.cc 2019-07-02 08:51:00.016826460 +0200 @@ -186,7 +186,7 @@ QueryURLResult::QueryURLResult(QueryURLR QueryURLResult& QueryURLResult::operator=(const QueryURLResult&) = default; -QueryURLResult& QueryURLResult::operator=(QueryURLResult&&) noexcept = default; +QueryURLResult& QueryURLResult::operator=(QueryURLResult&&) = default; // MostVisitedURL -------------------------------------------------------------- --- chromium-76.0.3809.46/components/signin/core/browser/about_signin_internals.cc.gcc8 2019-07-02 01:53:22.450773482 +0200 +++ chromium-76.0.3809.46/components/signin/core/browser/about_signin_internals.cc 2019-07-02 09:07:57.450074758 +0200 @@ -59,6 +59,7 @@ std::string GetGaiaCookiesStateAsString( case GaiaCookiesState::kAllowed: return "Allowed"; } + return ""; } base::ListValue* AddSection(base::ListValue* parent_list, --- chromium-76.0.3809.46/content/renderer/frame_swap_message_queue.cc.gcc8 2019-06-27 23:59:23.000000000 +0200 +++ chromium-76.0.3809.46/content/renderer/frame_swap_message_queue.cc 2019-07-02 20:46:46.655060316 +0200 @@ -129,6 +129,7 @@ cc::SwapPromise::DidNotSwapAction FrameS // response callbacks itself. return cc::SwapPromise::DidNotSwapAction::BREAK_PROMISE; } + return cc::SwapPromise::DidNotSwapAction::BREAK_PROMISE; } void FrameSwapMessageQueue::DrainMessages( --- chromium-76.0.3809.46/device/fido/credential_management.cc.gcc8 2019-06-27 23:59:25.000000000 +0200 +++ chromium-76.0.3809.46/device/fido/credential_management.cc 2019-07-02 21:18:35.700132318 +0200 @@ -145,7 +145,7 @@ base::Optional<CredentialsMetadataRespon if (it == response_map.end() || !it->second.is_unsigned()) { return base::nullopt; } - const int64_t existing_count = it->second.GetUnsigned(); + const uint64_t existing_count = uint64_t(it->second.GetUnsigned()); if (existing_count > std::numeric_limits<size_t>::max()) { return base::nullopt; } @@ -157,7 +157,7 @@ base::Optional<CredentialsMetadataRespon if (it == response_map.end() || !it->second.is_unsigned()) { return base::nullopt; } - const int64_t remaining_count = it->second.GetUnsigned(); + const uint64_t remaining_count = uint64_t(it->second.GetUnsigned()); if (remaining_count > std::numeric_limits<size_t>::max()) { return base::nullopt; } @@ -189,7 +189,7 @@ base::Optional<EnumerateRPsResponse> Enu } if (expect_rp_count) { if (it == response_map.end() || !it->second.is_unsigned() || - it->second.GetUnsigned() > std::numeric_limits<size_t>::max()) { + uint64_t(it->second.GetUnsigned()) > std::numeric_limits<size_t>::max()) { return base::nullopt; } rp_count = static_cast<size_t>(it->second.GetUnsigned()); @@ -293,7 +293,7 @@ EnumerateCredentialsResponse::Parse( it = response_map.find(cbor::Value( static_cast<int>(CredentialManagementResponseKey::kTotalCredentials))); if (it == response_map.end() || !it->second.is_unsigned() || - it->second.GetUnsigned() > std::numeric_limits<size_t>::max()) { + uint64_t(it->second.GetUnsigned()) > std::numeric_limits<size_t>::max()) { return base::nullopt; } credential_count = static_cast<size_t>(it->second.GetUnsigned()); --- chromium-76.0.3809.46/device/fido/device_response_converter.cc.gcc8 2019-06-27 23:59:25.000000000 +0200 +++ chromium-76.0.3809.46/device/fido/device_response_converter.cc 2019-07-02 21:23:54.832514238 +0200 @@ -406,6 +406,7 @@ static base::Optional<std::string> FixIn return base::nullopt; } } + return base::nullopt; } typedef bool (*PathPredicate)(const std::vector<const cbor::Value*>&); @@ -488,6 +489,7 @@ static base::Optional<cbor::Value> FixIn return cbor::Value(new_map); } } + return base::nullopt; } // ContainsInvalidUTF8 returns true if any element of |v| (recursively) contains @@ -530,6 +532,7 @@ static bool ContainsInvalidUTF8(const cb return false; } } + return false; } base::Optional<cbor::Value> FixInvalidUTF8(cbor::Value in, --- chromium-76.0.3809.46/device/fido/virtual_ctap2_device.cc.gcc8 2019-06-27 23:59:25.000000000 +0200 +++ chromium-76.0.3809.46/device/fido/virtual_ctap2_device.cc 2019-07-02 21:32:36.679270326 +0200 @@ -856,6 +856,7 @@ CtapDeviceResponseCode VirtualCtap2Devic case CredProtect::kUVRequired: return !user_verified; } + return false; }), found_registrations.end()); --- chromium-76.0.3809.46/storage/browser/fileapi/obfuscated_file_util_memory_delegate.cc.gcc8 2019-06-27 23:59:34.000000000 +0200 +++ chromium-76.0.3809.46/storage/browser/fileapi/obfuscated_file_util_memory_delegate.cc 2019-07-02 22:09:50.604979383 +0200 @@ -512,8 +512,8 @@ base::File::Error ObfuscatedFileUtilMemo // |size_t| limits the maximum size that the memory file can keep and |int| // limits the maximum size that base::ReadFile function reads. - if (source_info.size > std::numeric_limits<size_t>::max() || - source_info.size > std::numeric_limits<int>::max()) { + if (uint64_t(source_info.size) > std::numeric_limits<size_t>::max() || + uint64_t(source_info.size) > std::numeric_limits<int>::max()) { return base::File::FILE_ERROR_NO_SPACE; } --- chromium-76.0.3809.46/third_party/blink/renderer/core/editing/commands/insert_paragraph_separator_command.cc.gcc8 2019-06-27 23:59:38.000000000 +0200 +++ chromium-76.0.3809.46/third_party/blink/renderer/core/editing/commands/insert_paragraph_separator_command.cc 2019-07-02 23:33:01.266250287 +0200 @@ -596,8 +596,7 @@ void InsertParagraphSeparatorCommand::Do ->CollapseWhiteSpace()) << position_after_split; DeleteInsignificantTextDownstream(position_after_split); - if (auto* is_text_node = - DynamicTo<Text>(position_after_split.AnchorNode())) { + if (DynamicTo<Text>(position_after_split.AnchorNode())) { InsertTextIntoNode( To<Text>(position_after_split.ComputeContainerNode()), 0, NonBreakingSpaceString()); --- chromium-76.0.3809.46/third_party/blink/renderer/core/layout/layout_text.cc.gcc8 2019-06-27 23:59:38.000000000 +0200 +++ chromium-76.0.3809.46/third_party/blink/renderer/core/layout/layout_text.cc 2019-07-03 00:37:29.459935571 +0200 @@ -538,9 +538,6 @@ void LayoutText::AbsoluteQuadsForRange(V // Find fragments that have text for the specified range. DCHECK_LE(start, end); auto fragments = NGPaintFragment::InlineFragmentsFor(this); - const LayoutBlock* block_for_flipping = nullptr; - if (UNLIKELY(HasFlippedBlocksWritingMode())) - block_for_flipping = ContainingBlock(); for (const NGPaintFragment* fragment : fragments) { const auto& text_fragment = To<NGPhysicalTextFragment>(fragment->PhysicalFragment()); --- chromium-76.0.3809.46/third_party/blink/renderer/core/layout/ng/inline/ng_inline_item_result.cc.gcc8 2019-06-27 23:59:38.000000000 +0200 +++ chromium-76.0.3809.46/third_party/blink/renderer/core/layout/ng/inline/ng_inline_item_result.cc 2019-07-03 00:49:36.598274733 +0200 @@ -130,6 +130,7 @@ bool NGLineInfo::ShouldHangTrailingSpace return IsRtl(BaseDirection()); } NOTREACHED(); + return false; } void NGLineInfo::UpdateTextAlign() { --- chromium-76.0.3809.46/third_party/blink/renderer/core/streams/readable_stream_reader.cc.gcc8 2019-06-27 23:59:39.000000000 +0200 +++ chromium-76.0.3809.46/third_party/blink/renderer/core/streams/readable_stream_reader.cc 2019-07-03 20:06:54.460085077 +0200 @@ -158,6 +158,7 @@ StreamPromiseResolver* ReadableStreamRea // 7. Return ! stream.[[readableStreamController]].[[PullSteps]](). return stream->GetController()->PullSteps(script_state); } + return nullptr; } void ReadableStreamReader::GenericRelease(ScriptState* script_state, --- chromium-76.0.3809.46/third_party/blink/renderer/modules/xr/type_converters.cc.gcc8 2019-06-27 23:59:40.000000000 +0200 +++ chromium-76.0.3809.46/third_party/blink/renderer/modules/xr/type_converters.cc 2019-07-03 21:11:21.303497866 +0200 @@ -12,12 +12,13 @@ TypeConverter<base::Optional<blink::XRPl Convert(const device::mojom::blink::XRPlaneOrientation& orientation) { switch (orientation) { case device::mojom::blink::XRPlaneOrientation::UNKNOWN: - return base::nullopt; + break; case device::mojom::blink::XRPlaneOrientation::HORIZONTAL: return blink::XRPlane::Orientation::kHorizontal; case device::mojom::blink::XRPlaneOrientation::VERTICAL: return blink::XRPlane::Orientation::kVertical; } + return base::nullopt; } blink::TransformationMatrix --- chromium-76.0.3809.46/chrome/browser/page_load_metrics/protocol_util.cc.gcc8 2019-06-27 23:59:08.000000000 +0200 +++ chromium-76.0.3809.46/chrome/browser/page_load_metrics/protocol_util.cc 2019-07-06 04:45:36.417596190 +0200 @@ -17,7 +17,7 @@ NetworkProtocol GetNetworkProtocol( case net::HttpResponseInfo::CONNECTION_INFO_HTTP0_9: case net::HttpResponseInfo::CONNECTION_INFO_HTTP1_0: case net::HttpResponseInfo::NUM_OF_CONNECTION_INFOS: - return NetworkProtocol::kOther; + break; case net::HttpResponseInfo::CONNECTION_INFO_HTTP1_1: return NetworkProtocol::kHttp11; case net::HttpResponseInfo::CONNECTION_INFO_HTTP2: @@ -43,6 +43,7 @@ NetworkProtocol GetNetworkProtocol( case net::HttpResponseInfo::CONNECTION_INFO_QUIC_999: return NetworkProtocol::kQuic; } + return NetworkProtocol::kOther; } } // namespace page_load_metrics --- chromium-76.0.3809.46/chrome/browser/media/router/providers/openscreen/platform/logging.cc.gcc8 2019-06-27 23:59:07.000000000 +0200 +++ chromium-76.0.3809.46/chrome/browser/media/router/providers/openscreen/platform/logging.cc 2019-07-06 05:43:16.188456264 +0200 @@ -21,8 +21,9 @@ namespace { case LogLevel::kError: return ::logging::LOG_ERROR; case LogLevel::kFatal: - return ::logging::LOG_FATAL; + break; } + return ::logging::LOG_FATAL; } } // namespace --- chromium-76.0.3809.46/chrome/browser/media/router/providers/cast/cast_session_client.cc.gcc8 2019-06-27 23:59:07.000000000 +0200 +++ chromium-76.0.3809.46/chrome/browser/media/router/providers/cast/cast_session_client.cc 2019-07-06 05:47:13.570299525 +0200 @@ -97,6 +97,7 @@ bool CastSessionClientImpl::MatchesAutoJ case AutoJoinPolicy::kOriginScoped: return other_origin == origin(); } + return false; } void CastSessionClientImpl::OnMessage( --- chromium-76.0.3809.46/chrome/browser/ui/send_tab_to_self/send_tab_to_self_sub_menu_model.cc.gcc8 2019-06-27 23:59:10.000000000 +0200 +++ chromium-76.0.3809.46/chrome/browser/ui/send_tab_to_self/send_tab_to_self_sub_menu_model.cc 2019-07-06 05:59:16.038627472 +0200 @@ -73,6 +73,7 @@ const std::string MenuTypeToString(SendT default: NOTREACHED(); } + return ""; } } // namespace --- chromium-76.0.3809.46/chrome/browser/ui/views/profiles/profile_menu_view_base.cc.gcc8 2019-06-27 23:59:11.000000000 +0200 +++ chromium-76.0.3809.46/chrome/browser/ui/views/profiles/profile_menu_view_base.cc 2019-07-06 06:20:29.020307080 +0200 @@ -204,7 +204,7 @@ void ProfileMenuViewBase::Reset() { int ProfileMenuViewBase::GetMarginSize(GroupMarginSize margin_size) const { switch (margin_size) { case kNone: - return 0; + break; case kTiny: return ChromeLayoutProvider::Get()->GetDistanceMetric( DISTANCE_CONTENT_LIST_VERTICAL_SINGLE); @@ -215,6 +215,7 @@ int ProfileMenuViewBase::GetMarginSize(G return ChromeLayoutProvider::Get()->GetDistanceMetric( DISTANCE_UNRELATED_CONTROL_VERTICAL_LARGE); } + return 0; } void ProfileMenuViewBase::AddMenuGroup(bool add_separator) { --- chromium-76.0.3809.46/chrome/browser/ui/autofill/payments/save_card_bubble_controller_impl.cc.gcc8 2019-07-05 22:21:44.677969996 +0200 +++ chromium-76.0.3809.46/chrome/browser/ui/autofill/payments/save_card_bubble_controller_impl.cc 2019-07-06 06:58:39.322238222 +0200 @@ -261,8 +261,9 @@ base::string16 SaveCardBubbleControllerI return l10n_util::GetStringUTF16(IDS_AUTOFILL_FAILURE_BUBBLE_TITLE); case BubbleType::INACTIVE: NOTREACHED(); - return base::string16(); + break; } + return base::string16(); } base::string16 SaveCardBubbleControllerImpl::GetExplanatoryMessage() const { --- chromium-76.0.3809.46/chrome/browser/ui/views/tabs/tab_strip_layout.cc.gcc8 2019-06-27 23:59:11.000000000 +0200 +++ chromium-76.0.3809.46/chrome/browser/ui/views/tabs/tab_strip_layout.cc 2019-07-06 07:13:08.410006513 +0200 @@ -28,6 +28,7 @@ int TabSizer::CalculateTabWidth(const Ta space_fraction_available_, tab.GetLayoutCrossoverWidth(), tab.GetPreferredWidth())); } + return 0; } bool TabSizer::TabAcceptsExtraSpace(const TabWidthConstraints& tab) const { @@ -39,6 +40,7 @@ bool TabSizer::TabAcceptsExtraSpace(cons case LayoutDomain::kInactiveWidthEqualsActiveWidth: return tab.GetLayoutCrossoverWidth() < tab.GetPreferredWidth(); } + return false; } bool TabSizer::IsAlreadyPreferredWidth() const { --- chromium-76.0.3809.46/chrome/common/media_router/providers/cast/cast_media_source.cc.gcc8 2019-06-27 23:59:12.000000000 +0200 +++ chromium-76.0.3809.46/chrome/common/media_router/providers/cast/cast_media_source.cc 2019-07-06 07:21:19.540409448 +0200 @@ -297,12 +297,13 @@ bool IsAutoJoinAllowed(AutoJoinPolicy po int tab_id2) { switch (policy) { case AutoJoinPolicy::kPageScoped: - return false; + break; case AutoJoinPolicy::kTabAndOriginScoped: return origin1 == origin2 && tab_id1 == tab_id2; case AutoJoinPolicy::kOriginScoped: return origin1 == origin2; } + return false; } CastAppInfo::CastAppInfo( --- chromium-76.0.3809.46/components/omnibox/browser/autocomplete_match.cc.gcc8 2019-07-05 22:21:44.776968302 +0200 +++ chromium-76.0.3809.46/components/omnibox/browser/autocomplete_match.cc 2019-07-06 07:52:49.356260956 +0200 @@ -378,8 +378,9 @@ base::string16 AutocompleteMatch::GetWhy case Type::TAB_SEARCH_DEPRECATED: case Type::NUM_TYPES: NOTREACHED(); - return base::string16(); + break; } + return base::string16(); } // static --- chromium-76.0.3809.46/content/browser/accessibility/browser_accessibility.cc.gcc8 2019-07-05 22:21:44.776968302 +0200 +++ chromium-76.0.3809.46/content/browser/accessibility/browser_accessibility.cc 2019-07-06 08:36:50.713473424 +0200 @@ -85,6 +85,7 @@ int GetBoundaryTextOffsetInsideBaseAncho case ui::AXTextBoundaryDirection::kForwards: return base->CreatePositionAtEndOfAnchor()->text_offset(); } + return 0; } } // namespace --- chromium-76.0.3809.46/content/browser/permissions/permission_controller_impl.cc.gcc8 2019-06-27 23:59:22.000000000 +0200 +++ chromium-76.0.3809.46/content/browser/permissions/permission_controller_impl.cc 2019-07-06 08:48:16.625189492 +0200 @@ -70,6 +70,7 @@ PermissionToSchedulingFeature(Permission case PermissionType::NUM: return base::nullopt; } + return base::nullopt; } void NotifySchedulerAboutPermissionRequest(RenderFrameHost* render_frame_host, --- chromium-76.0.3809.46/content/browser/devtools/devtools_background_services_context_impl.cc.gcc8 2019-06-27 23:59:22.000000000 +0200 +++ chromium-76.0.3809.46/content/browser/devtools/devtools_background_services_context_impl.cc 2019-07-06 08:53:50.754213204 +0200 @@ -56,6 +56,7 @@ constexpr devtools::proto::BackgroundSer case DevToolsBackgroundService::kPeriodicBackgroundSync: return devtools::proto::PERIODIC_BACKGROUND_SYNC; } + return devtools::proto::BACKGROUND_FETCH; } } // namespace --- chromium-76.0.3809.46/content/browser/scheduler/browser_task_queues.cc.gcc8 2019-06-27 23:59:22.000000000 +0200 +++ chromium-76.0.3809.46/content/browser/scheduler/browser_task_queues.cc 2019-07-06 09:04:59.804259110 +0200 @@ -64,6 +64,7 @@ const char* GetUITaskQueueName(BrowserTa case BrowserTaskQueues::QueueType::kUserVisible: return "ui_user_visible_tq"; } + return ""; } const char* GetIOTaskQueueName(BrowserTaskQueues::QueueType queue_type) { @@ -81,6 +82,7 @@ const char* GetIOTaskQueueName(BrowserTa case BrowserTaskQueues::QueueType::kUserVisible: return "io_user_visible_tq"; } + return ""; } const char* GetTaskQueueName(BrowserThread::ID thread_id, --- chromium-76.0.3809.46/content/browser/indexed_db/indexed_db_transaction.cc.gcc8 2019-06-27 23:59:22.000000000 +0200 +++ chromium-76.0.3809.46/content/browser/indexed_db/indexed_db_transaction.cc 2019-07-06 18:06:53.234685509 +0200 @@ -257,8 +257,7 @@ void IndexedDBTransaction::EnsureBacking leveldb::Status IndexedDBTransaction::BlobWriteComplete( IndexedDBBackingStore::BlobWriteResult result) { IDB_TRACE("IndexedDBTransaction::BlobWriteComplete"); - if (state_ == FINISHED) // aborted - return leveldb::Status::OK(); + if (state_ != FINISHED) { // aborted DCHECK_EQ(state_, COMMITTING); switch (result) { @@ -275,6 +274,8 @@ leveldb::Status IndexedDBTransaction::Bl } } NOTREACHED(); + } + return leveldb::Status::OK(); } leveldb::Status IndexedDBTransaction::Commit() { --- chromium-76.0.3809.46/content/browser/indexed_db/scopes/disjoint_range_lock_manager.cc.gcc8 2019-07-06 18:14:35.649597261 +0200 +++ chromium-76.0.3809.46/content/browser/indexed_db/scopes/disjoint_range_lock_manager.cc 2019-07-06 18:14:48.023380822 +0200 @@ -19,7 +19,7 @@ DisjointRangeLockManager::LockRequest::L : requested_type(type), locks_holder(std::move(locks_holder)), acquired_callback(std::move(acquired_callback)) {} -DisjointRangeLockManager::LockRequest::LockRequest(LockRequest&&) noexcept = +DisjointRangeLockManager::LockRequest::LockRequest(LockRequest&&) = default; DisjointRangeLockManager::LockRequest::~LockRequest() = default; DisjointRangeLockManager::Lock::Lock() = default; --- chromium-76.0.3809.46/ui/accessibility/ax_node_position.cc.gcc8 2019-06-28 00:00:16.000000000 +0200 +++ chromium-76.0.3809.46/ui/accessibility/ax_node_position.cc 2019-07-06 19:01:14.266430629 +0200 @@ -93,7 +93,6 @@ base::stack<AXNode*> AXNodePosition::Get base::stack<AXNode*> anchors; AXNode* current_anchor = GetAnchor(); - int32_t current_anchor_id = GetAnchor()->id(); AXTreeID current_tree_id = this->tree_id(); int32_t parent_anchor_id = INVALID_ANCHOR_ID; @@ -105,7 +104,6 @@ base::stack<AXNode*> AXNodePosition::Get current_anchor /*child*/, current_tree_id /*child_tree_id*/, &parent_tree_id /*parent_tree_id*/, &parent_anchor_id /*parent_id*/); - current_anchor_id = parent_anchor_id; current_tree_id = parent_tree_id; } return anchors; --- chromium-76.0.3809.46/ui/accessibility/ax_text_boundary.cc.gcc8 2019-06-28 00:00:16.000000000 +0200 +++ chromium-76.0.3809.46/ui/accessibility/ax_text_boundary.cc 2019-07-06 19:03:41.205847997 +0200 @@ -41,6 +41,7 @@ std::string ToString(const AXTextBoundar case AXTextBoundary::kWordStartOrEnd: return "WordStartOrEndBoundary"; } + return ""; } std::ostream& operator<<(std::ostream& stream, const AXTextBoundary& boundary) { --- chromium-76.0.3809.46/ui/accessibility/platform/ax_platform_text_boundary.cc.gcc8 2019-06-28 00:00:16.000000000 +0200 +++ chromium-76.0.3809.46/ui/accessibility/platform/ax_platform_text_boundary.cc 2019-07-06 19:11:35.635414535 +0200 @@ -25,6 +25,7 @@ AXTextBoundary FromAtkTextBoundary(AtkTe case ATK_TEXT_BOUNDARY_LINE_END: return AXTextBoundary::kLineEnd; } + return AXTextBoundary::kCharacter; } #if ATK_CHECK_VERSION(2, 10, 0) @@ -42,6 +43,7 @@ AXTextBoundary FromAtkTextGranularity(At case ATK_TEXT_GRANULARITY_PARAGRAPH: return AXTextBoundary::kParagraphStart; } + return AXTextBoundary::kCharacter; } #endif // ATK_CHECK_VERSION(2, 10, 0) #endif // BUILDFLAG(USE_ATK)