2011-02-08 Michael Wiegand <michael.wiegand@greenbone.net> Preparing the openvas-client 3.0.3 release. * VERSION: Set to 3.0.3. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. 2011-02-07 Michael Wiegand <michael.wiegand@greenbone.net> Ensure openvas-client builds with openvas-libraries >= 4.0.0. * configure.in: Check openvas-libraries presence via pkg-config if libopenvas-config cannot be found. * configure: Regenerated. 2010-11-19 Michael Wiegand <michael.wiegand@greenbone.net> Post-release version bump. * VERSION: Set to 3.0.3.SVN. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. 2010-11-19 Michael Wiegand <michael.wiegand@greenbone.net> Preparing the openvas-client 3.0.2 release. * VERSION: Set to 3.0.2. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. 2010-11-19 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * CHANGES: Updated. 2010-11-19 Michael Wiegand <michael.wiegand@greenbone.net> Make sure openvas-client builds with openvas-libraries >= 4.0.0 when being built with OMP support. * openvas/prefs_dialog/prefs_scope_tree.c (scopetree_refresh): Adjust call to omp_get_report () based on libraries version so openvas-client 3.0.x builds with openvas-libraries =< 4.0.0 as well. * openvas/openvas-client.c, openvas/prefs_dialog/prefs_scope_tree.c, openvas/monitor_dialog.c: Check if LIBOPENVAS_OLD_INCLUDE_PATH is defined when including headers originating from openvas-libraries/misc. 2010-11-11 Michael Wiegand <michael.wiegand@greenbone.net> Make sure openvas-client builds with openvas-libraries =< 3.1.4 as well as newer versions by setting the includes based on the openvas-libraries version. * configure.in: Check openvas-libraries version and set LIBOPENVAS_OLD_INCLUDE_PATH if the old include paths should be used. * configure: Regenerated. * openvas.tmpl.in: Handle setting of LIBOPENVAS_OLD_INCLUDE_PATH. * include/includes.h, src/gui/ssh_key_info_form.c, src/gui/ssh_keys_dialog.c, src/gui/ssh_key_info_form.h, src/gui/ssh_keys_dialog.h, src/gui/nvt_pref_sshlogin.c, src/gui/severity_override_form.c, src/util/openvas_lsc_target_prep.c, src/util/openvas_lsc_user_makensis.h, src/util/openvas_lsc_target_prep.h, src/util/openvas_ssh_key_create.c, src/util/openvas_lsc_user_deb.c, src/util/openvas_ssh_key_create.h, src/util/openvas_lsc_user_rpm.c, src/util/openvas_lsc_user_deb.h, src/util/openvas_lsc_user_rpm.h, openvas/attack.c, openvas/openvas-client.c, openvas/monitor_dialog.c, openvas/cli.c, openvas/context.c, openvas/comm.c: Check if LIBOPENVAS_OLD_INCLUDE_PATH is defined when including headers originating from openvas-libraries/misc. 2010-09-14 Matthew Mundell <matthew.mundell@greenbone.net> * openvas/comm.c (comm_get_rules): Remove OMP rules code. GET_RULES was remove pre OMP 1.0. * openvas/prefs_dialog/prefs_scope_tree.c (scopetree_refresh) (scopetree_refresh_reports): Add new omp_get_report first_result_number arg. 2010-07-20 Michael Wiegand <michael.wiegand@greenbone.net> * ChangeLog: Fixed encoding snafus. 2010-07-19 Stephan Kleine * Makefile: Since there is no Makefile in src/ it makes no sense to run clean on it. 2010-07-19 Michael Wiegand <michael.wiegand@greenbone.net> Post-release version bump. * VERSION: Set to 3.0.2.SVN. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. 2010-07-19 Michael Wiegand <michael.wiegand@greenbone.net> Preparing the openvas-client 3.0.1 release. * VERSION: Set to 3.0.1. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. * CHANGES: Updated. 2010-07-19 Michael Meyer <michael.meyerd@greenbone.net> * openvas/preferences.c (preferences_new): Removed references to nonexistent OIDs. Changed OID 10180 (Nessus script_id for ping_host.nasl) to 100315. 2010-07-19 Michael Wiegand <michael.wiegand@greenbone.net> Reverted calls to new library functions to reestablish compatibility with openvas-libraries 3.0.5. Once the openvas-libraries dependency has been raised to 3.1.0, this can be changed back. * openvas/monitor_dialog.c (idle_socket): Changed back to calling omp_get_status. (monitor_stop_whole_test): Changed back to calling omp_abort_task. * openvas/prefs_dialog/prefs_scope_tree.c (scopetree_refresh) (scopetree_refresh_reports): Changed back to calling omp_get_status. 2010-07-13 Matthew Mundell <matthew.mundell@greenbone.net> * openvas/monitor_dialog.c (idle_socket): Add omp_get_tasks details arg. * openvas/prefs_scope_tree.c (scopetree_refresh) (scopetree_refresh_reports): Add omp_get_tasks details arg. 2010-06-18 Matthew Mundell <matthew.mundell@greenbone.net> * openvas/monitor_dialog.c (monitor_stop_whole_test): Call omp_stop_task instead of omp_abort_task. 2010-06-18 Matthew Mundell <matthew.mundell@greenbone.net> * openvas/monitor_dialog.c (idle_socket): Call new name omp_get_tasks. * openvas/prefs_dialog/prefs_scope_tree.c (scopetree_refresh) (scopetree_refresh_reports): Call new name omp_get_tasks. 2010-05-06 Felix Wolfsteller <felix.wolfsteller@greenbone.net> * src/util/Makefile: Added cflags to objects dependencies as suggested by Michal Ambroz. Fixes #1489 (http://bugs.openvas.org/1489). 2010-04-23 Michael Wiegand <michael.wiegand@greenbone.net> * openvas/comm.c (parse_plugin): Make sure sign_key_ids and script_tags are properly initialized before use and freed if parsing has failed. 2010-03-25 Tim Brown <timb@openvas.org> * openvas/latex_output.c: Fixed SIGFPE triggered in LaTeX export when there are 0 hosts in final .nbe. 2010-03-23 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> Removing omp-cli. The command line tool has now a module of its own, "openvas-cli". * src/omp-cli.c, src/Makefile: Removed. * Makefile: Removed handling of omp-cli. * MANIFEST: Updated. 2010-03-23 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> Part 3 of session saving removal. * openvas/openvas-client.c (main): Removing command line options "--list-sessions" and "--restore-session". 2010-03-23 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> Part 2 of session saving removal. * openvas/comm.c (comm_server_restores_sessions, comm_get_sessions, comm_restore_session): Removed. It is not used. * openvas/comm.h: Removed protos accordingly. 2010-03-23 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> Removing since-long disabled code regarding "session saving" feature. This is part 1 of the patch. The change corresponds to CR#46, http://www.openvas.org/openvas-cr-46.html * include/config.h.in: Removed ENABLE_SAVE_TESTS (which was set to 0). * openvas/attack.c, openvas/attack.h, openvas/cli.c, openvas/comm.c, openvas/context.h, openvas/openvas-client.c: Remove code path conditional to ENABLE_SAVE_TESTS. 2010-03-10 Michael Wiegand <michael.wiegand@intevation.de> Removing obsolete, duplicate and broken script for generating client certificates. Client certificates are now generated by openvas-scanner/openvas-mkcert-client. * openvasclient-mkcert.in: Removed. Superseded by openvas-scanner/openvas-mkcert-client.in. * configure.in: Removed handling of openvasclient-mkcert. * configure: Regenerated. * doc/openvasclient-mkcert.1: Removed obsolete manpage. * Makefile: Removed handling of openvasclient-mkcert and now obsolete target "install-bin". Removed handling of obsolete manpage. * MANIFEST: Updated. 2010-02-25 Michael Wiegand <michael.wiegand@intevation.de> * openvas/Makefile: Remove superfluous linking against libcrypto. 2010-02-16 Stephan Kleine * src/omp-cli.c (main): Fix some "format not a string literal and no format arguments" issue. 2010-02-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/omp-cli.c (main): Added pretty print option (--pretty-print, -i). In combination with "direct" XML input (-X), print the response in a more readable (indented) form. 2010-01-08 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/sslui.c: Include gnutls also if configured without GTK. 2010-01-08 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/sslui.c: Cosmetics. 2009-12-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> * configure.in: When gnutls is not found, place a hint that it was searched for using pkg-config (and thus maybe PKG_CONFIG_PATH has to be altered). * configure: Regenerated. 2009-12-18 Michael Wiegand <michael.wiegand@intevation.de> Post-release version bump. * VERSION: Set to 3.0.1.SVN. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. 2009-12-18 Michael Wiegand <michael.wiegand@intevation.de> Preparing the openvas-client 3.0.0 release. * VERSION: Set to 3.0.0. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. * CHANGES: Updated. 2009-12-18 Michael Wiegand <michael.wiegand@intevation.de> * configure.in: Set default for enable_omp to no. * configure: Regenerated. 2009-12-11 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * src/gui/about_dlg.c (about_dialog): Fixed broken URL. 2009-12-09 Tim Brown <timb@openvas.org> * openvas/read_target_file.c: Fixed potential resource leak. * openvas/prefs_dialog/prefs_scope_tree.c: Fixed potential resource leak. * openvas/nbe_output.c: Fixed potential resource leak. 2009-12-07 Michael Wiegand <michael.wiegand@intevation.de> Post-release version bump. * VERSION: Set to 3.0.0.rc2.SVN. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. 2009-12-07 Michael Wiegand <michael.wiegand@intevation.de> Preparing the openvas-client 3.0.0-rc1 release. * VERSION: Set to 3.0.0.rc1. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. * CHANGES: Updated. * ChangeLog: Fixed entry formatting. 2009-11-24 Christian Kuersteiner <ckuerste@gmx.ch> Fixed the progress bar when connecting to the scanner * openvas_client.h: Included config.h because otherwise pointer to progress bar is lost * comm.c: Re-enabled calls to comm_update_ui 2009-11-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added check for gnutls to configure. Thanks to Stephan Kleine for spotting this issue. Closes bug #1188 (http://bugs.openvas.org/1188). * configure.in: Added check for gnutls >= 2.4 * configure: Regenerated. 2009-11-21 Chandrashekhar B <bchandra@secpod.com> * openvas/prefs_dialog/prefs_dialog_user.c: Added new function v6_valid_ip_addr() to validate the IPv6 address. * openvas/prefs_dialog/prefs_dialog_user.c (add_rule_callback): Call v6_valid_ip_addr() to check the IPv6 valid entry in the client user rules. 2009-11-18 Christian Kuersteiner <ckuerste@gmx.ch> * openvas/prefs_dialog/prefs_scan_assistant.c (scan_assistant_create_dialog): Added text for virtual host syntax on step 3. 2009-11-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/prefs_dialog/prefs_scope_tree.c (on_scope_edited): Added documentation. 2009-11-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed bug that prohibited renaming of OTP scopes and OMP servers if configured with --enable-omp. * openvas/prefs_dialog/prefs_scope_tree.c (on_scope_edited): Fixed flow. 2009-11-12 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/prefs_dialog/prefs_dialog.c (prefs_dialog_setup): Corrected check for preferences. This restores correct behaviour for the Settings from the "View" Menu. Closes bug #944 (bugs.openvas.org/944). 2009-11-12 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/prefs_dialog/prefs_dialog.c (toggle_msglog, toggle_toolbar): Reformatted. 2009-11-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> Applying modified patch of Christian Kuersteiner to add support for vhosts. * openvas/read_target_file.c (translate_vhosts): New. "Expands syntax" to add vhosts to an IP. (target_file_to_list, target_translate): Call new function. * openvas/prefs_dialog/prefs_help.h: Modified help text. 2009-11-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> Resolved typos lead to by Ryan Schmidt. * include/ntcompat.h, openvas/latex_output.c: Replaced recommand by recommend, added todo about duplicate code. 2009-11-09 Michael Wiegand <michael.wiegand@intevation.de> Post-release version bump. * VERSION: Set to 3.0.0.beta5.SVN. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. 2009-11-09 Michael Wiegand <michael.wiegand@intevation.de> Last minute fix. * MANIFEST: Remove packaging/debian from MANIFEST since it is not shipped with the source tarball anymore. 2009-11-09 Michael Wiegand <michael.wiegand@intevation.de> Preparing the openvas-client 3.0.0-beta4 release. * VERSION: Set to 3.0.0.beta4. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. * CHANGES: Updated. 2009-11-06 Michael Wiegand <michael.wiegand@intevation.de> Fixed an issue where the content of a report was not properly inserted into the Gtk report pane when it contained special characters and was not UTF-8 encoded. * openvas/prefs_dialog/prefs_report.c (row_activated): Convert the report contents to UTF-8 before inserting them into the text buffer. 2009-11-05 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed a cache issue of OMP scopes that prevented update of the cache if outdated (e.g. feed update for scanner/manager). If the cache is outdated, all plugins are fetched anew and the cache is updated. * openvas/comm.c (client_omp_read_plugins): Minor doc added. [USE_OMP] (comm_get_plugins): Fixed md5sum string comparison, query all plugins anew if cache is out of date. 2009-11-05 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/comm.c: Cosmetics, reformatting, doc. 2009-11-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/plugin_infos.c (spin_to_timeout): Fixed todo/memleak. 2009-11-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/prefs_dialog/prefs_report.c [USE_OMP] (row_activated): Fixed NVT cache issues for OMP reports (e.g. name and OID of NVT that reported a selected issue are shown again). Use cache of parent context, read cache in first if that did not yet happened. Added todos. 2009-11-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/openvas_plugin.c: Cosmetics. (openvas_plugin_get_by_oid): Corrected doc. * openvas/plugin_cache.c, openvas/read_target_file.c, openvas/prefs_dialog/prefs_plugin_tree.c, openvas/prefs_dialog/prefs_report.c: Cosmetics, doc) * openvas/prefs_dialog/prefs_report.c (row_activated): Renamed local var context to cache_holder. 2009-11-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/prefs_dialog/prefs_report.c: Removed unnessecary include. (row_activated): Slightly improve error message if NVT is not found in cache. In case of issues found by NVTs that are not in the cache, do not segfault. 2009-11-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> If configured with --enable-omp --disable-otp, show a menu item "Save openvasrc" to save the openvasrc if a scope context is selected. * openvas/prefs_dialog/prefs_scope_tree.c (scope_menu_save_ok): Doc. (scope_menu_save_as): Renamed from scope_menu_save. (scope_menu_save): New, updates the context and saves it openvasrc. * openvas/prefs_dialog/prefs_scope_tree.h: Updated protos. * openvas/prefs_dialog/prefs_dialog.c (prefs_dialog_setup): Add "Save openvasrc" menuitem. * openvas/prefs_dialog/prefs_contex.c (prefs_context_update_widgets): Grey out "Save openvasrc" button if currently selected context is not a scope. 2009-11-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> Extracted method to create and initialize message log area. * packaging/prefs_dialog.c (create_add_messagelog): New. Extracted from prefs_dialog_setup. (prefs_dialog_setup): Moved code, call new function. 2009-10-29 Matthew Mundell <matthew.mundell@intevation.de> * src/util/file_utils.c (file_utils_rmdir_rf): Free temporary pathname. 2009-10-29 Felix Wolfsteller <felix.wolfsteller@intevation.de> * packaging/debian: Unset svn:externals property. 2009-10-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/omp-cli.c (main): Respect verbosity flag. If command is given as xml and verbosity flag is not set, print only response (or error). 2009-10-26 Michael Wiegand <michael.wiegand@intevation.de> Post-release version bump. * VERSION: Set to 3.0.0.beta4.SVN. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. 2009-10-26 Michael Wiegand <michael.wiegand@intevation.de> Preparing the openvas-client 3.0.0-beta3 release. * VERSION: Set to 3.0.0.beta3. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. * CHANGES: Updated. 2009-10-23 Matthew Mundell <matthew.mundell@intevation.de> * src/util/openvas_ssh_rpm.c (get_rpm_generator_path) (openvas_ssh_rpm_create): Use new name for RPM generator script. * src/util/openvas_lsc_user_rpm.c (get_rpm_generator_path) (openvas_lsc_user_rpm_create): Use new name for RPM generator script. * MANIFEST: Remove tools/openvas-ssh-client-rpm-creator.sh. * tools/openvas-ssh-client-rpm-creator.sh: Remove, now in openvas-libraries. * Makefile (install-tool): Remove, now in openvas-libraries. 2009-10-23 Matthew Mundell <matthew.mundell@intevation.de> * src/util/openvas_ssh_rpm.c, src/util/openvas_lsc_user_rpm.c: Flush trailing whitespace. 2009-10-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/comm.c (omp_send_files, comm_omp_send_files): Refactored, added todos. * openvas/comm.h: Adjusted protos * openvas/attack.c: Adjusted call refactored function. 2009-10-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> Moved omp related functions to openvas-libraries/omp/omp.c module. * openvas/comm.c (omp_get_nvt_all, omp_get_nvt_feed_checksum, omp_get_rules_503, omp_get_dependencies_503): (Re)moved to openvas-libraries/omp/omp.c. (omp_get_preferences_503): Removed. Duplicate in omp module already existed. 2009-10-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/comm.c: Documentation added. 2009-10-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/openvas_plugin.c (openvas_plugin_list_length): New. Counts the number of plugins in a list. * openvas/openvas_plugin.h: Added proto, minor doc. * openvas/attack.c (attack_host, restore_attack): Use new function, resolved todo. 2009-10-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/openvas_plugin.c: Cosmetics. 2009-10-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/plugin_infos.c: Cosmetics. (spin_to_timeout): Changed type of local variable to gchar, added todo about mem leak. * openvas/report.c (report_save): Major reformatting. * openvas/prefs_dialog/prefs_dialog_auth.c: Documentation. 2009-10-19 Michael Wiegand <michael.wiegand@intevation.de> Post-release version bump. * VERSION: Set to 3.0.0.beta3.SVN. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. 2009-10-19 Michael Wiegand <michael.wiegand@intevation.de> Preparing the openvas-client 3.0.0-beta2 release. * VERSION: Set to 3.0.0.beta2. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. * CHANGES: Updated. 2009-10-18 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * po/de.po: Removed old entries. 2009-10-18 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * po/fr.po, po/sv.po, po/he.po: Replace Nessus by OpenVAS. 2009-10-18 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * po/de.po: Resolved fuzzy translations. 2009-10-18 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * po/es.po, po/fr.po, po/de.po, po/sv.po, po/hr.po, po/he.po: Updated with source code changes. 2009-10-18 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * include/config.h.in, include/corevers.h.in, doc/openvasclient-mkcert.1, openvas/prefs_dialog/listnotebook.c, openvas/prefs_dialog/listnotebook.h, openvas/prefs_dialog/prefs_dialog.c, openvas/prefs_dialog/prefs_dialog.h, openvas/prefs_dialog/prefs_dialog_plugins_prefs.c, openvas/prefs_dialog/prefs_dialog_plugins_prefs.h, openvas/prefs_dialog/prefs_dialog_scan_opt.c, openvas/prefs_dialog/prefs_dialog_scan_opt.h, openvas/prefs_dialog/prefs_dialog_user.c, openvas/prefs_dialog/prefs_dialog_user.h, openvas/prefs_dialog/prefs_help.h, openvas/prefs_dialog/prefs_kb.c, openvas/prefs_dialog/prefs_kb.h, openvas/prefs_dialog/prefs_plugins.c, openvas/prefs_dialog/prefs_plugins.h, openvas/prefs_dialog/prefs_plugins_tree.c, openvas/prefs_dialog/prefs_plugins_tree.h, openvas/prefs_dialog/prefs_target.c, openvas/prefs_dialog/prefs_target.h: Replaced Nessus by OpenVAS. 2009-10-17 Matthew Mundell <matthew.mundell@intevation.de> * openvas/prefs_dialog/prefs_context.c (update_connection_image) [USE_OMP]: Clear the image if is_connected is -1. (prefs_context_update_statusbar) [USE_OMP]: For OMP contexts clear the text and image. 2009-10-17 Matthew Mundell <matthew.mundell@intevation.de> * src/omp-cli.c (prints_tasks): Print reports if there are any. (main): Free report_id. 2009-10-16 Matthew Mundell <matthew.mundell@intevation.de> * src/omp-cli.c (prints_tasks): Remove last report printing. (main): Print report ID after start-task. 2009-10-16 Matthew Mundell <matthew.mundell@intevation.de> * src/omp-cli.c (main): Compare cmd_xml to NULL in single command check, as it is a string. 2009-10-16 Matthew Mundell <matthew.mundell@intevation.de> * src/omp-cli.c (main): Rename status to exit_status, as it was shadowed. 2009-10-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/omp-cli.c (print_tasks): Adjusted to differing OMP response for the get_status command (one task-uuid vs many or none). 2009-10-16 Matthew Mundell <matthew.mundell@intevation.de> More organisation and renaming, after negotiations with Felix. * src/omp-cli.c: Add pages. (omp_cli_connection_t, ompcli_connect, ompcli_disconnect) (ompcli_cmd_get_report): Rename. (server_connection_t): New structure. Rename from omp_cli_connection_t. Remove "manager" and "omp" from field names. (manager_open): New function. Rename from ompcli_connect. (manager_close): New function. Rename from ompcli_disconnect. Return openvas_server_close value. (manager_get_reports): New function. Rename from ompcli_cmd_get_report. Rename arg point to report_ids. Return on failure. (main): Ensure that at most one command option is present. Move cmd_xml handling to the end. In each command handler set a status variable instead of exiting immediately. Rename var point to report_ids. Add command handling example to cmd_modify_task. 2009-10-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Refactored omp-cli for easier extendability. * src/omp-cli.c (omp_cli_connection_t): New, struct bundles connection information. (ompcli_connect): New. Connects and authenticates. (ompcli_disconnect): New. Disconnects. (ompcli_cmd_get_report): New, extracted from main. (main): Fill values of omp_cli_connection_t and (dis)connect by using new functions. Added TODO about freeing omp_cli_connection_t. 2009-10-16 Matthew Mundell <matthew.mundell@intevation.de> * openvas/prefs_dialog/prefs_scope_tree.c [USE_OMP] (set_cell_context_type): Only define if OTP is used. (scopetreeview_create_columns): Only create Type column if OTP is used. 2009-10-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> * Makefile: Added target for omp-cli, added to "all" target, install and clean. 2009-10-15 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * openvas/monitor_dialog.c: Removed coment about GTK 2.4 progress widget. Meanwhile the old 2.4 style is gone already. 2009-10-15 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * openvas/comm.h, openvas/latex_output.h, openvas/attack.c, openvas/attack.h, openvas/globals.w32, openvas/html_output.c, openvas/openvas-client.c, openvas/html_output.h, openvas/openvas-client.h, openvas/auth.c, openvas/auth.h, openvas/data_mining.c, openvas/data_mining.h, openvas/nbe_output.c, openvas/filter.c, openvas/nbe_output.h, openvas/filter.h, openvas/html_graph_output.c, openvas/monitor_dialog.c, openvas/cli.c, openvas/html_graph_output.h, openvas/monitor_dialog.h, openvas/cli.h, openvas/backend.c, openvas/openvas_plugin.c, openvas/backend.h, openvas/openvas_plugin.h, openvas/comm.c, openvas/latex_output.c: Replaced Nessus by OpenVAS. 2009-10-15 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * openvas/preferences.h, openvas/sighand.c, openvas/sighand.h, openvas/pdf_output.c, openvas/plugin_infos.c, openvas/pdf_output.h, openvas/plugin_infos.h, openvas/report.c, openvas/report.h, openvas/plugin_cache.c, openvas/plugin_cache.h, openvas/parser.c, openvas/sslui.c, openvas/parser.h, openvas/sslui.h, openvas/text_output.c, openvas/xml_output_ng.c, openvas/text_output.h, openvas/xml_output_ng.h, openvas/read_target_file.c, openvas/read_target_file.h, openvas/report_save.c, openvas/report_utils.c, openvas/report_save.h, openvas/report_utils.h, openvas/subset.c, openvas/subset.h: Replaced Nessus by OpenVAS. 2009-10-15 Matthew Mundell <matthew.mundell@intevation.de> * openvas/prefs_dialog/prefs_dialog_auth.c [USE_OMP] (prefs_dialog_auth_omp_connection): If a do_connect attempt fails, continue to the dialog, otherwise return success. Only return success in the dialog case if there is a socket. * openvas/monitor_dialog.c (monitor_dialog_setup) [USE_OMP]: With OMP contexts start the attack before creating the dialog, in case attack_host fails and pops up a message. 2009-10-15 Matthew Mundell <matthew.mundell@intevation.de> * openvas/monitor_dialog.c (idle_socket) [USE_OMP]: Give up gracefully if getting the status fails. Close the server when removing the idle. Reformat three lines. * openvas/attack.c (attack_host) [USE_OMP]: Add error messages to fail cases. 2009-10-15 Matthew Mundell <matthew.mundell@intevation.de> * src/omp-cli.c (main): Add --delete-report. 2009-10-15 Matthew Mundell <matthew.mundell@intevation.de> * src/omp-cli.c (print_tasks): Add extra space before report ID. (main): Pass content_length to omp_modify_task_file. * openvas/comm.c (omp_send_files): Pass content_length to omp_modify_task_file. * openvas/attack.c (attack_host): Remove specifier from error string. * src/gui/nvt_prefs_sshlogin.c (nvt_pref_sshlogin_rebuild_gui): Correct doc typo. 2009-10-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/context.c (context_collect_servers) [DISABLE_OTP]: Fix bug of missing (not loaded) lsc credentials manager data. 2009-10-15 Matthew Mundell <matthew.mundell@intevation.de> * openvas/prefs_dialog/prefs_scope_tree.c (scopetree_refresh) (scopetree_refresh_reports): Add format to omp_get_report call. 2009-10-14 Matthew Mundell <matthew.mundell@intevation.de> * src/omp-cli.c (print_tasks): New function. (main): Rename the --command option to --xml. Add options for creating a task, removing a task, getting reports, getting task status, starting a task and attaching a file to a task. 2009-10-14 Matthew Mundell <matthew.mundell@intevation.de> Remove reports in scope tree before refreshing. * openvas/prefs_dialog/prefs_scope_tree.c (copy_plugins): New function. (scopetree_refresh_reports): New function, was refresh_reports in monitor_dialog.c. Remove reports before refreshing. * openvas/prefs_dialog/prefs_scope_tree.h: Add header. * openvas/monitor_dialog.c (copy_plugins, refresh_reports): Remove. Move to prefs_scope_tree.c. 2009-10-14 Matthew Mundell <matthew.mundell@intevation.de> * openvas/monitor_dialog.c (monitor_dialog_setup) [USE_OMP]: Only show the checkboxes for OTP tasks. Add OMP specific button text. Only set action for OMP contexts. 2009-10-14 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_prompt_new) [USE_OMP] (ssh_keys_dialog_delete_login) [USE_OMP]: When credentials where added or removed from the lsc credentials manager, update comboboxes in all Server contexts, too. 2009-10-14 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/ssh_keys_dialog.c: Minor cosmetics. 2009-10-13 Matthew Mundell <matthew.mundell@intevation.de> * openvas/monitor_dialog.c (monitor_stop_whole_test) [USE_OMP]: Add OMP alternative. 2009-10-13 Matthew Mundell <matthew.mundell@intevation.de> * openvas/prefs_dialog/prefs_scope_tree.c (scopetree_add_new_with_parent) [USE_OMP]: Add missing format specifier. 2009-10-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/comm.c (omp_send_files)[USE_OMP]: Closed mem leaks, changed signature to return whether action was successfull. openvas/comm.h: Adjusted proto. * openvas/attack.c (attack_host)[USE_OMP]: Respect (new) return value of omp_send_files. 2009-10-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> Minor refactoring. * openvas/comm.c (omp_send_files)[USE_OMP]: New, moved from atttack.c (attack_host). openvas/comm.h: Added protos, corrected path in comment. * openvas/attack.c (attack_host): Moved code to comm.c and call function. 2009-10-13 Matthew Mundell <matthew.mundell@intevation.de> * openvas/preferences.c (prefs_set_string) [USE_OMP]: Always set the value for OMP contexts, so that all values end up in the RC file, even defaults. 2009-10-13 Matthew Mundell <matthew.mundell@intevation.de> * openvas/comm.c (update_individual_plugins): Initialise "missing". 2009-10-13 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> Continued to replace struct openvas_plugin by nvti. * openvas/openvas_plugin.c (openvas_plugin_new): Now handle name, copyright, cve, bid, xres, scripts_tags, sign_key_ids, family and version via nvti. (openvas_plugin_get_by_name): Use new method to access name. (openvas_plugin_duplicate): Use new methods to access elements. * openvas/openvas_plugin.h (struct openvas_plugin): Removed elements name, copyright, cve, bid, xrefs, scripts_tags, sign_key_ids, family and version. * openvas/pdf_output.c, openvas/plugin_infos.c, openvas/prefs_dialog/prefs_dialog_plugins_prefs.c, openvas/prefs_dialog/prefs_plugins_tree.c, openvas/prefs_dialog/prefs_report.c, openvas/prefs_dialog/prefs_dialog_scan_opt.c, openvas/plugin_cache.c, openvas/filter.c, openvas/xml_output_ng.c, openvas/cli.c, openvas/comm.c, openvas/latex_output.c: Apply new method to access elements. 2009-10-12 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/prefs_dialog/prefs_report.c (fill_tree_model): Put a string ("Report is empty") in the report list if report is empty. 2009-10-12 Michael Wiegand <michael.wiegand@intevation.de> * openvas/openvas-client.c (main): Made command line options more consistent with other modules and coding standards. Short option for --verbose is now -v (was -V), short option for --version is now -V (was -v). 2009-10-10 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * openvas/Makefile: Added missing dependencies. 2009-10-09 Matthew Mundell <matthew.mundell@intevation.de> * openvas/attack.c [USE_OMP] (send_ssh_credential_files): New header. (attack_host) [USE_OMP]: Sync context plugin prefs before saving context. Free GError. Send files after sending RC. Add error dialog to omp_start_task failure. 2009-10-09 Matthew Mundell <matthew.mundell@intevation.de> * openvas/comm.c (send_ssh_credential_files): Correct doc typo. (gui_comm_send_preferences): Add free query. 2009-10-09 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> Start to replace struct openvas_plugin by nvti. * openvas/openvas_plugin.h (openvas_plugin): Added nvti_t element ni and removed description and summary. Removed proto for openvas_plugin_get_description(). * openvas/openvas_plugin.c (ni_store): New. Static store for NVTIs. (interned_strings, intern_string, openvas_plugin_get_description): Removed. (openvas_plugin_new): Handle summary and description via a nvti_t structure. (openvas_plugin_duplicate): Apply new method to access summary and description. * openvas/pdf_output.c (print_plugin_information), openvas/plugin_infos.c (plugin_info_window_setup), openvas/plugin_cache.c (write_plugin), openvas/filter.c (filter_plugin), openvas/xml_output_ng.c (xml_plugins_plugin), openvas/cli.c (_cli_sql_dump_plugins, _cli_dump_plugins): Apply new method to access summary and description. 2009-10-09 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * openvas/comm.c (omp_get_nvt_details): Removed. Functionality is now in libopenvas_omp. (fetch_new_plugins, client_omp_read_plugins): Adjusted call accordingly. 2009-10-09 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> Replaced self-made list "struct missing_plugins_list" by a GSList. missing_plugin_list was actually a struct with a array inside, thats why some protos change here as well. * openvas/comm.c (comm_get_plugins_md5, add_md5sum_to_plugin): Changed data pointer from void * to void **. (struct missing_plugins_list, missing_plugins_list_init, missing_plugins_list_add, missing_plugins_list_free): Removed. (update_existing_plugin): Changed data pointer from void * to void **. Handle the GSList instead of struct missing_plugins_list. (fetch_new_plugins, update_individual_plugins): Handle the GSList instead of struct missing_plugins_list. 2009-10-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/preferences.c (preferences_init): Reformatted. (preferences_get_filename): Reformatted, doc. (prefs_add_subcategory): Reformatted, added todo about possible memleak. (prefs_get_pluginset): Reformatted. 2009-10-09 Michael Wiegand <michael.wiegand@greenbone.net> * openvas/preferences.c (prefs_buffer_parse): Don't drop preferences just because they are empty. Should solve the "disappearing preferences" issue in OMP mode. Thanks to Felix Wolfsteller for isolating this bug. 2009-10-09 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * openvas/openvas_plugin.c (openvas_plugin_free): Removed. It was an empty function anyway and the whole openvas_plugin structure needs to be resolved based on nvti_t anyway. * openvas/openvas_plugin.h: Removed proto accordingly. * openvas/comm.c (remove_outdated_plugins), openvas/context.c (context_reset_plugins): Deactivated call of openvas_plugin_free. 2009-10-09 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * openvasclient-mkcert.in: Changed Paris to Berlin for the default. 2009-10-09 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * openvas/preferences.c (prefs_get_openvashome): Use g_get_home_dir() instead of trying on our own. (dlopen, dlsym, dlclose, w32_shgetfolderpath, standard_homedir): Removed. These all were only trying to assist finding the homedir on our own. 2009-10-09 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * openvas/preferences.c (prefs_get_default): Use g_get_user_name() instead of own function to determine username. (get_username): Removed. 2009-10-08 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * openvas/prefs_dialog/prefs_scope_tree.c (scopetree_add_new_with_parent): Renamed scope to task for OMP. 2009-10-08 Matthew Mundell <matthew.mundell@intevation.de> * openvas/prefs_dialog/prefs_scope_tree.c (scopetree_new_with_parent/scopetree_add_new_with_parent) [USE_OMP]: Note error in g_file_get_contents fail handling. Check omp_modify_task return. 2009-10-08 Matthew Mundell <matthew.mundell@intevation.de> * openvas/openvas-client.c [USE_OMP] (refresh_server): Remove context_save_recurse. * openvas/prefs_dialog/prefs_scope_tree.c [USE_OMP] (scopetree_refresh): Call context_save_recurse after prefs_context_update after refresh_server, so that plugin prefs are synced before the RC is saved. 2009-10-07 Matthew Mundell <matthew.mundell@intevation.de> * openvas/prefs_dialog/prefs_scope_tree.c [USE_OMP] (create_omp_scope): Ensure RC contains correct name. Free strings used to set ID in RC. 2009-10-07 Matthew Mundell <matthew.mundell@intevation.de> * openvas/prefs_dialog/prefs_dialog_auth.c (prefs_dialog_auth_do_connect): Add const to return and err. (prefs_dialog_auth_connect_dialog): Add const to err. * openvas/cli.c (cli_connect_to_scanner): Add const to err. 2009-10-07 Matthew Mundell <matthew.mundell@intevation.de> * openvas/cli.c: Flush trailing whitespace. 2009-10-07 Matthew Mundell <matthew.mundell@intevation.de> * openvas/context.c (context_new, context_add) [DISABLE_OMP]: Name new scopes "unnamed task". 2009-10-07 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * openvas/openvas-client.c (connect_to_scanner): Changed return value to be const. * openvas/openvas-client.c: Updated proto accordingly. 2009-10-07 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * openvas/context.c (context_collect, context_new, context_add, context_collect_servers), openvas/openvas-client.c (main), openvas/pdf_output.c (arglist_to_pdf), openvas/preferences.c (prefs_get_default), openvas/prefs_dialog/prefs_scope_tree.c (create_omp_scope): Renamed key "nessus_dir" to "openvas_dir". 2009-10-07 Matthew Mundell <matthew.mundell@intevation.de> * ChangeLog: Mark USE_OMP in last few logs. 2009-10-07 Matthew Mundell <matthew.mundell@intevation.de> * openvas/prefs_dialog/prefs_scope_tree.c [USE_OMP] (create_omp_scope): Convert NULL returns to ints. Use show_error instead of show_error_and_wait. Add missing success return. Put the final g_free in an else. 2009-10-06 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * openvas/prefs_dialog/prefs_scope_tree.c (scope_menu_save): Renamed default filename from nessusrc to openvasrc. 2009-10-06 Matthew Mundell <matthew.mundell@intevation.de> * openvas/prefs_dialog/prefs_scope_tree.c [USE_OMP] (create_omp_scope): Symlink NVT cache instead of copying it. Turn off saving of report NVT cache. * openvas/context.c (context_new) [USE_OMP]: Symlink NVT to parent cache instead of saving cache to disk. 2009-10-06 Matthew Mundell <matthew.mundell@intevation.de> * openvas/prefs_dialog/prefs_scope_tree.c (scopetree_refresh) [USE_OMP]: Remove verbose flag setting. Correct indentation. * openvas/openvas-client.c [USE_OMP] (refresh_server): Save context to disk afterwards, so that new scopes can copy it. 2009-10-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> * include/config.h.in: Set ENABLE_SAFE_TESTS to 0. * src/gui/nvt_prefs_sshlogin.h, src/util/openvas_ssh_key_create.c: Include config.h to include exactly the same context as in other places. 2009-10-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/prefs_dialog/prefs_dialog_auth.c (prefs_dialog_auth_connect_dialog): Initialize variables with NULL. * openvas/prefs_dialog/prefs_context.c (prefs_context_update_widgets): Guard CONTEXT_SERVER which is only defined if configured with --enable-omp. 2009-09-30 Matthew Mundell <matthew.mundell@intevation.de> * openvas/prefs_dialog/prefs_dialog.c (prefs_dialog_setup): Only define subsubmenu for OTP. Only create Scope->Open, Scope->"Save As" and Report->Import for OTP. * openvas/prefs_dialog/prefs_context.c (prefs_context_update_widgets): Turn off the last type and action check when OMP is enabled. With OMP and OTP compiled, only enable Scope->Open, Scope->"Save As", Scope->"Move to task" and Report->Import in OTP contexts. Only handle Scope->Open, Scope->"Save As" and Scope->"Move to task" for OTP. * openvas/prefs_dialog/prefs_scope_tree.c (scope_create_treestore): Only define global for OTP. (scopetree_add_new_with_parent/scopetree_new_with_parent): Remove the parentscope USE_OMP special case when appending the context. In the ensure_context_connected fail case show an error and continue like the success case. 2009-09-30 Matthew Mundell <matthew.mundell@intevation.de> Make Scope->New behave like the new button, for OMP. * openvas/prefs_dialog/prefs_scope_tree.c [USE_OMP] (ensure_context_connected): Move up. (scopetree_add_new_with_parent) [USE_OMP]: Move the body of server_menu_new here for new scope case. (server_menu_new) [USE_OMP]: For CONTEXT_SERVER call scopetree_new like the other cases do. 2009-09-30 Matthew Mundell <matthew.mundell@intevation.de> * openvas/context.c: Correct comment typo. 2009-09-30 Matthew Mundell <matthew.mundell@intevation.de> * MANIFEST: Add openvas/openvas-client_log.conf. 2009-09-30 Matthew Mundell <matthew.mundell@intevation.de> * openvas/openvas-client_log.conf: New file. 2009-09-30 Matthew Mundell <matthew.mundell@intevation.de> * configure: Update. 2009-09-30 Matthew Mundell <matthew.mundell@intevation.de> * openvas/openvas-client.c (log_config): New variable. (main): Setup glib logging. * configure.in: Setup OPENVASCLIENT_CONFDIR. * openvas.tmpl.in: Setup OPENVASCLIENT_CONFDIR. * openvas/Makefile (openvas-client.o): Pass OPENVASCLIENT_CONFDIR to CC. * Makefile (install-conf): New rule. (install): Depend on install-conf. 2009-09-30 Matthew Mundell <matthew.mundell@intevation.de> * configure.in: Flush trailing whitespace. 2009-09-30 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> Post-release version bump. * VERSION: Set to 3.0.0.beta2.SVN. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. 2009-09-30 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> Last minute fix. * MANIFEST: Updated. 2009-09-30 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> Preparing the openvas-client 3.0.0-beta1 release. * VERSION: Set to 3.0.0.beta1 * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. * CHANGES: Updated. 2009-09-30 Matthew Mundell <matthew.mundell@intevation.de> * openvas/prefs_dialog/prefs_context.c (prefs_context_update_widgets) [USE_OMP]: Grey out connection buttons for servers. 2009-09-30 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * AUTHORS: Updated. 2009-09-30 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * packaging/fedora/openvas-client-1.0.3-1.fc8.openvas.spec, packaging/opensuse/openvas-client-1.0.3-1.suse102.openvas.spec, packaging/fedora/, packaging/opensuse/, packaging/w32/make-installer-openvas.sh, packaging/w32/README.txt, packaging/w32/openvasclient+gtk.iss.in, packaging/w32: Removed. These are very old packaging files. Apart from this, packaging is now kept separate. * MANIFEST: Updated. 2009-09-29 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * COPYING.README: Removed entries about libnessus and gdchart because both parts have been removed from this module. 2009-09-29 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * po/de.po: Updateing german translation. 2009-09-29 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * po/POTFILES: Updated according to name changes. * po/es.po, po/fr.po, po/de.po, po/sv.po, po/hr.po, po/he.po: Newly generated. 2009-09-29 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * COPYING.README, tools/openvas1_to_openvas2.sh, po/Makefile, po/README, openvas/sighand.c, openvas/report.c, openvas/preferences.h, openvas/preferences.c, openvas/pdf_output.h, openvas/pdf_output.c, openvas/openvas_i18n.h, openvas/openvas-client.c, openvas/context.h, openvas/context.c, include/config.w32, openvas/prefs_dialog/prefs_comment.c, openvas/prefs_dialog/prefs_comment.h, openvas/prefs_dialog/prefs_context.c, openvas/prefs_dialog/prefs_context.h, openvas/prefs_dialog/prefs_dialog_auth.c, openvas/prefs_dialog/prefs_dialog_auth.h, openvas/prefs_dialog/prefs_dialog.c, openvas/prefs_dialog/prefs_dialog_prefs.c, openvas/prefs_dialog/prefs_dialog_prefs.h, openvas/prefs_dialog/prefs_options.c, openvas/prefs_dialog/prefs_options.h, openvas/prefs_dialog/prefs_report.c, openvas/prefs_dialog/prefs_report.h, openvas/prefs_dialog/prefs_scan_assistant.c, openvas/prefs_dialog/prefs_scan_assistant.h, openvas/prefs_dialog/prefs_scope_tree.c, openvas/prefs_dialog/prefs_scope_tree.h, openvas/prefs_dialog/readonly.c, openvas/prefs_dialog/readonly.h: Copyright transfer from Intevation to Greenbone. 2009-09-29 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/prefs_dialog/prefs_context.c (prefs_context_update_widgets): Re-enabled state change of some menu items if configured with --disable-otp. Removed obsolete "if 0"-Block. * openvas/prefs_dialog/prefs_scope_tree.c (set_cell_context_type): Dispaly scopes type as "task" if configured with --disable-otp. * configure: Regenerated. 2009-09-29 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/prefs_dialog/prefs_scope_tree.c (scope_create_treestore): Only not perform certain actions if configured with --disable-otp. 2009-09-29 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/prefs_dialog/prefs_scope_tree.c (scope_create_treestore_children): If configured with --disable-otp, do not anything to the (non-existing) move-scope menu. 2009-09-29 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/prefs_dialog/prefs_scope_tree.c: Replaced K&R function decls., Cosmetics. 2009-09-29 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/prefs_dialog/prefs_context.c: Replaced K&R function decls, cosmetics. 2009-09-29 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/openvas-client.c (main): If configured with --disable-otp, do not collect otp contexts. * openvas/prefs_dialog/prefs_dialog.c (prefs_dialog_setup): Also skip "Scan Assistant" menu entry and toolbar element if configured with "--disable-otp . * openvas/prefs_dialog/prefs_dialog_prefs.c (prefs_dialog_prefs): Do not show otp related preference options if configured with --disable-otp. 2009-09-29 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added a flag to configure that will hide some OTP-related GUI elements. * configure.in, openvas/Makefile, openvas.tmpl.in: Added disable-otp flags. * openvas/prefs_dialog/prefs_context.c, openvas/prefs_dialog/prefs_dialog.c: Respect disable_otp flags (do not display otp related gui elements). 2009-09-29 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/prefs_dialog/prefs_context.c: Cosmetics. 2009-09-29 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/prefs_dialog/prefs_scope_tree.c, openvas/context.c: Cosmetics, added todos. * openvas/backend.c: Cosmetics 2009-09-29 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/preferences.c: Cosmetics. 2009-09-29 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/prefs_dialog/prefs_dialog_auth.c: Replaced K&R function decls. 2009-09-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/util/openvas_lsc_user_makensis.c, src/util/openvas_ssh_key_create.c, src/util/openvas_ssh_rpm.c, src/util/openvas_lsc_user_deb.c: Cleaned up include mess, minor cosmetics. 2009-09-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/omp-cli.c: Adjusted omp- includes. 2009-09-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> Adjusted includes to changed installation location for header of openvas-libraries/omp. * openvas/attack.c, openvas/comm.c, openvas/context.c, openvas/monitor_dialog.c, openvas/openvas-client.c, openvas/prefs_dialog/prefs_scope_tree.c: Adjusted includes. 2009-09-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/comm.c (comm_parse_certificate, comm_get_certificates), openvas/contex.c (context_new), openvas/context.h, openvas/pdf_output.c (print_plugin_information_signatures), openvas/plugin_infos.c (create_certificate_list, showcert): Switch from openvas_certificate to certificate implementation. 2009-09-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/openvas-client.c: Adjusted includes (modules from base now get installed to openvas/base). 2009-09-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/backend.c, openvas/data_mining.c, openvas/report.c, openvas/prefs_dialog/prefs_dialog.c, openvas/prefs_dialog/prefs_report.c, openvas/prefs_dialog/prefs_scope_tree, src/gui/severityfiltermngr_dlg.c, src/gui/severity_override_form.h: Adjusted includes (modules from base now get installed to openvas/base). 2009-09-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> * include/includes.h: Remove conditioned include of harglists.h 2009-09-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> * configure: Regenerated. 2009-09-23 Matthew Mundell <matthew.mundell@intevation.de> * openvas/openvas-client.c (connect_to_scanner) [USE_OMP]: Duplicate the password, as it's freed later. Free it before returning, like the OTP cases. 2009-09-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> * openvas/attack.c, openvas/openvas-client.c, openvas/parser.c, openvas/preferences.c, openvas/prefs_dialog/prefs_help.h: Replaced openvasd by openvassd, server by scanner. 2009-09-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> * include/ntcompat.h, openvas.tmpl.in, doc/nbe_file_format.txt, doc/openvasclient-mkcert.1, openvas/comm.c, openvas/parser.c, include/includes.h: Replaced nessus by OpenVAS, server by scanner. * configure.in: Replaced nessus by openvas, removed substitution of nessus_lib (not needed anymore). 2009-09-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> * include/config.h.in: Replaced Nessus by OpenVAS, removed condition on ENABLE_CRYPTO_LAYER, removed undef of DEFAULT_PORT (both never used). * openvas/cli.c, openvas/openvas-client.c, openvas/prefs_dialog/prefs_dialog_auth.c: Removed reference to ENABLE_CRYPTO_LAYER. 2009-09-22 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * MANIFEST: Updated. 2009-09-22 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * src/gui/about_dlg.c (about_dialog): Added Matthew as author and Greenbone as supporter. * src/xpm/logo_greenbone.xpm: New. 2009-09-22 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * src/Makefile, src/README_SRC, src/gui/about_dlg.c, src/gui/about_dlg.h, src/gui/error_dlg.c, src/gui/error_dlg.h, src/gui/Makefile, src/gui/nvt_pref_sshlogin.c, src/gui/nvt_pref_sshlogin.h, src/gui/severityfiltermngr_dlg.c, src/gui/severityfiltermngr_dlg.h, src/gui/severity_override_form.c, src/gui/severity_override_form.h, src/gui/ssh_key_info_form.c, src/gui/ssh_key_info_form.h, src/gui/ssh_keys_dialog.c, src/gui/ssh_keys_dialog.h, src/util/file_utils.c, src/util/file_utils.h, src/util/Makefile, src/util/openvas-socket.c, src/util/openvas-socket.h: Copyright transfer from Intevation to Greenbone. 2009-09-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> * doc/Doxyfile, doc/Doxyfile_full: Adjusted input paths to move of nessus to openvas. * doc/openvasclient-mkcert.1: Replaced nessus by openvas, adjusted links to website. 2009-09-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> Moved 'nessus' directory - now 'openvas' directory. * nessus/: (re)moved. * openvas/: Moved from nessus. * Makefile: Adjusted. * src/gui/Makefile, src/util/Makefile: Adjusted and removed non-existat include directories. * MANIFEST: Updated 2009-09-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> Renamed nessus module to openvas-client. * nessus/nessus.c, nessus/nessus.h: (re)Moved. * nessus/openvas-client.c, nessus/openvas-client.h: Moved from nessus/nesuss.[h|c]. * nessus/openvas-client.c, nessus/preferences.c, nessus/prefs_dialog/prefs_dialog_auth.c, nessus/prefs_dialog/prefs_context.c, nessus/prefs_dialog/prefs_scope_tree.c, nessus/cli.c: Adjusted include. * Makefile: Adjusted. 2009-09-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_scan_assistant.c (scan_assistant_create_dialog): Replaced "Nessus Server" by "OpenVAS Scanner". * src/gui/nvt_pref_sshlogin.c, nessus/prefs_dialog/prefs_dialog_auth.c: Added missing includes. 2009-09-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/globals.h, nessus/globals.w32, nessus/backend.h: Minor cosmetics. 2009-09-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/html_output.c: In comment, replaced nessus by openvas. * nessus/monitor_dialog.c: In comment, replaced NessusClient by OpenVAS-Client. 2009-09-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/parser.c (parse_server_error): In comment changed server to scanner. * nessus/openvas_plugin.c (openvas_plugin_free): Changed nessus_plugin to openvas_plugin in comments. 2009-09-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/nessus.c: Added missing include. (connect_to_scanner): Removed unused local variable. 2009-09-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> * Makefile: Removed ALLDEPS target, instead add openvas.tmpl as dependency to the all target, removed src/openvas-lib from clean target as directory has been removed. 2009-09-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/attack.c, nessus/auth.c, nessus/backend.c, nessus/cli.c, nessus/comm.c, nessus/parser.c, nessus/sighand.c, nessus/subset.c: Added missing includes. 2009-09-22 Matthew Mundell <matthew.mundell@intevation.de> * nessus/nessus.c (main) [USE_OMP]: Ensure the servers directory exists before collecting the servers. 2009-09-22 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * configure: Updated. 2009-09-22 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * ssl/openvasclient-mkrand.c, ssl/Makefile, ssl/, doc/openvasclient-mkrand.1: Removed. It is not the task of the openvas-client to try to take care of entropy. * Makefile: Removed handling for openvasclient-mkrand. It was only build, not installed anyway. * MANIFEST: Updated. 2009-09-21 Matthew Mundell <matthew.mundell@intevation.de> * src/nessus/context.c (context_delete) [USE_OMP]: Break instead of returning, so that the recursive case works. * ChangeLog: Move last entry up. 2009-09-21 Matthew Mundell <matthew.mundell@intevation.de> * src/omp-cli.c (OPENVASMD_PORT): Set to 9390. (main): Shorten the OMP command example. Use two literals for the option description. Switch to openvas-libraries/omp. * src/Makefile: Switch to openvas-libraries/omp. 2009-09-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> * Makefile: Removed targets regarding src/openvas-lib. * src/openvas-lib: Removed. Content was moved to openvas-libraries. * MANIFEST: Updated. * src/gui/nvt_pref_sshlogin.c: Added missing include. 2009-09-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> * Makefile: Removed openvas_certificates and openvas_certificate_file objects and targets. * src/util/Makefile: Removed severity_filter object and target definition. * nessus/plugin_infos.c, nessus/comm.c, nessus/context.h: Changed include (openvas_certificates -> openvas_certificate). * nessus/context.h: Added missing include. * nessus/report.c: Adjusted call to new API of openvas_certificate_file. * MANIFEST: Adjusted 2009-09-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> Moved the openvas_certificate_file module to openvas-libraries/base. * src/openvas-lib/openvas_certificate_file.c, src/openvas-lib/openvas_certificate_file.h: Moved to openvas-libraries/base. 2009-09-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/openvas-lib/openvas_certificate_file.c: Cosmetics, doc. 2009-09-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> Moved the openvas_certificates module to openvas-libraries/base. * src/openvas-lib/openvas_certificates.c, src/openvas-lib/openvas_certificates.h: Moved to openvas-libraries/base. 2009-09-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> Moved the severity_filter module to openvas-libraries/base. * src/util/severity_filter.c, src/util/severity_filter.h: Moved to openvas-libraries/base. 2009-09-21 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * openvas.tmpl.in, Makefile, configure.in, src/Makefile, nessus/sslui.h, nessus/sighand.h, nessus/report_utils.h, nessus/report_save.h, nessus/report.h, nessus/read_target_file.h, nessus/preferences.h, nessus/preferences.c, nessus/plugin_infos.h, nessus/plugin_cache.h, nessus/pdf_output.h, nessus/parser.h, nessus/openvas_plugin.h, nessus/nessus.h, nessus/nessus.c, nessus/nbe_output.h, nessus/monitor_dialog.h, nessus/latex_output.h, nessus/html_output.h, nessus/html_graph_output.h, nessus/globals.w32, nessus/globals.h, nessus/filter.h, nessus/comm.h, nessus/auth.h, include/ntcompat.h, include/config.w32, include/config.h.in, nessus/prefs_dialog/listnotebook.h, nessus/prefs_dialog/prefs_dialog_auth.h, nessus/prefs_dialog/prefs_dialog.c, nessus/prefs_dialog/prefs_dialog.h, nessus/prefs_dialog/prefs_dialog_plugins_prefs.h, nessus/prefs_dialog/prefs_dialog_prefs.h, nessus/prefs_dialog/prefs_dialog_scan_opt.h, nessus/prefs_dialog/prefs_dialog_user.h, nessus/prefs_dialog/prefs_help.h, nessus/prefs_dialog/prefs_plugins.h, nessus/prefs_dialog/prefs_plugins_tree.h, nessus/prefs_dialog/prefs_target.h, src/gui/Makefile, src/openvas-lib/Makefile, src/util/Makefile, src/omp-cli.c, nessus/Makefile, include/includes.h, include/corevers.h.in: Replaced "NESSUS" by "OPENVAS". 2009-09-18 Matthew Mundell <matthew.mundell@intevation.de> * nessus/prefs_dialog/prefs_scope_tree.c (scopetree_context_new): Add a CONTEXT_GLOBAL special case for USE_OMP. 2009-09-18 Matthew Mundell <matthew.mundell@intevation.de> * nessus/attack.c, nessus/prefs_dialog/prefs_scope_tree.c, nessus/monitor_dialog.c, nessus/nessus.c: Use new libopenvas_omp names. 2009-09-18 Matthew Mundell <matthew.mundell@intevation.de> * nessus/report.c: Correct comment typo. 2009-09-18 Matthew Mundell <matthew.mundell@intevation.de> * src/omp-cli.c: Add a "--prompt" flag. When given the program prompts for a key after connecting to the manager and before closing the connection. This gives the user time to attach to the resulting manager process for inspection. 2009-09-18 Matthew Mundell <matthew.mundell@intevation.de> * nessus/comm.h, nessus/preferences.c, nessus/attack.c, nessus/Makefile, nessus/prefs_dialog/prefs_dialog.c, nessus/prefs_dialog/prefs_dialog_auth.c, nessus/prefs_dialog/prefs_context.c, nessus/prefs_dialog/prefs_scope_tree.c, nessus/monitor_dialog.c, nessus/nessus.c, nessus/context.c, nessus/context.h, nessus/comm.c, Makefile, ChangeLog: Flush trailing whitespace. Cleanup a little indenting. 2009-09-18 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> More parts of OMP support. Developed by Matthew Mundell. * nessus/context.c, nessus/comm.c, nessus/monitor_dialog.c: Added code to handle OMP aspects conditional to USE_OMP flag. 2009-09-18 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> More parts of OMP support. Developed by Matthew Mundell. * nessus/Makefile: Hand over USE_OMP flag for building. * nessus/nessus.c, nessus/prefs_dialog/prefs_context.c, nessus/prefs_dialog/prefs_scope_tree.c, nessus/prefs_dialog/prefs_scope_tree.h: Added code to handle OMP aspects conditional to USE_OMP flag. * nessus/parser.c: Added protocol samples in comment. 2009-09-18 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> More parts of OMP support. Developed by Matthew Mundell. * nessus/context.h, nessus/nessus.h: Added code to handle OMP aspects conditional to USE_OMP flag. 2009-09-18 Felix Wolfsteller <felix.wolfsteller@intevation.de> * MANIFEST: Updated, as file names have changed. 2009-09-18 Felix Wolfsteller <felix.wolfsteller@intevation.de> First part of renaming nessus_regex to openvas_regex. * nessus/nessus_regex.h, nessus/openvas_regex.h: Moved. * nessus/filter.c, nessus/regex.c: Updated includes. 2009-09-18 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/openvas_plugin.h: Adjusted include guard. 2009-09-18 Felix Wolfsteller <felix.wolfsteller@intevation.de> First part of renaming nessus_plugin to openvas_plugin. * nessus/nessus_plugin.c, nessus/nessus_plugin.h, nessus/openvas_plugin.c, nessus/openvas_plugin.h: Moved nessus_plugin to openvas_plugin. * nessus/preferences.c, nessus/attack.c, nessus/pdf_output.c, nessus/plugin_infos.c, nessus/report.c, nessus/prefs_dialog/prefs_dialog.c, nessus/prefs_dialog/prefs_dialog_plugins_prefs.c, nessus/prefs_dialog/prefs_plugins.c, nessus/prefs_dialog/prefs_plugins_tree.c, nessus/prefs_dialog/prefs_report.c, nessus/prefs_dialog/prefs_dialog_scan_opt.c, nessus/plugin_cache.c, nessus/filter.c, nessus/parser.c, nessus/xml_output_ng.c, nessus/monitor_dialog.c, nessus/cli.c, nessus/context.c, nessus/comm.c, nessus/latex_output.c, src/gui/nvt_pref_sshlogin.c: Updated includes. * nessus/Makefile: Adjusted. 2009-09-18 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/openvas_i18n.h: Adjusted include guard. 2009-09-18 Felix Wolfsteller <felix.wolfsteller@intevation.de> First part of renaming nessus_i18n to openvas_i18n in client. * nessus/nessus_i18n.h, nessus/openvas_i18n.h: Moved. * nessus/preferences.c, nessus/attack.c, nessus/sighand.c, nessus/pdf_output.c, nessus/plugin_infos.c, nessus/report.c, nessus/prefs_dialog/prefs_dialog.c, nessus/prefs_dialog/prefs_dialog_plugins_prefs.c, nessus/prefs_dialog/prefs_scan_assistant.c, nessus/prefs_dialog/prefs_dialog_auth.c, nessus/prefs_dialog/prefs_context.c, nessus/prefs_dialog/prefs_options.c, nessus/prefs_dialog/prefs_dialog_prefs.c, nessus/prefs_dialog/prefs_plugins_tree.c, nessus/prefs_dialog/prefs_comment.c, nessus/prefs_dialog/prefs_report.c, nessus/prefs_dialog/prefs_dialog_scan_opt.c, nessus/prefs_dialog/prefs_target.c, nessus/prefs_dialog/prefs_scope_tree.c, nessus/prefs_dialog/prefs_help.h, nessus/prefs_dialog/prefs_dialog_user.c, nessus/plugin_cache.c, nessus/filter.c, nessus/parser.c, nessus/sslui.c, nessus/xml_output_ng.c, nessus/html_graph_output.c, nessus/monitor_dialog.c, nessus/read_target_file.c, nessus/backend.c, nessus/report_save.c, nessus/nessus.c, nessus/context.c, nessus/comm.c, src/openvas-lib/openvas_certificate_file.h, src/gui/about_dlg.c, src/gui/ssh_key_info_form.c, src/gui/ssh_keys_dialog.c, src/gui/slad_install.c, src/gui/error_dlg.c, src/gui/nvt_pref_sshlogin.c, src/gui/severityfiltermngr_dlg.c, src/gui/severity_override_form.c, src/util/file_utils.c, src/util/openvas_lsc_user_makensis.c, src/util/openvas_ssh_rpm.c, src/util/openvas_lsc_target_prep.c, src/util/severity_filter.c, src/util/openvas_ssh_key_create.c, src/util/openvas_lsc_user_deb.c, src/util/openvas_lsc_user_rpm.c: Updated include. 2009-09-18 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/nessus_plugin.c: Added todo/text/stub for still missing code to free the plugin structs. 2009-09-18 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * src/openvas-lib/openvas_certificate_file.h, src/openvas-lib/openvas_certificate_file.c, src/util/parseutils.h, src/util/openvas_lsc_user_makensis.c, src/util/openvas_ssh_rpm.c, src/util/openvas_lsc_target_prep.c, src/util/openvas_lsc_user_makensis.h, src/util/openvas_ssh_rpm.h, src/util/openvas_lsc_target_prep.h, src/util/severity_filter.c, src/util/openvas_ssh_key_create.c, src/util/severity_filter.h, src/util/openvas_lsc_user_deb.c, src/util/openvas_ssh_key_create.h, src/util/openvas_lsc_user_rpm.c, src/util/openvas_lsc_user_deb.h, src/util/parseutils.c, src/util/openvas_lsc_user_rpm.h: Copyright transfer from Intevation to Greenbone. 2009-09-17 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> More parts of OMP support. Developed by Matthew Mundell. * nessus/preferences.c, nessus/attack.c: Added code to handle OMP aspects conditional to USE_OMP flag. 2009-09-17 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * nessus/prefs_dialog/prefs_report.c (row_activated): Added note in code on wrong behaviour in case absence of valid plugin. Spotted by Matthew Mundell. 2009-09-17 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> First parts of OMP support. Developed by Matthew Mundell. * openvas.tmpl.in: Added handling of USE_OMP flag. * nessus/prefs_dialog/prefs_dialog.c, nessus/prefs_dialog/prefs_dialog_auth.c, nessus/prefs_dialog/prefs_dialog_auth.h: Added code to handle OMP aspects conditional to USE_OMP flag. 2009-09-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removing the "OpenSSL-exception statement" and references to it. OpenVAS-Client does not link against openssl anymore. * COPYING.OpenSSL, nessus/COPYING.OpenSSL: Removed. * src/openvas-lib/Makefile, src/gui/Makefile, src/util/Makefile: Removed the OpenSSL-exception statement. * COPYING.README: Removed references to the OpenSSL-exception statement, updated text, as (parts of) openvas-libraries are not included in the openvas-client source tree anymore. * MANIFEST: Updated. 2009-09-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removing the "OpenSSL-exception" from source files (the exception itself allows to do so). OpenVAS-Client does not link against openssl anymore. * nessus/sighand.c, nessus/sighand.h, nessus/prefs_dialog/prefs_dialog.c, nessus/prefs_dialog/prefs_dialog_plugins_prefs.c, nessus/prefs_dialog/prefs_kb.h, nessus/prefs_dialog/prefs_dialog_user.h, nessus/prefs_dialog/prefs_dialog.h, nessus/prefs_dialog/prefs_dialog_plugins_prefs.h, nessus/prefs_dialog/prefs_scan_assistant.c, nessus/prefs_dialog/prefs_dialog_auth.c, nessus/prefs_dialog/prefs_plugins.c, nessus/prefs_dialog/prefs_scan_assistant.h, nessus/prefs_dialog/prefs_context.c, nessus/prefs_dialog/prefs_dialog_auth.h, nessus/prefs_dialog/prefs_plugins.h, nessus/prefs_dialog/prefs_context.h, nessus/prefs_dialog/prefs_options.c, nessus/prefs_dialog/prefs_dialog_prefs.c, nessus/prefs_dialog/prefs_options.h, nessus/prefs_dialog/prefs_plugins_tree.c, nessus/prefs_dialog/prefs_comment.c, nessus/prefs_dialog/prefs_dialog_prefs.h, nessus/prefs_dialog/prefs_plugins_tree.h, nessus/prefs_dialog/prefs_comment.h, nessus/prefs_dialog/prefs_report.c, nessus/prefs_dialog/listnotebook.c, nessus/prefs_dialog/readonly.c, nessus/prefs_dialog/prefs_report.h, nessus/prefs_dialog/listnotebook.h, nessus/prefs_dialog/readonly.h, nessus/prefs_dialog/prefs_dialog_scan_opt.c, nessus/prefs_dialog/prefs_target.c, nessus/prefs_dialog/prefs_scope_tree.c, nessus/prefs_dialog/prefs_dialog_scan_opt.h, nessus/prefs_dialog/prefs_target.h, nessus/prefs_dialog/prefs_kb.c, nessus/prefs_dialog/prefs_help.h, nessus/prefs_dialog/prefs_dialog_user.c, nessus/prefs_dialog/prefs_scope_tree.h, nessus/nessus_plugin.c, nessus/nessus_plugin.h, nessus/xml_output_ng.c, nessus/text_output.c, nessus/monitor_dialog.c, nessus/xml_output_ng.h, nessus/text_output.h, nessus/monitor_dialog.h, nessus/nessus_regex.h, nessus/report_utils.c, nessus/report_utils.h, nessus/subset.c, nessus/regex.c, nessus/subset.h, src/openvas-lib/openvas_certificates.c, src/openvas-lib/openvas_certificate_file.h, src/openvas-lib/openvas_certificates.h, src/openvas-lib/openvas_certificate_file.c, src/gui/nvt_pref_sshlogin.h, src/gui/severityfiltermngr_dlg.h, src/gui/about_dlg.c, src/gui/severity_override_form.h, src/gui/ssh_key_info_form.c, src/gui/about_dlg.h, src/gui/ssh_keys_dialog.c, src/gui/ssh_key_info_form.h, src/gui/slad_install.c, src/gui/ssh_keys_dialog.h, src/gui/slad_install.h, src/gui/error_dlg.c, src/gui/error_dlg.h, src/gui/treeview_support.c, src/gui/nvt_pref_sshlogin.c, src/gui/severityfiltermngr_dlg.c, src/gui/treeview_support.h, src/gui/severity_override_form.c, src/util/file_utils.c, src/util/parseutils.h, src/util/openvas-socket.c, src/util/file_utils.h, src/util/openvas_lsc_user_makensis.c, src/util/openvas-socket.h, src/util/openvas_ssh_rpm.c, src/util/openvas_lsc_target_prep.c, src/util/openvas_lsc_user_makensis.h, src/util/openvas_ssh_rpm.h, src/util/openvas_lsc_target_prep.h, src/util/severity_filter.c, src/util/openvas_ssh_key_create.c, src/util/severity_filter.h, src/util/openvas_lsc_user_deb.c, src/util/openvas_ssh_key_create.h, src/util/openvas_lsc_user_rpm.c, src/util/openvas_lsc_user_deb.h, src/util/parseutils.c, src/util/openvas_lsc_user_rpm.h: Removed OpenSSL-exception from header. 2009-09-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removing the "OpenSSL-exception" from source files (the exception itself allows to do so). OpenVAS-Client does not link against openssl anymore. * nessus/attack.c, nessus/attack.h, nessus/auth.c, nessus/auth.h, nessus/backend.c, nessus/backend.h, nessus/cli.c, nessus/cli.h, nessus/comm.c, nessus/comm.h, nessus/context.c, nessus/context.h, nessus/data_mining.c, nessus/data_mining.h, nessus/filter.c, nessus/filter.h, nessus/html_graph_output.c, nessus/html_graph_output.h, nessus/html_output.c, nessus/html_output.h, nessus/latex_output.c, nessus/latex_output.h, nessus/nbe_output.c, nessus/nbe_output.h, nessus/nessus.c, nessus/nessus.h, nessus/parser.c, nessus/parser.h, nessus/pdf_output.c, nessus/pdf_output.h, nessus/plugin_cache.c, nessus/plugin_cache.h, nessus/plugin_infos.c, nessus/plugin_infos.h, nessus/preferences.c, nessus/preferences.h, nessus/read_target_file.c, nessus/read_target_file.h, nessus/report.c, nessus/report.h, nessus/report_save.c, nessus/report_save.h, nessus/sslui.c, nessus/sslui.h: Removed OpenSSL-exception from header. 2009-09-17 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * nessus/prefs_dialog/prefs_dialog_auth.c: Fixed includes. 2009-09-16 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * nessus/sighand.h, nessus/preferences.h, nessus/plugin_infos.h, nessus/parser.h, nessus/nessus_plugin.h, nessus/nessus.h, nessus/filter.h, nessus/context.h, nessus/cli.h, nessus/prefs_dialog/prefs_dialog.h, src/util/openvas_ssh_rpm.c, src/util/openvas_lsc_user_rpm.c, src/util/openvas_lsc_user_makensis.c, src/util/openvas_lsc_user_deb.c, src/util/openvas_lsc_target_prep.c, src/gui/ssh_keys_dialog.c, src/gui/ssh_key_info_form.c, src/gui/severity_override_form.c, src/gui/severityfiltermngr_dlg.c, nessus/prefs_dialog/prefs_report.c, nessus/preferences.c, nessus/prefs_dialog/prefs_plugins_tree.c, nessus/prefs_dialog/prefs_plugins.c, nessus/report.c, nessus/prefs_dialog/prefs_dialog_scan_opt.c, nessus/prefs_dialog/prefs_dialog_plugins_prefs.c, nessus/prefs_dialog/prefs_dialog.c, nessus/sighand.c, nessus/prefs_dialog/prefs_dialog_auth.c, nessus/xml_output_ng.c, nessus/plugin_infos.c, nessus/plugin_cache.c, nessus/pdf_output.c, nessus/parser.c, nessus/nessus_plugin.c, nessus/nessus.c, nessus/monitor_dialog.c, nessus/latex_output.c, nessus/filter.c, nessus/context.c, nessus/comm.c, nessus/cli.c, nessus/attack.c: Replaced "nessus" by "openvas" in function and struct names. 2009-09-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.c: Added todo about possible incorrect freeing/memleak. 2009-09-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/cli.c: Replaced K&R function declarations, cosmetics. * nessus/context.c, nessus/prefs_dialog/prefs_options.c: Reformatting, doc. * nessus/monitor_dialog.h, nessus/nbe_output.c, nessus/parser.c, nessus/prefs_dialog/prefs_comment.c, nessus/prefs_dialog/prefs_dialog.c, nessus/prefs_dialog/prefs_scope_tree.h, nessus/prefs_dialog/readonly.c: Minor cleanup. * nessus/plugin_cache.c: Reformatting. * nessus/prefs_dialog/prefs_dialog_plugin_prefs.c: Doc, cleanup. Added todos, as there seems to be a bug when just one plugin exists. 2009-09-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/report.c: Doc. * nessus/report_utils.c: Made todo appearing in doxygen-generated todo- list, reformatted. * nessus/report_save.c: Use gchar/gfree consistently, doc. * nessus/attack.h: Added include guard. 2009-09-16 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * Makefile: Fixed typo. Spotted by Matthew Mundell. 2009-09-16 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * configure.in: Add option --enable-omp. Developed by Matthew Mundell. * configure: updated. 2009-09-15 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * nessus.tmpl.in: Renamed to openvas.tmpl.in. * configure.in, Makefile, nessus/Makefile, src/Makefile, po/Makefile, ssl/Makefile, src/gui/Makefile, src/openvas-lib/Makefile, src/util/Makefile: Adjusted accordingly. * MANIFEST: Updated. 2009-09-15 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * libnessus/network.h, libnessus/COPYING, libnessus/network.c, libnessus/Makefile, libnessus/: Removed. * include/libnessus.h: Removed. * MANIFEST: Updated. 2009-09-15 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * configure: Updated. 2009-09-14 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> Migration from OpenSSL to GNUTLS, according to Change Request #35 (http://www.openvas.org/openvas-cr-35.html). This patch was developed by Marcus Brinkmann. * nessus.tmpl.in: Removes explicit handling of ssl. * doc/Doxyfile, doc/Doxyfile_full, Makefile: Removed handling of libnessus. * nessus/Makefile: Removed explicit handling of ssl and libnessus. * nessus/sslui.c (sslui_check_cert): Migrated from OpenSSL to GNUTLS. * nessus/sslui.h: Adjusted proto accordingly. * nessus/nessus.c (verify_callback): Removed. (get_server_cert_hash, print_hash, set_server_cert_hash): Added parameter hashlen and changed meaning of parameter hash. (set_gnutls_sslv23, set_gnutls_sslv3, set_gnutls_tlsv1, verify_certificate): New. (connect_to_nessusd): Migrated from OpenSSL to GNUTLS. (main): Initialized SSL. * nessus/nessus.h: Removed unneeded define for SSL_VER_DEF_METH. * include/includes.h: Migrated from OpenSSL to GNUTLS. Removed libnessus. * include/libnessus.h: Adjusted protos and migrated from OpenSSL to GNUTLS. * configure.in: Remove OpenSSL handling. Also, SSL is mandatory anyway. 2009-09-14 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * nessus/backend.c (backend_convert): Fix calls of efree(). This bug has been spotted and fixed by Marcus Brinkmann. * nessus/xml_output_ng.c (xml_results_result_ports): Don't use standard function names like "free" as variable name! Spotted and fixed by Marcus Brinkmann. 2009-09-14 Michael Wiegand <michael.wiegand@intevation.de> Repairing and updating openvasclient-mkcert. * openvasclient-mkcert.in: Improved gettext detection. Improved detection of server directories. Harmonised openvasclient-mkcert with openvas-server/openvas-mkcert-client; ultimately one of the two scripts should be removed. 2009-09-11 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * configure.in: Upgraded dependency for glib from 2.6 to 2.12 according to CR#38. Upgraded dependency for openvas-libraries from 2.0.3 to 2.1.0 due to the recent comprehensive changes. * configure: Updated. 2009-09-10 Michael Wiegand <michael.wiegand@intevation.de> Repairing and updating openvasclient-mkcert. * openvasclient-mkcert.in: Change signature algorithm from MD5 to SHA1 since GnuTLS classifies the use of MD5 as an insecure in this context. 2009-09-10 Michael Wiegand <michael.wiegand@intevation.de> Repairing and updating openvasclient-mkcert. * openvasclient-mkcert.in: Set $TMPDIR if necessary. Don't create the obsolete user plugins directory. 2009-09-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> * doc/Doxyfile, doc/Doxyfile_full: Added alias to generate todo list from both lower and uppercase @TODOs. 2009-09-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed last occurance of harglists in openvas-client. * nessus/backend.c (backend_convert): Include hash_table_util, add report arglists to GHashTable instead of harglist and do the sorting in the list of keys instead of in the harglist directly. * nessus/backend.c (_backend_cmpcb, compare_ip_hostname): Renamed and changed signature, as it is now used as GCompareFunc. 2009-09-08 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/backend.c: Removed include to yet non-existant file, preparations to (last) harglist - removal from openvas-client. 2009-09-08 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/backend.c (_backend_cmpcb): Reformatted. * nessus/backend.c (backend_convert): Minor cosmetics. 2009-09-07 Felix Wolfsteller <felix.wolfsteller@intevation.de> Replaced the harglist that was used in contexts by a GHashTable. * nessus/context.h: Changed type of "sessions" from harglst to GHashTable. * nessus/cli.c (cli_list_sessions): Use g_hash_table_foreach instead of hargwalker, broke up conditional. * nessus/cli.c (print_session): Callback for g_hash_table_foreach, prints key and value. * nessus/comm.c (comm_get_sessions): Assembles GHashTable instead of harglst. * nessus/comm.h (comm_get_sessions): Changed return type in proto. 2009-09-07 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/cli.c (cli_list_sessions): Refomatted. 2009-09-07 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/backend.c: Minor reformatting. * nessus/comm.c (comm_get_sessions): Reformatted. 2009-09-07 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed arglists implementation, now complete in openvas-libraries/misc. * include/libnessus.h: Include arglist.h, remove declaration of arglist and functions. * libnessus/arglists.c: Removed (is in openvas-libraries/misc). * libnessus/Makefile: Removed arglist object from OBJS list. 2009-08-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> * libnessus/network.c (recv_line, nessus_deregister_connection): Removed code duplicate. * nessus/nessus.c: Added missing include, resolves compiler warning. * nessus/nessus.c (connect_to_nessusd): Corrected overargumented function call, (but still passes wrong argument type). 2009-08-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> * libnessus/network.c (stream_zero, stream_set, stream_isset, os_send, os_recv): Removed unproblematic duplicate code (now linked; in openvas-libraries/misc/network.c). Note that removing other duplicates in this file might still break things. 2009-08-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> * libnessus/arglists.c (arg_free_name, arg_add_value, arg_get, arg_set_value, arg_set_type, arg_get_value, arg_get_length, arg_get_type, arg_dup, arg_dump, arg_free, arg_free_all): Removed duplicate code (now linked; in openvas-libraries/misc/arglists.c). 2009-08-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> * libnessus/arglists.c (mkhash_arglists): Switched to hash algorithm provided by glib. 2009-08-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> Moved libnessus/openvas-socket to src/util. * libnessus/openvas-socket.c, libnessus/openvas-socket.h, src/util/openvas-socket.c, src/util/openvas-socket.h: Moved files from libnessus to src/util. * src/util/Makefile: Added openvas-socket to OBJS list and created target. * nessus/Makefile: Added openvas-socket to UTIL_OBJS. * libnessus/Makefile: Removed target for openvas-socket, added src/util to include path. 2009-08-26 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * libnessus/network.c (open_sock_opt_hn): Removed. The corresponding function of libopenvasmisc is now used. This resolves a compilation error regarding nn_resolve. 2009-08-26 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> Adding patch to support IPv6 connections between OpenVAS-Client and OpenVAS Server. The patch was developed by Srinivasa NL. * libnessus/network.c (open_socket, open_sock_opt_hn): Added support for ipv6. * nessus/nessus.c (connect_to_nessusd): Use new style of nn_resolve (supporting ipv6). 2009-08-26 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * include/libnessus.h: Removed proto for nn_resolve. 2009-08-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> * libnessus/Makefile: Removed CIPHER_SUBDIR and references to it (was never defined). * libnessus/Makefile: Replaced occurences of NESSUSCLIENT by OPENVASCLIENT. 2009-08-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> Further clean ups (Change Request #37, http://www.openvas.org/openvas-cr-37.html) * include/harglists.h: Removed. * MANIFEST: Updated. 2009-08-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> Further clean ups (Change Request #37, http://www.openvas.org/openvas-cr-37.html) * libnessus/addslashes.c: Removed, functionality provided by openvas-libraries/misc/plugutils module. * libnessus/system.c, libnessus/system.h: Removed, functionality provided by openvas-libraries/misc/system.[c|h]. * libnessus/Makefile: Removed targets. * ChangeLog: Corrected. 2009-08-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cleaning up alongside Change Request #37 (http://www.openvas.org/openvas-cr-37.html), removing duplicated functionality. * libnessus/harglists.c, libnessus/hlst.c, libnessus/hlst.h: Removed, although not strictly identical with the openvas-libraries version, the added features (like "remote harglist") were never used in the client. * libnessus/Makefile: Removed targets for removed files. 2009-08-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> Made OpenVAS-Client depend on and link against openvas-libraries. This implements the basics of Change Request #37 (http://www.openvas.org/openvas-cr-37.html). Attention: to compile, you need to have openvas-libraries installed! Make sure libopenvas-config is in your PATH. * libnessus/Makefile: Removed resolve.o and addslashes.o targets, added libopenvas compiler and linker flags, removed newlines. * nessus/Makefile: Added libopenvas compiler and linker flags, removed targets for objects that are provided by openvas-libraries * src/gui/Makefile, src/openvas-lib/Makefile, src/util/Makefile: Added libopenvas compiler flags, removed targets for objects that are provided by openvas-libraries. * configure: Regenerated. * libnessus/resolve.c, libnessus/resolve.h: Removed, copy in openvas-libraries is identical. * src/openvas-lib/hash_table_file.c, src/openvas-lib/hash_table_file.h, src/openvas-lib/openvas_ssh_login.c, src/openvas-lib/openvas_ssh_login.h : Removed, are now linked against. * src/gui/nvt_pref_sshlogin.c: Removed include of arglists.c. 2009-08-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/Makefile: Changed build order (utils first), cosmetics. 2009-08-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/pdf_output.c: widely reformatted, added docs and TODOs. 2009-08-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> * libnessus/system.h: Removed if(n)defs for HUNT_MEM_LEAKS, as the otherwise defined functions like __hml_free could not be found to be implemented anywhere. 2009-08-24 Tim Brown <timb@openvas.org> * src/gui/slad_install.c, src/util/openvas_lsc_user_makensis.c: Further format string fixes from Stephan Kleine. 2009-08-23 Tim Brown <timb@openvas.org> * nessus/pdf_output.c: Fixed PRINT macro where no formatting is done to resolve issues where a hardened gcc is used as per bug #1051 (http://bugs.openvas.org/1051). Thanks to Stephan Kleine. 2009-08-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> * include/libnessus.h, nessus/auth.h, nessus/cli.h, nessus/filter.h: Cosmetics. 2009-08-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/text_output.c: Cosmetics and doc. 2009-08-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> As part of CR # 37 (http://openvas.org/openvas-cr-37.html) and CR #38 (http://openvas.org/openvas-cr-38.html), made clients configure fail if libopenvas is not present. * configure.in: Made presence of libopenvas mandatory for openvas-client. 2009-08-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/Makefile: White space removal. 2009-08-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/parser.c: Removed unnecessary include. Cosmetics. Improved documentation. Extended verbosity if DEBUG is defined. * nessus/parser.c (parse_separator, parse_symbol): Added TODO (duplicate code in openvas-server). Replaced functions with the versions found in openvas-server/openvasd/parser.c (reformatted, TODO added, number of strlen calls reduced). 2009-08-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_context.c (prefs_context_update): Replaced g_strdup_printf by g_strdup where no formatting is done anyway. Step towards fixing bug #1051 (http://bugs.openvas.org/1051). Thanks to Stephan Kleine. 2009-08-12 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * libnessus/resolve.c: Backport changes in orginal source (r4457). 2009-08-12 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * libnessus/resolve.c, libnessus/resolve.h: Updated from original source in openvas-libraries/libopenvas. 2009-08-12 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/slad_install.c (ERROR): Added todo, as there is a implementation of error dialogs already in src/gui/err_dlg.c. * src/gui/slad_install.c (slad_install): Added RATS:ignore flag where popens first argument comes from a trusted source. 2009-08-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/sslui.c (sslui_check_cert): Added RATS:ignore flag where sufficient buffer size is ensured. * nessus/sslui.c (sslui_ask_paranoia_level): Added RATS:ignore flag where a formating string and destination for scanf are sane. 2009-08-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/xml_output_ng.c (escape_string): Reduced number of calls to strlen. 2009-08-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/util/severity_filter.c (severity_filter_to_xml, write_override_xml_elem): When invoking fprintf, supply a formatting string. 2009-08-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/filter.c (ask_filter): Removed never used non-GTK equivalent to ask_filter function. 2009-08-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/read_target_file.c (target_file_to_list): Removed unused variable 'i' and the assignment to it. * nessus/read_target_file.c (target_translate): Added RATS:ignore flag as string literals are always nul terminated. 2009-08-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/data_mining.c (be_index_keywords): Added RATS:ignore flag for strcpy, where buffer lenght is ensured. * nessus/data_mining.c (compile_conditions): Added TODO because of strange way of allocating struct and copying a string. * nessus/data_mining.c (compile_query): Added RATS:ignore flag, string literals are always nul terminated. 2009-08-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> Attempt to fix bug 1036 (http://bugs.openvas.com/1036). * nessus/context.h: Exposed context_collect_recurse, removed and added whitespaces. * nessus/nessus.c (main): In cli report conversion mode, load plugin cache to be able to provide xml outputs with all 'possible' information. 2009-08-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/xml_output_ng.c (xml_plugins): Take current Contexts plugin and scanner list in case of xml export. Two TODOs added, as logic of taking parents information is not clear. Partly fixes bug 1036 (http://bugs.openvas.com/1036). 2009-08-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/xml_output_ng.c (xml_plugins): Cosmetics and doc. 2009-08-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/nessus.c: In cli report conversion mode, try to load a (report) context from the directory of the given input argument and set it as currently selected Context. This tackles a tiny part of bug 1036 (http://bugs.openvas.com/1036). Removed single whitespace. 2009-08-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/xml_output_ng.h, nessus/xml_output_ng.c: Removed forward declaration of backend_to_xml_ng, include header instead. Minor formatting. 2009-08-05 Felix Wolfsteller <felix.wolfsteller@intevation.de> * packaging: Added svn:externals property to fetch the most up to date /openvas-packaging/openvas-client/debian/trunk/debian/ into packaging/debian. 2009-08-05 Felix Wolfsteller <felix.wolfsteller@intevation.de> * packaging/debian/, packaging/debian/changelog, packaging/debian/compat, packaging/debian/control, packaging/debian/copyright, packaging/debian/docs, packaging/debian/openvas-client.menu, packaging/debian/watch, packaging/debian/patches/, packaging/debian/patches/01_libgdchart-gd2-noxpm-dev.patch, packaging/debian/patches/05_fix_script_dir.dpatch: Moved to own new module /openvas-packaging/openvas-client/debian/trunk/ . 2009-07-31 Michael Wiegand <michael.wiegand@intevation.de> * Makefile, src/util/Makefile: Fixed installation location of support scripts as suggested by Jan Wagner. This closes bug #1072 (http://bugs.openvas.org/1072). 2009-07-28 Jan Wagner <waja@cyconet.org> * packaging/debian/changelog, packaging/debian/patches/00list, packaging/debian/patches/05_fix_script_dir.dpatch: Get scripts installed into /usr/share/ 2009-07-28 Jan Wagner <waja@cyconet.org> * packaging/debian/changelog. packaging/debian/control, packaging/debian/watch, packaging/debian/patches/00list, packaging/debian/patches/02_de-fix.dpatch, packaging/debian/copyright, packaging/debian/docs, packaging/debian/rules: - New upstream release - Remove 02_de-fix.dpatch and 03_es-fix.dpatch as the changes have been fixed upstream - Add debian/watch to detect when a new version is available at wald.intevation.org - Bump Standards-Version to 3.8.2, no changes needed - relicense packaging to GPL-3 - add debian/patches/03_es-fix.dpatch to update Spanish translation with the latest complete translation available in SVN - Change priority from optional to extra - Remove config.sub and config.guess since the package depends on autotools-dev and should be able to recreate them. This also fixes a lintian bug - Remove .svn folders from debian/ subdir - Lintian fix: Remove COPYING.OpenSSL from debian/docs since it is already included in debian/copyright 2009-07-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/html_output.c (html_output_from_arg): If no detailed information will be visible for a host, do not create empty tables for it. As the detail tables are linked from a section in the beginning of the report, omit the link if there will be no table. 2009-07-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/html_output.c (html_output_from_arg, html_output_print_port_table): Extracted method to print contents of "Ports table", eased up and reformatted loop. Changed order of conditionals, which interpreted "False Positives" to be more worth mentioning than "Security Notes". 2009-07-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/html_output.h (issue_type): Introduced yet another issue severity discrimination method. * nessus/html_output.c (html_output_print_issue_details, html_output_from_arg): Extracted html_output_print_issue_details to ensures a more consistent form of the html output and increases code readability. 2009-07-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/html_output.c (html_output_from_arg, summary_to_file): Moved code to print beginning of a html table closer to where the table will get filled. * nessus/html_output.c (html_output_from_arg): Solved minor issues that led to invalid html document, tiny cosmetics. 2009-07-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/html_output.c (summary_to_file): Accept new parameter to drop "No Information" issues. Write a note to the summary if that will happen. Added documentation. Made function static. * nessus/html_output.c (html_output_from_arg): Pass (new) parameter to summary_to_file. 2009-07-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/report.c (is_there_any_hole): Cosmetics, reformatted, added documentation. 2009-07-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/html_output.c (html_output_from_arg): Always show all targets, even if False Positives should be dropped (then list "No noticeable information..." in summary). 2009-07-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed bug: in the stripped down html report (OpenVAS-Client -DNF -i .. -o ..), ports with a False Positive were not listed at all, even if there were other issues reported for this port. * nessus/html_output.c (html_output_from_arg): Corrected check to skip a port (FP has to be present, but nothing else has to be present and option has to be set). 2009-07-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> Resolved some issues with html report conversion and the new parameters. * nessus/html_output.c (html_output_from_arg): Early stop in two cases when drop_fp is specified. Avoids unclosed table rows or table rows with insufficient data in it. 2009-07-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> Preparing slightly improved GUI of Severity Overrides Manager (multiline reason text field, editing). Changed type of input field for the "reason" of an severity_override from GtkEntry (single line) to GtkTextView (multiline). * src/gui/severity_override_form.h (severity_override_form): Renamed reason_entry to reason_textview, changed type. * src/gui/severity_override_form.c (textview_get_text): New. Convience function to retrieve all visible text of a textview. * src/gui/severity_override_form.c: Replaced all occurences of reason_entry and use its GtkTextBuffer where the text is accessed. 2009-07-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added option to CLI to drop issues with "No Information" during export conversion to html. New command line option is --convert-drop-no-info or -N. * nessus/nessus.c (convert_report): Added new parameter. Warn if new option is given, but report target format is not html. Changed function call to pass the given option. * nessus/nessus.c (main): Introduced new command line option, pass this option to convert_report, warn in cases where the new option is given but will be ignored. * nessus/html_output.c (html_output_from_arg): Added new parameter, skip "No Information" issues if parameter drop_no_info equals TRUE. * nessus/html_output.h (html_output_from_arg): Adjusted proto (new parameter). * nessus/html_output.c (arglist_to_html): In the wrapper, default new option to FALSE. 2009-07-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> Expose html report conversion (last commits) with hidden False Positive to CLI, introduced new command line option (--convert-drop-fp or -D). * nessus/nessus.c (convert_report): Added new parameter. Warn if new option is given, but report target format is not html. Changed function call to pass the given option. * nessus/nessus.c (main): Introduced new command line option, pass this option to convert_report, warn in cases where the new option is given but will be ignored. 2009-07-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> Implementation of html report generation with False Positives completely stripped. * nessus/html_output.c (summary_to_file): Added parameter (drop_fp), state that False Positives are not shown in the report, if so. Drop number of False Positives if asked to. * nessus/html_output.c (html_output_from_arg): Respect new parameter of summary_to_file, do not print information about False Positives, if asked to. Removed TODO. 2009-07-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> To allow future (html) report generation without display of issues that were labelled "False Positive" by a severity override, extended the html_output module. Function signatures were kept in order to change calls just where it is relevant and avoid further code changes in the cli module, where converting-functions like arglist_to_xyz are casted into (output_func_t). * nessus/html_output.h (html_output_from_arg): Proto added. * nessus/html_output.c: Include html_output.h. * nessus/html_output.c (html_output_from_arg, arglist_to_html): Renamed arglist_to_html to html_output_from_arg. Added (yet unused) parameter to html_output_from_arg. Created wrapper function arglist_to_html that passes the default value for the new parameter to html_output_from_arg and does nothing else. Added TODO to implement relevance of the new parameter. 2009-07-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/html_output.c (html_output_print_data_with_links): Corrected wording (OID != OpenVAS ID). 2009-07-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.c (send_ntp_opts): In the TODO explained the deprecation. 2009-07-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/html_output.c (summary_to_file): Fixed typo that lead to warning about unknown escape sequence. 2009-07-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/nvt_pref_sshlogin.c (prompt_new_pattern): Changed wording and title of dialog that prompts for a new pattern. 2009-07-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/html_output.c (arglist_to_html, summary_to_file): Dropped "found" in text, as it does not convey any additional meaning and in case of "False Positives" sounds wrong. 2009-07-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/html_output.c (summary_to_file): Print note that a severity filter was applied if that is the case. * nessus/html_output.c (arglist_to_html): If severity level is 'False Positive', indicate that in the 'Type' field of the 'Severity Issues and Fixes' table of html report (was 'Informational' before). 2009-07-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/report.h: Cosmetics. 2009-07-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/report.h: Corrected defines to match the felt order of severities (important in html reports where in an overview just the "highest" severity level is shown, was False Positives till now). * nessus/report.h: Removed whitespaces. 2009-07-14 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.c: Removed accidentally commited comments and debugging code. 2009-07-14 Felix Wolfsteller <felix.wolfsteller@intevation.de> Reverted sending of a certain preference to the server to keep 2.x compatibility (was removed in rev. 3930). * nessus/comm.c (send_ntp_opts): Send to-be-obsolete preference "ntp_client_accepts_notes" to avoid misconfiguration when talking to 2.x servers, marked TODO and added deprecation warning. 2009-07-14 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/nessus_plugin.c: Cosmetics and documentation. * nessus/nessus_plugin.c (nessus_plugin_get_by_name): Check function parameter 'name' and return NULL if NULL was passed. 2009-07-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> Allow patterns (containing * or ?) in host and port fields of severity overrides that are matched against the values in the issue at filter application. Attention when testing: There are no conflict checks for the patterns, thus in some cases the order of the overrides within the xml file can matter. * src/util/severity_filter.c (severity_filter_apply): Use g_pattern_match_simple instead of strcmp. 2009-07-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/util/severity_filter.c (severity_filter_apply): Improved readability by flattened code and easier (positive) conditional. 2009-07-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Backported from openvas-client-2-0 branch (revision 3956). Unhide the new cli option to enable report conversion with active severity filter. Slightly improved wording and comments. * nessus/nessus.c (convert_report): Removed TODO, as implementation now works for conversions into all formats (except for nbe and pdf, but in that case a message is printed). Slightly better comment. Use 'conversion' instead of 'export' consistently, also in messages. * nessus/nessus.c (main): Unhide the new option. 2009-07-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Backported from openvas-client-2-0 branch (revision 3942). Slightly more helpful messages in command line option parsing. * nessus/nessus.c (convert_report): Print error message if severity overrides flag (-F) was given together with export type nbe. Print more helpful message if export type pdf was given. * nessus/nessus.c (main): Print a message to stdout when -F flag, but neither -i nor -o was given on command line. 2009-07-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Backported from openvas-client-2-0 branch (revision 3940). * nessus/backend.c (priority_str_to_idx): Declared argument as const, removes compiler warning. 2009-07-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Backported from openvas-client-2-0 branch (revision 3939). Enabled latex-report output with enabled severity filter from cli. * nessus/latex_output.c: Get reference to global sev_mapping_matrix and include backend.h to print the mapping matrix if needed. * nessus/latex_output.c (latex_severity_mapping_matrix): New. Print the mapping matrix of a severity filter as counted by backend_convert if severity mapping for Current Context is enabled. * nessus/latex_output.c (arglist_to_latex): Call new latex_severity_mapping_matrix if severity filtering is enabled. 2009-07-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Backported from openvas-client-2-0 branch (revision 3938). Enabled "html with graphs"-report output with enabled severity filter from cli. * nessus/html_graph_output.c: Get reference to global sev_mapping_matrix and include backend.h to print the mapping matrix if needed. * nessus/html_graph_output.c (print_severity_map): New. Print the mapping matrix of a severity filter as counted by backend_convert if severity mapping for Current Context is enabled. * nessus/html_graph_output.c (print_severity_map): Call new print_severity_map if severity filtering is enabled. 2009-07-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Backported from openvas-client-2-0 branch (revision 3936, 3937). Enabled text report output with enabled severity filter from cli. * nessus/text_output.c: Get reference to global sev_mapping_matrix and include backend.h to print the mapping matrix if needed. * nessus/text_output.c (arglist_to_text): Print the mapping matrix of a severity filter as counted by backend_convert if severity mapping for Current Context is enabled. Wording improved. 2009-07-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Backported from openvas-client-2-0 branch (revision 3935). Enabled xml report output with enabled severity filter from cli. * nessus/xml_output_ng.c: Get reference to global sev_mapping_matrix and include backend.h to print the mapping matrix if needed. * nessus/xml_output_ng.c (xml_filter_matrix): New. Print the mapping matrix of a severity filter as counted by backend_convert if severity mapping for Current Context is enabled. * nessus/xml_output_ng.c (backend_to_xml_ng): If filter is enabled, call backend_convert to arrive at a filtered report without to much code change. Call new xml_filter_matrix. 2009-07-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Backported from openvas-client-2-0 branch (revision 3933, 3934). Enabled html report output with enabled severity filter from cli. * nessus/html_output.c: Get reference to global sev_mapping_matrix and include backend.h to print the mapping matrix if needed. * nessus/html_output.c (arglist_to_html): Print the mapping matrix of a severity filter as counted by backend_convert if severity mapping for Current Context is enabled. 2009-07-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Backported from openvas-client-2-0 branch (revision 3917). * nessus/latex_output.c (latex_print_host_ports_problems): Use plural of for listed severities consistently, removed not escaped underscore that prevented further standard processing. 2009-07-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Backported from openvas-client-2-0 branch (revision 3916). Added a new command line option to Openvas-Client, --convert-filtered or -F, that will enable severity filter application during report export in combination with --in-report / -i and --out-report / -o . The parameter will stay declared as hidden (not visible with --help) until implementation is complete. * nessus/nessus.c (main, convert_report): Added new command line option that is passed to convert_report. In convert_report load global filter if the flag is set and set the Contexts is_severity_mapped flag accordingly. Added TODO comment to indicate incomplete implementation. 2009-07-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Backported from openvas-client-2-0 branch (revision 3915). * nessus/nessus.c (main, convert_report): Extracted method from main that converts ('exports') reports from nbe into other supported formats. 2009-07-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Backported from openvas-client-2-0 branch (revision 3909). * nessus/nessus.c: Cosmetics, doc and comments. 2009-07-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Backported from openvas-client-2-0 branch (revision 3908). To keep track of the number times that a severity override was applied and from which severity it mapped to which other severity, a global matrix was introduced. Due to incompatible backend and severity filter designs this might be not an elegant but the most efficient way to arrive at a severity filter summary without massive changes to the code base. * nessus/backend.c (priority_idx_to_str, priority_str_to_idx): New. Yet another functions to turn strings for severities into numbers and vice versa (to be used as array indices). * nessus/backend.c (sev_mapping_matrix, backend_reset_sev_mapping_matrix): New global variable that holds the number of severity_overrides that were actually applied during a backend conversion (i.e. nbe to arglist). Function to reset the counters to zero. * nessus/backend.c (backend_convert): Reset and update counters in the sev_mapping_matrix when applying severity overrides. * nessus/backend.h (priority_idx_to_str): Prototype of new function added. 2009-07-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Backported from openvas-client-2-0 branch (revision 3906). * nessus/backend.c: Cosmetics, docs. 2009-07-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Backported from openvas-client-2-0 branch (revision 3906). * nessus/html_output.c (arglist_to_html): Fixed mem leak (the malloced memory for desc was never read, html_output_convert_cr_to_html will allocated new mem), removed associated TODO comment. 2009-07-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Backported from openvas-client-2-0 branch (revision 3904). * nessus/html_output.c: Cosmetics, documentation, added TODO about possible memory leak. 2009-07-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> * libnessus/rand.h, libnessus/rand.c, libnessus/Makefile: Removed module rand and object target, as it is never used. 2009-07-03 Jan-Oliver Wagner <jan-oliver.wagner@greenbone.net> * nessus/comm.c (send_ntp_opts): Removed setting of unneeded preference "ntp_client_accepts_notes"). 2009-06-30 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/nessus.c: Cosmetics. 2009-06-30 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/cli.c: Reformatting, whitespace removal, minor doc. 2009-06-15 Michael Wiegand <michael.wiegand@intevation.de> Post branch version bump. * VERSION: Set to 2.1.0.SVN. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. 2009-06-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/preferences.c (preferences_new): Set default value of plugins_timeout parameter to 320 (as in the servers default). 2009-06-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> Enabled storing and recovering of Global Timeout Settings, added tooltip help text. * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_set_defaults, prefs_dialog_set_tooltips, prefs_dialog_apply): Set global timeout value from preferenfces to SpinButton and read from SpinButton into preferences. Set tooltip to SpinButton. * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_execute): Corrected build-breaking typo. * nessus/prefs_dialog/prefs_help.h (HLP_AUTO_GLOBAL_NVT_TIMEOUT): Added tooltip text for global nvt timeout SpinButton. 2009-06-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_plugins.c (prefs_dialog_plugins): Added (yet non functional) Spinner to set the Global NVT Timeout. 2009-06-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_plugins.c: Minor reformatting. 2009-06-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_dialog.c: Cosmetics, reformatting and doc. * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_execute): Changed wording (Target section starts with capital T, punctuation). 2009-06-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_plugins.c: Cosmetics, reformatting and doc. 2009-06-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_plugins_tree.c: Cosmetics, reformatting and doc. 2009-06-08 Felix Wolfsteller <felix.wolfsteller@intevation.de> Small refactoring where toggle buttons states are set to reflect preference (arglist) values. * nessus/prefs_dialog/prefs_dialog.c: (arg_int_to_yesno): Return the value read/set from preference, declared parameter const, doc. (set_toggle_from_pref): New. Extracted from prefs_dialog_set_defaults, set I thistate of a toggle button according to a preference value. (prefs_dialog_set_defaults): Extracted method set_toggle_from_pref, use it. 2009-06-05 Felix Wolfsteller <felix.wolfsteller@intevation.de> * MANIFEST: Added tools/openvas-ssh-client-rpm-creator.sh. 2009-06-05 Michael Wiegand <michael.wiegand@intevation.de> Post release version bump. * VERSION: Set to 2.0.5.SVN. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. 2009-06-05 Michael Wiegand <michael.wiegand@intevation.de> Preparing the openvas-client 2.0.4 release. * VERSION: Set to 2.0.4. * doc/Doxyfile, doc/Doxyfile_full: Updated PROJECT_NUMBER. * CHANGES: Updated. 2009-06-05 Michael Wiegand <michael.wiegand@intevation.de> Committing code audit results. * src/gui/ssh_key_info_form.c (ssh_key_info_form_validated): Added RATS:ignore statements since the nul-termination of the strings is ensured by gtk_entry_get_text. * src/util/openvas_ssh_key_create.c (openvas_ssh_privkey_create, openvas_ssh_key_create_unlink_files): Added RATS:ignore statements since the nul-termination of string literals is ensured. * nessus/nessus.c (main): Added RATS:ignore statements since the non-constant format strings are actually gettext translations, which we regard as a trusted source. * libnessus/network.c (sslerror2): Replaced ERR_error_string with ERR_error_string_n to ensure the error written to string does not exceed the allocated length. 2009-06-03 Michael Wiegand <michael.wiegand@intevation.de> * po/de.po: Updated German translation. 2009-05-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.c (comm_parse_certificate): Exclude trailing space of public key data as sent by the server. 2009-05-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.c: Reformatted, minor doc. 2009-05-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.c: Reformatted, minor doc. 2009-05-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> Replaced context_delete_dir with the newer file_utils_rmdir_rf at the price of possibly less detailed error messages. * nessus/context.c (context_delete_directory): Removed. * nessus/context.c (context_delete): Updated call, show error message if failed. 2009-05-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/context.c (check_is_dir, check_is_file, check_exists): Cosmetics, reformatting. 2009-05-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/context.c: Adjusted include and call to functions of renamed module. 2009-05-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> Renamed module openvas_ssh_rpm to openvas_lsc_user_rpm to be consistent with the openvas_lsc_user_deb and openvas_lsc_user_makensis modules. * src/util/openvas_ssh_rpm.c, src/util/openvas_ssh_rpm.h, src/util/openvas_lsc_user_rpm.c, src/util/openvas_lsc_user_rpm.h: Moved module and renamed functions. * MANIFEST, nessus/Makefile, src/util/Makefile: Updated according to new filenames. * src/gui/ssh_key_info_form.c, src/gui/ssh_keys_dialog.c, src/util/openvas_lsc_target_prep.c, src/util/openvas_lsc_user_deb.c: Adjusted include and call to functions. 2009-05-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed code duplicates, changed working (temporary) directory for package generators (rpm and makensis). * src/util/openvas_ssh_rpm.c (create_tmp_dir), src/util/openvas_lsc_user_makensis.c (create_tmp_dir): Removed, calls replaced by calls top openvas_lsc_target_prep_create_tmp_dir. * src/util/openvas_lsc_target_prep.c (openvas_lsc_target_prep_create_tmp_dir): Changed location of temporary directory from subdirectory of .openvas/.ssh to .openvas/lsc-mngt. 2009-05-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added tooltips for all entries in the ssh_key_info_form, added todo. * src/gui/ssh_key_info_form.c (add_tooltips): Added tooltips for all entries. 2009-05-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> Handle missing installers/packages on check on startup analog to missing key files. Remove installer/packages if key files should be deleted. * nessus/context.c (verify_sshlogin_integrity): Check for 'missing' installers/packages as well and recreate if user selects so. * nessus/context.c (context_pickup_sshkeys): Remove installers/packages if keys shall be deleted. * nessus/context.c (context_delete_directory): Added doc and TODO, minor reformatting. 2009-05-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> Remove installers / packages together with key files if an entry is deleted via the OpenVAS LSC Credentials Manager. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_delete_login): Remove generated installers/packages when deleting a login. 2009-05-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/util/openvas_lsc_target_prep.c, src/util/openvas_lsc_target_prep.h (openvas_lsc_target_prep_remove): New. Removes all generated installers / packages. 2009-05-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed bug that occurred due to a freed static string when executing rpm generator script more than once. * src/util/openvas_ssh_rpm.c (openvas_ssh_rpm_create): Dont free oltap_path to allow multiple executions. 2009-05-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> Respect the changed signature of filename functions. Changed location of installer/packages from .openvas/lsc-credentials to .openvas/lsc-mngt. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_prompt_new), src/util/openvas_lsc_user_deb.c (openvas_lsc_user_deb): Respect new signature of filename functions. * src/util/openvas_lsc_target_prep.c (openvas_lsc_target_prep_filename): Changed location of installer/packages from .openvas/lsc-credentials to .openvas/lsc-mngt. 2009-05-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> Execute alien as fakeroot, use extracted module to fetch file names for 'credential installer/packages'. * src/util/openvas_lsc_user_deb.c, src/util/openvas_lsc_user_deb.h (openvas_lsc_user_deb_filename), src/util/openvas_lsc_user_makensis.c, src/util/openvas_lsc_user_makensis.h (openvas_lsc_user_makensis_filename), src/util/openvas_ssh_rpm.c, src/util/openvas_ssh_rpm.h (openvas_ssh_rpm_filename): Include new module openvas_lsc_target_prep, use its function for filename generation, changed signature to take char*, corrected documentation. * src/util/openvas_lsc_user_deb.c (execute_alien): Execute alien with fakeroot. * src/gui/ssh_key_info_form.c (ssh_key_info_form_fill, name_typed_in_cb): Call functions to get filenames with new signature. 2009-05-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> Extracted module with common functionality that is needed for credential installer/packages (rpm,deb,exe). * src/util/openvas_lsc_target_prep.c, src/util/openvas_lsc_target_prep.h: New module with common functionality for the package/installer generators. * MANIFEST: Added the two new files. * nessus/Makefile: Added object to UTIL_OBJS. * src/util/Makefile: Added target for new module. 2009-05-18 Felix Wolfsteller <felix.wolfsteller@intevation.de> * doc/Doxyfile: Turn EXTRACT_ALL off, to enable warnings about missing function docs. 2009-05-18 Felix Wolfsteller <felix.wolfsteller@intevation.de> Towards automatic generation of 'lsc user installer/packages'. Therefore filenames for the generated installers/packages have to be found and it has to be known if the tool to create the installer/package is available. * src/util/openvas_lsc_user_deb.c (execute_alien): Use --script parameter when converting rpm to deb. * src/util/openvas_lsc_user_deb.c (openvas_lsc_user_deb_alien_found): New. Checks once for alien in path and returns whether it was found. * src/util/openvas_lsc_user_makensis.c (execute_makensis): Included return code of makensis in output to stdout. * src/util/openvas_ssh_rpm.c (get_rpm_generator_path): Extracted. Searches in install location and in tools folder for the rpm generator script and returns its location if found. * src/util/openvas_ssh_rpm.c (openvas_ssh_rpm_create): Use new extracted function get_rpm_generator_path, (debug) print the spawned command. * src/util/openvas_ssh_rpm.c (openvas_ssh_rpm_generator_found): New. Checks once for existence of rpm generator script. * src/util/openvas_lsc_user_deb.c (openvas_lsc_user_deb_filename), src/util/openvas_lsc_user_deb.h, src/util/openvas_lsc_makensis.c (openvas_lsc_makensis_filename) src/util/openvas_lsc_makensis.h, src/util/openvas_ssh_rpm.c (openvas_ssh_rpm_filename), src/util/openvas_ssh_rpm.h: New. Added functions and protos to create and return filename of an installer/package. * src/gui/ssh_key_info_form.c (typed_in_cb): When creating a new account, now shows filenames for .exe, .rpm and .deb files as the account name is typed in if the tools are available. * src/gui/ssh_key_info_form.c (add_tooltips): Stub for function where tooltips will be set. * src/gui/ssh_key_info_form.c (ssh_key_info_form_create): Initialize text to indicate that a tool could not be found - if so. * src/gui/ssh_key_info_form.c (ssh_key_info_form_free): Free the new text entries. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_prompt_new): When account is added, try to create the rpm, exe and deb installer/packages. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_create_exe_click, ssh_keys_dialog_create_rpm_click, ssh_keys_dialog_show): Removed buttons to manually create rpm and exe installer/package and associated callback functions. 2009-05-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added stub for module openvas_lsc_user_deb that will create deb packages from the rpm packages that install accounts for lsc. * MANIFEST: Added the new files. * nessus/Makefile: Added object to UTIL_OBJS. * src/util/Makefile: Added target for new module. * src/util/openvas_lsc_user_deb.c, src/util/openvas_lsc_user_deb.c: New. Will take care of executing alien to transform rpm packages to deb packages. 2009-05-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> Preparing display of filenames of 'installers' for credentials. * src/gui/ssh_key_info_form.h: Added references to text entries to struct that will display filenames of rpm, deb and exe 'installers'. * src/gui/ssh_key_info_form.c (ssh_key_info_form_create): Initializes the new tet entries, adds them to the layout. * src/gui/ssh_key_info_form.c (ssh_key_info_form_fill): Fills in paths to files if they do exist. * src/openvas-lib/openvas_ssh_login.h: Adjusted documentation: login is valid if the installer files do not exist. 2009-05-14 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.h (comm_send_long_preferences, comm_get_preference_errors, comm_plugin_upload): Removed prototypes for not implemented functions. 2009-05-14 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_dialog_user.c: Use GTK+ 2.6 functionality (keeping old code as comment), use gchar where glib char function is used. 2009-05-14 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cosmetics, Wording about paranoia settings in sslui. * nessus/attack.c, nessus/auth.c: Some reformatting. * nessus/filter.c: Reformatting, documentation. * nessus/sslui.c: Reformating, documentation. Changed wording about paranoia setting choice minimally, to clarify difference between two options. 2009-05-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> Few cleanups in rpm export function. * src/util/openvas_ssh_rpm.c (openvas_ssh_rpm_create): Slightly better error handling and cleanup, corrected memory allocation, using file_utils module function instead of context_remove_directory. 2009-05-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> Better wording and catching the case where credentials export functionality is attempted to be used before any credentials were created. Changed the nsi installer script with Thomas Rotters help to find out the Administrators group name at runtime. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_create_rpm_click, ssh_keys_dialog_create_exe_click): Better wording, internationalization catch situations where no account has yet been created. * src/util/openvas_lsc_user_makensis.c (create_nsi_file): Changed resulting nsi file so that the generated installer will during execution time create two scripts and execute these. Big Thanks to Thomas Rotter who helped with the scripts and advises regarding the MS WIN shell. 2009-05-06 Felix Wolfsteller <felix.wolfsteller@intevation.de> Updated rpm generator script - created from trunk/tools/openvas-lsc-target-preparation. * tools/openvas-ssh-client-rpm-creator.sh: Replaced dummyscript by rpm-generator created from trunk/tools/openvas-lsc-target-preparation. 2009-05-06 Felix Wolfsteller <felix.wolfsteller@intevation.de> Improved "user-installer" functionality. * src/util/openvas_lsc_user_makensis.c (create_nsi_file): Thanks to Thomas Rotter, give the user admin rights. Display messages. Some parts adopted from winslads installer (thanks to Dirk Jagdmann). * src/util/openvas_lsc_user_makensis.c, src/util/openvas_lsc_user_makensis.h (openvas_lsc_user_makensis_found): New, checks for presence of makensis in path. * src/util/openvas_lsc_user_makensis.c (openvas_lsc_user_makensis): Better error checking and handling, removes temporary directory when done. * src/gui/gui/ssh_keys_dialog.c (ssh_keys_dialog_create_exe_click): Checks for presence of makensis in path, display messages if failed. 2009-05-06 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/util/file_utils.c, src/util/file_utils.h (file_utils_rmdir_rf): New (copied from openvas-config-manager/src/openvascd.c). 2009-05-06 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_dialog.c: Collapsed comments, minor reformatting. 2009-05-05 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/ssh_keys_dialog.c: Added missing include. 2009-05-05 Jan Wagner <waja@cyconet.org> Update debian packaging * patches/02_de-fix.dpatch, patches/00list, changelog: Fix german translation * copyright, changelog: Update changelog for new upstream code 2009-05-05 Felix Wolfsteller <felix.wolfsteller@intevation.de> Can now build executable with nsis that installs a user on win xp machines if executed with admin rights. * src/util/openvas_lsc_user_makensis.c (execute_makensis): Executes makensis on a given (.nis) file. * src/util/openvas_lsc_user_makensis.c (create_nsi_file): Adjusted resulting nsi script, so that it calls 'net user ...' in install and uninstall process, todos added. 2009-05-05 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cosmetics. * libnessus/addslashes.c: Reformatting and doc. * libnessus/network.c: Reformatting, minor doc. * libnessus/system.c: Minor reformatting. * nessus/cli.c: Reformatting, doc, added comment. 2009-05-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> Work-in-progress of new .exe export functionality for credentials. This functionality will ease installation of new users to perform local security checks on certain platforms (analog to RPMs). * src/util/openvas_lsc_user_makensis.c, src/util/openvas_lsc_user_makensis.h: New module to create .exe from credentials account information. * src/util/Makefile: Included new module. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_create_exe_click, ssh_keys_dialog_show): Added Button and callback for click on button. * nessus/Makefile: Included new module. * MANIFEST: Updated. 2009-04-28 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/util/openvas_ssh_rpm.c: Cleaned up, searches for the generator script in the install directory (set via Makefile). If there nothing is found looks in tools subdir of pwd. 2009-04-28 Felix Wolfsteller <felix.wolfsteller@intevation.de> Define path to ssh rpm generator generator script. * Makefile: Use lib/openvas, no need for an own variable. * src/util/Makefile: Define path to generator script. 2009-04-28 Felix Wolfsteller <felix.wolfsteller@intevation.de> Minor cleanup of build related files. * configure.in: Removed unneeded nessuslib variable, replaced nessus by openvas in comment. * nessus.tmpl.in: Removed nessuslib reference, minor whitespace removal. * include/config.h.in: Marked suspicious variables as fixme. 2009-04-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cleaned up and corrected rpm package export of ssh public keys. Can be tested locally (bin/OpenVAS-Client) by generating the rpm generator script ('make self' in trunk/tools/openvas-lsc-target-preparation) and placing it into trunk/openvas-client/tools). Will not yet worked with installed versions. Functionality is exposed as "Export RPM" in the OpenVAS Credentials Manager (GUI/Extras menu). * src/util/openvas_ssh_rpm.c: Cleaned up and corrected. 2009-04-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed double code, added include ('new' subset module). * nessus/data_minig.c, nessus/data_mining.h: Removed code that is now in subset module, minor reformatting, added include. 2009-04-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> Extracted subset module. * nessus/subset.h, nessus/subset.c: New module. Code from data_mining. * nessus/Makefile, MANIFEST: Updated to include new module. 2009-04-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/util/openvas_ssh_key_create.c, src/util/openvas_ssh_key_create.h: Removed code that is now in the file_utils and openvas_ssh_rpm modules, updated references and includes. * src/util/openvas_ssh_rpm.c: Corrected includes. * nessus/context.c, nessus/context.h: Reformatting, doc, TODO about function to be moved. * nessus/nessus.c: Changed include (as we have the file_utils module now) and reference to ensure_dir function. * src/gui/ssh_keys_dialog.c: Added include, changed reference to rpm creation function. 2009-04-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/nessus.c: Reformatting, doc. 2009-04-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> Donating own module to rpm export functionality. * src/util/openvas_ssh_rpm.c, src/util/openvas_ssh_rpm.h: * MANIFEST, nessus/Makefile, src/util/Makefile: Updated, included the new module. 2009-04-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/util/file_utils.c: Include own header file. 2009-04-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> Created (extracted) module for various file- related functions. * src/util/file_utils.c, src/util/file_utils.h: New. File- related functions that were misplaced in other modules. * MANIFEST, nessus/Makefile, src/util/Makefile: Updated, included the new module. 2009-04-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> * tools/openvas-ssh-client-rpm-creator.sh: Typo corrected. 2009-04-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> * tools/openvas-ssh-client-rpm-creator.sh: New, dummy script. Will generate rpm packages from key files. * Makefile: New target (install-tools) to install the dummy-script (for testing purposes). 2009-04-21 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/prefs_dialog/prefs_report.c (gshb_export_click): Removed leading "#" for export file. (show_popup_menu): Renamed menu entry to "Export GSHB...". 2009-04-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> Repaired and cleaned up ~RPM export of keys. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_create_rpm_click): Propose a filename, respect new return type of openvas_ssh_key_create_rpm. * src/util/openvas_ssh_key_create.c, src/util/openvas_ssh_key_create.h (openvas_ssh_key_create_rpm): Changed return type to gboolean, cleaned up. * src/util/openvas_ssh_key_create.c (copy_file): Repaired, initialize values. 2009-04-21 Michael Wiegand <michael.wiegand@intevation.de> * src/omp-cli.c: Added examples for OMP commands to --help. 2009-04-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_create_rpm_click): Ask user for filename. * src/util/openvas_ssh_key_create.c (copy_file, move_file): New, talky functions to copy and move a file. The in other places used rename() is not guaranteed to work across filesystem boundaries. * src/util/openvas_ssh_key_create.c, src/util/openvas_ssh_key_create.h (openvas_ssh_key_create_rpm): Now expects a filename as second parameter, use new functions. 2009-04-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> Reformatted, use glibs gchar/ g_free consistently, removed define-conditionals around rpm export code. * src/util/openvas_ssh_key_create.c, src/util/openvas_ssh_key_create.h: Reformatted, use glibs gchar/g_free consistently, removed DEV_SSH_RPM_EXPORT conditionals. 2009-04-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> Minor reformatting, USE_GTK guard to enable compilation without gtk. * src/gui/treeview_support.c, src/gui/treeview_support.c: Minor style, documentation, added USE_GTK guard. 2009-04-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> Reformatted, removed define-conditionals around rpm export code. * src/gui/ssh_keys_dialog.c: Style, removed DEV_SSH_RPM_EXPORT- define conditionals. 2009-04-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed issue with RMB in report view: Popup menu was shown on information prioir to selectionm, renamed functions that included the string 'prio'. * nessus/prefs_dialog/prefs_report.c (prio_button_press, mouse_button_press): Renamed, do a selection when rmb is clicked before showing the popup menu. * nessus/prefs_dialog/prefs_report.c (prio_show_popup, addprio_click): Renamed to show_popup and add_override_click respectively. 2009-04-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_report.c (gshb_export_click): Removed debug- printf. 2009-04-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed issues with gshb export of a reports item. * nessus/prefs_dialog/prefs_report.c (rough_gshb_export_click, gshb_export_click, show_popup_menu): Stripped rough from function name. * nessus/prefs_dialog/prefs_report.c (gshb_export_click, show_popup_menu): Fixed a bug that caused crash when different ordering of report tree (port/host/severity) was chosen. Proposed filename now contains target, minor changes (window parenting, ordering of error checks). 2009-04-17 Michael Wiegand <michael.wiegand@intevation.de> * nessus/prefs_dialog/prefs_report.c (rough_gshb_export_click): Fixed syntax error. 2009-04-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> Introduced rough outline for specialized, selective report export (in this case gshb). * nessus/prefs_dialog/prefs_report.c (rough_gshb_export_click): New. Outlines this specific export process. * nessus/prefs_dialog/prefs_report.c (show_popup_menu): Added menu item to the rmb menu, if items from a special port are selected. 2009-04-16 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * src/omp-cli.c (main): Renamed openvas_server_ methods according to changes in openvas-libraries. Adjusted copyright. 2009-04-16 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * libnessus/network.c: Removed any code path for NESSUS_CNX_LOCK. This is not used and not relevant for client anyway. 2009-04-15 Michael Wiegand <michael.wiegand@intevation.de> First (optional) integration of openvas-libraries in openvas-client. The OMP Command Line Interface now depends on connection functionality provided by openvas-libraries. * src/omp-cli.c: Adjusted function names, added missing headers. * src/Makefile: Adjusted to use LIBOPENVAS_*. * configure.in: Added tests for libopenvasconfig. * nessus.tmpl.in: Added support for LIBOPENVAS_*. * configure: Regenerated. 2009-04-09 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * MANIFEST: Updated. 2009-04-09 Michael Wiegand <michael.wiegand@intevation.de> Added a first draft for an OMP Command Line Interface, allowing to issue OMP commands from the command line. * src/omp-cli.c: Added. * src/Makefile: Added. Makefile to build omp-cli. 2009-04-08 Michael Wiegand <michael.wiegand@intevation.de> * po/de.po: Translated remaing strings. 2009-04-07 Felix Wolfsteller <felix.wolfsteller@intevation.de> Made the progress bar in the scan monitor showing values (for checks only, portscans stay at 0%). * nessus/monitor_dialog.c (monitor_list_update): Repaired progress bar in scan monitor (cast to float when calculating numbers 0<x<1). 2009-04-07 Felix Wolfsteller <felix.wolfsteller@intevation.de> Reformatted monitor_dialog module. * nessus/monitor_dialog.c: Reformatted. 2009-04-07 Felix Wolfsteller <felix.wolfsteller@intevation.de> Adding timestamps to gtk message display (lower part of the gui if activated via the 'View' menu). * src/gui/error_dlg.c (show_dialog_gtk_log): Prepend timestamp to dispalyed message. 2009-04-07 Felix Wolfsteller <felix.wolfsteller@intevation.de> * TODO: Updated (with quite old idea). 2009-04-03 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * MANIFEST: Updated. 2009-04-03 Felix Wolfsteller <felix.wolfsteller@intevation.de> * libnessus/openvas-socket.h: Corrected include guard (resolves compiler warnings). 2009-04-03 Michael Wiegand <michael.wiegand@intevation.de> * Makefile: Added buildcheck target; this target is intended to improve QA and should be called to make sure OpenVAS-Client builds correctly before a release. As an initial step, it will try to build OpenVAS-Client as well as the translations in the "po" directory. 2009-04-02 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/monitor_dialog.c (monitor_dialog_setup, monitor_list_update, monitor_remove_host, monitor_add_host): Since GTK 2.6 is now minimal version for OpenVAS-Client, the if-clauses for old 2.4 code can be removed. (monitor_stop_test): Removed (not used anymore). 2009-04-02 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * configure.in, nessus.tmpl.in, include/corevers.h.in, nessus/nessus.c, src/gui/about_dlg.c: Renaming NESSUS_[MAJOR,MINOR,PATCH,RC,VERSION,FULL_VERSION] to OPENVASCLIENT_[...] * configure: updated. 2009-04-02 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Further patches by Marcus Brinkmann towards a crosscompiling OpenVAS-Client based on mingw. * nessus/preferences.c (get_username): For W32 system, try environment variable USERNAME. (dlopen, dlsym, dlclose, w32_shgetfolderpath, standard_homedir): New. Handling of W32 specific methods to get folder path. (prefs_get_nessushome): For W32 systems, use standard_homedir() to get the homedir if environment does not help. * libnessus/openvas-socket.h: New. Protos fpr socket wrapper to help with W32 handling. * libnessus/openvas-socket.c: New. Socket wrappers for W32. * libnessus/Makefile: Add handling of module openvas-socket. * libnessus/system.c (emalloc): Don't run the waitpid/sleep loop for W32. * libnessus/network.c: Everyhwere: Replace block_socket by openvas_sock_block, socket by openvas_sock_new, unblock_socket by openvas_sock_unblock, close by openvas_sock_close, connect by openvas_sock_connect. (unblock_socket, block_socket): Removed. Equivalents now in module openvas-socket. (open_socket): Use EINPROGRESS only if defined. 2009-04-02 Michael Wiegand <michael.wiegand@intevation.de> Post release version bump. * VERSION: Set to 2.0.4.SVN. * doc/Doxyfile, doc/Doxyfile_full: Set PROJECT_NUMBER to 2.0.4.SVN. 2009-04-02 Michael Wiegand <michael.wiegand@intevation.de> Preparing the openvas-client 2.0.3 release. * VERSION: Set to 2.0.3. * CHANGES: Updated. * doc/Doxyfile, doc/Doxyfile_full: Set PROJECT_NUMBER to 2.0.3. 2009-04-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> * po/de.po: Updated german translation. 2009-04-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> Changed wording to comply to standards. * nessus/prefs_dialog/prefs_report.c (show_popup_menu): Changed wording to comply to standards. 2009-04-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> Increased GTK+ version requirement (from 2.4 to 2.6). Resolved build problems when configured with --disable-gtk. * configure.in: Increased version requirement for gtk+. * nessus/Makefile: Moved hash_table_file object into util_objs list, NESSUSCLIENT target depending on utils target. * src/util/Makefile, src/openvas-lib/Makefile: Include GLib cflags. 2009-03-31 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_comment.c (prefs_dialog_comment): Proper use of scrolledwindow (adds border to text area, looks better), minimal doc improvements. 2009-03-31 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_comment.c: K&R Style replacements, minor reformatting. 2009-03-30 Felix Wolfsteller <felix.wolfsteller@intevation.de> Stricter use of g_free for strings allocated by glib, reformatting, typo fixed, use of g_strdup_printf instead of fixed-size array. * nessus/preferences.c: Changed return type of preferences_get_filename indeed a gchar*, and many other occurences where gchar* were handled as char* (important only when free'ing), reformatting. * nessus/preferences.c (new_pluginset): Use g_strdup instead of statically sized array. * nessus/preferences.c (preferences_save_as): Removed favorite typo (automagically). 2009-03-30 Felix Wolfsteller <felix.wolfsteller@intevation.de> Tackled compiler warnings (const poison). * src/gui/severity_override_form.c (add_override_to_global_filter, severity_override_form_to_override): Moved consistency/conflict checking to severity_override_form_to_override. * src/util/severity_filter.c (severity_filter_contains_conflicting): Renamed into severity_filter_contains_conflicting_override. * src/util/severity_filter.c (severity_filter_contains_conflicting): New, checks conflict state, but not given an override, but potential override information as strings. Needed for severity_form_override to avoid getting hold of a const override that has to be freed because it would conflict. * src/util/severity_filter.c (severity_filter_from_xml): Removed const from return type. * src/util/severity_filter.h: Updated protos. 2009-03-30 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/nvt_pref_sshlogin.h, src/gui/nvt_pref_sshlogin.c: USE_GTK guarded. 2009-03-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.c, nessus/comm.h (comm_delete_session, comm_stop_detached_session, comm_get_detached_sessions, comm_server_detached_sessions): Removed never used functions (pointed to by cppcheck). * nessus/comm.h: Moved include before defines. 2009-03-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/pdf_output.c (arglist_to_pdf): Fixed mem leak, use otherwise senseless function destroy_argv (pointed to by cppcheck). 2009-03-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/util/severity_filter.c (severity_filter_from_xml): Fixed mem leak, pointed to by cppcheck. * src/util/severity_filter.c: Minor reformatting (spacing). 2009-03-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/plugin_infos.c (show_deps): Made translation a bit easier, collapsed code. 2009-03-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/plugin_infos.c (show_deps): Use glib string functions instead of strcat and strcpy. 2009-03-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/nbe_output.c, nessus/nbe_output.h (nbe_to_backend): Declared parameter as const. * nessus/nbe_output.c: Minor reformatting and doc. 2009-03-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> Use gchar consistently (free with g_free), use g_build_filename where filenames are built. * nessus/report.c (report_get_filename, report_get_certificates_filename): Changed return type to gchar, use g_build_filename instead of malloc and sprintf, reformatting * nessus/report.c (report_save, open_report): Respect return types, free with g_free, minor reformatting. * nessus/report.c * nessus/report.h (report_get_filename, report_get_certificates_filename): Changed return type in protos to gchar. 2009-03-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> Use glibs functions instead of malloc + sprintf. * nessus/prefs_dialog/prefs_dialog_user.c (add_rule_callback): Use g_strdup_printf instead of emalloc + sprintf (one instance accidentially commited with last commit). 2009-03-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cosmetics in prefs_dialog_user module. * nessus/prefs_dialog/prefs_dialog_user.c: Added doc, reformatting. 2009-03-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> Use GLib type conversion macro to ensure 64-Bit compatibility. * nessus/comm.c (comm_parse_preference): Use type conversion macro int to pointer instead of pure void cast. 2009-03-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cosmetics in comm module. * nessus/comm.c: Minor reformatting. 2009-03-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> Resolved compiler warnings. * nessus/prefs_dialog/listnotebook.c (listnotebook_new): Cast function to Callback function. * src/util/openvas_ssh_key_create.c (openvas_ssh_key_create_rpm): Included unused variables in the "deactivation define", made proper comment after endif. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_create_rpm_click): Shadowed whole function in define. 2009-03-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> Before report export, remember reports is_severity_mapped state. Then disable the filter, do the export and switch it back. * nessus/report_save.c (file_save_ok_callback): Disable severity mapping before exporting report. Switch on afterwards if it was enabled before. 2009-03-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> Reference gchar*s as gchar*s, minor reformatting. * nessus/report_save.c (show_pdf): Change parameter type to gchar. * nessus/report_save.c (report_open_pdf): Type local variables as gchar* where gchar*s are returned from glib functions. 2009-03-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cosmetics in report_save module. * nessus/report_save.c: K&R Style replacements, doc reformatting. 2009-03-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> Assign and display icons to "False Positive"s, "Log Message"s and "Debug Message"s. Fixed mem leak (free displayed override- forms). * nessus/prefs_dialog/prefs_report.c (severity_level): Assigned severity level integers to "False Positive"s, "Log Message"s and "Debug Message"s. * nessus/prefs_dialog/prefs_report.c (severity_data_func): Added the stock icon identifiers to be associated to the ("new") severity levels. * nessus/prefs_dialog/prefs_report.c (severity_override_form_t): Returns the form itself, allows freeing them later. * nessus/prefs_dialog/prefs_report.c (addprio_click): Parent the dialog to the main window, free the forms. 2009-03-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/severity_override_form.c (severity_override_form_free): Free in reverse order, null- guarded. 2009-03-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cosmetis in listnotebook modoule. * nessus/listnotebook.c: K&R style replacement, minor reformatting. 2009-03-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed bug related to removal of severity_overrides from the list. * src/gui/severityfiltermngr_dlg.c (severityfiltermanager_dialog): Fixed bug related to removal of severity_overrides from the list (better guard and loop break when issue found). 2009-03-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> Report view (GUI, on the gright side) now shows icon next to severities icon if severities were overridden. More info in text-view at a better place. No addition of severity overrides possible if view is already filtered. * nessus/prefs_dialog/prefs_report.c (mapped_to): Renamed into mapped_from, returns the original severity now. * nessus/prefs_dialog/prefs_report.c (fill_tree_model, row_activated): Call mapped_from instead of mapped_to. * nessus/prefs_dialog/prefs_report.c (row_activated): Added information about original severity into the string in textview on the right, line of text now displayed before reported issues text. * nessus/prefs_dialog/prefs_report.c (isoverriden_data_func): New. Sets icon of a cellrenderer if current row contains severity- overriden issues. * nessus/prefs_dialog/prefs_report.c (severity_data_func): Set only icon of severity to cellrenderer (not the "overridden" icon). * nessus/prefs_dialog/prefs_report.c (show_popup_menu): If current Context is severity mapped, make menuitem insensitive. * nessus/prefs_dialog/prefs_report.c (prefs_dialog_report): Add new cell renderer, comments. 2009-03-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> In report module fixed minor issue (use of char* instead of gchar*), cosmetics in report and prefs_dialog module. * nessus/report.c: Cosmetics, reformatting, doc. * nessus/report.c (open_report): Local variable that is freed with g_free is indeed a gchar*, changed type of local var. * nessus/prefs_dialog/prefs_dialog.c: Reformatted doc. 2009-03-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/preferences.c (preferences_yes_or_one): Use GLibs pointer to int conversion macro e.g. for 64-Bit compatibility. 2009-03-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> Deactivated prototypical implementation of rpm- package generator for standard builds. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_create_rpm_click, ssh_keys_dialog_show): For standard builds, dactivated rpm generator code. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_create_rpm_click): Print debug message (but deactivated, conditioned on a define). * src/util/openvas_ssh_key_create.c (openvas_ssh_key_create_rpm): Improved, but for standard builds, dactivated rpm generator code (conditioned on define). 2009-03-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/util/severity_filter.c (severity_filter_apply): NULL- guarded, if not all parameter are non-NULL, return NULL. 2009-03-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> In reports tree- view (GUI, on the right if a report has been selected), display icons on severity-overriden issues, if any. Also indicate that a modification took place in the text. * nessus/prefs_dialog/prefs_report.c (mapped_to): New. Finds out if and how the severity of a single reported issue has been overriden. * nessus/prefs_dialog/prefs_report.c (fill_tree_model): Sets a flag in the tree model if the severity of a reported issue has been modified. * nessus/prefs_dialog/prefs_report.c (row_activated): Alters the text of a reported issue if its severity has been modified. 2009-03-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/data_mining.c, nessus/data_mining.h (report_query_single_line): New, queries certain values of a single line. * nessus/data_mining.c, nessus/data_mining.h (report_query_all_by_line): Made non-static. Exclude lines that are not queried. 2009-03-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/data_mining.c (subset_size): Minor doc and reformatting. 2009-03-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> Towards icons in the reports tree view (GUI-> right, when report is selected) indicating applied severity overrides. * nessus/prefs_dialog/prefs_report.c (fill_tree_model): Fixed bug, walk was not initialized. * nessus/prefs_dialog/prefs_report.c (fill_tree_model): Set list of contained issues in tree model. * nessus/prefs_dialog/prefs_report.c (row_activated): Pick up list of contained issues in tree model. 2009-03-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> Towards icons in the reports tree view (GUI-> right, when report is selected) indicating applied severity overrides. * nessus/prefs_dialog/prefs_report.c (enum, prefs_report_update): Added two more cols to the tree model: One indicating whether severities have been overriden, the other to carry a list of (indexes of) contained security messages. * nessus/prefs_dialog/prefs_report.c (fill_tree_model): Do not sort_uniq the severity messages, as we will need more information than just the severity type string. * nessus/prefs_dialog/prefs_report.c (severity_data_func): Choose "convert"- icon if current tree row is flagged as severity overriden. 2009-03-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cosmetics in prefs_report module. * nessus/prefs_dialog/prefs_report.c: Cosmetics, docs, whitespace removal, comments, reformatting. * nessus/prefs_dialog/prefs_report.h: whitespace removed. 2009-03-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> Outline of function to query certain records of the results "table" in nbe backend file (specified by line numbers as unique "ID"/ primary key). * nessus/data_mining.c (report_query_all_by_line): New. Method stub to access certain rows of the backends results "table". 2009-03-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cosmetics, docs, added comment about GLib 2.8 functionality. * nessus/data_mining.c (query_backend): Removed accidentially pasted declaration of local var. * nessus/data_mining.c: Cosmetics, docs, reformatting. 2009-03-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added id_line- field to subset struct to have a unique identifier for issues in a report/ backend (pseudo-sql implementation doesnt deliver primary keys). * nessus/data_mining.h (struct subset): Added field id_line. * nessus/data_mining.c (execute_query_flatfile): Set id_line when creating subsets. 2009-03-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cosmetics in data_mining module. * nessus/data_mining.c: Cosmetics. Doc, white-space removal, K&R style replacements, reformatting. * nessus/data_mining.c (execute_query_flatfile): Added debug- flag conditioned debug output. * nessus/data_mining.c (subnet_num_values): Removed (never used and misleading name). * nessus/data_mining.h (subnet_num_values): Removed proto. 2009-03-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/data_mining.c : Cosmetics. Doc, white-space removal, K&R style replacements. 2009-03-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/nessus.c (main): Fixed bug that caused global filter never to be created if the xml file did not exist. * src/util/openvas_ssh_key_create.c, src/util/openvas_ssh_key_create.c: (ensure_dir) Made convenient function non-static until a file utility module is created and this function is moved into it. 2009-03-20 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Further patches by Marcus Brinkmann towards a crosscompiling OpenVAS-Client based on mingw. * libnessus/Makefile (libnessus-client.a): Added handling for ranlib. * libnessus/addslashes.c: Added define of EXPORTING to have DllExport's. * include/config.w32: New. Windows-specific configurations. * nessus/Makefile, nessus.tmpl.in: Added handling for ".exe" extension. 2009-03-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/backend.c (priority_humanstr_to_short_str): New, extracted from backend_convert. Transforms one string representation of a severity level into yet another one. * nessus/backend.c (backend_convert): Fixed const issue (compiler warned) and extracted new method. 2009-03-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/backend.c: Cosmetics, minor reformatting and docs. 2009-03-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.c (send_ntp_opts): Removed deprecation flag and adjusted doc. The options that are sent ensure that the server behaves the way users might have got used to it. 2009-03-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/nessus.c: Include glib/gprintf.h to eliminate compiler warning. 2009-03-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed unneseecary field and related function in backend module, replaced a g_strconcat by g_build_filename. * nessus/backend.c (backend_init): Replaced g_strconcat by g_build_filename, removed setting of unused backend_type. * nessus/backend.c (backend_type): Removed (unreferenced). * nessus/backend.h (struct backend): Removed unused field backend_type. 2009-03-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/backend.c: Cosmetics, K&R style replacement, whitespace removal, minor doc. 2009-03-18 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cosmetics in the prefs_report module. * nessus/prefs_dialog/prefs_report.c: Added file doc, moved enum and const char tree_orders to beginning of file, reformatting and doc. * nessus/prefs_dialog/prefs_report.c (prefs_report_update): Changed parameter type to gboolean (called with either TRUE or FALSE anyway). 2009-03-18 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed auth_printf and auth_gets which were reported as unused by cppcheck. Reformatting and doc. * libnessus/network.c (auth_printf, auth_gets): Removed, cppcheck identified them as not being called ever. * libnessus/network.c: Replaced K&R function declarations, minor other reformatting and doc. * include/libnessus.h: Removed auth_printf forward declaration. 2009-03-18 Felix Wolfsteller <felix.wolfsteller@intevation.de> Update the report detail view (GUI, right side if report is selected) together with the scope tree (GUI, left side), so that when severity_overrides were applied / undone it is updated with eventually changed values as well. * nessu/prefs_dialog/prefs_scope_tree.c (prefs_scope_tree_update_report): Update the report view. 2009-03-18 Felix Wolfsteller <felix.wolfsteller@intevation.de> First tests for new feature that allows rpm export of credentials for LSC (conditioned on DEBUG flag, configure with --enable-debug to test). * src/gui/ssh_keys_dialog.c, src/util/openvas_ssh_key_create.c (openvas_ssh_privkey_create): Minor reformatting. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_show): Added new button to create rpm from openvas_ssh_login and registered callback. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_create_rpm_click): Callback for button, checks selected login and then starts rpm creation. * src/util/openvas_ssh_key_create.c (openvas_ssh_key_create_rpm): New. Fires up rpm creation processes, calling external tools. * src/util/openvas_ssh_key_create.h (openvas_ssh_key_create_rpm): Added proto. 2009-03-18 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removing first tests for the severity override mechanism. * src/util/priority.c, src/util/priority.h: Removed. * src/util/Makefile: Removed target. * src/gui/priorities_dialog.c, src/gui/priorities_dialog.h: Removed. * src/gui/Makefile: Removed target. * nessus/Makefile: Updated. * nessus/prefs_dialog/prefs_dialog.c: Removed obselete include. * MANIFEST: Updated. * po/POTFILES: Modified, after rename priority->severity was done, added severityfiltermngr_dlg, removed entry for header. 2009-03-17 Laban Mwangi <lmwangi@penguinlabs.co.ke> * nessus/nessus.c (connect_to_nessusd): Updated the certificate hash store to add a port to the hostname. Allows more than openvasd to run without confusing the client 2009-03-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.c (send_ntp_opts): Extracted from gui_comm_send_preferences and cli_comm_send_preferences and marked as deprecated as a comment suggests its of use to keep backward compatibility only. Can be removed after testing. 2009-03-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.c: Moved forward declaration behind the defines, slight modified documentation / comments. 2009-03-16 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Further patches by Marcus Brinkmann towards a crosscompiling OpenVAS-Client based on mingw. * nessus/prefs_dialog/prefs_dialog.c (add_nessus_icon_set): Some Windows header defines "small" and therefore the variable here is renamed to "small_icon". 2009-03-16 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Further patches by Marcus Brinkmann towards a crosscompiling OpenVAS-Client based on mingw. * src/util/openvas_ssh_key_create.c (openvas_ssh_privkey_create, openvas_ssh_pubkey_create): stdout and stderr can be macros in some build environments. Therefore renaming variables to something else. * nessus/data_mining.c (requests2lines): Make this function conditional to the presence of MMAP. * nessus/regex.c: Protect typedef of boolean from being done on WIN32. 2009-03-16 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Adding some patches by Marcus Brinkmann towards a crosscompiling OpenVAS-Client based on mingw. * configure.in: Added handling of RANLIB, added "mingw32" as further host. Added configure check to avoid regexp checking (--enable-internal-regex). * configure: updated. * nessus.tmpl.in: Added handling of RANLIB. 2009-03-16 Michael Wiegand <michael.wiegand@intevation.de> * nessus/OpenVAS-Client.desktop: Added to category Network as suggested by Scott Shinn to ensure OpenVAS-Client is placed in the correct menu in Fedora, CentOS and RHEL. Updated English, German and Spanish comments to indicate that the client is OpenVAS only and removed obsolete and confusing reference to Nessus. 2009-03-16 Michael Wiegand <michael.wiegand@intevation.de> * Makefile: Removed installation of openvasclient-mkrand man page since openvasclient-mkrand has not been installed using the install target since 2007-12-28. 2009-03-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Did the switch towards a per-report explicit on/off severity_override application. Note: the modifications to the backend and data-mining modules (apply overrides based on a flag of the __current__ context) might have influence on report generation, not tested. * src/gui/severityfiltermngr_dlg.c, nessus/prefs_dialog/prefs_dialog.c, nessus/prefs_dialog/prefs_scope_tree.c, src/util/severity_filter.c (severity_filter_apply): Removed reference to global_filter_active variable. * nessus/prefs_dialog/prefs_dialog.c (apply_severity_filter): Now functional. Swaps the is_priority_mapped flag of the current context and the menu items label. * nessus/prefs_dialog/prefs_dialog.c (switch_severity_filtering): Removed. * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_setup): Removed old menu entry. * nessus/prefs_dialog/prefs_scope_tree.c (scopetreeview_selection_func, prefs_scope_tree_update_report): Do not modify the is_severity_mapped flag from here. * nessus/data_mining.c (__split_line), nessus/backend.c (backend_convert): Added reference to current Context, apply severity overrides only if current contexts flag is set so. Influence on report export not tested. 2009-03-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/util/severity_filter.c: Slight doc improvements. * src/util/severity_filter.c (severity_filter_xml_elem, severity_filter_from_xml): Removed const from void return type. Adjusted error- checks, as user_data now is always passed non-NULL. 2009-03-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Moved initialization of global_filter to nessus.c:main. * nessus/nessus.c (main): Initialize global_filter. * nessus/nessus.c (struct MainDialog): Extended list of arglist- entries. * nessus/prefs_dialog/prefs_dialog.c (switch_severity_filtering), src/gui/severityfiltermngr_dlg.c (severityfiltermanager_dialog), src/gui/severity_override_form.c (add_override_to_global_filter): Removed conditional initialization of global_filter. * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_setup): Cast GtkWidget to get rid of compiler warning. * src/gui/severityfiltermngr_dlg.c: Added missing include. 2009-03-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/context.c: Doc added/improved. 2009-03-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added filename field to severity_filter struct. Made severity_to_xml static and access it only from the add and remove methods to ensure persistent state between filter in memory and on disk. Therefore made the add and remove methods returning gboolean. Removed all code that involved filter_to_xml from outside the severity_filter module, minor reformatting and doc improvements. Changed file name for global severity filter from priofilter.xml to severity_overrides.xml. * src/util/severity_filter.c, src/util/severity_filter.h (severity_filter_to_xml): Made severity_filter_to_xml static. * src/util/severity_filter.c, src/util/severity_filter.h (severity_filter, severity_filter_new): Added filename parameter to struct and severity_filter_new. * src/util/severity_filter.c (severity_filter_free): Free filename, reformatted. * src/util/severity_filter.c (severity_filter_contains_conflicting): Collapsed conditional with same consequence. * src/util/severity_filter.c (severity_filter_add): Saves to xml file. * src/util/severity_filter.c, src/util/severity_filter.h (severity_filter_remove): Changed return type to gboolean, saves to xml. * src/util/severity_filter.c, src/util/severity_filter.h (severity_filter_to_xml): Removed filename parameter, now stored in severity_filter struct. * src/util/severity_filter.c (severity_filter_xml_elem, severity_override_xml_elem, severity_filter_xml_start_element, severity_override_xml_reason_text): Changed logic of user_data for xml element callbacks: where it was an double pointer before, always pass a pre-initialized severity_filter. * src/gui/severityfiltermngr_dlg.c (severityfiltermanager_dialog), src/gui/severity_override_form.c (add_override_to_global_filter), nessus/prefs_dialog/prefs_dialog.c (switch_severity_filtering): No need for explicit saving anymore, use new file name severity_overrides.xml. Display message if saving failed. 2009-03-15 Tim Brown <timb@nth-dimension.org.uk> * Fixed memory leak as reported by cppcheck. 2009-03-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/severity_override_form.c (severity_override_form_free, severity_override_form_lock): Eliminated compiler warnings through widget casts. 2009-03-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> Changed wording of menu items. * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_setup), nessus/prefs_dialog/prefs_report.c (show_popup_menu): Changed wording for menu items connected to severity (former priority) override functionality. 2009-03-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> Towards a different mode of applying severity overrides (per-report via menu item vs. per-clicked-report depending on toggle state.) * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_setup): Added (yet non-functional) menu item to apply/undo severity overrides on reports. * nessus/prefs_dialog/prefs_dialog.c (apply_severity_filter): Callback function for new menu item (basically empty). * nessus/prefs_dialog/prefs_context.c (prefs_context_update_widgets): Toggle new menu items sensitivity (only applicable on reports) and label, improved documentation. 2009-03-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_dialog.c: Corrected wrong include statement (broke) build. * nessus/prefs_dialog/prefs_dialog.c (menuitem_add): Documentation for parameters added. 2009-03-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> In the report-view (right hand side of GUI), add text to show the user that the severity of an issue (alert) has been changed by an override, if that is the case. Note that due to a "bug" this currently works only if you did something with the overrides in the currently running Client (inspect, add override or apply). * nessus/prefs_dialog/prefs_report.c (row_activated): Renamed priority to severity where applicable. * nessus/prefs_dialog/prefs_report.c (row_activated): Added debug string about the query that results in the report view. * nessus/prefs_dialog/prefs_report.c (row_activated): Add text to text view to indicate change of severity, if overrides are applied. * nessus/prefs_dialog/prefs_report.c (row_activated): Free overrides that have been created for and stored in the list of currently selected issues. * nessus/prefs_dialog/prefs_report.c (severity_data_func): Marked spot where an additional icon should be placed if an override was applied. 2009-03-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> Prohibit addition of conflicting (same OID, host, port, severity_from) overrides to the global_filter. * src/util/severity_filter.c (severity_override_similarity_predicate): New. To be used in a g_slist_find_common to find conflicting overrides. * src/util/severity_filter.c (severity_filter_contains_conflicting): New. To be used to query if a filter contains an override conflicting a given override. * src/util/severity_filter.h: Added proto for new function. * src/gui/severity_override_form.c (add_override_to_global_filter): Perform conflict-check before adding an override to the global_filter. 2009-03-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> Renamed priority overrides to severity overrides, also in-source. * nessus/prefs_dialog/prefs_report.c, nessus/prefs_dialog/prefs_scope_tree.c, nessus/prefs_dialog/prefs_dialog.c, nessus/data_mining.c, nessus/backend.c :Renamed include and references. * nessus/context.c, nessus/context.h: Renamed field of context from is_priority_mapped to is_severity_mapped. * src/gui/priofiltermngr_dlg.c, src/gui/priofiltermngr_dlg.h, src/util/priority_filter.c, src/util/priority_filter.h, src/gui/priority_override_form.c, src/gui/priority_override_form.h : Moved. (replace priority in filename by severity), renamed everything priority- like to severity-like. * nessus/Makefile, src/util/Makefile, src/gui/Makefile: Updated. * MANIFEST: Updated. 2009-03-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/priority_override_form.c (priority_override_form_free): New. Frees the widgets and associated memory. * src/gui/priority_override_form.h (priority_override_form_free): Proto added. 2009-03-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Made xml writing a bit more robust. Strip leading and trailing whitespaces off the text that defines an overrides reason. * src/util/priority_filter.c (write_override_xml_elem): Escape xml content using g_markup_printf_escaped. * src/util/priority_filter.c (priority_filter_to_xml): Escape xml content using g_markup_printf_escaped. * src/util/priority_filter.c (write_override_xml_elem): Escape xml contents using g_markup_printf_escaped. * src/util/priority_filter.c (priority_override_xml_reason_text): Strip whitespaces from the text for an overrides reason. 2009-03-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Introduced actions to the priority_override_form to enhance reusability. Reused the form in the Filter Manager to beautify it. * src/gui/priority_override_form.c: File doc block added. * src/gui/priority_override_form.c (priority_override_form_new): Added parameter formaction to decide whether to lock the form or add an add-button to it. * src/gui/priority_override_form.c (priority_override_form_lock): New function to lock down input to a form. * src/gui/priority_override_form.c (priority_override_form_from_override): Parameter added, is passed to priority_override_form_new. * src/gui/priority_override_form.h: Protos for (new) functions added/ modified. * src/gui/priority_override_form.h (enum formaction, struct priority_override_form): New enum to define possible actions that a form can help doing. Added field to struct, minor reformating and doc. * src/gui/priofiltermngr_dlg.c: Added priority_override_form include. * src/gui/priofiltermngr_dlg.c (priofiltermngr_dlg_add_override): Declared parameter as const. * src/gui/priofiltermngr_dlg.c (priofiltermngr_dlg_add_override): Use form instead of not-so-nice-looking label. Init form with the view- action. * nessus/prefs_dialog/prefs_report.c (create_override_page): Init form with the add- action. 2009-03-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Tackled 3 compiler warnings. * src/gui/priority_override_form.h: Added newline at end of file. * src/gui/priofiltermngr_dlg.c: Added missing include, cast function pointer handed over to g_slist_foreach correctly. 2009-03-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/priority_override_form.c (priority_override_form_new): Made table looking better (left aligned labels). * src/gui/priority_override_form.c (priority_override_form_from_override) Fixed bug that changed text for the wrong labels. 2009-03-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_report.c (row_activated): Get name of NVT and set it as default value for an overrides name when user clicks in report view. * nessus/prefs_dialog/prefs_report.c (addprio_click): In the dialog to add an override to the global filter, display the overrides name (so the nvt name) in the overview on the left, not the OID. 2009-03-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/priority_override_form.c: Added forward declaration of priority_override_form_valid. * src/gui/priority_override_form.c (priority_override_form_from_override): Set text for entries name and reason according to name and reason of override. * src/gui/priority_override_form.c (priority_override_form_new): Added cast to eliminate compiler warning. * src/gui/priority_override_form.h: Added include guards. 2009-03-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_report.c (row_activated): Reformatted part that is going to be changed. 2009-03-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_report.c (row_activated): Reformatted part that is going to be changed. 2009-03-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Eliminated compiler- warnings. * src/util/priority_filter.c (priority_override_form_valid): Added forward declaration. * nessus/prefs_dialog/prefs_dialog.c, src/util/priority_filter.c: Corrected type extern global_filter_active. 2009-03-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Moved code to recalculate counters and refresh scope view to prefs_scope_tree module, declared some functions in that module static. * nessus/prefs_dialog/prefs_scope_tree.c: Added static keyword to various function that are used only within the module. * nessus/prefs_dialog/prefs_scope_tree.c (prefs_scope_tree_update_report): New, pretends a reselection of currently selected row, if a report is shown (copied from priofiltermngr). * nessus/prefs_dialog/prefs_scope_tree.h (prefs_scope_tree_update_report): Added proto. * src/gui/priofiltermngr_dlg.c: Added some missing includes. * src/gui/priofiltermngr_dlg.c (priorityfiltermanager_dialog): Replaced code by call to new prefs_scope_tree_update_report function. * nessus/prefs_dialog/prefs_dialog.c: Added some missing includes. * nessus/prefs_dialog/prefs_dialog.c (switch_priority_filtering): Replaced code by call to new prefs_scope_tree_update_report function, eliminated compiler warnings through casts. 2009-03-11 Felix Wolfsteller <felix.wolfsteller@intevation.de> Made priority_override_form validate values on "Add"- action, removed many compiler warnings by casts. * src/gui/priority_override_form.c (priority_override_form_valid): New, does some sanity checking. * src/gui/priority_override_form.c (add_override_to_global_filter): Add override only when validation returned TRUE. * src/gui/priority_override_form.h (priority_override_form_to_override): Changed signature (return const). * src/gui/priority_override_form.c (priority_override_form_to_override): Changed signature (return const). * src/gui/priority_override_form.h, src/gui/priority_override_form.c: Corrected year (2009) in header comment block. 2009-03-10 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * src/gui/priofiltermngr_dlg.c (priorityfiltermanager_dialog): Removed the temporary label that indicated whether filter is on or off. 2009-03-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> Allow addition of overrides to global priority_filter. * src/gui/priority_override_form.h: Added newline at end of file. * src/gui/priority_override_form.c (add_override_to_global_filter): New. Adds override to global filter, callback for add- button. * src/gui/priority_override_form.c (priority_override_form_new): Added add-button and registered callback, allows addition of overrides specified in a form to the global_filter. * src/gui/priority_override_form.c (priority_override_form_to_override): Fixed. Before, read values from wrong labels. 2009-03-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_dialog.c (switch_priority_filtering): Apply filter when checkbox was ticked/ unticked. 2009-03-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> First steps towards cleaner module boundaries: Use priority_override_form to create visualization widget for priority_overrides. * nessus/prefs_dialog/prefs_report.c: Include of priority_override_form added. * nessus/prefs_dialog/prefs_report.c (create_override_page): Use priority_override_form instead of creating GUI in this module. 2009-03-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> Allow deletion of overrides from the Priority Filter Manager GUI. Prototypical implementation. * src/gui/priofiltermngr_dlg.c: Added reference to extern global_filter_active flag. * src/gui/priofiltermngr_dlg.c (priorityfiltermanager_dialog): Respect the global_filter_active flag, allow deletion of overrides. 2009-03-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added function to remove an override from a priority_filter. * src/util/priority_filter.c, src/util/priority_filter.h (priority_filter_remove): New function. Removes and frees an override from a filter. 2009-03-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added stub for new module priority_override_form that acts as a Viewer and editor for a priority_override much in the same fashion as in the SSH Credentials Manager. An actual own widget implementation might grow out of this stub. * src/gui/priority_override_form.h, priority_override_form.c: Skeleton for a widget that allow creation and modification of priority_overrides. * src/gui/Makefile: Included target. * nessus/Makefile: Included object. * MANIFEST: Updated. * po/POTFILES: Updated. 2009-03-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> Show dialog to add priority_overrides to the global priority_filter when item in popup-menu is clicked. Dialog is dummy, does not do anything yet. * nessus/prefs_dialog/prefs_report.c: Added includes. Future separation into separate modules is neccessary and planned. * nessus/prefs_dialog/prefs_report.c: Added reference to global MainDialog arglist. * nessus/prefs_dialog/prefs_report.c (row_activated): Initializes a list of overrides when in the report view something is selected. If a list with a further selection existed, free it. Register the list in the arglist for this view when finished. * nessus/prefs_dialog/prefs_report.c (create_override_page): New. Creates a widget containing information about an override, allows editing. * nessus/prefs_dialog/prefs_report.c (addprio_click): New. Callback for click on the popupmenu. Opens a dialog with a listnotebook showing the selected security issues to create overrides from (utilizes new create_override_page). * nessus/prefs_dialog/prefs_report.c (show_popup_menu): Changed label of menuitem and registered callback (addprio_click) for it. * nessus/prefs_dialog/prefs_report.c (prio_button_press): Indicate that a right mouse button click was not handled to allow selections with rmb. * nessus/prefs_dialog/prefs_report.c (prefs_dialog_report): Added new key "SELECTED_ISSUES" with (empty) list to the ctrls- arglist for this view. 2009-03-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_scope_tree.c: Added reference to extern global_filter_active. * nessus/prefs_dialog/prefs_scope_tree.c (scope_move_menuitem_enable): Minimal reformatting. * nessus/prefs_dialog/prefs_scope_tree.c (scopetreeview_selection_func): Added documentation, respect global_filter_active flag when asked whether to display the "filter" icon or not. 2009-03-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/nvt_pref_sshlogin.c, src/gui/nvt_pref_sshlogin.h (text_combobox_set_active_text): Made convenient function public, renamed frame (per-target -> per-host). 2009-03-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed testing-mechanism of global priority switching between NULL and real instantiation. Instead added Checkbox- Menuitem to dis/enable priority filtering. Priority Filter Dialog shows global filter regardless of activity and initializes and saves to disk if none found. * nessus/prefs_dialog/prefs_dialog.c: References to global_filter and global_filter_active added, respective include added. * nessus/prefs_dialog/prefs_dialog.c (switch_priority_filtering): New. Callback for new CheckBoxMenuItem, creates global filter if none there yet and sets the global priority filtering active flag. * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_setup): Added Checkbox MenuItem. * src/gui/priofiltermngr_dlg.c (priorityfiltermanager_dialog): Initialize global_filter if not loaded yet. 2009-03-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added global boolean to indicate state (in/active) of priority filtering, new function to duplicate a priority_override. * src/util/priority_filter.c: Added global gboolean to indicate state (in/active) of filter. * src/util/priority_filter.c (priority_override_duplicate): New. Duplicates a priority_override. * src/util/priority_filter.h (priority_override_duplicate): Added proto for new function. * src/util/priority_filter.c (priority_filter_apply): Apply filter only when (new) global boolean is true. * src/util/priority_filter.c: Minimal changes in documentation, whitespaces. 2009-03-09 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * src/gui/priofiltermngr_dlg.c: Added missing include. (priofiltermngr_dlg_add_override): Fixed a bug: port and reason were mixed up. 2009-03-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added outline for context-popup-menus on the treeview that shows security issues from a report (right hand side in GUI). (Menu has no function yet, will allow priority override generation from reported issues) * nessus/prefs_dialog/prefs_report.c (prio_button_press, prio_show_popup, show_popup_menu): New. Allow context menus on rmb clicks on the treeview that shows security issues. * nessus/prefs_dialog/prefs_report.c (prefs_dialog_report): Connect the appropriate signals to the new functions. 2009-03-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed typo that broke build. * src/gui/priofiltermngr_dlg.c (priorityfiltermanager_dialog): Fixed typo that broke build. 2009-03-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_report.c: Transformed/improved documentation blocks. 2009-03-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> Allow inspection of a priority_filter with the Priority Filter Manager Dialog. Enabled immediate update of icon and numbers in the scopetree. The report-view on the right hand side is not yet updated in place. Layout-stub done by Jan-Oliver-Wagner. * src/gui/priofiltermngr_dlg.c: Include includes.h for arglists, context.h for Context. * src/gui/priofiltermngr_dlg.c: Added references to global Dialog arglist (MainDialog), current context (Context). * src/gui/priofiltermngr_dlg.c (priofiltermngr_dlg_add_override): New. Adds page with information about a priority_override to a listnotebook. * src/gui/priofiltermngr_dlg.c (priorityfiltermanager_dialog): Added listnotebook to dialog, fill listnotebook with details of overrides, added Delete- Button, update scopetree when testfilter-state changed. 2009-03-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> "Scopetree" (left half of GUI) now shows an icon next to a reports name if in the current view a priority_filter is applied. Applying a filter currently is only implemented for testing purposes and done by switching the test filter on via the "Extras" menu. Then each click to selected a report will enable the filter (thus, the currently selected report is unaffected for the time being). Removing a filter works by switching off the testfilter via the "Extras" menu and then do the selection. The filter and selection just works on memory; restarting OpenVAS-client will undo any filtering- effect. * nessus/context.h (struct): Added field is_priority_mapped to the context struct that indicate wether a report is priority_filtered or not. * nessus/context.c (context_init): Initialize the new field to FALSE. * nessus/prefs_dialog/prefs_scope_tree.c: Include priority_filter.h added. * nessus/prefs_dialog/prefs_scope_tree.c: Reference to extern global_filter added. * nessus/prefs_dialog/prefs_scope_tree.c (connected_data_func): Reformatted part that does the connection-icon selection, added case where icon is set for a context that has a filter applied. * nessus/prefs_dialog/prefs_scope_tree.c (scopetreeview_selection_func): If global_filter is set and a report is selected, set the contexts is_priority_mapped flag. 2009-03-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/context.c (context_add_plugin): Doc added. * nessus/context.c (context_pickup_sshkeys): Use gchar* and g_free for memory allocated by GLib functions. 2009-03-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> Renamed Stock-item key from nessus-(dis)connect to openvas-(dis)connect. * nessus/prefs_dialog/prefs_scope.c (create_nessus_icon_factory, prefs_dialog_setup): Renamed stock-item. * nessus/prefs_dialog/prefs_scope_tree.c (connected_data_func): Use renamed stock-item- key. 2009-03-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> Include the number of log messages in the count-cache file (.cnt) that is used to fill the table of reports (left side in GUI), cosmetics. * nessus/prefs_dialog/prefs_scope_tree.c: Documentation and whites spaces added. * nessus/prefs_dialog/prefs_scope_tree.c (scopetreestore_counters_update): Documentation added, use of g_strdup_printf and gfree instead of snprintf etc. Renamed local variables h,w,n,f,l to highs,warnings... etc, included nr of log messages into the cnt file. 2009-03-07 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * src/gui/priofiltermngr_dlg.c (priorityfiltermanager_dialog): Changed string representation of severity. * nessus/data_mining.c (__split_line): Apply filter for severity. * nessus/backend.c (backend_convert): Apply filter for severity. 2009-03-06 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * src/util/priority_filter.c (priority_filter_xml_elem, priority_override_xml_elem, priority_filter_xml_start_element, priority_override_xml_reason_text): New. Handling for parsing xml file. Main author is Felix Wolfsteller. (priority_filter_from_xml): Added implementation. Main author is Felix again. 2009-03-06 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * src/util/priority_filter.c: Added file doc string and various macros for XML keywords. (priority_override_new): Added parameter for directly setting the active flag. (write_override_xml_elem): New. Write a override object in xml format. (priority_filter_to_xml): Added implementation. * src/util/priority_filter.h: Updated proto for priority_override_new. * src/gui/priofiltermngr_dlg.c (priorityfiltermanager_dialog): Use priority_override_new with additional parameter. For testing purposes create and read a filter xml file. 2009-03-06 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed bug: Client always attempted to send 'login to host' mapping file, even if none existed. * nessus/comm.c (send_ssh_credential_files): If no files that define a mapping for login-information to hosts exist, do not add their patjes to the list of files to send. Otherwise error messages about missing files come up (e.g. first scan on a fresh installation). 2009-03-06 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.c: Added briefs to comments, replaced K&R style, minor reformatting. 2009-03-06 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * src/util/priority_filter.c (global_filter): Added this global filter. (priority_filter_from_xml, priority_filter_to_xml): New. Stubs for xml representation of a filter. (priority_filter_apply): New. * src/util/priority_filter.h: Added protos for priority_filter_apply, priority_filter_to_xml and priority_filter_from_xml. Added declaration of global_filter. * src/gui/priofiltermngr_dlg.c (priorityfiltermanager_dialog): Switched to use global filter instead of local static one. Added a second sample override. 2009-03-06 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * src/util/priority_filter.c, src/util/priority_filter.h: New. Module for handling of priority filters. * src/util/Makefile, nessus/Makefile: Added handling of module priority_filter. * src/gui/priofiltermngr_dlg.c (priorityfiltermanager_dialog): For testing purpose added toggling creation of a filter and respectively removal of it. * MANIFEST: Updated. 2009-03-05 Vlatko Kosturjak <kost@linux.hr> * configure, configure.in: Removal of PCAP_TIMEOUT_IGNORED which is not used any more in the source 2009-03-05 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Introducing the "Extras" menu to collect helpers and not let them distribute all over the GUI. * priofiltermngr_dlg.c, priofiltermngr_dlg.h: New. Shell for the Priority Filter Manager Dialog, currently containing only the note that it is not yet implemented. * src/gui/Makefile: Added handling of new module priofiltermngr_dlg. * nessus/Makefile: Added module "priofiltermngr_dlg" to GUI_OBJS. * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_setup): Added "Extas Menu" with "LSC Credentials Manager" and "Priority Filter Manager" and moved "SLAD Install" from "File" menu to "Extras". * nessus/prefs_dialog/prefs_dialog_prefs.c (prefs_dialog_prefs): Removed button for LSC Credentials Manager. * MANIFEST: Updated. 2009-03-05 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * src/openvas-lib/Makefile, src/gui/Makefile, src/util/Makefile, nessus/Makefile: Replace term "NESSUS_INCLUDE" by "OPENVAS_INCLUDE". 2009-03-05 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * MANIFEST: Updated (missing doxygen files) 2009-03-05 Michael Wiegand <michael.wiegand@intevation.de> * CHANGES: Fixed misleading comment regarding silent dependencies. 2009-03-05 Michael Wiegand <michael.wiegand@intevation.de> Post release version bump. * VERSION: Set to 2.0.3.SVN. * doc/Doxyfile, doc/Doxyfile_full: Set PROJECT_NUMBER to 2.0.3.SVN. 2009-03-05 Michael Wiegand <michael.wiegand@intevation.de> Preparing the openvas-client 2.0.2 release. * VERSION: Set to 2.0.2. * CHANGES: Updated. * MANIFEST: Added missing entries. * doc/Doxyfile, doc/Doxyfile_full: Set PROJECT_NUMBER to 2.0.2. 2009-03-05 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/Makefile: Added parseutils.o to UTIL_OBJS. 2009-03-05 Felix Wolfsteller <felix.wolfsteller@intevation.de> Moved parseutils module back into src/ directory. * nessus/parseutils.h, nessus/parseutils.c: Moved to src/util. * src/util/parseutils.c, src/util/parseutils.h: Moved from nessus/. * nessus/Makefile: Removed target. * src/util/Makefile: Added target. * MANIFEST: Updated. 2009-03-05 Felix Wolfsteller <felix.wolfsteller@intevation.de> Moved code with former different copyright from parseutils module back into parser module. Credited copyright- holder of new code (intevation GmbH) and author (Joey Schulze) in parseutils, applied GPL/(c) header as in original commit of Joey. This partially reverts my changes in yesterdays rev. 2654 in which Joey Schulze as a author and the copyright- owner was not properly mentioned. Futhermore adjusted includes as a consequence of moved functionality. * nessus/parser.c (priority_name_to_type, priority_type_to_str): Moved from parseutils module. * nessus/parseutils.c (priority_name_to_type, priority_type_to_str): Moved to parser module. * nessus/parser.h: Added protos, moved various defines from parseutils module. * nessus/parseutils.h: Moved protos and defines to parser module. * src/gui/priorities_dialog.c: Added include. * src/util/prioritiy.c: Added include. 2009-03-04 Michael Wiegand <michael.wiegand@intevation.de> * nessus/rand.c: Added commented RATS ignore since moderate randomness is enough for our purpose here. 2009-03-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> Disabled priority mapping at server message parsing level. Code remained. Parser module should behave like in rev. 1791. * nessus/parser.c (parse_host_add_data): Disabled modifications of data regarding security messages. 2009-03-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> Use of g_strdup_printf instead of malloc + sprintf, cosmetics in parser module. * nessus/parser.c: Moved defines to beginning of file. * nessus/parser.c (is_mac_addr, parse_server_error): Shortened comment blocks. * nessus/parser.c (parse_modify_data): use g_strdupo_printf + g_free instead of emalloc + sprintf + free. * nessus/parser.c (parse_nessusd_short_status): Gave example in comment. 2009-03-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> Disabled "Edit Priorities" menu item. * nessus/prefs_dialog/prefs_dialog.c, nessus/prefs_dialog/prefs_context.c: Disabled "Edit Priorities" menu item. 2009-03-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> Moved parseutils module (extracted from parser module in rev 2610) back into nessus dir, due to unclear copyright and licensing. * src/util/parseutils.c, src/util/parseutils.h: Moved to nessus/, reverted GPL and copyright header. * nessus/parseutils.h, nessus/parseutils.c: Moved from src/util, reverted GPL and copyright header. * src/util/Makefile: Removed parseutils target. * nessus/Makefile: Included parseutils target. * MANIFEST: updated. 2009-03-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/ssh_key_info_form.c (ssh_key_info_form_create): Modified label text to indicate that password is optional (and may indeed be ignored by current ssh_authorization.nasl). 2009-03-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> Replaced #ifdef DEBUGMORE switches by #ifdef DEBUGs. * include/config.h.in: No need to undef MOREDEBUG anymore. * nessus/parser.c, src/util/parseutils.c: Replaced DEBUGMORE by DEBUG. 2009-03-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> Improved documentation of data_mining module, minor reformatting. * nessus/data_mining.c: Improved documentation. * nessus/data_mining.c (__split_line): K&R style replacement. 2009-03-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> Renamed the OpenVAS SSH Key Manager into the OpenVAS LSC Credentials Manager. * src/openvas-lib/openvas_ssh_login.h, src/gui/ssh_keys_dialog.c, src/util/openvas_ssh_key_create.c, src/util/openvas_ssh_key_create.h, nessus/prefs_dialog/prefs_dialog_prefs.c, src/openvas-lib/openvas_ssh_login.c: Reworded ~SSH Key into LSC Credentials. * nessus/prefs_dialog/prefs_dialog_prefs.c (prefs_dialog_prefs): Use non-default box adding for slightly better look. 2009-03-03 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/parser.c: Cosmetics, K&R style replacements, documentation, formatting. 2009-03-03 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/backend.c: Added commented RATS ignores where strlen is called on string literals. 2009-03-03 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/priorities_dialog.c, nessus/plugin_infos.c: Added missing includes. 2009-03-03 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added Button to open plugin_info dialog from priority editing dialog, fixed bug when viewing editing priorities of empty report, fixed mem leaks, minor doc and reformatting. * src/gui/priorities_dialog.c: Added plugin_infos.h include. * src/gui/priorities_dialog.c (edit_priority, -priorities_keypress_cb, priorities_dialog): Minor reformatting and extension of documentation and function declarations. * src/gui/priorities_dialog.c (edit_priority): Use gchar + g_strdup_printf instead of malloc + snprintf, fixed mem leaks where strings for labels were not freed, added Button to open plugin_info dialog. * src/gui/priorities_dialog.c (priorities_dialog): When empty priority chain returned, show warning and abort. 2009-03-03 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/plugin_infos.c, nessus/plugin_infos.h (plugin_info_window_show_cb): Method takes name instead of OID to avoid double traversal of plugin list. 2009-03-03 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/plugin_infos.c: Removed debug-survivor-printf. 2009-03-03 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/plugin_infos.c, nessus/plugin_infos.h (plugin_info_window_show_cb): New, callback method can be used to show plugin info dialog when only a NVTs OID is known. 2009-03-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed obsolete code and variables in cli module, pointed to by cppcheck. * nessus/cli.h (struct cli_args): Removed auth_pwd & cipher member. * nessus/cli.h, cli.c (cli_args_auth_pwd, cli_auth_pwd, cli_args_cipher): Removed references to auth_pwd and cipher. 2009-03-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed obsolete module families, pointed to by cppcheck. * nessus/families.h, nessus/families.c: Removed. Not used, a tree-based approach is used instead. * nessus/prefs_dialog/prefs_plugins_tree.c, nessus/prefs_dialog/prefs_plugins.c: Removed families.h include. * nessus/Makefile: Removed target and include of families.h . * MANIFEST: Removed families- entries. 2009-03-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> Use GTK Spin-Buttons instead of plain text fields for preferences ~"max hosts to check concurrently" and ~"max checks concurrently", to allow a minimum of input sanitizing (expecting integers here). * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_set_defaults): Set values to spinbuttons as float (atof), not as string. * nessus/prefs_dialog/prefs_dialog_scan_opt.c (prefs_dialog_scan_opt): Initialize GtkSpinButtons rather than plain text fields for preferences that - at the end - expect integers anyway. Set limit for max hosts/checks to perform concurrently arbitrarily high to 1000. * nessus/nessus.c (struct MainDialog): Added keys of scan_options to documentation of the "main" gui arglist to ease later refactorization. 2009-03-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_dialog.c (set_yesno_pref_from_toggle, prefs_dialog_apply_plugin_prefs, arg_int_to_yesno): Added RATS ignores where strlen is called on string literals. * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_apply): Use estrdup instead of malloc and snprintf. 2009-03-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_dialog_scan_opts.c: Tranformed doc blocks, K&R style replacements. 2009-03-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> In module data_mining, added GPL header from implementation file to header file. * nessus/data_mining.h: Added GPL header from modules implementation file (nessus/data_mining.c). 2009-03-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added commented RATS ignores. * src/gui/error_dlg.c (show_dialog_std): Added RATS ignore: Calling getchar but not filling any buffer. * nessus/auth.c (auth_login): Added RATS ignore: Strlen on buffer that is nul-terminated as it comes from network_gets. 2009-03-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/auth.c, nessus/prefs_dialog/prefs_plugins.c, nessus/prefs_dialog/prefs_plugins_tree.c: K&R style replacements, doc, minor refomatting. 2009-03-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> In filter module, added GPL header from implementation file to the header file. * nessus/filter.h: Added GPL Header from modules implementation file (nessus/filter.c). 2009-03-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/ssh_keys_dialog.c: Documentation added/improved. * nessus/prefs_dialog/listnotebook.h: Removed white spaces and commented proto. * nessus/cli.c: Removed zlib include, minor reformatting. * nessus/preferences.c, nessus/attack.c, nessus/html_output.c, nessus/prefs_dialog/prefs_scan_assistant.c, nessus/nessus_plugin.c: Documentation, K&R style replacements. 2009-03-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/latex_output.c: Fixed typo in text. * README: Minimal change to wording, reference to openvas-discuss rather than openvas-users. 2009-03-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> * ssl/openvasclient-mkrand.c: Reformatted (moved includes behind the gpl header), extracted file doc block. 2009-03-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added one RATS ignore, cosmetics. * libnessus/rand.c: Added RATS ignore where size is sane, minimal doc and reformat. * libnessus/arglists.c: Minimal reformat, doc. * libnessus/system.c: Minimal reformat. 2009-02-28 Joey Schulze <joey@infodrom.org> * nessus/parser.c (parse_modify_data, parse_host_add_data): Switch priorities adjustment methods to host based configuration * nessus/parser.h: Include context.h to fulfil datastructure dependencies * src/util/parseutils.c (priority_name_to_type, priority_str_to_type, priority_type_to_name, priority_type_to_str): New source file for conversion of priority types parse_message_type renamed into priority_name_to_type parse_expand_type renamed into priority_type_to_str * nessus/monitor_dialog.c, nessus/cli.c: Add parseutils.h as new include file * src/gui/priorities_dialog.c: Add new Priorities Editor priorities_dialog() and support functions * src/util/priority.c: Add support functions for handling priorities 2009-02-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/util/openvas_ssh_key_create.c (openvas_ssh_key_create_unlink_files): When information in .logins is corrupted and as a result the computed length of file name for identity file is <= 0, skip memory allocation for the string holding it. 2009-02-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/ssh_keys_dialog.c: Documentation. 2009-02-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added client-side support for username/password authentification using the OpenVAS SSH Key Manager. GUI is extended by a password text entry, value is saved in .ssh/.logins. The current server will ignore these values (per-host user/password logins will not work yet). * src/openvas-lib/openvas_ssh_login.h: Added new member userpassword, adjusted the prototype to create a new login. * src/openvas-lib/openvas_ssh_login.c: Added new keyword for key file that saves the information for logins, respect the new userpassword. * src/openvas-lib/openvas_ssh_login.c (openvas_ssh_login_file_read): Ignore error if keyword for password not found in keyfile (allows seamless migration from older .logins). * src/gui/ssh_key_info_form.h: Added new member (text entry for password) to the ssh_key_info_form struct. * src/gui/ssh_key_info_form.c: Extended GUI by text-entry for text entry. 2009-02-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> Improved doc in ssh_key_info_form module. * src/gui/ssh_key_info_form.c: Improved doc and readability of doc. 2009-02-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> Improved doc, closed mem-leaks in case of errors, format. * src/openvas-lib/openvas_ssh_login.c: Improved doc, minor reformatting, removed whitespaces. * src/openvas-lib/openvas_ssh_login.c (openvas_ssh_login_file_write): Do no further processing and free error struct in case of errors. 2009-02-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/util/openvas_ssh_key_create.c (openvas_ssh_key_create_unlink_files): NULL- guard file unlinking. * src/util/openvas_ssh_key_create.c (openvas_ssh_privkey_create, openvas_ssh_pubkey_create): Use g_strlcpy instead of strncpy. 2009-02-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/read_target_file.c: Minimal doc improvement. * nessus/read_target_file.c (target_file_name, read_target_file): target_file_name indeed returns gchar, adjusted return type and use g_free when freeing the returned value. 2009-02-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/plugin_cache.c: Beautified documentation. * nessus/plugin_cache.c (plugin_cache_get_filename, plugin_cache_write, plugin_cache_read): plugin_cache_get_filename indeed returns a gchar, adjusted return type and free it accordingly with g_free. 2009-02-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_kb.c: Documentation added, K&R replacements whitespaces removed. * nessus/prefs_dialog/prefs_kb.c (arg_addset_value): Signature changed. Lead to compiler warnings after K&R function declaration replacement. 2009-02-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/nessus.c (MainDialog): Added list showing arglists contents that has been identified so far. * nessus/nessus.c (init_globals): Removed forward declaration of never implemented nor called function. * nessus/nessus.c: Minor reformatting and doc. 2009-02-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> * MANIFEST: Updated src/README to src/README_SRC. 2009-02-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> Improved generated documentation. * Makefile: Added missig newline at eof. * doc/Doxyfile: Defined USE_GTK to include gui- related functions into the generated documentation (already done in doc/Doxygen_full). * src/README: Moved to src/README_SRC to allow inclusion of correct file in nessus/nessus.c (workaround, doxygen would include this file instead of the main README otherwise). * src/README_SRC: Moved from src/README. * nessus/nessus.c: Include the (unique) README in the documentation. 2009-02-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/plugin_infos (plugin_info_window_setup): Made labels selectable to allow users to copy'n'paste information (i.e. OID) from within the info dialog, whitespaces removed. 2009-02-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/monitor_dialog.c (monitor_list_update): Removed never really used local variables that counted the number of GUI- updates of the monitor dialog application- wide per host. 2009-02-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/monitor_dialog.c: Cosmetics - white spaces removed and added, K&R replacements, doc. 2009-02-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/data_mining.c: Added RATS ignores where strlen is called on a string literal. 2009-02-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/data_mining.c: Cosmetics (K&R, whitespaces), docs. 2009-02-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/pdf_output.c (print_plugin_information_signatures): Use g_strdup_printf instead of malloc + snprintf. 2009-02-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/pdf_output.c: Cosmetics, TODO added about stringvector implementation, can use GLib here. 2009-02-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/xml_output_ng.c (xml_info_nessusd): Corrected name of key for openvasd version. 2009-02-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/xml_output_ng.c (xml_info_host): Removed unessecary fetching of server_info, it comes as parameter anyway. 2009-02-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> Variables renamed. * nessus/xml_output_ng.c (xml_info_host): Renamed parameter name from t to server_info. * nessus/xml_output_ng.c (xml_info): Renamed local variable t to server_info. 2009-02-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/nessus.c (set_server_cert_hash): Added RATS ignore where string is ensured to be nul- terminated. 2009-02-24 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/sighand.c (close_all_context_cnx): Moved upward within file, declared static. * nessus/sighand.c (nessus_exit): Close connections of all contexts, not only current one close_all_context_cnx(/Context/Global/) before exiting. * nessus/nessus.c (main): Removed call to close_all_context_cnx, implicitly done by nessus_exit now. 2009-02-23 Joey Schulze <joey@infodrom.org> * libnessus/arglists.c (arg_del_value): Fix thinko * libnessus/arglists.c (arg_del_value): Added missing initialisation on element removal 2009-02-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> Use correct closing tag for nvt element. * nessus/xml_output_ng.c (xml_plugins_plugin): Close xml nvt element with /nvt, not /plugin, doc. * nessus/xml_output_ng.c (escape_string): Corrected comment. 2009-02-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/parser.c: Replaced K&R function declarations, doc. 2009-02-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_set_defaults): Added RATS-ignores for strlens where strings are guaranteed to be nul- terminated. * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_apply): Use strdups instead of malloc and strncpys, added RATS ignores where strlen is called on (nul- terminated) literals. 2009-02-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/plugin_infos.c (show_deps): Use gchar and g_strdup_printf instead of emalloc + snprintf. 2009-02-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> * libnessus/network.c: Minor documentation and reformatting. 2009-02-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.c (comm_get_preferences): Added RATS-ignores, where strlen looks at nul- terminated strings. 2009-02-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.c: Reformatted function declarations and improved doc blocks. 2009-02-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/backend.c: Minor reformatting and doc. 2009-02-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> Use a more sophisticated file chooser for nvt file preferences. Allows for selection of hidden files/folders (useful when selecting ssh keys) and better integrated into desktop environments. Also reduced code and arglist shuffling. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (file_dialog_hide): Removed. All packed in select_file. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (file_selected): Removed. All packed in select_file. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (select_file): Use GtkFileChooser instead of GtkFileSelection, makes procedure easier and allows more options like selection of hidden files and folders. 2009-02-21 Joey Schulze <joey@infodrom.org> * libnessus/arglists.c (arg_del_value): Add missing initialisation 2009-02-20 Joey Schulze <joey@infodrom.org> * libnessus/arglists.c (arg_del_value): New function to remove an arglist element 2009-02-19 Joey Schulze <joey@infodrom.org> * nessus/backend.c (backend_convert), nessus/parser.c (parse_expand_type), nessus/pdf_output.c (arglist_to_plainhtml): Use capital letters for "false positive" string 2009-02-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> Try to set client- side "silent dependencies" preference default to "no" , use g_strdup_printf instead of malloc + sprintf. * nessus/preferences.c (preferences_get_altname): Use g_strdup_printf instead of malloc + sprintf. * nessus/preferences.c (preferences_new): Set silent_dependencies default to "no". 2009-02-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> Minor documentation and reformatting of preferences module. * nessus/preferences.c: Minor documentation and reformatting. 2009-02-18 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added tooltip to timeout spinner in plugin info dialog. * nessus/plugin_infos.c (plugin_info_window_setup): Added toolip to timeout- spinbutton. 2009-02-18 Felix Wolfsteller <felix.wolfsteller@intevation.de> Resolved compiler warning via gtk cast. * src/gui/nvt_pref_sshlogin.c (nvt_pref_sshlogin_rebuild_gui): Cast GtkTable to GtkWidget to eliminate compiler warning. 2009-02-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> Allow plugin- setting directly from plugin-info dialog via a spinner. Saves the user two clicks and does not hide this functionality. * nessus/plugin_infos.c (do_set_timeout): Clarified doc. * nessus/plugin_infos.c (set_timeout_build_window): Removed. No additional window for timeout- setting needed anymore. * nessus/plugin_infos.c (set_timeout): Removed. * nessus/plugin_infos.c (spin_to_timeout): New. Sets the spinner to the value found in preferences. * nessus/plugin_infos.c (plugin_info_window_setup): Put spinner and label to the plugin info dialog. Removed the set-timeout-button. Call spin_to_timeout to show current (old) value. Call do_set_timeout when window is closed to update current (new) value. 2009-02-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/plugin_infos.c (do_set_timeout): Removed debug- printf, use g_strdup_printf instead of malloc + sprintf, documentation for parameters. 2009-02-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> Partly repaired timeout- functionality on client- side. * nessus/plugin_infos.c (do_set_timeout): Changed signature, no reason to use arglists here, treat OID as a string and not as an int. * nessus/plugin_infos.c (set_timeout_build_window): Use arguments directly, not nested in an argument (matches new do_set_timeout signature). Renamed local variables, indicate thet timeout unit is seconds, use gtks show_all() instead of multiple show()s. 2009-02-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> Minor reformatting and documentation. * nessus/plugin_infos.c: Minor reformatting and documentation. 2009-02-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/auth.c: Minor reformatting. 2009-02-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed (worked around) bug that caused non-visible SSH-login--per-target GUIs not to show up after e.g. deletion of a sshlogin until resizing of the GUI. * src/gui/nvt_pref_sshlogin.c (add_host_login_row): Added additional (nested, because we are in a callback) argument. Allows for manipulation of an arbitrary contexts guis, not only the currently active contexts one. * src/gui/nvt_pref_sshlogin.c (nvt_pref_sshlogin_rebuild_gui): Nesting a per-context GUI in new argument for add_host_login_row, work around invisibility- bug by manually sending a size request. 2009-02-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Showing counted log messages in overview table (~left side of the GUI). Based on Joeys "False-Positives" patch of 2009-01-17. * nessus/prefs_dialog/prefs_scope_tree.c: Added entry to column enum. * nessus/prefs_dialog/prefs_scope_tree.c (scopetree_move): Copy nr. of log messages, too. * nessus/prefs_dialog/prefs_scope_tree.c (scopetree_new_with_parent): Initialize new column. * nessus/prefs_dialog/prefs_scope_tree.c (scopetreestore_counters_update) : Fetch and set number of log messages. * nessus/prefs_dialog/prefs_scope_tree.c (scopetreeview_create_columns): Create the new column. * nessus/prefs_dialog/prefs_scope_tree.c (scope_create_treestore): Include value in tree store. 2009-02-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Towards counting log messages in overview (~left side of the GUI). Provided functions to count log messages. * nessus/report_utils.c (number_of_log_messages_by_port, number_of_log_messages_by_host, number_of_log_messages): New. Count log messages analog to others (e.g. security notes) * nessus/report_utils.h: Added protos. 2009-02-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_scope_tree.c: Reformatted larger parts. 2009-02-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_scope_tree.c: Minor reformatting, K&R function declaration replaced. 2009-02-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cosmetics. * nessus/backend.c, nessus/prefs_dialog/prefs_scope_tree.c : Minor reformatting, doc. * nessus/prefs_dialog/prefs_report.c, nessus/prefs_dialog/prefs_context.c: Reformatting, K&R function declaration replacements, documentation blocks adjusted 2009-02-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_scope_tree.c: Added documentation, replaced K&R style function headers. 2009-02-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/openvas-lib/hash_table_file.c (openvas_ssh_login_file_write): Close file descriptor in case of error. 2009-02-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_dialog.c: Minor doc. improvement. 2009-02-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_scopte_tree.c (scopetreeview_create_columns) : Changed column title for false positives from "false" to "FP", added minimal documentation. * nessus/prefs_dialog/prefs_scope_tree.c: Added minimal documentation to column enum. 2009-02-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> Documentation support for 'full' doc. * doc/Doxyfile_full: New (but MANIFEST entry existed already). * Makefile: Added doc-full target. 2009-02-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> Basic documentation support. * doc/Doxyfile: Changed version number and include/output paths. * Makefile: Renamed old doc- target to man, included new target doc for source code doc. * nessus/nessus.c: Adjuste mainpage directive to have a more informative starting page for the code documentation. 2009-02-12 Felix Wolfsteller <felix.wolfsteller@intevation.de> Use new function to rebuild all GUIs when a ssh- login was deleted using the OpenVAS SSH Key Manager, changed window title for form to input new key information. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_delete_login): Rebuild all GUIs by calling nvt_pref_sshlogin_rebuild_all. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_prompt_new): More verbose window title. 2009-02-12 Felix Wolfsteller <felix.wolfsteller@intevation.de> Introduced function to rebuild all ssh-login-per-host GUIs. * src/gui/nvt_pref_sshlogin.c (nvt_pref_sshlogin_rebuild_gui): Added parameter context to reuse functionality in new function nvt_pref_sshlogin_rebuild_all. * src/gui/nvt_pref_sshlogin.c (nvt_pref_sshlogin_rebuild_all): New. Calls nvt_pref_sshlogin_rebuild_gui recursively for contexts. * src/gui/nvt_pref_sshlogin.c, nessus/prefs_dialog/pref_target.c: Added NULL parameter to calls to nvt_pref_sshlogin_rebuild_gui to resemble the old behaviour. * src/gui/nvt_pref_sshlogin.h: Adjusted protos. 2009-02-12 Felix Wolfsteller <felix.wolfsteller@intevation.de> Pure cosmetics, little doc. added. * nessus/latex_output.c (latex_print_footer, latex_print_header): (Very) brief documentation added. * nessus/backend.c: Tiny doc improvements. * nessus/parser.c: Converted doc blocks to doxygen-interpretables, K&R function declarations. * nessus/nbe_output.c: Function headers reformatted, white- spaces removed/ added to improve readability. * nessus/prefs_dialog/prefs_plugins_tree.c: Doc blocks transformed. 2009-02-10 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed irritating focus switch when confirming warning about malformed pattern in ssh-logins per host gui (window manager specific bug). * src/gui/nvt_pref_sshlogin.c (prompt_new_pattern): Setting Main window as parent of pattern dialog. Added note about possible further improvement. 2009-02-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> Remove eventual white spaces from target strings to end up with proper formatted .host_logins file (was bad if key starts with a space). * nessus/read_target_file.c (target_translate): Remove white spaces in target list when translating. * nessus/read_target_file.c (target_file_name): Use safer GLib g_strdup_printf instead of sprintf. 2009-02-09 Laban Mwangi <lmwangi@penguinlabs.co.ke> Fixed bugs found by cppcheck. * nessus/html_graph_output.c(html_make_index): Added fclose: In some instances the file pointer is not closed * nessus/nessus.c (main): Added a missing free 2009-02-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cleaned up sighand module. * nessus/sighand.c, nessus/sighand.h (sighand_alarm): Removed. Was not registered. * nessus/sighand.h (sighand_sigsegv): Removed. Was not implemented. 2009-02-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cosmetics in the sighand module. * nessus/sighand.c: Documentation and formatting, removed include of globals.h (comment suggested that it was needed for a closesocket call that was never done). 2009-02-06 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed potential buffer overflow (spotted by Bernhard Herzog). * nessus/xml_output_ng.c (escape_string): Respect worst case scenario properly (thanks Bernhard for spotting it). 2009-02-06 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cosmetics in xml_output_ng module. * nessus/xml_output_ng.c: Minimal documentation and formatting. * nessus/xml_output_ng.c (escape_string): Removed exit if erealloc returns NULL (thats what erealloc is responsible for). 2009-02-06 Felix Wolfsteller <felix.wolfsteller@intevation.de> Finish removal of (empty) xml_output module (2008-06-01). * nessus/xml_output.h, nessus/xml_output.c: Removed * MANIFEST: Removed xml_output.* entries. 2009-02-06 Felix Wolfsteller <felix.wolfsteller@intevation.de> Changing per-target selection of ssh logins does not have an effect if done in the Global Settings 'task'. Inform user about this problem. * nessus/context.c (context_collect_recurse): Do not save ssh-login mapping of Global scope for now. Would impose exceptions on location of .host_logins file, as the Global scope does not have an own directory and the users home directory seems like a bad choice. * src/gui/nvt_pref_sshlogin.c (sshlogin_selected_cb): Warn user that this interaction in the Global Settings is effect-less. 2009-02-06 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/nvt_pref_sshlogin.c (prompt_new_pattern): Run the dialog until user cancels, closes or enters a valid pattern. Prevent a 'match-all' pattern, allow translation of certain messages. 2009-02-05 Felix Wolfsteller <felix.wolfsteller@intevation.de> Improved pattern- definition in hostname --> sshlogin mapping. (http://openvas.org/openvas-cr-20.html) * src/gui/nvt_pref_sshlogin.c (is_pattern): New. Checks if string is a (valid) pattern. * src/gui/nvt_pref_sshlogin.c (remove_pattern): New. After confirmation dialog, removes pattern from GUI and memory. * src/gui/nvt_pref_sshlogin.c (prompt_new_pattern): Renamed (former addpattern). * src/gui/nvt_pref_sshlogin.c (copy_pattern): New. Copies pattern into a GHashTable. Needed when target list changed, to keep defined patterns. * src/gui/nvt_pref_sshlogin.c (add_host_login_row): Adds a 'remove' button to patterns and connect signal to new remove_pattern function. * src/gui/nvt_pref_sshlogin.c (nvt_pref_sshlogin_rebuild_gui): Modified to keep patterns. * src/gui/nvt_pref_sshlogin.c (nvt_pref_sshlogin_add): Donated icon to 'add pattern' button. Distinguishes if this GUI is created the first time ever (scope is fresh) or just the first time since this client instance started (was touched already). 2009-02-05 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/openvas-lib/hash_table_file.c: Documentation improved, newlines. 2009-02-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added "Add Pattern" button to sshlogin-per-target GUI to allow netmask or regexp definitions. Not yet functional. * src/gui/nvt_pref_sshlogin.c (addpattern): New. Displays dialog asking for a pattern and a login. * src/gui/nvt_pref_sshlogin.c (nvt_pref_sshlogin_rebuild_gui): Made targets parameter optional to allow 'lazy' case where the mapping hash table of the Context does not have to be recreated, added 'Add pattern' button and signal connect to new addpattern function. 2009-02-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added GPL header of module implementation files to module header files. * nessus/prefs_dialog/prefs_kb.h: Added GPL header from nessus/prefs_dialog/prefs_kb.c . * nessus/prefs_dialog/prefs_dialog_plugins_prefs.h: Added GPL header from nessus/prefs_dialog/prefs_dialog_plugins_prefs.c . 2009-02-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> Minimal documentation of nessus_plugin module, include guard in header. * nessus/nessus_plugin.c: Added/transformed documentation block comments * nessus/nessus_plugin.h: Added include guard, minimal documentation. 2009-02-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added GPL header from nessus/parser.c to nessus_plugin module. parser.c stems from approximately the same time. Conditions equal those in COPYING and COPYING.OpenSSL which are valid for the whole directory. * nessus/nessus_plugin.h, nessus/nessus_plugin.c: Added GPL header. 2009-02-03 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed memory leak and occasional GLib- Critical warnings * nessus/context.c (context_delete): NULL- guard g_hash_table_destroy. * nessus/context.c (context_pickup_sshkeys): Free list content. 2009-02-03 Felix Wolfsteller <felix.wolfsteller@intevation.de> Donating headers of modules the GPL headers of the modules implementation file. * nessus/cli.h: Pasted GPL header from nessus/cli.c . * nessus/backend.h: Pasted GPL header from nessus/backend.c . * nessus/xml_output_ng.h: Pasted GPL header from nessus/xml_output_ng.c (except TODO text). * nessus/text_output.h: Pasted GPL header from nessus/text_output.c . * nessus/sslui.h: Pasted GPL header from nessus/sslui.c . * nessus/report_utils.h: Pasted GPL header from nessus/report_utils.c . * nessus/report_save.h: Pasted GPL header from report_save.c . 2009-02-03 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed two bugs: 1) When last ssh key in list missed a file and user chose to delete it at startup, the hash table got confused. 2) Writing the map host --> ssh key could happen in the wrong directory. Fixed fixme: 1) At startup, 'mapping file' is only written when user deleted keys. * nessus/context.c (verify_sshlogin_integrity): Does not remove items directly, but collect them in a list. * nessus/context.c (context_pickup_sshkeys): provide the list for verify_sshlogin_integrity and remove items afterwards. * nessus/context.c (context_save_recurse): Reference has to be lowercase context, not uppercase (current) Context. 2009-02-03 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/context.c: Removed debug-surviving printf. 2009-02-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/nessus.h: Removed NESSUS_RCFILE alltogether, it is not used anywhere, current code uses preferences.c: preferences_get_filename. 2009-02-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed unused module dirutils. * nessus/dirutils.c: Removed. * nessus/nessus.h: Removed reference to dirutils, set NESSUS_RCFILE to 0. * nessus/Makefile: Removed dirutils target. * MANIFEST: Removed dirutils. 2009-02-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed unnecessary local variable, cosmetics. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (prefs_dialog_plugins_prefs_read_only): Reformatted. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (prefs_dialog_plugins_prefs_fill): Removed local variable vbox. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (file_dialog_hide, file_selected, get_pref_value): Cosmetics, documentation. 2009-02-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> As sshlogin selection per host is represented in memory, file saving is only when neccessary at initialization, before an attack and before quit. 'Before quit' awaits patch, as the client does not reliably handles signals. Allows number of simplifications (e.g. to receive settings no search through GUI elements has to be done anymore, less file reading and writing). * nessus/attack.c (attack_host): Update the .host_sshlogin file before starting an attack. K&R function declaration replaced. * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_apply_plugin_prefs): No need to 'apply' ssh login selections or save file anymore. But set a dummy value to enable logins-per-target selections being visible in an unconnected scope, too. * src/gui/nvt_pref_sshlogin.c (sshlogin_selected_cb): New. Updates Contexts hashtable in combobox change callback. * src/gui/nvt_pref_sshlogin.c (add_host_login_row): New (extracted). Adds a row with label and combobox to the GtkTable defining the login-per-target GUI, selects the correct value and registeres the callbacks for changes in combobox selections. * src/gui/nvt_pref_sshlogin.c (nvt_pref_sshlogin_rebuild_gui): New. Rebuilds the GUI and populates it according to current contexts map_target_sshlogin. * src/gui/nvt_pref_sshlogin.c (str_hash_table_has_value): New. Workaround to be used with g_hash_table_find to check if a certain value is present in a hashtable. * src/gui/nvt_pref_sshlogin.c (nvt_pref_sshlogin_is_in_use): Reformed to work with contexts hashtable rather than with the gtk widgets. * src/gui/nvt_pref_sshlogin.c (nvt_pref_sshlogin_save_file): Removed, not needed anymore. * src/gui/nvt_pref_sshlogin.c (nvt_pref_sshlogin_add): Use new function. * src/gui/nvt_pref_sshlogin.h: Adjusted protos. * nessus/prefs_dialog/prefs_target.c (targets_changed): Updated call of nvt_pref_sshlogins gui rebuilding function. 2009-02-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> Moving from purely file- and gui- based representation of the mapping 'target --> sshlogin' to storing choices in memory in a hashtable. * nessus/context.h (struct context): Added another GHashTable, map_target_sshlogin that is to be kept in sync with gui. * nessus/context.c (context_init, context_collect_recurse): Initialize and pick up new field (map_target_sshlogin), pick up '.host_sshlogins' file at startup. * nessus/context.c (context_save_recurse): Save the map_target_sshlogin to file '.host_sshlogins', documentation. * nessus/context.c (context_new): Initialize map_target_sshlogin as an empty hash table. * nessus/context.c (verify_sshlogin_integrity): Eliminated compiler warning (use gtk cast). * nessus/comm.c (send_ssh_credential_files): Use mapping from memory instead of reading the mapping from file. 2009-01-28 Felix Wolfsteller <felix.wolfsteller@intevation.de> Improved SSH Key Manager deletion function: 1) warns stronger if the to-be-deleted account is selected as login for a target in any context. 2) Improved button placement. * src/gui/nvt_pref_sshlogin.c (nvt_pref_sshlogin_is_in_use): New. Checks if a certain string is selected in any combobox that shows ssh logins. * src/gui/nvt_pref_sshlogin.h (nvt_pref_sshlogin_is_in_use): Added proto. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_delete_login): Warn stronger if account is used. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_show): Arrange the 'delete' and 'create new' buttons in the action area of the dialog. 2009-01-28 Felix Wolfsteller <felix.wolfsteller@intevation.de> Improved gui for notification of invalid ssh login at startup (public or private key files are missing). * nessus/context.c (verify_sshlogin_integrity): If not compiled with GTK print a warning. * nessus/context.c (verify_sshlogin_integrity): Use gtk_message_dialog (has an icon) and positive response codes (recommended). 2009-01-28 Felix Wolfsteller <felix.wolfsteller@intevation.de> Improved gui for deletion of ssh-logins in the SSH Key Manager. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_empty): New method to display the placeholder in case of no ssh logins to display. Extracted from ssh_keys_dialog_show. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_show): Call extracted method. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_delete_login): Prevent deletion of placeholder. When login deleted, remove item from list. Display placeholder if list empty after deletion. 2009-01-28 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed iterator complaints on console under certain conditions. * nessus/listnotebook.c (listnotebook_remove_page): In the loop to find page to remove, break when deleted, to spare time and prevent confused iterators. 2009-01-28 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed deletion of user defined ssh- login accounts. * src/util/openvas_ssh_key_create.c (openvas_ssh_key_create_undo), src/gui/ssh_keys_dialog.c (ssh_keys_dialog_delete_login), nessus/context (verify_sshlogin_integrity, context_pickup_sshkeys): Accessing the correct sshkeys hashtable of the global context, and not of the currently selected one. 2009-01-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed sending of ssh- key files. * nessus/comm.c (comm_send_preferences) : K&R function declaration replaced, comment added. * nessus/comm.c (send_ssh_login_keys): Corrected string comparison condition, duplicate strings. 2009-01-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> Verifies all SSH Keys when loaded. Ask the user if the files should be recreated or all info deleted. Functionality still incomplete, TODOs added. * nessus/context.c (verify_sshlogin_integrity): New. In a g_hash_table_foreach, asks the user how to deal with 'invalid' ssh- login accounts. * nessus/context.c (context_pickup_sshkeys): Calls verify_sshlogin_integrity for each found login and rewrites the '.logins' file afterwards. 2009-01-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/context.c: Cosmetics, documentation. 2009-01-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> Preparations for notification and user choice in case of missing public/ private key files of a SSH login. * src/util/openvas_ssh_key_create.c (openvas_ssh_key_create_unlink_files, openvas_ssh_key_create_undo): New. Extracted method from openvas_ssh_key_create_undo. * src/util/openvas_ssh_key_create.h: Added proto. 2009-01-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> Rudimentary 'delete' function of SSH Key Manager (does not yet inform any other parts of the gui about the event) added. * src/util/openvas_ssh_key_create.c (openvas_ssh_key_create_undo): New. Unlinks key files and removes a openvas_ssh_login from memory. * src/util/openvas_ssh_key_create.h: Added proto for openvas_ssh_key_create_undo. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_show): Added a 'delete' button and connected to new callback function ssh_keys_dialog_delete_login. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_delete_login): New. Callback for click on 'delete' button, asks for reconfirmation and triggers new openvas_ssh_key_create_undo function to clean up. 2009-01-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> Introducing and setting "valid" flag in struct openvas_ssh_login to indicate whether key files exist or not. * src/openvas-lib/openvas_ssh_login.h (struct openvas_ssh_login): Added boolean field 'valid' to indicate whether the key files exist or not. * src/openvas-lib/openvas_ssh_login.c (openvas_ssh_login_new): Validity flag is set after checking existance of public and private key files. * src/openvas-lib/openvas_ssh_login.c (openvas_ssh_login_file_read): When check_keyfiles parameter is TRUE, do not stat the files but look for validity flag that is now set in openvas_ssh_login_new, indentation. 2009-01-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> Callback when ssh key created: update all comboboxes showing ssh keys to display the new entry. * src/gui/nvt_pref_sshlogins (GUI_KEY_NVT_PREF_SSHLOGIN_GTKTABLE): Doc improved. * src/gui/nvt_pref_sshlogins (nvt_pref_sshlogin_update_all_comboboxes): Updated to work with infrastructure for sshlogin-selection per host. 2009-01-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixing bug in SSH Key Manager that created *.pub.pub files. * src/util/openvas_ssh_key_create.c (openvas_ssh_pubkey_create, openvas_ssh_privkey_create): Stripping '.pub's that were suffixed in the GUI, corrected documentation comments, initialize local vars to NULL. 2009-01-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_target.c (targets_changed): New. Callback that triggers rebuilding of table with ssh-login per target selection. * nessus/prefs_dialog/prefs_target.c (prefs_dialog_target): Connected signal to callback function, so that a possible target list change triggers changes in the ssh-selection per target gui of the current context. 2009-01-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> For ssh-key selection per target: 1) Added a 'Default' host. 2) Prepared ability of gui being updated when the target list was modified by the user. * src/gui/nvt_prefs_sshlogin.c: Documentation improved. * src/gui/nvt_prefs_sshlogin.c (nvt_pref_sshlogin_update_all_comboboxes): Added TODO. (just looks like removal in svn diff). * src/gui/nvt_prefs_sshlogin.c (nvt_pref_sshlogin_apply_file): Loads table from context if the arglist parameter is NULL. Step towards making this preference type arglist- independent. * src/gui/nvt_prefs_sshlogin.c (nvt_pref_sshlogin_targets_update): New. Method extracted mainly from nvt_pref_sshlogin_add. Cleans the table, populate it with widgets and loads eventual selections from file. * src/gui/nvt_prefs_sshlogin.c (nvt_pref_sshlogin_add): Use of extracted method, therefore restructured. Adds the table to the context, prepends a 'Default' to the hostlist to enable setting of a default sshlogin. * src/gui/nvt_prefs_sshlogin.h: Added proto for nvt_pref_sshlogin_targets_update. 2009-01-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> Introduced a new field to the context struct that holds the GtKTable for sshlogin selection per target. * nessus/context.h (struct context): Added gui_sshlogins_per_target field and comment/doc about it. * nessus/context.c (context_init): Set gui_ssh_logins_per_target to NULL. 2009-01-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> Comments and whitespaces to the context struct added. * nessus/context.h: Comments and whitespaces added. 2009-01-23 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cosmetics (K&R function declarations, whitespaces) * nessus/context.c: Cosmetics (replaced K&R function declarations, whitespaces). * nessus/context.c (context_collect): Removed third parameter of call to context_collect_recurse, that did not exist and broke build once the function declarations were replaced. 2009-01-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> Updated openvas_ssh_login module so that it equals the one in openvas-libraries (introduced an additional parameter for openvas_ssh_file_read). * src/openvas-lib/openvas_ssh_login.c: Updated from openvas-libraries. * src/openvas-lib/openvas_ssh_login.h: Updated from openvas-libraries. * nessus/comm.c: Updated call of openvas_ssh_file_read. * nessus/context.c: Updated call of openvas_ssh_file_read. 2009-01-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cosmetics (documentation and whitespaces). * nessus/comm.c: Removed empty lines, improved readability of documentation. 2009-01-22 Felix Wolfsteller <felix.wolfsteller@intevation.de> Send public and private key files of selected ssh- logins. * nessus/comm.c (send_ssh_login_keys): New function to add pub/private key files to list of files to send. * nessus/comm.c (send_ssh_credential_files): New. Extracted from comm_parse_preference, fixed fixme, because now the files will be send. * nessus/comm.c (comm_parse_preference): Extracted send_ssh_credential_files, improved documentation marginally. 2009-01-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed two compiler warnings. * nessus/comm.c (comm_parse_preference): Cast an arglist value to void*. * nessus/comm.c (comm_parse_certificate): Initialize a char* to NULL. 2009-01-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> Send .logins and .host_logins files to server if a plugins with PREF_SSH_CREDENTIALS preference was found. * nessus/comm.c (gui_comm_send_preferences): Add .logins and .host_logins to the list of files to send. 2009-01-20 Michael Wiegand <michael.wiegand@intevation.de> * nessus/xml_output_ng.c (getproto): Fixed parsing of string containing possible protocol information. This solves bug #867 (http://bugs.openvas.org/867) which caused a corrupted protocol attribute when service names contained slashes. This also fixes another bug which caused service names to show up in the protocol attribute. NB: This causes some port elements to have empty protocol attributes when the protocol information was not sent correctly by the server. This happens when then messages does not relate to a specific port, but to the attacked host in general (port 0 in NASL). 2009-01-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/openvas-lib/openvas_ssh_login.c: Cleaned up includes, defined file- check functions, so that a copy of this module can be placed (and compiles) in openvas-libaries. 2009-01-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/html_graph_output.c (host_details): Fixed breakage (html_output_print_data_with_links needed one more argument). 2009-01-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> Extracted module from src/openvas-lib/openvas_ssh_login to enable inclusion of openvas_ssh_login into openvas-libraries. * src/openvas-lib/openvas_ssh_login.c: Added include, disabled error messages (will be shown by src/gui/ssh_keys_dialog), moved key creation- functions to src/util/openvasssh_key_create module. * src/openvas-lib/openvas_ssh_login.h: Proper naming of include guard, removed proto of function that is moved to openvas_ssh_key_create. * src/util/openvas_ssh_key_create.h, src/util/openvas_ssh_key_create.c: Added, module extracted from openvas_ssh_login. * src/gui/ssh_keys_dialog.c: Updated reference, include new module. * MANIFEST, nessus/Makefile, src/util/Makefile: Updated. 2009-01-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/openvas-lib/openvas_ssh_login.h: Removed obsolete prototype and include. 2009-01-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> Moved hash_table_file as it is now parts of openvas-libraries. * src/util/hash_table_file.h: Moved to src/openvas-lib. * src/util/hash_table_file.c: Moved to src/openvas-lib. * MANIFEST, Makefile, nessus/Makefile, src/util/Makefile, src/openvas-lib/Makefile: Updated. 2009-01-20 Joey Schulze <joey@infodrom.org> * nessus/html_graph_output.c (host_details): Rename functions to their new names 2009-01-19 Joey Schulze <joey@infodrom.org> * nessus/html_graph_output.c (host_details): Fix breakage 2009-01-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> Renamed unluckily named g_hash_table_file module as suggested by Bernhard Herzog. * /src/util/g_hash_table_file.c, /src/util/g_hash_table_file.h: Stripped 'g_' in function and file names, as that prefix is used by GLib. * /src/util/hash_table_file.c, /src/util/hash_table_file.h: Old module with new name and updated function names. * MANIFEST, nessus/Makefile, src/util/Makefile, src/gui/nvt_pref_sshlogin.c: Updated references to new module and function names. 2009-01-17 Joey Schulze <joey@infodrom.org> Add support for false positives and adjusting priorities in the client to via configuration file (CR#18) A user interface will follow, until then adjustments are configured in the openvasrc in the scope directory like: begin(PLUGINS_PRIORITIES) 1.3.6.1.4.1.25623.1.0.10107 = \n <|> http (80/tcp) <|> NOTE <|> FALSE <|> end(PLUGINS_PRIORITIES) * nessus/report_utils.c (number_of_false_positives_by_port) (number_of_false_positives_by_host, number_of_false_positives), nessus/report.c (is_there_any_hole): New functions to support listing false positives in various reports * nessus/latex_output.c (latex_introduction_a, latex_introduction_b, latex_introduction_c, latex_introduction_d, latex_introduction_e, latex_print_host_ports_problems, arglist_to_latex), nessus/html_output.c (arglist_to_html, summary_to_file), nessus/html_graph_output.c (host_details, html_make_index), nessus/text_output.c (arglist_to_text), nessus/pdf_output.c (arglist_to_plainhtml, pdf_summary_to_file): Add support for false positives to all output types * nessus/parser.c (parse_message_type, parse_expand_type) (parse_calc_priority, parse_modify_data, parse_server_message) (parse_host_add_data), nessus/backend.c (backend_convert): Add support for adjusting priorities from the server in the client, including false positives * nessus/prefs_dialog/prefs_scope_tree.c (scopetree_move, scopetree_new_with_parent, scopetreestore_counters_update, scopetreeview_create_columns, scope_create_treestore): Add support for false positives to tree view 2009-01-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added 2009 (and 2008 where missing) to copyright notice. Added Michael Wiegand and Felix Wolfsteller to the list of authors. * nessus/nessus.c (main): Updated copyright notice. * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_setup): Updated copyright years, added M.Wiegand and F.Wolfsteller to list of authors. * src/gui/about_dlg.c (about_dialog): Updated copyright years, added M.Wiegand and F.Wolfsteller to list of authors. 2009-01-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Improvements to OpenVAS SSH Key Manager: 1) Looks good even if no key there yet. 2) Selects the key right after it was created. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_add_key): Remove entry for 'no logins yet' if existant, select the key that was just created. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_show): Show 'no logins yet' if none was found, use pack instead of containeradd for better layout. 2009-01-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed compiler warnings related to preference module. * nessus/preferences.c (preferences_yes_or_one): Cast unknown (from arglist) to int. * nessus/preferences.h: Added missing preferences_yes_or_one proto. 2009-01-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cosmetics and doc improvements. * src/openvas-lib/openvas_certificates.c (openvas_certificate_free, openvas_certificate_new): Improved doc, donating return values an own line. * nessus/attack.c: Improved doc, removed dangling comment. 2009-01-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Improved functionality of the listnotebook widget. * nessus/prefs_dialog/listnotebook.c (listnotebook_new): Use pack methods instead of adds to have good proportions even when empty. * nessus/prefs_dialog/listnotebook.c (listnotebook_remove_page): New function to remove a page and the list entry. * nessus/prefs_dialog/listnotebook.c (listnotebook_select_page_named): New function to select a page, given its name in the list. * nessus/prefs_dialog/listnotebook.h : Added protos for new functions. 2009-01-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Improved documentation of the listnotebook widget. * nessus/prefs_dialog/listnotebook.c: Improved comments and doc, K&R header in listnotebook_new replaced. 2009-01-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/plugin_infos.c: Missing include added. 2009-01-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/openvas-lib/openvas_ssh_login.c: Cosmetics, spread out doxygen comments for better readability, slight improvements, added briefs. 2009-01-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed bug that prevented creation of ssh-keys when .openvas/ did not exist. Bug was caused by ensure_dir being able to create a single directory only. * src/openvas-lib/openvas_ssh_login.c (ensure_single_dir): Renamed from ensure_dir. * src/openvas-lib/openvas_ssh_login.c (ensure_dir): New method that creates parent directories as well. 2009-01-14 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.c (comm_parse_certificate): Slightly restructured. Doc updated. 2009-01-14 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed bugs: 1) When no_nasl_check==no, signatures were not found due to sometimes different "fingerprint" length. 2) Server preference setting did (and partially still does) not override values local to the client, making it impossible to read the real servers value. Fixed for nasl_no_signature_check. * nessus/preferences.c (preferences_get_filename) : doc added. * nessus/preferences.c (preferences_yes_or_one): New function. Returns true if the value of an arglist is yes or one. * nessus/plugin_infos.c (showcert): Callback gets a pointer to certificate as data, avoids double lookup in hash table. * nessus/nessus/plugin_infos.c (create_certificate_list): Use short fingerprint for lookup certificates in hashtable. * nessus/nessus/plugin_infos.c (plugin_info_window_setup): Replaced preference value check by (new) preference_yes_or_one and registering callback (showcert) with pointer to certificate instead of fpr. * nessus/comm.c (comm_parse_preference): Brief doc added. Fixme added (server preference handling is messy). Handle nasl_no_signature_check appropriately. 2009-01-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed bug (unknown nvt signatures were not always listed in plugin info dialog). * nessus/comm.c (comm_parse_certificate): Fix size for "fingerprint" -keys of certificates in hash table to 16 chars. * nessus/plugin_infos.c: Minimal documentation for file added. * nessus/plugin_infos.c (new_unknown_cert): Function to return a dummy "unknown" certificate added. * nessus/plugin_infos.c (create_certificate_list): Extracted method to look up a list of fprs in the contexts signature store and add unknowns if they could not be retrieved found. * nessus/plugin_infos.c (plugin_info_window_setup): extracted create_certificate_list and condition the "View" button on not "Unknown" certificates. 2009-01-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/util/g_hash_table_file.c: Fixed mem leak (used original double pointer to iterate over list). 2009-01-12 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_dialog.c: Replaced K&R function definitions, documentation. * nessus/prefs_dialog/prefs_dialog.c (create_nessus_icon_factory): Added casts to eliminate warnings. 2009-01-12 Felix Wolfsteller <felix.wolfsteller@intevation.de> Make the GUI save selection of ssh keys per host. * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_apply_plugin_prefs): Include added, save selection to file. 2009-01-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed unused files nessus/prefs_dialog/prefs_dialog_misc.h/c. * nessus/prefs_dialog/prefs_dialog_misc.h, nessus/prefs_dialog/prefs_dialog_misc.c: Removed, were unused. * nessus/Makefile: removed references to prefs_dialog_misc. * po/POTFILES: removed prefs_dialog_misc entry. * MANIFEST: removed prefs_dialog_misc entries. 2009-01-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> Moving towards SSH key selection on a per-host basis. * ChangeLog: fixed. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (prefs_dialog_plugins_prefs_fill): Call new function to add gui element for per-host selection of ssh keypairs. * src/gui/nvt_pref_sshlogin.h (nvt_pref_sshlogin_add): Changed proto. * src/gui/nvt_pref_sshlogin.c: New functions to save selection to file and to recover selection from file, new per-host gui, doc improvements. 2009-01-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/Makefile: Added src/util to include path. * src/util/Makefile: Added source file to object target dependency. 2009-01-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/util/g_hash_table_file.c (g_hash_table_file_read): fixed mem leaks & avoided segfault when key_file is empty. 2009-01-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> Included src/util into build system. * Makefile: Include src/util cleaning to clean target. * nessus/Makefile: Introduced util target, added dependency. Added src/util/g_hash_table_file.o as GUI_OBJS (until needed elsewhere). 2009-01-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/util/g_hash_table_file.c (g_hash_table_read): renamed to g_hash_table_file_read. * src/util/g_hash_table_file.h: changed name of proto. 2009-01-08 Felix Wolfsteller <felix.wolfsteller@intevation.de> New Module to save and load GHashTables to / from disk. * MANIFEST: Updated with the new files. * src/util: Added (for non-OpenVAS specific code). * src/util/Makefile: Added. * src/util/g_hash_table_file.c: New module for (de-)serialization of GHashTables in a human readable form. * src/util/g_hash_table_file.h: Header of new module. 2009-01-08 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/read_target_file.h, nessus/read_target_file.c: GPL/header added. 2009-01-08 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/read_target_file.c: Comments and newlines to help reader understanding the defines, whitespace garbage removed. * nessus/read_target_file.c(target_file_select): brief doc. * nessus/read_target_file.c(target_file_to_list): doc improved. * nessus/read_target_file.c(target_translate): doc improved, indentation 2009-01-07 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c: Removed obsolete includes. 2009-01-07 Felix Wolfsteller <felix.wolfsteller@intevation.de> Donating visualization of a nvt sshlogins preference an own module. * src/gui/nvt_pref_sshlogin.c: New module with nvt pref sshlogin gui functions (moved from nessus/prefs_dialog/prefs_dialog_plugins_prefs.c). Updated style to be closer to GNU Coding Standards. * src/gui/nvt_pref_sshlogin.h: Header for nvt pref sshlogin gui functions. * MANIFEST: Added the new files. * po/POTFILES: Added the new files. * src/gui/Makefile: Added new target for new module, added libnessus include. * nessus/Makefile: Added the new target. * src/gui/ssh_keys_dialog.c: Changed include and function call to match new module. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c: (Re)moved code that deals with nvt sshlogin preferences (to src/gui/nvt_pref_sshlogin.c), added include, changed references to renamed functions. 2009-01-06 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c: Replaced K&R function declarations. 2009-01-06 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c: Added/ removed whitespaces, added comments. 2009-01-06 Felix Wolfsteller <felix.wolfsteller@intevation.de> Comments and Documentation converted to Javadoc format, added. * nessus/auth.c : Doc/comments improved, K&R function declarations replaced. * nessus/prefs_dialog/prefs_plugins.c, nessus/prefs_dialog/prefs_dialog.c, nessus/prefs_dialog/prefs_context.c, nessus/prefs_dialog/prefs_options.c, nessus/prefs_dialog/prefs_target.c: Doc/comments improved. 2009-01-02 Michael Wiegand <michael.wiegand@intevation.de> Modified openvas-client to use the freshly allocated IANA port 9390 instead of the Nessus port 1241. * include/config.h.in: Removed NESIANA_PORT define, added OPENVAS_IANA_OTP_PORT define. Updated IANA URL. * nessus/nessus.h: Removed NESIANA_PORT define, added OPENVAS_IANA_OTP_PORT define. * nessus/preferences.c (prefs_get_default): Changed to use OPENVAS_IANA_OTP_PORT. * nessus/prefs_dialog/prefs_help.h: Mention port 9390 instead of 1241 in tooltips. * doc/OpenVAS-Client.1: Changed example port to 9390. 2009-01-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> * TODO: Added wish to rename prefs_dialog/prefs_dialog_plugins_prefs and the like. 2009-01-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/read_target_file.c: Replaced C&R function declarations. 2009-01-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/read_target_file.c, nessus/prefs_dialog/prefs_target.c: Documentation added. 2008-12-29 Felix Wolfsteller <felix.wolfsteller@intevation.de> * Makefile: 'Clean' target now also removes generated documentation (doc/generated). 2008-12-29 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added an examplary doxygen configuration file as result of CR #19. Calling doxygen within the openvas/doc directory will generate a subdirectory "generated" wherein html and tex documentation is located. * doc/Doxyfile: Added, fancy "dot" options disabled. 2008-12-29 Michael Wiegand <michael.wiegand@intevation.de> * nessus/nessus.c (main): Added additional check for batch mode when trying to list preferences or plugins. This fixes bug #858 (http://bugs.openvas.org/858) which cause a segmentation fault when trying to list preferences or plugins without enabling batch mode. 2008-12-19 Michael Wiegand <michael.wiegand@intevation.de> Post release version bump. * VERSION: Set to 2.0.2.SVN. 2008-12-19 Michael Wiegand <michael.wiegand@intevation.de> Preparing the openvas-client 2.0.1 release. * CHANGES: Updated. * VERSION: Set to 2.0.1. 2008-12-18 Joey Schulze <joey@infodrom.org> * nessus/backend.c (backend_convert): Be more helpful when detecting a malformed line by printing said line as well * nessus/backend.c: Correct function names in associated comment * nessus/parser.c (parse_host_add_data): Correct debug format string 2008-12-18 Michael Wiegand <michael.wiegand@intevation.de> * po/POTFILES: Fixed wrong filename as pointed out by Stephan Kleine. 2008-12-17 Michael Wiegand <michael.wiegand@intevation.de> Post release version bump. * VERSION: Set to 2.0.1.SVN. 2008-12-17 Michael Wiegand <michael.wiegand@intevation.de> Preparing the openvas-client 2.0.0 release. * CHANGES: Updated. * VERSION: Set to 2.0.0. 2008-12-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed last commit. * nessus/comm.c (cli_send_prefs_arglist) : Fixed curruption by last commit. 2008-12-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> Enabled sending of ("new") ssh logins in CLI. * nessus/comm.c (cli_send_prefs_arglist) : Comments/doc. Send ssh logins similar to its GUI counterpart. 2008-12-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> NULL-Guard g_hash_table_lookup. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_show) : Added NULL-Guard. 2008-12-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> More glibs g_build_filename instead of emallocs + sprintfs and fixed one call. * nessus/plugin_cache.c (plugin_cache_get_filename) : Fixed call of g_build_filename with NULL- termination. * nessus/preferences.c (preferences_get_filename, prefs_get_default) : glib include, use g_build_filename. 2008-12-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/plugin_cache.c (plugin_cache_get_filename) : Use g_build_filename instead of emalloc + sprintfs. 2008-12-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> Extracted method to convert an ARG_INT to "yes"/"no" in an ARG_STRING. Makes code a bit cleaner, but concepts and mechanisms stay fuzzy. * nessus/prefs_dialog/prefs_dialog.c (arg_int_to_yesno) : Extracted method. * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_set_defaults) : Duplicate code removal, use of arg_int_to_yesno method. 2008-12-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> Extracted method to set preference based on a toggle-button state, cleanup. * nessus/prefs_dialog/prefs_dialog.c (set_yesno_pref_from_toggle) : Extracted method. * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_apply) : Removed code duplicate, use of new method, blank line removal. * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_apply_plugin_prefs) : NULL- initialize local char vars. 2008-12-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/openvas-lib/openvas_ssh_login.c (openvas_ssh_pubkey_create) : Check for nul rather than strlen < 0. * nessus/backend.c (backend_insert_report_data) : Use g_strconcat rather than malloc and strcat, rats-ignore for strlen on string literal. 2008-12-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/ssh_key_info_form.c (name_typed_in_cb) : Using GLibs (safer) convienance function g_stgrdup_printf instead of strlen + mallocs + sprintf. 2008-12-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Call function to update comboboxes when new ssh account added. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_prompt_new) : Added call to update comboboxes if an account has been added. 2008-12-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed debug message printf. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (prefs_dialog_plugins_prefs_update_ssh_comboboxes) : Removed debug message. 2008-12-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Registering xyz.pub as public key file, not just xyz. * src/gui/ssh_key_info_form.c (name_typed_in_cb) : When typed in, append .pub to public key filename. * src/openvas-lib/openvas_ssh_login.c (openvas_ssh_pubkey_create) : Stripping the .pub for creating the key. 2008-12-16 Michael Wiegand <michael.wiegand@intevation.de> Downgraded build environment to use a consistent libtool version. * config.guess, config.sub: Regenerated. 2008-12-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Moved callback function to open SSH Key Manager from prefs_dialog_prefs to ssh_keys_dialog. * src/gui/ssh_keys_dialog.h (ssh_manager_button_cb) : Added proto. * src/gui/ssh_keys_dialog.c (ssh_manager_button_cb) : Moved from prefs_dialog_prefs. * src/gui/ssh_keys_dialog.c (ssh_keys_dialog_prompt_new) : Added singly space, improved comment. * nessus/prefs_dialog/prefs_dialog_prefs.c (ssh_management_button_cb) : Moved to ssh_keys_dialog, renamed. Updated reference. 2008-12-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Let sshlogin preference area also contain a button to open the SSH Key Management Dialog. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (pprefs_add_sshcredentials) : Add and hook up button to open SSH Key Management Dialog. 2008-12-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Function to update existing comboboxes showing ssh keys, can be used when a new key is created, so that the keys to select are always up to date. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.h (prefs_dialog_plugins_prefs_update_ssh_comboboxes) : Added proto. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (prefs_dialog_plugins_prefs_update_ssh_comboboxes) : Implemented, adds a text entry item to all sshkey comboboxes. 2008-12-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed free-function for ssh_key_info_form. * src/gui/ssh_key_info_form.c (ssh_key_info_form_free ): Added missing references. 2008-12-16 Felix Wolfsteller <felix.wolfsteller@intevation.de> Free-function for ssh_key_info_form. * src/gui/ssh_key_info_form.h : Prototype for free- function. * src/gui/ssh_key_info_form.c (ssh_key_info_form_free ): Implementation for free- function. 2008-12-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> Minor documentation and style. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (show_sshinfo_cb, show_sshinfo_cb, pprefs_add_password, pprefs_add_file, pprefs_add_radio, pprefs_add_checkbox) : Added comment/doc. 2008-12-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> Display empty strings as info if no ssh key is selected in ssh_key_info_form. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (show_sshinfo_cb) : removed check for NULLness. * src/gui/ssh_key_info_form.c (ssh_key_info_form_fill) : Accept NULL as login info parameter and then blank out all text fields. 2008-12-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> Changed visual representation of new "sshlogin" preference to display infomation of selected key directly within the preference area. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c : New includes, references updated to ssh_key_info_form. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (text_combobox_set_active_text) : New conveniance function to mark a combox entry as active. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (show_sshinfo_cb) : Callback function for change of combobox entry added. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (pprefs_add_sshcredentials) : display information of selected keys in an ssh_key_form. 2008-12-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> Extracted module ssh_key_info_form from ssh_keys_dialog (with formerly somewhat misleading name ssh_login_form). * MANIFEST : Added src/gui/ssh_key_info_form.h/c entries. * po/POTFILES : Added new files. * src/gui/ssh_keys_dialog.h : Moved ssh_login_form struct to own ssh_key_info_form module. * src/gui/ssh_keys_dialog.c : Moved formerly static ssh_login_form* functions to own module ssh_key_info_form, updated references. * src/gui/Makefile : Included new ssh_key_info_form target. * nessus/Makefile : Added target. * src/gui/ssh_key_info_form.h : Added. Struct and protos for new module. * src/gui/ssh_key_info_form.c : Added. Implementation of new module. 2008-12-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed ssh password handling from SSH Management and renamed it in GUI. * src/openvas-lib/openvas_ssh_login.h : Removed userpassword from struct and function proto. * src/openvas-lib/openvas_ssh_login.c : Removed any references to userpassword. * src/gui/ssh_keys_dialog.c : Removed any reference to userpassword, changed dialog title. * src/gui/ssh_keys_dialog.h : Removed userpassword from form struct. * nessus/prefs_dialog/prefs_dialog_prefs.c (prefs_dialog_prefs) : Relabeled button for ssh manager. 2008-12-15 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/gui/ssh_keys_dialog.c (ssh_login_form_validated) : Inverted contrary check for spaces in comments. 2008-12-12 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.c (cli_comm_send_preferences, gui_comm_send_preferences) : K&R header collapsed, documented. 2008-12-12 Felix Wolfsteller <felix.wolfsteller@intevation.de> "Javadoc'ed" comments, documentation, some K&R headers collapsed, minimal style changes. * nessus/prefs_dialog/prefs_options.c : Header, style, comments. * nessus/monitor_dialog.c : Doc/Comments. * nessus/nessus.c : Doc/Comments. * libnessus/arglists.c : Doc/Comments. 2008-12-12 Felix Wolfsteller <felix.wolfsteller@intevation.de> Missing Makefile targets added (repairs pre-last commit). * nessus/Makefile : Added targets for new files. 2008-12-12 Felix Wolfsteller <felix.wolfsteller@intevation.de> Infrastructure for second step for CR #20 (ssh key management in client) (http://www.openvas.net/openvas-cr-20.html). Only in GUI, not feature- complete. * src/openvas-lib/openvas_ssh_login.h, src/openvas-lib/openvas_ssh_login.c : New file, handles login information (in mem, storing, loading), can create public and private keys. * src/gui/ssh_keys_dialog.h, src/gui/ssh_keys_dialog.c : New file, shows GUI to add and manage ssh login information. * Makefile, src/gui/Makefile : Added targets for new files. * MANIFEST : Added new files. * po/POTFILES : Added ssh_keys_dialog.c and comm.h. * nessus/comm.h : Changed credentials symbol (preferenc types have 9 char contraint), added NO_SSH_LOGIN_SELECTED define. * nessus/prefs_dialog/prefs_dialog.c : Comments improved. * nessus/prefs_dialog/prefs_dialog.c (get_plugin_radio_pref) : extracted method. * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_apply_plugin_prefs) : use of extracted method, build up combobox for ssh_logins. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c : Comments improved. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (pprefs_add_sshcredentials, add_key_to_combobox_cb) : Fill combobox with values from sshlogin hash table of Global context * nessus/prefs_dialog/prefs_dialog_prefs.c (ssh_management_button_cb, prefs_dialog_prefs ) : Added and hooked up button to show key management * nessus/context.c (context_pickup_sshkeys) : Added includes, pick up keys via openvas_ssh_login_file_read and only if Global context. * nessus/context.c (check_is_file, check_exists, check_is_dir) : Commented. * nessus/context.h : Replaced list for ssh key infos by hashtable. * nessus/comm.c (gui_comm_send_preferences) : Added support for new preference type (gui only). 2008-12-10 Michael Wiegand <michael.wiegand@intevation.de> * po/de.po: Fixed errors in German translation pointed out by Hans Ullrich. 2008-12-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> TODO ( harglst-> GSList for temporarily storing filenames) done. * nessus/comm.c (cli_send_prefs_arglist) : K&R header removed, comment added. * nessus/commc.c (cli_comm_send_preferences, gui_comm_send_preferences, cli_send_prefs_arglist) : Use GSList instead of harglst. * nessus/commc.c (comm_send_file) : Cleaned of debug printf. 2008-12-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> Various comments revamped, Todo (harglst -> Glib list) added. * nessus/comm.c : Documentation in javadoc style, harglst removal todo. 2008-12-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> Refactoring and comments of plugin preference gui creation. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (create_plugin_prefs_containers) : Documentation added. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (get_pref_value) : Method extracted to convert int values to yes/no. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (pprefs_add_sshcredentials) : use of get_pref_value, comment, combobox stub. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (pprefs_add_entry, pprefs_add_password, pprefs_add_file, pprefs_add_radio, pprefs_add_checkbox) : Duplicate code removal through extraction and use of new pref_get_value function. 2008-12-09 Felix Wolfsteller <felix.wolfsteller@intevation.de> Comments, minor style changes. * nessus/latex_output.c : Comments to javadoc style. * nessus/comm.c (comm_send_file) : Removed K&R funciton header, comment. * nessus/comm.c (gui_comm_send_preferences) : Donated braces, intendation. * nessus/context.h : Added comment about badly placed functions. * nessus/prefs_dialog/listnotebook.c (listnotebook_new) : Comment improved. * nessus/prefs_dialog/prefs_dialog_auth.c (prefs_dialog_auth_connection): Comment to javadoc style. 2008-12-08 Felix Wolfsteller <felix.wolfsteller@intevation.de> Comments. * nessus/prefs_dialog/prefs_dialog_prefs.c (prefs_dialog_prefs) : Function header style, comment. * nessus/prefs_dialog/listnotebook.c : Made comments javadoc-conform. 2008-12-05 Michael Wiegand <michael.wiegand@intevation.de> Real post release version bump. * VERSION: Set to 2.0.0.rc2.SVN. 2008-12-05 Michael Wiegand <michael.wiegand@intevation.de> Revert post release version bump, forgot to tag. * VERSION: Set to 2.0.0.rc1. 2008-12-05 Michael Wiegand <michael.wiegand@intevation.de> Post release version bump. * VERSION: Set to 2.0.0.rc2.SVN. 2008-12-05 Michael Wiegand <michael.wiegand@intevation.de> Preparing the openvas-client 2.0-rc1 release. * CHANGES: Updated. * VERSION: Set to 2.0.0.rc1. 2008-12-05 Felix Wolfsteller <felix.wolfsteller@intevation.de> Towards step 2 for CR #20: contexts scan .ssh directory for files. ( http://www.openvas.org/openvas-cr-20.html ). * nessus/context.h : Added list sshkeys to context struct. * nessus/context.c (context_init) : Function header reformatted, documented, sshkeys initialization. * nessus/context.c (context_add_plugin) : documented. * nessus/context.c (context_pickup_sshkeys) : new function to scan scopes .ssh directory. * nessus/context.c (context_collect_recurse) : calling context_pickup_sshkeys on appropriate directory, comment. 2008-12-05 Michael Wiegand <michael.wiegand@intevation.de> * po/de.po: Updated German translation. 2008-12-05 Michael Wiegand <michael.wiegand@intevation.de> * nessus/nessus.c (main): Fixed error message. 2008-12-05 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/plugin_cache.c (plugin_cache_write) : gettexted error msg and added include. 2008-12-05 Felix Wolfsteller <felix.wolfsteller@intevation.de> First step for CR #20: Add plugin preference type for ssh credentials. * nessus/comm.h : Added define for PREF_SSH_CREDENTIALS and todo item (define is duplicate of libopenvas.h) * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (pprefs_add_sshcredentials) : Function and proto to display combo box for future ssh key selection added. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (prefs_dialog_plugins_prefs_fill) : Comment added, case of PREF_SSH_CREDENTIALS included, show_info in case of unknown preference type added. 2008-12-04 Joey Schulze <joey@infodrom.org> * nessus/prefs_dialog/prefs_scope_tree.c (scopetree_move, scopetree_new_with_parent, scopetreeview_create_columns, scope_create_treestore): Adjust visible order of vulnerabilities to most important one first (Change Request #21) 2008-12-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> Transformed comments to javadoc style. * nessus/prefs_dialog/prefs_dialog.c : Transformed single star to double star ("javadoc") comments. * nessus/context.c : Added second star to start of function comments. * nessus/context.h : Documented signer_fp_certificates, removed comment duplicate (double of context.c). 2008-12-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_dialog.c : Removed (disabled) menuitem_TODO. 2008-12-04 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (pprefs_add_notebook_page) : Added comment, collapsed code duplicate. 2008-12-04 Michael Wiegand <michael.wiegand@intevation.de> * nessus/nessus.c (main): Improved handling of --list-plugins and --list-prefs parameters, made error messages more useful, removed stray printf. 2008-12-04 Michael Wiegand <michael.wiegand@intevation.de> * nessus/nessus.c (main): Fixed command line parsing to handle parameter assignments like --batchmode=host port ... correctly. 2008-12-03 Felix Wolfsteller <felix.wolfsteller@intevation.de> * /nessus/prefs_dialog/prefs_dialog_plugin_prefs.c : Comments added/ javadoc'ed. 2008-12-03 Felix Wolfsteller <felix.wolfsteller@intevation.de> Implementation of script tags according to CR #22 (http://www.openvas.org/openvas-cr-22.html). * nessus/plugin_infos.c (plugin_info_window_setup) : Display script tags. * nessus/plugin_cache.c : Increased max items per line, file format nr. * nessus/plugin_cache.c (write_plugin, plugin_cache_read) : Write and read script tag to/from cache. * nessus/nessus_plugin.h : Define char* script_tag in struct, adjust proto for nessus_plugin_new. * nessus/nessus_plugin.c (nessus_plugin_new, nessus_plugin_duplicate) : Set script_tag in plugin. * nessus/comm.c (parse_plugin) : Parse the new script_tag field, set script_tag in plugin struct. 2008-12-03 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/plugin_cache.c : Comments changed to doxygen "javadoc" style, return values documented. 2008-12-03 Felix Wolfsteller <felix.wolfsteller@intevation.de> * ChangeLog : Added function names in ChangeLog entries. 2008-12-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/plugin_infos.c (plugin_info_window_setup): respect the symbolic values NOXREF, NOCVE, NOBID and NOSIGNKEY. * nessus/pdf_output.c (print_plugin_information): Do not print appendix table rows if NOCVE, NOBID or NOXREF, improved text for signature summary. 2008-12-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> SSL Certificate view modernization. * nessus/sslui.c (sslui_showcert) : Replaced deprecated text widget and table by gtk_text_view and gtk_scrolled_window to remove GTK critical warnings on console. 2008-12-02 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixed certificate issues with multiple signatures. * nessus/comm.c (parse_certificate) : reverted, yesterdays fix not necessary because it seemingly happens with untrusted certificates only. * nessus/pdf_output.c (print_plugin_information_signatures) : consistent vertical alignment for appendix plugin table. 2008-12-02 Michael Wiegand <michael.wiegand@intevation.de> * po/de.po: Fixed typo in German translation. 2008-12-02 Michael Wiegand <michael.wiegand@intevation.de> * po/de.po: Updated German translation. 2008-12-02 Michael Wiegand <michael.wiegand@intevation.de> * nessus/prefs_dialog/prefs_help.h: Removed obsolete define for tooltip. 2008-12-02 Tim Brown <timb@nth-dimension.org.uk> * nessus/backed.c: Fixed some memory leaks as reported by cppcheck. 2008-12-01 Felix Wolfsteller <felix.wolfsteller@intevation.de> Fixing certificate issues and certificate listing in pdf reports. * nessus/plugin_info.c (plugin_info_window_setup) : use of g_strsplit instead of strtok, included test for connection to distinguish the case of unknown certificates vs client not connected. * nessus/report.c (report_save) : Load certificate store to have it at hand immideately in report context. * nessus/comm.c (parse_certificate) : clean up, crop fingerprints to keyids to ensure same inforamation in certificates and signatures. 2008-12-01 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/pdf_output.c : Typo in output fixed, brackets added. 2008-12-01 Joey Schulze <joey@infodrom.org> * nessus/parser.c (parse_expand_type, parse_host_add_data): Add new function to expand the message type into human readable string and use it * nessus/html_output.c (arglist_to_html): Consistent text phrases in reports * nessus/pdf_output.c (arglist_to_plainhtml): Consistent text phrases in reports * nessus/text_output.c (arglist_to_text): Consistent text phrases in reports 2008-11-28 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed code duplicates (html_graph_output / html_output). * nessus/html_graph_output.c : Removed duplicate function definitions and replaced calls with calls to the functions defined in html_output. 2008-11-28 Felix Wolfsteller <felix.wolfsteller@intevation.de> Better error messages and cleanup. * nessus/pdf_output.c : Cleanup. * src/openvas-lib/openvas_certificate_file.c (openvas_certificate_file_write): Better error msgs, empty signature store not interpreted as error (pointed out by Joey). * nessus/report.c (report_save) : Undid NULL check to write empty (just one comment) files when no certificates found. 2008-11-28 Joey Schulze <joey@infodrom.org> * nessus/report.c (report_save): Only try to save the certificate file if it exists 2008-11-27 Joey Schulze <joey@infodrom.org> * nessus/latex_output.c (latex_conclusion): Improved wording and formatting * nessus/latex_output.c (latex_appendix): Make generation of each itemised list in the appendix conditional * nessus/latex_output.c (latex_introduction_c): Fix typo * nessus/latex_output.c (latex_print_header): Corrected English grammar * nessus/html_output.c (summary_to_file): Add "Number of security notes found" to generated HTML report 2008-11-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/context.c : Added NULLness check to avoid GLib panic, include. 2008-11-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> Enabled signature and certificate information display in pdf reports. * nessus/context.c (context_collect_recurse) : Pick up certificates "cache" when loading a report context. * nessus/pdf_output.c : Added printing of signature and trust level information. 2008-11-26 Joey Schulze <joey@infodrom.org> Several clean up activities. * nessus/tex_output.c (line_length) : Removed superflous function * libnessus/system.c (emalloc, erealloc) : Adjust printf format string from %ld to %d because format '%ld' expects type 'long int', but argument 4 has type 'size_t' * nessus/backend.c (backend_convert) : Donate parentheses around assignment used as truth value * nessus/context.h : Fix typo * nessus/preferences.c (preferences_save_as) : Donate newline to improve config file format * nessus/parser.c (parse_server_message) : Use consistend indention * nessus/backend.c (backend_convert) : Use consistend indention 2008-11-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed Copyright sections that came with gdchart and snprintf. * packaging/debian/copyright : Removed "snprintf" Copyright section. * COPYING.README : Removed "snprintf" and "gdchart" Copyright sections. 2008-11-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> Cleaned pdf report code. * nessus/html_output.c : Comment and reference to pdf_output added. * nessus/pdf_output.c (html_print_plugin_box, arglist_to_plainhtml) : extracted method to print plugin infos, cleanup, comments 2008-11-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed obsolete snprintf copy. * libnessus/snprintf.c : Removed. * libnessus/Makefile : snprintf object removed. * MANIFEST : snprintf.c removed. 2008-11-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> Openvas_certificate_file mem-leak-fixed, added to manifest + potfiles. * src/openvas-lib/openvas_certificate_file.c : mem leak fixed. * MANIFEST : openvas_certificate_file.h/c added. * po/POTFILES : openvas_certificate_file added. 2008-11-26 Felix Wolfsteller <felix.wolfsteller@intevation.de> Comments added/improved. * src/openvas-lib/openvas_certificate_file.c, nessus/attack.c, nessus/pdf_output.c, nessus/plugin_infos.c, nessus/nbe_output.c, nessus/backend.c: Comments added/improved 2008-11-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> Save certificate information when saving a report. * nessus/report.c (report_save) : saves cert. info, comment, cosmetics. * nessus/report.c : added include, comments. * nessus/report.c (report_get_certificates_filename) : new function to return filename for certificate info file. * nessus/report.c : Added proto. 2008-11-25 Felix Wolfsteller <felix.wolfsteller@intevation.de> Added (de-)serialization functions for hashtables with openvas_certificates as content. * src/openvas-lib/openvas_certificate_file.h : Added. * src/openvas-lib/openvas_certificate_file.c : Added. * src/openvas-lib/Makefile : Corrected authorship and includes, removed targets. * nessus/Makefile : Added openvas_certificate_file target. * src/openvas-lib/openvas_certificates.c : Added todo about adherence to naming conventions. 2008-11-25 Joey Schulze <joey@infodrom.org> * po/POTFILES: Add more files to gettext POT generation that include translatable strings 2008-11-24 Joey Schulze <joey@infodrom.org> * nessus/nessus.c (connect_to_nessusd): Display better error message, change paranoia level to avoid OpenSSL messages on stderr. 2008-11-21 Michael Wiegand <michael.wiegand@intevation.de> * nessus/preferences.c (prefs_get_default): Fixed default value for OID links in HTML reports (closes bug #830). 2008-11-20 Michael Wiegand <michael.wiegand@intevation.de> * nessus/prefs_dialog/prefs_help.h: Changed non-functional nessus.org reference to the appropriate OpenVAS compendium URL. 2008-11-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed further duplicate code in export report to pdf/html functions. * nessus/html_output.c (print_data_with_links): Renamed to indicate module affiliation, included the changes small changes from the version in pdf_output.c, replaced calls. * nessus/html_output.h: Added proto for html_output_print_data_with_links, glib include. * nessus/pdf_output.c (print_data_with_links): Removed. Replaced calls. 2008-11-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> Removed duplicate code and therefore opened up interface to html_output. * nessus/html_output.c: Renamed formerly static functions to indicate module affiliation and removed staticness. * nessus/html_output.h: Added the protos for now non static functions. * nessus/pdf_output: Includes html_output.h, replaced function calls with new name, removed the duplicate code. * nessus/nessus.c (connect_to_nessusd): comment. 2008-11-19 Felix Wolfsteller <felix.wolfsteller@intevation.de> Reactivated broken appendix- feature of pdf report, added and improved comments. * nessus/pdf_output.c: comments, fixed ID/OID issue, oids are displayed correctly, reanimated the appendix in pdf, cosmetics (style). * nessus/backend.c (backend_convert): Incomplete comment added, cosmetics, resolved ID/OID issue for all (?) report types. * nessus/data_mining.c: moved comment. * nessus/parser.c: moved comment to the right place, added some. * nessus/cli.c: comments * nessus/nessus.c: example comment for a doxygen mainpage (for anybody demo-ing cr #19). * src/openvas-lib/openvas_certificates.c: typo in comment fixed. 2008-11-18 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/plugin_infos.c (plugin_info_window_setup): Dealing with the case when no certificate to a fingerprint is found in local hashtable (can happen e.g. with old server cachce files) added. * nessus/pdf_output.c (arglist_to_pdf): commented. * nessus/report.c (report_get_filename, copy_plugins): commented. * nessus/report_save.c (file_save_ok_callback, report_save_cb): commented. * nessus/report_utils.c: TODO added (replace safe_strcmp by glib vers.) 2008-11-18 Michael Wiegand <michael.wiegand@intevation.de> Fixing version requirements for glib as pointed out by atomicturtle. * configure.in: Updated glib requirements to >= 2.6.0 * configure: Regenerated. * aclocal.m4: Regenerated to update PKG_CHECK_MODULES. 2008-11-17 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/plugin_infos.c (plugin_info_window_setup): Looks at server pref nasl_no_signature_check and indicates if displayed signature is verified or not * nessus/comm.c: comments added. 2008-11-14 Tim Brown <timb@nth-dimension.org.uk> * nessus/OpenVAS-Client.desktop: Encoding tag now deprecated, see http://lintian.debian.org/tags/desktop-entry-contains-encoding-key.html. 2008-11-14 Michael Wiegand <michael.wiegand@intevation.de> Post release version bump. * VERSION: Set to 2.0.0.beta3.SVN. 2008-11-14 Michael Wiegand <michael.wiegand@intevation.de> Preparing the 2.0-beta2 release. * VERSION: Set to 2.0.0.beta2. * MANIFEST: Updated. * CHANGES: Updated. 2008-11-14 Felix Wolfsteller <felix.wolfsteller@intevation.de> * src/openvas-lib/openvas_certificates.c (openvas_certificate_free): NULL- guard and not freeing gboolean. * src/gui/error_dlg.c : comment added. * nessus/plugin_infos.c (showcert, plugin_info_window_setup) : updated, removed use of deprecated gtk widget, "beautified", showing trust level * nessus/context.c : hashtable init with correct destroy callback function + mem leak fix * nessus/context.h : include added 2008-11-14 Michael Wiegand <michael.wiegand@intevation.de> * nessus.tmpl.in, openvasclient-mkcert.in: Added datarootdir to remove configure warning and to be compatible with autoconf 2.60 (see http://www.gnu.org/software/libtool/manual/autoconf/Changed-Directory-Variables.html). 2008-11-14 Michael Wiegand <michael.wiegand@intevation.de> Applying patch provided by Stjepan Gros to eliminate compiler warnings. * nessus/comm.c (comm_parse_preference): Added parentheses around expression to remove compiler warning. * src/openvas-lib/openvas_certificates.c (openvas_certificate_free): Changed comparison of integer variable to zero instead of NULL, silencing the compiler warning. * libnessus/harglists.c (harg_addt, harg_set_valuet, harg_renamet): Added parentheses around if expressions to silence compiler warnings. 2008-11-13 Michael Wiegand <michael.wiegand@intevation.de> * nessus/sslui.c (sslui_showcert): Catch signal sent when user closes the certificate window. The uncaught signal caused the client to hang indefinitely when the window was closed. This solves bug #826 (http://bugs.openvas.org/826). 2008-11-12 Felix Wolfsteller <felix.wolfsteller@intevation.de> Work on Change Request #17 (http://www.openvas.org/openvas-cr-17.html - "OTP: Make NVT signatures available to OpenVAS-Client"). Now shows certificate information. * src/openvas-libraries : new folder for local copy of openvas_certificate struct added. * src/openvas-libraries/Makefile : added. * src/openvas-libraries/openvas_certificates.c : New file with openvas_certitificate struct, ~new and ~free added. * src/openvas-libraries/openvas_certificates.h : New file with protos added. * MANIFEST : updated * Makefile : added new dir to the clean target. * nessus/plugin_infos.c (plugin_info_window_setup) : include added, showing certificate information for a nvt with a button to show the full certificate. * nessus/plugin_infos.c (showcert): Added functionality to show a certificate. * nessus/Makefile : Changed to include the new files. * nessus/context.h : Removed hashtables from first implementation plan, added single signer_fp_certificates hashtable. * nessus/context.c (context_init, context_new) : Inits the hashtable signer_fp_certificates hashtable. * nessus/comm.c (parse_certificate, get_certificates) : corrected and updated. * ChangeLog : shamefully changed typos with my own email adress. 2008-11-12 Michael Wiegand <michael.wiegand@intevation.de> * configure.in: Added AC_PREREQ directive to tell autoconf to generate a 2.50-style configure script. * configure: Regenerated. 2008-11-12 Michael Wiegand <michael.wiegand@intevation.de> * nessus/attack.c (setup_plug_list): Increased maximum buffer size available for individual OIDs when constructing the plugin_set. This fixes a bug that caused long OIDs to be cut prematurely and damaging the plugin_set in the process. 2008-11-10 Michael Wiegand <michael.wiegand@intevation.de> Patch provided by Stjepan Gros <stjepan.gros@gmail.com> to improve 64-bit cleanliness. * nessus/preferences.c, nessus/preferences.h, nessus/plugin_infos.c, nessus/prefs_dialog/prefs_dialog.c, nessus/prefs_dialog/prefs_dialog_auth.c, nessus/prefs_dialog/prefs_context.c, nessus/prefs_dialog/prefs_report.c, nessus/prefs_dialog/prefs_scope_tree.c, nessus/prefs_dialog/prefs_kb.c, nessus/sslui.c, nessus/monitor_dialog.c, nessus/cli.c, nessus/report_save.c, nessus/context.c, nessus/comm.c, include/harglists.h, libnessus/harglists.c, libnessus/arglists.c, libnessus/network.c: 64/32-bit cleanups, minor reformatting. * libnessus/harglists.c, libnessus/arglists.c, libnessus/network.c, libnessus/Makefile:: added glib header 2008-11-07 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.c (comm_parse_certificate): (New) method stub. * nessus/comm.c (comm_get_certificates): Fixed and eased loop. 2008-11-05 Felix Wolfsteller <felix.wolfsteller@intevation.de> Work on Change Request #17 (http://www.openvas.org/openvas-cr-17.html - "OTP: Make NVT signatures available to OpenVAS-Client"). Receives dummy certificate information. * nessus/auth.c: Added comment. * nessus/nessus.c (connect_to_nessus): Attemps fetching certificate information. * nessus/comm.c (comm_get_certificates): Reads in the OTP "certificates" element. 2008-10-31 Felix Wolfsteller <felix.wolfsteller@intevation.de> Steps to an implementation of Change Request #17 (http://www.openvas.org/openvas-cr-17.html - "Make NVT signatures available to OpenVAS-Client"). The client now receives the new field "sign_key_ids", adds it to the plugin- structs and the local nvt caches. It is displayed in the plugin_info dialog. IMPORTANT: Breaks compatibility and renders old nvt- cache files useless. You will only be able to successfully connect to openvas-server with revision >= 1655. There might be problems with transmitting OVAL plugins from the server to client. * nessus/nessus_plugin.c (nessus_plugin_duplicate, nessus_plugin_new): Added new sign_key_ids field. * nessus/nessus_plugin.c (nessus_plugin_new): Updated struct, proto. * nessus/comm.c (parse_plugin, comm_get_certificates): Comments, goto-removal, use sign_key_id. Method stub to receive certificates. * nessus/comm.h: Prototype for comm_get_certificates. * nessus/plugin_infos.c (plugin_info_window_setup): Comment, simple label to display server trust information. * nessus/plugin_cache.c: Increased "max number of items per line" to parse, FILE_FORMAT_VERSION * nessus/plugin_cache.c (write_plugin, plugin_cache_read): Read and write the new "key_ids" field. * nessus/parser.c (parse_symbol, parse_separator): Comments++ K&R-Style-- * nessus/context.h: Added HashTables to store certificate information. 2008-10-27 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/prefs_dialog/prefs_help.h: Added tooltip definition for auto-enable new plugins - checkbox. * nessus/prefs_dialog/prefs_dialog.c: Added tooltip to auto-enable new plugins - checkbox. * po/de.po: Updated translation. * TODO: Added basic gui/usability section 2008-10-24 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/prefs_dialog/prefs_help.h: Fixed help string on port: 3001 is really ancient and of no relevance. 2008-10-22 Michael Wiegand <michael.wiegand@intevation.de> * nessus/cli.c (cli_sql_dump_plugins): Added fix proposed by Madhat Unspecific to correct the SQL produced by OpenVAS-Client in command line mode. 2008-10-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/comm.c (parse_plugin): Removed memory leak (were NULL returns, without taking care of emalloc'd strings). 2008-10-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/commc.c (parse_plugin): Peeled if-onion, variable name improved 2008-10-21 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/commc.c (parse_plugin): Peeled if-onion, variable name improved * nessus/plugin_cache.c: Updated doc/comments about format of nvt cache file. * nessus/preferences.c: Fixed tiny typo in comment. 2008-10-20 Michael Wiegand <michael.wiegand@intevation.de> * po/de.po: Updated German translation. 2008-10-20 Felix Wolfsteller <felix.wolfsteller@intevation.de> * nessus/commc.c (fetch_new_plugins, fetch_new_plugins): Changed strings displayed to the user in case of new plugins, to allow easier translations. 2008-10-17 Michael Wiegand <michael.wiegand@intevation.de> * nessus/xml_output_ng.c (xml_results_result_ports): Changed backend query to query for plugin_oid instead of plugin_id. This fixes a bug during XML export which resulted in an empty XML file. 2008-10-13 Felix Wolfsteller <felix.wolfsteller@intevation.de> Introduced a new scope- wise preference to control automatic en/disabling of new plugins. Partial solution to change request #16: http://www.openvas.org/openvas-cr-16.html . * nessus/preferences.c (prefs_get_default): Added default for "auto_enable_new_plugins" option (1) * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_set_defaults, prefs_dialog_apply): Hooked checkbox up with preference * nessus/prefs_dialog/prefs_plugins.c (prefs_dialog_plugins): Create and hook up GTK checkbox for new option * nessus/context.h (context_add_plugin): Changed signature of add_plugin from void to int * nessus/context.c (context_add_plugin): En/Disables new plugins based on the preference, returns if plugin was new (to be able to count) * nessus/comm.c (fetch_new_plugins, fetch_new_plugins): Counts new plugins based on the return value of context_add_plugin, displays info to user 2008-10-12 Tim Brown <timb@nth-dimension.org.uk> * packaging/debian/patches/01_libgdchart-gd2-noxpm-dev.patch, packaging/debian/patches/02_update_configure.dpatch openvas-client/packaging/debian/patches/00list: Removed. * packaging/debian/changelog: Updated. * packaging/debian/copyright: Updated. * packaging/debian/rules: Cleaned up. 2008-10-06 Michael Wiegand <michael.wiegand@intevation.de> * nessus/context.c (context_collect_recurse): Corrected string that prevented OpenVAS from loading the correct context. 2008-09-29 Michael Wiegand <michael.wiegand@intevation.de> * po/Makefile: Updated to support French and Croatian translation. 2008-09-29 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * MANIFEST: updated. 2008-09-28 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * openvasclient-mkcert.in: Renamed Nessus to OpenVAS and removed NessusWX-specific stuff. * nessus/html_graph_output.c (print_data_with_links): Renamed Nessus to OpenVAS. * nessus/html_output.c (print_data_with_links, summary_to_file): Renamed Nessus to OpenVAS. * nessus/latex_output.c (latex_print_header, latex_introduction_a, latex_introduction_b, latex_introduction_c, latex_introduction_d, latex_introduction_e, latex_conclusion): Renamed Nessus to OpenVAS. * nessus/text_output.c (arglist_to_text): Renamed Nessus to OpenVAS. * include/config32.h: Removed. This file isn't used anywhere. 2008-09-25 Michael Wiegand <michael.wiegand@intevation.de> Post release version bump. * VERSION: Set to 2.0.0.beta2.SVN 2008-09-25 Michael Wiegand <michael.wiegand@intevation.de> Doing the 2.0-beta1 release. * VERSION: Set to 2.0.0.beta1 * CHANGES: Updated. 2008-09-25 Michael Wiegand <michael.wiegand@intevation.de> * MANIFEST: Updated. 2008-09-23 Michael Wiegand <michael.wiegand@intevation.de> Added French translation provided by Marco Fradin. * po/fr.po: Added. * MANIFEST: Updated. 2008-09-22 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/comm.c (cli_comm_send_preferences, gui_comm_send_preferences): Removed sending "ntp_escape_crlf" as it is now standatd for OTP. 2008-09-19 Michael Wiegand <michael.wiegand@intevation.de> Added support for new LOG and DEBUG messages. Removed support for PREFERENCES ERROR message type as it was never properly implemented and is now obsolete. * nessus/attack.c (restore_attack, attack_host): Removed support for PREFERENCES ERROR message. * nessus/parser.c (parse_message_type, parse_server_message, parse_host_add_data): Added support for new LOG and DEBUG messages. Removed support for obsolete PING message. * nessus/backend.c (backend_convert): Added support for new LOG and DEBUG messages. * nessus/comm.c (comm_get_preferences_errors): Removed support for PREFERENCES ERROR message. 2008-09-17 Michael Wiegand <michael.wiegand@intevation.de> Changed communication protocol to use OTP exclusively now. Removed the last instances of dynamic protocol extension selection. * nessus/prefs_dialog/prefs_dialog_prefs.c (prefs_dialog_prefs): Removed NTP entry in selection box. * nessus/nessus.c (connect_to_nessusd): Removed dynamic creation of protocol string; the protocol string is now static. * nessus/nessus.h: Changed PROTO_NAME to OTP protocol string, removed obsolete PROTO_NAME_OTP define. 2008-09-17 Michael Wiegand <michael.wiegand@intevation.de> * nessus/attack.c (restore_attack, attack_host): Allocate a buffer large enough to hold all OIDs. This fixes a segfault in the client. 2008-09-14 Tim Brown <timb@nth-dimension.org.uk> * nessus/diff: Removed. 2008-09-12 Michael Wiegand <michael.wiegand@intevation.de> Added migration script to convert user data from IDs to OIDs. * tools/: Created. * tools/openvas1_to_openvas2.sh: Added. Migration script to convert user data from IDs to OIDs. 2008-09-12 Michael Wiegand <michael.wiegand@intevation.de> * nessus/comm.c (parse_plugin, comm_get_plugins_md5): Fixed parser to correctly handle the OIDs send by the server. 2008-09-11 Tim Brown <timb@nth-dimension.org.uk> * nessus/monitor_dialog.c: Fixed #758, which leads to an OpenVAS client crash due to a divide by zero. 2008-09-10 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/nessus_plugin.h (struct nessus_plugin): Finally remove the old ID. Its use has been eliminated all over the code. 2008-09-10 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Migrate the XML export format to a new version that now also uses OID as a base. Many node names have changed. There is currently no old version supported. * nessus/xml_output_ng.c (xml_plugins_plugin, xml_config_scanners): Change nodes "plugin id=" to "nvt oid=". (xml_config_plugins, xml_plugins): Renamed node "plugins" to "nvts". (backend_to_xml_ng): Renamed node "report" to "openvas-report". Renamed nessus.xsl to openvas-report.xsl, despite the fact neither previous nor the new exists. Version set to 1.0. (xml_info_nessusd): Renamed node "nessusd" to "openvasd", "libnasl" to "openvas-libnasl" and "libnessus" to "opnevas-libraries". 2008-09-10 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Migrate the LONG_ATTACK command to use OID instead of IDs. * nessus/attack.c (setup_plug_list): Create a ;-separated list of OIDs instead of IDs. 2008-09-10 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Migrate preferences to use OID instead of ID. This includes migration from "nessusrc" to "openvasrc" filename. * nessus/preferences.c (pluginset_reload): Change hash search from ID to OID. (struct hash): Changed type of name from int to char * as it is now OID. (hash_get): Changed parameter id to OID (and type from int to char *). The hash value is now the last element of the OID. The hash name is now OID. (new_pluginset): print OID instead of ID. (preferences_get_filename): Change filename from "nessusrc" to "openvasrc". ANSI C declaration. Renamed internal variables accordingly. (preferences_new): Initial settings use full OID now. 2008-09-10 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Migrate timout settings handling as well as SQL dumping to OID. * nessus/cli.c (_cli_sql_dump_plugins): Use OID for INSERT command instead of ID. (cli_sql_dump_plugins): Use OID as VARCHAR for CREATE TABLE instead of ID as Integer. * nessus/plugin_infos.c (plugin_info_window_setup): Use OID for calling the timeout settings dialog. (set_timeout): Base the timeout request on OID instead of ID now. Apply ANSI C func declaration. (set_timeout_build_window): Apply OID instead of ID as key for storing them internally. Apply ANSI C func declaration. * nessus/plugin_infos.c (do_set_timeout): Look for the values with the key "OID" instead of "ID". 2008-09-10 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Migrate plugin(nvt) caches to OID. * nessus/plugin_cache.c: Changed HEADER_MAGIC to OpenVAS code, because the structure of caches changes. Also changed PLUGIN_KEYWORD to "nvt", while we are at it. And rename PLUGIN_KEYWORD to NVT_KEYWORD. (write_plugin): Write OID instead of ID into plugin cache. (plugin_cache_get_filename): Renamed cache file from "nessus_plugin_cache" to "openvas_nvt_cache" and global cache file from ".openvas_plugin_cache" to ".openvas_nvt_cache". * nessus/plugin_infos.c (plugin_info_window_setup): Now display the OID in instead of ID in the info dialog. 2008-09-09 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Migrate PLUGIN_INFO request based on OIDs. Assume OIDs for receiving standard plugin information. * nessus/comm.c (parse_plugin): Now parsing for a OID string instead of the old integer ID. (fetch_new_plugins): Apply PLUGIN_INFO with OID instead of old ID. (struct mising_plugin): replaced element "int id" by "char * oid". (missing_plugins_list_add): Apply OID instead of ID. (update_existing_plugin): Apply OID instead of ID. (comm_get_plugins_md5): Migrated from ID to OID. (add_md5sum_to_plugin): Adapted parameter type. * nessus/nessus_plugin.c (nessus_plugin_new): Now takes and sets OID instead of old ID. (nessus_plugin_get_by_id): Renamed to nessus_plugin_get_by_oid() and switched to using OIDs. * nessus/nessus_plugin.h: Updated protos. * nessus/prefs_dialog/prefs_report.c (row_activated): Migrated from id to oid. * nessus/pdf_output.c (print_plugin_information): Migrated from id to oid. * nessus/data_mining.c: rename "plugin_id" to "plugin_oid" for query types. 2008-09-05 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Renaming element "asc_id" of struct "nessus_plugin" into "oid" all over the code. This prepares protocol changes that will consistently use OIDs. The renaming does not change the length of the data structure of nessus_plugin and with OIDs being strings anyway there is not use of a asc_id anymore. * nessus/nessus_plugin.h: Rename asc_id to oid in struct nessus_plugin. * nessus/nessus_plugin.c (nessus_plugin_new, nessus_plugin_duplicate): Renamed asc_id to oid. * nessus/cli.c (_cli_dump_plugins): Renamed asc_id to oid. * nessus/context.c (context_add_plugin): Renamed asc_id to oid. * nessus/filter.c (filter_plugin): Renamed asc_id to oid. * nessus/preferences.c (plugin_asc_id, plugin_id): Removed these methods. * nessus/preferences.h: Removed proto for plugin_asc_id(). 2008-09-05 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/nessus.h: Removed "timestamps" as protocol extension for OTP1.0 (it is default now). 2008-09-01 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/nessus.h: Removed "plugins_version", "plugins_cve_id", "plugins_bugtraq_id" and plugins_xrefs as protocol extension for OTP1.0 (it is default now). 2008-09-01 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/nessus.h: Removed "dependecies" as protocol extension for OTP1.0 (it is default now). 2008-09-01 Michael Wiegand <michael.wiegand@intevation.de> * nessus/plugin_infos.c (plugin_info_window_setup): Add description when displaying plugin version. 2008-09-01 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/attack.c (attack_host): Removed some old commented out code (which was about NEW_ATTACK). 2008-08-22 Javier Fernandez-Sanguino <jfs@computer.org> * po/es.po: Updated spanish translation. 2008-08-12 Michael Wiegand <michael.wiegand@intevation.de> * nessus/nessus.c (main): Do not display html_graph as possible output type in the command line options if the client was compiled without gdchart support. 2008-08-10 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Removing handling of "PLUGINS_ORDER" command which is not implemented in the server at all. It is not used in a senseful way anyway here in the client. * nessus/parser.h: Remove definition of MSG_PLUGINS_ORDER * nessus/parser.c (parse_message_type, parse_server_message): Removed handling of MSG_PLUGINS_ORDER. * nessus/cli.h (struct cli_args): Removed element plugins_order_table. * nessus/cli.c (build_plugins_order_table): Removed. (cli_test_monitor): Removed code element that did not do any useful things about plugins order. 2008-08-08 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/nmake.w32, nessus/nmake.bat: Removed. These are desperately outdated. * MANIFEST: Updated. 2008-08-08 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * VERSION: Set to 1.1.0.SVN to reflect that the 1.0 development has been branched and the development here lead to a next major release. 2008-08-08 Michael Wiegand <michael.wiegand@intevation.de> Removing gd and gdchart according to OpenVAS Change Request #14: http://www.openvas.org/openvas-cr-14.html Second part of patch. * nessus/html_graph_output.c, nessus/cli.c, nessus/report_save.c, nessus/nessus.c: Changed conditional to NO_GDCHART to better adapt to gdchart oddities. * configure.in: Improved header check for headers needed by gdchart; only set GDC_LIBS when _all_ headers are present. * include/config.h.in: Changed conditional to NO_GDCHART; defining HAVE_LIBFREETYPE as gdchart breaks compilation if it is not set (see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=242936). * configure: Updated. 2008-08-06 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Removing gd and gdchart according to OpenVAS Change Request #14: http://www.openvas.org/openvas-cr-14.html First part of patch. * configure.in: Added check for gdchart * nessus.tmpl.in: Add handling of GDC_LIB. * include/config.h.in: Add conditional HAVE_GDCHART. * nessus/Makefile: Removed any handling of gdchart modules. * nessus/html_graph_output.c: Added HAVE_GDCHART conditional and replaced direct includes by generic ones for gdchart. * nessus/cli.c (cli_args_output): Replaced _NO_PIES conditional by HAVE_GDCHART. * nessus/report_save.c (file_save_ok_callback, report_save_cb): Replaced _NO_PIES and _NOPIE conditionals by HAVE_GDCHART. * nessus/nessus.c (main): Added HAVE_GDCHART conditional. * nessus/globals.h: Removed already-commented-out definition of _NO_PIES. * gdchart0.94b/gdc_samp1.c, nessus/gdchart0.94b/NOTES-092b.txt, nessus/gdchart0.94b/gdc_samp2.c, nessus/gdchart0.94b/NOTES-093b.txt, nessus/gdchart0.94b/gdcpie.h, nessus/gdchart0.94b/NOTES-094b.txt, nessus/gdchart0.94b/gdc.h, nessus/gdchart0.94b/gdc_pie_samp.c, nessus/gdchart0.94b/gdchart.c, nessus/gdchart0.94b/gdchart.h, nessus/gdchart0.94b/samp.html, nessus/gdchart0.94b/price_conv.c, nessus/gdchart0.94b/W.gif, nessus/gdchart0.94b/gdc_pie.c, nessus/gdchart0.94b/README.txt, nessus/gdchart0.94b/gd1.3/demoin.gif, nessus/gdchart0.94b/gd1.3/gd.h, nessus/gdchart0.94b/gd1.3/gddemo.c, nessus/gdchart0.94b/gd1.3/gdfontmb.c, nessus/gdchart0.94b/gd1.3/gdfontl.h, nessus/gdchart0.94b/gd1.3/webgif.c, nessus/gdchart0.94b/gd1.3/gdfonts.c, nessus/gdchart0.94b/gd1.3/gdfontmb.h, nessus/gdchart0.94b/gd1.3/gdfontt.c, nessus/gdchart0.94b/gd1.3/gdfonts.h, nessus/gdchart0.94b/gd1.3/gdfontt.h, nessus/gdchart0.94b/gd1.3/giftogd.c, nessus/gdchart0.94b/gd1.3/mtables.c, nessus/gdchart0.94b/gd1.3/mathmake.c, nessus/gdchart0.94b/gd1.3/gdfontg.c, nessus/gdchart0.94b/gd1.3/index.html, nessus/gdchart0.94b/gd1.3/gd.c, nessus/gdchart0.94b/gd1.3/readme.txt, nessus/gdchart0.94b/gd1.3/Makefile, nessus/gdchart0.94b/gd1.3/gdfontl.c, nessus/gdchart0.94b/gd1.3/gdfontg.h, nessus/gdchart0.94b/makefile, nessus/gdchart0.94b/gdc.c: Removed. * nessus/gdchart0.94b/gd1.3: Removed empty directory. * nessus/gdchart0.94b: Removed empty directory. * MANIFEST: Updated. 2008-07-31 Vlatko Kosturjak <kost@linux.hr> * po/hr.po: New. Initial Croatian translation of OpenVAS client. 2008-07-19 Jan Wagner <waja@cyconet.org> * packaging/debian/changelog, packaging/debian/control, packaging/debian/copyright, packaging/debian/openvas-client.menu, packaging/debian/rules: Some more polishing * packaging/debian/patches/02_update_configure.dpatch: Patch a version of configure in, which works with debian unstable 2008-07-19 Tim Brown <timb@nth-dimension.org.uk> * nessus/Makefile: Fixed dependency issue that cause parallel builds to fail. * ChangeLog: Fixed typos. * packaging/debian/patches/01_libgdchart-gd2-noxpm-dev.patch, packaging/debian/changelog Ported the fixes to use libgdchart-gd2-noxpm-dev to the latest release. * packaging/debian/rules, packaging/debian/changelog: Fixed up rules file to correctly handle CROSS. 2008-07-05 Tim Brown <timb@nth-dimension.org.uk> * nessus/xml_output_ng.c: Fixed format string parameters to show_error() which resulted in a segfault as the format string expected two parameters and only one, the expanded strerror(errno) was supplied. 2008-07-04 Jan Wagner <waja@cyconet.org> * packaging/debian/changelog, packaging/debian/control: New debian package version with some minor changes. 2008-07-04 Michael Wiegand <michael.wiegand@intevation.de> * nessus/nessus.c (main): Do not let gtk_get_option_group open DISPLAY when parsing the command line as this leads to an error when DISPLAY is not set. This means the client is now able to run in quiet mode without DISPLAY being set; closes bug #645. 2008-07-01 Tim Brown <timb@nth-dimension.org.uk> * nessus/OpenVAS-Client.desktop: Removed SUSE directive as it was a mistake. Also changed Categories directive. 2008-07-01 Michael Wiegand <michael.wiegand@intevation.de> * TODO: Added section about the "Save Global Settings" behavior. 2008-06-27 Michael Wiegand <michael.wiegand@intevation.de> Post-release version bump. * VERSION: Set to 1.0.5.SVN. 2008-06-27 Michael Wiegand <michael.wiegand@intevation.de> Doing the 1.0.4 release. * VERSION: Set to 1.0.4. * CHANGES: Updated. 2008-06-26 Michael Wiegand <michael.wiegand@intevation.de> Reverted the name change for the plugin cache in context directories pending an appropriate change request as this might break transition from NessusClient to OpenVAS-Client. * nessus/plugin_cache.c (plugin_cache_get_filename): Set filename to nessus_plugin_cache if context->dir is set. 2008-06-26 Michael Wiegand <michael.wiegand@intevation.de> Fixed another bug that resulted in a segfault when running OpenVAS-Client in batch mode with a non-existent targets file and --output_type html_graph. * nessus/html_graph_output.c (risk_severity): Don't try to walk an empty hosts arglist. * nessus/cli.c: Replaced "nessus" with "OpenVAS" in error messages. 2008-06-26 Michael Wiegand <michael.wiegand@intevation.de> Fixed two bugs that resulted in segfaults. * nessus/plugin_cache.c (plugin_cache_get_filename): Set a filename for the plugin cache even if the user has supplied an alternate rc file. After all, chances are we will find a writable place. Running without a cache is non-functional and resulted in segfaults resp. no plugins in the context. We will try to put the plugin_cache in $HOME/.openvas_plugin_cache for now even if there is an alternate rc file. * nessus/plugin_cache.c (plugin_cache_write): Removed handling of !filename NULL as plugin_cache_get_filename now returns a filename in any case. * nessus/cli.c (cli_args_results): Re-added default file type in case the filename provided by the user contains neither '.' nor '/'. This bug was introduced in revision 673 with the removal of NSR support; we now default to nbe if the user provided no --output-type and we are unable to guess a format from the result filename. 2008-06-25 Michael Wiegand <michael.wiegand@intevation.de> * nessus/nessus.c (main): Made glib command line help gettext accessible, updated version message. * nessus/nessus_i18n.h: Use glib's gettext integration. * po/es.po, po/de.po, po/sv.po, po/he.po: Updated. 2008-06-24 Michael Wiegand <michael.wiegand@intevation.de> Making the protocol version an option in preparation for change request #12, http://www.openvas.org/openvas-cr-12.html. The current version of OpenVAS-Server will simply disconnect clients requesting OTP/1.0 as the server does not know about OTP yet. * nessus/preferences.c (prefs_buffer_parse, preferences_save_as): Added handling for protocol_version. * nessus/prefs_dialog/prefs_dialog_prefs.c: Added combobox for protocol version; the only options right now are NTP/1.2 and OTP/1.0 with NTP being the default. * nessus/nessus.c (connect_to_nessusd): Added handling of the protocol_version preference, made error message on bad protocol version disconnect more descriptive. * nessus/nessus.h: Added version string for OTP/1.0. * nessus/comm.c: Updated incorrect comments. 2008-06-23 Michael Wiegand <michael.wiegand@intevation.de> * nessus/nessus.c: Only add GTK options to parser group if GTK is indeed present; otherwise the client won't build with --disable-gtk. 2008-06-23 Michael Wiegand <michael.wiegand@intevation.de> Replaced getopt in nessus/nessus.c according to change request #11, http://www.openvas.org/openvas-cr-11.html. The client now uses the glib command line parser and no longer uses the nessus-modified version of getopt. * nessus/pdf_output.c: Moved the functions append_argv and destroy_argv from libnessus/getopt.c to here. These functions are not part of getopt, but were added to libnessus/getopt.c at a later date. * nessus/nessus.c (display_help): Removed display_help as this functioniality is now handled by glib. * nessus/nessus.c (main): Removed dependency on getopt, made error messages more useful, repaired options list-plugins, list-prefs and make-config-file, removed hidden (and no longer functional) option open-report, cleaned up code. * configure: Removed handling of getopt. * include/config.h.in: Removed handling of getopt. * include/getopt.h: Removed. * include/ntcompat.h: Removed handling of getopt. * include/libnessus.h: Removed ExtFuncs append_argv and destroy_argv; they now reside directly inside pdf_output so declaration here is no longer needed. * packaging/debian/copyright: Removed copyright notices for getopt. * configure.in: Removed handling of getopt. * COPYING.README: Removed copyright notices for getopt. * MANIFEST: Removed references to getopt. * libnessus/getopt.c: Removed. Moved the functions append_argv and destroy_argv to nessus/pdf_output.c as PDF generation depends on these functions. These functions are not part of getopt, but were added to libnessus/getopt.c at a later date. * libnessus/getopt1.c: Removed. * libnessus/Makefile: Removed handling of getopt. * doc/OpenVAS-Client.1: Removed reference to obsolete -r/--open-report option. 2008-06-20 Michael Wiegand <michael.wiegand@intevation.de> * nessus/nessus.c (main): Started replacing getopt with the glib command line parser. Note: The replacement is not yet complete and not yet thoroughly tested, batch mode is not yet working. I will finish the replacement on 2008-06-23. 2008-06-20 Michael Wiegand <michael.wiegand@intevation.de> * libnessus/hlst.c (sort_hlst): Avoid sorting an hlst if it has no entries since that will lead to an emalloc issue under certain conditions. 2008-06-19 Tim Brown <timb@nth-dimension.org.uk> * packaging/debian/control: Minor updates to control file, fixed Priority directive. 2008-06-20 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/OpenVAS-Client.desktop: Added SUSE directive as suggested by Ales Nosek. 2008-06-19 Michael Wiegand <michael.wiegand@intevation.de> Cleaned up the authentication dialog as the separation of the "Authentication" and "SSL Options" frames no longer makes sense. * nessus/prefs_dialog/prefs_dialog_auth.c: Removed "SSL Options" frame, moved SSL options to "Authentication" frame, cleaned up dialog layout. 2008-06-19 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * MANIFEST: updated. 2008-06-19 Michael Wiegand <michael.wiegand@intevation.de> Removed support for non-SSL connections according to change request #10, http://www.openvas.org/openvas-cr-10.html. The defines NESSUS_ON_SSL and HAVE_SSL are now considered obsolete because the client only allows SSL connections; the USE_AF_INET, USE_AF_UNIX and AF_UNIX_PATH defines are considered obsolete because local socket connections are no longer possible. * nessus/preferences.c: Removed obsolete handling of NESSUS_ON_SSL. * nessus/sighand.c: Removed obsolete handling of NESSUS_ON_SSL. * nessus/prefs_dialog/prefs_dialog.c: Renamed arglist key for connection icon to reflect that we no longer display a now redundant encryption icon; the icon now simply displays whether the client is connected or not. * nessus/prefs_dialog/prefs_dialog_auth.c: Removed obsolete handling of NESSUS_ON_SSL and USE_AF_INET; removed display of "Use SSL encryption" option. * nessus/prefs_dialog/prefs_context.c: Removed handling of redundant use_ssl preference; changed the now redundant encryption icon; the icon now simply displays whether the client is connected or not. * nessus/sslui.c: Removed obsolete handling of NESSUS_ON_SSL and USE_AF_UNIX. * nessus/nessus.c: Removed obsolete handling of NESSUS_ON_SSL, USE_AF_UNIX, USE_AF_INET and HAVE_SSL. * nessus/nessus.h: Removed obsolete handling of NESSUS_ON_SSL. * include/config.h.in: Removed obsolete handling of NESSUS_ON_SSL, USE_AF_UNIX, USE_AF_INET and HAVE_SSL. * include/config32.h: Removed obsolete handling of AF_UNIX_PATH and USE_AF_INET. * include/includes.h: Removed obsolete handling of HAVE_SSL. * include/libnessus.h: Removed obsolete handling of HAVE_SSL. * configure.in: Removed obsolete handling of HAVE_SSL and NESSUS_ON_SSL. * libnessus/network.h: Removed obsolete handling of HAVE_SSL. * libnessus/network.c: Removed obsolete handling of HAVE_SSL. 2008-06-17 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * doc/HTTP_authentication.txt: Removed. It is redundent with the file doc/HTTP_authentication.txt in openvas-server. 2008-06-16 Michael Wiegand <michael.wiegand@intevation.de> Fixed label in plugin information dialog. * nessus/plugin_infos.c: Changed label for the plugin description; the text show in the text box below the label is not the plugin output on a successful attack but the plugin description returned by the plugin itself. 2008-06-11 Michael Wiegand <michael.wiegand@intevation.de> Fixed bug introduced with the last change that prevented compilation. * nessus/Makefile: Execute target error_dlg.o only once. 2008-06-11 Michael Wiegand <michael.wiegand@intevation.de> Fixed compilation without GTK support; OpenVAS-Client will now compile when configured with --disable-gtk. It will now explicitly use glib when configured with --disable-gtk. Some core functioniality used to depend on the glib provided by GTK and would fail to compile without GTK present. * nessus/Makefile: Explicitly consider glib during make process; re-enabled compilation of src/gui/error_dlg.{c,h} even without GTK. * nessus/context.h: Now includes glib if GTK is not present. Enabled compilation of functioniality depending on glib without GTK. * nessus/context.c: Enabled compilation of functioniality depending on glib without GTK. * configure.in: Test for glib presence and set GLIB_CFLAGS and GLIB_LIBS. * configure: Regenerated from configure.in using autoconf. * nessus.tmpl.in: Use GLIB_CFLAGS and GLIB_LIBS. * nessus/nessus.c: Changed message when called without arguments and configured with --disable-gtk to be more helpful and to reflect the name change to OpenVAS. 2008-06-10 Tim Brown <timb@nth-dimension.org.uk> * nessus/OpenVAS-Client.desktop: Fixed icon directive. * nessus/prefs_dialog/prefs_dialog.c: Fixed NESSUS_DOCDIR to point at PREFIX/share/doc/openvas-manual 2008-06-05 Michael Wiegand <michael.wiegand@intevation.de> Enabling gettext translation for string added in CR #7. * nessus/prefs_dialog/prefs_report.c (row_activated): Gettext translation for NVT name and OID display is enabled. 2008-06-05 Michael Wiegand <michael.wiegand@intevation.de> Implementing Credentials page changes according to change request #8, http://www.openvas.org/openvas-cr-8.html. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (create_plugin_prefs_containers, prefs_dialog_plugins_prefs, prefs_dialog_plugins_prefs_read_only, prefs_dialog_plugins_prefs_fill, prefs_plugins_prefs_redraw, pprefs_add_notebook_page): Changed implementation of the credentials page to make use of the listnotebook class. * nessus/context.c (context_init, context_force_plugin_prefs_redraw): Added listnotebook object handling for credentials page to context. * nessus/context.h: Added listnotebook object for credentials page to context. 2008-06-05 Michael Wiegand <michael.wiegand@intevation.de> Extending report widget with optional plugin info according to change request #7, http://www.openvas.org/openvas-cr-7.html. * nessus/preferences.c (prefs_get_default): Added default value for new option "show_nvt_name_and_oid". * nessus/prefs_dialog/prefs_dialog_prefs.c (prefs_dialog_prefs): Added handling for new option "show_nvt_name_and_oid". * nessus/prefs_dialog/prefs_report.c (row_activated): Added retrieval and output of NVT name and (legacy) oid, provided the option "show_nvt_name_and_oid" in enabled and access to the plugin cache is available. 2008-06-04 Michael Wiegand <michael.wiegand@intevation.de> Fixed bug introduced in Rev 673 on 2008-02-25 that could cause filename corruption or segfaults when exporting a report with a format other than NBE. * nessus/report_save.c: Corrected #define values for file types other than NBE to sync them with the suffixes in char *suffixes[] in file_save_ok_callback. 2008-06-01 Michael Wiegand <michael.wiegand@intevation.de> Removing support of old XML report format according to change request #6, http://www.openvas.org/openvas-cr-6.html. * nessus/xml_output.h: Removed. * nessus/xml_output.c: Removed. * nessus/Makefile: Removed handling of module xml_output. * nessus/cli.c (cli_args_output): Removed handling of "old-xml". * nessus/nessus.c (display_help): Removed "old-xml" from list of options. (main): Removed actions for "old-xml". * nessus/report_save.c (file_save_ok_callback): Removed handling for old XML report format ("SAVE_XML"). (report_save_cb): Removed GUI selection for old XML in report save dialog. * doc/OpenVAS-Client.1: Removed reference to old XML report format. 2008-06-01 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Implementing Credentials page check according to change request #8, http://www.openvas.org/openvas-cr-8.html. * nessus/prefs_dialog/prefs_dialog_plugins_prefs.c (is_credentials): Removed. (prefs_dialog_plugins_prefs_fill): Replaced call of is_credentials by direct check for family "Credentials". 2008-04-18 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * packaging/fedora: New. Directory for Fedora RPM files. * packaging/fedora/openvas-client-1.0.3-1.fc8.openvas.spec: New. * MANIFEST: updated. 2008-04-16 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * packaging/opensuse: New. Directory for OpenSUSE RPM files. * packaging/opensuse/openvas-client-1.0.3-1.suse102.openvas.spec: New. 2008-04-16 Tim Brown <timb@nth-dimension.org.uk> * packaging/debian/control, packaging/debian/copyright: Synced with uploaded version. 2008-04-15 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * packaging/w32/openvasclient+gtk.iss.in: Updated version to 1.0.3. * packaging/w32/make-installer-openvas.sh: Updated version to 1.0.3, and added support for spanish and (commented out for the time being) hebrew. 2008-04-15 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * Makefile: Removed unused and useless target "w32". 2007-04-05 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/nessus.c, include/corevers.h.in: fix naming nessus->OpenVAS-Client. 2008-04-05 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/nessus.c (connect_to_nessusd): fix naming nessus->openvas. 2008-04-04 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Post-release version bump. * VERSION: Set to 1.0.4.SVN. 2008-04-04 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * MANIFEST: Updated. 2008-04-04 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Doing the 1.0.3 release. * VERSION: Set to 1.0.3. * CHANGES: Updated. 2008-04-02 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * MANIFEST: Updated. 2008-04-02 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * po/es.po, po/de.po, po/sv.po, po/he.po: Updated. 2008-04-02 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/preferences.c (prefs_get_default): NEW URL defaults for OpenVAS NVT ID, BID and CVE. Previous were directed towards nessus.org. * nessus/pdf_output.c (print_appendix, print_plugin_information): Made strings translatable. (fprint_link, print_data_with_links, print_plugin_information): Adapted OpenVAS ID referencing to the new OID scheme as specified with OpenVAS Change Request #1. 2008-02-29 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/nessus.c (connect_to_nessusd): Only write plugin cache if it is configured to cache plugins. This fixes a segfault when the caching feature is switched off and a connection established. This patch is contributed by Carsten Koch-Mauthe. 2008-02-29 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Refactored onKeypressed method for treeview widgets as it can be used at least for two treeview already. * src/gui/treeview_support.c, src/gui/treeview_support.h: New. Factored out onKeypressed from prefs_scope_tree.c. * src/gui/Makefile, nessus/Makefile: Added module treeview_support. * nessus/prefs_dialog/prefs_scope_tree.c (onKeypressed): Removed, now in treeview_support. * nessus/prefs_dialog/prefs_report.c (prefs_dialog_report): Connect tree with onKeypressed. 2008-02-29 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/prefs_dialog/prefs_scope_tree.c (onKeypressed): New. Expands/Collapses tree upon left/right arrow key. (prefs_dialog_scope_tree): Connect scopetreeview with onKeypressed. This patch is contributed by Carsten Koch-Mauthe. 2008-02-28 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/monitor_dialog.c (monitor_add_host, monitor_stop_whole_test, monitor_input_callback): Finally removed unused variable. 2008-02-28 Laban Mwangi <labeneator@gmail.com> * nessus/html_output.c, nessus/latex_output.c, nessus/text_output.c: Fix links in report pages. 2008-02-26 Tim Brown <timb@nth-dimension.org.uk> * nessus/monitor_dialog.c: Added some preprocessor directives to fix compiler warnings * nessus/preferences.c, nessus/prefs_dialog/prefs_context.c, nessus/prefs_dialog/prefs_dialog_prefs.c, nessus/prefs_dialog/prefs_report.c, nessus/prefs_dialog/prefs_report.h: Added global setting sort_order which can be set from preferences. When the report context changes this (when the report being shown changes) the default sort order will be applied. Justification, from a pentesting perspective, it is optimal to go after the most vulnerable ports first :). 2008-02-26 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * MANIFEST: Updated. 2008-02-25 Tim Brown <timb@nth-dimension.org.uk> * nessus/foo.tex, nessus/foo.xml, nessus/nessus.html: Removed as unrequired. 2008-02-25 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Final step of removing the NSR support (OpenVAS Change Request #2): Removed handling in code. * nessus/html_graph_output.c: Various renaming from Nessus to OpenVAS (arglist_to_html_graph): Removed saving a nsr file. This action appeared to have no effect anyway. * nessus/cli.c (cli_args_results): Removed setting of "nsr" as ftype as a default. (cli_args_output): Removed handling of ftype "nsr". * nessus/backend.c (backend_import_report): Removed handling for ".nsr" files. * nessus/report_save.c (SAVE_NSR): Removed. (file_save_ok_callback): Removed suffix ".nsr" from list, removed handlung to save nsr. (report_save_cb): Removed GUI selection label for NSR. * nessus/nessus.c (display_help): Removed "nsr" from help text. (main): Remove handling to write nsr format. * nessus/Makefile, nessus/nmake.w32: Remove handling of module "nsr_output". * nessus/nsr_output.c, nessus/nsr_output.h: Removed. 2008-02-23 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> First step of removing the NSR support (OpenVAS Change Request #2): Documentation. * OpenVAS-Client.1, nbe_file_format.txt: Removed any reference to NSR format. * nsr_file_format.txt: Removed. * MANIFEST: Updated. 2008-02-14 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * doc/ntp/README, doc/ntp/ntp_white_paper.txt, doc/ntp/plugin_prefs.txt, doc/ntp/ntp_extensions.txt, doc/ntp/ntp_white_paper_11.txt, doc/ntp/: Removed. They are redundant copies of the respective files in module openvas-server where they are maintained. * MANIFEST: Updated. 2008-01-05 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * COPYING.README: Adding the summary of copyrights as collected in file packaging/debian/copyright. 2008-01-04 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * MANIFEST: updated. 2007-12-29 Tim Brown <timb@nth-dimension.org.uk> * Makefile, packaging/debian/rules: Removed man8 from make install-man. * packaging/debian/changelog: Updated. 2007-12-29 Javier Fernandez-Sanguino <jfs@computer.org> * packaging/debian/copyright: More information in the copyright, including a detailed account of holders as well as reference to the LGPL and the inclusions of the licenses which are neither GPL nor LGP. Done after a full (C) and license review of all the source code. Convert to UTF-8 and fix typo. * packaging/debian/changelog: Updated. * packaging/debian/rules: Remove empty directory from the package. * openvas-client/po/es.po: Minor typo fix. 2007-12-28 Tim Brown <timb@nth-dimension.org.uk> * packaging/debian/openvas-client.menu: Updated in line with Debian Menu sub-policy * packaging/debian/patches/, packaging/debian/patches/00list, packaging/debian/patches/01_libgdchart-gd2-noxpm-dev.patch: New. Incorporates the fixes to use libgdchart-gd2-noxpm-dev. * packaging/debian/control: Depends on dpatch * packaging/debian/rules: Apply patches * packaging/debian/changelog: Updated. * Makefile: Removed installation of openvasclient-mkrand 2007-12-18 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Post-release version bump. * VERSION: Set to 1.0.3.SVN. 2007-12-18 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Doing the 1.0.2 release. * VERSION: Set to 1.0.2. * CHANGES: Updated. 2007-11-04 Tim Brown <timb@nth-dimension.org.uk> * packaging/debian/copyright, packaging/debian/changelog: Updated to list all contributing authors based on grep for "\([cC]\)|[cC]opyright". 2007-11-04 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * README: Replace license information by a reference to COPYING.README. * COPYING.README: New. * nessus/test.pdf: Removed. This test file probably has been added by accident. * MANIFEST: Updated. 2007-11-01 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * MANIFEST: Updated. 2007-11-01 Javier Fernandez-Sanguino <jfs@computer.org> * nessus/OpenVAS-Client.desktop: Enable logo. * packaging/debian/TODO, packaging/debian/openvas-client.menu: New. Sync with the contents of the uploaded Debian package. * packaging/debian/control, packaging/debian/changelog, packaging/debian/copyright, packaging/debian/rules: Sync with the contents of the uploaded Debian package. 2007-11-01 Javier Fernandez-Sanguino <jfs@computer.org> * po/README: Remove references to Nessus, move CVS to SVN. 2007-10-31 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * MANIFEST: Updated. 2007-10-31 Tim Brown <timb@nth-dimension.org.uk> * nessus/OpenVAS-Client.desktop: Removed Icon filename because it does not exist yet. * packaging/debian, packaging/debian/control, packaging/debian/dirs, packaging/debian/compat, packaging/debian/changelog, packaging/debian/copyright, packaging/debian/docs, packaging/debian/rules: New. The debian packaing files. * config.guess, config.sub: Merged changes from old Debian nessus-client package 2007-10-23 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Post-release version bump. * VERSION: Set to 1.0.2.SVN. 2007-10-23 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * MANIFEST: Updated. 2007-10-23 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Doing the 1.0.1 release. * VERSION: Set to 1.0.1. * CHANGES: Updated. 2007-10-21 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * README_SSL, doc/WARNING.En, doc/WARNING.Fr: Removed due to phrases that render the text files non-free. 2007-09-24 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/backend.c (backend_init): Replaced "nessus" by "openvas" for basename of temporary files. Found by Hanno Boeck. 2007-09-24 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * TODO: Yet another wish (NSIS) 2007-09-20 Bernhard Herzog <bh@intevation.de> * include/includes.h: No longer includes nessus-devel.h * include/nessus-devel.h: Removed because it's not actually used. 2007-09-18 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Post-release version bump. * VERSION: Set to 1.0.1.SVN. 2007-09-18 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Doing the 1.0.0 release. * VERSION: Set to 1.0.0. * CHANGES: Updated. 2007-09-18 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/prefs_dialog/prefs_help.h: Removed HLP_CIPHER_CHOICE since it is not used anywhere in the code. * po/de.po, po/he.po, po/sv.po: Updated (removed unused translations). * po/es.po: New. Spanish translation by Javier Fernandez-Sanguino 2007-09-17 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * po/Makefile: Added spanish. * MANIFEST: Updated. * nessus/prefs_dialog/prefs_help.h: Fixed string typos. Also "Nessus"->"OpenVAS". * nessus/prefs_dialog/prefs_scan_assistant.c: Fixed "Nessus" -> "OpenVAS" * po/de.po, po/sv.po: Updated. Resolved fuzzy. * po/he.po: Just updated. 2007-09-13 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/preferences.c, nessus/pdf_output.c, nessus/plugin_infos.c, nessus/prefs_dialog/prefs_dialog_auth.c, nessus/prefs_dialog/prefs_dialog_prefs.c, nessus/prefs_dialog/prefs_kb.c, nessus/prefs_dialog/prefs_help.h, nessus/backend.c, nessus/nessus.c: Replace "Nessus" UI Strings by "OpenVAS" where appropriate. * de.po, sv.po, he.po: Updated to new strings. de translated 100%, sv almost, he no updates. 2007-09-13 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * doc/OpenVAS-Client.1.in: Renamed to OpenVAS-Client.1 since there where no differences, so no need to let handle this by autotools. * doc/OpenVAS-Client.1: New. Former OpenVAS-Client.1.in. * configure.in: Don't handle OpenVAS-CLient.1.in anymore. * configure, TODO: Updated. 2007-08-30 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * src/gui/error_dlg.h: Applied standard header. * MANIFEST: Updated. * po/POTFILES, po/de.po, po/sv.po: Updated. * po/he.po: New. Hebrew translation. Contributed by Moti Yehoshua. * po/Makefile: Support hebrew (he). 2007-08-28 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * src/gui/error_dlg.c: Applied standard header. 2007-08-28 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * src/gui/error_dlg.c: Replace error_dialog.h by error_dlg.h. 2007-08-20 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * src/README: Fixed text because Intevation is not the exclusive copyright holder anymore. * nessus/error_dialog.h: Moved to gui/src/error_dlg.h * nessus/error_dialog.c: Moved to gui/src/error_dlg.c * gui/src/error_dlg.h: New. Former error_dialog.h. * gui/src/error_dlg.c: New. Former error_dialog.c. * gui/src/Makefile: Added module error_dlg. * nessus/Makefile: Adjustments to moved module error_dialog to src/gui/error_dlg. * nessus/comm.c, nessus/sighand.c, nessus/parser.c, nessus/plugin_cache.c, nessus/context.c, nessus/preferences.c, nessus/report.c, nessus/report_save.c, nessus/nsr_output.c, nessus/nbe_output.c, nessus/html_output.c, nessus/text_output.c, nessus/xml_output.c, nessus/xml_output_ng.c, nessus/html_graph_output.c, nessus/monitor_dialog.c, nessus/backend.c, nessus/prefs_dialog/prefs_dialog.c, nessus/prefs_dialog/prefs_scope_tree.c, nessus/prefs_dialog/prefs_dialog_scan_opt.c, nessus/prefs_dialog/prefs_dialog_user.c, nessus/prefs_dialog/prefs_plugins.c, nessus/prefs_dialog/prefs_plugins_tree.c, nessus/read_target_file.c, nessus/filter.c, nessus/nessus.c, nessus/prefs_dialog/prefs_context.c, nessus/prefs_dialog/prefs_scan_assistant.c, nessus/pdf_output.c: Replace error_dialog.h by error_dlg.h. 2007-08-16 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * packaging/w32/make-installer-openvas.sh, packaging/w32/openvasclient+gtk.iss.in, packaging/w32/README.txt: New. Some intitial scripts to create Windows Installer packages. Likely incomplete yet. 2007-08-16 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus.tmpl.in, include/config.h.in, include/config32.h, configure.in, Makefile, nessus/preferences.c: Removed any occurance of NESSUSD_*. * configure: updated. 2007-08-16 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * src/gui/slad_install.c (slad_install): disable sladinstaller test for CYGWIN as it does not work there. 2007-08-10 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * po/sv.po: Updated swedish translation by Daniel Nylander. 2007-08-02 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Basis of this are the patches by Javier Fernandez-Sanguino Pena for the Debian package. * doc/OpenVAS-Client.1.in: Replaced Nessus (nessusd, ...) by OpenVAS (openvasd, ...). * Makefile: Fixed cleanup routines. * nessus/OpenVAS-Client.desktop: Added spanish. 2007-07-31 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Post-release version bump. * VERSION: Set to 0.9.2.SVN. 2007-07-31 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Doing the 0.9.1 release. * VERSION: Set to 0.9.1. 2007-07-31 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Update everything to have I18N work again. * po/README: NessusClient -> OpenVAS-Client * po/POTFILES: updated. * po/de.po: upated. * CHANGES: updated. * README: Added note about language support. 2007-07-31 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Adding a menu entry with a startup routine for the sladinstaller GUI. SLAD is the Security Local Auditing Daemon which comes with some NASL scripts and thus can now be fully managed through OpenVAS-Client. * src/gui/slad_install.h, src/gui/slad_install.c: New. A sladinstaller startup routine. * src/gui/Makefile, nessus/Makefile: Adding module slad_install. * nessus/prefs_dialog/prefis_dialog.c (prefs_dialog_setup): Add menu item to run sladintaller startup. * MANIFEST: updated. * CHANGES: updated. 2007-07-31 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Removing the whole manual directory which now forms the new stand-alone module "openvas-manual". * doc/man/, doc/man/Makefile, doc/man/fixtex.pl, doc/man/users-manual-de.lyx, doc/man/users-manual.lyx, doc/man/images, doc/man/images/authentication-dlg-de.png, doc/man/images/authentication-dlg-en.png, doc/man/images/mainwindow-credentials-de.png, doc/man/images/mainwindow-credentials-en.png, doc/man/images/mainwindow-de.png, doc/man/images/mainwindow-en.png, doc/man/images/mainwindow-kb-de.png, doc/man/images/mainwindow-kb-en.png, doc/man/images/mainwindow-pluginprefs-de.png, doc/man/images/mainwindow-pluginprefs-en.png, doc/man/images/mainwindow-plugins-de.png, doc/man/images/mainwindow-plugins-en.png, doc/man/images/mainwindow-report-de.png, doc/man/images/mainwindow-report-en.png, doc/man/images/mainwindow-targetselection-de.png, doc/man/images/mainwindow-targetselection-en.png, doc/man/images/preferences-dlg-de.png, doc/man/images/preferences-dlg-en.png, doc/man/OpenVAS-logo.png: Removed. * MANIFEST: updated. * VERSION: Updated to 0.9.1.SVN. * CHANGES: Added info for 0.9.1 * nessus.tmpl.in, nessus/prefs_dialog/prefs_dialog.c (show_users_manual): New doc-dir is OpenVAS, not OpenVAS-Client. 2007-07-24 Bernhard Herzog <bh@intevation.de> * nessus/nessus_plugin.c: Remove unused include 2007-07-24 Bernhard Herzog <bh@intevation.de> * nessus/plugin_cache.c (plugin_cache_read): Remove incorrect comment. 2007-07-24 Bernhard Herzog <bh@intevation.de> * nessus/nessus_plugin.c (nessus_plugin_get_description): Return the description directly without making a copy. Since the description is now stored uncompressed it's not necessary anymore to return a copy and there were several places in the code where the returned string wasn't freed. * nessus/xml_output_ng.c (xml_plugins_plugin), nessus/pdf_output.c (print_plugin_information), nessus/filter.c (filter_plugin), nessus/cli.c (_cli_sql_dump_plugins): Adapt to nessus_plugin_get_description changes. 2007-07-24 Bernhard Herzog <bh@intevation.de> * nessus/nessus_plugin.c (nessus_plugin_new): Intern the summary, too. 2007-07-23 Bernhard Herzog <bh@intevation.de> * nessus/nessus_plugin.h (struct nessus_plugin): The plugin description is now stored uncompressed. * nessus/nessus_plugin.c (intern_string): New. Function to intern strings. (nessus_plugin_new): Use intern_string to store the description uncompressed but shared among nessus_plugin instances for the same plugin. (nessus_plugin_get_description): Adapt to description changes. 2007-07-23 Bernhard Herzog <bh@intevation.de> * nessus/cli.c (_cli_sql_dump_plugins, _cli_dump_plugins): Use nessus_plugin_get_description to get the uncompressed description 2007-07-19 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Final preparations for release 0.9.0. * VERSION: set to 0.9.0. * INSTALL: Removed. Those information were partly wrong or misleading. * README: Added some notes on compilation. * src/gui/about_dlg.c, src/gui/about_dlg.h, src/gui/Makefile, src/README, nessus/prefs_dialog/prefs_dialog.c: Because the copyright assignment takes some time, for the time being SPI is not yet the copyright holder. Intevation will transfer as soon as assignment process has been clarified. * CHANGES: Started anew with information on OpenVAS-Client. The previous information haven't been maintained consistently and have no meaning to the reader. * MANIFEST: updated. 2007-07-18 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * Makefile: Added target "dist". * MANIFEST: New. List of files for dist. * src/gui/Makefile: Fixed include-path and added Makefile as dependency for cflags. 2007-07-10 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * po/POTFILES: Replace module prefs_dialog by about_dlg. * po/de.po: Updating german translation. 2007-07-10 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Activate the src/gui/ source tree. Initially, this is done for the about dialog module. * nessus/prefs_dialog/prefs_about.c: Removed. Replaced by src/gui/about_dlg.c. * nessus/prefs_dialog/prefs_about.h: Removed. Replaced by src/gui/about_dlg.h. * nessus/Makefile: removed module prefs_about. Added new target "gui" and some handling for it (GUI_OBJS). Added module "about_dlg" which is now located under src/gui and build via target "gui". * nessus/prefs_dialog/prefs_dialog.c: Replace prefs_about by about_dlg. * nessus/xpm/logo_intevation.xpm: Removed. Now in src/gui/xpm/ * nessus/xpm/logo_bsi_de.xpm: Removed. Now in src/gui/xpm/ * nessus/xpm/OpenVAS-logo.xpm: Removed. Now in src/gui/xpm/ * nessus/xpm/logo_bsi.xpm: Removed. Now in src/gui/xpm/ * nessus/xpm/NessusClient.xpm: Removed. Not needed anymore. 2007-07-10 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Introduce new directory "src/" which will contain only clean stuff in terms of license and copyright. It is initially filled with one sample module. * src/: New. Directory to contain all new source modules and anything that is cleanly GPLv2 or any later version and copyright by SPI. * src/README: New. Explain what should be in this directory. * src/gui/: New. Directory to contain GUI modules. * src/gui/Makefile: New. Build instructions for GUI modules. * src/gui/about_dlg.c: New. Former nessus/prefs_dialog/prefs_about.c but with new header (Intevation transfers copyright to SPI) and renamed main function prefs_dialog_about to about_dialog. * src/gui/about_dlg.h: New. Former nessus/prefs_dialog/prefs_about.h but with new header (Intevation transfers copyright to SPI) and renamed main function prefs_dialog_about to about_dialog. * src/xpm/: New. Directory to contain XPMs used by modules under src/. * src/xpm/logo_bsi.xpm: New. Former nessus/xpm/logo_bsi.xpm. * src/xpm/logo_intevation.xpm: New. Former nessus/xpm/logo_intevation.xpm. * src/xpm/logo_bsi_de.xpm: New. Former nessus/xpm/logo_bsi_de.xpm. * src/xpm/OpenVAS-logo.xpm: New. Former nessus/xpm/OpenVAS-logo.xpm. 2007-07-09 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/prefs_dialog/prefs_about.c, nessus/prefs_dialog/prefs_dialog.c: Added info on SPI as being copyright holder for new code since OpenVAS-Client. 2007-07-05 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> * nessus/preferences.c, nessus/pdf_output.c, nessus/plugin_cache.c, nessus/nessus.h: rename files and directory from ".nessus*" to ".openvas*" * nessus/prefs_dialog/prefs_dialog.c (prefs_dialog_setup): Set a default size for the main window (1000x630). 2007-07-05 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> And more renaming from NessusClient ot OpenVAS-Client. * nessus/OpenVAS-Client.desktop: Renamed from NessusClient to OpenVAS-Client. * openvasclient-mkcert.in, ssl/openvasclient-mkrand.c: Renamed from nessusclient to openvasclient. * po/Makefile: Renamed NessusClient to OpenVAS-Client. Changed email address for bugs to openvas-devel mailing list. * po/de.po, po/sv.po: Renamed NessusClient to OpenVAS-Client. 2007-07-05 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Another series of name changes. Prevents name clash with installed NessusClient 1.x package. * configure.in: Renamed nessusclient-mkcert to openvasclient-mkcert. * configure: updated. * Makefile: Renamed nessusclient-mkcert to openvasclient-mkcert. Renamed nessusclient-mkrand to openvasclient-mkrand. * nessusclient-mkcert.in: Renamed to openvasclient-mkcert.in. * openvasclient-mkcert.in: New. Former nessusclient-mkcert.in. * ssl/nessusclient-mkrand.c: Renamed to openvasclient-mkrand.c * ssl/openvasclient-mkrand.c: New. Former nessusclient-mkrand.c. * ssl/Makefile: Renamed nessusclient-mkrand to openvasclient-mkrand. * doc/nessusclient-mkcert.1: Renamed to openvasclient-mkcert.1. * doc/openvasclient-mkcert.1: New. Former nessusclient-mkcert.1. * doc/nessusclient-mkrand.1: Renamed to openvasclient-mkrand.1. * doc/openvasclient-mkrand.1: New. Former nessusclient-mkrand.1. 2007-07-05 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Removed reference to Tenable in GUI on request by Renaud Deraison. * nessus/xpm/logo_tenable.xpm: Removed. * Makefile (prefs_about.o): Fixed dependencies concerning xpm's. * nessus/prefs_dialog/prefs_about.c: Removed reference to Tenable in about dialog. 2007-07-05 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Another bunch of renaming NessusClient to OpenVAS-Client. * nessus/xpm/OpenVAS-logo.xpm: New. The OpenVAS logo as a small xpm. * nessus/xpm/nessus.xpm: Removed. * nessus/prefs_dialog/prefs_about.c (prefs_dialog_about): Exchanged Nessus Logo/URL by OpenVAS logo/URL. Added license info. Removed URL to mailing list. * doc/man/nessus-logo.png: Removed. * doc/man/OpenVAS-logo.png: New. * doc/man/users-manual.lyx, doc/man/users-manual-de.lyx: Changed NessusClient to OpenVAS-Client (plain search and replace) and added a hint on the renaming situation. Replaced Logo. 2007-07-05 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> Introducing an improved scan progress dialog for GTK >= 2.6. * nessus/monitor_dialog.c (stop_toggled): New. Stop a scan if toggled off. * nessus/monitor_dialog.c (monitor_dialog_setup): default window size smaller for new style of dialog. Set up new style of dialog now with a TreeView Widget and full MVC (Model-View-Controller) concept. * nessus/monitor_dialog.c (monitor_list_update, monitor_remove_host, monitor_add_host): Consider new style of dialog (TreeView and MVC). 2007-07-05 Jan-Oliver Wagner <jan-oliver.wagner@intevation.de> First bunch of renaming. * ChangeLog: New. Starting to explicity log changes. * README: New. Explain the history in short. * VERSION: Set back to 0.9.0 as OpenVAS-Client starts anew. * Makefile, configure.in, nessus.tmpl.in, nessus/Makefile, nessus/preferences.c, nessus/prefs_dialog/prefs_about.c, nessus/prefs_dialog/prefs_dialog.c: Renaming NessusClient to OpenVAS-Client. * configure: updated (now created on vanilla Debian Etch 4.0) * doc/NessusClient.1.in: Renamed to OpenVAS-Client.1.in * doc/OpenVAS-Client.1.in: New. Former NessusClient.1.in * nessus/NessusClient.desktop: Renamed to OpenVAS-Client.desktop. * nessus/OpenVAS-Client.desktop: New. Former NessusClient.desktop.