2011-12-19 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Release 0.0.4
2011-12-18 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Add mandatory commas to udev rules file
2011-12-16 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Release 0.0.3
2011-12-12 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Minor correction to win2k8 volume ID
2011-12-02 Christophe Fergeau <cfergeau@redhat.com>
Handle NULL GError **
It's valid to pass NULL GError ** around when we are not interested
in error reporting. This means we have to make sure the GError** is
not NULL before dereferencing it. In particular, the right way of
testing if GError **err; is set is to do if (err && *err) {}
This commit adds a helper to do this check and uses it where needed.
Fix OSINFO_MEDIA_ERROR_INSUFFIENT_METADATA typo
This is an API change, but I don't think many application are
checking error code values of libosinfo errors so I'd say we can
do it a this point. A #define for the old symbolic name can be
added if we don't want to break the API.
Fix "insufficient metadata" test in on_pvd_read
There are 2 issues with this test:
1) it's not using is_str_empty, which means it won't do what's
expected on some ISOs where "empty" descriptors are read as a
string full of blank space
2) it mandates the presence of a system or publisher descriptor in
ISOs, which is not the case on ubuntu 11.10 ISOs. They only have a
volume descriptor. Since on most ISOs, publisher is empty and
system is "LINUX", they don't add much to discriminate between ISOs,
so we don't really need to mandate the presence of one of these.
Handle empty/NULL strings in is_str_empty
2011-11-30 Christophe Fergeau <cfergeau@redhat.com>
Remove useless prototype
The static function it declares is defined immediatly after it.
Remove unused python gobject import
Nothing in examples/demo.py uses this import, and having it causes a
runtime error:
Traceback (most recent call last):
File "examples/demo.py", line 4, in <module>
from gi.repository import Libosinfo as osinfo;
File "/usr/lib64/python2.7/site-packages/gi/__init__.py", line 23, in <module>
from ._gi import _API, Repository
ImportError: could not import gobject (error was: ImportError('When using
gi.repository you must not import static modules like "gobject". Please
change all occurrences of "import gobject" to "from gi.repository import
GObject".',))
Make sure we don't set a GError twice in OSInfoLoader
When parsing OSInfo XML documents, the catchXMLError callback may
be called for non fatal errors. When this happens, we get a pointer
to a parsed document which we can use, but we may have set a GError
during the parsing if a non fatal error was logged. This means we
have to make sure the error is cleared after the parsing, otherwise
we may attempt to set it twice which is forbidden
This can be triggered by running examples/demo.py:
$ python examples/demo.py
/usr/lib/python2.7/dist-packages/gi/types.py:43: Warning: GError set
over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error
is NULL before it's set.
The overwriting error message was: Incorrect root element
return info.invoke(*args, **kwargs)
Traceback (most recent call last):
File "examples/demo.py", line 6, in <module>
loader.process_path("./")
File "/usr/lib/python2.7/dist-packages/gi/types.py", line 43, in function
return info.invoke(*args, **kwargs)
gi._glib.GError: at line 18: Namespace prefix xi on include is not defined
Bug report and initial fix from Guido Günther <agx@sigxcpu.org>
2011-11-28 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Add more OS metadata
- More metadata on Debian, *SUSE, Ubuntu and Windows.
- Correct some metadata.
Based on a patch from Mateusz Kaplon <mateusz.kaplon@gmail.com>.
Add some information about Apple OSs
Based on a patch from Mateusz Kaplon <mateusz.kaplon@gmail.com>.
2011-11-24 Christophe Fergeau <cfergeau@redhat.com>
Fix setting of property default value
This commit reverts 4ba6a970dd4a6ba5e8efc49bb190c059f0d5b604.
For the default value of a GObject to be set upon object construction,
it needs to be marked as G_PARAM_CONSTRUCT or G_PARAM_CONSTRUCT_ONLY.
This commit adds this flag for the "installer" and "live" properties
("installer" defaults to TRUE and we want this to be set when the
object is created).
2011-11-24 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Correct flags for most Media properties
Most properties are not supposed be construct-only.
Initialize Media.installer to default value
Don't entertain empty ID headers from ISOs
Expose Media properties as gobject properties
Detection tool should set env for media ID
Detection tool now prints an environment variable 'OSINFO_MEDIA' with
the value of the ID of the media in the OS that was positively matched
against the media in question.
This implies setting of a udev property for the device by the same name.
Correct pattern matching logic
If both pattern and string are NULL, they should match.
API to indicate media is live and/or installer
Add live and installer boolean getters to Media.
Add live media data for Fedora 14-16
Return matched OS media
osinfo_db_guess_os_from_media() now has an out parameter that provides
the caller a reference to returned OS's media that was matched against
the passed media instance.
WARNING: This commit breaks API but its not really an issue since we
haven't yet promised API stability.
Don't match non-live Fedora ISOs against live ones
2011-11-24 Daniel P. Berrange <berrange@redhat.com>
Update to newer COPYING.LIB file with correct FSF address
Also include libosinfo.spec in tar.gz
Update RPM spec with tweaks from Fedora submission
2011-11-24 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Bump version
2011-11-22 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Remove contributors list from NEWS file
This release is out but doing this so I don't forget the rule of not
including contributors' list in next release announcement.
Release 0.0.2
2011-11-21 Christophe Fergeau <cfergeau@redhat.com>
Add VolumeIDs for CentOS
It doesn't seem to be possible to make the difference between a 32
or 64 bit CentOS iso just by looking at its headers so the iso type
guessing will need to be improved
Fix CentOS 6.1 entry
There were a few copy and paste typos
Add VolumeIDs for 2011 Ubuntu releases
Note that due to a bug in libosinfo, the detection of 11.10 won't work.
The 11.10 isos don't have a system id nor a publisher id, so they end
up as NULL in the parsed database, but they are a string of N consecutive
space when read from the iso. This prevents the match from working.
Fix <volume-id> for RHEL 5.x
The VolumeID for RHEL 5.x was RHEL/5.x, it was changed to RHEL_6.x
for RHEL6. I checked this with ISOs straight from RHN.
Fix <volume-id> for RHEL 4.x
The VolumeID for RHEL 4.x was RHEL/4-Ux, it was changed to RHEL_6.x
for RHEL6. I checked this with ISOs straight from RHN.
Fix <version> for RHEL 5.4
There was a typo.
Add openSUSE data
2011-11-21 Daniel P. Berrange <berrange@redhat.com>
Add homepage/mailing list / download links to README
2011-11-21 Christophe Fergeau <cfergeau@redhat.com>
Add #include <string.h> for strcmp
2011-11-16 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Recommend 9GiB for Fedora 14-16
Test for check if tests are enabled, not gir
Slightly more linient volume IDs for Fedora
Add Fedora 16 OS metadata
2011-11-01 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Add forgotten new classes to docs
Ask gtkdoc-scan to generate the sections file
This frees us from maintaining the sections file.
2011-10-26 Christophe Fergeau <cfergeau@redhat.com>
Improved volume ID regex for Windows 7
2011-10-25 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
First public release
Generate ChangeLog from git history on dist
Stole the Makefile.am rule and gitlog-to-changelog from libvirt.
Don't ignore the whole build-aux directory
Add a MAINTAINERS file
Update AUTHORS file
2011-10-21 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Improved README file
2011-10-20 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Consistent properties enum naming
Properties for Product attributes
2011-10-18 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Add API to fetch paths to kernel and initrd images
2011-10-17 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Provide paths to kernel & initrd in the install tree
2011-10-13 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Minimum/recommended resources for F14 & F15
Set UDEV properties for UDF media as well
2011-10-05 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Let there be Vala bindings!
Generate Vala bindings if vapigen tool is available, unless explicitly
asked not to.
Correct Cflags and Libs in .pc file
2011-10-04 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Include libxml2 in gir files
Fix two small introspection annotations
Stop using deprecated g-ir-scanner option
2011-10-03 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Properties for Resources attributes
Add setters for Resources' attributes
2011-09-26 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Constant for Kibibytes
2011-09-23 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Media ID strings are now regular expressions
Fix 2 small mistakes in syms and docs
Better udev rule installation
Provide a configure option to set the udev rule directory. If this
option is not set, udev directory defaults to '$prefix/lib/udev/rules.d'
unless $prefix is '/usr' in which case it defaults to '/lib/udev/rules.d'.
2011-09-22 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Add udev rules file to RPM package
2011-09-19 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Make *.ids generation optional (failable)
Just because one is hacking on git repo, doesn't mean he/she always have
access to Internet so download of *.ids should not fail the entire
build. They are not strictly needed anyways.
2011-09-15 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Don't worry on failure to install udev rule file
This can easily fail (e.g if `make install` is run unprivileged) and its
not a big deal if it does.
Hard-code GIBIBYTES definition
GIR scanner doesn't like it and its not like this value is going to
ever change anyways.
Load resources metadata from XML
Implement loading of OS minimum and recommended resources from XML.
Minor code clean-up
API to add/list resources to/from Os
Add API to add/list minimum and recommended resources to/from Os.
Add ResourcesList class
Add special list class to hold Resources instances.
Add Resources class
Add a new class to represent resource requirements/recommendations for OSs.
Add resource data for windows OSs
Add resource requirements and recommendations data for windows OSs.
2011-09-12 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Fix typos in OsinfoMedia doc comments
2011-09-02 Daniel P. Berrange <dan@berrange.com>
Allow OSINFO_DATA_DIR env var to override default location for DB
Avoid referencing NULL pointer if data dir does not exist
Add osinfo-detect.exe to the mingw32 RPM spec
2011-09-02 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Add Udev support
If enabled, provide a udev rule to listen to insertion/removal of
ISO9660 media and sets some helpful (to apps) properties on the device
if media is bootable.
2011-09-01 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Add utility app that detects OS given a media
Given a path to a ISO9660 image/device, detects if media is bootable and
the relavent OS if media is an installer for it.
2011-08-23 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Async variant of osinfo_media_create_from_location()
'new' -> 'create' in osinfo_media_new_from_location()
Renaming osinfo_media_new_from_location() to
osinfo_media_create_from_location() to emphasize the factory nature
of this function.
Also the convention in g* world is to keep _new() as only thin wrappers
around g_object_new() calls.
Replace OsinfoDb.guess_os_from_location() by guess_os_from_media()
Add osinfo_media_new_from_location()
Add API to create a OsinfoMedia object, given an installation media
location. This includes moving of installation media errors to
osinfo_media module and rename from OsinfoInstallMediaError to
OsinfoMediaError.
Some application/libraries will want to be able to get basic information
about an installation media without having to load the whole metadata DB.
Add osinfo_db_guess_os_from_location()
Add API to guess OS given an installation media location.
2011-08-22 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Explicitly reguire Gio GIR
2011-08-04 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Add media metatadata to RHEL & some Windows OSs XML
Add ISO metatadata to Fedora media XML
Load media metadata from XML
Add API to add/list medias to/from OS
Add MediaList class
Add special list class to hold Media instances.
Add Media class
Add a new class to represent installation media, typically an CD/DVD ISO
or an online filesystem hierarchy.
Correct a typo in OSinfoOS doc comment
2011-07-26 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Remove '-' from Fedora OSs' short ID
This is to ensure compatibility with existing OS dictionary of
python-virtinst and virt-manager.
2011-07-01 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Correct node name
The 'derives' element in OS XML is supposed to be 'derives-from'.
Use correct param names in Product getters
2011-06-29 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Add a 'class' attribute to OS
This is the generic family this OS belongs to, for example Linux, Windows,
Solaris, UNIX etc.
2011-06-28 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
VBox USB Tablet is an 'input' device, not 'block'
2011-06-28 Daniel P. Berrange <berrange@redhat.com>
Tricks to avoid gcc set-but-not-read-vars warning
2011-06-23 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Correct 2 small spelling mistakes in docs
Add osinfo_loader_process_default_path()
Add a method that enables applications to load the metadata osinfo
provides without having to specify any paths.
Micro coding-style fixes
- Remove redundant newlines.
- Add newlines where needed.
Add some randome OS metadata
Add MS-DOS and Novell Netware metadata.
2011-06-22 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Add *BSD OS metadata
Add Sun Solaris OS metadata
2011-06-17 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Add Windows OS metadata
Correct a typo in all XML files
Add generic Linux OS metadata
Add Ubuntu OS metadata
Add Debian OS metadata
Add Mandriva OS metadata
Add Suse Linux Server OS metadata
2011-06-16 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Add more Fedora OS metadata
Now libosinfo knows every Fedora OS known to python-virtinst.
Add media information for f13 & f14
Add more RHEL OS metadata
Now libosinfo knows every RHEL OS known to python-virtinst.
2011-06-09 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Add basic devices to RHEL OSes
2011-06-08 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Rename RHEL OS metadata file as par latest changes
Add OS metadata for supported RHEL releases
Also add last supported RHEL releases to allow upgrades to supported
ones.
Add XML for Qemu/KVM PS2 devices
Add PS2 keyboard and mouse to Qemu/KVM device DB.
2011-06-03 Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Add XML for Qemu/KVM USB devices
Currently, it only has one device.
2011-06-01 Daniel P. Berrange <berrange@redhat.com>
Fix some API docs to make introspection work again
Add some more realistic data files
Start on basic metadata for Fedora/RHEL and QEMU/Xen
Only load DB files with a .xml extension
To ensure we skip over random files, only load things ending
with a '.xml' extension
2011-06-01 Zeeshan Ali <zeeshanak@gnome.org>
Strip correct C namespace
Fixes build against latest GIR.
2011-04-19 Daniel P. Berrange <berrange@redhat.com>
Add some scripts for converting USB/PCI ID lists to XML
Add some scripts which are able to convert from the raw USB
and PCI device ID lists to the osinfo XML format. Do not
actually use these scripts by default though, because the
osinfo loader can read the native formats *much* faster
than reading the XML variant
Pull down USB and PCI device IDs from sourceforge
Populate the database with all USB and PCI device IDs known
to the master sourceforge databases
Load all files in data directory in example scripts
* examples/demo.js, examples/demo.py: Load all files
from data/
Allow the DB loader to process sf.net PCI/USB id lists
Allow the DB loader to process the master lists of PCI and
USB device IDs, as downloadable from sourceforge.
Improve scalability of object list lookups
Looking up a entity by ID is O(n) due to iteration over an
array. This is impossibly slow with the full set of PCI
and USB device IDs loaded. Add in a hashtable to provide
for O(1) lookups
Remove TAB characters (again)
Allow arbitrary custom xml attributes with an x- prefix
* data/libosinfo-dummy-data.xml: Some example custom attrs
* osinfo/osinfo_entity.c, osinfo/osinfo_entity.h: Add a
method for setting a parameter, rather than just adding
to it
* osinfo/osinfo_loader.c: Allow custom xml attrs with
an 'x-' prefix
* demo.js, demo.py: Update to demo new capabilities
Add constants and API accessors for common parameters
There are some standard parameters for products, devices and
devicelinks. Add static constants and API accessors for these
2010-09-02 Daniel P. Berrange <berrange@redhat.com>
Add notes about possible data sources for populating the database
Add notes about the possible sources for finding device info
about operating systems and hypervisor platforms
* docs/data-sources.txt: Note data sources for OS and hypervisors
Remove some bogus symbols to fix Win32
Win32 linker does not like linker scripts containing symbols
which do not exist
* osinfo/libosinfo.syms: Remove bogus symbols
Introduce a OsinfoDeployment object
The supported devices for deploying an OS on a platform are
tracked as part of the main OS device list. This is not
sufficiently flexible because it does not allow for tracking
extra metadata against a (os, platform) pair. Introduce a
new "deployment" object to track the metadata for deploying
an OS on a platform.
* docs/object-model.fig: Illustrate the object model
* data/libosinfo-dummy-data.xml: Introduce deployment
metadata
* examples/demo.py, examples/demo.js: Update for new
APIs
* osinfo/Makefile.am, osinfo/libosinfo.syms,
osinfo/osinfo.h, osinfo/osinfo_db.c, osinfo/osinfo_db.h
osinfo/osinfo_db.h, osinfo/osinfo_deployment.h,
osinfo/osinfo_deploymentlist.c, osinfo/osinfo_deploymentlist.h,
osinfo/osinfo_devicelink.c, osinfo/osinfo_loader.c: Introduce
an explicit deployment object
* osinfo/osinfo_os.c, osinfo/osinfo_os.h, test/test-db.c,
test/test-os.c: Remove tracking of hypervisor preferred
devices
* osinfo/osinfo_devicelinkfilter.c,
osinfo/osinfo_devicelinkfilter.h: Allow filtering against
a link and its target device at the same time.
Introduce a new OsinfoProduct abstract class
It is neccessary to track upgrades/clones/derives relationships
for platforms as well as operating systems. Introduce a common
parent class for both called OsinfoProduct
* data/libosinfo-dummy-data.xml: Make platform XML use the
common product XML attributes/relationships
* docs/reference/Libosinfo-docs.xml, docs/reference/Libosinfo-sections.txt,
docs/reference/Libosinfo.types: Update for new/renamed classes
* osinfo/Makefile.am, osinfo/libosinfo.syms,
osinfo/osinfo.h: New OsinfoProduct class
* osinfo/osinfo_product.c, osinfo/osinfo_product.h,
osinfo/osinfo_productlist.h, osinfo/osinfo_productlist.c: New
classes
* osinfo/osinfo_os.c, osinfo/osinfo_os.h,
osinfo/osinfo_platform.c, osinfo/osinfo_platform.h: Change
to inherit from OsinfoProduct
* osinfo/osinfo_oslist.c, osinfo/osinfo_oslist.h,
osinfo/osinfo_platformlist.c, osinfo/osinfo_platformlist.h:
Change to inherit from OsinfoProductList
* osinfo/osinfo_db.c, osinfo/osinfo_db.h, osinfo/osinfo_loader.c:
Update for new class hierarchy
* osinfo/osinfo_osfilter.c, osinfo/osinfo_osfilter.h,
osinfo/osinfo_osfilter.h, osinfo/osinfo_productfilter.h: Rename
filter class
Rename 'OsinfoHypervisor' to 'OsinfoPlatform'
Not all virtualization technologies are hypervisors. Rename the
OsinfoHypervisor object to the more general term OsinfoPlatform.
* data/libosinfo-dummy-data.xml: Rename 'hypervisor' element
to 'platform'
* docs/reference/Libosinfo-docs.xml, docs/reference/Libosinfo-docs.xml
docs/reference/Libosinfo.types: Update docs for new object name
* examples/demo.js, examples/demo.py: Update for object name
* osinfo/osinfo_hypervisor.c, osinfo/osinfo_hypervisor.h,
osinfo/osinfo_hypervisorlist.c, osinfo/osinfo_hypervisorlist.h,
osinfo/osinfo_platform.h, osinfo/osinfo_platformlist.c,
osinfo/osinfo_platformlist.h, osinfo/osinfo_platform.c,
osinfo/osinfo.h, osinfo/osinfo_db.c , osinfo/osinfo_db.h,
osinfo/osinfo_device.c, osinfo/osinfo_devicelink.c,
osinfo/osinfo_devicelink.c, osinfo/osinfo_os.h,
osinfo/osinfo_loader.c, osinfo/libosinfo.syms,
osinfo/Makefile.am: Rename OsinfoHypervisor to OsinfoPlatform
* test/Makefile.am, test/test-os.c, test/test-hypervisor.c,
test/test-platform.c, test/test-db.c: Update for object
name
Expand example programs
Expand the example programs to demonstrate how to obtain the
the preferred device for an operating system/hypervisor pair
* examples/demo.js, examples/demo.py: Demonstrate device
filtering
Turn internal device link into a public object
To enable arbitrary parameters to be set on the association
between the device & hypervisor/os objects, turn the internal
device link struct into a formal managed OsinfoEntity called
OsinfoDeviceLink.
* data/libosinfo-dummy-data.xml: Make 'driver' into a entity
parameter instead of link text content
* docs/reference/Libosinfo-docs.xml,
docs/reference/Libosinfo-sections.txt: Add OsinfoDeviceLink
and OsinfoDeviceLinkList objects
* docs/reference/Libosinfo-sections.txt, osinfo/libosinfo.syms,
osinfo/osinfo.h, osinfo/osinfo_devicelink.c,
osinfo/osinfo_devicelink.h, osinfo/osinfo_devicelinklist.c,
osinfo/osinfo_devicelinklist.h: Add OsinfoDeviceLink and
OsinfoDeviceLinkList objects.
* osinfo/osinfo_hypervisor.c, osinfo/osinfo_hypervisor.h,
osinfo/osinfo_os.c, osinfo/osinfo_os.c: Convert internal
device links to use OsinfoDeviceLink object
* osinfo/osinfo_loader.c: Allow setting of 'driver' attribute
on device links
* test/test-hypervisor.c, test/test-os.c: Update for API
change
2010-09-01 Daniel P. Berrange <berrange@redhat.com>
Fix VPATH build for gtk-doc
gtkdoc-scan is run from the source dir, so it the path must be
relative to the source dir, not using $(top_srcdir) which is
relative to the build dir.
* docs/reference/Makefile.am: Fix docs path
Add two examples using GObject introspection
Add two example programs using GObject introspection bindings
for Python (PyGObject) and Javascript (GJS)
* examples/demo.js: Javascript demo
* examples/demo.py: Python demo
* Makefile.am, configure.ac: Add examples Makefile
* examples/Makefile.am: Include demos in dist
* libosinfo.spec.in: Include demo programs + docs
* mingw32-libosinfo.spec.in: Kill docs
Ensure args can be passed to autogen.sh
Ensure that autogen.sh honours args passed to it, but passing
them on down to gnome-autogen.sh, enabling usage such as
./autogen.sh --enable-coverage
* autogen.sh: Pass command line args down to gnome-autogen.sh
Remove list iterator & add API to retrieve a GList
The OsinfoList iterator method does not play nicely with
gobject introspection bindings. Remove it, and replace with
a method that returns a GList of elements. This trivially
maps to the language bindings native list/array classes
which are natively iterable.
* docs/reference/Libosinfo-sections.txt: Remove osinfo_list_foreach
and add osinfo_list_get_elements
* osinfo/osinfo_list.c, osinfo/osinfo_list.h: Remove osinfo_list_foreach
and add osinfo_list_get_elements
* osinfo/osinfo_db.c: Rewrite to use g_list_foreach and
fix some GList annotations to specify element type
correctly.
* test/test-list.c: Rewrite to use g_list_foreach
Add API docs for all public methods
Add GTK-DOC api docs for all public methods, signals, objects,
enums, etc. Include annotations required for GObject Introspection
to get reference counting / memory allocation correct when doing
automatic language binding generation
* osinfo/*.c: Add API docs for all methods / signals / objects / enums
* osinfo/*.h: Ensure parameter names match those in the corresponding
.c file implementation to avoid confusing gtk-doc
Remove 'self' as a parameter name.
Using 'self' as a parameter name in methods makes the code feel
more object-oriented, but it doesn't play nicely with gtk-doc
because 'self' isn't a very descriptive name for docs. Replace
all occurances of a 'self' with a short name for the object in
question.
* osinfo/*.c, osinfo/*.h: Remove use of 'self' as a parameter
name
Integrate gtk-doc into the build for API docs
* Makefile.am: Add docs subdir
* autogen.sh: Enable gtk-doc build by default
* configure.ac: Add check for gtk-doc
* doc/api.txt, doc/overview.txt: Remove inaccurate, outdated
docs
* docs/Makefile.am: Add reference/ subdir
* docs/reference/: bare template for gtk-doc content
2010-08-31 Daniel P. Berrange <berrange@redhat.com>
Add emacs magic for indentation rules
Fix some files where tabs have crept in for indentation and
add emacs magic to ensure they don't return.
* osinfo/*.h, osinfo/*.c, tests/*c: Add footer setting emacs
indentation rules. Re-indent to comply.
Avoid directly exposing internal lists in OsinfoDb
Don't directly expose the OsinfoList objects used by the
OsinfoDb class. Instead return a shallow copy of the lists.
Add formal APIs for adding entities to the DB.
* osinfo/osinfo_devicelist.c, osinfo/osinfo_devicelist.h,
osinfo/osinfo_hypervisorlist.c, osinfo/osinfo_hypervisorlist.h,
osinfo/osinfo_oslist.c, osinfo/osinfo_oslist.h: Add new
constructor to copy an existing list
* osinfo/osinfo_list.c, osinfo/osinfo_list.h: Add API to
copy elements of an existing list
* osinfo/osinfo_db.c, osinfo/osinfo_db.h: Shallow copy
the lists before returning them. New APIs for adding
entities to the DB.
* test/test-list.c, test/test-db.c: Update for changed APIs
2010-08-27 Daniel P. Berrange <berrange@redhat.com>
Ensure all GList return values are duplicated
To avoid exposing callers to the internal implementation,
ensure all returned GList * values are shallow-copied.
All callers must g_list_free the value. The elements are
not copied.
* osinfo/osinfo_db.c, osinfo/osinfo_db.c,
osinfo/osinfo_filter.c, osinfo/osinfo_osfilter.c: Copy
all GList return values.
* test/test-entity.c, test/test-filter.c,
test/test-osfilter.c: Free GList values
Enable test suite during automated & RPM builds
* autobuild.sh: Enable tests
* configure.ac: Allow tests to be disabled for Win32
* libosinfo.spec.in: Enable tests
* libosinfo.spec.in: Disable tests
* test/test-loader.c, test/Makefile.am: Fix VPATH build
Ignore more test programs
Convert loader to use GIO
Direct use of POSIX/stdc I/O is deprecated in favour of
the GIO system. Re-write the OsinfoLoader to use GIO
for loading XML from arbitrary paths/uris.
* configure.ac: Check for GIO library
* osinfo/Makefile.am: Link to GIO
* osinfo/osinfo_loader.c, osinfo/osinfo_loader.h: Port
to GIO
* test/osinfo.suppression: Supress many GIO data types
* test/test-loader.c: update for new GIO api.
Pull XML loader into a separate class
Instead of having a method on the OsinfoDb class
for loading XML, introduce a new object that can
handle XML loading. This then gives back a DB when
loading is finished
* osinfo/osinfo_db.c, osinfo/osinfo_db.h: Remove
backing-store property and xml loader methods
* osinfo/osinfo_loader.c, osinfo/osinfo_loader.h: New class
for loading XML files
* osinfo/osinfo_dataread.c: Delete old loader
* osinfo/libosinfo.syms, osinfo/osinfo.h,
osinfo/Makefile.am: New loader class
* test/Makefile.am, test/osinfo.suppression,
test/test-db.c, test/test-loader.c: Update to
use new loader class
Make OsinfoList typecheck the elements for compatibility
To avoid have an OsinfoList with a mixture of hypervisor,
os and device objects, associate an explicit type with
each list. The list will validate the data type matches
whenever adding elements to the list, or producing new
lists via union/intersect/filter operations.
* osinfo/osinfo_list.c, osinfo/osinfo_list.h: Add an
element-type property
* osinfo/osinfo_devicelist.c, osinfo/osinfo_hypervisorlist.c,
osinfo/osinfo_oslist.c: Set the element-type when creating
a new list
Lots of code fixes based on results from testsuite
This fixes numerous memory leaks throughout the code
identified by valgrind. It also fixes the const-ness
of many parameters
* osinfo/osinfo_dataread.c: Rewrite from scratch using DOM
APIs instead of streaming APIs
* osinfo/osinfo_db.h, osinfo/osinfo_db.c: Remove 'libvirtVer' property
and declare all gchar * parameters to be const. Fix some mem leaks
* osinfo/osinfo_entity.c, osinfo/osinfo_entity.h: Remove some
unnecessary strdup()s and fix some mem leaks
* osinfo/osinfo_filter.c: Fix mem leaks
* osinfo/osinfo_hypervisor.c, osinfo/osinfo_os.c: Allow some
object parameters to be NULL. Fix some mem leaks
* osinfo/osinfo_list.c: Fix some mem leaks
* osinfo/osinfo_osfilter.c: Fix some mem leaks
Comprehensive test suite
This adds a comprehensive test suite. Each test case
fulls covers a single class. Combined, they provide
100% function and 99% line coverage. All important
code branches are also covered.
* Makefile.am: Target to generate code coverage reports
* osinfo/Makefile.am: Add code coverage flags
* configure.ac: Enable use of 'check' for test suite
and use of gcc coverage flags
* test/test-*.c: One test suite per class
* test/test-skeleton.c: Remove obsoleted test
* test/osinfo.suppression: supress valgrind warning for
static data in glib type system
* test/Makefile.am: Link tests against libcheck library
2010-08-26 Daniel P. Berrange <berrange@redhat.com>
Add missing AC_ARG_ENABLE declaration
The configure.ac script was missing the AC_ARG_ENABLE declaration
for the gobject introspection code
* configure.ac: Add AC_ARG_ENABLE
2010-08-25 Daniel P. Berrange <berrange@redhat.com>
Add LGPLv2+ header to all source files
* osinfo/*.h, osinfo/*.c: Add license header text
* COPYING.LIB: LGPLv2+ license
* libosinfo.spec.in, mingw32-libosinfo.spec.in,
Makefile.am: Use COPYING.LIB instead of COPYING
Add formal RPM build infrastructure
* autogen.sh: Rewrite to use gnome-autogen.sh
* autobuild.sh: Automated RPM build control script
* configure.ac: Generate RPM specfiles
* Makefile.am: Distribute RPM specfile templates
* libosinfo.spec.in, mingw32-libosinfo.spec.in: RPM specs
* osinfo/Makefile.am, osinfo/libosinfo.syms: Fix Win32
portability problem
Fix Win32 portability problem in XML reader
stpcpy is a non-standard extension and can be replaced with
g_strdup_printf resulting in much clearer code. The d_type
entry doesn't exist in readdir() for most platforms.
* osinfo/osinfo_dataread.c: Fix Win32 portability
Add support for GObject introspection
Introspect the libosinfo API so that non-C language bindings
can be automagically generated
* osinfo/osinfo.h, osinfo/osinfo_dataread.c, osinfo/osinfo_db.h,
osinfo/osinfo_device.h, osinfo/osinfo_devicelist.h,
osinfo/osinfo_entity.h, osinfo/osinfo_filter.h,
osinfo/osinfo_hypervisor.h, osinfo/osinfo_hypervisorlist.h,
osinfo/osinfo_os.h, osinfo/osinfo_oslist.h: Add explicit
includes to match build dependancies, to satisfy g-ir-scanner
limitations. Rename enum values to allow them to be extracted
with correct names
Add a pkg-config data file for building apps
* configure.ac: Generate libosinfo.pc
* osinfo/Makefile.am: Install pkg-config file
* osinfo/libosinfo-1.0.pc.in: Master pkg-config template
Use pkg-config for checking for libxml
Rather than creating huge amounts of m4 logic, just use pkg-config
to check for libxml2 library. Make libxml2 compulsory
* configure.ac: Simplify libxml2 check
Add proper ELF versioning
Rename library to libosinfo-1.0.la to allow parallel install if
we need to break ABI in the future. Add per-symbol version tagging
to allow fine grained automatic RPM dependancies. Make version
script portable to Win32
* configure.ac: Detect args for linker symbol file / format
* osinfo/Makefile.am: Rename library and use symbol versioning
* osinfo/libosinfo.syms: Symbol version script
Run configure at end of autogen.sh
It is usual practice to run configure at the end of
autogen.sh to save having to manually run it afterwards
* autogen.sh: Run configure
Pull OS relationship filtering into a subclass
The base filter object should only be concerned with
filtering OsinfoEntity objects. Filtering OsinfoOs
objects should be done by a sub-class.
* osinfo/osinfo_filter.c, osinfo/osinfo_filter.h: Remove
OS relationship filtering
* osinfo/osinfo_osfilter.c, osinfo/osinfo_osfilter.h:
New object to handle OS relationship filtering
* osinfo/osinfo_entity.h, osinfo/osinfo_hypervisor.h,
osinfo/osinfo_os.h: Tweak some typedefs to santize
build ordering constraints
* osinfo/osinfo.h: Re-arrange include ordering to
match declaration usage
Move filter matching code out of entity into filter object
To eliminate a circular dependency, move the filter matching
code out of the OsinfoEntity object and into OsinfoFilter
object.
* osinfo/osinfo_entity.c, osinfo/osinfo_entity.h,
osinfo/osinfo_filter.c, osinfo/osinfo_filter.h,
osinfo/osinfo_hypervisor.c, osinfo/osinfo_list.c,
osinfo/osinfo_os.c: Move filter matching code into
the OsinfoFilter object APIs
Fix filter class/object inheritance & add constructor
The OsinfoFilter structs mistakenly included the OsinfoEntity
structs, even though the type inherits direct from GObject.
* osinfo/osinfo_filter.c, osinfo/osinfo_filter.h: Fix
struct parent, and add an explicit constructor
Remove osinfo common module
Finally all objects are fully private and the common
code module can be banished.
* osinfo/osinfo_common.c, osinfo/osinfo_common.h: Delete
* osinfo/Makefile.am, osinfo/osinfo.h: Remove osinfo_common.h
* configure.ac: Use osinfo/osinfo_db.c in CONFIG_SRCDIR
* osinfo/osinfo_dataread.c, osinfo/osinfo_db.c,
osinfo/osinfo_db.h, osinfo/osinfo_device.h,
osinfo/osinfo_devicelist.h, osinfo/osinfo_entity.c,
osinfo/osinfo_entity.h, osinfo/osinfo_filter.c,
osinfo/osinfo_hypervisor.h, osinfo/osinfo_hypervisorlist.h,
osinfo/osinfo_list.h, osinfo/osinfo_os.c,
osinfo/osinfo_os.h, osinfo/osinfo_oslist.h: Add the
main object typedefs, previously in the common module.
Rename osinfoRelationship to OsinfoOsRelationship.
Convert filter constraints from GTree to GHashTable
Simply code and follow more normal GLib practice by
using a GHashTable of GLists for filter property
storage, instead of a GTree of GPtrArrays
* osinfo/osinfo_filter.c, osinfo/osinfo_filter.h:
Convert to use a GHashTable of GLists for filter
properties
* osinfo/osinfo_common.c, osinfo/osinfo_common.h:
Remove unused int/string comparators
* osinfo/osinfo_dataread.c: Remove unused variable
Remove all remaining Hypervisor/Os structs out of common code
Make OsinfoOsPrivate, OsinfoHypervisorPrivate structs private
to their respective objects, and update all code which poked
at private data to use formal APIs
* osinfo/osinfo_common.h, osinfo/osinfo_common.c: Remove the
OsinfoOsPrivate, OsinfoHypervisorPrivate structs and
related helper methods
* osinfo/osinfo_os.c: Add OsinfoOsPrivate struct & helper
methods
* osinfo/osinfo_hypervisor.c: Add OsinfoHypervisorPrivate
struct & helper methods.
* osinfo/osinfo_db.c, osinfo/osinfo_entity.c,
osinfo/osinfo_filter.c: Convert to use APIs instead of
accessing private data of OS/Hypervisor objects.
Make entity object fully private
Make the OsinfoEntityPrivate struct fully private to
the OsinfoEntity object.
* osinfo/osinfo_common.h: Remove OsinfoEntityPrivate
* osinfo/osinfo_entity.c: Add OsinfoEntityPrivate
* osinfo/osinfo_list.c: Use API instead of direct
access to private data of OsinfoEntity objects
Convert entity property data into a GHashTable of GLists
Simply code and follow more normal GLib practice by
using a GHashTable of GLists for entity property
storage, instead of a GTree of GPtrArrays
* osinfo/osinfo_common.h, osinfo/osinfo_dataread.c,
osinfo/osinfo_entity.c, osinfo/osinfo_entity.h: Convert
to use a GHashTable of GLists for properties
Turn OS relationships into a GList structure
Simplify storage of OS relationships by using a single GList
instead of a pair of GTree objects. The data access patterns
mean there is no change in access efficiency
* osinfo/osinfo_common.h, osinfo/osinfo_dataread.c,
osinfo/osinfo_db.c, osinfo/osinfo_entity.c,
osinfo/osinfo_os.c, osinfo/osinfo_os.h: Replace
GTree with GList for OS relationships.
Remove sections from OS device list
Arranging devices in sections against operating systems duplicates
information already available via the 'class' attribute on
the device object. Removing this unneccessary data simplifies
the code, allowing a pair of GTree maps to be replaced by
a single GList.
* data/libosinfo-dummy-data.xml: Remove os sections
* osinfo/osinfo_common.h, osinfo/osinfo_dataread.c,
osinfo/osinfo_os.c, osinfo/osinfo_os.h: Model
hypervisor devices in a GList instead of pair of GTrees
* osinfo/osinfo_device.c, osinfo/osinfo_device.h,
osinfo/osinfo_hypervisor.c: Update for API changes
Remove sections from hypervisor device list
Arranging devices in sections against hypervisors duplicates
information already available via the 'class' attribute on
the device object. Removing this unneccessary data simplifies
the code, allowing a pair of GTree maps to be replaced by
a single GList.
* data/libosinfo-dummy-data.xml: Remove hypervisor sections
* osinfo/osinfo_common.h, osinfo/osinfo_dataread.c,
osinfo/osinfo_hypervisor.c, osinfo/osinfo_hypervisor.h: Model
hypervisor devices in a GList instead of pair of GTrees
Pass a GError all the way through the XML parser
When reading the XML files, a GError should be passed
all the way into the parser functions to enable more
useful error reporting
* osinfo/osinfo_dataread.c: Pass GError down into
all XML parser APIs
* osinfo/osinfo_db.c, osinfo/osinfo_db.h: Remove
return value, since this can be detected from
the GError status
* test/test-skeleton.c: Pass in a GError & report
on failures
Convert OS hypervisor sections from GTree to GHashTable
Remove another GTree data structure in favour of GHashTable
for simpler, more efficient code
* osinfo/osinfo_common.h: Change OsinfoOsPrivate struct
to use a GHashTable
* osinfo/osinfo_common.c, osinfo/osinfo_dataread.c,
osinfo/osinfo_device.c, osinfo/osinfo_os.c: Update to
use hash table APIs
Remove 2 unused struct definitions
The __osinfoPopulateListArgs and __osinfoFilterPassArgs structs
are not used anymore.
* osinfo/osinfo_common.h: Remove unused structs
Remove unused FREE_N macro
The FREE_N macro is not used anywhere
* osinfo/osinfo_common.h: Remove FREE_N
Fix reference count handling in device list
When adding an OsinfoEntity to an OsinfoList, an explicit
reference should be taken on the entity, rather than
relying on the caller to have done it.
* osinfo/osinfo_list.c: Take an extra reference when
adding an entity to the list
* osinfo/osinfo_dataread.c: Release a reference
after adding an entity to the list
Turn filter matching functions into formal APIs
Instead of having the osinfo_common.c module poking into
the private parts of OsinfoFilter and OsinfoEntity
objects, move the code into OsinfoEntity and use formal
APIs for all data access
* osinfo/osinfo_filter.c, osinfo/osinfo_filter.h,
osinfo/osinfo_entity.c, osinfo/osinfo_entity.h: Add
API for matching entities against filters
* osinfo/osinfo_common.c, osinfo/osinfo_common.h: Remove
all entity filtering code.
* osinfo/osinfo_device.c, osinfo/osinfo_hypervisor.c,
osinfo/osinfo_list.c, osinfo/osinfo_os.c: Update to
use formal entity filtering APIs
Replace some temporary GTree objects with GHashTable
Using a GHashTable + GList combination instead of GTree
and GPtrArray results in shorter, simpler code and is
more inline with normal GLib practice.
* osinfo/osinfo_common.h, osinfo/osinfo_db.c,
osinfo/osinfo_db.h, osinfo/osinfo_list.c: Replace
several GTree objects with GHashTable
Remove unused error strings
Since most of the GError code was remove, the method
__osinfoErrorToString is now unused, as are all the
error strings. Remove them all
* osinfo/osinfo_common.c, osinfo/osinfo_common.h: Remove
__osinfoErrorToString and all strings
Make device object struct fully private
Classes should not expose their private bits to each other. Make
the OsinfoDevice private struct truely private.
* osinfo/osinfo_common.h: Remove OsinfoDevicePrivate
* osinfo/osinfo_device.c: Add OsinfoDevicePrivate
* osinfo/osinfo_devicelist.c, osinfo/osinfo_hypervisorlist.c,
osinfo/osinfo_oslist.c: Change 'int tmp' to 'gboolean unsed'
Make osinfo DB struct private & change to use a OsinfoList internally
Classes should expose their private bits to each other. Make
the OsinfoDb private struct truely private. Switch from using
a GTree in OsinfoDb over to a OsinfoList to simplify the code.
* osinfo/osinfo_db.c, osinfo/osinfo_db.h: Add private data
struct & convert from OsinfoList instead of GTree
* osinfo/osinfo_common.h: Remove OsinfoDbPrivate
* osinfo/osinfo_dataread.c, osinfo/osinfo_devicelist.h,
osinfo/osinfo_hypervisorlist.h, osinfo/osinfo_oslist.h: Update
for API changes
* osinfo/osinfo_list.c, osinfo/osinfo_list.h: Add API
for iterating over elements & finding an entity based
on its id.
Add constructors for all objects. Remove constructor for abstract list object
While using g_object_new() is functionally fine, it is not
type-safe/checked. It should generally only be used by
bindings for non-C language. Add explicit constructors for
every object and update all callers of g_object_new to use
the new constructors.
* osinfo/osinfo.h, osinfo/osinfo_dataread.c,
osinfo/osinfo_db.c, osinfo/osinfo_db.h,
osinfo/osinfo_device.c, osinfo/osinfo_device.h,
osinfo/osinfo_devicelist.c, osinfo/osinfo_devicelist.h,
osinfo/osinfo_hypervisor.c, osinfo/osinfo_hypervisor.h,
osinfo/osinfo_hypervisorlist.c, osinfo/osinfo_hypervisorlist.h,
osinfo/osinfo_list.c, osinfo/osinfo_list.h,
osinfo/osinfo_os.c, osinfo/osinfo_os.h,
osinfo/osinfo_oslist.c, osinfo/osinfo_oslist.h: Add
constructors for all objects & use them
Remove 'db' property from entity object to avoid circular reference
The OsinfoDb object holds a reference to every OsinfoEntity.
If the OsinfoEntity also holds a back-reference to OsinfoDb
then no memory will ever be freed. The back-reference is
not used in the code, so just remove it
* osinfo/osinfo_common.h, osinfo/osinfo_dataread.c,
osinfo/osinfo_entity.c: Remove back-reference to the
OsinfoDb object from OsinfoEntity
Remove GError from most APIs
GLib documents that GError should only be used for recoverable
runtime errors, not programmer errors. The latter should use
g_return_val_if_fail / g_return_if_fail macros to display the
programmer error
* osinfo/osinfo_common.c, osinfo/osinfo_common.h,
osinfo/osinfo_db.c, osinfo/osinfo_db.h,
osinfo/osinfo_device.c, osinfo/osinfo_device.h,
osinfo/osinfo_entity.c, osinfo/osinfo_entity.h,
osinfo/osinfo_filter.c, osinfo/osinfo_filter.h,
osinfo/osinfo_hypervisor.c, osinfo/osinfo_hypervisor.h,
osinfo/osinfo_os.c, osinfo/osinfo_os.h: Remove GError
from most public APIs
Remove unused error variables from more iterators
The iterators used in the OsinfoDb class pass around an GError
object but none of the codepaths can ever fail, since all the
ENOMEM code was remove. The GError variable is thus redundant
* osinfo/osinfo_common.h, osinfo/osinfo_db.c: Remove GError
from the iterators
Remove many duplicate methods from device, hv & os list classes
The OsinfoDeviceList, OsinfoHypervisorList and OsinfoOsList
classes don't need to provide accessors for list elements,
since those are all available via the superclass OsinfoList.
Re-work list intersection, union & filter APIs so that
they add to the current list. Add constructors that
allow creation of new lists with intersections, unions
and filtering.
* osinfo/osinfo_devicelist.c, osinfo/osinfo_devicelist.h,
osinfo/osinfo_hypervisorlist.c, osinfo/osinfo_hypervisorlist.h,
osinfo/osinfo_oslist.c, osinfo/osinfo_oslist.h: Remove all
list element accessors
* osinfo/osinfo_list.c, osinfo/osinfo_list.h: Add constructors
for union, filter & intersection operations.
Remove unused error variable from db populate list iterator
The GError object passed around when getting lists of OS,
or Hypervisor objects from the DB, is never actually set,
nor can failure ever occur in any of the codepaths.
Since it is unused, it can be removed completely.
* osinfo/osinfo_common.h: Remove errcode & err from
struct __osinfoPopulateListArgs.
* osinfo/osinfo_db.c: Don't pass around GError object
when populating entity lists
Make osinfo_list_add into a public API
Make osinfo_list_add a public API on OsinfoList since
apps should be allowed to manipulate objects at will
if they're not using the XML loader. This also avoids
compile warnings from other objects using this API
without it being declared
* osinfo/osinfo_list.h, osinfo/osinfo_list.c: Make
osinfo_list_add a public API
* osinfo/osinfo_db.c, osinfo/osinfo_filter.c,
osinfo/osinfo_hypervisor.c, osinfo/osinfo_os.c: Update
for changing API name
Remove all bad signed/unsigned casts in XML handling
libxml2 strings are all 'unsigned char*' but C world normally
uses 'char *', or 'gchar *' in GLib. Add appropriate casts
and change variable types to avoid compiler warnings about
implicit signed/unsigned casts.
* osinfo/osinfo_dataread.c: Fix compile warnings about
signed/unsigned string casts
Remove more malloc failure checks
GLib will always abort() upon malloc failure, so there is
no need to check return value of any g_object_new, g_new
or g_strdup API call. Remove all this redundant ENOMEM
checking
* osinfo/osinfo_common.c, osinfo/osinfo_dataread.c,
osinfo/osinfo_db.c, osinfo/osinfo_devicelist.c,
osinfo/osinfo_entity.c, osinfo/osinfo_filter.c,
osinfo/osinfo_hypervisor.c, osinfo/osinfo_hypervisorlist.c,
osinfo/osinfo_list.c, osinfo/osinfo_os.c,
osinfo/osinfo_oslist.c: Remove all ENOMEM checks
Sanitize naming of filter object APIs
The GObject naming conversion is lowercase, separated
by underscores. This needs to be followed to allow
gobject introspection to be auto-generated easily.
* osinfo/osinfo_filter.c, osinfo/osinfo_filter.h: Convert
API naming to use lowercase + underscores. Add an
explicit constructor.
Sanitize naming of all list object APIs
The GObject naming conversion is lowercase, separated
by underscores. This needs to be followed to allow
gobject introspection to be auto-generated easily.
* osinfo/osinfo_devicelist.c, osinfo/osinfo_devicelist.h,
osinfo/osinfo_hypervisorlist.c, osinfo/osinfo_hypervisorlist.h,
osinfo/osinfo_list.c, osinfo/osinfo_list.h: Convert
API naming to use lowercase + underscores. Add
explicit constructors.
* osinfo/osinfo_db.c, osinfo/osinfo_filter.c,
osinfo/osinfo_hypervisor.c, osinfo/osinfo_os.c: Update
for changing API naming
Santize naming of device, hypervisor and os object APIs
The GObject naming conversion is lowercase, separated
by underscores. This needs to be followed to allow
gobject introspection to be auto-generated easily.
* osinfo/osinfo_device.c, osinfo/osinfo_device.h,
osinfo/osinfo_hypervisor.c, osinfo/osinfo_hypervisor.h,
osinfo/osinfo_os.c, osinfo/osinfo_os.h: Convert
API naming to use lowercase + underscores. Add
explicit constructors.
Sanitize API naming for OsinfoEntity class
The GObject naming conversion is lowercase, separated
by underscores. This needs to be followed to allow
gobject introspection to be auto-generated easily.
* osinfo/osinfo_common.h: Remove declaration of
methods that belong in osinfo_entity.h
* osinfo/osinfo_entity.c, osinfo/osinfo_entity.h: Convert
API naming to use lowercase + underscores. Add an
explicit constructor.
* osinfo/osinfo_filter.c, osinfo/osinfo_hypervisor.c: Update
for changed API names
Sanitize API naming for OsinfoDb class
The GObject naming conversion is lowercase, separated
by underscores. This needs to be followed to allow
gobject introspection to be auto-generated easily.
* osinfo/Makefile.am: Add -Wl,-no-undefined to ensure
any undefined symbols are caught
* osinfo/osinfo_common.h: Remove declaration of
methods that belong in osinfo_db.h
* osinfo/osinfo_db.c, osinfo/osinfo_db.h: Convert
API naming to use lowercase + underscores. Add an
explicit constructor.
* test/test-skeleton.c: Fix for changed API naming
and use OsinfoDb constructor
Remove all redundant malloc failure checks
GLib will always abort() upon malloc failure, so there is
no need to check return value of any g_object_new, g_new
or g_strdup API call. Remove all this redundant ENOMEM
checking
* osinfo/osinfo_common.c, osinfo/osinfo_db.c,
osinfo/osinfo_device.c, osinfo/osinfo_entity.c,
osinfo/osinfo_filter.c, osinfo/osinfo_os.c: Remove
all ENOMEM checking
Add decl for all _get_type() methods & enable warnings
Eliminate compile warnings about undeclared XXX_get_type()
methods, by adding declarations for all objects.
Switch to using standard GNOME m4 magic for compile
warnings. Force enablement of automake maintainer
mode, so that Makefile is re-generated if Makefile.am
ever changes. Enable silent build rules so that compile
warnings can be more easily spotted.
* Makefile.am: Whitespace tweak
* configure.ac: Remove -Wall, -Werror. Add
GNOME_COMPILE_WARNINGS, GNOME_MAINTAINER_MODE_DEFINES,
AM_MAINTAINER_MODE, AM_SILENT_RULES
* osinfo/*.h: Add XXX_get_type() declarations for all
objects
* osinfo/Makefile.am: Add $(WARN_CFLAGS) to build
Move Makefile.am into each sub-dir
Move Makefile.am into each sub-dir so that built objects end
up in the same directory as the sources, instead of polluting
the top level. This will also enable the gobject introspection
makefile rules to be imported later
* .gitignore: test-skeleton & test-skeleton.sh
* Makefile.am: Remove all build rules, add SUBDIRS
* osinfo/Makefile.am: Add build rules for library
* test/Makefile.am: Add build rules for tests
* test/test-skeleton.c: Update to reflect changed
current directory during test execution
Move all source & headers into osinfo/ directory
The GLib/GObject standard practice is to have all source and
header files in the same directory, named after the library
prefix. Move all headers from api/ and inc/ into src/, then
rename src/ to osinfo/
* src/*, api/*, inc/*: Move to osinfo/
* Makefile.am: Update build rules for changed locations
* configure.ac: change AC_CONFIG_SRCDIR
2010-07-01 Arjun Roy <arroy@redhat.com>
Moved over API to use glib/gobject. API definitions have changed, though functionality remains identical. Added new features to list classes.
TODO: Extensive testing. Codebase compiles and simplest test of
creating/destroying DB works, but more is required.
2010-02-03 Arjun Roy <arroy@redhat.com>
Added autogen.sh
2010-02-03 Jim Meyering <meyering@redhat.com>
avoid legitimate gcc used-before-set warning
* test/test-filter.c (main): Initialize filter buffer before
trying to free it.
fix used-uninitialized bugs
* src/osi_device.c (dev_property_all_values): Initialize "kv" to NULL
to avoid using it uninitialized when there is no match.
* src/osi_hv.c (osi_get_hv_property_all_values): Likewise.
* src/osi_os.c (os_property_all_values): Likewise.
* src/osi_hv.c (osi_get_hv_property_first_value): Likewise.
* src/osi_os.c (osi_get_os_property_first_value): Likewise.
* src/osi_device.c (osi_get_device_property_value): Likewise.
include <string.h> for decl of strcmp, in test programs
remove more declarations of unused variables
avoid FP unused "osname" warning
* test/sample.c (main): Print "osname", so that variable
does not appear to be unused.
tests: fix test-filter failure
* test/test-filter.c (main): Don't reference "filter"
after freeing it: remove the failing assertion.
fix failing tests
remove decls of unused variables
avoid gcc warnings
* src/osi_os.c: Avoid warnings:
declaration of 'index' shadows a global declaration: s/index/idx/
unused variable 'cursor'
unused variable 'i'
* src/osi_device.c (osi_get_device_by_index): s/index/idx/
libraries must not call chdir; avoid getcwd, too
* src/osi_dataread.c: Include <stdlib.h>.
(osi_initialize_data): Don't call chdir. Use ".", rather than getcwd.
Add a directory name parameter.
Construct the dir-relative file name we'll read from.
Adjust sole caller.
autoconfiscate
* Makefile.am: New file.
* configure.ac: New file.
* Makefile: Remove.
* .gitignore: List ignorable files.
2010-01-28 Arjun Roy <arroy@redhat.com>
Updated README.
TODO:
1. Update docs
2. Better error handling and messages for reading XML data
3. More unit tests and more automation for unit tests.
2010-01-26 Arjun Roy <arroy@redhat.com>
Changed tests to accept data dir as a command line parameter.
Initial working codebase.
2009-11-09 Arjun Roy <arroy@redhat.com>
Added a few unit tests to the API for initializing/closing the library and setting hypervisors.
No implementation yet.
Added dummy data for testing purposes.
2009-11-06 Arjun Roy <arroy@redhat.com>
Initial commit with API definition, overview, and sample program.
No implementation at all yet.
