From a4e588e3eacf4e5590ff98171a495f8fa0e37375 Mon Sep 17 00:00:00 2001 Message-Id: <a4e588e3eacf4e5590ff98171a495f8fa0e37375.1355522395.git.crobinso@redhat.com> From: Christophe Fergeau <cfergeau@redhat.com> Date: Mon, 1 Oct 2012 18:22:04 +0200 Subject: [PATCH] Don't free SPICE ticket twice Commit 2201a5a was supposed to free a SPICE ticket leak, but it's actually introducing a double-free as the SPICE ticket is unconditionally freed at the end of virt_viewer_session_spice_main_channel_event --- src/virt-viewer-session-spice.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/virt-viewer-session-spice.c b/src/virt-viewer-session-spice.c index 5fcd7fb..2577f2b 100644 --- a/src/virt-viewer-session-spice.c +++ b/src/virt-viewer-session-spice.c @@ -326,7 +326,6 @@ virt_viewer_session_spice_main_channel_event(SpiceChannel *channel G_GNUC_UNUSED gboolean openfd; g_object_set(self->priv->session, "password", password, NULL); - g_free(password); g_object_get(self->priv->session, "client-sockets", &openfd, NULL); if (openfd) -- 1.8.0.2