Sophie

Sophie

distrib > Fedora > 18 > i386 > by-pkgid > 9714d5357935b99b4b2687ef8a0c7c2d > files > 6

quota-4.00-7.fc18.src.rpm

Fix editting more users with edquota

Back-ported for 4.00 from upstream commit:

From e7cdf879468501b1be6c3ab9add1c9ec056093ab Mon Sep 17 00:00:00 2001
From: Jan Kara <jack@suse.cz>
Date: Wed, 23 May 2012 15:29:31 +0200
Subject: [PATCH 1/2] edquota: Fix editting of more users

We reopened temporary file with editted quota limits in O_RDONLY mode after
user has edited the limits. This is problematic when edquota is called to
edit more users because then we cannot write limits for the next user to
the file. So reopen the file O_RDWR mode.


diff --git a/edquota.c b/edquota.c
index ef9fc9b..f433417 100644
--- a/edquota.c
+++ b/edquota.c
@@ -333,7 +333,11 @@ int main(int argc, char **argv)
 				continue;
 			}
 			close(tmpfd);
-			if ((tmpfd = open(tmpfil, O_RDONLY)) < 0)
+			/*
+			 * Open in rw mode because we can reuse the file for
+			 * editting next user as well.
+			 */
+			if ((tmpfd = open(tmpfil, O_RDWR)) < 0)
 				die(1, _("Cannot reopen!"));
 			if (readprivs(curprivs, tmpfd) < 0) {
 				errstr(_("Cannot read quotas from file.\n"));
-- 
1.7.7.6