From 5c8c3123652045191474a4ca85fbb6e8d9e7d2bc Mon Sep 17 00:00:00 2001 From: Roland McGrath <roland@hack.frob.com> Date: Fri, 4 Sep 2015 14:37:56 -0700 Subject: [PATCH 11/65] BZ#18921: Fix opendir inverted o_directory_works test. (cherry picked from commit bd9e69abb887d78d0d6708fc089cc9f3eabf106d) --- ChangeLog | 8 ++++++++ sysdeps/posix/opendir.c | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index d0d2cbd..44809a6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2015-09-04 Roland McGrath <roland@hack.frob.com> + + [BZ #18921] + * sysdeps/posix/opendir.c (need_isdir_precheck) [O_DIRECTORY]: + Fix inverted sense of test of 'o_directory_works' value. + Reported by Pádraig Brady <P@draigBrady.com>, diagnosed by + Bernhard Voelker <mail@bernhard-voelker.de>. + 2015-08-31 Brett Neumeier <brett@neumeier.us> [BZ #18870] diff --git a/sysdeps/posix/opendir.c b/sysdeps/posix/opendir.c index 6509f5c..9edf056 100644 --- a/sysdeps/posix/opendir.c +++ b/sysdeps/posix/opendir.c @@ -105,7 +105,7 @@ need_isdir_precheck (void) tryopen_o_directory (); /* We can skip the expensive `stat' call if O_DIRECTORY works. */ - return o_directory_works > 0; + return o_directory_works < 0; #endif return true; } -- 2.7.4