--- chromium-81.0.4044.43/chrome/services/sharing/public/cpp/sharing_webrtc_metrics.cc.gcc9 2020-03-04 22:52:11.000000000 +0100
+++ chromium-81.0.4044.43/chrome/services/sharing/public/cpp/sharing_webrtc_metrics.cc 2020-03-09 18:51:15.306664210 +0100
@@ -45,6 +45,7 @@ std::string TimingEventToString(sharing:
case sharing::WebRtcTimingEvent::kDestroyed:
return "Destroyed";
}
+ return "";
}
} // namespace
--- chromium-81.0.4044.43/v8/src/torque/implementation-visitor.cc.gcc9 2020-03-09 18:39:40.374301436 +0100
+++ chromium-81.0.4044.43/v8/src/torque/implementation-visitor.cc 2020-03-09 18:59:03.297832839 +0100
@@ -1019,7 +1019,7 @@ const Type* ImplementationVisitor::Visit
#if defined(DEBUG)
do_check = true;
#endif
- Block* resume_block;
+ Block* resume_block = nullptr;
if (!do_check) {
Block* unreachable_block = assembler().NewBlock(assembler().CurrentStack());
--- chromium-81.0.4044.43/services/service_manager/sandbox/linux/sandbox_seccomp_bpf_linux.cc.gcc9 2020-03-04 22:52:19.000000000 +0100
+++ chromium-81.0.4044.43/services/service_manager/sandbox/linux/sandbox_seccomp_bpf_linux.cc 2020-03-09 18:59:58.440910794 +0100
@@ -184,6 +184,7 @@ std::unique_ptr<BPFBasePolicy> SandboxSe
NOTREACHED();
return nullptr;
}
+ return nullptr;
}
// If a BPF policy is engaged for |process_type|, run a few sanity checks.
--- chromium-81.0.4044.43/services/service_manager/sandbox/sandbox_type.cc.gcc9 2020-03-04 22:52:59.000000000 +0100
+++ chromium-81.0.4044.43/services/service_manager/sandbox/sandbox_type.cc 2020-03-09 19:00:43.842151665 +0100
@@ -48,6 +48,7 @@ bool IsUnsandboxedSandboxType(SandboxTyp
case SandboxType::kSoda:
return false;
}
+ return false;
}
void SetCommandLineFlagsForSandboxType(base::CommandLine* command_line,
@@ -192,6 +193,7 @@ std::string StringFromUtilitySandboxType
NOTREACHED();
return std::string();
}
+ return std::string();
}
SandboxType UtilitySandboxTypeFromString(const std::string& sandbox_string) {
--- chromium-81.0.4044.43/third_party/angle/src/libANGLE/renderer/vulkan/ContextVk.cpp.gcc9 2020-03-09 18:39:40.402300967 +0100
+++ chromium-81.0.4044.43/third_party/angle/src/libANGLE/renderer/vulkan/ContextVk.cpp 2020-03-09 19:15:03.377783238 +0100
@@ -2984,7 +2984,7 @@ vk::DynamicQueryPool *ContextVk::getQuer
queryType == gl::QueryType::Timestamp || queryType == gl::QueryType::TimeElapsed);
// Assert that timestamp extension is available if needed.
- ASSERT(queryType != gl::QueryType::Timestamp && queryType != gl::QueryType::TimeElapsed ||
+ ASSERT(((queryType != gl::QueryType::Timestamp) && (queryType != gl::QueryType::TimeElapsed)) ||
mRenderer->getQueueFamilyProperties().timestampValidBits > 0);
ASSERT(mQueryPools[queryType].isValid());
return &mQueryPools[queryType];
--- chromium-81.0.4044.43/third_party/angle/src/libANGLE/renderer/vulkan/vk_cache_utils.cpp.gcc9 2020-03-09 18:39:40.384301268 +0100
+++ chromium-81.0.4044.43/third_party/angle/src/libANGLE/renderer/vulkan/vk_cache_utils.cpp 2020-03-09 19:23:20.074519726 +0100
@@ -847,11 +847,8 @@ angle::Result GraphicsPipelineDesc::init
*pNextPtr = &provokingVertexState;
pNextPtr = &provokingVertexState.pNext;
}
- VkPipelineRasterizationStateStreamCreateInfoEXT rasterStreamState = {};
- rasterStreamState.sType = VK_STRUCTURE_TYPE_PIPELINE_RASTERIZATION_STATE_STREAM_CREATE_INFO_EXT;
if (contextVk->getFeatures().supportsTransformFeedbackExtension.enabled)
{
- rasterStreamState.rasterizationStream = 0;
rasterState.pNext = &rasterLineState;
}
--- chromium-81.0.4044.43/third_party/webrtc/call/adaptation/resource.cc.gcc9 2020-03-04 22:54:30.000000000 +0100
+++ chromium-81.0.4044.43/third_party/webrtc/call/adaptation/resource.cc 2020-03-09 20:01:27.782467544 +0100
@@ -25,6 +25,7 @@ const char* ResourceUsageStateToString(R
case ResourceUsageState::kUnderuse:
return "underuse";
}
+ return "";
}
} // namespace
--- chromium-81.0.4044.43/third_party/webrtc/modules/rtp_rtcp/source/create_video_rtp_depacketizer.cc.gcc9 2020-03-04 22:54:30.000000000 +0100
+++ chromium-81.0.4044.43/third_party/webrtc/modules/rtp_rtcp/source/create_video_rtp_depacketizer.cc 2020-03-09 20:05:06.544832420 +0100
@@ -37,6 +37,7 @@ std::unique_ptr<VideoRtpDepacketizer> Cr
case kVideoCodecMultiplex:
return std::make_unique<VideoRtpDepacketizerGeneric>();
}
+ return std::make_unique<VideoRtpDepacketizerGeneric>();
}
} // namespace webrtc
--- chromium-81.0.4044.43/components/feed/core/common/refresh_throttler.cc.gcc9 2020-03-04 22:52:13.000000000 +0100
+++ chromium-81.0.4044.43/components/feed/core/common/refresh_throttler.cc 2020-03-09 20:33:49.236198263 +0100
@@ -43,6 +43,7 @@ std::pair<std::string, int> GetThrottler
case UserClass::kActiveSuggestionsConsumer:
return {"SuggestionFetcherActiveSuggestionsConsumer", 20};
}
+ return {"", 0};
}
} // namespace
--- chromium-81.0.4044.43/components/feed/core/common/user_classifier.cc.gcc9 2020-03-04 22:52:13.000000000 +0100
+++ chromium-81.0.4044.43/components/feed/core/common/user_classifier.cc 2020-03-09 20:35:43.164300556 +0100
@@ -68,6 +68,7 @@ const char* GetRateKey(UserClassifier::E
case UserClassifier::Event::kSuggestionsUsed:
return prefs::kUserClassifierAverageSuggestionsUsedPerHour;
}
+ return "";
}
const char* GetLastTimeKey(UserClassifier::Event event) {
@@ -77,6 +78,7 @@ const char* GetLastTimeKey(UserClassifie
case UserClassifier::Event::kSuggestionsUsed:
return prefs::kUserClassifierLastTimeToUseSuggestions;
}
+ return "";
}
double GetInitialHoursBetweenEvents(UserClassifier::Event event) {
@@ -86,6 +88,7 @@ double GetInitialHoursBetweenEvents(User
case UserClassifier::Event::kSuggestionsUsed:
return 120;
}
+ return 0.;
}
// Returns the new value of the rate using its |old_value|, assuming
--- chromium-81.0.4044.43/components/openscreen_platform/logging.cc.gcc9 2020-03-04 22:52:13.000000000 +0100
+++ chromium-81.0.4044.43/components/openscreen_platform/logging.cc 2020-03-09 20:48:41.430328956 +0100
@@ -28,6 +28,7 @@ namespace {
case LogLevel::kFatal:
return ::logging::LOG_FATAL;
}
+ return ::logging::LOG_VERBOSE;
}
} // namespace
--- chromium-81.0.4044.43/net/dns/resolve_context.cc.gcc9 2020-03-04 22:52:59.000000000 +0100
+++ chromium-81.0.4044.43/net/dns/resolve_context.cc 2020-03-09 21:02:21.570646828 +0100
@@ -110,7 +110,7 @@ void ResolveContext::SetProbeSuccess(siz
// TODO(crbug.com/1022059): Consider figuring out some way to only for the
// first context enabling DoH or the last context disabling DoH.
- if (doh_available_before != NumAvailableDohServers(session) > 0)
+ if (doh_available_before != (NumAvailableDohServers(session) > 0))
NetworkChangeNotifier::TriggerNonSystemDnsChange();
}
--- chromium-81.0.4044.43/cc/animation/scroll_offset_animation_curve.cc.gcc9 2020-03-04 22:52:54.000000000 +0100
+++ chromium-81.0.4044.43/cc/animation/scroll_offset_animation_curve.cc 2020-03-09 21:14:49.760168453 +0100
@@ -233,6 +233,7 @@ base::TimeDelta ScrollOffsetAnimationCur
case AnimationType::kImpulse:
return ImpulseSegmentDuration(delta, delayed_by);
}
+ return base::TimeDelta();
}
// static
--- chromium-81.0.4044.43/media/base/audio_codecs.cc.gcc9 2020-03-09 18:39:32.954425743 +0100
+++ chromium-81.0.4044.43/media/base/audio_codecs.cc 2020-03-09 21:17:56.622052394 +0100
@@ -55,6 +55,7 @@ std::string GetCodecName(AudioCodec code
case kCodecWMA2:
return "wma2";
}
+ return "";
}
std::string GetProfileName(AudioCodecProfile profile) {
@@ -64,6 +65,7 @@ std::string GetProfileName(AudioCodecPro
case AudioCodecProfile::kXHE_AAC:
return "xhe-aac";
}
+ return "";
}
AudioCodec StringToAudioCodec(const std::string& codec_id) {
--- chromium-81.0.4044.43/components/viz/common/quads/render_pass_io.cc.gcc9 2020-03-04 22:52:58.000000000 +0100
+++ chromium-81.0.4044.43/components/viz/common/quads/render_pass_io.cc 2020-03-09 21:21:01.748962321 +0100
@@ -586,6 +586,7 @@ const char* ColorSpacePrimaryIdToString(
MATCH_ENUM_CASE(PrimaryID, WIDE_GAMUT_COLOR_SPIN)
MATCH_ENUM_CASE(PrimaryID, CUSTOM)
}
+ return "";
}
const char* ColorSpaceTransferIdToString(gfx::ColorSpace::TransferID id) {
@@ -616,6 +617,7 @@ const char* ColorSpaceTransferIdToString
MATCH_ENUM_CASE(TransferID, CUSTOM_HDR)
MATCH_ENUM_CASE(TransferID, PIECEWISE_HDR)
}
+ return "";
}
const char* ColorSpaceMatrixIdToString(gfx::ColorSpace::MatrixID id) {
@@ -633,6 +635,7 @@ const char* ColorSpaceMatrixIdToString(g
MATCH_ENUM_CASE(MatrixID, YDZDX)
MATCH_ENUM_CASE(MatrixID, GBR)
}
+ return "";
}
const char* ColorSpaceRangeIdToString(gfx::ColorSpace::RangeID id) {
@@ -642,6 +645,7 @@ const char* ColorSpaceRangeIdToString(gf
MATCH_ENUM_CASE(RangeID, FULL)
MATCH_ENUM_CASE(RangeID, DERIVED)
}
+ return "";
}
#undef MATCH_ENUM_CASE
--- chromium-81.0.4044.43/gpu/config/gpu_info_collector.cc.gcc9 2020-03-04 22:52:16.000000000 +0100
+++ chromium-81.0.4044.43/gpu/config/gpu_info_collector.cc 2020-03-09 21:26:04.553901190 +0100
@@ -427,7 +427,7 @@ bool CollectGpuExtraInfo(GpuExtraInfo* g
#if defined(USE_X11)
// Create the GLVisualPickerGLX singleton now while the GbmSupportX11
// singleton is busy being created on another thread.
- gl::GLVisualPickerGLX* visual_picker;
+ gl::GLVisualPickerGLX* visual_picker = nullptr;
if (gl::GetGLImplementation() == gl::kGLImplementationDesktopGL)
visual_picker = gl::GLVisualPickerGLX::GetInstance();
--- chromium-81.0.4044.43/media/base/media_serializers.h.gcc9 2020-03-04 22:52:59.000000000 +0100
+++ chromium-81.0.4044.43/media/base/media_serializers.h 2020-03-09 21:31:53.823064450 +0100
@@ -317,6 +317,7 @@ struct MediaSerializer<media::BufferingS
case BUFFERING_CHANGE_REASON_UNKNOWN:
return base::Value("BUFFERING_CHANGE_REASON_UNKNOWN");
}
+ return base::Value();
}
};
--- chromium-81.0.4044.43/base/optional.h.gcc9 2020-03-04 22:52:54.000000000 +0100
+++ chromium-81.0.4044.43/base/optional.h 2020-03-09 22:17:26.085324956 +0100
@@ -239,7 +239,7 @@ class OptionalBase {
return *this;
}
- OptionalBase& operator=(OptionalBase&& other) noexcept(
+ constexpr OptionalBase& operator=(OptionalBase&& other) noexcept(
std::is_nothrow_move_assignable<T>::value&&
std::is_nothrow_move_constructible<T>::value) {
MoveAssign(std::move(other));
--- chromium-81.0.4044.43/ui/accessibility/ax_position.h.gcc9 2020-03-09 18:39:43.583247676 +0100
+++ chromium-81.0.4044.43/ui/accessibility/ax_position.h 2020-03-09 23:45:23.866329758 +0100
@@ -362,6 +362,7 @@ class AXPosition {
return AsLeafTreePosition()->IsIgnored();
return false;
}
+ return false;
}
bool IsNullPosition() const {
@@ -3347,6 +3348,7 @@ class AXPosition {
case AXTextBoundaryDirection::kBackwards:
return AXPositionAdjustmentBehavior::kMoveBackwards;
}
+ return AXPositionAdjustmentBehavior::kMoveForwards;
}
static std::vector<int32_t> GetWordStartOffsetsFunc(
@@ -3455,6 +3457,7 @@ class AXPosition {
}
break;
}
+ return text_position;
}
// Returns the next leaf text position in the specified direction ensuring
--- chromium-81.0.4044.43/ui/accessibility/ax_node_data.cc.gcc9 2020-03-04 22:53:02.000000000 +0100
+++ chromium-81.0.4044.43/ui/accessibility/ax_node_data.cc 2020-03-09 23:47:14.170472810 +0100
@@ -929,6 +929,7 @@ bool AXNodeData::IsReadOnlyOrDisabled()
!IsReadOnlySupported(role);
}
}
+ return false;
}
bool AXNodeData::IsRangeValueSupported() const {
--- chromium-81.0.4044.43/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc.gcc9 2020-03-04 22:53:03.000000000 +0100
+++ chromium-81.0.4044.43/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc 2020-03-10 00:04:47.453748884 +0100
@@ -343,7 +343,7 @@ int DesktopDragDropClientAuraX11::Update
DragDropDelegate* delegate = nullptr;
DragTranslate(screen_point, &data, &drop_target_event, &delegate);
int drag_operation =
- delegate ? drag_operation = delegate->OnDragUpdated(*drop_target_event)
+ delegate ? delegate->OnDragUpdated(*drop_target_event)
: ui::DragDropTypes::DRAG_NONE;
UMA_HISTOGRAM_BOOLEAN("Event.DragDrop.AcceptDragUpdate",
drag_operation != ui::DragDropTypes::DRAG_NONE);
--- chromium-81.0.4044.43/ui/views/layout/normalized_geometry.cc.gcc9 2020-03-04 22:52:40.000000000 +0100
+++ chromium-81.0.4044.43/ui/views/layout/normalized_geometry.cc 2020-03-10 00:11:58.960491644 +0100
@@ -255,6 +255,7 @@ NormalizedPoint Normalize(LayoutOrientat
case LayoutOrientation::kVertical:
return NormalizedPoint(point.y(), point.x());
}
+ return NormalizedPoint();
}
gfx::Point Denormalize(LayoutOrientation orientation,
@@ -265,6 +266,7 @@ gfx::Point Denormalize(LayoutOrientation
case LayoutOrientation::kVertical:
return gfx::Point(point.cross(), point.main());
}
+ return gfx::Point();
}
NormalizedSize Normalize(LayoutOrientation orientation, const gfx::Size& size) {
@@ -274,6 +276,7 @@ NormalizedSize Normalize(LayoutOrientati
case LayoutOrientation::kVertical:
return NormalizedSize(size.height(), size.width());
}
+ return NormalizedSize();
}
gfx::Size Denormalize(LayoutOrientation orientation,
@@ -284,6 +287,7 @@ gfx::Size Denormalize(LayoutOrientation
case LayoutOrientation::kVertical:
return gfx::Size(size.cross(), size.main());
}
+ return gfx::Size();
}
NormalizedSizeBounds Normalize(LayoutOrientation orientation,
@@ -294,6 +298,7 @@ NormalizedSizeBounds Normalize(LayoutOri
case LayoutOrientation::kVertical:
return NormalizedSizeBounds(bounds.height(), bounds.width());
}
+ return NormalizedSizeBounds();
}
SizeBounds Denormalize(LayoutOrientation orientation,
@@ -304,6 +309,7 @@ SizeBounds Denormalize(LayoutOrientation
case LayoutOrientation::kVertical:
return SizeBounds(bounds.cross(), bounds.main());
}
+ return SizeBounds();
}
NormalizedInsets Normalize(LayoutOrientation orientation,
@@ -316,6 +322,7 @@ NormalizedInsets Normalize(LayoutOrienta
return NormalizedInsets(insets.top(), insets.left(), insets.bottom(),
insets.right());
}
+ return NormalizedInsets();
}
gfx::Insets Denormalize(LayoutOrientation orientation,
@@ -328,6 +335,7 @@ gfx::Insets Denormalize(LayoutOrientatio
return gfx::Insets(insets.main_leading(), insets.cross_leading(),
insets.main_trailing(), insets.cross_trailing());
}
+ return gfx::Insets();
}
NormalizedRect Normalize(LayoutOrientation orientation,
@@ -349,6 +357,7 @@ int GetMainAxis(LayoutOrientation orient
case LayoutOrientation::kVertical:
return size.height();
}
+ return 0;
}
int GetCrossAxis(LayoutOrientation orientation, const gfx::Size& size) {
@@ -358,6 +367,7 @@ int GetCrossAxis(LayoutOrientation orien
case LayoutOrientation::kVertical:
return size.width();
}
+ return 0;
}
base::Optional<int> GetMainAxis(LayoutOrientation orientation,
@@ -368,6 +378,7 @@ base::Optional<int> GetMainAxis(LayoutOr
case LayoutOrientation::kVertical:
return size.height();
}
+ return base::Optional<int>();
}
base::Optional<int> GetCrossAxis(LayoutOrientation orientation,
@@ -378,6 +389,7 @@ base::Optional<int> GetCrossAxis(LayoutO
case LayoutOrientation::kVertical:
return size.width();
}
+ return base::Optional<int>();
}
void SetMainAxis(gfx::Size* size, LayoutOrientation orientation, int main) {
--- chromium-81.0.4044.43/ui/views/controls/slider.cc.gcc9 2020-03-04 22:53:03.000000000 +0100
+++ chromium-81.0.4044.43/ui/views/controls/slider.cc 2020-03-10 00:23:08.673255794 +0100
@@ -354,6 +354,7 @@ SkColor Slider::GetThumbColor() const {
return GetNativeTheme()->GetSystemColor(
ui::NativeTheme::kColorId_SliderThumbMinimal);
}
+ return SkColor(0);
}
SkColor Slider::GetTroughColor() const {
@@ -365,6 +366,7 @@ SkColor Slider::GetTroughColor() const {
return GetNativeTheme()->GetSystemColor(
ui::NativeTheme::kColorId_SliderTroughMinimal);
}
+ return SkColor(0);
}
int Slider::GetSliderExtraPadding() const {
@@ -376,6 +378,7 @@ int Slider::GetSliderExtraPadding() cons
case RenderingStyle::kMinimalStyle:
return kSliderPadding;
}
+ return 0;
}
BEGIN_METADATA(Slider)
--- chromium-81.0.4044.43/ui/views/layout/animating_layout_manager.cc.gcc9 2020-03-04 22:53:03.000000000 +0100
+++ chromium-81.0.4044.43/ui/views/layout/animating_layout_manager.cc 2020-03-11 02:13:30.341336085 +0100
@@ -935,7 +935,7 @@ ChildLayout AnimatingLayoutManager::Calc
NormalizedRect new_bounds = fade_info.reference_bounds;
// Determine which layout the sliding view will be completely faded in.
- const ProposedLayout* fully_faded_layout;
+ const ProposedLayout* fully_faded_layout = nullptr;
switch (fade_info.fade_type) {
case LayoutFadeType::kFadingIn:
fully_faded_layout = &starting_layout_;
--- chromium-81.0.4044.43/chrome/browser/sharing/sharing_device_source_sync.cc.gcc9 2020-03-04 22:52:57.000000000 +0100
+++ chromium-81.0.4044.43/chrome/browser/sharing/sharing_device_source_sync.cc 2020-03-11 02:54:30.545256000 +0100
@@ -38,6 +38,7 @@ bool IsDesktop(sync_pb::SyncEnums::Devic
case sync_pb::SyncEnums::DeviceType::SyncEnums_DeviceType_TYPE_OTHER:
return false;
}
+ return false;
}
bool IsStale(const syncer::DeviceInfo& device) {
--- chromium-81.0.4044.43/components/payments/core/payment_app.cc.gcc9 2020-03-04 22:52:13.000000000 +0100
+++ chromium-81.0.4044.43/components/payments/core/payment_app.cc 2020-03-11 03:04:55.137837842 +0100
@@ -40,6 +40,7 @@ int GetSortingGroup(const PaymentApp& ap
return 4;
}
}
+ return 0;
}
} // namespace
--- chromium-81.0.4044.43/chrome/browser/sharing/sharing_message_bridge_impl.cc.gcc9 2020-03-04 22:52:09.000000000 +0100
+++ chromium-81.0.4044.43/chrome/browser/sharing/sharing_message_bridge_impl.cc 2020-03-11 21:33:46.787551939 +0100
@@ -160,7 +160,7 @@ void SharingMessageBridgeImpl::OnCommitA
syncer::SyncCommitError commit_error) {
// Full commit failed means we need to drop all entities and report an error
// using callback.
- sync_pb::SharingMessageCommitError::ErrorCode sharing_message_error_code;
+ sync_pb::SharingMessageCommitError::ErrorCode sharing_message_error_code = sync_pb::SharingMessageCommitError::NONE;
switch (commit_error) {
case syncer::SyncCommitError::kNetworkError:
sharing_message_error_code =
--- chromium-81.0.4044.43/chrome/browser/sharing/sharing_metrics.cc.gcc9 2020-03-09 18:39:43.584247659 +0100
+++ chromium-81.0.4044.43/chrome/browser/sharing/sharing_metrics.cc 2020-03-11 21:59:44.904608891 +0100
@@ -107,6 +107,7 @@ std::string SharingSendMessageResultToSt
case SharingSendMessageResult::kEncryptionError:
return "EncryptionError";
}
+ return "";
}
chrome_browser_sharing::MessageType SharingPayloadCaseToMessageType(
--- chromium-81.0.4044.43/chrome/browser/extensions/api/identity/gaia_remote_consent_flow.cc.gcc9 2020-03-04 22:52:56.000000000 +0100
+++ chromium-81.0.4044.43/chrome/browser/extensions/api/identity/gaia_remote_consent_flow.cc 2020-03-11 22:30:48.161481809 +0100
@@ -111,7 +111,7 @@ void GaiaRemoteConsentFlow::OnConsentRes
}
void GaiaRemoteConsentFlow::OnAuthFlowFailure(WebAuthFlow::Failure failure) {
- GaiaRemoteConsentFlow::Failure gaia_failure;
+ GaiaRemoteConsentFlow::Failure gaia_failure = GaiaRemoteConsentFlow::LOAD_FAILED;
switch (failure) {
case WebAuthFlow::WINDOW_CLOSED:
--- chromium-81.0.4044.43/chrome/browser/vr/service/vr_service_impl.cc.gcc9 2020-03-04 22:52:57.000000000 +0100
+++ chromium-81.0.4044.43/chrome/browser/vr/service/vr_service_impl.cc 2020-03-11 23:18:41.324710744 +0100
@@ -93,6 +93,7 @@ ContentSettingsType GetRequiredPermissio
case device::mojom::XRSessionMode::kImmersiveAr:
return ContentSettingsType::AR;
}
+ return ContentSettingsType::SENSORS;
}
} // namespace
--- chromium-81.0.4044.43/chrome/browser/safe_browsing/cloud_content_scanning/deep_scanning_dialog_views.cc.gcc9 2020-03-04 22:52:57.000000000 +0100
+++ chromium-81.0.4044.43/chrome/browser/safe_browsing/cloud_content_scanning/deep_scanning_dialog_views.cc 2020-03-12 08:16:41.193313681 +0100
@@ -274,7 +274,7 @@ void DeepScanningDialogViews::SetupButto
}
base::string16 DeepScanningDialogViews::GetDialogMessage() const {
- int text_id;
+ int text_id = 0;
switch (dialog_status_) {
case DeepScanningDialogStatus::PENDING:
text_id = GetPendingMessageId();
@@ -424,6 +424,7 @@ int DeepScanningDialogViews::GetPendingM
return is_file_scan_ ? IDS_DEEP_SCANNING_DIALOG_DRAG_FILES_PENDING_MESSAGE
: IDS_DEEP_SCANNING_DIALOG_DRAG_DATA_PENDING_MESSAGE;
}
+ return IDS_DEEP_SCANNING_DIALOG_UPLOAD_PENDING_MESSAGE;
}
int DeepScanningDialogViews::GetFailureMessageId() const {
@@ -442,6 +443,7 @@ int DeepScanningDialogViews::GetFailureM
return is_file_scan_ ? IDS_DEEP_SCANNING_DIALOG_DRAG_FILES_FAILURE_MESSAGE
: IDS_DEEP_SCANNING_DIALOG_DRAG_DATA_FAILURE_MESSAGE;
}
+ return IDS_DEEP_SCANNING_DIALOG_UPLOAD_FAILURE_MESSAGE;
}
const gfx::ImageSkia* DeepScanningDialogViews::GetTopImage() const {
--- chromium-81.0.4044.43/chrome/browser/safe_browsing/cloud_content_scanning/deep_scanning_dialog_delegate.cc.gcc9 2020-03-04 22:52:57.000000000 +0100
+++ chromium-81.0.4044.43/chrome/browser/safe_browsing/cloud_content_scanning/deep_scanning_dialog_delegate.cc 2020-03-12 08:17:41.856287807 +0100
@@ -274,6 +274,7 @@ bool DeepScanningDialogDelegate::ResultS
case BinaryUploadService::Result::FILE_ENCRYPTED:
return false;
}
+ return false;
}
// static
--- chromium-81.0.4044.43/chrome/browser/ui/startup/startup_browser_creator_impl.cc.gcc9 2020-03-04 22:52:57.000000000 +0100
+++ chromium-81.0.4044.43/chrome/browser/ui/startup/startup_browser_creator_impl.cc 2020-03-12 09:02:38.562292431 +0100
@@ -273,7 +273,7 @@ void MaybeToggleFullscreen(Browser* brow
void FinalizeWebAppLaunch(Browser* browser,
apps::mojom::LaunchContainer container) {
- LaunchMode mode;
+ LaunchMode mode = LM_UNKNOWN_WEBAPP;
switch (container) {
case apps::mojom::LaunchContainer::kLaunchContainerWindow:
DCHECK(browser->is_type_app());
--- chromium-81.0.4044.43/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc.gcc9 2020-03-04 22:52:57.000000000 +0100
+++ chromium-81.0.4044.43/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc 2020-03-12 10:03:30.397153740 +0100
@@ -96,6 +96,7 @@ bool ShouldAnchorToAction(const extensio
case extensions::ActionInfo::TYPE_ACTION:
return false;
}
+ return false;
}
bool HasOmniboxKeyword(const Extension* extension) {
@@ -180,6 +181,7 @@ bool ShouldShowHowToUse(const extensions
case extensions::ActionInfo::TYPE_ACTION:
return HasOmniboxKeyword(extension);
}
+ return false;
}
bool HasCommandKeybinding(const extensions::Extension* extension,
@@ -217,6 +219,7 @@ bool ShouldShowHowToManage(const extensi
case extensions::ActionInfo::TYPE_ACTION:
return HasOmniboxKeyword(extension);
}
+ return false;
}
bool ShouldShowKeybinding(const Extension* extension, const Browser* browser) {
@@ -232,6 +235,7 @@ bool ShouldShowKeybinding(const Extensio
case extensions::ActionInfo::TYPE_ACTION:
return false;
}
+ return false;
}
bool ShouldShowSignInPromo(const Extension* extension, const Browser* browser) {
--- chromium-81.0.4044.43/chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view.cc.gcc9 2020-03-04 22:52:10.000000000 +0100
+++ chromium-81.0.4044.43/chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view.cc 2020-03-12 11:54:03.930266414 +0100
@@ -49,6 +49,7 @@ int GetSafetyTipBannerId(security_state:
NOTREACHED();
return 0;
}
+ return 0;
}
} // namespace
--- chromium-81.0.4044.43/chrome/browser/ui/views/tabs/tab_group_editor_bubble_view.cc.gcc9 2020-03-04 22:52:57.000000000 +0100
+++ chromium-81.0.4044.43/chrome/browser/ui/views/tabs/tab_group_editor_bubble_view.cc 2020-03-12 12:11:12.817178027 +0100
@@ -197,7 +197,7 @@ SkColor TabGroupEditorBubbleView::InitCo
// selected value.
const tab_groups::TabGroupColorId initial_color_id =
tab_controller_->GetGroupColorId(group_);
- SkColor initial_color;
+ SkColor initial_color(0);
color_ids_.reserve(all_colors.size());
colors_.reserve(all_colors.size());
--- chromium-81.0.4044.43/chrome/browser/vr/metrics/session_metrics_helper.cc.gcc9 2020-03-04 22:52:10.000000000 +0100
+++ chromium-81.0.4044.43/chrome/browser/vr/metrics/session_metrics_helper.cc 2020-03-12 12:33:44.266740275 +0100
@@ -273,6 +273,7 @@ SessionMetricsHelper::ConvertRuntimeOpti
case device::mojom::XRSessionMode::kImmersiveAr:
return SessionMode::kImmersiveAr;
}
+ return SessionMode::kInline;
}
SessionMetricsHelper::SessionMetricsHelper(content::WebContents* contents,
--- chromium-81.0.4044.43/components/paint_preview/browser/paint_preview_client.cc.gcc9 2020-03-04 22:52:57.000000000 +0100
+++ chromium-81.0.4044.43/components/paint_preview/browser/paint_preview_client.cc 2020-03-12 13:04:03.482531314 +0100
@@ -78,7 +78,7 @@ PaintPreviewClient::PaintPreviewData::Pa
PaintPreviewClient::PaintPreviewData::~PaintPreviewData() = default;
PaintPreviewClient::PaintPreviewData& PaintPreviewClient::PaintPreviewData::
-operator=(PaintPreviewData&& rhs) noexcept = default;
+operator=(PaintPreviewData&& rhs) = default;
PaintPreviewClient::PaintPreviewData::PaintPreviewData(
PaintPreviewData&& other) noexcept = default;
--- chromium-81.0.4044.43/content/browser/gpu/gpu_data_manager_impl_private.cc.gcc9 2020-03-04 22:52:58.000000000 +0100
+++ chromium-81.0.4044.43/content/browser/gpu/gpu_data_manager_impl_private.cc 2020-03-12 14:19:15.662282373 +0100
@@ -955,19 +955,19 @@ void GpuDataManagerImplPrivate::UpdateGp
GpuProcessKind kind) const {
DCHECK(gpu_preferences);
+#if !defined(USE_X11)
// For performance reasons, discourage storing VideoFrames in a biplanar
// GpuMemoryBuffer if this is not native, see https://crbug.com/791676.
if (auto* gpu_memory_buffer_manager =
GpuMemoryBufferManagerSingleton::GetInstance()) {
// On X11, we do not know GpuMemoryBuffer configuration support until
// receiving the initial GPUInfo.
-#if !defined(USE_X11)
gpu_preferences->disable_biplanar_gpu_memory_buffers_for_video_frames =
!gpu_memory_buffer_manager->IsNativeGpuMemoryBufferConfiguration(
gfx::BufferFormat::YUV_420_BIPLANAR,
gfx::BufferUsage::GPU_READ_CPU_READ_WRITE);
-#endif
}
+#endif
gpu_preferences->gpu_program_cache_size =
gpu::ShaderDiskCache::CacheSizeBytes();
--- chromium-81.0.4044.43/extensions/browser/url_loader_factory_manager.cc.gcc9 2020-03-04 22:52:58.000000000 +0100
+++ chromium-81.0.4044.43/extensions/browser/url_loader_factory_manager.cc 2020-03-12 16:04:00.912228569 +0100
@@ -332,6 +332,7 @@ bool ShouldDisableCorb(const Extension&
case FactoryUser::kExtensionProcess:
return true;
}
+ return false;
}
// Returns whether URLLoaderFactoryParams::ignore_isolated_world_origin should
@@ -353,6 +354,7 @@ bool ShouldInspectIsolatedWorldOrigin(co
case FactoryUser::kExtensionProcess:
return false;
}
+ return false;
}
bool ShouldCreateSeparateFactoryForContentScripts(const Extension& extension) {
--- chromium-81.0.4044.43/extensions/browser/api/declarative_net_request/ruleset_manager.cc.gcc9 2020-03-04 22:52:58.000000000 +0100
+++ chromium-81.0.4044.43/extensions/browser/api/declarative_net_request/ruleset_manager.cc 2020-03-12 16:20:01.985116614 +0100
@@ -257,6 +257,7 @@ base::Optional<RequestAction> RulesetMan
NOTREACHED();
return 0;
}
+ return 0;
};
base::Optional<RequestAction> action;
--- chromium-81.0.4044.43/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc.gcc9 2020-03-09 18:39:39.501316061 +0100
+++ chromium-81.0.4044.43/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc 2020-03-12 16:58:47.825107744 +0100
@@ -523,7 +523,7 @@ bool AXLayoutObject::IsSelectedFromFocus
// A tab item can also be selected if it is associated to a focused tabpanel
// via the aria-labelledby attribute.
if (IsTabItem() && IsTabItemSelected())
- return kSelectedStateTrue;
+ return true;
// If not a single selection container, selection does not follow focus.
AXObject* container = ContainerWidget();
--- chromium-81.0.4044.43/third_party/blink/renderer/modules/accessibility/ax_object.cc.gcc9 2020-03-04 22:53:00.000000000 +0100
+++ chromium-81.0.4044.43/third_party/blink/renderer/modules/accessibility/ax_object.cc 2020-03-12 18:25:47.952680062 +0100
@@ -1709,7 +1709,7 @@ String AXObject::AriaTextAlternative(boo
// calculations.
AXObjectSet visited_copy = visited;
text_alternative = TextFromElements(
- true, visited, elements_from_attribute, related_objects);
+ true, visited_copy, elements_from_attribute, related_objects);
if (!ids.IsEmpty())
AXObjectCache().UpdateReverseRelations(this, ids);
if (!text_alternative.IsNull()) {
--- chromium-81.0.4044.43/third_party/blink/renderer/core/editing/ime/input_method_controller.cc.gcc9 2020-03-04 22:52:59.000000000 +0100
+++ chromium-81.0.4044.43/third_party/blink/renderer/core/editing/ime/input_method_controller.cc 2020-03-12 20:08:04.358585029 +0100
@@ -1189,7 +1189,7 @@ bool InputMethodController::DeleteSelect
TypingCommand::UpdateSelectionIfDifferentFromCurrentSelection(
last_typing_command, &GetFrame());
- last_typing_command->DeleteSelection(TypingCommand::kSmartDelete,
+ last_typing_command->DeleteSelection(true,
ASSERT_NO_EDITING_ABORT);
return true;
}
--- chromium-81.0.4044.43/third_party/blink/renderer/core/html/forms/html_select_element.cc.gcc9 2020-03-04 22:52:59.000000000 +0100
+++ chromium-81.0.4044.43/third_party/blink/renderer/core/html/forms/html_select_element.cc 2020-03-12 21:06:22.632450979 +0100
@@ -1104,7 +1104,7 @@ void HTMLSelectElement::SelectOption(HTM
DispatchInputEvent();
DispatchChangeEvent();
}
- if (LayoutObject* layout_object = GetLayoutObject()) {
+ if (GetLayoutObject()) {
// Need to check UsesMenuList() again because event handlers might
// change the status.
if (UsesMenuList()) {
--- chromium-81.0.4044.43/third_party/blink/renderer/core/inspector/inspector_dom_agent.cc.gcc9 2020-03-04 22:52:59.000000000 +0100
+++ chromium-81.0.4044.43/third_party/blink/renderer/core/inspector/inspector_dom_agent.cc 2020-03-12 21:27:34.939950894 +0100
@@ -200,6 +200,7 @@ protocol::DOM::PseudoType InspectorDOMAg
CHECK(false);
return "";
}
+ return "";
}
// static
--- chromium-81.0.4044.43/third_party/blink/renderer/core/layout/ng/inline/ng_inline_cursor.cc.gcc9 2020-03-04 22:53:00.000000000 +0100
+++ chromium-81.0.4044.43/third_party/blink/renderer/core/layout/ng/inline/ng_inline_cursor.cc 2020-03-12 21:57:13.688781801 +0100
@@ -879,9 +879,7 @@ NGInlineCursor::ItemsSpan::iterator NGIn
void NGInlineCursor::InternalMoveTo(const LayoutObject& layout_object) {
DCHECK(layout_object.IsInLayoutNGInlineFormattingContext());
// If this cursor is rootless, find the root of the inline formatting context.
- bool had_root = true;
if (!HasRoot()) {
- had_root = false;
const LayoutBlockFlow& root = *layout_object.RootInlineFormattingContext();
DCHECK(&root);
SetRoot(root);
--- chromium-81.0.4044.43/third_party/blink/renderer/core/loader/frame_loader.cc.gcc9 2020-03-04 22:53:00.000000000 +0100
+++ chromium-81.0.4044.43/third_party/blink/renderer/core/loader/frame_loader.cc 2020-03-13 20:33:28.115628194 +0100
@@ -944,7 +944,7 @@ void FrameLoader::CommitNavigation(
// Check if the CSP of the response allow should block the new document from
// committing before unloading the current document. This will allow to report
// violations and display console messages properly.
- ContentSecurityPolicy* content_security_policy;
+ ContentSecurityPolicy* content_security_policy = nullptr;
if (!loading_url_as_empty_document) {
content_security_policy =
CreateCSP(navigation_params->url,
--- chromium-81.0.4044.43/third_party/blink/renderer/modules/xr/xr_target_ray_space.cc.gcc9 2020-03-04 22:53:00.000000000 +0100
+++ chromium-81.0.4044.43/third_party/blink/renderer/modules/xr/xr_target_ray_space.cc 2020-03-13 21:54:26.364818118 +0100
@@ -47,6 +47,7 @@ std::unique_ptr<TransformationMatrix> XR
*(input_source_->InputFromPointer())));
}
}
+ return nullptr;
}
std::unique_ptr<TransformationMatrix> XRTargetRaySpace::NativeFromMojo() {
--- chromium-81.0.4044.43/third_party/blink/renderer/modules/xr/xr_dom_overlay_state.cc.gcc9 2020-03-04 22:53:00.000000000 +0100
+++ chromium-81.0.4044.43/third_party/blink/renderer/modules/xr/xr_dom_overlay_state.cc 2020-03-13 22:31:13.607062313 +0100
@@ -17,6 +17,7 @@ const String MapOverlayType(XRDOMOverlay
case XRDOMOverlayState::DOMOverlayType::kFloating:
return "floating";
}
+ return "";
}
} // namespace
--- chromium-81.0.4044.43/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc.gcc9 2020-03-09 18:39:40.360301670 +0100
+++ chromium-81.0.4044.43/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc 2020-03-13 23:28:38.776721307 +0100
@@ -365,6 +365,7 @@ bool ResourceLoadScheduler::IsClientDela
case scheduler::SchedulingLifecycleState::kStopped:
return option != ThrottleOption::kCanNotBeStoppedOrThrottled;
}
+ return true;
}
void ResourceLoadScheduler::OnLifecycleStateChanged(
--- chromium-81.0.4044.43/third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.cc.gcc9 2020-03-04 22:53:00.000000000 +0100
+++ chromium-81.0.4044.43/third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.cc 2020-03-14 00:56:23.225915248 +0100
@@ -141,8 +141,9 @@ PaintImage AcceleratedStaticBitmapImage:
// TODO(ccameron): This function should not ignore |colorBehavior|.
// https://crbug.com/672306
DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
- if (!IsValid())
+ if (!IsValid()) {
return PaintImage();
+ }
CreateImageFromMailboxIfNeeded();
@@ -162,8 +163,9 @@ void AcceleratedStaticBitmapImage::Draw(
ImageDecodingMode decode_mode) {
DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
auto paint_image = PaintImageForCurrentFrame();
- if (!paint_image)
+ if (!paint_image) {
return;
+ }
auto paint_image_decoding_mode = ToPaintImageDecodingMode(decode_mode);
if (paint_image.decoding_mode() != paint_image_decoding_mode) {
paint_image = PaintImageBuilder::WithCopy(std::move(paint_image))
--- chromium-81.0.4044.83/components/viz/common/quads/render_pass.cc.gcc9 2020-03-26 19:39:50.000000000 +0100
+++ chromium-81.0.4044.83/components/viz/common/quads/render_pass.cc 2020-03-27 10:12:07.050379862 +0100
@@ -115,6 +115,7 @@ QuadList::Iterator QuadList::InsertCopyB
NOTREACHED(); // Invalid DrawQuad material.
return at;
}
+ return at;
}
std::unique_ptr<RenderPass> RenderPass::Create() {
--- chromium-81.0.4044.122/third_party/webrtc/api/video_codecs/video_encoder_software_fallback_wrapper.cc.gcc9 2020-04-21 23:52:05.000000000 +0200
+++ chromium-81.0.4044.122/third_party/webrtc/api/video_codecs/video_encoder_software_fallback_wrapper.cc 2020-04-22 19:46:17.463439281 +0200
@@ -161,6 +161,7 @@ class VideoEncoderSoftwareFallbackWrappe
case EncoderState::kForcedFallback:
return fallback_encoder_.get();
}
+ return nullptr;
}
// Updates encoder with last observed parameters, such as callbacks, rates,
@@ -344,6 +345,7 @@ int32_t VideoEncoderSoftwareFallbackWrap
case EncoderState::kForcedFallback:
return fallback_encoder_->Encode(frame, frame_types);
}
+ return 0;
}
int32_t VideoEncoderSoftwareFallbackWrapper::EncodeWithMainEncoder(
const VideoFrame& frame,
