--- chromium-74.0.3729.40/base/files/file_posix.cc.gcc8 2019-03-27 19:49:54.000000000 +0100 +++ chromium-74.0.3729.40/base/files/file_posix.cc 2019-03-30 18:59:49.372411413 +0100 @@ -73,15 +73,16 @@ int CallFutimes(PlatformFile file, const #if !defined(OS_FUCHSIA) short FcntlFlockType(base::Optional<File::LockMode> mode) { - if (!mode.has_value()) - return F_UNLCK; - switch (mode.value()) { - case File::LockMode::kShared: - return F_RDLCK; - case File::LockMode::kExclusive: - return F_WRLCK; + if (mode.has_value()) + { + switch (mode.value()) { + case File::LockMode::kShared: + return F_RDLCK; + case File::LockMode::kExclusive: + return F_WRLCK; + } } - NOTREACHED(); + return F_UNLCK; } File::Error CallFcntlFlock(PlatformFile file, --- chromium-74.0.3729.40/third_party/glslang/src/SPIRV/SpvPostProcess.cpp.gcc8 2019-03-27 19:52:46.000000000 +0100 +++ chromium-74.0.3729.40/third_party/glslang/src/SPIRV/SpvPostProcess.cpp 2019-03-30 19:37:45.068435622 +0100 @@ -256,9 +256,7 @@ void Builder::postProcess(Instruction& i } } assert(inst.getNumOperands() >= 3); - unsigned int memoryAccess = inst.getImmediateOperand((inst.getOpCode() == OpStore) ? 2 : 1); - assert(memoryAccess & MemoryAccessAlignedMask); - static_cast<void>(memoryAccess); + assert(inst.getImmediateOperand((inst.getOpCode() == OpStore) ? 2 : 1) & MemoryAccessAlignedMask); // Compute the index of the alignment operand. int alignmentIdx = 2; if (inst.getOpCode() == OpStore) --- chromium-74.0.3729.40/third_party/nasm/asm/nasm.c.gcc8 2019-03-27 19:52:48.000000000 +0100 +++ chromium-74.0.3729.40/third_party/nasm/asm/nasm.c 2019-03-30 19:45:26.195518119 +0100 @@ -358,26 +358,6 @@ static void emit_dependencies(StrList *l fclose(deps); } -/* Convert a struct tm to a POSIX-style time constant */ -static int64_t make_posix_time(const struct tm *tm) -{ - int64_t t; - int64_t y = tm->tm_year; - - /* See IEEE 1003.1:2004, section 4.14 */ - - t = (y-70)*365 + (y-69)/4 - (y-1)/100 + (y+299)/400; - t += tm->tm_yday; - t *= 24; - t += tm->tm_hour; - t *= 60; - t += tm->tm_min; - t *= 60; - t += tm->tm_sec; - - return t; -} - static void timestamp(void) { struct compile_time * const oct = &official_compile_time; --- chromium-74.0.3729.40/third_party/webrtc/call/simulated_network.cc.gcc8 2019-03-27 19:52:52.000000000 +0100 +++ chromium-74.0.3729.40/third_party/webrtc/call/simulated_network.cc 2019-03-30 19:51:18.497468489 +0100 @@ -48,7 +48,7 @@ bool CoDelSimulation::DropDequeuedPacket case kNormal: enter_drop_state_at_ = now + kWindow; state_ = kPending; - return false; + break; case kPending: if (now >= enter_drop_state_at_) { @@ -63,7 +63,7 @@ bool CoDelSimulation::DropDequeuedPacket ++drop_count_; return true; } - return false; + break; case kDropping: TimeDelta drop_delay = kWindow / sqrt(static_cast<double>(drop_count_)); @@ -75,8 +75,9 @@ bool CoDelSimulation::DropDequeuedPacket ++drop_count_; return true; } - return false; + break; } + return false; } SimulatedNetwork::SimulatedNetwork(SimulatedNetwork::Config config, --- chromium-74.0.3729.40/net/http/http_auth_gssapi_posix.cc.gcc8 2019-03-27 19:50:21.000000000 +0100 +++ chromium-74.0.3729.40/net/http/http_auth_gssapi_posix.cc 2019-03-30 22:18:16.792399022 +0100 @@ -51,6 +51,7 @@ OM_uint32 DelegationTypeToFlag(Delegatio case DelegationType::kUnconstrained: return GSS_C_DELEG_FLAG; } + return 0; } // ScopedBuffer releases a gss_buffer_t when it goes out of scope. --- chromium-74.0.3729.40/cc/animation/animation_host.cc.gcc8 2019-03-27 19:49:55.000000000 +0100 +++ chromium-74.0.3729.40/cc/animation/animation_host.cc 2019-03-30 22:24:50.617663405 +0100 @@ -44,8 +44,9 @@ AnimationWorkletMutationState ToAnimatio return AnimationWorkletMutationState::COMPLETED_NO_UPDATE; case MutateStatus::kCanceled: - return AnimationWorkletMutationState::CANCELED; + break; } + return AnimationWorkletMutationState::CANCELED; } bool TickAnimationsIf(AnimationHost::AnimationsList animations, --- chromium-74.0.3729.40/components/offline_pages/core/offline_page_metadata_store.cc.gcc8 2019-03-27 19:50:09.000000000 +0100 +++ chromium-74.0.3729.40/components/offline_pages/core/offline_page_metadata_store.cc 2019-03-30 22:36:14.216962023 +0100 @@ -322,8 +322,9 @@ StoreState InitializationStatusToStoreSt case SqlStoreBase::InitializationStatus::kSuccess: return StoreState::LOADED; case SqlStoreBase::InitializationStatus::kFailure: - return StoreState::FAILED_LOADING; + break; } + return StoreState::FAILED_LOADING; } } // anonymous namespace --- chromium-74.0.3729.40/gpu/config/gpu_info.cc.gcc8 2019-03-30 20:21:44.234853325 +0100 +++ chromium-74.0.3729.40/gpu/config/gpu_info.cc 2019-03-30 22:42:03.847983019 +0100 @@ -70,6 +71,7 @@ const char* ImageDecodeAcceleratorSubsam case gpu::ImageDecodeAcceleratorSubsampling::k444: return "4:4:4"; } + return ""; } void EnumerateImageDecodeAcceleratorSupportedProfile( --- chromium-74.0.3729.40/gpu/ipc/common/gpu_info_mojom_traits.cc.gcc8 2019-03-27 19:50:17.000000000 +0100 +++ chromium-74.0.3729.40/gpu/ipc/common/gpu_info_mojom_traits.cc 2019-03-30 22:57:47.426922376 +0100 @@ -242,6 +242,7 @@ gpu::mojom::ImageDecodeAcceleratorType E case gpu::ImageDecodeAcceleratorType::kUnknown: return gpu::mojom::ImageDecodeAcceleratorType::kUnknown; } + return gpu::mojom::ImageDecodeAcceleratorType::kUnknown; } // static @@ -277,6 +278,7 @@ EnumTraits<gpu::mojom::ImageDecodeAccele case gpu::ImageDecodeAcceleratorSubsampling::k444: return gpu::mojom::ImageDecodeAcceleratorSubsampling::k444; } + return gpu::mojom::ImageDecodeAcceleratorSubsampling(0); } // static --- chromium-74.0.3729.40/ui/events/event.cc.gcc8 2019-03-27 19:51:07.000000000 +0100 +++ chromium-74.0.3729.40/ui/events/event.cc 2019-03-30 23:07:57.324532445 +0100 @@ -137,6 +137,7 @@ std::string MomentumPhaseToString(EventM case EventMomentumPhase::BLOCKED: return "BLOCKED"; } + return ""; } std::string ScrollEventPhaseToString(ScrollEventPhase phase) { @@ -150,6 +151,7 @@ std::string ScrollEventPhaseToString(Scr case ScrollEventPhase::kEnd: return "kEnd"; } + return ""; } } // namespace --- chromium-74.0.3729.40/components/feed/core/feed_scheduler_host.cc.gcc8 2019-03-27 19:50:08.000000000 +0100 +++ chromium-74.0.3729.40/components/feed/core/feed_scheduler_host.cc 2019-03-30 23:17:48.137459119 +0100 @@ -97,6 +97,7 @@ ParamPair LookupParam(UserClass user_cla return {"fixed_timer_hours_active_suggestions_consumer", 24.0}; } } + return {"", 0.0}; } // Coverts from base::StringPiece to TriggerType and adds it to the set if the @@ -148,6 +149,7 @@ std::string UserClassToHistogramSuffix(U case UserClassifier::UserClass::kActiveSuggestionsConsumer: return "ActiveSuggestionsConsumer"; } + return ""; } // This has a small performance penalty because it is looking up the histogram --- chromium-74.0.3729.40/components/feed/core/refresh_throttler.cc.gcc8 2019-03-27 19:50:08.000000000 +0100 +++ chromium-74.0.3729.40/components/feed/core/refresh_throttler.cc 2019-03-30 23:33:15.383634902 +0100 @@ -45,6 +45,7 @@ std::pair<std::string, int> GetThrottler case UserClassifier::UserClass::kActiveSuggestionsConsumer: return {"SuggestionFetcherActiveSuggestionsConsumer", 20}; } + return {"", 0}; } } // namespace --- chromium-74.0.3729.40/components/invalidation/impl/channels_states.cc.gcc8 2019-03-27 19:50:08.000000000 +0100 +++ chromium-74.0.3729.40/components/invalidation/impl/channels_states.cc 2019-03-30 23:43:22.970239573 +0100 @@ -15,6 +15,7 @@ const char* FcmChannelStateToString(FcmC case FcmChannelState::NO_INSTANCE_ID_TOKEN: return "NO_INSTANCE_ID_TOKEN"; } + return ""; } const char* SubscriptionChannelStateToString(SubscriptionChannelState state) { @@ -28,6 +29,7 @@ const char* SubscriptionChannelStateToSt case SubscriptionChannelState::SUBSCRIPTION_FAILURE: return "SUBSCRIPTION_FAILURE"; } + return ""; } } // namespace syncer --- chromium-74.0.3729.40/components/offline_pages/core/prefetch/prefetch_types.cc.gcc8 2019-03-27 19:50:09.000000000 +0100 +++ chromium-74.0.3729.40/components/offline_pages/core/prefetch/prefetch_types.cc 2019-03-31 00:28:46.571488517 +0100 @@ -21,6 +21,7 @@ std::string PrefetchEnumToString(Prefetc return "SUSPEND"; } DCHECK(false) << static_cast<int>(value) << " not valid enum value"; + return ""; } std::string PrefetchEnumToString(PrefetchRequestStatus value) { @@ -45,6 +46,7 @@ std::string PrefetchEnumToString(Prefetc return "EMPTY_REQUEST_SUCCESS"; } DCHECK(false) << static_cast<int>(value) << " not valid enum value"; + return ""; } std::string PrefetchEnumToString(RenderStatus value) { @@ -59,6 +61,7 @@ std::string PrefetchEnumToString(RenderS return "EXCEEDED_LIMIT"; } DCHECK(false) << static_cast<int>(value) << " not valid enum value"; + return ""; } std::string PrefetchEnumToString(PrefetchItemState value) { @@ -87,6 +90,7 @@ std::string PrefetchEnumToString(Prefetc return "ZOMBIE"; } DCHECK(false) << static_cast<int>(value) << " not valid enum value"; + return ""; } std::string PrefetchEnumToString(PrefetchItemErrorCode value) { @@ -136,6 +140,7 @@ std::string PrefetchEnumToString(Prefetc return "SUGGESTION_INVALIDATED"; } DCHECK(false) << static_cast<int>(value) << " not valid enum value"; + return ""; } } // namespace --- chromium-74.0.3729.40/content/browser/renderer_host/render_widget_host_input_event_router.cc.gcc8 2019-03-27 19:50:13.000000000 +0100 +++ chromium-74.0.3729.40/content/browser/renderer_host/render_widget_host_input_event_router.cc 2019-03-31 00:44:38.885975057 +0100 @@ -240,12 +240,13 @@ bool RenderWidgetHostInputEventRouter::T switch (state_) { case PinchState::NONE: case PinchState::EXISTING_BUBBLING_TO_ROOT: - return false; + break; case PinchState::PINCH_WITH_ROOT_GESTURE_TARGET: case PinchState::PINCH_WHILE_BUBBLING_TO_ROOT: case PinchState::PINCH_DURING_CHILD_GESTURE: return true; } + return false; } bool RenderWidgetHostInputEventRouter::TouchscreenPinchState:: @@ -253,12 +254,13 @@ bool RenderWidgetHostInputEventRouter::T switch (state_) { case PinchState::NONE: case PinchState::PINCH_DURING_CHILD_GESTURE: - return true; + break; case PinchState::EXISTING_BUBBLING_TO_ROOT: case PinchState::PINCH_WITH_ROOT_GESTURE_TARGET: case PinchState::PINCH_WHILE_BUBBLING_TO_ROOT: return false; } + return true; } void RenderWidgetHostInputEventRouter::TouchscreenPinchState:: --- chromium-74.0.3729.40/content/browser/scheduler/browser_task_executor.cc.gcc8 2019-03-27 19:50:13.000000000 +0100 +++ chromium-74.0.3729.40/content/browser/scheduler/browser_task_executor.cc 2019-03-31 00:52:18.669014798 +0100 @@ -62,6 +62,7 @@ QueueType GetQueueType(const base::TaskT case base::TaskPriority::USER_BLOCKING: return QueueType::kUserBlocking; } + return QueueType::kDefault; } const scoped_refptr<base::SequencedTaskRunner>& GetNullTaskRunner() { --- chromium-74.0.3729.40/content/browser/tracing/perfetto_file_tracer.h.gcc8 2019-03-27 19:50:13.000000000 +0100 +++ chromium-74.0.3729.40/content/browser/tracing/perfetto_file_tracer.h 2019-03-31 15:12:22.285562410 +0200 @@ -15,10 +15,12 @@ namespace content { -namespace { +namespace internal { class BackgroundDrainer; } // namespace +using namespace internal; + // This is currently only used for tracing startup using Perfetto // as the backend, rather than TraceLog. It will directly stream // protos to a file specified with the '--perfetto-output-file' --- chromium-74.0.3729.40/content/browser/tracing/perfetto_file_tracer.cc.gcc8 2019-03-27 19:50:13.000000000 +0100 +++ chromium-74.0.3729.40/content/browser/tracing/perfetto_file_tracer.cc 2019-03-31 15:10:35.812445295 +0200 @@ -22,7 +22,7 @@ namespace content { -namespace { +namespace internal { constexpr base::TimeDelta kReadBufferIntervalInSeconds = base::TimeDelta::FromSeconds(1); --- chromium-74.0.3729.40/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc.gcc8 2019-03-27 19:50:01.000000000 +0100 +++ chromium-74.0.3729.40/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc 2019-03-31 15:46:19.093529518 +0200 @@ -57,6 +57,7 @@ bool IsSupportedProtocol(page_load_metri case page_load_metrics::NetworkProtocol::kOther: return false; } + return false; } int64_t LayoutShiftUkmValue(float shift_score) { --- chromium-74.0.3729.40/chrome/browser/ui/webui/signin/inline_login_ui.cc.gcc8 2019-03-27 19:50:04.000000000 +0100 +++ chromium-74.0.3729.40/chrome/browser/ui/webui/signin/inline_login_ui.cc 2019-03-31 16:47:21.473612864 +0200 @@ -92,6 +92,7 @@ bool IsValidChromeSigninReason(const GUR return false; } NOTREACHED(); + return false; #endif // defined(OS_CHROMEOS) } --- chromium-74.0.3729.40/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc.gcc8 2019-03-27 19:50:04.000000000 +0100 +++ chromium-74.0.3729.40/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc 2019-03-31 17:11:00.874898328 +0200 @@ -117,6 +117,7 @@ signin_metrics::Reason GetSigninReasonFr case HandlerSigninReason::FETCH_LST_ONLY: return signin_metrics::Reason::REASON_FETCH_LST_ONLY; } + return signin_metrics::Reason::REASON_MAX; } // Specific implementation of DiceTurnSyncOnHelper::Delegate for forced --- chromium-74.0.3729.40/content/renderer/accessibility/ax_image_annotator.cc.gcc8 2019-03-27 19:50:14.000000000 +0100 +++ chromium-74.0.3729.40/content/renderer/accessibility/ax_image_annotator.cc 2019-03-31 17:41:34.695739039 +0200 @@ -213,7 +213,7 @@ bool AXImageAnnotator::ImageInfo::HasAnn case ax::mojom::ImageAnnotationStatus::kEligibleForAnnotation: case ax::mojom::ImageAnnotationStatus::kSilentlyEligibleForAnnotation: case ax::mojom::ImageAnnotationStatus::kAnnotationPending: - return false; + break; case ax::mojom::ImageAnnotationStatus::kAnnotationSucceeded: DCHECK(annotation_.has_value()); return true; @@ -220,6 +220,7 @@ bool AXImageAnnotator::ImageInfo::HasAnn DCHECK(!annotation_.has_value()); return true; } + return false; } // static --- chromium-74.0.3729.40/services/proxy_resolver/proxy_resolver_v8_tracing.cc.gcc8 2019-03-27 19:50:21.000000000 +0100 +++ chromium-74.0.3729.40/services/proxy_resolver/proxy_resolver_v8_tracing.cc 2019-03-31 17:44:54.755229746 +0200 @@ -857,7 +857,7 @@ void Job::SaveDnsToLocalCache(const std: std::string Job::MakeDnsCacheKey(const std::string& host, net::ProxyResolveDnsOperation op) { - return base::StringPrintf("%d:%s", op, host.c_str()); + return base::StringPrintf("%d:%s", int(op), host.c_str()); } void Job::HandleAlertOrError(bool is_alert, --- chromium-74.0.3729.40/third_party/blink/renderer/modules/mediastream/processed_local_audio_source.cc.gcc8 2019-03-27 19:50:14.000000000 +0100 +++ chromium-74.0.3729.40/third_party/blink/renderer/modules/mediastream/processed_local_audio_source.cc 2019-03-31 18:09:58.599783337 +0200 @@ -54,6 +54,7 @@ void LogAudioProcesingProperties(const A case AEC::kEchoCancellationSystem: return "system"; } + return ""; }; auto bool_to_string = [](bool value) { return value ? "true" : "false"; }; auto str = base::StringPrintf( --- chromium-74.0.3729.40/third_party/blink/renderer/modules/idle/idle_state.cc.gcc8 2019-03-27 19:50:26.000000000 +0100 +++ chromium-74.0.3729.40/third_party/blink/renderer/modules/idle/idle_state.cc 2019-03-31 18:32:44.503774222 +0200 @@ -29,6 +29,7 @@ String IdleState::user() const { case mojom::blink::UserIdleState::kIdle: return "idle"; } + return ""; } String IdleState::screen() const { @@ -38,6 +39,7 @@ String IdleState::screen() const { case mojom::blink::ScreenIdleState::kUnlocked: return "unlocked"; } + return ""; } } // namespace blink --- chromium-74.0.3729.40/third_party/blink/renderer/core/accessibility/apply_dark_mode.cc.gcc8 2019-03-27 19:50:25.000000000 +0100 +++ chromium-74.0.3729.40/third_party/blink/renderer/core/accessibility/apply_dark_mode.cc 2019-03-31 19:35:06.592341207 +0200 @@ -61,8 +61,7 @@ DarkModeSettings BuildDarkModeSettings(c bool ShouldApplyDarkModeFilterToPage(DarkModePagePolicy policy, const LayoutView& root) { - if (root.StyleRef().DarkColorScheme()) - return false; + if (!root.StyleRef().DarkColorScheme()) { switch (policy) { case DarkModePagePolicy::kFilterAll: @@ -70,6 +69,8 @@ bool ShouldApplyDarkModeFilterToPage(Dar case DarkModePagePolicy::kFilterByBackground: return HasLightBackground(root); } + } + return false; } } // namespace blink --- chromium-74.0.3729.40/third_party/blink/renderer/core/frame/csp/content_security_policy.cc.gcc8 2019-03-27 19:50:25.000000000 +0100 +++ chromium-74.0.3729.40/third_party/blink/renderer/core/frame/csp/content_security_policy.cc 2019-03-31 20:23:32.160724291 +0200 @@ -526,6 +526,7 @@ bool ContentSecurityPolicy::IsScriptInli case ContentSecurityPolicy::InlineType::kStyle: return false; } + return false; } bool ContentSecurityPolicy::AllowEval( @@ -667,8 +668,9 @@ GetDirectiveTypeFromRequestContextType(m case mojom::RequestContextType::LOCATION: case mojom::RequestContextType::PLUGIN: case mojom::RequestContextType::UNSPECIFIED: - return base::nullopt; + break; } + return base::nullopt; } bool ContentSecurityPolicy::AllowRequest( --- chromium-74.0.3729.40/third_party/blink/renderer/core/frame/csp/csp_directive_list.cc.gcc8 2019-03-27 19:50:25.000000000 +0100 +++ chromium-74.0.3729.40/third_party/blink/renderer/core/frame/csp/csp_directive_list.cc 2019-03-31 20:33:11.486647257 +0200 @@ -104,6 +104,7 @@ GetDirectiveTypeForAllowInlineFromInline case ContentSecurityPolicy::InlineType::kStyleAttribute: return ContentSecurityPolicy::DirectiveType::kStyleSrcAttr; } + return ContentSecurityPolicy::DirectiveType::kBaseURI; } ContentSecurityPolicy::DirectiveType GetDirectiveTypeForAllowHashFromInlineType( @@ -122,6 +123,7 @@ ContentSecurityPolicy::DirectiveType Get case ContentSecurityPolicy::InlineType::kStyle: return ContentSecurityPolicy::DirectiveType::kStyleSrcElem; } + return ContentSecurityPolicy::DirectiveType::kBaseURI; } } // namespace --- chromium-74.0.3729.40/third_party/blink/renderer/core/intersection_observer/intersection_observer_controller.cc.gcc9 2019-03-27 19:50:25.000000000 +0100 +++ chromium-74.0.3729.40/third_party/blink/renderer/core/intersection_observer/intersection_observer_controller.cc 2019-03-31 21:14:31.385612752 +0200 @@ -62,7 +62,7 @@ void IntersectionObserverController::Del bool IntersectionObserverController::ComputeIntersections(unsigned flags) { needs_occlusion_tracking_ = false; - if (Document* document = To<Document>(GetExecutionContext())) { + if (To<Document>(GetExecutionContext())) { TRACE_EVENT0("blink", "IntersectionObserverController::" "computeIntersections"); --- chromium-74.0.3729.40/third_party/blink/renderer/core/script/import_map.cc.gcc8 2019-03-27 19:50:26.000000000 +0100 +++ chromium-74.0.3729.40/third_party/blink/renderer/core/script/import_map.cc 2019-03-31 22:25:44.718614867 +0200 @@ -87,6 +87,7 @@ String NormalizeSpecifierKey(const Strin // url.</spec> return key.GetImportMapKeyString(); } + return String(); } // Step 2.4-2.7 of @@ -134,6 +135,7 @@ KURL NormalizeValue(const String& key, return value.GetUrl(); } + return NullURL(); } } // namespace --- chromium-74.0.3729.40/third_party/blink/renderer/core/script/modulator_impl_base.cc.gcc8 2019-03-27 19:50:26.000000000 +0100 +++ chromium-74.0.3729.40/third_party/blink/renderer/core/script/modulator_impl_base.cc 2019-03-31 22:35:49.450091410 +0200 @@ -86,6 +86,7 @@ bool ModulatorImplBase::BuiltInModuleEna case layered_api::Module::kElementsVirtualScroller: return false; } + return false; } bool ModulatorImplBase::BuiltInModuleRequireSecureContext( @@ -218,7 +219,7 @@ KURL ModulatorImplBase::ResolveModuleSpe switch (parsed_specifier.GetType()) { case ParsedSpecifier::Type::kInvalid: NOTREACHED(); - return KURL(); + break; case ParsedSpecifier::Type::kBare: // Reject bare specifiers as specced by the pre-ImportMap spec. @@ -232,6 +233,7 @@ KURL ModulatorImplBase::ResolveModuleSpe case ParsedSpecifier::Type::kURL: return parsed_specifier.GetUrl(); } + return KURL(); } ScriptValue ModulatorImplBase::CreateTypeError(const String& message) const { --- chromium-74.0.3729.40/third_party/blink/renderer/core/script/parsed_specifier.cc.gcc8 2019-03-27 19:50:26.000000000 +0100 +++ chromium-74.0.3729.40/third_party/blink/renderer/core/script/parsed_specifier.cc 2019-03-31 22:45:40.949799172 +0200 @@ -41,22 +41,24 @@ ParsedSpecifier ParsedSpecifier::Create( String ParsedSpecifier::GetImportMapKeyString() const { switch (GetType()) { case Type::kInvalid: - return String(); + break; case Type::kBare: return bare_specifier_; case Type::kURL: return url_.GetString(); } + return String(); } KURL ParsedSpecifier::GetUrl() const { switch (GetType()) { case Type::kInvalid: case Type::kBare: - return NullURL(); + break; case Type::kURL: return url_; } + return NullURL(); } } // namespace blink --- chromium-74.0.3729.40/third_party/blink/renderer/modules/animationworklet/animation_worklet_proxy_client.cc.gcc8 2019-03-27 19:50:26.000000000 +0100 +++ chromium-74.0.3729.40/third_party/blink/renderer/modules/animationworklet/animation_worklet_proxy_client.cc 2019-03-31 22:58:52.566976070 +0200 @@ -185,7 +185,7 @@ AnimationWorkletProxyClient::SelectGloba if (--next_global_scope_switch_countdown_ < 0) { int last_global_scope_index = current_global_scope_index_; current_global_scope_index_ = - (++current_global_scope_index_ % global_scopes_.size()); + ((current_global_scope_index_ + 1) % global_scopes_.size()); global_scopes_[last_global_scope_index]->MigrateAnimatorsTo( global_scopes_[current_global_scope_index_]); // Introduce an element of randomness in the switching interval to make --- chromium-74.0.3729.40/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc.gcc8 2019-03-27 19:50:27.000000000 +0100 +++ chromium-74.0.3729.40/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc 2019-03-31 23:23:40.028942283 +0200 @@ -1365,6 +1365,7 @@ const char* ResourceFetcher::GetNameFor( return "load"; } NOTREACHED(); + return ""; } std::pair<ResourceFetcher::RevalidationPolicy, const char*>