--- chromium-70.0.3528.4/base/callback_internal.cc.gcc8 2018-08-21 11:49:22.000000000 +0200 +++ chromium-70.0.3528.4/base/callback_internal.cc 2018-08-22 03:08:10.825006053 +0200 @@ -21,6 +21,7 @@ return true; } NOTREACHED(); + return false; } } // namespace --- chromium-70.0.3528.4/base/bind_internal.h.gcc8 2018-08-21 11:49:22.000000000 +0200 +++ chromium-70.0.3528.4/base/bind_internal.h 2018-08-22 03:12:22.454435946 +0200 @@ -749,6 +749,7 @@ functor, std::get<indices>(bound_args)...); } NOTREACHED(); + return false; } // Relays |base| to corresponding CallbackCancellationTraits<>::Run(). Returns --- chromium-70.0.3528.4/components/viz/common/gl_helper.cc.gcc8 2018-08-21 11:49:36.000000000 +0200 +++ chromium-70.0.3528.4/components/viz/common/gl_helper.cc 2018-08-22 20:20:05.439042583 +0200 @@ -476,7 +476,7 @@ } bool GLHelper::CopyTextureToImpl::IsBGRAReadbackSupported() { - if (bgra_support_ == BGRA_PREFERENCE_UNKNOWN) { + if (bgra_support_ == BGRA_SUPPORT_UNKNOWN) { bgra_support_ = BGRA_NOT_SUPPORTED; if (auto* extensions = gl_->GetString(GL_EXTENSIONS)) { const std::string extensions_string = --- chromium-70.0.3528.4/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc.gcc8 2018-08-21 11:49:32.000000000 +0200 +++ chromium-70.0.3528.4/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc 2018-08-22 20:46:18.826814588 +0200 @@ -46,8 +46,9 @@ std::string GetClientTagForSpecificsId(W return "card-" + specifics_id; case WalletMetadataSpecifics::UNKNOWN: NOTREACHED(); - return ""; + break; } + return ""; } // Returns the wallet metadata specifics id for the specified |metadata_id|. @@ -248,8 +249,9 @@ bool AddServerMetadata(AutofillTable* ta return table->AddServerCardMetadata(metadata); case WalletMetadataSpecifics::UNKNOWN: NOTREACHED(); - return false; + break; } + return false; } bool RemoveServerMetadata(AutofillTable* table, @@ -262,8 +264,9 @@ bool RemoveServerMetadata(AutofillTable* return table->RemoveServerCardMetadata(id); case WalletMetadataSpecifics::UNKNOWN: NOTREACHED(); - return false; + break; } + return false; } bool UpdateServerMetadata(AutofillTable* table, --- chromium-70.0.3528.4/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc.gcc8 2018-08-21 11:49:32.000000000 +0200 +++ chromium-70.0.3528.4/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc 2018-08-22 20:50:21.920501135 +0200 @@ -31,6 +31,7 @@ sync_pb::WalletMaskedCreditCard::WalletC case CreditCard::EXPIRED: return sync_pb::WalletMaskedCreditCard::EXPIRED; } + return sync_pb::WalletMaskedCreditCard::WalletCardStatus(0); } CreditCard::ServerStatus ServerToLocalStatus( @@ -41,6 +42,7 @@ CreditCard::ServerStatus ServerToLocalSt case sync_pb::WalletMaskedCreditCard::EXPIRED: return CreditCard::EXPIRED; } + return CreditCard::ServerStatus(0); } sync_pb::WalletMaskedCreditCard::WalletCardType WalletCardTypeFromCardNetwork( @@ -85,6 +87,7 @@ const char* CardNetworkFromWalletCardTyp case sync_pb::WalletMaskedCreditCard::UNKNOWN: return kGenericCard; } + return kGenericCard; } // Creates an AutofillProfile from the specified |card| specifics. --- chromium-70.0.3528.4/components/policy/core/common/cloud/cloud_policy_util.cc.gcc8 2018-08-21 11:49:33.000000000 +0200 +++ chromium-70.0.3528.4/components/policy/core/common/cloud/cloud_policy_util.cc 2018-08-22 20:57:20.438070995 +0200 @@ -160,8 +160,6 @@ em::Channel ConvertToProtoChannel(version_info::Channel channel) { switch (channel) { - case version_info::Channel::UNKNOWN: - return em::CHANNEL_UNKNOWN; case version_info::Channel::CANARY: return em::CHANNEL_CANARY; case version_info::Channel::DEV: @@ -170,7 +168,10 @@ return em::CHANNEL_BETA; case version_info::Channel::STABLE: return em::CHANNEL_STABLE; + case version_info::Channel::UNKNOWN: + break; } + return em::CHANNEL_UNKNOWN; } } // namespace policy --- chromium-70.0.3528.4/services/network/public/cpp/host_resolver_mojom_traits.cc.gcc8 2018-08-21 11:49:46.000000000 +0200 +++ chromium-70.0.3528.4/services/network/public/cpp/host_resolver_mojom_traits.cc 2018-08-22 21:04:36.936359195 +0200 @@ -271,7 +271,7 @@ DnsQueryType EnumTraits<DnsQueryType, ne net::DnsQueryType input) { switch (input) { case net::DnsQueryType::UNSPECIFIED: - return DnsQueryType::UNSPECIFIED; + break; case net::DnsQueryType::A: return DnsQueryType::A; case net::DnsQueryType::AAAA: @@ -286,6 +286,7 @@ DnsQueryType EnumTraits<DnsQueryType, ne NOTIMPLEMENTED(); return DnsQueryType::UNSPECIFIED; } + return DnsQueryType::UNSPECIFIED; } // static @@ -312,6 +313,7 @@ bool EnumTraits<DnsQueryType, net::DnsQu *output = net::DnsQueryType::SRV; return true; } + return false; } // static --- chromium-70.0.3528.4/chrome/browser/media/webrtc/media_stream_capture_indicator.cc.gcc8 2018-08-21 11:49:26.000000000 +0200 +++ chromium-70.0.3528.4/chrome/browser/media/webrtc/media_stream_capture_indicator.cc 2018-08-23 00:51:21.562436998 +0200 @@ -106,6 +106,7 @@ ObserverMethod GetObserverMethodToCall(b NOTREACHED(); return nullptr; } + return nullptr; } } // namespace @@ -294,6 +295,7 @@ int& MediaStreamCaptureIndicator::WebCon NOTREACHED(); return video_stream_count_; } + return video_stream_count_; } MediaStreamCaptureIndicator::Observer::~Observer() { --- chromium-70.0.3528.4/chrome/browser/ui/webui/media/media_engagement_ui.cc.gcc8 2018-08-21 11:49:28.000000000 +0200 +++ chromium-70.0.3528.4/chrome/browser/ui/webui/media/media_engagement_ui.cc 2018-08-23 01:36:02.540654647 +0200 @@ -99,6 +99,7 @@ case content::AutoplayPolicy::kDocumentUserActivationRequired: return "document-user-activation-required"; } + return ""; } const std::string GetPreloadVersion() { --- chromium-70.0.3528.4/chrome/browser/ui/views/autofill/payments/local_card_migration_dialog_view.cc.gcc8 2018-08-21 11:49:28.000000000 +0200 +++ chromium-70.0.3528.4/chrome/browser/ui/views/autofill/payments/local_card_migration_dialog_view.cc 2018-08-23 02:06:24.710232264 +0200 @@ -471,6 +473,7 @@ base::string16 LocalCardMigrationDialogV return l10n_util::GetStringUTF16( IDS_AUTOFILL_LOCAL_CARD_MIGRATION_DIALOG_BUTTON_LABEL_DONE); } + return base::string16(); } base::string16 LocalCardMigrationDialogView::GetCancelButtonLabel() const { --- chromium-70.0.3528.4/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc.gcc8 2018-08-21 11:50:19.000000000 +0200 +++ chromium-70.0.3528.4/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc 2018-08-24 01:23:50.677245606 +0200 @@ -348,17 +348,18 @@ const String BackgroundFetchRegistration case mojom::BackgroundFetchResult::SUCCESS: return "success"; case mojom::BackgroundFetchResult::FAILURE: - return "failure"; + break; case mojom::BackgroundFetchResult::UNSET: return ""; } NOTREACHED(); + return "failure"; } const String BackgroundFetchRegistration::failureReason() const { switch (failure_reason_) { case mojom::BackgroundFetchFailureReason::NONE: - return ""; + break; case mojom::BackgroundFetchFailureReason::CANCELLED_FROM_UI: case mojom::BackgroundFetchFailureReason::CANCELLED_BY_DEVELOPER: return "aborted"; @@ -373,6 +374,7 @@ const String BackgroundFetchRegistration return "download-total-exceeded"; } NOTREACHED(); + return ""; } void BackgroundFetchRegistration::Dispose() { --- chromium-70.0.3528.4/third_party/blink/renderer/modules/accessibility/ax_position.cc.gcc8 2018-08-21 11:50:19.000000000 +0200 +++ chromium-70.0.3528.4/third_party/blink/renderer/modules/accessibility/ax_position.cc 2018-08-24 01:39:59.717763044 +0200 @@ -802,7 +802,7 @@ const AXObject* AXPosition::FindNeighbor if (next_object && next_object->AccessibilityIsIncludedInTree()) return next_object; } - return nullptr; + break; } case AXPositionAdjustmentBehavior::kMoveLeft: { @@ -814,9 +814,10 @@ const AXObject* AXPosition::FindNeighbor if (previous_object && previous_object->AccessibilityIsIncludedInTree()) return previous_object; } - return nullptr; + break; } } + return nullptr; } bool operator==(const AXPosition& a, const AXPosition& b) { --- chromium-70.0.3528.4/third_party/blink/renderer/platform/scheduler/common/metrics_helper.cc.gcc8 2018-08-21 11:50:20.000000000 +0200 +++ chromium-70.0.3528.4/third_party/blink/renderer/platform/scheduler/common/metrics_helper.cc 2018-08-24 02:02:26.257496527 +0200 @@ -44,6 +44,7 @@ scheduling_metrics::ThreadType ConvertBl NOTREACHED(); return scheduling_metrics::ThreadType::kCount; } + return scheduling_metrics::ThreadType::kCount; } } // namespace --- chromium-70.0.3528.4/third_party/blink/renderer/modules/storage/cached_storage_area.cc.gcc8 2018-08-21 11:50:19.000000000 +0200 +++ chromium-70.0.3528.4/third_party/blink/renderer/modules/storage/cached_storage_area.cc 2018-08-24 02:21:38.087682075 +0200 @@ -625,6 +625,7 @@ } } NOTREACHED(); + return Vector<uint8_t>(); } } // namespace blink --- chromium-70.0.3528.4/content/browser/media/capture/mouse_cursor_overlay_controller_aura.cc.gcc8 2018-08-21 11:49:37.000000000 +0200 +++ chromium-70.0.3528.4/content/browser/media/capture/mouse_cursor_overlay_controller_aura.cc 2018-08-28 16:24:08.166914370 +0200 @@ -174,7 +174,7 @@ if (auto* window = Observer::GetTargetWindow(observer_)) { const gfx::Size window_size = window->bounds().size(); if (!window_size.IsEmpty()) { - if (auto* root_window = window->GetRootWindow()) { + if (window->GetRootWindow() != nullptr) { // Compute the cursor size in terms of DIP coordinates. const SkBitmap& bitmap = cursor.GetBitmap(); const float scale_factor = cursor.device_scale_factor(); --- chromium-70.0.3528.4/third_party/blink/renderer/core/layout/layout_view.cc.gcc8 2018-08-21 11:50:18.000000000 +0200 +++ chromium-70.0.3528.4/third_party/blink/renderer/core/layout/layout_view.cc 2018-08-28 16:26:59.078801346 +0200 @@ -878,8 +878,7 @@ if (result) { // Changing overflow should notify scrolling coordinator to ensures that it // updates non-fast scroll rects even if there is no layout. - if (ScrollingCoordinator* scrolling_coordinator = - GetDocument().GetPage()->GetScrollingCoordinator()) { + if (GetDocument().GetPage()->GetScrollingCoordinator() != nullptr) { GetFrameView()->GetScrollingContext()->SetScrollGestureRegionIsDirty( true); } --- chromium-70.0.3534.4/third_party/blink/renderer/core/animation/animation_time_delta.h.gcc8 2018-08-28 06:11:07.000000000 +0200 +++ chromium-70.0.3534.4/third_party/blink/renderer/core/animation/animation_time_delta.h 2018-09-03 01:38:14.169583523 +0200 @@ -53,7 +53,7 @@ return AnimationTimeDelta(std::numeric_limits<double>::infinity()); } - double InSecondsF() const { return delta_; } + constexpr double InSecondsF() const { return delta_; } double InMillisecondsF() const { return delta_ * 1000; } bool is_max() const { --- chromium-70.0.3538.22/media/base/audio_processing.cc.gcc8 2018-09-19 21:10:51.000000000 +0200 +++ chromium-70.0.3538.22/media/base/audio_processing.cc 2018-09-23 20:14:22.964158434 +0200 @@ -12,7 +12,7 @@ auto agc_to_string = [](AutomaticGainControlType type) -> const char* { switch (type) { case AutomaticGainControlType::kDisabled: - return "disabled"; + break; case AutomaticGainControlType::kDefault: return "default"; case AutomaticGainControlType::kExperimental: @@ -20,28 +20,31 @@ case AutomaticGainControlType::kHybridExperimental: return "hybrid experimental"; } + return "disabled"; }; auto aec_to_string = [](EchoCancellationType type) -> const char* { switch (type) { case EchoCancellationType::kDisabled: - return "disabled"; + break; case EchoCancellationType::kAec3: return "aec3"; case EchoCancellationType::kSystemAec: return "system aec"; } + return "disabled"; }; auto ns_to_string = [](NoiseSuppressionType type) -> const char* { switch (type) { case NoiseSuppressionType::kDisabled: - return "disabled"; + break; case NoiseSuppressionType::kDefault: return "default"; case NoiseSuppressionType::kExperimental: return "experimental"; } + return "disabled"; }; auto bool_to_yes_no = [](bool b) -> const char* { return b ? "yes" : "no"; }; --- chromium-70.0.3538.22/components/viz/host/gpu_host_impl.cc.gcc8 2018-09-19 21:10:42.000000000 +0200 +++ chromium-70.0.3538.22/components/viz/host/gpu_host_impl.cc 2018-09-23 22:14:53.434515786 +0200 @@ -46,7 +46,6 @@ class FontRenderParams { friend class base::NoDestructor<FontRenderParams>; FontRenderParams(); - ~FontRenderParams(); THREAD_CHECKER(thread_checker_); base::Optional<gfx::FontRenderParams> params_; @@ -66,10 +65,6 @@ const base::Optional<gfx::FontRenderPara FontRenderParams::FontRenderParams() = default; -FontRenderParams::~FontRenderParams() { - NOTREACHED(); -} - FontRenderParams& GetFontRenderParams() { static base::NoDestructor<FontRenderParams> instance; return *instance; --- chromium-70.0.3538.22/third_party/blink/renderer/core/loader/mixed_content_checker.cc.gcc8 2018-09-19 21:11:34.000000000 +0200 +++ chromium-70.0.3538.22/third_party/blink/renderer/core/loader/mixed_content_checker.cc 2018-09-24 02:43:04.295333866 +0200 @@ -238,11 +238,12 @@ bool MixedContentChecker::IsMixedContent const KURL& url) { switch (settings.GetHttpsState()) { case HttpsState::kNone: - return false; + break; case HttpsState::kModern: return IsInsecureUrl(url); } + return false; } // static --- chromium-70.0.3538.22/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.cc.gcc8 2018-09-19 21:11:35.000000000 +0200 +++ chromium-70.0.3538.22/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.cc 2018-09-24 03:31:06.508249594 +0200 @@ -12,14 +12,13 @@ WTF::String OverscrollBehaviorTypeToStri cc::OverscrollBehavior::OverscrollBehaviorType value) { switch (value) { case cc::OverscrollBehavior::kOverscrollBehaviorTypeNone: - return "none"; + break; case cc::OverscrollBehavior::kOverscrollBehaviorTypeAuto: return "auto"; case cc::OverscrollBehavior::kOverscrollBehaviorTypeContain: return "contain"; - default: - NOTREACHED(); } + return "none"; } } // namespace --- chromium-70.0.3538.22/third_party/blink/renderer/platform/mediastream/media_stream_audio_processor_options.cc.gcc8 2018-09-19 21:10:43.000000000 +0200 +++ chromium-70.0.3538.22/third_party/blink/renderer/platform/mediastream/media_stream_audio_processor_options.cc 2018-09-24 03:46:13.701580453 +0200 @@ -89,12 +89,13 @@ AudioProcessingProperties::ToAudioProces [](EchoCancellationType type) -> media::EchoCancellationType { switch (type) { case EchoCancellationType::kEchoCancellationDisabled: - return media::EchoCancellationType::kDisabled; + break; case EchoCancellationType::kEchoCancellationAec3: return media::EchoCancellationType::kAec3; case EchoCancellationType::kEchoCancellationSystem: return media::EchoCancellationType::kSystemAec; } + return media::EchoCancellationType::kDisabled; }; out.echo_cancellation = convert_type(echo_cancellation_type); --- chromium-70.0.3538.22/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc.gcc8 2018-09-19 21:11:35.000000000 +0200 +++ chromium-70.0.3538.22/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc 2018-09-24 22:40:30.244928180 +0200 @@ -5141,10 +5141,6 @@ void WebGLRenderingContextBase::TexImage possible_direct_copy = Extensions3DUtil::CanUseCopyTextureCHROMIUM(target); } - GLint copy_x_offset = xoffset; - GLint copy_y_offset = yoffset; - GLenum copy_target = target; - // if direct copy is not possible, create a temporary texture and then copy // from canvas to temporary texture to target texture. if (!possible_direct_copy) { @@ -5160,9 +5156,6 @@ void WebGLRenderingContextBase::TexImage GL_CLAMP_TO_EDGE); ContextGL()->TexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, width, height, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr); - copy_x_offset = 0; - copy_y_offset = 0; - copy_target = GL_TEXTURE_2D; } {