--- chromium-78.0.3904.9/base/containers/intrusive_heap.h.gcc9 2019-09-12 05:02:49.000000000 +0200
+++ chromium-78.0.3904.9/base/containers/intrusive_heap.h 2019-09-13 06:34:33.055830792 +0200
@@ -458,7 +458,6 @@ class IntrusiveHeap {
// General operations.
void swap(IntrusiveHeap& other) noexcept;
- friend void swap(IntrusiveHeap& lhs, IntrusiveHeap& rhs) { lhs.swap(rhs); }
// Comparison operators. These check for exact equality. Two heaps that are
// semantically equivalent (contain the same elements, but in different
--- chromium-78.0.3904.9/third_party/webrtc/modules/audio_processing/include/audio_processing.cc.gcc9 2019-09-12 05:04:49.000000000 +0200
+++ chromium-78.0.3904.9/third_party/webrtc/modules/audio_processing/include/audio_processing.cc 2019-09-13 06:42:34.564566012 +0200
@@ -28,6 +28,7 @@ std::string NoiseSuppressionLevelToStrin
case AudioProcessing::Config::NoiseSuppression::Level::kVeryHigh:
return "VeryHigh";
}
+ return "";
}
std::string GainController1ModeToString(
@@ -40,6 +41,7 @@ std::string GainController1ModeToString(
case AudioProcessing::Config::GainController1::Mode::kFixedDigital:
return "FixedDigital";
}
+ return "";
}
std::string GainController2LevelEstimatorToString(
@@ -50,6 +52,7 @@ std::string GainController2LevelEstimato
case AudioProcessing::Config::GainController2::LevelEstimator::kPeak:
return "Peak";
}
+ return "";
}
int GetDefaultMaxInternalRate() {
--- chromium-78.0.3904.9/third_party/webrtc/modules/pacing/pacing_controller.cc.gcc9 2019-09-12 05:04:49.000000000 +0200
+++ chromium-78.0.3904.9/third_party/webrtc/modules/pacing/pacing_controller.cc 2019-09-13 06:51:41.591174738 +0200
@@ -66,6 +66,7 @@ int GetPriorityForType(RtpPacketToSend::
// BWE high.
return kFirstPriority + 4;
}
+ return 0;
}
} // namespace
--- chromium-78.0.3904.9/services/resource_coordinator/public/cpp/memory_instrumentation/browser_metrics.cc.gcc9 2019-09-12 05:03:03.000000000 +0200
+++ chromium-78.0.3904.9/services/resource_coordinator/public/cpp/memory_instrumentation/browser_metrics.cc 2019-09-13 06:57:27.286238954 +0200
@@ -42,6 +42,7 @@ const char* HistogramProcessTypeToString
case HistogramProcessType::kUtility:
return kUtilityHistogramName;
}
+ return "";
}
std::string GetPrivateFootprintHistogramName(HistogramProcessType type) {
--- chromium-78.0.3904.9/net/third_party/quiche/src/quic/core/quic_sent_packet_manager.cc.gcc9 2019-09-12 05:04:41.000000000 +0200
+++ chromium-78.0.3904.9/net/third_party/quiche/src/quic/core/quic_sent_packet_manager.cc 2019-09-13 08:21:11.187991663 +0200
@@ -767,6 +767,7 @@ QuicSentPacketManager::OnRetransmissionT
pending_timer_transmission_count_ = max_probe_packets_per_pto_;
return PTO_MODE;
}
+ return RTO_MODE;
}
void QuicSentPacketManager::RetransmitCryptoPackets() {
--- chromium-78.0.3904.9/net/third_party/quiche/src/quic/core/quic_framer.cc.gcc9 2019-09-13 06:18:56.248902492 +0200
+++ chromium-78.0.3904.9/net/third_party/quiche/src/quic/core/quic_framer.cc 2019-09-13 08:34:40.042086705 +0200
@@ -4252,7 +4252,7 @@ bool QuicFramer::ApplyHeaderProtection(E
if (!buffer_reader.ReadUInt8(&type_byte)) {
return false;
}
- QuicLongHeaderType header_type;
+ QuicLongHeaderType header_type = INITIAL;
if (IsLongHeader(type_byte)) {
bitmask = 0x0f;
if (!GetLongHeaderType(type_byte, &header_type)) {
--- chromium-78.0.3904.9/net/dns/dns_util.cc.gcc9 2019-09-13 06:18:56.151904155 +0200
+++ chromium-78.0.3904.9/net/dns/dns_util.cc 2019-09-13 08:59:48.853077608 +0200
@@ -483,6 +483,7 @@ std::string SecureDnsModeToString(
case DnsConfig::SecureDnsMode::SECURE:
return "Secure";
}
+ return "";
}
} // namespace net
--- chromium-78.0.3904.9/chrome/browser/notifications/scheduler/internal/stats.cc.gcc9 2019-09-12 05:02:52.000000000 +0200
+++ chromium-78.0.3904.9/chrome/browser/notifications/scheduler/internal/stats.cc 2019-09-13 09:43:07.414231509 +0200
@@ -32,6 +32,7 @@ std::string ToHistogramSuffix(SchedulerC
case SchedulerClientType::kChromeUpdate:
return "ChromeUpdate";
}
+ return "";
}
// Returns the string representing database type.
@@ -44,6 +45,7 @@ std::string ToDbTypeString(DatabaseType
case DatabaseType::kIconDb:
return "IconDb";
}
+ return "";
}
// Logs a histogram enumeration with client type suffix.
--- chromium-78.0.3904.9/services/media_session/public/cpp/media_session_mojom_traits.cc.gcc9 2019-09-12 05:03:03.000000000 +0200
+++ chromium-78.0.3904.9/services/media_session/public/cpp/media_session_mojom_traits.cc 2019-09-13 10:04:08.453409134 +0200
@@ -78,7 +78,7 @@ bool StructTraits<media_session::mojom::
// Convert the mojo color type into the Skia equivalient. This will tell us
// what format the image is in.
- SkColorType color_type;
+ SkColorType color_type = kUnknown_SkColorType;
switch (data.color_type()) {
case (media_session::mojom::MediaImageBitmapColorType::kRGBA_8888):
color_type = kRGBA_8888_SkColorType;
--- chromium-78.0.3904.9/chrome/browser/sharing/sharing_metrics.cc.gcc9 2019-09-13 06:18:57.499881041 +0200
+++ chromium-78.0.3904.9/chrome/browser/sharing/sharing_metrics.cc 2019-09-14 22:48:59.327541379 +0200
@@ -24,6 +24,7 @@ const char* GetEnumStringValue(SharingFe
case SharingFeatureName::kSharedClipboard:
return "SharedClipboard";
}
+ return "";
}
// Maps SharingChannelType enum values to strings used as histogram
--- chromium-78.0.3904.9/chrome/browser/sharing/sharing_fcm_sender.cc.gcc9 2019-09-12 05:02:52.000000000 +0200
+++ chromium-78.0.3904.9/chrome/browser/sharing/sharing_fcm_sender.cc 2019-09-14 23:11:42.407491637 +0200
@@ -202,7 +202,7 @@ void SharingFCMSender::OnMessageSentToVa
TRACE_EVENT1("sharing", "SharingFCMSender::OnMessageSentToVapidTarget",
"result", result);
- SharingSendMessageResult send_message_result;
+ SharingSendMessageResult send_message_result = SharingSendMessageResult::kInternalError;
switch (result) {
case SendWebPushMessageResult::kSuccessful:
send_message_result = SharingSendMessageResult::kSuccessful;
@@ -294,7 +294,7 @@ void SharingFCMSender::OnMessageSentViaS
TRACE_EVENT1("sharing", "SharingFCMSender::OnMessageSentViaSync", "error",
error.error_code());
- SharingSendMessageResult send_message_result;
+ SharingSendMessageResult send_message_result = SharingSendMessageResult::kInternalError;
switch (error.error_code()) {
case sync_pb::SharingMessageCommitError::NONE:
send_message_result = SharingSendMessageResult::kSuccessful;
--- chromium-78.0.3904.9/chrome/browser/renderer_context_menu/render_view_context_menu.cc.gcc9 2019-09-12 05:02:52.000000000 +0200
+++ chromium-78.0.3904.9/chrome/browser/renderer_context_menu/render_view_context_menu.cc 2019-09-14 23:46:10.685218857 +0200
@@ -1851,7 +1851,7 @@ void RenderViewContextMenu::AppendSharin
}
void RenderViewContextMenu::AppendClickToCallItem() {
- SharingClickToCallEntryPoint entry_point;
+ SharingClickToCallEntryPoint entry_point = SharingClickToCallEntryPoint::kLeftClickLink;
base::Optional<std::string> phone_number;
std::string selection_text;
if (ShouldOfferClickToCallForURL(browser_context_, params_.link_url)) {
--- chromium-78.0.3904.9/chrome/browser/sharing/sharing_ui_controller.cc.gcc9 2019-09-12 05:02:52.000000000 +0200
+++ chromium-78.0.3904.9/chrome/browser/sharing/sharing_ui_controller.cc 2019-09-15 00:04:24.265455989 +0200
@@ -70,6 +70,7 @@ base::string16 SharingUiController::GetT
IDS_BROWSER_SHARING_ERROR_DIALOG_TITLE_INTERNAL_ERROR,
base::ToLowerASCII(GetContentType()));
}
+ return base::string16();
}
base::string16 SharingUiController::GetErrorDialogText() const {
@@ -96,6 +97,7 @@ base::string16 SharingUiController::GetE
return l10n_util::GetStringUTF16(
IDS_BROWSER_SHARING_ERROR_DIALOG_TEXT_INTERNAL_ERROR);
}
+ return base::string16();
}
void SharingUiController::OnDialogClosed(SharingDialog* dialog) {
--- chromium-78.0.3904.9/chrome/browser/ui/browser.cc.gcc9 2019-09-12 05:02:53.000000000 +0200
+++ chromium-78.0.3904.9/chrome/browser/ui/browser.cc 2019-09-15 00:33:09.871856801 +0200
@@ -2620,6 +2620,7 @@ bool Browser::NormalBrowserSupportsWindo
case FEATURE_NONE:
return false;
}
+ return false;
}
bool Browser::PopupBrowserSupportsWindowFeature(WindowFeature feature,
@@ -2639,6 +2640,7 @@ bool Browser::PopupBrowserSupportsWindow
case FEATURE_NONE:
return false;
}
+ return false;
}
bool Browser::LegacyAppBrowserSupportsWindowFeature(
@@ -2681,6 +2683,7 @@ bool Browser::WebAppBrowserSupportsWindo
case FEATURE_NONE:
return false;
}
+ return false;
}
bool Browser::SupportsWindowFeatureImpl(WindowFeature feature,
@@ -2699,6 +2702,7 @@ bool Browser::SupportsWindowFeatureImpl(
case TYPE_DEVTOOLS:
return LegacyAppBrowserSupportsWindowFeature(feature, check_can_support);
}
+ return false;
}
void Browser::UpdateBookmarkBarState(BookmarkBarStateChangeReason reason) {
--- chromium-78.0.3904.9/chrome/browser/ui/webui/settings/settings_security_key_handler.cc.gcc9 2019-09-12 05:02:53.000000000 +0200
+++ chromium-78.0.3904.9/chrome/browser/ui/webui/settings/settings_security_key_handler.cc 2019-09-15 00:47:54.298505301 +0200
@@ -489,7 +489,7 @@ void SecurityKeysCredentialHandler::OnFi
device::CredentialManagementStatus status) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- int error;
+ int error = 0;
switch (status) {
case device::CredentialManagementStatus::kSoftPINBlock:
@@ -602,7 +602,7 @@ void SecurityKeysBioEnrollmentHandler::O
DCHECK_CURRENTLY_ON(BrowserThread::UI);
state_ = State::kNone;
- int error;
+ int error = 0;
switch (status) {
case device::BioEnrollmentStatus::kSoftPINBlock:
error = IDS_SETTINGS_SECURITY_KEYS_PIN_SOFT_LOCK;
--- chromium-78.0.3904.9/chrome/browser/ui/views/hats/hats_bubble_view.cc.gcc9 2019-09-12 05:02:53.000000000 +0200
+++ chromium-78.0.3904.9/chrome/browser/ui/views/hats/hats_bubble_view.cc 2019-09-15 01:18:25.927685733 +0200
@@ -49,6 +49,7 @@ HatsBubbleView::BubbleUsageCounts Bubble
case views::Widget::ClosedReason::kAcceptButtonClicked:
return HatsBubbleView::BubbleUsageCounts::kAccepted;
}
+ return HatsBubbleView::BubbleUsageCounts::kIgnored;
}
} // namespace
--- chromium-78.0.3904.9/chrome/browser/ui/views/location_bar/cookie_controls_icon_view.cc.gcc9 2019-09-12 05:02:53.000000000 +0200
+++ chromium-78.0.3904.9/chrome/browser/ui/views/location_bar/cookie_controls_icon_view.cc 2019-09-15 02:01:37.649680383 +0200
@@ -53,7 +53,7 @@ void CookieControlsIconView::OnStatusCha
void CookieControlsIconView::OnBlockedCookiesCountChanged(int blocked_cookies) {
// The blocked cookie count changes quite frequently, so avoid unnecessary
// UI updates.
- if (has_blocked_cookies_ != blocked_cookies > 0) {
+ if (has_blocked_cookies_ != (blocked_cookies > 0)) {
has_blocked_cookies_ = blocked_cookies > 0;
SetVisible(ShouldBeVisible());
}
--- chromium-78.0.3904.9/chrome/browser/ui/views/passwords/password_items_view.cc.gcc9 2019-09-12 05:02:53.000000000 +0200
+++ chromium-78.0.3904.9/chrome/browser/ui/views/passwords/password_items_view.cc 2019-09-15 02:11:05.057900134 +0200
@@ -149,8 +149,8 @@ std::unique_ptr<views::Label> CreatePass
: l10n_util::GetStringFUTF16(federation_message_id,
GetDisplayFederation(form));
int text_style = form.federation_origin.opaque()
- ? STYLE_SECONDARY_MONOSPACED
- : views::style::STYLE_SECONDARY;
+ ? int(STYLE_SECONDARY_MONOSPACED)
+ : int(views::style::STYLE_SECONDARY);
auto label =
std::make_unique<views::Label>(text, CONTEXT_BODY_TEXT_LARGE, text_style);
label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
--- chromium-78.0.3904.9/chrome/browser/vr/service/browser_xr_runtime.cc.gcc9 2019-09-12 05:02:53.000000000 +0200
+++ chromium-78.0.3904.9/chrome/browser/vr/service/browser_xr_runtime.cc 2019-09-15 03:06:32.747599503 +0200
@@ -272,6 +272,7 @@ bool BrowserXRRuntime::SupportsFeature(
}
NOTREACHED();
+ return false;
}
bool BrowserXRRuntime::SupportsAllFeatures(
@@ -311,6 +312,7 @@ bool BrowserXRRuntime::SupportsCustomIPD
}
NOTREACHED();
+ return false;
}
bool BrowserXRRuntime::SupportsNonEmulatedHeight() const {
@@ -337,6 +339,7 @@ bool BrowserXRRuntime::SupportsNonEmulat
}
NOTREACHED();
+ return false;
}
void BrowserXRRuntime::OnDisplayInfoChanged(
--- chromium-78.0.3904.9/components/optimization_guide/hints_processing_util.cc.gcc9 2019-09-12 05:02:56.000000000 +0200
+++ chromium-78.0.3904.9/components/optimization_guide/hints_processing_util.cc 2019-09-15 03:48:01.659376926 +0200
@@ -108,6 +108,7 @@ net::EffectiveConnectionType ConvertProt
case proto::EffectiveConnectionType::EFFECTIVE_CONNECTION_TYPE_4G:
return net::EffectiveConnectionType::EFFECTIVE_CONNECTION_TYPE_4G;
}
+ return net::EffectiveConnectionType::EFFECTIVE_CONNECTION_TYPE_UNKNOWN;
}
bool IsValidURLForURLKeyedHint(const GURL& url) {
--- chromium-78.0.3904.9/components/password_manager/core/browser/password_manager_metrics_util.cc.gcc9 2019-09-12 05:02:56.000000000 +0200
+++ chromium-78.0.3904.9/components/password_manager/core/browser/password_manager_metrics_util.cc 2019-09-15 03:54:20.934800684 +0200
@@ -69,6 +69,7 @@ void LogLeakDialogTypeAndDismissalReason
case LeakDialogType::kCheckupAndChange:
return "CheckupAndChange";
}
+ return "";
};
base::UmaHistogramEnumeration(kHistogram, reason);
--- chromium-78.0.3904.9/content/browser/bluetooth/web_bluetooth_service_impl.cc.gcc9 2019-09-12 05:02:57.000000000 +0200
+++ chromium-78.0.3904.9/content/browser/bluetooth/web_bluetooth_service_impl.cc 2019-09-15 04:19:46.399378071 +0200
@@ -277,6 +277,8 @@
case ContentBrowserClient::AllowWebBluetoothResult::ALLOW:
return blink::mojom::WebBluetoothResult::SUCCESS;
}
+ return blink::mojom::WebBluetoothResult::
+ CHOOSER_NOT_SHOWN_API_GLOBALLY_DISABLED;
}
bool WebBluetoothServiceImpl::IsDevicePaired(
--- chromium-78.0.3904.9/content/browser/frame_host/origin_policy_throttle.cc.gcc9 2019-09-12 05:02:57.000000000 +0200
+++ chromium-78.0.3904.9/content/browser/frame_host/origin_policy_throttle.cc 2019-09-15 04:46:52.770724032 +0200
@@ -116,6 +116,7 @@ OriginPolicyThrottle::WillProcessRespons
case network::OriginPolicyState::kLoaded:
return NavigationThrottle::PROCEED;
}
+ return NavigationThrottle::CANCEL;
}
const char* OriginPolicyThrottle::GetNameForLogging() {
--- chromium-78.0.3904.9/content/browser/indexed_db/indexed_db_connection_coordinator.cc.gcc9 2019-09-12 05:02:57.000000000 +0200
+++ chromium-78.0.3904.9/content/browser/indexed_db/indexed_db_connection_coordinator.cc 2019-09-15 05:05:28.812910635 +0200
@@ -630,6 +630,7 @@ IndexedDBConnectionCoordinator::ExecuteT
}
}
NOTREACHED();
+ return {ExecuteTaskResult::kError, leveldb::Status::OK()};
}
size_t IndexedDBConnectionCoordinator::ActiveOpenDeleteCount() const {
--- chromium-78.0.3904.9/components/services/storage/indexed_db/transactional_leveldb/transactional_leveldb_iterator.cc.gcc9 2019-09-12 05:02:57.000000000 +0200
+++ chromium-78.0.3904.9/components/services/storage/indexed_db/transactional_leveldb/transactional_leveldb_iterator.cc 2019-09-15 06:00:27.500296280 +0200
@@ -77,6 +77,7 @@ bool TransactionalLevelDBIterator::IsVal
return iterator_->Valid();
}
NOTREACHED();
+ return false;
}
leveldb::Status TransactionalLevelDBIterator::SeekToLast() {
--- chromium-78.0.3904.9/content/browser/service_worker/service_worker_single_script_update_checker.cc.gcc9 2019-09-12 05:02:57.000000000 +0200
+++ chromium-78.0.3904.9/content/browser/service_worker/service_worker_single_script_update_checker.cc 2019-09-15 06:53:27.491440978 +0200
@@ -419,6 +419,7 @@ const char* ServiceWorkerSingleScriptUpd
case Result::kDifferent:
return "Different";
}
+ return "";
}
//------------------------------------------------------------------------------
--- chromium-78.0.3904.9/ui/views/animation/installable_ink_drop_animator.cc.gcc9 2019-09-12 05:03:27.000000000 +0200
+++ chromium-78.0.3904.9/ui/views/animation/installable_ink_drop_animator.cc 2019-09-15 07:18:55.716429661 +0200
@@ -157,6 +157,7 @@ base::TimeDelta InstallableInkDropAnimat
case SubAnimation::kDeactivatedFadeOut:
return base::TimeDelta::FromMilliseconds(300);
}
+ return base::TimeDelta::FromMilliseconds(0);
}
void InstallableInkDropAnimator::StartSubAnimation(SubAnimation sub_animation) {
--- chromium-78.0.3904.9/third_party/blink/renderer/platform/heap/persistent.h.gcc9 2019-09-12 05:03:06.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/platform/heap/persistent.h 2019-09-15 08:13:44.684863499 +0200
@@ -279,7 +279,6 @@ class PersistentBase {
NO_SANITIZE_ADDRESS
void AssignSafe(T* ptr) {
- typename PersistentMutexTraits<crossThreadnessConfiguration>::Locker lock;
AssignUnsafe(ptr);
}
@@ -320,7 +319,6 @@ class PersistentBase {
TraceCallback trace_callback =
TraceMethodDelegate<PersistentBase,
&PersistentBase::TracePersistent>::Trampoline;
- typename PersistentMutexTraits<crossThreadnessConfiguration>::Locker lock;
persistent_node_.Initialize(this, trace_callback);
}
@@ -338,7 +336,6 @@ class PersistentBase {
void UninitializeSafe() {
if (persistent_node_.IsInitialized()) {
- typename PersistentMutexTraits<crossThreadnessConfiguration>::Locker lock;
persistent_node_.Uninitialize();
}
}
--- chromium-78.0.3904.9/third_party/blink/renderer/core/layout/ng/table/interface_casting.h.gcc9 2019-09-12 05:03:05.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/core/layout/ng/table/interface_casting.h 2019-09-15 08:49:45.180187945 +0200
@@ -54,6 +54,7 @@ struct InterfaceDowncastTraits {
template <typename U>
static bool AllowFrom(const U&) {
static_assert(sizeof(U) == 0, "no downcast traits specialization for T");
+ return false;
}
template <typename U>
static const T& ConvertFrom(const U&) {
--- chromium-78.0.3904.9/third_party/blink/renderer/build/scripts/core/css/templates/css_property_names.cc.tmpl.gcc9 2019-09-12 05:03:04.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/build/scripts/core/css/templates/css_property_names.cc.tmpl 2019-09-15 09:19:05.018380750 +0200
@@ -63,6 +63,7 @@ mojom::blink::CSSSampleId GetCSSSampleId
}
NOTREACHED();
+ return mojom::blink::CSSSampleId::kInvalid;
}
} // namespace blink
--- chromium-78.0.3904.9/third_party/blink/renderer/core/accessibility/apply_dark_mode.cc.gcc9 2019-09-13 06:18:56.211903126 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/core/accessibility/apply_dark_mode.cc 2019-09-15 10:14:35.061271782 +0200
@@ -57,6 +57,7 @@ DarkModeInversionAlgorithm GetMode(const
case ForceDarkInversionMethod::kRgbBased:
return DarkModeInversionAlgorithm::kInvertBrightness;
}
+ return DarkModeInversionAlgorithm::kOff;
}
DarkModeImagePolicy GetImagePolicy(const Settings& frame_settings) {
@@ -68,6 +69,7 @@ DarkModeImagePolicy GetImagePolicy(const
case ForceDarkImageBehavior::kInvertSelectively:
return DarkModeImagePolicy::kFilterSmart;
}
+ return DarkModeImagePolicy::kFilterNone;
}
int GetTextBrightnessThreshold(const Settings& frame_settings) {
--- chromium-78.0.3904.9/third_party/blink/renderer/core/css/css_math_expression_node.cc.gcc9 2019-09-12 05:03:04.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/core/css/css_math_expression_node.cc 2019-09-15 10:20:53.990694348 +0200
@@ -731,8 +731,8 @@ CSSMathExpressionVariadicOperation* CSSM
DCHECK(op == CSSMathOperator::kMin || op == CSSMathOperator::kMax);
DCHECK(operands.size());
bool is_first = true;
- CalculationCategory category;
- bool is_integer;
+ CalculationCategory category = kCalcNumber;
+ bool is_integer = false;
for (const auto& operand : operands) {
if (is_first) {
category = operand->Category();
--- chromium-78.0.3904.9/third_party/blink/renderer/core/layout/flexible_box_algorithm.cc.gcc9 2019-09-12 05:03:05.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/core/layout/flexible_box_algorithm.cc 2019-09-15 10:56:58.653566388 +0200
@@ -50,6 +50,7 @@ ItemPosition BoxAlignmentToItemPosition(
case EBoxAlignment::kEnd:
return ItemPosition::kFlexEnd;
}
+ return ItemPosition::kBaseline;
}
ContentPosition BoxPackToContentPosition(EBoxPack box_pack) {
@@ -63,6 +64,7 @@ ContentPosition BoxPackToContentPosition
case EBoxPack::kEnd:
return ContentPosition::kFlexEnd;
}
+ return ContentPosition::kCenter;
}
ContentDistributionType BoxPackToContentDistribution(EBoxPack box_pack) {
--- chromium-78.0.3904.9/third_party/blink/renderer/core/layout/ng/ng_floats_utils.cc.gcc9 2019-09-12 05:03:05.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/core/layout/ng/ng_floats_utils.cc 2019-09-15 11:18:43.934373144 +0200
@@ -280,8 +280,7 @@ NGPositionedFloat PositionFloat(NGUnposi
break;
} while (true);
- if (const NGBreakToken* break_token =
- layout_result->PhysicalFragment().BreakToken())
+ if (layout_result->PhysicalFragment().BreakToken())
fragment_margins.block_end = LayoutUnit();
}
--- chromium-78.0.3904.9/third_party/blink/renderer/core/paint/ng/ng_paint_fragment_traversal.cc.gcc9 2019-09-12 05:03:05.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/core/paint/ng/ng_paint_fragment_traversal.cc 2019-09-15 11:37:07.874597294 +0200
@@ -86,7 +86,7 @@ void NGPaintFragmentTraversal::MoveToNex
if (IsAtEnd())
return;
- if (const NGPaintFragment* first_child = current_->FirstChild())
+ if (current_->FirstChild())
return MoveToFirstChild();
MoveToNextSiblingOrAncestor();
}
--- chromium-78.0.3904.9/third_party/blink/renderer/core/paint/theme_painter.cc.gcc9 2019-09-12 05:03:05.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/core/paint/theme_painter.cc 2019-09-15 11:52:42.231793277 +0200
@@ -71,6 +71,7 @@ static ui::NativeTheme::ColorScheme ToNa
case WebColorScheme::kDark:
return ui::NativeTheme::ColorScheme::kDark;
}
+ return ui::NativeTheme::ColorScheme::kLight;
}
bool IsTemporalInput(const AtomicString& type) {
--- chromium-78.0.3904.9/third_party/blink/renderer/core/script/modulator_impl_base.cc.gcc9 2019-09-13 06:18:56.212903109 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/core/script/modulator_impl_base.cc 2019-09-15 12:00:22.326982077 +0200
@@ -97,6 +97,7 @@ bool ModulatorImplBase::BuiltInModuleReq
case layered_api::Module::kKvStorage:
return true;
}
+ return false;
}
void ModulatorImplBase::BuiltInModuleUseCount(
--- chromium-78.0.3904.9/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.cc.gcc9 2019-09-12 05:03:05.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.cc 2019-09-15 12:19:35.044362924 +0200
@@ -207,6 +207,7 @@ String getTrustedTypeName(SpecificTruste
case SpecificTrustedType::kNone:
return String();
}
+ return String();
}
typedef bool (*PropertyEqualsFn)(decltype(*kTypeTable)&,
--- chromium-78.0.3904.9/third_party/blink/renderer/modules/serial/serial_port.cc.gcc9 2019-09-12 05:03:06.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/modules/serial/serial_port.cc 2019-09-15 12:56:18.558778000 +0200
@@ -59,6 +59,7 @@ DOMException* DOMExceptionFromSendError(
return MakeGarbageCollected<DOMException>(DOMExceptionCode::kUnknownError,
kSystemError);
}
+ return nullptr;
}
bool ReceiveErrorIsFatal(SerialReceiveError error) {
@@ -103,6 +104,7 @@ DOMException* DOMExceptionFromReceiveErr
return MakeGarbageCollected<DOMException>(DOMExceptionCode::kUnknownError,
kSystemError);
}
+ return nullptr;
}
// A ScriptFunction that calls ContinueClose() on the provided SerialPort.
--- chromium-78.0.3904.9/third_party/blink/renderer/modules/xr/xr.cc.gcc9 2019-09-12 05:03:06.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/modules/xr/xr.cc 2019-09-15 13:12:45.635911725 +0200
@@ -154,6 +154,7 @@ bool IsFeatureValidForMode(device::mojom
}
return true;
}
+ return false;
}
bool HasRequiredFeaturePolicy(const Document* doc,
@@ -173,6 +174,7 @@ bool HasRequiredFeaturePolicy(const Docu
return doc->IsFeatureEnabled(mojom::blink::FeaturePolicyFeature::kWebXr,
ReportOptions::kReportOnFailure);
}
+ return false;
}
// Ensure that the immersive session request is allowed, if not
--- chromium-78.0.3904.9/third_party/blink/renderer/platform/geometry/calculation_value.cc.gcc9 2019-09-12 05:03:06.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/platform/geometry/calculation_value.cc 2019-09-15 13:46:22.767390268 +0200
@@ -45,8 +45,8 @@ CalculationValue::~CalculationValue() {
}
float CalculationValue::Evaluate(float max_value) const {
- float value = is_expression_ ? value = data_.expression->Evaluate(max_value)
- : value = Pixels() + Percent() / 100 * max_value;
+ float value = is_expression_ ? data_.expression->Evaluate(max_value)
+ : Pixels() + Percent() / 100 * max_value;
return (IsNonNegative() && value < 0) ? 0 : value;
}
--- chromium-78.0.3904.9/third_party/blink/renderer/platform/geometry/calculation_expression_node.cc.gcc9 2019-09-12 05:03:06.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/platform/geometry/calculation_expression_node.cc 2019-09-15 13:47:21.671379840 +0200
@@ -118,7 +118,7 @@ CalculationExpressionComparisonNode::Cre
Vector<scoped_refptr<const CalculationExpressionNode>>&& operands,
Type type) {
DCHECK(operands.size());
- float simplified_px;
+ float simplified_px = .0f;
bool can_simplify = true;
for (wtf_size_t i = 0; i < operands.size(); ++i) {
const auto* leaf = DynamicTo<CalculationExpressionLeafNode>(*operands[i]);
--- chromium-78.0.3904.9/third_party/blink/renderer/platform/graphics/dark_mode_filter.cc.gcc9 2019-09-12 05:03:06.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/platform/graphics/dark_mode_filter.cc 2019-09-15 13:54:17.125254187 +0200
@@ -48,7 +48,7 @@ bool ShouldApplyToImage(const DarkModeSe
Image* image) {
switch (settings.image_policy) {
case DarkModeImagePolicy::kFilterSmart: {
- DarkModeImageClassifier* classifier;
+ DarkModeImageClassifier* classifier = nullptr;
switch (settings.classifier_type) {
case DarkModeClassifierType::kIcon: {
DarkModeIconClassifier icon_classifier;
@@ -69,6 +69,7 @@ bool ShouldApplyToImage(const DarkModeSe
case DarkModeImagePolicy::kFilterAll:
return true;
}
+ return false;
}
// TODO(gilmanmh): If grayscaling images in dark mode proves popular among
--- chromium-78.0.3904.21/chrome/browser/resource_coordinator/tab_ranker/pairwise_inference.cc.gcc9 2019-09-19 20:50:27.000000000 +0200
+++ chromium-78.0.3904.21/chrome/browser/resource_coordinator/tab_ranker/pairwise_inference.cc 2019-09-22 16:25:52.738825612 +0200
@@ -58,12 +58,11 @@ void FullyConnected(const int32_t* __res
template <typename T>
void Relu(const int32_t rank,
const int32_t* __restrict input_shape,
- const T* __restrict input_values,
- T* __restrict output_values) {
+ T* __restrict values) {
const int32_t size = ShapeSize(rank, input_shape);
for (int32_t i = 0; i < size; ++i) {
- const T value = input_values[i];
- output_values[i] = std::max(value, static_cast<T>(0));
+ const T value = values[i];
+ values[i] = std::max(value, static_cast<T>(0));
}
}
@@ -1980,7 +1979,7 @@ void Inference(const float* __restrict f
// dnn/hiddenlayer_0/hiddenlayer_0/Relu
Relu<float>(2, // rank
- fixed->shape0, fixed->alloc1, fixed->alloc1);
+ fixed->shape0, fixed->alloc1);
// dnn/logits/MatMul_merged_with_dnn/logits/BiasAdd
FullyConnected<float>(
--- chromium-78.0.3904.70/sandbox/linux/seccomp-bpf/syscall.cc.gcc9 2019-10-21 21:06:39.000000000 +0200
+++ chromium-78.0.3904.70/sandbox/linux/seccomp-bpf/syscall.cc 2019-10-28 21:14:17.697737345 +0100
@@ -371,7 +371,7 @@ intptr_t Syscall::Call(int nr,
// N.B. These are not the calling conventions normally used by the ABI.
: "=a"(ret)
: "0"(ret), "D"(args)
- : "cc", "esp", "memory", "ecx", "edx");
+ : "cc", "memory", "ecx", "edx");
#elif defined(__x86_64__)
intptr_t ret = SyscallAsm(nr, args);
#elif defined(__arm__)
--- chromium-78.0.3904.70/third_party/lss/linux_syscall_support.h.gcc9 2019-10-21 21:09:13.000000000 +0200
+++ chromium-78.0.3904.70/third_party/lss/linux_syscall_support.h 2019-10-28 21:48:02.994115094 +0100
@@ -1955,7 +1955,7 @@ struct kernel_statfs {
LSS_ENTRYPOINT \
"pop %%ebx" \
args \
- : "esp", "memory"); \
+ : "memory"); \
LSS_RETURN(type,__res)
#undef _syscall0
#define _syscall0(type,name) \
@@ -2012,7 +2012,7 @@ struct kernel_statfs {
: "i" (__NR_##name), "ri" ((long)(arg1)), \
"c" ((long)(arg2)), "d" ((long)(arg3)), \
"S" ((long)(arg4)), "D" ((long)(arg5)) \
- : "esp", "memory"); \
+ : "memory"); \
LSS_RETURN(type,__res); \
}
#undef _syscall6
@@ -2034,7 +2034,7 @@ struct kernel_statfs {
: "i" (__NR_##name), "0" ((long)(&__s)), \
"c" ((long)(arg2)), "d" ((long)(arg3)), \
"S" ((long)(arg4)), "D" ((long)(arg5)) \
- : "esp", "memory"); \
+ : "memory"); \
LSS_RETURN(type,__res); \
}
LSS_INLINE int LSS_NAME(clone)(int (*fn)(void *), void *child_stack,
@@ -2120,7 +2120,7 @@ struct kernel_statfs {
: "0"(-EINVAL), "i"(__NR_clone),
"m"(fn), "m"(child_stack), "m"(flags), "m"(arg),
"m"(parent_tidptr), "m"(newtls), "m"(child_tidptr)
- : "esp", "memory", "ecx", "edx", "esi", "edi");
+ : "memory", "ecx", "edx", "esi", "edi");
LSS_RETURN(int, __res);
}
--- chromium-78.0.3904.70/third_party/tcmalloc/vendor/src/base/linux_syscall_support.h.gcc9 2019-10-21 21:07:26.000000000 +0200
+++ chromium-78.0.3904.70/third_party/tcmalloc/vendor/src/base/linux_syscall_support.h 2019-10-28 22:00:44.319641968 +0100
@@ -1066,7 +1066,7 @@ struct kernel_stat {
"pop %%ebx\n" \
CFI_ADJUST_CFA_OFFSET(-4) \
args \
- : "esp", "memory"); \
+ : "memory"); \
LSS_RETURN(type,__res)
#undef _syscall0
#define _syscall0(type,name) \
@@ -1123,7 +1123,7 @@ struct kernel_stat {
: "i" (__NR_##name), "ri" ((long)(arg1)), \
"c" ((long)(arg2)), "d" ((long)(arg3)), \
"S" ((long)(arg4)), "D" ((long)(arg5)) \
- : "esp", "memory"); \
+ : "memory"); \
LSS_RETURN(type,__res); \
}
#undef _syscall6
@@ -1145,7 +1145,7 @@ struct kernel_stat {
: "i" (__NR_##name), "0" ((long)(&__s)), \
"c" ((long)(arg2)), "d" ((long)(arg3)), \
"S" ((long)(arg4)), "D" ((long)(arg5)) \
- : "esp", "memory"); \
+ : "memory"); \
LSS_RETURN(type,__res); \
}
LSS_INLINE int LSS_NAME(clone)(int (*fn)(void *), void *child_stack,
@@ -1231,7 +1231,7 @@ struct kernel_stat {
: "0"(-EINVAL), "i"(__NR_clone),
"m"(fn), "m"(child_stack), "m"(flags), "m"(arg),
"m"(parent_tidptr), "m"(newtls), "m"(child_tidptr)
- : "esp", "memory", "ecx", "edx", "esi", "edi");
+ : "memory", "ecx", "edx", "esi", "edi");
LSS_RETURN(int, __res);
}
--- chromium-78.0.3904.70/third_party/tcmalloc/chromium/src/base/linux_syscall_support.h.gcc9 2019-10-21 21:07:26.000000000 +0200
+++ chromium-78.0.3904.70/third_party/tcmalloc/chromium/src/base/linux_syscall_support.h 2019-10-28 22:01:10.371213784 +0100
@@ -1067,7 +1067,7 @@ struct kernel_stat {
"pop %%ebx\n" \
CFI_ADJUST_CFA_OFFSET(-4) \
args \
- : "esp", "memory"); \
+ : "memory"); \
LSS_RETURN(type,__res)
#undef _syscall0
#define _syscall0(type,name) \
@@ -1124,7 +1124,7 @@ struct kernel_stat {
: "i" (__NR_##name), "ri" ((long)(arg1)), \
"c" ((long)(arg2)), "d" ((long)(arg3)), \
"S" ((long)(arg4)), "D" ((long)(arg5)) \
- : "esp", "memory"); \
+ : "memory"); \
LSS_RETURN(type,__res); \
}
#undef _syscall6
@@ -1146,7 +1146,7 @@ struct kernel_stat {
: "i" (__NR_##name), "0" ((long)(&__s)), \
"c" ((long)(arg2)), "d" ((long)(arg3)), \
"S" ((long)(arg4)), "D" ((long)(arg5)) \
- : "esp", "memory"); \
+ : "memory"); \
LSS_RETURN(type,__res); \
}
LSS_INLINE int LSS_NAME(clone)(int (*fn)(void *), void *child_stack,
@@ -1232,7 +1232,7 @@ struct kernel_stat {
: "0"(-EINVAL), "i"(__NR_clone),
"m"(fn), "m"(child_stack), "m"(flags), "m"(arg),
"m"(parent_tidptr), "m"(newtls), "m"(child_tidptr)
- : "esp", "memory", "ecx", "edx", "esi", "edi");
+ : "memory", "ecx", "edx", "esi", "edi");
LSS_RETURN(int, __res);
}
--- chromium-78.0.3904.70/v8/src/diagnostics/ia32/disasm-ia32.cc.gcc9 2019-10-21 21:09:21.000000000 +0200
+++ chromium-78.0.3904.70/v8/src/diagnostics/ia32/disasm-ia32.cc 2019-10-29 20:20:31.149741601 +0100
@@ -543,7 +543,7 @@ int DisassemblerIA32::F7Instruction(byte
byte modrm = *++data;
int mod, regop, rm;
get_modrm(modrm, &mod, ®op, &rm);
- const char* mnem = nullptr;
+ const char* mnem = "???";
switch (regop) {
case 0:
mnem = "test";
distrib
>
Mageia
>
7
>
i586
>
media
>
core-updates-src
>
by-pkgid
>
7bd852dfb0052e5fd697b7e8e3fd46c5
>
files
>
42
