--- chromium-72.0.3626.81/base/task/common/operations_controller.cc.gcc8 2019-01-30 02:17:39.000000000 +0100
+++ chromium-72.0.3626.81/base/task/common/operations_controller.cc 2019-02-02 14:38:56.245706064 +0100
@@ -49,13 +49,14 @@ OperationsController::OperationToken Ope
switch (ExtractState(prev_value)) {
case State::kRejectingOperations:
- return OperationToken(nullptr);
+ break;
case State::kAcceptingOperations:
return OperationToken(this);
case State::kShuttingDown:
DecrementBy(1);
- return OperationToken(nullptr);
+ break;
}
+ return OperationToken(nullptr);
}
void OperationsController::ShutdownAndWaitForZeroOperations() {
@@ -105,4 +106,4 @@ void OperationsController::DecrementBy(u
}
} // namespace internal
-} // namespace base
\ No newline at end of file
+} // namespace base
--- chromium-72.0.3626.81/third_party/webrtc/modules/video_coding/codecs/vp8/temporal_layers_checker.cc.gcc8 2019-01-30 02:20:38.000000000 +0100
+++ chromium-72.0.3626.81/third_party/webrtc/modules/video_coding/codecs/vp8/temporal_layers_checker.cc 2019-02-02 17:09:48.090494775 +0100
@@ -27,6 +27,7 @@ TemporalLayersChecker::CreateTemporalLay
// Conference mode temporal layering for screen content in base stream.
return absl::make_unique<TemporalLayersChecker>(num_temporal_layers);
}
+ return nullptr;
}
TemporalLayersChecker::TemporalLayersChecker(int num_temporal_layers)
--- chromium-72.0.3626.81/media/base/decode_status.cc.gcc8 2019-01-30 02:18:05.000000000 +0100
+++ chromium-72.0.3626.81/media/base/decode_status.cc 2019-02-02 19:45:42.314497146 +0100
@@ -19,6 +19,7 @@ const char* GetDecodeStatusString(Decode
case DecodeStatus::DECODE_ERROR:
return "DecodeStatus::DECODE_ERROR";
}
+ return "";
}
std::ostream& operator<<(std::ostream& os, const DecodeStatus& status) {
--- chromium-72.0.3626.81/media/base/decryptor.cc.gcc8 2019-01-30 02:18:05.000000000 +0100
+++ chromium-72.0.3626.81/media/base/decryptor.cc 2019-02-02 20:42:21.387394890 +0100
@@ -16,8 +16,9 @@ const char* Decryptor::GetStatusName(Sta
case kNeedMoreData:
return "need_more_data";
case kError:
- return "error";
+ break;
}
+ return "error";
}
Decryptor::Decryptor() = default;
--- chromium-72.0.3626.81/media/base/demuxer_stream.cc.gcc8 2019-01-30 02:18:05.000000000 +0100
+++ chromium-72.0.3626.81/media/base/demuxer_stream.cc 2019-02-02 21:00:32.673023251 +0100
@@ -16,8 +16,9 @@ const char* DemuxerStream::GetTypeName(T
case DemuxerStream::TEXT:
return "text";
case DemuxerStream::UNKNOWN:
- return "unknown";
+ break;
}
+ return "unknown";
}
// static
@@ -30,8 +31,9 @@ const char* DemuxerStream::GetStatusName
case DemuxerStream::kConfigChanged:
return "config_changed";
case DemuxerStream::kError:
- return "error";
+ break;
}
+ return "error";
}
DemuxerStream::~DemuxerStream() = default;
--- chromium-72.0.3626.81/ui/gfx/skia_vector_animation.cc.gcc8 2019-01-30 02:18:54.000000000 +0100
+++ chromium-72.0.3626.81/ui/gfx/skia_vector_animation.cc 2019-02-02 21:16:25.546267497 +0100
@@ -143,7 +143,7 @@
float SkiaVectorAnimation::GetCurrentProgress() const {
switch (state_) {
case PlayState::kStopped:
- return 0;
+ break;
case PlayState::kEnded:
DCHECK(timer_control_);
return timer_control_->GetNormalizedEndOffset();
@@ -164,6 +164,7 @@
DCHECK(timer_control_);
return timer_control_->GetNormalizedCurrentCycleProgress();
}
+ return 0;
}
void SkiaVectorAnimation::Paint(gfx::Canvas* canvas,
--- chromium-72.0.3626.81/net/dns/dns_util.cc.gcc8 2019-01-30 02:18:08.000000000 +0100
+++ chromium-72.0.3626.81/net/dns/dns_util.cc 2019-02-02 22:14:47.573401872 +0100
@@ -235,7 +235,7 @@ uint16_t DnsQueryTypeToQtype(DnsQueryTyp
switch (dns_query_type) {
case DnsQueryType::UNSPECIFIED:
NOTREACHED();
- return 0;
+ break;
case DnsQueryType::A:
return dns_protocol::kTypeA;
case DnsQueryType::AAAA:
@@ -247,6 +247,7 @@ uint16_t DnsQueryTypeToQtype(DnsQueryTyp
case DnsQueryType::SRV:
return dns_protocol::kTypeSRV;
}
+ return 0;
}
DnsQueryType AddressFamilyToDnsQueryType(AddressFamily address_family) {
--- chromium-72.0.3626.81/components/content_settings/core/browser/host_content_settings_map.cc.gcc8 2019-01-30 02:17:53.000000000 +0100
+++ chromium-72.0.3626.81/components/content_settings/core/browser/host_content_settings_map.cc 2019-02-02 22:20:52.201087706 +0100
@@ -230,8 +230,9 @@ const char* ContentSettingToString(Conte
case CONTENT_SETTING_DEFAULT:
case CONTENT_SETTING_NUM_SETTINGS:
NOTREACHED();
- return nullptr;
+ break;
}
+ return nullptr;
}
} // namespace
--- chromium-72.0.3626.81/components/flags_ui/feature_entry.cc.gcc8 2019-01-30 02:17:54.000000000 +0100
+++ chromium-72.0.3626.81/components/flags_ui/feature_entry.cc 2019-02-02 22:45:06.492019359 +0100
@@ -46,6 +46,7 @@ bool FeatureEntry::InternalNameMatches(c
base::StringToInt(name.substr(internal_name_length + 1), &index) &&
index >= 0 && index < num_options;
}
+ return false;
}
std::string FeatureEntry::NameForOption(int index) const {
--- chromium-72.0.3626.81/components/viz/common/gl_scaler.cc.gcc8 2019-01-30 02:17:57.000000000 +0100
+++ chromium-72.0.3626.81/components/viz/common/gl_scaler.cc 2019-02-02 22:53:21.022474407 +0100
@@ -694,6 +694,7 @@ const char* GLScaler::GetShaderName(GLSc
CASE_RETURN_SHADER_STR(DEINTERLEAVE_PAIRWISE_MRT);
#undef CASE_RETURN_SHADER_STR
}
+ return "";
}
// static
--- chromium-72.0.3626.81/gpu/command_buffer/service/gles2_cmd_decoder.cc.gcc8 2019-01-30 02:18:02.000000000 +0100
+++ chromium-72.0.3626.81/gpu/command_buffer/service/gles2_cmd_decoder.cc 2019-02-02 23:01:18.198192176 +0100
@@ -15292,7 +15292,8 @@ bool GLES2DecoderImpl::GetUniformSetup(G
}
uint32_t checked_size = 0;
if (!SizedResult<T>::ComputeSize(num_elements).AssignIfValid(&checked_size)) {
- return error::kOutOfBounds;
+ *error = error::kOutOfBounds;
+ return false;
}
result = GetSharedMemoryAs<SizedResult<T>*>(shm_id, shm_offset, checked_size);
if (!result) {
--- chromium-72.0.3626.81/media/cdm/cdm_helpers.cc.gcc8 2019-01-30 02:18:05.000000000 +0100
+++ chromium-72.0.3626.81/media/cdm/cdm_helpers.cc 2019-02-02 23:15:02.798848133 +0100
@@ -18,7 +18,7 @@ constexpr cdm::ColorSpace kUnspecifiedCo
gfx::ColorSpace::RangeID ToGfxColorSpaceRange(cdm::ColorRange range) {
switch (range) {
case cdm::ColorRange::kInvalid:
- return gfx::ColorSpace::RangeID::INVALID;
+ break;
case cdm::ColorRange::kLimited:
return gfx::ColorSpace::RangeID::LIMITED;
case cdm::ColorRange::kFull:
@@ -26,6 +26,7 @@ gfx::ColorSpace::RangeID ToGfxColorSpace
case cdm::ColorRange::kDerived:
return gfx::ColorSpace::RangeID::DERIVED;
}
+ return gfx::ColorSpace::RangeID::INVALID;
}
} // namespace
--- chromium-72.0.3626.81/media/filters/decoder_stream.cc.gcc8 2019-01-30 02:18:05.000000000 +0100
+++ chromium-72.0.3626.81/media/filters/decoder_stream.cc 2019-02-02 23:22:06.786471338 +0100
@@ -90,6 +90,7 @@ const char* GetStatusString(typename Dec
case DecoderStream<StreamType>::DECODE_ERROR:
return "decode_error";
}
+ return "";
}
template <DemuxerStream::Type StreamType>
--- chromium-72.0.3626.81/chrome/browser/download/offline_item_utils.cc.gcc8 2019-01-30 02:17:45.000000000 +0100
+++ chromium-72.0.3626.81/chrome/browser/download/offline_item_utils.cc 2019-02-02 23:38:55.268808679 +0100
@@ -148,6 +148,7 @@ FailState OfflineItemUtils::ConvertDownl
#include "components/download/public/common/download_interrupt_reason_values.h"
#undef INTERRUPT_REASON
}
+ return offline_items_collection::FailState::CRASH;
}
// static
@@ -160,13 +161,14 @@ OfflineItemUtils::ConvertFailStateToDown
// maps them to none error.
case offline_items_collection::FailState::CANNOT_DOWNLOAD:
case offline_items_collection::FailState::NETWORK_INSTABILITY:
- return download::DOWNLOAD_INTERRUPT_REASON_NONE;
+ break;
#define INTERRUPT_REASON(name, value) \
case offline_items_collection::FailState::name: \
return download::DOWNLOAD_INTERRUPT_REASON_##name;
#include "components/download/public/common/download_interrupt_reason_values.h"
#undef INTERRUPT_REASON
}
+ return download::DOWNLOAD_INTERRUPT_REASON_NONE;
}
// static
--- chromium-72.0.3626.81/chrome/browser/download/offline_item_model.cc.gcc8 2019-01-30 02:17:45.000000000 +0100
+++ chromium-72.0.3626.81/chrome/browser/download/offline_item_model.cc 2019-02-02 23:39:52.468800050 +0100
@@ -127,8 +127,7 @@ void OfflineItemModel::Remove() {
}
download::DownloadItem::DownloadState OfflineItemModel::GetState() const {
- if (!offline_item_)
- return download::DownloadItem::CANCELLED;
+ if (offline_item_) {
switch (offline_item_->state) {
case OfflineItemState::IN_PROGRESS:
FALLTHROUGH;
@@ -143,11 +142,13 @@ download::DownloadItem::DownloadState Of
case OfflineItemState::COMPLETE:
return download::DownloadItem::COMPLETE;
case OfflineItemState::CANCELLED:
- return download::DownloadItem::CANCELLED;
+ break;
case OfflineItemState::NUM_ENTRIES:
NOTREACHED();
- return download::DownloadItem::CANCELLED;
+ break;
}
+ }
+ return download::DownloadItem::CANCELLED;
}
bool OfflineItemModel::IsPaused() const {
--- chromium-72.0.3626.81/google_apis/gaia/google_service_auth_error.cc.gcc8 2019-01-30 02:18:02.000000000 +0100
+++ chromium-72.0.3626.81/google_apis/gaia/google_service_auth_error.cc 2019-02-02 23:59:47.403751632 +0100
@@ -28,8 +28,9 @@ const char* InvalidCredentialsReasonToSt
return "credentials missing";
case InvalidGaiaCredentialsReason::NUM_REASONS:
NOTREACHED();
- return "";
+ break;
}
+ return "";
}
} // namespace
@@ -155,8 +156,9 @@ std::string GoogleServiceAuthError::ToSt
error_message_.c_str());
case NUM_STATES:
NOTREACHED();
- return std::string();
+ break;
}
+ return std::string();
}
bool GoogleServiceAuthError::IsPersistentError() const {
--- chromium-72.0.3626.81/components/signin/internal/identity_manager/profile_oauth2_token_service.cc.gcc8 2019-01-30 02:17:55.000000000 +0100
+++ chromium-72.0.3626.81/components/signin/internal/identity_manager/profile_oauth2_token_service.cc 2019-02-03 00:03:23.484949466 +0100
@@ -66,6 +66,7 @@ std::string SourceToString(SourceForRefr
kAccountReconcilor_RevokeTokensNotInCookies:
return "AccountReconcilor::RevokeTokensNotInCookies";
}
+ return "";
}
} // namespace
@@ -436,6 +437,7 @@ bool ProfileOAuth2TokenService::HasLoadC
// Load credentials finished with success.
return true;
}
+ return false;
}
void ProfileOAuth2TokenService::RecreateDeviceIdIfNeeded() {
--- chromium-72.0.3626.81/services/network/public/cpp/host_resolver_mojom_traits.cc.gcc8 2019-02-02 18:45:44.807519009 +0100
+++ chromium-72.0.3626.81/services/network/public/cpp/host_resolver_mojom_traits.cc 2019-02-03 00:24:44.073223903 +0100
@@ -39,8 +39,9 @@ base::Optional<bool> FromTristate(DnsCon
case DnsConfigOverrides::Tristate::TRISTATE_TRUE:
return true;
case DnsConfigOverrides::Tristate::TRISTATE_FALSE:
- return false;
+ break;
}
+ return false;
}
bool ReadHostData(mojo::ArrayDataView<DnsHostDataView> data,
@@ -272,7 +273,7 @@ EnumTraits<ResolveHostParameters::Source
case net::HostResolverSource::ANY:
return ResolveHostParameters::Source::ANY;
case net::HostResolverSource::SYSTEM:
- return ResolveHostParameters::Source::SYSTEM;
+ break;
case net::HostResolverSource::DNS:
return ResolveHostParameters::Source::DNS;
case net::HostResolverSource::MULTICAST_DNS:
@@ -280,6 +281,7 @@ EnumTraits<ResolveHostParameters::Source
case net::HostResolverSource::LOCAL_ONLY:
return ResolveHostParameters::Source::LOCAL_ONLY;
}
+ return ResolveHostParameters::Source::SYSTEM;
}
// static
@@ -303,6 +305,7 @@ bool EnumTraits<ResolveHostParameters::S
*output = net::HostResolverSource::LOCAL_ONLY;
return true;
}
+ return false;
}
// static
--- chromium-72.0.3626.81/services/network/resource_scheduler/resource_scheduler.cc.gcc8 2019-01-30 02:18:10.000000000 +0100
+++ chromium-72.0.3626.81/services/network/resource_scheduler/resource_scheduler.cc 2019-02-03 00:31:21.169154387 +0100
@@ -94,6 +94,7 @@ const char* RequestStartTriggerString(Re
case RequestStartTrigger::PEER_TO_PEER_CONNECTIONS_COUNT_CHANGED:
return "PEER_TO_PEER_CONNECTIONS_COUNT_CHANGED";
}
+ return "";
}
} // namespace
--- chromium-72.0.3626.81/services/network/mdns_responder.cc.gcc8 2019-01-30 02:18:10.000000000 +0100
+++ chromium-72.0.3626.81/services/network/mdns_responder.cc 2019-02-03 00:46:06.195423989 +0100
@@ -434,8 +434,9 @@ class MdnsResponderManager::SocketHandle
return RateLimitScheme::NO_LIMIT;
case MdnsResponseSendOption::ResponseClass::UNSPECIFIED:
NOTREACHED();
- return RateLimitScheme::PER_RESPONSE;
+ break;
}
+ return RateLimitScheme::PER_RESPONSE;
}
// Returns null if the computed delay exceeds kMaxScheduledDelay and the next
// available time is not updated.
--- chromium-72.0.3626.81/services/network/public/cpp/cors/cors.cc.gcc8 2019-01-30 02:18:10.000000000 +0100
+++ chromium-72.0.3626.81/services/network/public/cpp/cors/cors.cc 2019-02-03 00:51:01.746177854 +0100
@@ -584,8 +584,9 @@ bool IsCorsSameOriginResponseType(mojom:
case mojom::FetchResponseType::kError:
case mojom::FetchResponseType::kOpaque:
case mojom::FetchResponseType::kOpaqueRedirect:
- return false;
+ break;
}
+ return false;
}
bool IsCorsCrossOriginResponseType(mojom::FetchResponseType type) {
@@ -599,6 +600,7 @@ bool IsCorsCrossOriginResponseType(mojom
case mojom::FetchResponseType::kOpaqueRedirect:
return true;
}
+ return false;
}
bool CalculateCredentialsFlag(mojom::CredentialsMode credentials_mode,
@@ -616,6 +618,7 @@ bool CalculateCredentialsFlag(mojom::Cre
case network::mojom::CredentialsMode::kInclude:
return true;
}
+ return false;
}
} // namespace cors
--- chromium-72.0.3626.81/components/autofill/core/browser/autofill_metrics.cc.gcc8 2019-01-30 02:17:53.000000000 +0100
+++ chromium-72.0.3626.81/components/autofill/core/browser/autofill_metrics.cc 2019-02-03 01:03:08.861265327 +0100
@@ -1886,6 +1886,7 @@ const char* AutofillMetrics::GetMetricsS
case AutofillSyncSigninState::kNumSyncStates:
return ".Unknown";
}
+ return "";
}
void AutofillMetrics::FormInteractionsUkmLogger::LogFormSubmitted(
--- chromium-72.0.3626.81/components/autofill/core/browser/autofill_external_delegate.cc.gcc8 2019-01-30 02:17:53.000000000 +0100
+++ chromium-72.0.3626.81/components/autofill/core/browser/autofill_external_delegate.cc 2019-02-03 01:08:04.009018236 +0100
@@ -456,8 +456,9 @@ base::string16 AutofillExternalDelegate:
case PopupType::kPasswords:
NOTREACHED();
- return base::string16();
+ break;
}
+ return base::string16();
}
} // namespace autofill
--- chromium-72.0.3626.81/components/signin/core/browser/about_signin_internals.cc.gcc8 2019-01-30 02:17:55.000000000 +0100
+++ chromium-72.0.3626.81/components/signin/core/browser/about_signin_internals.cc 2019-02-03 01:44:34.307213001 +0100
@@ -565,6 +565,7 @@ std::string AboutSigninInternals::Refres
case AboutSigninInternals::RefreshTokenEventType::kAllTokensLoaded:
return "Loaded";
}
+ return "";
}
AboutSigninInternals::SigninStatus::SigninStatus()
--- chromium-72.0.3626.81/components/viz/service/display/skia_renderer.cc.gcc8 2019-01-30 02:17:57.000000000 +0100
+++ chromium-72.0.3626.81/components/viz/service/display/skia_renderer.cc 2019-02-03 02:36:27.949375551 +0100
@@ -1151,10 +1151,11 @@ bool SkiaRenderer::ShouldApplyBackground
GrContext* SkiaRenderer::GetGrContext() {
switch (draw_mode_) {
case DrawMode::DDL:
- return nullptr;
+ break;
case DrawMode::SKPRECORD:
- return nullptr;
+ break;
}
+ return nullptr;
}
void SkiaRenderer::UpdateRenderPassTextures(
--- chromium-72.0.3626.81/components/viz/service/hit_test/hit_test_manager.cc.gcc8 2019-01-30 02:17:57.000000000 +0100
+++ chromium-72.0.3626.81/components/viz/service/hit_test/hit_test_manager.cc 2019-02-03 02:50:05.305012810 +0100
@@ -10,7 +10,7 @@
namespace viz {
-namespace {
+namespace internal {
// TODO(gklassen): Review and select appropriate sizes based on
// telemetry / UMA.
constexpr uint32_t kMaxRegionsPerSurface = 1024;
@@ -164,9 +164,9 @@ void HitTestManager::SetHitTestAsyncQuer
bool HitTestManager::ValidateHitTestRegionList(
const SurfaceId& surface_id,
HitTestRegionList* hit_test_region_list) {
- if (hit_test_region_list->regions.size() > kMaxRegionsPerSurface)
+ if (hit_test_region_list->regions.size() > internal::kMaxRegionsPerSurface)
return false;
- if (!FlagsAndAsyncReasonsMatch(
+ if (!internal::FlagsAndAsyncReasonsMatch(
hit_test_region_list->flags,
hit_test_region_list->async_hit_test_reasons)) {
return false;
@@ -178,7 +178,7 @@ bool HitTestManager::ValidateHitTestRegi
region.frame_sink_id = FrameSinkId(surface_id.frame_sink_id().client_id(),
region.frame_sink_id.sink_id());
}
- if (!FlagsAndAsyncReasonsMatch(region.flags, region.async_hit_test_reasons))
+ if (!internal::FlagsAndAsyncReasonsMatch(region.flags, region.async_hit_test_reasons))
return false;
}
return true;
--- chromium-72.0.3626.81/media/capture/video/video_capture_device.cc.gcc8 2019-01-30 02:18:05.000000000 +0100
+++ chromium-72.0.3626.81/media/capture/video/video_capture_device.cc 2019-02-03 03:08:50.035235591 +0100
@@ -79,12 +79,13 @@ VideoCaptureFrameDropReason ConvertReser
VideoCaptureDevice::Client::ReserveResult reserve_result) {
switch (reserve_result) {
case VideoCaptureDevice::Client::ReserveResult::kSucceeded:
- return VideoCaptureFrameDropReason::kNone;
+ break;
case VideoCaptureDevice::Client::ReserveResult::kMaxBufferCountExceeded:
return VideoCaptureFrameDropReason::kBufferPoolMaxBufferCountExceeded;
case VideoCaptureDevice::Client::ReserveResult::kAllocationFailed:
return VideoCaptureFrameDropReason::kBufferPoolBufferAllocationFailed;
}
+ return VideoCaptureFrameDropReason::kNone;
}
} // namespace media
--- chromium-72.0.3626.81/chrome/browser/background_fetch/background_fetch_download_client.cc.gcc8 2019-01-30 02:17:44.000000000 +0100
+++ chromium-72.0.3626.81/chrome/browser/background_fetch/background_fetch_download_client.cc 2019-02-03 03:58:51.476458736 +0100
@@ -37,6 +37,7 @@ BackgroundFetchFailureReason ToBackgroun
case download::Client::FailureReason::CANCELLED:
return BackgroundFetchFailureReason::CANCELLED;
}
+ return BackgroundFetchFailureReason::NONE;
}
} // namespace
--- chromium-72.0.3626.81/chrome/browser/navigation_predictor/navigation_predictor.cc.gcc8 2019-01-30 02:17:46.000000000 +0100
+++ chromium-72.0.3626.81/chrome/browser/navigation_predictor/navigation_predictor.cc 2019-02-03 12:00:26.128679087 +0100
@@ -683,18 +683,6 @@ double NavigationPredictor::CalculateAnc
DCHECK_LE(0, metrics.ratio_visible_area);
DCHECK_GE(1, metrics.ratio_visible_area);
- DCHECK_LE(0, metrics.is_in_iframe);
- DCHECK_GE(1, metrics.is_in_iframe);
-
- DCHECK_LE(0, metrics.is_same_host);
- DCHECK_GE(1, metrics.is_same_host);
-
- DCHECK_LE(0, metrics.contains_image);
- DCHECK_GE(1, metrics.contains_image);
-
- DCHECK_LE(0, metrics.is_url_incremented_by_one);
- DCHECK_GE(1, metrics.is_url_incremented_by_one);
-
DCHECK_LE(0, document_engagement_score);
DCHECK_GE(1, document_engagement_score);
--- chromium-72.0.3626.81/chrome/browser/ui/content_settings/content_setting_image_model.cc.gcc8 2019-01-30 02:17:48.000000000 +0100
+++ chromium-72.0.3626.81/chrome/browser/ui/content_settings/content_setting_image_model.cc 2019-02-03 13:19:17.853486404 +0100
@@ -473,8 +473,9 @@ bool ContentSettingDownloadsImageModel::
return true;
case DownloadRequestLimiter::DOWNLOAD_UI_DEFAULT:
// No need to show icon otherwise.
- return false;
+ break;
}
+ return false;
}
// Clipboard -------------------------------------------------------------------
--- chromium-72.0.3626.81/chrome/browser/ui/views/autofill/payments/local_card_migration_dialog_view.cc.gcc8 2019-02-02 18:45:44.808518991 +0100
+++ chromium-72.0.3626.81/chrome/browser/ui/views/autofill/payments/local_card_migration_dialog_view.cc 2019-02-03 13:37:24.541069762 +0100
@@ -486,6 +486,7 @@ base::string16 LocalCardMigrationDialogV
return l10n_util::GetStringUTF16(
IDS_AUTOFILL_LOCAL_CARD_MIGRATION_DIALOG_BUTTON_LABEL_VIEW_CARDS);
}
+ return base::string16();
}
LocalCardMigrationDialog* CreateLocalCardMigrationDialogView(
--- chromium-72.0.3626.81/chrome/browser/ui/views/overlay/resize_handle_button.cc.gcc8 2019-01-30 02:17:48.000000000 +0100
+++ chromium-72.0.3626.81/chrome/browser/ui/views/overlay/resize_handle_button.cc 2019-02-03 13:59:23.275462434 +0100
@@ -58,6 +58,7 @@ int ResizeHandleButton::GetHTComponent()
case OverlayWindowViews::WindowQuadrant::kTopRight:
return HTBOTTOMLEFT;
}
+ return HTNOWHERE;
}
void ResizeHandleButton::SetPosition(
--- chromium-74.0.3729.40/components/data_reduction_proxy/content/browser/data_reduction_proxy_pingback_client_impl.cc.gcc8 2019-03-27 19:50:08.000000000 +0100
+++ chromium-74.0.3729.40/components/data_reduction_proxy/content/browser/data_reduction_proxy_pingback_client_impl.cc 2019-03-30 04:27:52.812150888 +0100
@@ -44,7 +44,7 @@ ProtoLitePageRedirectStatusFromLitePageR
previews::ServerLitePageStatus status) {
switch (status) {
case previews::ServerLitePageStatus::kUnknown:
- return HTTPSLitePagePreviewInfo_Status_UNKNOWN;
+ break;
case previews::ServerLitePageStatus::kSuccess:
return HTTPSLitePagePreviewInfo_Status_SUCCESS;
case previews::ServerLitePageStatus::kBypass:
@@ -56,6 +56,7 @@ ProtoLitePageRedirectStatusFromLitePageR
case previews::ServerLitePageStatus::kControl:
return HTTPSLitePagePreviewInfo_Status_CONTROL;
}
+ return HTTPSLitePagePreviewInfo_Status_UNKNOWN;
}
static const char kHistogramSucceeded[] =
--- chromium-72.0.3626.81/components/omnibox/browser/autocomplete_match.cc.gcc8 2019-01-30 02:17:54.000000000 +0100
+++ chromium-72.0.3626.81/components/omnibox/browser/autocomplete_match.cc 2019-02-03 14:29:59.471866490 +0100
@@ -259,9 +259,10 @@ const gfx::VectorIcon& AutocompleteMatch
case Type::NUM_TYPES:
NOTREACHED();
- static const gfx::VectorIcon dummy = {};
- return dummy;
+ break;
}
+ static const gfx::VectorIcon dummy = {};
+ return dummy;
}
#endif
--- chromium-72.0.3626.81/content/browser/media/audio_output_stream_broker.cc.gcc8 2019-01-30 02:17:59.000000000 +0100
+++ chromium-72.0.3626.81/content/browser/media/audio_output_stream_broker.cc 2019-02-03 15:05:15.757520763 +0100
@@ -52,8 +52,9 @@ StreamBrokerDisconnectReason GetDisconne
kDocumentDestroyedAwaitingCreated
: StreamBrokerDisconnectReason::kDocumentDestroyed;
case DisconnectReason::kDefault:
- return StreamBrokerDisconnectReason::kDefault;
+ break;
}
+ return StreamBrokerDisconnectReason::kDefault;
}
} // namespace
--- chromium-72.0.3626.81/extensions/browser/url_loader_factory_manager.cc.gcc8 2019-01-30 02:18:01.000000000 +0100
+++ chromium-72.0.3626.81/extensions/browser/url_loader_factory_manager.cc 2019-02-03 15:24:57.840768304 +0100
@@ -66,6 +66,7 @@ bool IsSpecialURLLoaderFactoryRequired(c
case FactoryUser::kExtensionProcess:
return DoExtensionPermissionsCoverCorsOrCorbRelatedOrigins(extension);
}
+ return false;
}
network::mojom::URLLoaderFactoryPtrInfo CreateURLLoaderFactory(
--- chromium-72.0.3626.81/third_party/blink/renderer/platform/wtf/casting.h.gcc8 2019-01-30 02:18:17.000000000 +0100
+++ chromium-72.0.3626.81/third_party/blink/renderer/platform/wtf/casting.h 2019-02-03 15:47:36.993899659 +0100
@@ -57,6 +57,7 @@ struct DowncastTraits {
template <typename U>
static bool AllowFrom(const U&) {
static_assert(sizeof(U) == 0, "no downcast traits specialization for T");
+ return false;
}
};
--- chromium-72.0.3626.81/gin/v8_isolate_memory_dump_provider.cc.gcc8 2019-01-30 02:18:02.000000000 +0100
+++ chromium-72.0.3626.81/gin/v8_isolate_memory_dump_provider.cc 2019-02-03 15:53:52.549316792 +0100
@@ -133,6 +133,7 @@ std::string IsolateTypeString(IsolateHol
return "utility";
}
LOG(FATAL) << "Unreachable code";
+ return "";
}
bool CanHaveMultipleIsolates(IsolateHolder::IsolateType isolate_type) {
@@ -149,6 +150,7 @@ bool CanHaveMultipleIsolates(IsolateHold
return false;
}
LOG(FATAL) << "Unreachable code";
+ return false;
}
} // namespace anonymous
--- chromium-72.0.3626.81/third_party/blink/renderer/core/editing/element_inner_text.cc.gcc8 2019-01-30 02:18:14.000000000 +0100
+++ chromium-72.0.3626.81/third_party/blink/renderer/core/editing/element_inner_text.cc 2019-02-03 17:03:47.484469962 +0100
@@ -52,7 +52,6 @@ class ElementInnerTextCollector final {
public:
Result() = default;
- void EmitChar16(UChar code_point);
void EmitNewline();
void EmitRequiredLineBreak(int count);
void EmitTab();
@@ -72,7 +71,6 @@ class ElementInnerTextCollector final {
static bool IsBeingRendered(const Node& node);
// Returns true if used value of "display" is block-level.
static bool IsDisplayBlockLevel(const Node&);
- static LayoutObject* PreviousLeafOf(const LayoutObject& layout_object);
static bool ShouldEmitNewlineForTableRow(
const LayoutNGTableRowInterface& table_row);
@@ -181,19 +179,6 @@ bool ElementInnerTextCollector::IsDispla
}
// static
-LayoutObject* ElementInnerTextCollector::PreviousLeafOf(
- const LayoutObject& layout_object) {
- LayoutObject* parent = layout_object.Parent();
- for (LayoutObject* runner = layout_object.PreviousInPreOrder(); runner;
- runner = runner->PreviousInPreOrder()) {
- if (runner != parent)
- return runner;
- parent = runner->Parent();
- }
- return nullptr;
-}
-
-// static
bool ElementInnerTextCollector::ShouldEmitNewlineForTableRow(
const LayoutNGTableRowInterface& table_row) {
const LayoutNGTableInterface* const table = table_row.TableInterface();
@@ -420,12 +405,6 @@ void ElementInnerTextCollector::ProcessT
// ----
-void ElementInnerTextCollector::Result::EmitChar16(UChar code_point) {
- FlushRequiredLineBreak();
- DCHECK_EQ(required_line_break_count_, 0);
- builder_.Append(code_point);
-}
-
void ElementInnerTextCollector::Result::EmitNewline() {
FlushRequiredLineBreak();
builder_.Append(kNewlineCharacter);
--- chromium-72.0.3626.81/third_party/blink/renderer/modules/mediastream/media_stream_constraints_util_audio.cc.gcc8 2019-01-30 02:18:00.000000000 +0100
+++ chromium-72.0.3626.81/third_party/blink/renderer/modules/mediastream/media_stream_constraints_util_audio.cc 2019-02-03 17:27:24.429355560 +0100
@@ -411,6 +411,7 @@ class EchoCancellationContainer {
case EchoCancellationType::kEchoCancellationAec3:
return Score::EcModeScore::kAec3;
}
+ return Score::EcModeScore::kDisabled;
}
static EchoCancellationTypeSet ToEchoCancellationTypes(const BoolSet ec_set) {
--- chromium-72.0.3626.81/media/blink/webmediaplayer_impl.cc.gcc8 2019-01-30 02:18:05.000000000 +0100
+++ chromium-72.0.3626.81/media/blink/webmediaplayer_impl.cc 2019-02-03 18:39:18.908601850 +0100
@@ -192,12 +192,13 @@ EncryptionMode DetermineEncryptionMode(
const EncryptionScheme& encryption_scheme) {
switch (encryption_scheme.mode()) {
case EncryptionScheme::CIPHER_MODE_UNENCRYPTED:
- return EncryptionMode::kUnencrypted;
+ break;
case EncryptionScheme::CIPHER_MODE_AES_CTR:
return EncryptionMode::kCenc;
case EncryptionScheme::CIPHER_MODE_AES_CBC:
return EncryptionMode::kCbcs;
}
+ return EncryptionMode::kUnencrypted;
}
#if BUILDFLAG(ENABLE_FFMPEG)
--- chromium-72.0.3626.81/third_party/blink/renderer/core/css/properties/longhands/custom_property.cc.gcc8 2019-01-30 02:18:14.000000000 +0100
+++ chromium-72.0.3626.81/third_party/blink/renderer/core/css/properties/longhands/custom_property.cc 2019-02-03 20:14:27.832403200 +0100
@@ -98,6 +98,7 @@ const CSSValue* CustomProperty::ParseSin
return nullptr;
return ParseUntyped(range, context, local_context);
}
+ return nullptr;
}
const CSSValue* CustomProperty::CSSValueFromComputedStyleInternal(
--- chromium-72.0.3626.81/third_party/blink/renderer/core/layout/layout_flexible_box.cc.gcc8 2019-01-30 02:18:15.000000000 +0100
+++ chromium-72.0.3626.81/third_party/blink/renderer/core/layout/layout_flexible_box.cc 2019-02-03 21:13:06.415736350 +0100
@@ -604,6 +604,7 @@ LayoutUnit LayoutFlexibleBox::FlowAwareC
return ContentInsetRight();
}
NOTREACHED();
+ return LayoutUnit();
}
DISABLE_CFI_PERF
@@ -619,6 +620,7 @@ LayoutUnit LayoutFlexibleBox::FlowAwareC
return ContentLeft();
}
NOTREACHED();
+ return LayoutUnit();
}
LayoutUnit LayoutFlexibleBox::CrossAxisScrollbarExtent() const {
--- chromium-72.0.3626.81/third_party/blink/renderer/modules/cache_storage/inspector_cache_storage_agent.cc.gcc8 2019-01-30 02:18:16.000000000 +0100
+++ chromium-72.0.3626.81/third_party/blink/renderer/modules/cache_storage/inspector_cache_storage_agent.cc 2019-02-03 21:58:09.187174953 +0100
@@ -398,7 +398,7 @@ class CachedResponseFileReaderLoaderClie
void DidFail(FileErrorCode error) override {
callback_->sendFailure(ProtocolResponse::Error(String::Format(
- "Unable to read the cached response, error code: %d", error)));
+ "Unable to read the cached response, error code: %d", int(error))));
dispose();
}
--- chromium-72.0.3626.81/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc.gcc5 2019-01-30 02:18:16.000000000 +0100
+++ chromium-72.0.3626.81/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc 2019-02-03 22:41:04.273198056 +0100
@@ -571,6 +571,7 @@ RTCSetSessionDescriptionOperation GetRTC
return RTCSetSessionDescriptionOperation::
kSetRemoteDescriptionInvalidType;
}
+ return RTCSetSessionDescriptionOperation::kSetLocalDescriptionOffer;
}
} // namespace
@@ -596,6 +597,7 @@ SdpUsageCategory DeduceSdpUsageCategory(
? SdpUsageCategory::kSafe
: SdpUsageCategory::kUnsafe;
}
+ return SdpUsageCategory::kUnsafe;
}
RTCPeerConnection::EventWrapper::EventWrapper(Event* event,
--- chromium-72.0.3626.81/third_party/blink/renderer/modules/worklet/animation_and_paint_worklet_thread.cc.gcc8 2019-01-30 02:18:16.000000000 +0100
+++ chromium-72.0.3626.81/third_party/blink/renderer/modules/worklet/animation_and_paint_worklet_thread.cc 2019-02-03 23:05:45.671830140 +0100
@@ -96,7 +96,8 @@ AnimationAndPaintWorkletThread::CreateWo
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("paint-worklet"),
"AnimationAndPaintWorkletThread::CreateWorkerGlobalScope");
return PaintWorkletGlobalScope::Create(std::move(creation_params), this);
- };
+ }
+ return nullptr;
}
void AnimationAndPaintWorkletThread::EnsureSharedBackingThread() {
distrib
>
Mageia
>
7
>
i586
>
media
>
core-updates-src
>
by-pkgid
>
f5a2d348875a82e92e9aab3aebacb9c1
>
files
>
29
