--- chromium-67.0.3396.10/chrome/browser/ui/webui/discards/discards_ui.cc.gcc7 2018-04-18 21:04:40.000000000 +0200
+++ chromium-67.0.3396.10/chrome/browser/ui/webui/discards/discards_ui.cc 2018-04-22 18:15:26.594324206 +0200
@@ -44,7 +44,7 @@
case content::Visibility::VISIBLE:
return discards::mojom::LifecycleUnitVisibility::VISIBLE;
}
-#if defined(COMPILER_MSVC)
+#if defined(COMPILER_MSVC) || defined(COMPILER_GCC)
NOTREACHED();
return discards::mojom::LifecycleUnitVisibility::VISIBLE;
#endif
--- chromium-68.0.3418.2/media/capture/video/video_capture_device_descriptor.cc.gcc7 2018-05-04 06:05:23.000000000 +0200
+++ chromium-68.0.3418.2/media/capture/video/video_capture_device_descriptor.cc 2018-05-08 01:07:51.984718931 +0200
@@ -93,6 +93,7 @@
case VideoCaptureApi::VIRTUAL_DEVICE:
return "Virtual Device";
case VideoCaptureApi::UNKNOWN:
+ default:
return "Unknown";
}
}
--- chromium-68.0.3418.2/net/nqe/network_quality_estimator.cc.gcc7 2018-05-04 06:05:25.000000000 +0200
+++ chromium-68.0.3418.2/net/nqe/network_quality_estimator.cc 2018-05-08 01:51:43.640113593 +0200
@@ -1307,6 +1307,7 @@
percentile, observations_count)
.value_or(nqe::internal::INVALID_RTT_THROUGHPUT));
case nqe::internal::OBSERVATION_CATEGORY_COUNT:
+ default:
NOTREACHED();
return base::TimeDelta();
}
--- chromium-68.0.3418.2/services/network/public/cpp/cross_origin_read_blocking.cc.gcc7 2018-05-04 06:05:26.000000000 +0200
+++ chromium-68.0.3418.2/services/network/public/cpp/cross_origin_read_blocking.cc 2018-05-08 04:58:22.484383246 +0200
@@ -729,6 +729,7 @@
case kNeedToSniffMore:
return sniffers_.empty() && !found_blockable_content_;
case kBlock:
+ default:
return false;
}
}
@@ -740,6 +741,7 @@
case kNeedToSniffMore:
return sniffers_.empty() && found_blockable_content_;
case kBlock:
+ default:
return true;
}
}
--- chromium-68.0.3418.2/third_party/blink/renderer/modules/webaudio/audio_param.cc.gcc7 2018-05-04 06:05:50.000000000 +0200
+++ chromium-68.0.3418.2/third_party/blink/renderer/modules/webaudio/audio_param.cc 2018-05-13 16:16:36.362212522 +0200
@@ -144,6 +144,7 @@
return custom_param_name_;
default:
NOTREACHED();
+ return "";
}
}
--- chromium-68.0.3440.7/services/audio/public/cpp/audio_system_to_service_adapter.cc.gcc7 2018-05-31 12:45:46.000000000 +0200
+++ chromium-68.0.3440.7/services/audio/public/cpp/audio_system_to_service_adapter.cc 2018-06-02 16:23:31.460186468 +0200
@@ -66,6 +66,7 @@ const char* GetTraceEvent(Action action)
return "AudioSystemToServiceAdapter::GetInputDeviceInfo";
}
NOTREACHED();
+ return NULL;
}
OnAudioParamsCallback WrapGetStreamParametersReply(
--- chromium-68.0.3440.7/cc/input/snap_fling_controller.cc.gcc7 2018-05-31 12:45:27.000000000 +0200
+++ chromium-68.0.3440.7/cc/input/snap_fling_controller.cc 2018-06-02 16:44:43.320656957 +0200
@@ -27,6 +27,8 @@
return state_ == State::kActive || state_ == State::kFinished;
}
}
+ // should not be reached
+ return false;
}
void SnapFlingController::ClearSnapFling() {
--- chromium-68.0.3440.7/components/autofill/core/browser/autofill_manager.cc.gcc7 2018-05-31 12:45:36.000000000 +0200
+++ chromium-68.0.3440.7/components/autofill/core/browser/autofill_manager.cc 2018-06-02 17:06:51.007106694 +0200
@@ -303,6 +303,7 @@ PopupType AutofillManager::GetPopupType(
default:
NOTREACHED();
+ return PopupType::kUnspecified;
}
}
--- chromium-68.0.3440.7/content/browser/cache_storage/cache_storage_quota_client.cc.gcc7 2018-05-31 12:45:39.000000000 +0200
+++ chromium-68.0.3440.7/content/browser/cache_storage/cache_storage_quota_client.cc 2018-06-02 19:36:54.786503931 +0200
@@ -99,6 +99,7 @@ storage::QuotaClientType CacheStorageQuo
case CacheStorageOwner::kBackgroundFetch:
return storage::QuotaClientType::kBackgroundFetch;
}
+ return storage::QuotaClientType::kServiceWorkerCache;
}
} // namespace content
--- chromium-68.0.3440.7/ui/accessibility/platform/ax_platform_node_auralinux.cc.gcc7 2018-05-31 12:46:30.000000000 +0200
+++ chromium-68.0.3440.7/ui/accessibility/platform/ax_platform_node_auralinux.cc 2018-06-02 20:45:03.373900877 +0200
@@ -2661,6 +2661,8 @@ AtkRole AXPlatformNodeAuraLinux::GetAtkR
case ax::mojom::Role::kPresentational:
return ATK_ROLE_REDUNDANT_OBJECT;
}
+ // should not be reached
+ return AtkRole(0);
}
void AXPlatformNodeAuraLinux::GetAtkState(AtkStateSet* atk_state_set) {
--- chromium-68.0.3440.7/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc.gcc7 2018-05-31 12:46:13.000000000 +0200
+++ chromium-68.0.3440.7/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc 2018-06-03 01:23:30.476302728 +0200
@@ -972,6 +972,7 @@ ax::mojom::blink::TextPosition AXLayoutO
case EVerticalAlign::kSuper:
return ax::mojom::blink::TextPosition::kSuperscript;
}
+ return ax::mojom::blink::TextPosition(0);
}
static unsigned TextStyleFlag(ax::mojom::blink::TextStyle text_style_enum) {
--- chromium-69.0.3472.3/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc.gcc7 2018-06-26 06:32:58.000000000 +0200
+++ chromium-69.0.3472.3/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc 2018-07-07 13:47:27.816647653 +0200
@@ -104,6 +104,7 @@ bool IsValidStateChange(LifecycleUnitSta
}
}
}
+ return false;
}
StateChangeReason DiscardReasonToStateChangeReason(
@@ -114,6 +115,7 @@ StateChangeReason DiscardReasonToStateCh
case LifecycleUnitDiscardReason::URGENT:
return StateChangeReason::SYSTEM_MEMORY_PRESSURE;
}
+ return StateChangeReason::BROWSER_INITIATED;
}
} // namespace
--- chromium-69.0.3472.3/device/bluetooth/bluetooth_remote_gatt_characteristic.cc.gcc7 2018-06-26 06:33:02.000000000 +0200
+++ chromium-69.0.3472.3/device/bluetooth/bluetooth_remote_gatt_characteristic.cc 2018-07-07 21:00:37.557253268 +0200
@@ -362,14 +362,15 @@
Properties properties = GetProperties();
bool hasNotify = (properties & PROPERTY_NOTIFY) != 0;
bool hasIndicate = (properties & PROPERTY_INDICATE) != 0;
- if (!notification_type)
- return hasNotify || hasIndicate;
- switch (notification_type.value()) {
- case NotificationType::kNotification:
- return hasNotify;
- case NotificationType::kIndication:
- return hasIndicate;
+ if (notification_type) {
+ switch (notification_type.value()) {
+ case NotificationType::kNotification:
+ return hasNotify;
+ case NotificationType::kIndication:
+ return hasIndicate;
+ }
}
+ return hasNotify || hasIndicate;
}
} // namespace device
--- chromium-69.0.3472.3/ui/views/layout/layout_provider.cc.gcc7 2018-06-26 06:33:24.000000000 +0200
+++ chromium-69.0.3472.3/ui/views/layout/layout_provider.cc 2018-07-07 22:46:19.302390595 +0200
@@ -174,6 +174,7 @@ int LayoutProvider::GetCornerRadiusMetri
case EMPHASIS_MAXIMUM:
return std::min(size.width(), size.height()) / 2;
}
+ return 0;
}
int LayoutProvider::GetShadowElevationMetric(
@@ -190,6 +191,7 @@ int LayoutProvider::GetShadowElevationMe
case EMPHASIS_MAXIMUM:
return 16;
}
+ return 0;
}
gfx::ShadowValues LayoutProvider::MakeShadowValues(int elevation,
--- chromium-69.0.3472.3/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc.gcc7 2018-06-26 06:33:19.000000000 +0200
+++ chromium-69.0.3472.3/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc 2018-07-08 10:57:14.446270568 +0200
@@ -707,7 +707,7 @@ PageSchedulerImpl::PageLifecycleStateTra
switch (old_state) {
case PageLifecycleState::kUnknown:
// We don't track the initial transition.
- return base::nullopt;
+ break;
case PageLifecycleState::kActive:
switch (new_state) {
case PageLifecycleState::kHiddenForegrounded:
@@ -716,8 +716,8 @@ PageSchedulerImpl::PageLifecycleStateTra
return PageLifecycleStateTransition::kActiveToHiddenBackgrounded;
default:
NOTREACHED();
- return base::nullopt;
}
+ break;
case PageLifecycleState::kHiddenForegrounded:
switch (new_state) {
case PageLifecycleState::kActive:
@@ -729,8 +729,8 @@ PageSchedulerImpl::PageLifecycleStateTra
return PageLifecycleStateTransition::kHiddenForegroundedToFrozen;
default:
NOTREACHED();
- return base::nullopt;
}
+ break;
case PageLifecycleState::kHiddenBackgrounded:
switch (new_state) {
case PageLifecycleState::kActive:
@@ -742,8 +742,8 @@ PageSchedulerImpl::PageLifecycleStateTra
return PageLifecycleStateTransition::kHiddenBackgroundedToFrozen;
default:
NOTREACHED();
- return base::nullopt;
}
+ break;
case PageLifecycleState::kFrozen:
switch (new_state) {
case PageLifecycleState::kActive:
@@ -754,9 +754,10 @@ PageSchedulerImpl::PageLifecycleStateTra
return PageLifecycleStateTransition::kFrozenToHiddenBackgrounded;
default:
NOTREACHED();
- return base::nullopt;
}
+ break;
}
+ return base::nullopt;
}
FrameSchedulerImpl* PageSchedulerImpl::SelectFrameForUkmAttribution() {
--- chromium-69.0.3497.4/components/policy/core/common/policy_proto_decoders.cc.gcc7 2018-07-21 09:12:56.000000000 +0200
+++ chromium-69.0.3497.4/components/policy/core/common/policy_proto_decoders.cc 2018-07-21 21:38:32.566870921 +0200
@@ -43,6 +43,7 @@
case em::PolicyOptions::UNSET:
return false;
}
+ return false;
}
// Convert a BooleanPolicyProto to a bool base::Value.
--- chromium-69.0.3497.4/components/password_manager/core/browser/browser_save_password_progress_logger.cc.gcc7 2018-07-21 09:12:55.000000000 +0200
+++ chromium-69.0.3497.4/components/password_manager/core/browser/browser_save_password_progress_logger.cc 2018-07-21 23:21:48.274812853 +0200
@@ -76,6 +76,7 @@ std::string VoteTypeToString(
case AutofillUploadContents::Field::FIRST_USE:
return "First use";
}
+ return "";
}
std::string FormSignatureToDebugString(autofill::FormSignature form_signature) {
--- chromium-69.0.3497.4/services/viz/public/cpp/gpu/command_buffer_metrics.cc.gcc7 2018-07-21 09:13:14.000000000 +0200
+++ chromium-69.0.3497.4/services/viz/public/cpp/gpu/command_buffer_metrics.cc 2018-07-22 02:02:14.833006828 +0200
@@ -97,6 +97,7 @@ std::string ContextTypeToString(ContextT
case ContextType::XR_COMPOSITING:
return "XRCompositing";
}
+ return "Unexpected";
}
void UmaRecordContextInitFailed(ContextType type) {
--- chromium-69.0.3497.4/third_party/blink/common/media/watch_time_reporter.cc.gcc7 2018-07-21 09:13:09.000000000 +0200
+++ chromium-69.0.3497.4/third_party/blink/common/media/watch_time_reporter.cc 2018-07-22 03:13:23.483720815 +0200
@@ -572,6 +572,7 @@
case DisplayType::kPictureInPicture:
return DISPLAY_TYPE_KEY(DisplayPictureInPicture);
}
+ return DISPLAY_TYPE_KEY(All);
}
#undef DISPLAY_TYPE_KEY
--- chromium-69.0.3497.4/third_party/blink/renderer/core/css/style_environment_variables.cc.gcc7 2018-07-21 09:13:40.000000000 +0200
+++ chromium-69.0.3497.4/third_party/blink/renderer/core/css/style_environment_variables.cc 2018-07-22 10:53:45.772448293 +0200
@@ -110,6 +110,7 @@ const AtomicString StyleEnvironmentVaria
}
NOTREACHED();
+ return "";
}
// static
--- chromium-69.0.3497.4/third_party/blink/renderer/modules/cookie_store/cookie_change_event.cc.gcc7 2018-07-21 09:13:41.000000000 +0200
+++ chromium-69.0.3497.4/third_party/blink/renderer/modules/cookie_store/cookie_change_event.cc 2018-07-22 12:42:37.155347296 +0200
@@ -62,6 +62,7 @@ String ToCookieListItemSameSite(network:
}
NOTREACHED();
+ return String();
}
String ToCookieListItemEffectiveSameSite(
@@ -77,6 +78,7 @@ String ToCookieListItemEffectiveSameSite
case network::mojom::CookieEffectiveSameSite::kUndefined:
return String();
}
+ return String();
}
} // namespace
--- chromium-69.0.3497.42/third_party/blink/renderer/core/html/media/media_controls.cc.gcc7 2018-08-17 03:06:24.000000000 +0200
+++ chromium-69.0.3497.42/third_party/blink/renderer/core/html/media/media_controls.cc 2018-08-19 12:30:24.128429583 +0200
@@ -39,6 +39,7 @@
}
NOTREACHED();
+ return AtomicString();
}
MediaControls::MediaControls(HTMLMediaElement& media_element)
--- chromium-70.0.3528.4/base/callback_internal.cc.gcc8 2018-08-21 11:49:22.000000000 +0200
+++ chromium-70.0.3528.4/base/callback_internal.cc 2018-08-22 03:08:10.825006053 +0200
@@ -21,6 +21,7 @@
return true;
}
NOTREACHED();
+ return false;
}
} // namespace
--- chromium-70.0.3528.4/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc.gcc8 2018-08-21 11:49:32.000000000 +0200
+++ chromium-70.0.3528.4/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc 2018-08-22 20:46:18.826814588 +0200
@@ -46,8 +46,9 @@ std::string GetClientTagForSpecificsId(W
return "card-" + specifics_id;
case WalletMetadataSpecifics::UNKNOWN:
NOTREACHED();
- return "";
+ break;
}
+ return "";
}
// Returns the wallet metadata specifics id for the specified |metadata_id|.
@@ -248,8 +249,9 @@ bool AddServerMetadata(AutofillTable* ta
return table->AddServerCardMetadata(metadata);
case WalletMetadataSpecifics::UNKNOWN:
NOTREACHED();
- return false;
+ break;
}
+ return false;
}
bool RemoveServerMetadata(AutofillTable* table,
@@ -262,8 +264,9 @@ bool RemoveServerMetadata(AutofillTable*
return table->RemoveServerCardMetadata(id);
case WalletMetadataSpecifics::UNKNOWN:
NOTREACHED();
- return false;
+ break;
}
+ return false;
}
bool UpdateServerMetadata(AutofillTable* table,
--- chromium-70.0.3528.4/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc.gcc8 2018-08-21 11:49:32.000000000 +0200
+++ chromium-70.0.3528.4/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc 2018-08-22 20:50:21.920501135 +0200
@@ -31,6 +31,7 @@ sync_pb::WalletMaskedCreditCard::WalletC
case CreditCard::EXPIRED:
return sync_pb::WalletMaskedCreditCard::EXPIRED;
}
+ return sync_pb::WalletMaskedCreditCard::WalletCardStatus(0);
}
CreditCard::ServerStatus ServerToLocalStatus(
@@ -41,6 +42,7 @@ CreditCard::ServerStatus ServerToLocalSt
case sync_pb::WalletMaskedCreditCard::EXPIRED:
return CreditCard::EXPIRED;
}
+ return CreditCard::ServerStatus(0);
}
sync_pb::WalletMaskedCreditCard::WalletCardType WalletCardTypeFromCardNetwork(
@@ -85,6 +87,7 @@ const char* CardNetworkFromWalletCardTyp
case sync_pb::WalletMaskedCreditCard::UNKNOWN:
return kGenericCard;
}
+ return kGenericCard;
}
// Creates an AutofillProfile from the specified |card| specifics.
--- chromium-70.0.3528.4/components/policy/core/common/cloud/cloud_policy_util.cc.gcc8 2018-08-21 11:49:33.000000000 +0200
+++ chromium-70.0.3528.4/components/policy/core/common/cloud/cloud_policy_util.cc 2018-08-22 20:57:20.438070995 +0200
@@ -182,8 +182,6 @@ std::string GetOSUsername() {
em::Channel ConvertToProtoChannel(version_info::Channel channel) {
switch (channel) {
- case version_info::Channel::UNKNOWN:
- return em::CHANNEL_UNKNOWN;
case version_info::Channel::CANARY:
return em::CHANNEL_CANARY;
case version_info::Channel::DEV:
@@ -192,7 +190,10 @@ em::Channel ConvertToProtoChannel(versio
return em::CHANNEL_BETA;
case version_info::Channel::STABLE:
return em::CHANNEL_STABLE;
+ case version_info::Channel::UNKNOWN:
+ break;
}
+ return em::CHANNEL_UNKNOWN;
}
std::string GetDeviceName() {
--- chromium-70.0.3528.4/services/network/public/cpp/host_resolver_mojom_traits.cc.gcc8 2018-08-21 11:49:46.000000000 +0200
+++ chromium-70.0.3528.4/services/network/public/cpp/host_resolver_mojom_traits.cc 2018-08-22 21:04:36.936359195 +0200
@@ -41,6 +41,7 @@ base::Optional<bool> FromTristate(DnsCon
case DnsConfigOverrides::Tristate::TRISTATE_FALSE:
return false;
}
+ return false;
}
bool ReadDnsOverHttpsServerData(
@@ -69,8 +70,7 @@ bool ReadDnsOverHttpsServerData(
OptionalSecureDnsMode ToOptionalSecureDnsMode(
base::Optional<net::SecureDnsMode> optional) {
- if (!optional)
- return OptionalSecureDnsMode::NO_OVERRIDE;
+ if (optional) {
switch (optional.value()) {
case net::SecureDnsMode::kOff:
return OptionalSecureDnsMode::OFF;
@@ -79,6 +79,8 @@ OptionalSecureDnsMode ToOptionalSecureDn
case net::SecureDnsMode::kSecure:
return OptionalSecureDnsMode::SECURE;
}
+ }
+ return OptionalSecureDnsMode::NO_OVERRIDE;
}
} // namespace
@@ -95,6 +97,7 @@ base::Optional<net::SecureDnsMode> FromO
case OptionalSecureDnsMode::SECURE:
return net::SecureDnsMode::kSecure;
}
+ return base::nullopt;
}
// static
@@ -203,7 +206,7 @@ DnsQueryType EnumTraits<DnsQueryType, ne
net::DnsQueryType input) {
switch (input) {
case net::DnsQueryType::UNSPECIFIED:
- return DnsQueryType::UNSPECIFIED;
+ break;
case net::DnsQueryType::A:
return DnsQueryType::A;
case net::DnsQueryType::AAAA:
@@ -220,6 +223,7 @@ DnsQueryType EnumTraits<DnsQueryType, ne
NOTIMPLEMENTED();
return DnsQueryType::UNSPECIFIED;
}
+ return DnsQueryType::UNSPECIFIED;
}
// static
@@ -249,6 +253,7 @@ bool EnumTraits<DnsQueryType, net::DnsQu
*output = net::DnsQueryType::HTTPS;
return true;
}
+ return false;
}
// static
@@ -259,7 +264,7 @@ EnumTraits<ResolveHostParameters::Source
case net::HostResolverSource::ANY:
return ResolveHostParameters::Source::ANY;
case net::HostResolverSource::SYSTEM:
- return ResolveHostParameters::Source::SYSTEM;
+ break;
case net::HostResolverSource::DNS:
return ResolveHostParameters::Source::DNS;
case net::HostResolverSource::MULTICAST_DNS:
@@ -267,6 +272,7 @@ EnumTraits<ResolveHostParameters::Source
case net::HostResolverSource::LOCAL_ONLY:
return ResolveHostParameters::Source::LOCAL_ONLY;
}
+ return ResolveHostParameters::Source::SYSTEM;
}
// static
@@ -290,6 +296,7 @@ bool EnumTraits<ResolveHostParameters::S
*output = net::HostResolverSource::LOCAL_ONLY;
return true;
}
+ return false;
}
// static
@@ -305,6 +312,7 @@ EnumTraits<MdnsListenClient::UpdateType,
case net::HostResolver::MdnsListener::Delegate::UpdateType::REMOVED:
return MdnsListenClient::UpdateType::REMOVED;
}
+ return MdnsListenClient::UpdateType::CHANGED;
}
// static
@@ -323,6 +331,7 @@ bool EnumTraits<MdnsListenClient::Update
*output = net::HostResolver::MdnsListener::Delegate::UpdateType::REMOVED;
return true;
}
+ return false;
}
// static
--- chromium-70.0.3528.4/chrome/browser/media/webrtc/media_stream_capture_indicator.cc.gcc8 2018-08-21 11:49:26.000000000 +0200
+++ chromium-70.0.3528.4/chrome/browser/media/webrtc/media_stream_capture_indicator.cc 2018-08-23 00:51:21.562436998 +0200
@@ -106,6 +106,7 @@ ObserverMethod GetObserverMethodToCall(b
NOTREACHED();
return nullptr;
}
+ return nullptr;
}
} // namespace
@@ -294,6 +295,7 @@ int& MediaStreamCaptureIndicator::WebCon
NOTREACHED();
return video_stream_count_;
}
+ return video_stream_count_;
}
MediaStreamCaptureIndicator::Observer::~Observer() {
--- chromium-70.0.3528.4/chrome/browser/ui/webui/media/media_engagement_ui.cc.gcc8 2018-08-21 11:49:28.000000000 +0200
+++ chromium-70.0.3528.4/chrome/browser/ui/webui/media/media_engagement_ui.cc 2018-08-23 01:36:02.540654647 +0200
@@ -103,6 +103,7 @@ class MediaEngagementScoreDetailsProvide
case blink::mojom::AutoplayPolicy::kDocumentUserActivationRequired:
return "document-user-activation-required";
}
+ return "";
}
const std::string GetPreloadVersion() {
--- chromium-70.0.3528.4/chrome/browser/ui/views/autofill/payments/local_card_migration_dialog_view.cc.gcc8 2018-08-21 11:49:28.000000000 +0200
+++ chromium-70.0.3528.4/chrome/browser/ui/views/autofill/payments/local_card_migration_dialog_view.cc 2018-08-23 02:06:24.710232264 +0200
@@ -471,6 +473,7 @@ base::string16 LocalCardMigrationDialogV
return l10n_util::GetStringUTF16(
IDS_AUTOFILL_LOCAL_CARD_MIGRATION_DIALOG_BUTTON_LABEL_DONE);
}
+ return base::string16();
}
base::string16 LocalCardMigrationDialogView::GetCancelButtonLabel() const {
--- chromium-70.0.3528.4/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc.gcc8 2018-08-21 11:50:19.000000000 +0200
+++ chromium-70.0.3528.4/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc 2018-08-24 01:23:50.677245606 +0200
@@ -335,6 +335,7 @@ const String BackgroundFetchRegistration
return "";
}
NOTREACHED();
+ return "";
}
const String BackgroundFetchRegistration::failureReason() const {
@@ -364,6 +365,7 @@ const String BackgroundFetchRegistration
return "download-total-exceeded";
}
NOTREACHED();
+ return "";
}
bool BackgroundFetchRegistration::HasPendingActivity() const {
--- chromium-70.0.3528.4/third_party/blink/renderer/modules/accessibility/ax_position.cc.gcc8 2018-08-21 11:50:19.000000000 +0200
+++ chromium-70.0.3528.4/third_party/blink/renderer/modules/accessibility/ax_position.cc 2018-08-24 01:39:59.717763044 +0200
@@ -802,7 +802,7 @@ const AXObject* AXPosition::FindNeighbor
if (next_object && next_object->AccessibilityIsIncludedInTree())
return next_object;
}
- return nullptr;
+ break;
}
case AXPositionAdjustmentBehavior::kMoveLeft: {
@@ -814,9 +814,10 @@ const AXObject* AXPosition::FindNeighbor
if (previous_object && previous_object->AccessibilityIsIncludedInTree())
return previous_object;
}
- return nullptr;
+ break;
}
}
+ return nullptr;
}
bool operator==(const AXPosition& a, const AXPosition& b) {
--- chromium-70.0.3528.4/third_party/blink/renderer/platform/scheduler/common/metrics_helper.cc.gcc8 2018-08-21 11:50:20.000000000 +0200
+++ chromium-70.0.3528.4/third_party/blink/renderer/platform/scheduler/common/metrics_helper.cc 2018-08-24 02:02:26.257496527 +0200
@@ -44,6 +44,7 @@ scheduling_metrics::ThreadType ConvertBl
NOTREACHED();
return scheduling_metrics::ThreadType::kCount;
}
+ return scheduling_metrics::ThreadType::kCount;
}
} // namespace
--- chromium-70.0.3528.4/third_party/blink/renderer/modules/storage/cached_storage_area.cc.gcc8 2018-08-21 11:50:19.000000000 +0200
+++ chromium-70.0.3528.4/third_party/blink/renderer/modules/storage/cached_storage_area.cc 2018-08-24 02:21:38.087682075 +0200
@@ -625,6 +625,7 @@
}
}
NOTREACHED();
+ return Vector<uint8_t>();
}
} // namespace blink
--- chromium-70.0.3538.22/media/base/audio_processing.cc.gcc8 2018-09-19 21:10:51.000000000 +0200
+++ chromium-70.0.3538.22/media/base/audio_processing.cc 2018-09-23 20:14:22.964158434 +0200
@@ -12,7 +12,7 @@
auto agc_to_string = [](AutomaticGainControlType type) -> const char* {
switch (type) {
case AutomaticGainControlType::kDisabled:
- return "disabled";
+ break;
case AutomaticGainControlType::kDefault:
return "default";
case AutomaticGainControlType::kExperimental:
@@ -20,28 +20,31 @@
case AutomaticGainControlType::kHybridExperimental:
return "hybrid experimental";
}
+ return "disabled";
};
auto aec_to_string = [](EchoCancellationType type) -> const char* {
switch (type) {
case EchoCancellationType::kDisabled:
- return "disabled";
+ break;
case EchoCancellationType::kAec3:
return "aec3";
case EchoCancellationType::kSystemAec:
return "system aec";
}
+ return "disabled";
};
auto ns_to_string = [](NoiseSuppressionType type) -> const char* {
switch (type) {
case NoiseSuppressionType::kDisabled:
- return "disabled";
+ break;
case NoiseSuppressionType::kDefault:
return "default";
case NoiseSuppressionType::kExperimental:
return "experimental";
}
+ return "disabled";
};
auto bool_to_yes_no = [](bool b) -> const char* { return b ? "yes" : "no"; };
--- chromium-70.0.3538.22/third_party/blink/renderer/core/loader/mixed_content_checker.cc.gcc8 2018-09-19 21:11:34.000000000 +0200
+++ chromium-70.0.3538.22/third_party/blink/renderer/core/loader/mixed_content_checker.cc 2018-09-24 02:43:04.295333866 +0200
@@ -238,11 +238,12 @@ bool MixedContentChecker::IsMixedContent
const KURL& url) {
switch (settings.GetHttpsState()) {
case HttpsState::kNone:
- return false;
+ break;
case HttpsState::kModern:
return IsInsecureUrl(url);
}
+ return false;
}
// static
--- chromium-70.0.3538.22/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.cc.gcc8 2018-09-19 21:11:35.000000000 +0200
+++ chromium-70.0.3538.22/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.cc 2018-09-24 03:31:06.508249594 +0200
@@ -19,6 +19,7 @@ WTF::String OverscrollBehaviorTypeToStri
default:
NOTREACHED();
}
+ return "none";
}
} // namespace
--- chromium-70.0.3538.22/third_party/blink/renderer/platform/mediastream/media_stream_audio_processor_options.cc.gcc8 2018-09-19 21:10:43.000000000 +0200
+++ chromium-70.0.3538.22/third_party/blink/renderer/platform/mediastream/media_stream_audio_processor_options.cc 2018-09-24 03:46:13.701580453 +0200
@@ -89,12 +89,13 @@ AudioProcessingProperties::ToAudioProces
[](EchoCancellationType type) -> media::EchoCancellationType {
switch (type) {
case EchoCancellationType::kEchoCancellationDisabled:
- return media::EchoCancellationType::kDisabled;
+ break;
case EchoCancellationType::kEchoCancellationAec3:
return media::EchoCancellationType::kAec3;
case EchoCancellationType::kEchoCancellationSystem:
return media::EchoCancellationType::kSystemAec;
}
+ return media::EchoCancellationType::kDisabled;
};
out.echo_cancellation = convert_type(echo_cancellation_type);
--- chromium-72.0.3626.81/base/task/common/operations_controller.cc.gcc8 2019-01-30 02:17:39.000000000 +0100
+++ chromium-72.0.3626.81/base/task/common/operations_controller.cc 2019-02-02 14:38:56.245706064 +0100
@@ -49,13 +49,14 @@ OperationsController::OperationToken Ope
switch (ExtractState(prev_value)) {
case State::kRejectingOperations:
- return OperationToken(nullptr);
+ break;
case State::kAcceptingOperations:
return OperationToken(this);
case State::kShuttingDown:
DecrementBy(1);
- return OperationToken(nullptr);
+ break;
}
+ return OperationToken(nullptr);
}
void OperationsController::ShutdownAndWaitForZeroOperations() {
@@ -105,4 +106,4 @@ void OperationsController::DecrementBy(u
}
} // namespace internal
-} // namespace base
\ No newline at end of file
+} // namespace base
--- chromium-72.0.3626.81/media/base/decryptor.cc.gcc8 2019-01-30 02:18:05.000000000 +0100
+++ chromium-72.0.3626.81/media/base/decryptor.cc 2019-02-02 20:42:21.387394890 +0100
@@ -16,8 +16,9 @@ const char* Decryptor::GetStatusName(Sta
case kNeedMoreData:
return "need_more_data";
case kError:
- return "error";
+ break;
}
+ return "error";
}
Decryptor::Decryptor() = default;
--- chromium-72.0.3626.81/media/base/demuxer_stream.cc.gcc8 2019-01-30 02:18:05.000000000 +0100
+++ chromium-72.0.3626.81/media/base/demuxer_stream.cc 2019-02-02 21:00:32.673023251 +0100
@@ -16,8 +16,9 @@ const char* DemuxerStream::GetTypeName(T
case DemuxerStream::TEXT:
return "text";
case DemuxerStream::UNKNOWN:
- return "unknown";
+ break;
}
+ return "unknown";
}
// static
@@ -30,8 +31,9 @@ const char* DemuxerStream::GetStatusName
case DemuxerStream::kConfigChanged:
return "config_changed";
case DemuxerStream::kError:
- return "error";
+ break;
}
+ return "error";
}
DemuxerStream::~DemuxerStream() = default;
--- chromium-72.0.3626.81/ui/gfx/skia_vector_animation.cc.gcc8 2019-01-30 02:18:54.000000000 +0100
+++ chromium-72.0.3626.81/ui/gfx/skia_vector_animation.cc 2019-02-02 21:16:25.546267497 +0100
@@ -143,7 +143,7 @@
float SkiaVectorAnimation::GetCurrentProgress() const {
switch (state_) {
case PlayState::kStopped:
- return 0;
+ break;
case PlayState::kEnded:
DCHECK(timer_control_);
return timer_control_->GetNormalizedEndOffset();
@@ -164,6 +164,7 @@
DCHECK(timer_control_);
return timer_control_->GetNormalizedCurrentCycleProgress();
}
+ return 0;
}
void SkiaVectorAnimation::Paint(gfx::Canvas* canvas,
--- chromium-72.0.3626.81/net/dns/dns_util.cc.gcc8 2019-01-30 02:18:08.000000000 +0100
+++ chromium-72.0.3626.81/net/dns/dns_util.cc 2019-02-02 22:14:47.573401872 +0100
@@ -292,7 +292,7 @@ uint16_t DnsQueryTypeToQtype(DnsQueryTyp
switch (dns_query_type) {
case DnsQueryType::UNSPECIFIED:
NOTREACHED();
- return 0;
+ break;
case DnsQueryType::A:
return dns_protocol::kTypeA;
case DnsQueryType::AAAA:
@@ -308,6 +308,7 @@ uint16_t DnsQueryTypeToQtype(DnsQueryTyp
case DnsQueryType::HTTPS:
return dns_protocol::kTypeHttps;
}
+ return 0;
}
DnsQueryType AddressFamilyToDnsQueryType(AddressFamily address_family) {
@@ -390,6 +391,7 @@ std::string SecureDnsModeToString(const
case SecureDnsMode::kSecure:
return "Secure";
}
+ return "";
}
} // namespace net
--- chromium-72.0.3626.81/components/content_settings/core/browser/host_content_settings_map.cc.gcc8 2019-01-30 02:17:53.000000000 +0100
+++ chromium-72.0.3626.81/components/content_settings/core/browser/host_content_settings_map.cc 2019-02-02 22:20:52.201087706 +0100
@@ -230,8 +230,9 @@ const char* ContentSettingToString(Conte
case CONTENT_SETTING_DEFAULT:
case CONTENT_SETTING_NUM_SETTINGS:
NOTREACHED();
- return nullptr;
+ break;
}
+ return nullptr;
}
} // namespace
--- chromium-72.0.3626.81/components/flags_ui/feature_entry.cc.gcc8 2019-01-30 02:17:54.000000000 +0100
+++ chromium-72.0.3626.81/components/flags_ui/feature_entry.cc 2019-02-02 22:45:06.492019359 +0100
@@ -46,6 +46,7 @@ bool FeatureEntry::InternalNameMatches(c
base::StringToInt(name.substr(internal_name_length + 1), &index) &&
index >= 0 && index < NumOptions();
}
+ return false;
}
int FeatureEntry::NumOptions() const {
--- chromium-72.0.3626.81/components/viz/common/gl_scaler.cc.gcc8 2019-01-30 02:17:57.000000000 +0100
+++ chromium-72.0.3626.81/components/viz/common/gl_scaler.cc 2019-02-02 22:53:21.022474407 +0100
@@ -694,6 +694,7 @@ const char* GLScaler::GetShaderName(GLSc
CASE_RETURN_SHADER_STR(DEINTERLEAVE_PAIRWISE_MRT);
#undef CASE_RETURN_SHADER_STR
}
+ return "";
}
// static
--- chromium-72.0.3626.81/media/cdm/cdm_helpers.cc.gcc8 2019-01-30 02:18:05.000000000 +0100
+++ chromium-72.0.3626.81/media/cdm/cdm_helpers.cc 2019-02-02 23:15:02.798848133 +0100
@@ -18,7 +18,7 @@ constexpr cdm::ColorSpace kUnspecifiedCo
gfx::ColorSpace::RangeID ToGfxColorSpaceRange(cdm::ColorRange range) {
switch (range) {
case cdm::ColorRange::kInvalid:
- return gfx::ColorSpace::RangeID::INVALID;
+ break;
case cdm::ColorRange::kLimited:
return gfx::ColorSpace::RangeID::LIMITED;
case cdm::ColorRange::kFull:
@@ -26,6 +26,7 @@ gfx::ColorSpace::RangeID ToGfxColorSpace
case cdm::ColorRange::kDerived:
return gfx::ColorSpace::RangeID::DERIVED;
}
+ return gfx::ColorSpace::RangeID::INVALID;
}
} // namespace
--- chromium-72.0.3626.81/chrome/browser/download/offline_item_utils.cc.gcc8 2019-01-30 02:17:45.000000000 +0100
+++ chromium-72.0.3626.81/chrome/browser/download/offline_item_utils.cc 2019-02-02 23:38:55.268808679 +0100
@@ -148,6 +148,7 @@ FailState OfflineItemUtils::ConvertDownl
#include "components/download/public/common/download_interrupt_reason_values.h"
#undef INTERRUPT_REASON
}
+ return offline_items_collection::FailState::CRASH;
}
// static
@@ -160,13 +161,14 @@ OfflineItemUtils::ConvertFailStateToDown
// maps them to none error.
case offline_items_collection::FailState::CANNOT_DOWNLOAD:
case offline_items_collection::FailState::NETWORK_INSTABILITY:
- return download::DOWNLOAD_INTERRUPT_REASON_NONE;
+ break;
#define INTERRUPT_REASON(name, value) \
case offline_items_collection::FailState::name: \
return download::DOWNLOAD_INTERRUPT_REASON_##name;
#include "components/download/public/common/download_interrupt_reason_values.h"
#undef INTERRUPT_REASON
}
+ return download::DOWNLOAD_INTERRUPT_REASON_NONE;
}
// static
--- chromium-72.0.3626.81/chrome/browser/download/offline_item_model.cc.gcc8 2019-01-30 02:17:45.000000000 +0100
+++ chromium-72.0.3626.81/chrome/browser/download/offline_item_model.cc 2019-02-02 23:39:52.468800050 +0100
@@ -127,8 +127,7 @@ void OfflineItemModel::Remove() {
}
download::DownloadItem::DownloadState OfflineItemModel::GetState() const {
- if (!offline_item_)
- return download::DownloadItem::CANCELLED;
+ if (offline_item_) {
switch (offline_item_->state) {
case OfflineItemState::IN_PROGRESS:
FALLTHROUGH;
@@ -143,11 +142,13 @@ download::DownloadItem::DownloadState Of
case OfflineItemState::COMPLETE:
return download::DownloadItem::COMPLETE;
case OfflineItemState::CANCELLED:
- return download::DownloadItem::CANCELLED;
+ break;
case OfflineItemState::NUM_ENTRIES:
NOTREACHED();
- return download::DownloadItem::CANCELLED;
+ break;
}
+ }
+ return download::DownloadItem::CANCELLED;
}
bool OfflineItemModel::IsPaused() const {
--- chromium-72.0.3626.81/google_apis/gaia/google_service_auth_error.cc.gcc8 2019-01-30 02:18:02.000000000 +0100
+++ chromium-72.0.3626.81/google_apis/gaia/google_service_auth_error.cc 2019-02-02 23:59:47.403751632 +0100
@@ -28,8 +28,9 @@ const char* InvalidCredentialsReasonToSt
return "credentials missing";
case InvalidGaiaCredentialsReason::NUM_REASONS:
NOTREACHED();
- return "";
+ break;
}
+ return "";
}
} // namespace
@@ -155,8 +156,9 @@ std::string GoogleServiceAuthError::ToSt
error_message_.c_str());
case NUM_STATES:
NOTREACHED();
- return std::string();
+ break;
}
+ return std::string();
}
bool GoogleServiceAuthError::IsPersistentError() const {
--- chromium-72.0.3626.81/components/signin/internal/identity_manager/profile_oauth2_token_service.cc.gcc8 2019-01-30 02:17:55.000000000 +0100
+++ chromium-72.0.3626.81/components/signin/internal/identity_manager/profile_oauth2_token_service.cc 2019-02-03 00:03:23.484949466 +0100
@@ -68,6 +68,7 @@ std::string SourceToString(SourceForRefr
case SourceForRefreshTokenOperation::kLogoutTabHelper_DidFinishNavigation:
return "LogoutTabHelper::DidFinishNavigation";
}
+ return "";
}
} // namespace
@@ -443,6 +444,7 @@ bool ProfileOAuth2TokenService::HasLoadC
// Load credentials finished with success.
return true;
}
+ return false;
}
void ProfileOAuth2TokenService::RecreateDeviceIdIfNeeded() {
--- chromium-72.0.3626.81/services/network/resource_scheduler/resource_scheduler.cc.gcc8 2019-01-30 02:18:10.000000000 +0100
+++ chromium-72.0.3626.81/services/network/resource_scheduler/resource_scheduler.cc 2019-02-03 00:31:21.169154387 +0100
@@ -94,6 +94,7 @@ const char* RequestStartTriggerString(Re
case RequestStartTrigger::PEER_TO_PEER_CONNECTIONS_COUNT_CHANGED:
return "PEER_TO_PEER_CONNECTIONS_COUNT_CHANGED";
}
+ return "";
}
} // namespace
--- chromium-72.0.3626.81/services/network/mdns_responder.cc.gcc8 2019-01-30 02:18:10.000000000 +0100
+++ chromium-72.0.3626.81/services/network/mdns_responder.cc 2019-02-03 00:46:06.195423989 +0100
@@ -434,8 +434,9 @@ class MdnsResponderManager::SocketHandle
return RateLimitScheme::NO_LIMIT;
case MdnsResponseSendOption::ResponseClass::UNSPECIFIED:
NOTREACHED();
- return RateLimitScheme::PER_RESPONSE;
+ break;
}
+ return RateLimitScheme::PER_RESPONSE;
}
// Returns null if the computed delay exceeds kMaxScheduledDelay and the next
// available time is not updated.
--- chromium-72.0.3626.81/services/network/public/cpp/cors/cors.cc.gcc8 2019-01-30 02:18:10.000000000 +0100
+++ chromium-72.0.3626.81/services/network/public/cpp/cors/cors.cc 2019-02-03 00:51:01.746177854 +0100
@@ -590,8 +590,9 @@ bool IsCorsSameOriginResponseType(mojom:
case mojom::FetchResponseType::kError:
case mojom::FetchResponseType::kOpaque:
case mojom::FetchResponseType::kOpaqueRedirect:
- return false;
+ break;
}
+ return false;
}
bool IsCorsCrossOriginResponseType(mojom::FetchResponseType type) {
@@ -605,6 +606,7 @@ bool IsCorsCrossOriginResponseType(mojom
case mojom::FetchResponseType::kOpaqueRedirect:
return true;
}
+ return false;
}
bool CalculateCredentialsFlag(mojom::CredentialsMode credentials_mode,
@@ -622,6 +624,7 @@ bool CalculateCredentialsFlag(mojom::Cre
case network::mojom::CredentialsMode::kInclude:
return true;
}
+ return false;
}
mojom::FetchResponseType CalculateResponseType(
--- chromium-72.0.3626.81/components/autofill/core/browser/autofill_metrics.cc.gcc8 2019-01-30 02:17:53.000000000 +0100
+++ chromium-72.0.3626.81/components/autofill/core/browser/autofill_metrics.cc 2019-02-03 01:03:08.861265327 +0100
@@ -1886,6 +1886,7 @@ const char* AutofillMetrics::GetMetricsS
case AutofillSyncSigninState::kNumSyncStates:
return ".Unknown";
}
+ return "";
}
void AutofillMetrics::FormInteractionsUkmLogger::LogFormSubmitted(
--- chromium-72.0.3626.81/components/autofill/core/browser/autofill_external_delegate.cc.gcc8 2019-01-30 02:17:53.000000000 +0100
+++ chromium-72.0.3626.81/components/autofill/core/browser/autofill_external_delegate.cc 2019-02-03 01:08:04.009018236 +0100
@@ -456,8 +456,9 @@ base::string16 AutofillExternalDelegate:
case PopupType::kPasswords:
NOTREACHED();
- return base::string16();
+ break;
}
+ return base::string16();
}
} // namespace autofill
--- chromium-72.0.3626.81/components/signin/core/browser/about_signin_internals.cc.gcc8 2019-01-30 02:17:55.000000000 +0100
+++ chromium-72.0.3626.81/components/signin/core/browser/about_signin_internals.cc 2019-02-03 01:44:34.307213001 +0100
@@ -565,6 +565,7 @@ std::string AboutSigninInternals::Refres
case AboutSigninInternals::RefreshTokenEventType::kAllTokensLoaded:
return "Loaded";
}
+ return "";
}
AboutSigninInternals::SigninStatus::SigninStatus()
--- chromium-72.0.3626.81/media/capture/video/video_capture_device.cc.gcc8 2019-01-30 02:18:05.000000000 +0100
+++ chromium-72.0.3626.81/media/capture/video/video_capture_device.cc 2019-02-03 03:08:50.035235591 +0100
@@ -79,12 +79,13 @@ VideoCaptureFrameDropReason ConvertReser
VideoCaptureDevice::Client::ReserveResult reserve_result) {
switch (reserve_result) {
case VideoCaptureDevice::Client::ReserveResult::kSucceeded:
- return VideoCaptureFrameDropReason::kNone;
+ break;
case VideoCaptureDevice::Client::ReserveResult::kMaxBufferCountExceeded:
return VideoCaptureFrameDropReason::kBufferPoolMaxBufferCountExceeded;
case VideoCaptureDevice::Client::ReserveResult::kAllocationFailed:
return VideoCaptureFrameDropReason::kBufferPoolBufferAllocationFailed;
}
+ return VideoCaptureFrameDropReason::kNone;
}
} // namespace media
--- chromium-72.0.3626.81/chrome/browser/background_fetch/background_fetch_download_client.cc.gcc8 2019-01-30 02:17:44.000000000 +0100
+++ chromium-72.0.3626.81/chrome/browser/background_fetch/background_fetch_download_client.cc 2019-02-03 03:58:51.476458736 +0100
@@ -37,6 +37,7 @@ BackgroundFetchFailureReason ToBackgroun
case download::Client::FailureReason::CANCELLED:
return BackgroundFetchFailureReason::CANCELLED;
}
+ return BackgroundFetchFailureReason::NONE;
}
} // namespace
--- chromium-72.0.3626.81/chrome/browser/ui/content_settings/content_setting_image_model.cc.gcc8 2019-01-30 02:17:48.000000000 +0100
+++ chromium-72.0.3626.81/chrome/browser/ui/content_settings/content_setting_image_model.cc 2019-02-03 13:19:17.853486404 +0100
@@ -473,8 +473,9 @@ bool ContentSettingDownloadsImageModel::
return true;
case DownloadRequestLimiter::DOWNLOAD_UI_DEFAULT:
// No need to show icon otherwise.
- return false;
+ break;
}
+ return false;
}
// Clipboard -------------------------------------------------------------------
--- chromium-72.0.3626.81/chrome/browser/ui/views/autofill/payments/local_card_migration_dialog_view.cc.gcc8 2019-02-02 18:45:44.808518991 +0100
+++ chromium-72.0.3626.81/chrome/browser/ui/views/autofill/payments/local_card_migration_dialog_view.cc 2019-02-03 13:37:24.541069762 +0100
@@ -486,6 +486,7 @@ base::string16 LocalCardMigrationDialogV
return l10n_util::GetStringUTF16(
IDS_AUTOFILL_LOCAL_CARD_MIGRATION_DIALOG_BUTTON_LABEL_VIEW_CARDS);
}
+ return base::string16();
}
LocalCardMigrationDialog* CreateLocalCardMigrationDialogView(
--- chromium-72.0.3626.81/chrome/browser/ui/views/overlay/resize_handle_button.cc.gcc8 2019-01-30 02:17:48.000000000 +0100
+++ chromium-72.0.3626.81/chrome/browser/ui/views/overlay/resize_handle_button.cc 2019-02-03 13:59:23.275462434 +0100
@@ -58,6 +58,7 @@ int ResizeHandleButton::GetHTComponent()
case OverlayWindowViews::WindowQuadrant::kTopRight:
return HTBOTTOMLEFT;
}
+ return HTNOWHERE;
}
void ResizeHandleButton::SetPosition(
--- chromium-72.0.3626.81/components/omnibox/browser/autocomplete_match.cc.gcc8 2019-01-30 02:17:54.000000000 +0100
+++ chromium-72.0.3626.81/components/omnibox/browser/autocomplete_match.cc 2019-02-03 14:29:59.471866490 +0100
@@ -427,6 +427,7 @@ base::string16 AutocompleteMatch::GetWhy
NOTREACHED();
return base::string16();
}
+ return base::string16();
}
// static
--- chromium-72.0.3626.81/content/browser/media/audio_output_stream_broker.cc.gcc8 2019-01-30 02:17:59.000000000 +0100
+++ chromium-72.0.3626.81/content/browser/media/audio_output_stream_broker.cc 2019-02-03 15:05:15.757520763 +0100
@@ -52,8 +52,9 @@ StreamBrokerDisconnectReason GetDisconne
kDocumentDestroyedAwaitingCreated
: StreamBrokerDisconnectReason::kDocumentDestroyed;
case DisconnectReason::kDefault:
- return StreamBrokerDisconnectReason::kDefault;
+ break;
}
+ return StreamBrokerDisconnectReason::kDefault;
}
} // namespace
--- chromium-72.0.3626.81/gin/v8_isolate_memory_dump_provider.cc.gcc8 2019-01-30 02:18:02.000000000 +0100
+++ chromium-72.0.3626.81/gin/v8_isolate_memory_dump_provider.cc 2019-02-03 15:53:52.549316792 +0100
@@ -133,6 +133,7 @@ std::string IsolateTypeString(IsolateHol
return "utility";
}
LOG(FATAL) << "Unreachable code";
+ return "";
}
bool CanHaveMultipleIsolates(IsolateHolder::IsolateType isolate_type) {
@@ -149,6 +150,7 @@ bool CanHaveMultipleIsolates(IsolateHold
return false;
}
LOG(FATAL) << "Unreachable code";
+ return false;
}
} // namespace anonymous
--- chromium-72.0.3626.81/third_party/blink/renderer/modules/mediastream/media_stream_constraints_util_audio.cc.gcc8 2019-01-30 02:18:00.000000000 +0100
+++ chromium-72.0.3626.81/third_party/blink/renderer/modules/mediastream/media_stream_constraints_util_audio.cc 2019-02-03 17:27:24.429355560 +0100
@@ -411,6 +411,7 @@ class EchoCancellationContainer {
case EchoCancellationType::kEchoCancellationAec3:
return Score::EcModeScore::kAec3;
}
+ return Score::EcModeScore::kDisabled;
}
static EchoCancellationTypeSet ToEchoCancellationTypes(const BoolSet ec_set) {
--- chromium-72.0.3626.81/third_party/blink/renderer/core/css/properties/longhands/custom_property.cc.gcc8 2019-01-30 02:18:14.000000000 +0100
+++ chromium-72.0.3626.81/third_party/blink/renderer/core/css/properties/longhands/custom_property.cc 2019-02-03 20:14:27.832403200 +0100
@@ -162,6 +162,7 @@ const CSSValue* CustomProperty::ParseSin
return nullptr;
return ParseUntyped(range, context, local_context);
}
+ return nullptr;
}
bool CustomProperty::ComputedValuesEqual(const ComputedStyle& a,
--- chromium-72.0.3626.81/third_party/blink/renderer/core/layout/layout_flexible_box.cc.gcc8 2019-01-30 02:18:15.000000000 +0100
+++ chromium-72.0.3626.81/third_party/blink/renderer/core/layout/layout_flexible_box.cc 2019-02-03 21:13:06.415736350 +0100
@@ -604,6 +604,7 @@ LayoutUnit LayoutFlexibleBox::FlowAwareC
return ContentInsetRight();
}
NOTREACHED();
+ return LayoutUnit();
}
DISABLE_CFI_PERF
@@ -619,6 +620,7 @@ LayoutUnit LayoutFlexibleBox::FlowAwareC
return ContentLeft();
}
NOTREACHED();
+ return LayoutUnit();
}
LayoutUnit LayoutFlexibleBox::CrossAxisScrollbarExtent() const {
--- chromium-72.0.3626.81/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc.gcc5 2019-01-30 02:18:16.000000000 +0100
+++ chromium-72.0.3626.81/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc 2019-02-03 22:41:04.273198056 +0100
@@ -571,6 +571,7 @@ RTCSetSessionDescriptionOperation GetRTC
return RTCSetSessionDescriptionOperation::
kSetRemoteDescriptionInvalidType;
}
+ return RTCSetSessionDescriptionOperation::kSetLocalDescriptionOffer;
}
} // namespace
@@ -596,6 +597,7 @@ SdpUsageCategory DeduceSdpUsageCategory(
? SdpUsageCategory::kSafe
: SdpUsageCategory::kUnsafe;
}
+ return SdpUsageCategory::kUnsafe;
}
RTCPeerConnection::EventWrapper::EventWrapper(Event* event,
--- chromium-72.0.3626.81/third_party/blink/renderer/modules/worklet/animation_and_paint_worklet_thread.cc.gcc8 2019-01-30 02:18:16.000000000 +0100
+++ chromium-72.0.3626.81/third_party/blink/renderer/modules/worklet/animation_and_paint_worklet_thread.cc 2019-02-03 23:05:45.671830140 +0100
@@ -96,7 +96,8 @@ AnimationAndPaintWorkletThread::CreateWo
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("paint-worklet"),
"AnimationAndPaintWorkletThread::CreateWorkerGlobalScope");
return PaintWorkletGlobalScope::Create(std::move(creation_params), this);
- };
+ }
+ return nullptr;
}
void AnimationAndPaintWorkletThread::EnsureSharedBackingThread() {
--- chromium-73.0.3683.75/media/audio/audio_input_device.cc.gcc8 2019-03-11 23:00:59.000000000 +0100
+++ chromium-73.0.3683.75/media/audio/audio_input_device.cc 2019-03-17 18:22:38.765345928 +0100
@@ -51,8 +51,9 @@ base::ThreadPriority ThreadPriorityFromP
case AudioInputDevice::Purpose::kUserInput:
return base::ThreadPriority::REALTIME_AUDIO;
case AudioInputDevice::Purpose::kLoopback:
- return base::ThreadPriority::NORMAL;
+ break;
}
+ return base::ThreadPriority::NORMAL;
}
} // namespace
--- chromium-73.0.3683.75/net/dns/host_resolver_mdns_listener_impl.cc.gcc8 2019-03-11 23:01:01.000000000 +0100
+++ chromium-73.0.3683.75/net/dns/host_resolver_mdns_listener_impl.cc 2019-03-17 19:27:38.168722885 +0100
@@ -25,6 +25,7 @@ HostResolver::MdnsListener::Delegate::Up
case net::MDnsListener::RECORD_REMOVED:
return HostResolver::MdnsListener::Delegate::UpdateType::REMOVED;
}
+ return net::HostResolver::MdnsListener::Delegate::UpdateType(0);
}
} // namespace
--- chromium-73.0.3683.75/net/dns/host_resolver_mdns_task.cc.gcc8 2019-03-11 23:01:01.000000000 +0100
+++ chromium-73.0.3683.75/net/dns/host_resolver_mdns_task.cc 2019-03-17 19:29:16.803025405 +0100
@@ -219,6 +219,7 @@ HostCache::Entry HostResolverMdnsTask::P
return ParseHostnameResult(parsed->rdata<SrvRecordRdata>()->target(),
parsed->rdata<SrvRecordRdata>()->port());
}
+ return HostCache::Entry(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
}
void HostResolverMdnsTask::CheckCompletion(bool post_needed) {
--- chromium-73.0.3683.75/services/media_session/audio_focus_manager.cc.gcc8 2019-03-11 23:01:01.000000000 +0100
+++ chromium-73.0.3683.75/services/media_session/audio_focus_manager.cc 2019-03-17 19:52:48.908690179 +0100
@@ -312,8 +312,9 @@ bool AudioFocusManager::ShouldSessionBeS
return false;
case mojom::EnforcementMode::kDefault:
NOTIMPLEMENTED();
- return false;
+ break;
}
+ return false;
}
bool AudioFocusManager::ShouldSessionBeDucked(
@@ -329,8 +330,9 @@ bool AudioFocusManager::ShouldSessionBeD
return false;
case mojom::EnforcementMode::kDefault:
NOTIMPLEMENTED();
- return false;
+ break;
}
+ return false;
}
void AudioFocusManager::EnforceSingleSession(AudioFocusRequest* session,
--- chromium-73.0.3683.75/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc.gcc8-5 2019-03-17 16:29:17.913280114 +0100
+++ chromium-73.0.3683.75/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc 2019-03-17 20:17:22.060274195 +0100
@@ -280,8 +280,9 @@ bool UpdateServerMetadata(AutofillTable*
return table->UpdateServerCardMetadata(metadata);
case WalletMetadataSpecifics::UNKNOWN:
NOTREACHED();
- return false;
+ break;
}
+ return false;
}
} // namespace
--- chromium-73.0.3683.75/components/invalidation/public/invalidator_state.cc.gcc8 2019-03-11 23:00:56.000000000 +0100
+++ chromium-73.0.3683.75/components/invalidation/public/invalidator_state.cc 2019-03-17 20:27:30.702671478 +0100
@@ -27,6 +27,7 @@ const char* InvalidatorStateToString(Inv
case NOT_STARTED_NO_REFRESH_TOKEN:
return "NOT_STARTED_NO_REFRESH_TOKEN";
}
+ return "";
}
} // namespace syncer
--- chromium-73.0.3683.75/components/invalidation/impl/fcm_network_handler.cc.gcc8 2019-03-11 23:00:56.000000000 +0100
+++ chromium-73.0.3683.75/components/invalidation/impl/fcm_network_handler.cc 2019-03-17 20:43:19.481009130 +0100
@@ -288,6 +288,7 @@ std::string FCMNetworkHandlerDiagnostic:
case instance_id::InstanceID::NETWORK_ERROR:
return "InstanceID::NETWORK_ERROR";
}
+ return "";
}
} // namespace syncer
--- chromium-73.0.3683.75/components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate.cc.gcc8 2019-03-11 23:00:57.000000000 +0100
+++ chromium-73.0.3683.75/components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate.cc 2019-03-17 20:49:48.146201385 +0100
@@ -292,8 +292,9 @@ bool MutableProfileOAuth2TokenServiceDel
case GaiaAuthConsumer::TokenRevocationStatus::kInvalidToken:
case GaiaAuthConsumer::TokenRevocationStatus::kInvalidRequest:
case GaiaAuthConsumer::TokenRevocationStatus::kUnknownError:
- return false;
+ break;
}
+ return false;
}
void MutableProfileOAuth2TokenServiceDelegate::RevokeServerRefreshToken::
--- chromium-73.0.3683.75/ui/accessibility/mojom/ax_tree_id_mojom_traits.h.gcc8 2019-03-11 23:01:18.000000000 +0100
+++ chromium-73.0.3683.75/ui/accessibility/mojom/ax_tree_id_mojom_traits.h 2019-03-17 21:04:36.260411552 +0100
@@ -16,10 +16,11 @@ struct UnionTraits<ax::mojom::AXTreeIDDa
static ax::mojom::AXTreeIDDataView::Tag GetTag(const ui::AXTreeID& p) {
switch (p.type()) {
case ax::mojom::AXTreeIDType::kUnknown:
- return ax::mojom::AXTreeIDDataView::Tag::UNKNOWN;
+ break;
case ax::mojom::AXTreeIDType::kToken:
return ax::mojom::AXTreeIDDataView::Tag::TOKEN;
}
+ return ax::mojom::AXTreeIDDataView::Tag::UNKNOWN;
}
static uint8_t unknown(const ui::AXTreeID& p) { return 0; }
static const base::UnguessableToken token(const ui::AXTreeID& p) {
--- chromium-73.0.3683.75/ui/views/layout/flex_layout_types.cc.gcc8 2019-03-11 23:01:19.000000000 +0100
+++ chromium-73.0.3683.75/ui/views/layout/flex_layout_types.cc 2019-03-17 21:25:16.948916466 +0100
@@ -59,6 +59,7 @@ int InterpolateSize(MinimumFlexSizeRule
case MaximumFlexSizeRule::kUnbounded:
return available_size;
}
+ return 0;
}
// A view's minimum size can in some cases be expensive to compute. This
--- chromium-73.0.3683.75/components/safe_browsing/content/browser/threat_details.cc.gcc8 2019-03-11 23:00:57.000000000 +0100
+++ chromium-73.0.3683.75/components/safe_browsing/content/browser/threat_details.cc 2019-03-17 22:50:32.914419357 +0100
@@ -115,8 +115,9 @@ ClientSafeBrowsingReportRequest::ReportT
// Gated by SafeBrowsingBlockingPage::ShouldReportThreatDetails.
NOTREACHED() << "We should not send report for threat type: "
<< threat_type;
- return ClientSafeBrowsingReportRequest::UNKNOWN;
+ break;
}
+ return ClientSafeBrowsingReportRequest::UNKNOWN;
}
// Clears the specified HTTPS resource of any sensitive data, only retaining
--- chromium-73.0.3683.75/content/browser/cache_storage/cache_storage_cache_entry_handler.cc.gcc8 2019-03-11 23:00:57.000000000 +0100
+++ chromium-73.0.3683.75/content/browser/cache_storage/cache_storage_cache_entry_handler.cc 2019-03-17 23:06:10.861905396 +0100
@@ -364,6 +364,7 @@ CacheStorageCacheEntryHandler::CreateCac
std::move(blob_storage_context));
}
NOTREACHED();
+ return nullptr;
}
blink::mojom::SerializedBlobPtr CacheStorageCacheEntryHandler::CreateBlob(
--- chromium-73.0.3683.75/content/browser/media/hardware_key_media_controller.cc.gcc8 2019-03-11 23:00:57.000000000 +0100
+++ chromium-73.0.3683.75/content/browser/media/hardware_key_media_controller.cc 2019-03-17 23:20:53.762650819 +0100
@@ -194,6 +194,7 @@ HardwareKeyMediaController::MediaSession
case MediaSessionAction::kSwitchAudioDevice:
return base::nullopt;
}
+ return base::nullopt;
}
} // namespace content
--- chromium-73.0.3683.75/content/browser/cache_storage/cache_storage_histogram_utils.cc.gcc8 2019-03-11 23:00:57.000000000 +0100
+++ chromium-73.0.3683.75/content/browser/cache_storage/cache_storage_histogram_utils.cc 2019-03-17 23:40:14.543806924 +0100
@@ -34,6 +34,7 @@ base::StringPiece UMAToName(CacheStorage
case CacheStorageSchedulerUMA::kQueueLength:
RETURN_LITERAL_STRING_PIECE("QueueLength");
}
+ return "";
}
base::StringPiece ClientToName(CacheStorageSchedulerClient client_type) {
@@ -45,6 +46,7 @@ base::StringPiece ClientToName(CacheStor
case CacheStorageSchedulerClient::kStorage:
RETURN_LITERAL_STRING_PIECE("CacheStorage");
}
+ return "";
}
bool ShouldRecordOpUMA(CacheStorageSchedulerOp op_type) {
@@ -83,12 +85,13 @@ base::StringPiece OpToName(CacheStorageS
RETURN_LITERAL_STRING_PIECE("SizeThenClose");
case CacheStorageSchedulerOp::kTest:
NOTREACHED();
- return "";
+ break;
case CacheStorageSchedulerOp::kWriteIndex:
RETURN_LITERAL_STRING_PIECE("WriteIndex");
case CacheStorageSchedulerOp::kWriteSideData:
RETURN_LITERAL_STRING_PIECE("WriteSideData");
}
+ return "";
}
std::string GetClientHistogramName(CacheStorageSchedulerUMA uma_type,
--- chromium-73.0.3683.75/third_party/blink/renderer/modules/mediastream/media_stream_constraints_util_audio.cc.gcc8-5 2019-03-17 16:29:20.433235465 +0100
+++ chromium-73.0.3683.75/third_party/blink/renderer/modules/mediastream/media_stream_constraints_util_audio.cc 2019-03-18 02:02:58.536812396 +0100
@@ -994,6 +994,7 @@ class ProcessingBasedContainer {
GetMinMaxLatenciesForAudioParameters(device_parameters);
return DoubleRangeSet(min_latency, max_latency);
}
+ return DoubleRangeSet();
}
// The priority of each processing-based container depends on the default
@@ -1014,6 +1015,7 @@ class ProcessingBasedContainer {
case ProcessingType::kApmProcessed:
return use_processing_by_default ? 3 : 1;
}
+ return 0;
}
ProcessingType processing_type_;
--- chromium-74.0.3729.40/base/files/file_posix.cc.gcc8 2019-03-27 19:49:54.000000000 +0100
+++ chromium-74.0.3729.40/base/files/file_posix.cc 2019-03-30 18:59:49.372411413 +0100
@@ -73,15 +73,16 @@ int CallFutimes(PlatformFile file, const
#if !defined(OS_FUCHSIA)
short FcntlFlockType(base::Optional<File::LockMode> mode) {
- if (!mode.has_value())
- return F_UNLCK;
- switch (mode.value()) {
- case File::LockMode::kShared:
- return F_RDLCK;
- case File::LockMode::kExclusive:
- return F_WRLCK;
+ if (mode.has_value())
+ {
+ switch (mode.value()) {
+ case File::LockMode::kShared:
+ return F_RDLCK;
+ case File::LockMode::kExclusive:
+ return F_WRLCK;
+ }
}
- NOTREACHED();
+ return F_UNLCK;
}
File::Error CallFcntlFlock(PlatformFile file,
--- chromium-74.0.3729.40/net/http/http_auth_gssapi_posix.cc.gcc8 2019-03-27 19:50:21.000000000 +0100
+++ chromium-74.0.3729.40/net/http/http_auth_gssapi_posix.cc 2019-03-30 22:18:16.792399022 +0100
@@ -51,6 +51,7 @@ OM_uint32 DelegationTypeToFlag(Delegatio
case DelegationType::kUnconstrained:
return GSS_C_DELEG_FLAG;
}
+ return 0;
}
// ScopedBuffer releases a gss_buffer_t when it goes out of scope.
--- chromium-74.0.3729.40/cc/animation/animation_host.cc.gcc8 2019-03-27 19:49:55.000000000 +0100
+++ chromium-74.0.3729.40/cc/animation/animation_host.cc 2019-03-30 22:24:50.617663405 +0100
@@ -44,6 +44,7 @@ AnimationWorkletMutationState ToAnimatio
case MutateStatus::kCanceled:
return AnimationWorkletMutationState::CANCELED;
}
+ return AnimationWorkletMutationState::CANCELED;
}
} // namespace
--- chromium-74.0.3729.40/components/offline_pages/core/offline_page_metadata_store.cc.gcc8 2019-03-27 19:50:09.000000000 +0100
+++ chromium-74.0.3729.40/components/offline_pages/core/offline_page_metadata_store.cc 2019-03-30 22:36:14.216962023 +0100
@@ -322,8 +322,9 @@ StoreState InitializationStatusToStoreSt
case SqlStoreBase::InitializationStatus::kSuccess:
return StoreState::LOADED;
case SqlStoreBase::InitializationStatus::kFailure:
- return StoreState::FAILED_LOADING;
+ break;
}
+ return StoreState::FAILED_LOADING;
}
} // anonymous namespace
--- chromium-74.0.3729.40/gpu/config/gpu_info.cc.gcc8 2019-03-30 20:21:44.234853325 +0100
+++ chromium-74.0.3729.40/gpu/config/gpu_info.cc 2019-03-30 22:42:03.847983019 +0100
@@ -70,6 +71,7 @@ const char* ImageDecodeAcceleratorSubsam
case gpu::ImageDecodeAcceleratorSubsampling::k444:
return "4:4:4";
}
+ return "";
}
void EnumerateImageDecodeAcceleratorSupportedProfile(
--- chromium-74.0.3729.40/gpu/ipc/common/gpu_info_mojom_traits.cc.gcc8 2019-03-27 19:50:17.000000000 +0100
+++ chromium-74.0.3729.40/gpu/ipc/common/gpu_info_mojom_traits.cc 2019-03-30 22:57:47.426922376 +0100
@@ -242,6 +242,7 @@ gpu::mojom::ImageDecodeAcceleratorType E
case gpu::ImageDecodeAcceleratorType::kUnknown:
return gpu::mojom::ImageDecodeAcceleratorType::kUnknown;
}
+ return gpu::mojom::ImageDecodeAcceleratorType::kUnknown;
}
// static
@@ -277,6 +278,7 @@ EnumTraits<gpu::mojom::ImageDecodeAccele
case gpu::ImageDecodeAcceleratorSubsampling::k444:
return gpu::mojom::ImageDecodeAcceleratorSubsampling::k444;
}
+ return gpu::mojom::ImageDecodeAcceleratorSubsampling(0);
}
// static
--- chromium-74.0.3729.40/ui/events/event.cc.gcc8 2019-03-27 19:51:07.000000000 +0100
+++ chromium-74.0.3729.40/ui/events/event.cc 2019-03-30 23:07:57.324532445 +0100
@@ -124,6 +124,7 @@ std::string MomentumPhaseToString(EventM
case EventMomentumPhase::BLOCKED:
return "BLOCKED";
}
+ return "";
}
std::string ScrollEventPhaseToString(ScrollEventPhase phase) {
@@ -137,6 +138,7 @@ std::string ScrollEventPhaseToString(Scr
case ScrollEventPhase::kEnd:
return "kEnd";
}
+ return "";
}
#if defined(USE_OZONE)
--- chromium-74.0.3729.40/components/feed/core/feed_scheduler_host.cc.gcc8 2019-03-27 19:50:08.000000000 +0100
+++ chromium-74.0.3729.40/components/feed/core/feed_scheduler_host.cc 2019-03-30 23:17:48.137459119 +0100
@@ -88,6 +88,7 @@ ParamPair LookupParam(UserClass user_cla
return {"fixed_timer_hours_active_suggestions_consumer", 24.0};
}
}
+ return {"", 0.0};
}
// Coverts from base::StringPiece to TriggerType and adds it to the set if the
@@ -139,6 +140,7 @@ std::string UserClassToHistogramSuffix(U
case UserClass::kActiveSuggestionsConsumer:
return "ActiveSuggestionsConsumer";
}
+ return "";
}
// This has a small performance penalty because it is looking up the histogram
--- chromium-74.0.3729.40/components/invalidation/impl/channels_states.cc.gcc8 2019-03-27 19:50:08.000000000 +0100
+++ chromium-74.0.3729.40/components/invalidation/impl/channels_states.cc 2019-03-30 23:43:22.970239573 +0100
@@ -15,6 +15,7 @@ const char* FcmChannelStateToString(FcmC
case FcmChannelState::NO_INSTANCE_ID_TOKEN:
return "NO_INSTANCE_ID_TOKEN";
}
+ return "";
}
const char* SubscriptionChannelStateToString(SubscriptionChannelState state) {
@@ -28,6 +29,7 @@ const char* SubscriptionChannelStateToSt
case SubscriptionChannelState::SUBSCRIPTION_FAILURE:
return "SUBSCRIPTION_FAILURE";
}
+ return "";
}
} // namespace syncer
--- chromium-74.0.3729.40/components/offline_pages/core/prefetch/prefetch_types.cc.gcc8 2019-03-27 19:50:09.000000000 +0100
+++ chromium-74.0.3729.40/components/offline_pages/core/prefetch/prefetch_types.cc 2019-03-31 00:28:46.571488517 +0100
@@ -21,6 +21,7 @@ std::string PrefetchEnumToString(Prefetc
return "SUSPEND";
}
DCHECK(false) << static_cast<int>(value) << " not valid enum value";
+ return "";
}
std::string PrefetchEnumToString(PrefetchRequestStatus value) {
@@ -45,6 +46,7 @@ std::string PrefetchEnumToString(Prefetc
return "EMPTY_REQUEST_SUCCESS";
}
DCHECK(false) << static_cast<int>(value) << " not valid enum value";
+ return "";
}
std::string PrefetchEnumToString(RenderStatus value) {
@@ -59,6 +61,7 @@ std::string PrefetchEnumToString(RenderS
return "EXCEEDED_LIMIT";
}
DCHECK(false) << static_cast<int>(value) << " not valid enum value";
+ return "";
}
std::string PrefetchEnumToString(PrefetchItemState value) {
@@ -87,6 +90,7 @@ std::string PrefetchEnumToString(Prefetc
return "ZOMBIE";
}
DCHECK(false) << static_cast<int>(value) << " not valid enum value";
+ return "";
}
std::string PrefetchEnumToString(PrefetchItemErrorCode value) {
@@ -136,6 +140,7 @@ std::string PrefetchEnumToString(Prefetc
return "SUGGESTION_INVALIDATED";
}
DCHECK(false) << static_cast<int>(value) << " not valid enum value";
+ return "";
}
} // namespace
--- chromium-74.0.3729.40/content/browser/renderer_host/render_widget_host_input_event_router.cc.gcc8 2019-03-27 19:50:13.000000000 +0100
+++ chromium-74.0.3729.40/content/browser/renderer_host/render_widget_host_input_event_router.cc 2019-03-31 00:44:38.885975057 +0100
@@ -240,12 +240,13 @@ bool RenderWidgetHostInputEventRouter::T
switch (state_) {
case PinchState::NONE:
case PinchState::EXISTING_BUBBLING_TO_ROOT:
- return false;
+ break;
case PinchState::PINCH_WITH_ROOT_GESTURE_TARGET:
case PinchState::PINCH_WHILE_BUBBLING_TO_ROOT:
case PinchState::PINCH_DURING_CHILD_GESTURE:
return true;
}
+ return false;
}
bool RenderWidgetHostInputEventRouter::TouchscreenPinchState::
@@ -253,12 +254,13 @@ bool RenderWidgetHostInputEventRouter::T
switch (state_) {
case PinchState::NONE:
case PinchState::PINCH_DURING_CHILD_GESTURE:
- return true;
+ break;
case PinchState::EXISTING_BUBBLING_TO_ROOT:
case PinchState::PINCH_WITH_ROOT_GESTURE_TARGET:
case PinchState::PINCH_WHILE_BUBBLING_TO_ROOT:
return false;
}
+ return true;
}
void RenderWidgetHostInputEventRouter::TouchscreenPinchState::
--- chromium-74.0.3729.40/content/browser/scheduler/browser_task_executor.cc.gcc8 2019-03-27 19:50:13.000000000 +0100
+++ chromium-74.0.3729.40/content/browser/scheduler/browser_task_executor.cc 2019-03-31 00:52:18.669014798 +0100
@@ -154,6 +154,7 @@ QueueType BaseBrowserTaskExecutor::GetQu
case base::TaskPriority::USER_BLOCKING:
return QueueType::kUserBlocking;
}
+ return QueueType::kDefault;
}
BrowserTaskExecutor::BrowserTaskExecutor(
--- chromium-74.0.3729.40/chrome/browser/page_load_metrics/observers/core/ukm_page_load_metrics_observer.cc.gcc8 2019-03-27 19:50:01.000000000 +0100
+++ chromium-74.0.3729.40/chrome/browser/page_load_metrics/observers/core/ukm_page_load_metrics_observer.cc 2019-03-31 15:46:19.093529518 +0200
@@ -63,6 +63,7 @@ bool IsSupportedProtocol(page_load_metri
case page_load_metrics::NetworkProtocol::kOther:
return false;
}
+ return false;
}
bool IsDefaultSearchEngine(content::BrowserContext* browser_context,
--- chromium-74.0.3729.40/chrome/browser/ui/webui/signin/inline_login_ui.cc.gcc8 2019-03-27 19:50:04.000000000 +0100
+++ chromium-74.0.3729.40/chrome/browser/ui/webui/signin/inline_login_ui.cc 2019-03-31 16:47:21.473612864 +0200
@@ -92,6 +92,7 @@ bool IsValidChromeSigninReason(const GUR
return false;
}
NOTREACHED();
+ return false;
#endif // defined(OS_CHROMEOS)
}
--- chromium-74.0.3729.40/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc.gcc8 2019-03-27 19:50:04.000000000 +0100
+++ chromium-74.0.3729.40/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc 2019-03-31 17:11:00.874898328 +0200
@@ -117,6 +117,7 @@ signin_metrics::Reason GetSigninReasonFr
case HandlerSigninReason::FETCH_LST_ONLY:
return signin_metrics::Reason::REASON_FETCH_LST_ONLY;
}
+ return signin_metrics::Reason::REASON_MAX;
}
// Specific implementation of DiceTurnSyncOnHelper::Delegate for forced
--- chromium-74.0.3729.40/content/renderer/accessibility/ax_image_annotator.cc.gcc8 2019-03-27 19:50:14.000000000 +0100
+++ chromium-74.0.3729.40/content/renderer/accessibility/ax_image_annotator.cc 2019-03-31 17:41:34.695739039 +0200
@@ -213,7 +213,7 @@ bool AXImageAnnotator::ImageInfo::HasAnn
case ax::mojom::ImageAnnotationStatus::kEligibleForAnnotation:
case ax::mojom::ImageAnnotationStatus::kSilentlyEligibleForAnnotation:
case ax::mojom::ImageAnnotationStatus::kAnnotationPending:
- return false;
+ break;
case ax::mojom::ImageAnnotationStatus::kAnnotationSucceeded:
DCHECK(annotation_.has_value());
return true;
@@ -220,6 +220,7 @@ bool AXImageAnnotator::ImageInfo::HasAnn
DCHECK(!annotation_.has_value());
return true;
}
+ return false;
}
// static
--- chromium-74.0.3729.40/third_party/blink/renderer/modules/mediastream/processed_local_audio_source.cc.gcc8 2019-03-27 19:50:14.000000000 +0100
+++ chromium-74.0.3729.40/third_party/blink/renderer/modules/mediastream/processed_local_audio_source.cc 2019-03-31 18:09:58.599783337 +0200
@@ -54,6 +54,7 @@ void LogAudioProcesingProperties(const A
case AEC::kEchoCancellationSystem:
return "system";
}
+ return "";
};
auto bool_to_string = [](bool value) { return value ? "true" : "false"; };
auto str = base::StringPrintf(
--- chromium-74.0.3729.40/third_party/blink/renderer/modules/idle/idle_detector.cc.gcc8 2019-03-27 19:50:26.000000000 +0100
+++ chromium-74.0.3729.40/third_party/blink/renderer/modules/idle/idle_detector.cc 2019-03-31 18:32:44.503774222 +0200
@@ -68,6 +68,7 @@ String IdleDetector::userState() const {
case mojom::blink::UserIdleState::kIdle:
return "idle";
}
+ return "";
}
String IdleDetector::screenState() const {
@@ -80,6 +81,7 @@ String IdleDetector::screenState() const
case mojom::blink::ScreenIdleState::kUnlocked:
return "unlocked";
}
+ return "";
}
// static
--- chromium-74.0.3729.40/third_party/blink/renderer/core/frame/csp/content_security_policy.cc.gcc8 2019-03-27 19:50:25.000000000 +0100
+++ chromium-74.0.3729.40/third_party/blink/renderer/core/frame/csp/content_security_policy.cc 2019-03-31 20:23:32.160724291 +0200
@@ -587,6 +587,7 @@ bool ContentSecurityPolicy::IsScriptInli
case ContentSecurityPolicy::InlineType::kStyle:
return false;
}
+ return false;
}
bool ContentSecurityPolicy::ShouldCheckEval() const {
@@ -706,6 +707,7 @@ GetDirectiveTypeFromRequestContextType(
case mojom::blink::RequestContextType::UNSPECIFIED:
return base::nullopt;
}
+ return base::nullopt;
}
bool ContentSecurityPolicy::AllowRequest(
@@ -1417,6 +1419,7 @@ ContentSecurityPolicy::BuildCSPViolation
kURLViolation:
return mojom::blink::ContentSecurityPolicyViolationType::kURLViolation;
}
+ return mojom::blink::ContentSecurityPolicyViolationType::kInlineViolation;
}
void ContentSecurityPolicy::ReportContentSecurityPolicyIssue(
--- chromium-74.0.3729.40/third_party/blink/renderer/core/frame/csp/csp_directive_list.cc.gcc8 2019-03-27 19:50:25.000000000 +0100
+++ chromium-74.0.3729.40/third_party/blink/renderer/core/frame/csp/csp_directive_list.cc 2019-03-31 20:33:11.486647257 +0200
@@ -104,6 +104,7 @@ GetDirectiveTypeForAllowInlineFromInline
case ContentSecurityPolicy::InlineType::kStyleAttribute:
return ContentSecurityPolicy::DirectiveType::kStyleSrcAttr;
}
+ return ContentSecurityPolicy::DirectiveType::kBaseURI;
}
ContentSecurityPolicy::DirectiveType GetDirectiveTypeForAllowHashFromInlineType(
@@ -122,6 +123,7 @@ ContentSecurityPolicy::DirectiveType Get
case ContentSecurityPolicy::InlineType::kStyle:
return ContentSecurityPolicy::DirectiveType::kStyleSrcElem;
}
+ return ContentSecurityPolicy::DirectiveType::kBaseURI;
}
} // namespace
--- chromium-74.0.3729.40/third_party/blink/renderer/core/script/import_map.cc.gcc8 2019-03-27 19:50:26.000000000 +0100
+++ chromium-74.0.3729.40/third_party/blink/renderer/core/script/import_map.cc 2019-03-31 22:25:44.718614867 +0200
@@ -71,6 +71,7 @@ String NormalizeSpecifierKey(const Strin
// url.</spec>
return key.GetImportMapKeyString();
}
+ return String();
}
// Step 2.4-2.7 of
@@ -122,6 +123,7 @@ KURL NormalizeValue(const String& key,
DCHECK(value.GetUrl().IsValid());
return value.GetUrl();
}
+ return NullURL();
}
} // namespace
--- chromium-74.0.3729.40/third_party/blink/renderer/core/script/modulator_impl_base.cc.gcc8 2019-03-27 19:50:26.000000000 +0100
+++ chromium-74.0.3729.40/third_party/blink/renderer/core/script/modulator_impl_base.cc 2019-03-31 22:35:49.450091410 +0200
@@ -218,7 +219,7 @@ KURL ModulatorImplBase::ResolveModuleSpe
switch (parsed_specifier.GetType()) {
case ParsedSpecifier::Type::kInvalid:
NOTREACHED();
- return KURL();
+ break;
case ParsedSpecifier::Type::kBare:
// Reject bare specifiers as specced by the pre-ImportMap spec.
@@ -232,6 +233,7 @@ KURL ModulatorImplBase::ResolveModuleSpe
case ParsedSpecifier::Type::kURL:
return parsed_specifier.GetUrl();
}
+ return KURL();
}
ScriptValue ModulatorImplBase::CreateTypeError(const String& message) const {
--- chromium-74.0.3729.40/third_party/blink/renderer/core/script/parsed_specifier.cc.gcc8 2019-03-27 19:50:26.000000000 +0100
+++ chromium-74.0.3729.40/third_party/blink/renderer/core/script/parsed_specifier.cc 2019-03-31 22:45:40.949799172 +0200
@@ -41,22 +41,24 @@ ParsedSpecifier ParsedSpecifier::Create(
String ParsedSpecifier::GetImportMapKeyString() const {
switch (GetType()) {
case Type::kInvalid:
- return String();
+ break;
case Type::kBare:
return bare_specifier_;
case Type::kURL:
return url_.GetString();
}
+ return String();
}
KURL ParsedSpecifier::GetUrl() const {
switch (GetType()) {
case Type::kInvalid:
case Type::kBare:
- return NullURL();
+ break;
case Type::kURL:
return url_;
}
+ return NullURL();
}
} // namespace blink
--- chromium-74.0.3729.40/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc.gcc8 2019-03-27 19:50:27.000000000 +0100
+++ chromium-74.0.3729.40/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc 2019-03-31 23:23:40.028942283 +0200
@@ -1365,6 +1365,7 @@ const char* ResourceFetcher::GetNameFor(
return "load";
}
NOTREACHED();
+ return "";
}
std::pair<ResourceFetcher::RevalidationPolicy, const char*>
--- chromium-75.0.3766.2/base/task/sequence_manager/sequence_manager_impl.cc.gcc8 2019-04-16 03:13:58.000000000 +0200
+++ chromium-75.0.3766.2/base/task/sequence_manager/sequence_manager_impl.cc 2019-04-21 06:58:47.152916464 +0200
@@ -441,9 +441,10 @@ const char* RunTaskTraceNameForPriority(
case TaskQueue::QueuePriority::kBestEffortPriority:
return "RunBestEffortPriorityTask";
case TaskQueue::QueuePriority::kQueuePriorityCount:
- NOTREACHED();
- return nullptr;
+ break;
}
+ NOTREACHED();
+ return nullptr;
}
} // namespace
--- chromium-75.0.3766.2/chrome/browser/notifications/scheduler/internal/proto_conversion.cc.gcc8 2019-04-16 03:13:59.000000000 +0200
+++ chromium-75.0.3766.2/chrome/browser/notifications/scheduler/internal/proto_conversion.cc 2019-04-21 10:13:53.436296816 +0200
@@ -99,6 +101,7 @@ proto::Impression_UserFeedback ToUserFee
return proto::Impression_UserFeedback_IGNORE;
}
NOTREACHED();
+ return proto::Impression_UserFeedback_NO_FEEDBACK;
}
// Converts UserFeedback from its associated enum in proto buffer.
@@ -118,6 +121,7 @@ UserFeedback FromUserFeedback(proto::Imp
return UserFeedback::kIgnore;
}
NOTREACHED();
+ return UserFeedback::kNoFeedback;
}
// Converts ImpressionResult to its associated enum in proto buffer.
@@ -133,6 +137,7 @@ proto::Impression_ImpressionResult ToImp
return proto::Impression_ImpressionResult_NEUTRAL;
}
NOTREACHED();
+ return proto::Impression_ImpressionResult_INVALID;
}
// Converts ImpressionResult from its associated enum in proto buffer.
@@ -149,6 +154,7 @@ ImpressionResult FromImpressionResult(
return ImpressionResult::kNeutral;
}
NOTREACHED();
+ return ImpressionResult::kInvalid;
}
proto::IconType ToIconType(IconType type) {
@@ -161,6 +167,7 @@ proto::IconType ToIconType(IconType type
return proto::IconType::LARGE_ICON;
}
NOTREACHED();
+ return proto::IconType::UNKNOWN_ICON_TYPE;
}
IconType FromIconType(proto::IconType proto_type) {
@@ -173,6 +180,7 @@ IconType FromIconType(proto::IconType pr
return IconType::kLargeIcon;
}
NOTREACHED();
+ return IconType::kUnknownType;
}
proto::ActionButtonType ToActionButtonType(ActionButtonType type) {
@@ -185,6 +193,7 @@ proto::ActionButtonType ToActionButtonTy
return proto::ActionButtonType::UNHELPFUL;
}
NOTREACHED();
+ return proto::ActionButtonType::UNKNOWN_ACTION;
}
ActionButtonType FromActionButtonType(proto::ActionButtonType proto_type) {
@@ -196,6 +205,7 @@ ActionButtonType FromActionButtonType(pr
case proto::ActionButtonType::UNHELPFUL:
return ActionButtonType::kUnhelpful;
}
+ return ActionButtonType::kUnknownAction;
}
// Converts NotificationData to proto buffer type.
--- chromium-75.0.3766.2/cc/animation/scroll_offset_animations_impl.cc.gcc8 2019-04-16 03:13:58.000000000 +0200
+++ chromium-75.0.3766.2/cc/animation/scroll_offset_animations_impl.cc 2019-04-21 11:04:07.498942132 +0200
@@ -225,6 +225,7 @@ bool ScrollOffsetAnimationsImpl::IsAnima
case KeyframeModel::ABORTED_BUT_NEEDS_COMPLETION:
return false;
}
+ return false;
}
ElementId ScrollOffsetAnimationsImpl::GetElementId() const {
--- chromium-75.0.3766.2/ui/views/accessibility/ax_virtual_view.cc.gcc8 2019-04-16 03:14:26.000000000 +0200
+++ chromium-75.0.3766.2/ui/views/accessibility/ax_virtual_view.cc 2019-04-21 12:14:43.711581145 +0200
@@ -313,6 +313,7 @@ gfx::Rect AXVirtualView::GetBoundsRect(
NOTIMPLEMENTED();
return gfx::Rect();
}
+ return gfx::Rect();
}
gfx::NativeViewAccessible AXVirtualView::HitTestSync(
--- chromium-75.0.3766.2/ui/views/accessibility/view_ax_platform_node_delegate.cc.gcc8 2019-04-16 03:14:26.000000000 +0200
+++ chromium-75.0.3766.2/ui/views/accessibility/view_ax_platform_node_delegate.cc 2019-04-21 12:25:16.774729205 +0200
@@ -385,6 +385,7 @@ gfx::Rect ViewAXPlatformNodeDelegate::Ge
NOTIMPLEMENTED();
return gfx::Rect();
}
+ return gfx::Rect();
}
gfx::NativeViewAccessible ViewAXPlatformNodeDelegate::HitTestSync(
--- chromium-75.0.3766.2/chrome/browser/download/offline_item_utils.cc.gcc8 2019-04-21 00:55:30.410350904 +0200
+++ chromium-75.0.3766.2/chrome/browser/download/offline_item_utils.cc 2019-04-21 12:36:18.633401466 +0200
@@ -345,6 +345,7 @@ RenameResult OfflineItemUtils::ConvertDo
case DownloadRenameResult::FAILURE_UNKNOWN:
return RenameResult::FAILURE_UNKNOWN;
}
+ return RenameResult::FAILURE_UNKNOWN;
}
// static
--- chromium-75.0.3766.2/chrome/browser/supervised_user/kids_management_url_checker_client.cc.gcc8 2019-04-16 03:14:00.000000000 +0200
+++ chromium-75.0.3766.2/chrome/browser/supervised_user/kids_management_url_checker_client.cc 2019-04-21 21:04:55.662980962 +0200
@@ -27,6 +27,7 @@ safe_search_api::ClientClassification To
case ClassifyUrlResponse::ALLOWED:
return safe_search_api::ClientClassification::kAllowed;
}
+ return safe_search_api::ClientClassification::kUnknown;
}
} // namespace
--- chromium-75.0.3766.2/third_party/blink/renderer/build/scripts/templates/origin_trials.cc.tmpl.gcc8 2019-04-16 03:14:08.000000000 +0200
+++ chromium-75.0.3766.2/third_party/blink/renderer/build/scripts/templates/origin_trials.cc.tmpl 2019-04-22 09:53:21.147061066 +0200
@@ -88,6 +88,7 @@ bool origin_trials::FeatureEnabledForOS(
case OriginTrialFeature::kNonExisting:
return true;
}
+ return false;
}
} // namespace blink
--- chromium-75.0.3766.2/third_party/blink/renderer/core/streams/readable_stream_default_controller.cc.gcc8 2019-04-16 03:14:08.000000000 +0200
+++ chromium-75.0.3766.2/third_party/blink/renderer/core/streams/readable_stream_default_controller.cc 2019-04-22 12:16:16.835861339 +0200
@@ -224,6 +224,7 @@ base::Optional<double> ReadableStreamDef
// 5. Return controller.[[strategyHWM]] − controller.[[queueTotalSize]].
return strategy_high_water_mark_ - queue_->TotalSize();
}
+ return base::nullopt;
}
bool ReadableStreamDefaultController::CanCloseOrEnqueue(
--- chromium-75.0.3766.2/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc.gcc8 2019-04-16 03:14:09.000000000 +0200
+++ chromium-75.0.3766.2/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc 2019-04-22 13:23:35.686804499 +0200
@@ -83,6 +83,7 @@ v8::RAILMode RAILModeToV8RAILMode(RAILMo
default:
NOTREACHED();
}
+ return v8::RAILMode::PERFORMANCE_LOAD;
}
void AddRAILModeToProto(perfetto::protos::pbzero::TrackEvent* event,
--- chromium-75.0.3766.2/third_party/blink/renderer/platform/graphics/paint/paint_property_node.cc.gcc8 2019-04-16 03:14:09.000000000 +0200
+++ chromium-75.0.3766.2/third_party/blink/renderer/platform/graphics/paint/paint_property_node.cc 2019-04-22 13:58:52.989492537 +0200
@@ -105,6 +105,7 @@ const char* PaintPropertyChangeTypeToStr
case PaintPropertyChangeType::kNodeAddedOrRemoved:
return "node-add-remove";
}
+ return "";
}
} // namespace blink
--- chromium-75.0.3770.8/components/leveldb_proto/public/shared_proto_database_client_list.cc.gcc8 2019-04-25 07:49:34.000000000 +0200
+++ chromium-75.0.3770.8/components/leveldb_proto/public/shared_proto_database_client_list.cc 2019-04-30 20:18:29.365394915 +0200
@@ -75,6 +75,7 @@ std::string SharedProtoDatabaseClientLis
NOTREACHED();
return std::string();
}
+ return std::string();
}
// static
--- chromium-75.0.3770.8/components/variations/field_trial_config/field_trial_util.cc.gcc8 2019-04-25 07:49:35.000000000 +0200
+++ chromium-75.0.3770.8/components/variations/field_trial_config/field_trial_util.cc 2019-04-30 22:55:10.582136775 +0200
@@ -59,6 +59,7 @@ Study::FormFactor _GetCurrentFormFactor(
case ui::DEVICE_FORM_FACTOR_DESKTOP:
return Study::DESKTOP;
}
+ return Study::DESKTOP;
}
// Returns true if the experiment config has a missing form_factors or it
--- chromium-75.0.3770.8/third_party/blink/renderer/core/animation/timing_calculations.h.gcc8 2019-04-25 07:49:44.000000000 +0200
+++ chromium-75.0.3770.8/third_party/blink/renderer/core/animation/timing_calculations.h 2019-05-01 22:15:38.366883444 +0200
@@ -290,6 +290,7 @@ static inline bool IsCurrentDirectionFor
case Timing::PlaybackDirection::ALTERNATE_REVERSE:
return !current_iteration_is_even;
}
+ return true;
}
// https://drafts.csswg.org/web-animations/#calculating-the-directed-progress
--- chromium-75.0.3770.8/third_party/blink/renderer/modules/webaudio/inspector_web_audio_agent.cc.gcc8 2019-04-25 07:49:46.000000000 +0200
+++ chromium-75.0.3770.8/third_party/blink/renderer/modules/webaudio/inspector_web_audio_agent.cc 2019-05-02 00:12:18.389566071 +0200
@@ -36,6 +36,7 @@ String GetContextStateEnum(BaseAudioCont
NOTREACHED();
break;
}
+ return String();
}
// Strips "Node" from the node name string. For example, "GainNode" will return
--- chromium-76.0.3809.46/base/message_loop/message_pump.cc.gcc8 2019-06-27 23:59:00.000000000 +0200
+++ chromium-76.0.3809.46/base/message_loop/message_pump.cc 2019-07-01 01:13:08.903490091 +0200
@@ -80,6 +80,7 @@ std::unique_ptr<MessagePump> MessagePump
return std::make_unique<MessagePumpDefault>();
#endif
}
+ return nullptr;
}
} // namespace base
--- chromium-76.0.3809.46/sql/recover_module/parsing.cc.gcc8 2019-06-27 23:59:34.000000000 +0200
+++ chromium-76.0.3809.46/sql/recover_module/parsing.cc 2019-07-01 20:59:19.606507557 +0200
@@ -99,9 +99,9 @@ base::StringPiece ColumnTypeToSql(Module
case ModuleColumnType::kRowId:
return kIntegerSql; // rowids are ints.
case ModuleColumnType::kAny:
- return base::StringPiece();
+ break;
}
- NOTREACHED();
+ return base::StringPiece();
}
} // namespace
--- chromium-76.0.3809.46/chrome/browser/notifications/scheduler/internal/proto_conversion.cc.gcc8 2019-07-01 00:48:14.428722404 +0200
+++ chromium-76.0.3809.46/chrome/browser/notifications/scheduler/internal/proto_conversion.cc 2019-07-01 21:55:48.844531001 +0200
@@ -206,6 +206,7 @@ proto::ScheduleParams_Priority ScheduleP
case Priority::kNoThrottle:
return proto::ScheduleParams_Priority_NO_THROTTLE;
}
+ return proto::ScheduleParams_Priority_LOW;
}
// Converts ScheduleParams::Priority from proto buffer type.
@@ -220,6 +221,7 @@ ScheduleParams::Priority ScheduleParamsP
case proto::ScheduleParams_Priority_NO_THROTTLE:
return Priority::kNoThrottle;
}
+ return Priority::kLow;
}
// Converts ScheduleParams to proto buffer type.
--- chromium-76.0.3809.46/components/services/heap_profiling/public/cpp/profiling_client.cc.gcc8 2019-06-27 23:59:19.000000000 +0200
+++ chromium-76.0.3809.46/components/services/heap_profiling/public/cpp/profiling_client.cc 2019-07-02 03:05:28.670471739 +0200
@@ -149,6 +149,7 @@ mojom::AllocatorType ConvertType(
case base::PoissonAllocationSampler::AllocatorType::kBlinkGC:
return mojom::AllocatorType::kOilpan;
}
+ return mojom::AllocatorType::kMalloc;
}
} // namespace
--- chromium-76.0.3809.46/chrome/browser/banners/app_banner_manager.cc.gcc8 2019-06-27 23:59:05.000000000 +0200
+++ chromium-76.0.3809.46/chrome/browser/banners/app_banner_manager.cc 2019-07-02 04:51:39.588355276 +0200
@@ -647,8 +647,7 @@ bool AppBannerManager::IsRunning() const
base::string16 AppBannerManager::GetInstallableWebAppName(
content::WebContents* web_contents) {
AppBannerManager* manager = FromWebContents(web_contents);
- if (!manager)
- return base::string16();
+ if (manager) {
switch (manager->installable_web_app_check_result_) {
case InstallableWebAppCheckResult::kUnknown:
case InstallableWebAppCheckResult::kNo:
@@ -658,6 +657,8 @@ base::string16 AppBannerManager::GetInst
case InstallableWebAppCheckResult::kPromotable:
return manager->GetAppName();
}
+ }
+ return base::string16();
}
bool AppBannerManager::IsProbablyPromotableWebApp(
@@ -684,6 +685,7 @@ bool AppBannerManager::IsProbablyPromota
case InstallableWebAppCheckResult::kPromotable:
return true;
}
+ return false;
}
bool AppBannerManager::IsPromotableWebApp() const {
@@ -696,6 +698,7 @@ bool AppBannerManager::IsPromotableWebAp
case InstallableWebAppCheckResult::kPromotable:
return true;
}
+ return false;
}
const GURL& AppBannerManager::GetManifestStartUrl() const {
--- chromium-76.0.3809.46/device/vr/util/gamepad_builder.cc.gcc8 2019-06-27 23:59:25.000000000 +0200
+++ chromium-76.0.3809.46/device/vr/util/gamepad_builder.cc 2019-07-02 08:44:30.063698145 +0200
@@ -24,6 +24,7 @@ GamepadHand MojoToGamepadHandedness(devi
}
NOTREACHED();
+ return GamepadHand::kNone;
}
} // anonymous namespace
@@ -55,6 +56,7 @@ bool GamepadBuilder::IsValid() const {
}
NOTREACHED();
+ return false;
}
base::Optional<Gamepad> GamepadBuilder::GetGamepad() {
--- chromium-76.0.3809.46/components/signin/core/browser/about_signin_internals.cc.gcc8 2019-07-02 01:53:22.450773482 +0200
+++ chromium-76.0.3809.46/components/signin/core/browser/about_signin_internals.cc 2019-07-02 09:07:57.450074758 +0200
@@ -59,6 +59,7 @@ std::string GetGaiaCookiesStateAsString(
case GaiaCookiesState::kAllowed:
return "Allowed";
}
+ return "";
}
base::ListValue* AddSection(base::ListValue* parent_list,
--- chromium-76.0.3809.46/device/fido/device_response_converter.cc.gcc8 2019-06-27 23:59:25.000000000 +0200
+++ chromium-76.0.3809.46/device/fido/device_response_converter.cc 2019-07-02 21:23:54.832514238 +0200
@@ -406,6 +406,7 @@ static base::Optional<std::string> FixIn
return base::nullopt;
}
}
+ return base::nullopt;
}
typedef bool (*PathPredicate)(const std::vector<const cbor::Value*>&);
@@ -488,6 +489,7 @@ static base::Optional<cbor::Value> FixIn
return cbor::Value(new_map);
}
}
+ return base::nullopt;
}
// ContainsInvalidUTF8 returns true if any element of |v| (recursively) contains
@@ -530,6 +532,7 @@ static bool ContainsInvalidUTF8(const cb
return false;
}
}
+ return false;
}
base::Optional<cbor::Value> FixInvalidUTF8(cbor::Value in,
--- chromium-76.0.3809.46/device/fido/virtual_ctap2_device.cc.gcc8 2019-06-27 23:59:25.000000000 +0200
+++ chromium-76.0.3809.46/device/fido/virtual_ctap2_device.cc 2019-07-02 21:32:36.679270326 +0200
@@ -856,6 +856,7 @@ CtapDeviceResponseCode VirtualCtap2Devic
case CredProtect::kUVRequired:
return !user_verified;
}
+ return false;
}),
found_registrations.end());
--- chromium-76.0.3809.46/third_party/blink/renderer/core/layout/ng/inline/ng_inline_item_result.cc.gcc8 2019-06-27 23:59:38.000000000 +0200
+++ chromium-76.0.3809.46/third_party/blink/renderer/core/layout/ng/inline/ng_inline_item_result.cc 2019-07-03 00:49:36.598274733 +0200
@@ -130,6 +130,7 @@ bool NGLineInfo::ShouldHangTrailingSpace
return IsRtl(BaseDirection());
}
NOTREACHED();
+ return false;
}
void NGLineInfo::UpdateTextAlign() {
--- chromium-76.0.3809.46/third_party/blink/renderer/modules/xr/type_converters.cc.gcc8 2019-06-27 23:59:40.000000000 +0200
+++ chromium-76.0.3809.46/third_party/blink/renderer/modules/xr/type_converters.cc 2019-07-03 21:11:21.303497866 +0200
@@ -20,6 +20,7 @@ TypeConverter<base::Optional<blink::XRPl
case device::mojom::blink::XRPlaneOrientation::VERTICAL:
return blink::XRPlane::Orientation::kVertical;
}
+ return base::nullopt;
}
blink::HeapVector<blink::Member<blink::DOMPointReadOnly>>
--- chromium-76.0.3809.46/chrome/browser/ui/send_tab_to_self/send_tab_to_self_sub_menu_model.cc.gcc8 2019-06-27 23:59:10.000000000 +0200
+++ chromium-76.0.3809.46/chrome/browser/ui/send_tab_to_self/send_tab_to_self_sub_menu_model.cc 2019-07-06 05:59:16.038627472 +0200
@@ -73,6 +73,7 @@ const std::string MenuTypeToString(SendT
default:
NOTREACHED();
}
+ return "";
}
} // namespace
--- chromium-76.0.3809.46/chrome/browser/ui/views/tabs/tab_strip_layout.cc.gcc8 2019-06-27 23:59:11.000000000 +0200
+++ chromium-76.0.3809.46/chrome/browser/ui/views/tabs/tab_strip_layout.cc 2019-07-06 07:13:08.410006513 +0200
@@ -28,6 +28,7 @@ int TabSizer::CalculateTabWidth(const Ta
space_fraction_available_, tab.GetLayoutCrossoverWidth(),
tab.GetPreferredWidth()));
}
+ return 0;
}
bool TabSizer::TabAcceptsExtraSpace(const TabWidthConstraints& tab) const {
@@ -39,6 +40,7 @@ bool TabSizer::TabAcceptsExtraSpace(cons
case LayoutDomain::kInactiveWidthEqualsActiveWidth:
return tab.GetLayoutCrossoverWidth() < tab.GetPreferredWidth();
}
+ return false;
}
bool TabSizer::IsAlreadyPreferredWidth() const {
--- chromium-76.0.3809.46/components/media_router/common/providers/cast/cast_media_source.cc.gcc8 2019-06-27 23:59:12.000000000 +0200
+++ chromium-76.0.3809.46/components/media_router/common/providers/cast/cast_media_source.cc 2019-07-06 07:21:19.540409448 +0200
@@ -358,6 +358,7 @@ bool IsAutoJoinAllowed(AutoJoinPolicy po
case AutoJoinPolicy::kOriginScoped:
return origin1 == origin2;
}
+ return false;
}
bool IsSiteInitiatedMirroringSource(const MediaSource::Id& source_id) {
--- chromium-76.0.3809.46/content/browser/accessibility/browser_accessibility.cc.gcc8 2019-07-05 22:21:44.776968302 +0200
+++ chromium-76.0.3809.46/content/browser/accessibility/browser_accessibility.cc 2019-07-06 08:36:50.713473424 +0200
@@ -94,6 +94,7 @@ int GetBoundaryTextOffsetInsideBaseAncho
case ax::mojom::MoveDirection::kForward:
return base->CreatePositionAtEndOfAnchor()->text_offset();
}
+ return 0;
}
} // namespace
--- chromium-76.0.3809.46/content/browser/permissions/permission_controller_impl.cc.gcc8 2019-06-27 23:59:22.000000000 +0200
+++ chromium-76.0.3809.46/content/browser/permissions/permission_controller_impl.cc 2019-07-06 08:48:16.625189492 +0200
@@ -69,6 +69,7 @@ PermissionToSchedulingFeature(Permission
case PermissionType::FONT_ACCESS:
return base::nullopt;
}
+ return base::nullopt;
}
void NotifySchedulerAboutPermissionRequest(RenderFrameHost* render_frame_host,
--- chromium-76.0.3809.46/content/browser/devtools/devtools_background_services_context_impl.cc.gcc8 2019-06-27 23:59:22.000000000 +0200
+++ chromium-76.0.3809.46/content/browser/devtools/devtools_background_services_context_impl.cc 2019-07-06 08:53:50.754213204 +0200
@@ -56,6 +56,7 @@ constexpr devtools::proto::BackgroundSer
case DevToolsBackgroundService::kPeriodicBackgroundSync:
return devtools::proto::PERIODIC_BACKGROUND_SYNC;
}
+ return devtools::proto::BACKGROUND_FETCH;
}
} // namespace
--- chromium-76.0.3809.46/content/browser/scheduler/browser_task_queues.cc.gcc8 2019-06-27 23:59:22.000000000 +0200
+++ chromium-76.0.3809.46/content/browser/scheduler/browser_task_queues.cc 2019-07-06 09:04:59.804259110 +0200
@@ -64,6 +64,7 @@ const char* GetUITaskQueueName(BrowserTa
case BrowserTaskQueues::QueueType::kUserVisible:
return "ui_user_visible_tq";
}
+ return "";
}
const char* GetIOTaskQueueName(BrowserTaskQueues::QueueType queue_type) {
@@ -81,6 +82,7 @@ const char* GetIOTaskQueueName(BrowserTa
case BrowserTaskQueues::QueueType::kUserVisible:
return "io_user_visible_tq";
}
+ return "";
}
const char* GetTaskQueueName(BrowserThread::ID thread_id,
--- chromium-76.0.3809.46/content/browser/indexed_db/indexed_db_transaction.cc.gcc8 2019-06-27 23:59:22.000000000 +0200
+++ chromium-76.0.3809.46/content/browser/indexed_db/indexed_db_transaction.cc 2019-07-06 18:06:53.234685509 +0200
@@ -261,8 +261,7 @@ void IndexedDBTransaction::EnsureBacking
leveldb::Status IndexedDBTransaction::BlobWriteComplete(
BlobWriteResult result) {
IDB_TRACE("IndexedDBTransaction::BlobWriteComplete");
- if (state_ == FINISHED) // aborted
- return leveldb::Status::OK();
+ if (state_ != FINISHED) {
DCHECK_EQ(state_, COMMITTING);
switch (result) {
@@ -283,6 +282,8 @@ leveldb::Status IndexedDBTransaction::Bl
}
}
NOTREACHED();
+ }
+ return leveldb::Status::OK();
}
leveldb::Status IndexedDBTransaction::Commit() {
--- chromium-76.0.3809.46/ui/accessibility/platform/ax_platform_text_boundary.cc.gcc8 2019-06-28 00:00:16.000000000 +0200
+++ chromium-76.0.3809.46/ui/accessibility/platform/ax_platform_text_boundary.cc 2019-07-06 19:11:35.635414535 +0200
@@ -27,6 +27,7 @@ ax::mojom::TextBoundary FromAtkTextBound
case ATK_TEXT_BOUNDARY_LINE_END:
return ax::mojom::TextBoundary::kLineEnd;
}
+ return ax::mojom::TextBoundary::kCharacter;
}
#if ATK_CHECK_VERSION(2, 10, 0)
@@ -44,6 +45,7 @@ ax::mojom::TextBoundary FromAtkTextGranu
case ATK_TEXT_GRANULARITY_PARAGRAPH:
return ax::mojom::TextBoundary::kParagraphStart;
}
+ return ax::mojom::TextBoundary::kCharacter;
}
#endif // ATK_CHECK_VERSION(2, 10, 0)
#endif // BUILDFLAG(USE_ATK)
--- chromium-77.0.3865.10/cc/paint/image_transfer_cache_entry.cc.gcc9 2019-08-06 13:56:02.000000000 +0200
+++ chromium-77.0.3865.10/cc/paint/image_transfer_cache_entry.cc 2019-08-17 23:28:48.980573594 +0200
@@ -146,6 +146,7 @@ size_t NumberOfPlanesForYUVDecodeFormat(
case YUVDecodeFormat::kUnknown:
return 0u;
}
+ return 0u;
}
ClientImageTransferCacheEntry::ClientImageTransferCacheEntry(
--- chromium-77.0.3865.35/chrome/browser/notifications/scheduler/internal/impression_history_tracker.cc.gcc9 2019-08-18 00:21:36.232587961 +0200
+++ chromium-77.0.3865.35/chrome/browser/notifications/scheduler/internal/impression_history_tracker.cc 2019-08-18 01:58:46.793871546 +0200
@@ -57,6 +57,7 @@ std::string ToDatabaseKey(SchedulerClien
case SchedulerClientType::kReadingList:
return "ReadingList";
}
+ return "";
}
} // namespace
--- chromium-77.0.3865.35/services/tracing/public/mojom/trace_config_mojom_traits.h.gcc9 2019-08-15 00:02:11.000000000 +0200
+++ chromium-77.0.3865.35/services/tracing/public/mojom/trace_config_mojom_traits.h 2019-08-18 02:08:52.683639240 +0200
@@ -32,6 +32,7 @@ struct EnumTraits<tracing::mojom::Buffer
case perfetto::TraceConfig::BufferConfig::DISCARD:
return tracing::mojom::BufferFillPolicy::kDiscard;
}
+ return tracing::mojom::BufferFillPolicy::kUnspecified;
}
static bool FromMojom(tracing::mojom::BufferFillPolicy input,
@@ -47,6 +48,7 @@ struct EnumTraits<tracing::mojom::Buffer
*out = perfetto::TraceConfig::BufferConfig::DISCARD;
return true;
}
+ return false;
}
};
--- chromium-77.0.3865.35/net/dns/dns_query.cc.gcc9 2019-08-15 00:02:09.000000000 +0200
+++ chromium-77.0.3865.35/net/dns/dns_query.cc 2019-08-18 04:22:42.932863374 +0200
@@ -56,6 +56,7 @@ size_t DeterminePaddingSize(size_t unpad
DCHECK_EQ((unpadded_size + padding_size) % 128, 0u);
return padding_size;
}
+ return 0;
}
base::Optional<OptRecordRdata> AddPaddingIfNecessary(
--- chromium-77.0.3865.35/ui/display/manager/display_util.cc.gcc9 2019-08-15 00:02:32.000000000 +0200
+++ chromium-77.0.3865.35/ui/display/manager/display_util.cc 2019-08-18 05:33:32.022043361 +0200
@@ -138,6 +138,7 @@ bool GetContentProtectionMethods(Display
*protection_mask = CONTENT_PROTECTION_METHOD_HDCP;
return true;
}
+ return false;
}
std::vector<float> GetDisplayZoomFactors(const ManagedDisplayMode& mode) {
--- chromium-77.0.3865.35/components/cloud_devices/common/printer_description.cc.gcc9 2019-08-15 00:02:04.000000000 +0200
+++ chromium-77.0.3865.35/components/cloud_devices/common/printer_description.cc 2019-08-18 05:40:49.505640894 +0200
@@ -766,6 +766,7 @@ bool VendorCapability::operator==(const
return typed_value_capability_ == other.typed_value_capability_;
}
NOTREACHED() << "Bad vendor capability type";
+ return false;
}
bool VendorCapability::IsValid() const {
--- chromium-77.0.3865.35/services/network/sec_header_helpers.cc.gcc9 2019-08-15 00:02:11.000000000 +0200
+++ chromium-77.0.3865.35/services/network/sec_header_helpers.cc 2019-08-18 05:46:01.869354818 +0200
@@ -47,6 +47,7 @@ const char* GetSecFetchSiteHeaderString(
case SecFetchSiteValue::kCrossSite:
return "cross-site";
}
+ return "";
}
SecFetchSiteValue SecFetchSiteHeaderValue(const GURL& target_url,
--- chromium-77.0.3865.35/services/network/public/cpp/cross_origin_read_blocking.cc.gcc9 2019-08-18 03:10:31.277063384 +0200
+++ chromium-77.0.3865.35/services/network/public/cpp/cross_origin_read_blocking.cc 2019-08-18 05:48:12.395145819 +0200
@@ -1144,6 +1144,7 @@ CrossOriginReadBlocking::ResponseAnalyze
case kNeedToSniffMore:
return CrossOriginProtectionDecision::kNeedToSniffMore;
}
+ return CrossOriginProtectionDecision::kBlock;
}
// static
--- chromium-77.0.3865.35/chrome/browser/sharing/web_push/web_push_sender.cc.gcc9 2019-08-15 00:02:04.000000000 +0200
+++ chromium-77.0.3865.35/chrome/browser/sharing/web_push/web_push_sender.cc 2019-08-18 06:09:27.375571202 +0200
@@ -90,6 +90,7 @@ std::string GetUrgencyHeader(WebPushMess
case WebPushMessage::Urgency::kHigh:
return "high";
}
+ return "";
}
std::unique_ptr<network::SimpleURLLoader> BuildURLLoader(
--- chromium-77.0.3865.35/components/sync/nigori/nigori_sync_bridge_impl.cc.gcc9 2019-08-15 00:02:05.000000000 +0200
+++ chromium-77.0.3865.35/components/sync/nigori/nigori_sync_bridge_impl.cc 2019-08-18 06:22:47.119036149 +0200
@@ -98,6 +98,7 @@ bool SpecificsHasValidKeyDerivationParam
}
return true;
}
+ return false;
}
// Validates given |specifics| assuming it's not specifics received from the
@@ -1026,6 +1027,7 @@ KeyDerivationParams NigoriSyncBridgeImpl
DCHECK(state_.custom_passphrase_key_derivation_params);
return *state_.custom_passphrase_key_derivation_params;
}
+ return KeyDerivationParams::CreateWithUnsupportedMethod();
}
void NigoriSyncBridgeImpl::MaybeNotifyOfPendingKeys() const {
--- chromium-77.0.3865.35/chrome/browser/content_index/content_index_provider_impl.cc.gcc9 2019-08-15 00:02:00.000000000 +0200
+++ chromium-77.0.3865.35/chrome/browser/content_index/content_index_provider_impl.cc 2019-08-18 21:03:35.904841038 +0200
@@ -96,6 +96,7 @@ OfflineItemFilter CategoryToFilter(blink
case blink::mojom::ContentCategory::AUDIO:
return OfflineItemFilter::FILTER_AUDIO;
}
+ return OfflineItemFilter::FILTER_PAGE;
}
} // namespace
--- chromium-77.0.3865.35/chrome/browser/availability/availability_prober.cc.gcc9 2019-08-15 00:01:59.000000000 +0200
+++ chromium-77.0.3865.35/chrome/browser/availability/availability_prober.cc 2019-08-18 21:14:34.836514492 +0200
@@ -72,6 +72,7 @@ std::string HttpMethodToString(Availabil
case AvailabilityProber::HttpMethod::kHead:
return "HEAD";
}
+ return "";
}
// Computes the time delta for a given Backoff algorithm, a base interval, and
@@ -86,6 +87,7 @@ base::TimeDelta ComputeNextTimeDeltaForB
case AvailabilityProber::Backoff::kExponential:
return base_interval * pow(2, attempts_so_far);
}
+ return base::TimeDelta();
}
std::string GenerateNetworkID(
--- chromium-77.0.3865.35/chrome/browser/predictors/loading_predictor_tab_helper.cc.gcc9 2019-08-15 00:02:00.000000000 +0200
+++ chromium-77.0.3865.35/chrome/browser/predictors/loading_predictor_tab_helper.cc 2019-08-18 21:37:41.097817701 +0200
@@ -64,6 +64,7 @@ net::RequestPriority GetRequestPriority(
case network::mojom::RequestDestination::kXslt:
return net::LOWEST;
}
+ return net::LOWEST;
}
bool IsHandledNavigation(content::NavigationHandle* navigation_handle) {
--- chromium-77.0.3865.35/ui/accessibility/ax_event_generator.cc.gcc9 2019-08-18 07:38:50.637789991 +0200
+++ chromium-77.0.3865.35/ui/accessibility/ax_event_generator.cc 2019-08-18 21:54:18.773837195 +0200
@@ -1209,6 +1209,7 @@ const char* ToString(AXEventGenerator::E
case AXEventGenerator::Event::WIN_IACCESSIBLE_STATE_CHANGED:
return "winIaccessibleStateChanged";
}
+ return "";
}
} // namespace ui
--- chromium-77.0.3865.35/chrome/browser/enterprise/reporting/extension_info.cc.gcc9 2019-08-15 00:02:00.000000000 +0200
+++ chromium-77.0.3865.35/chrome/browser/enterprise/reporting/extension_info.cc 2019-08-18 22:16:42.392093354 +0200
@@ -42,6 +42,7 @@ em::Extension_InstallType GetExtensionIn
case extensions::Manifest::EXTERNAL_COMPONENT:
return em::Extension_InstallType_TYPE_OTHER;
}
+ return em::Extension_InstallType_TYPE_OTHER;
}
void AddPermission(const extensions::Extension* extension,
@@ -112,6 +113,7 @@ em::Extension_ExtensionType ConvertExten
NOTREACHED();
return em::Extension_ExtensionType_TYPE_UNKNOWN;
}
+ return em::Extension_ExtensionType_TYPE_UNKNOWN;
}
void AppendExtensionInfoIntoProfileReport(
--- chromium-88.0.4324.41/ui/base/clipboard/clipboard.cc.gcc10 2020-12-10 13:03:48.000000000 +0100
+++ chromium-88.0.4324.41/ui/base/clipboard/clipboard.cc 2020-12-12 04:28:52.687529485 +0100
@@ -43,6 +43,7 @@ bool Clipboard::IsSupportedClipboardBuff
return false;
}
NOTREACHED();
+ return false;
}
// static
--- chromium-77.0.3865.35/components/payments/content/payment_event_response_util.cc.gcc9 2019-08-15 00:02:04.000000000 +0200
+++ chromium-77.0.3865.35/components/payments/content/payment_event_response_util.cc 2019-08-19 16:16:46.923650042 +0200
@@ -50,6 +50,7 @@ base::StringPiece ConvertPaymentEventRes
case mojom::PaymentEventResponseType::SHIPPING_OPTION_EMPTY:
return errors::kShippingOptionEmpty;
}
+ return "";
}
} // namespace payments
--- chromium-77.0.3865.35/content/browser/cache_storage/cache_storage_cache_entry_handler.cc.gcc9 2019-08-19 00:48:55.650876084 +0200
+++ chromium-77.0.3865.35/content/browser/cache_storage/cache_storage_cache_entry_handler.cc 2019-08-19 20:39:21.749266578 +0200
@@ -213,6 +213,7 @@ int CacheStorageCacheEntryHandler::DiskC
return disk_cache_entry_->GetDataSize(CacheStorageCache::INDEX_SIDE_DATA);
}
NOTREACHED();
+ return 0;
}
void CacheStorageCacheEntryHandler::DiskCacheBlobEntry::Invalidate() {
--- chromium-77.0.3865.35/ui/views/controls/button/menu_button_controller.cc.gcc9 2019-08-15 00:02:32.000000000 +0200
+++ chromium-77.0.3865.35/ui/views/controls/button/menu_button_controller.cc 2019-08-19 21:54:13.958010239 +0200
@@ -31,6 +31,7 @@ ui::EventType NotifyActionToMouseEventTy
case ButtonController::NotifyAction::kOnRelease:
return ui::ET_MOUSE_RELEASED;
}
+ return ui::ET_MOUSE_PRESSED;
}
} // namespace
--- chromium-77.0.3865.35/third_party/blink/renderer/core/html/parser/html_resource_preloader.cc.gcc9 2019-08-15 00:02:12.000000000 +0200
+++ chromium-77.0.3865.35/third_party/blink/renderer/core/html/parser/html_resource_preloader.cc 2019-08-19 22:49:00.408518118 +0200
@@ -136,6 +136,7 @@ bool HTMLResourcePreloader::AllowPreload
true) ||
preload->DeferOption() == FetchParameters::DeferOption::kNoDefer;
}
+ return false;
}
} // namespace blink
--- chromium-77.0.3865.35/third_party/blink/renderer/core/frame/use_counter_helper.cc.gcc9 2019-08-15 00:02:12.000000000 +0200
+++ chromium-77.0.3865.35/third_party/blink/renderer/core/frame/use_counter_helper.cc 2019-08-20 14:49:40.459290500 +0200
@@ -164,6 +164,7 @@ bool UseCounterHelper::IsCounted(CSSProp
case CSSPropertyType::kAnimation:
return animated_css_recorded_[sample_id];
}
+ return false;
}
void UseCounterHelper::AddObserver(Observer* observer) {
--- chromium-77.0.3865.35/third_party/blink/renderer/modules/content_index/content_description_type_converter.cc.gcc9 2019-08-15 00:02:13.000000000 +0200
+++ chromium-77.0.3865.35/third_party/blink/renderer/modules/content_index/content_description_type_converter.cc 2019-08-20 15:57:45.301365537 +0200
@@ -37,6 +37,7 @@
case blink::mojom::ContentCategory::AUDIO:
return "audio";
}
+ return "";
}
} // namespace
--- chromium-77.0.3865.35/third_party/blink/renderer/modules/exported/web_ax_object.cc.gcc9 2019-08-15 00:02:13.000000000 +0200
+++ chromium-77.0.3865.35/third_party/blink/renderer/modules/exported/web_ax_object.cc 2019-08-20 16:08:34.913171225 +0200
@@ -83,6 +83,7 @@ mojom::blink::ScrollAlignment::Behavior
return mojom::blink::ScrollAlignment::Behavior::kClosestEdge;
}
NOTREACHED() << alignment;
+ return mojom::blink::ScrollAlignment::Behavior::kNoScroll;
}
} // namespace
--- chromium-77.0.3865.35/third_party/blink/renderer/modules/notifications/notification_resources_loader.cc.gcc9 2019-08-15 00:02:13.000000000 +0200
+++ chromium-77.0.3865.35/third_party/blink/renderer/modules/notifications/notification_resources_loader.cc 2019-08-20 16:25:58.671161899 +0200
@@ -37,6 +37,7 @@ WebSize GetIconDimensions(NotificationIc
return {kNotificationMaxActionIconSizePx,
kNotificationMaxActionIconSizePx};
}
+ return {kNotificationMaxImageWidthPx, kNotificationMaxImageHeightPx};
}
} // namespace
--- chromium-77.0.3865.35/third_party/blink/renderer/modules/shapedetection/barcode_detector.cc.gcc9 2019-08-15 00:02:13.000000000 +0200
+++ chromium-77.0.3865.35/third_party/blink/renderer/modules/shapedetection/barcode_detector.cc 2019-08-20 16:43:24.252182524 +0200
@@ -133,6 +133,7 @@ String BarcodeDetector::BarcodeFormatToS
case shape_detection::mojom::BarcodeFormat::UPC_E:
return "upc_e";
}
+ return "";
}
ScriptPromise BarcodeDetector::DoDetect(ScriptPromiseResolver* resolver,
--- chromium-77.0.3865.35/third_party/blink/renderer/modules/xr/xr_input_source.cc.gcc9 2019-08-19 00:48:55.798873564 +0200
+++ chromium-77.0.3865.35/third_party/blink/renderer/modules/xr/xr_input_source.cc 2019-08-20 16:54:13.017061924 +0200
@@ -125,6 +125,7 @@ const String XRInputSource::handedness()
}
NOTREACHED() << "Unknown handedness: " << state_.handedness;
+ return "";
}
const String XRInputSource::targetRayMode() const {
@@ -139,6 +139,7 @@ const String XRInputSource::targetRayMod
}
NOTREACHED() << "Unknown target ray mode: " << state_.target_ray_mode;
+ return "";
}
XRSpace* XRInputSource::targetRaySpace() const {
--- chromium-77.0.3865.35/third_party/blink/renderer/platform/scheduler/main_thread/compositor_priority_experiments.cc.gcc9 2019-08-15 00:02:13.000000000 +0200
+++ chromium-77.0.3865.35/third_party/blink/renderer/platform/scheduler/main_thread/compositor_priority_experiments.cc 2019-08-20 17:14:32.709191253 +0200
@@ -70,6 +70,7 @@ QueuePriority CompositorPriorityExperime
NOTREACHED();
return QueuePriority::kNormalPriority;
}
+ return QueuePriority::kNormalPriority;
}
void CompositorPriorityExperiments::OnMainThreadSchedulerInitialized() {
--- chromium-77.0.3865.35/third_party/blink/renderer/platform/graphics/dark_mode_color_filter.cc.gcc9 2019-08-15 00:02:13.000000000 +0200
+++ chromium-77.0.3865.35/third_party/blink/renderer/platform/graphics/dark_mode_color_filter.cc 2019-08-21 02:19:21.170900293 +0200
@@ -129,6 +129,7 @@ std::unique_ptr<DarkModeColorFilter> Dar
return std::make_unique<LABColorFilter>();
}
NOTREACHED();
+ return nullptr;
}
DarkModeColorFilter::~DarkModeColorFilter() {}
--- chromium-77.0.3865.35/v8/src/builtins/builtins-collections-gen.cc.gcc9 2019-08-15 00:03:54.000000000 +0200
+++ chromium-77.0.3865.35/v8/src/builtins/builtins-collections-gen.cc 2019-08-21 02:45:38.581435691 +0200
@@ -490,6 +490,7 @@ int BaseCollectionsAssembler::GetTableOf
return JSWeakSet::kTableOffset;
}
UNREACHABLE();
+ return 0;
}
TNode<IntPtrT> BaseCollectionsAssembler::EstimatedInitialSize(
--- chromium-78.0.3904.9/services/resource_coordinator/public/cpp/memory_instrumentation/browser_metrics.cc.gcc9 2019-09-12 05:03:03.000000000 +0200
+++ chromium-78.0.3904.9/services/resource_coordinator/public/cpp/memory_instrumentation/browser_metrics.cc 2019-09-13 06:57:27.286238954 +0200
@@ -42,6 +42,7 @@ const char* HistogramProcessTypeToString
case HistogramProcessType::kUtility:
return kUtilityHistogramName;
}
+ return "";
}
std::string GetPrivateFootprintHistogramName(HistogramProcessType type) {
--- chromium-78.0.3904.9/chrome/browser/notifications/scheduler/internal/stats.cc.gcc9 2019-09-12 05:02:52.000000000 +0200
+++ chromium-78.0.3904.9/chrome/browser/notifications/scheduler/internal/stats.cc 2019-09-13 09:43:07.414231509 +0200
@@ -36,6 +36,7 @@ std::string ToHistogramSuffix(SchedulerC
case SchedulerClientType::kReadingList:
return "ReadingList";
}
+ return "";
}
// Returns the string representing database type.
@@ -48,6 +49,7 @@ std::string ToDbTypeString(DatabaseType
case DatabaseType::kIconDb:
return "IconDb";
}
+ return "";
}
// Logs a histogram enumeration with client type suffix.
--- chromium-78.0.3904.9/chrome/browser/sharing/sharing_metrics.cc.gcc9 2019-09-13 06:18:57.499881041 +0200
+++ chromium-78.0.3904.9/chrome/browser/sharing/sharing_metrics.cc 2019-09-14 22:48:59.327541379 +0200
@@ -24,6 +24,7 @@ const char* GetEnumStringValue(SharingFe
case SharingFeatureName::kSharedClipboard:
return "SharedClipboard";
}
+ return "";
}
// Maps SharingChannelType enum values to strings used as histogram
--- chromium-78.0.3904.9/chrome/browser/sharing/sharing_ui_controller.cc.gcc9 2019-09-12 05:02:52.000000000 +0200
+++ chromium-78.0.3904.9/chrome/browser/sharing/sharing_ui_controller.cc 2019-09-15 00:04:24.265455989 +0200
@@ -70,6 +70,7 @@ base::string16 SharingUiController::GetT
IDS_BROWSER_SHARING_ERROR_DIALOG_TITLE_INTERNAL_ERROR,
base::ToLowerASCII(GetContentType()));
}
+ return base::string16();
}
base::string16 SharingUiController::GetErrorDialogText() const {
@@ -96,6 +97,7 @@ base::string16 SharingUiController::GetE
return l10n_util::GetStringUTF16(
IDS_BROWSER_SHARING_ERROR_DIALOG_TEXT_INTERNAL_ERROR);
}
+ return base::string16();
}
void SharingUiController::OnDialogClosed(SharingDialog* dialog) {
--- chromium-78.0.3904.9/chrome/browser/ui/browser.cc.gcc9 2019-09-12 05:02:53.000000000 +0200
+++ chromium-78.0.3904.9/chrome/browser/ui/browser.cc 2019-09-15 00:33:09.871856801 +0200
@@ -2875,6 +2875,7 @@ bool Browser::NormalBrowserSupportsWindo
case FEATURE_NONE:
return false;
}
+ return false;
}
bool Browser::PopupBrowserSupportsWindowFeature(WindowFeature feature,
@@ -2894,6 +2895,7 @@ bool Browser::PopupBrowserSupportsWindow
case FEATURE_NONE:
return false;
}
+ return false;
}
bool Browser::AppPopupBrowserSupportsWindowFeature(
@@ -2936,6 +2938,7 @@ bool Browser::AppBrowserSupportsWindowFe
case FEATURE_NONE:
return false;
}
+ return false;
}
#if defined(OS_CHROMEOS)
@@ -2977,6 +2980,7 @@ bool Browser::SupportsWindowFeatureImpl(
return CustomTabBrowserSupportsWindowFeature(feature);
#endif
}
+ return false;
}
void Browser::UpdateBookmarkBarState(BookmarkBarStateChangeReason reason) {
--- chromium-78.0.3904.9/chrome/browser/ui/views/hats/hats_bubble_view.cc.gcc9 2019-09-12 05:02:53.000000000 +0200
+++ chromium-78.0.3904.9/chrome/browser/ui/views/hats/hats_bubble_view.cc 2019-09-15 01:18:25.927685733 +0200
@@ -49,6 +49,7 @@ HatsBubbleView::BubbleUsageCounts Bubble
case views::Widget::ClosedReason::kAcceptButtonClicked:
return HatsBubbleView::BubbleUsageCounts::kAccepted;
}
+ return HatsBubbleView::BubbleUsageCounts::kIgnored;
}
} // namespace
--- chromium-83.0.4103.7/content/browser/xr/service/browser_xr_runtime_impl.cc.gcc 2020-04-09 00:28:32.000000000 +0200
+++ chromium-83.0.4103.7/content/browser/xr/service/browser_xr_runtime_impl.cc 2020-04-13 23:12:11.018733849 +0200
@@ -257,6 +257,7 @@ bool BrowserXRRuntimeImpl::SupportsFeatu
}
NOTREACHED();
+ return false;
}
bool BrowserXRRuntimeImpl::SupportsAllFeatures(
@@ -288,6 +289,7 @@ bool BrowserXRRuntimeImpl::SupportsCusto
}
NOTREACHED();
+ return false;
}
bool BrowserXRRuntimeImpl::SupportsNonEmulatedHeight() const {
@@ -308,6 +310,7 @@ bool BrowserXRRuntimeImpl::SupportsNonEm
}
NOTREACHED();
+ return false;
}
bool BrowserXRRuntimeImpl::SupportsArBlendMode() {
--- chromium-78.0.3904.9/components/optimization_guide/hints_processing_util.cc.gcc9 2019-09-12 05:02:56.000000000 +0200
+++ chromium-78.0.3904.9/components/optimization_guide/hints_processing_util.cc 2019-09-15 03:48:01.659376926 +0200
@@ -108,6 +108,7 @@ net::EffectiveConnectionType ConvertProt
case proto::EffectiveConnectionType::EFFECTIVE_CONNECTION_TYPE_4G:
return net::EffectiveConnectionType::EFFECTIVE_CONNECTION_TYPE_4G;
}
+ return net::EffectiveConnectionType::EFFECTIVE_CONNECTION_TYPE_UNKNOWN;
}
bool IsValidURLForURLKeyedHint(const GURL& url) {
--- chromium-78.0.3904.9/components/password_manager/core/browser/password_manager_metrics_util.cc.gcc9 2019-09-12 05:02:56.000000000 +0200
+++ chromium-78.0.3904.9/components/password_manager/core/browser/password_manager_metrics_util.cc 2019-09-15 03:54:20.934800684 +0200
@@ -69,6 +69,7 @@ void LogLeakDialogTypeAndDismissalReason
case LeakDialogType::kCheckupAndChange:
return "CheckupAndChange";
}
+ return "";
};
base::UmaHistogramEnumeration(kHistogram, reason);
--- chromium-78.0.3904.9/content/browser/bluetooth/web_bluetooth_service_impl.cc.gcc9 2019-09-12 05:02:57.000000000 +0200
+++ chromium-78.0.3904.9/content/browser/bluetooth/web_bluetooth_service_impl.cc 2019-09-15 04:19:46.399378071 +0200
@@ -277,6 +277,8 @@
case ContentBrowserClient::AllowWebBluetoothResult::ALLOW:
return blink::mojom::WebBluetoothResult::SUCCESS;
}
+ return blink::mojom::WebBluetoothResult::
+ CHOOSER_NOT_SHOWN_API_GLOBALLY_DISABLED;
}
bool WebBluetoothServiceImpl::IsDevicePaired(
--- chromium-78.0.3904.9/content/browser/renderer_host/origin_policy_throttle.cc.gcc9 2019-09-12 05:02:57.000000000 +0200
+++ chromium-78.0.3904.9/content/browser/renderer_host/origin_policy_throttle.cc 2019-09-15 04:46:52.770724032 +0200
@@ -116,6 +116,7 @@ OriginPolicyThrottle::WillProcessRespons
case network::OriginPolicyState::kLoaded:
return NavigationThrottle::PROCEED;
}
+ return NavigationThrottle::CANCEL;
}
const char* OriginPolicyThrottle::GetNameForLogging() {
--- chromium-78.0.3904.9/content/browser/indexed_db/indexed_db_connection_coordinator.cc.gcc9 2019-09-12 05:02:57.000000000 +0200
+++ chromium-78.0.3904.9/content/browser/indexed_db/indexed_db_connection_coordinator.cc 2019-09-15 05:05:28.812910635 +0200
@@ -630,6 +630,7 @@ IndexedDBConnectionCoordinator::ExecuteT
}
}
NOTREACHED();
+ return {ExecuteTaskResult::kError, leveldb::Status::OK()};
}
size_t IndexedDBConnectionCoordinator::ActiveOpenDeleteCount() const {
--- chromium-78.0.3904.9/components/services/storage/indexed_db/transactional_leveldb/transactional_leveldb_iterator.cc.gcc9 2019-09-12 05:02:57.000000000 +0200
+++ chromium-78.0.3904.9/components/services/storage/indexed_db/transactional_leveldb/transactional_leveldb_iterator.cc 2019-09-15 06:00:27.500296280 +0200
@@ -77,6 +77,7 @@ bool TransactionalLevelDBIterator::IsVal
return iterator_->Valid();
}
NOTREACHED();
+ return false;
}
leveldb::Status TransactionalLevelDBIterator::SeekToLast() {
--- chromium-78.0.3904.9/content/browser/service_worker/service_worker_single_script_update_checker.cc.gcc9 2019-09-12 05:02:57.000000000 +0200
+++ chromium-78.0.3904.9/content/browser/service_worker/service_worker_single_script_update_checker.cc 2019-09-15 06:53:27.491440978 +0200
@@ -419,6 +419,7 @@ const char* ServiceWorkerSingleScriptUpd
case Result::kDifferent:
return "Different";
}
+ return "";
}
//------------------------------------------------------------------------------
--- chromium-78.0.3904.9/ui/views/animation/installable_ink_drop_animator.cc.gcc9 2019-09-12 05:03:27.000000000 +0200
+++ chromium-78.0.3904.9/ui/views/animation/installable_ink_drop_animator.cc 2019-09-15 07:18:55.716429661 +0200
@@ -157,6 +157,7 @@ base::TimeDelta InstallableInkDropAnimat
case SubAnimation::kDeactivatedFadeOut:
return base::TimeDelta::FromMilliseconds(300);
}
+ return base::TimeDelta::FromMilliseconds(0);
}
void InstallableInkDropAnimator::StartSubAnimation(SubAnimation sub_animation) {
--- chromium-78.0.3904.9/third_party/blink/renderer/build/scripts/core/css/templates/css_property_names.cc.tmpl.gcc9 2019-09-12 05:03:04.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/build/scripts/core/css/templates/css_property_names.cc.tmpl 2019-09-15 09:19:05.018380750 +0200
@@ -63,6 +63,7 @@ mojom::blink::CSSSampleId GetCSSSampleId
}
NOTREACHED();
+ return mojom::blink::CSSSampleId::kInvalid;
}
} // namespace blink
--- chromium-87.0.4280.27/third_party/blink/renderer/platform/graphics/dark_mode_settings_builder.cc.gcc9 2020-10-21 22:14:10.000000000 +0200
+++ chromium-87.0.4280.27/third_party/blink/renderer/platform/graphics/dark_mode_settings_builder.cc 2020-10-30 02:42:33.309474240 +0100
@@ -92,6 +92,7 @@ DarkModeInversionAlgorithm GetMode(const
return DarkModeInversionAlgorithm::kInvertBrightness;
}
NOTREACHED();
+ return DarkModeInversionAlgorithm::kSimpleInvertForTesting;
}
DarkModeImagePolicy GetImagePolicy(const SwitchParams& switch_params) {
@@ -104,6 +105,7 @@ DarkModeImagePolicy GetImagePolicy(const
case ForceDarkImageBehavior::kInvertSelectively:
return DarkModeImagePolicy::kFilterSmart;
}
+ return DarkModeImagePolicy::kFilterNone;
}
int GetTextBrightnessThreshold(const SwitchParams& switch_params) {
--- chromium-78.0.3904.9/third_party/blink/renderer/core/layout/flexible_box_algorithm.cc.gcc9 2019-09-12 05:03:05.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/core/layout/flexible_box_algorithm.cc 2019-09-15 10:56:58.653566388 +0200
@@ -50,6 +50,7 @@ ItemPosition BoxAlignmentToItemPosition(
case EBoxAlignment::kEnd:
return ItemPosition::kFlexEnd;
}
+ return ItemPosition::kBaseline;
}
ContentPosition BoxPackToContentPosition(EBoxPack box_pack) {
@@ -63,6 +64,7 @@ ContentPosition BoxPackToContentPosition
case EBoxPack::kEnd:
return ContentPosition::kFlexEnd;
}
+ return ContentPosition::kCenter;
}
ContentDistributionType BoxPackToContentDistribution(EBoxPack box_pack) {
--- chromium-78.0.3904.9/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.cc.gcc9 2019-09-12 05:03:05.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.cc 2019-09-15 12:19:35.044362924 +0200
@@ -207,6 +207,7 @@ String getTrustedTypeName(SpecificTruste
case SpecificTrustedType::kNone:
return String();
}
+ return String();
}
typedef bool (*PropertyEqualsFn)(decltype(*kTypeTable)&,
--- chromium-78.0.3904.9/third_party/blink/renderer/modules/serial/serial_port.cc.gcc9 2019-09-12 05:03:06.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/modules/serial/serial_port.cc 2019-09-15 12:56:18.558778000 +0200
@@ -59,6 +59,7 @@ DOMException* DOMExceptionFromSendError(
return MakeGarbageCollected<DOMException>(DOMExceptionCode::kUnknownError,
kSystemError);
}
+ return nullptr;
}
bool ReceiveErrorIsFatal(SerialReceiveError error) {
@@ -103,6 +104,7 @@ DOMException* DOMExceptionFromReceiveErr
return MakeGarbageCollected<DOMException>(DOMExceptionCode::kUnknownError,
kSystemError);
}
+ return nullptr;
}
// A ScriptFunction that calls ContinueClose() on the provided SerialPort.
--- chromium-78.0.3904.9/third_party/blink/renderer/modules/xr/xr_system.cc.gcc9 2019-09-12 05:03:06.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/modules/xr/xr_system.cc 2019-09-15 13:12:45.635911725 +0200
@@ -180,6 +180,7 @@ bool IsFeatureValidForMode(device::mojom
// depth APIs are all valid only for immersive AR mode for now.
return mode == device::mojom::blink::XRSessionMode::kImmersiveAr;
}
+ return false;
}
bool HasRequiredFeaturePolicy(const ExecutionContext* context,
@@ -205,6 +206,7 @@ bool HasRequiredFeaturePolicy(const Exec
mojom::blink::FeaturePolicyFeature::kWebXr,
ReportOptions::kReportOnFailure);
}
+ return false;
}
// Ensure that the immersive session request is allowed, if not
--- chromium-79.0.3945.16/components/services/app_service/public/cpp/intent_util.cc.gcc9 2019-10-29 23:01:57.000000000 +0100
+++ chromium-79.0.3945.16/components/services/app_service/public/cpp/intent_util.cc 2019-11-03 22:17:25.231077982 +0100
@@ -37,6 +37,7 @@ base::Optional<std::string> GetIntentCon
case apps::mojom::ConditionType::kMimeType:
return intent->mime_type;
}
+ return base::nullopt;
}
bool ComponentMatched(const std::string& intent_component,
@@ -169,6 +170,7 @@ bool ConditionValueMatches(
case apps::mojom::PatternMatchType::kMimeType:
return MimeTypeMatched(value, condition_value->value);
}
+ return false;
}
bool IntentMatchesCondition(const apps::mojom::IntentPtr& intent,
--- chromium-79.0.3945.16/net/extras/sqlite/sqlite_persistent_cookie_store.cc.gcc9 2019-10-29 23:02:03.000000000 +0100
+++ chromium-79.0.3945.16/net/extras/sqlite/sqlite_persistent_cookie_store.cc 2019-11-03 23:08:18.884764677 +0100
@@ -499,6 +499,7 @@ DBCookieSameSite CookieSameSiteToDBCooki
case CookieSameSite::UNSPECIFIED:
return kCookieSameSiteUnspecified;
}
+ return kCookieSameSiteUnspecified;
}
CookieSameSite DBCookieSameSiteToCookieSameSite(DBCookieSameSite value) {
--- chromium-79.0.3945.16/components/password_manager/core/browser/password_form.cc.gcc9 2019-10-29 23:01:58.000000000 +0100
+++ chromium-79.0.3945.16/components/password_manager/core/browser/password_form.cc 2019-11-04 19:26:25.194891828 +0100
@@ -27,6 +27,7 @@ std::string ToString(PasswordForm::Store
case PasswordForm::Store::kAccountStore:
return "Account Store";
}
+ return "";
}
std::string ToString(PasswordForm::Scheme scheme) {
--- chromium-79.0.3945.16/net/cookies/canonical_cookie.cc.gcc9 2019-10-29 23:02:03.000000000 +0100
+++ chromium-79.0.3945.16/net/cookies/canonical_cookie.cc 2019-11-04 19:48:40.701815937 +0100
@@ -826,6 +826,7 @@ CookieEffectiveSameSite CanonicalCookie:
case CookieSameSite::STRICT_MODE:
return CookieEffectiveSameSite::STRICT_MODE;
}
+ return CookieEffectiveSameSite::STRICT_MODE;
}
bool CanonicalCookie::IsRecentlyCreated(base::TimeDelta age_threshold) const {
--- chromium-79.0.3945.16/net/cookies/cookie_constants.cc.gcc9 2019-10-29 23:02:03.000000000 +0100
+++ chromium-79.0.3945.16/net/cookies/cookie_constants.cc 2019-11-04 19:49:54.188592366 +0100
@@ -68,6 +68,7 @@ std::string CookieSameSiteToString(Cooki
case CookieSameSite::UNSPECIFIED:
return kSameSiteUnspecified;
}
+ return kSameSiteStrict;
}
CookieSameSite StringToCookieSameSite(const std::string& same_site,
--- chromium-79.0.3945.16/ui/accessibility/ax_position.h.gcc9 2019-10-29 23:02:24.000000000 +0100
+++ chromium-79.0.3945.16/ui/accessibility/ax_position.h 2019-11-04 21:56:40.612651325 +0100
@@ -452,6 +452,7 @@ class AXPosition {
case AXPositionKind::TEXT_POSITION:
return text_offset_ == 0;
}
+ return false;
}
bool AtEndOfAnchor() const {
@@ -465,6 +466,7 @@ class AXPosition {
case AXPositionKind::TEXT_POSITION:
return text_offset_ == MaxTextOffset();
}
+ return false;
}
bool AtStartOfWord() const {
@@ -482,6 +484,7 @@ class AXPosition {
int32_t{text_position->text_offset_});
}
}
+ return false;
}
bool AtEndOfWord() const {
@@ -498,6 +501,7 @@ class AXPosition {
return base::Contains(word_ends, int32_t{text_position->text_offset_});
}
}
+ return false;
}
bool AtStartOfLine() const {
@@ -544,6 +548,7 @@ class AXPosition {
AXNode::kInvalidAXID &&
text_position->AtStartOfAnchor();
}
+ return false;
}
bool AtEndOfLine() const {
@@ -612,6 +617,7 @@ class AXPosition {
return text_position->AtEndOfAnchor() &&
text_position->CreateNextLeafTextPosition()->AtEndOfLine();
}
+ return false;
}
// |AtStartOfParagraph| is asymmetric from |AtEndOfParagraph| because of
@@ -682,6 +688,7 @@ class AXPosition {
return previous_text_position->IsNullPosition();
}
}
+ return false;
}
// |AtEndOfParagraph| is asymmetric from |AtStartOfParagraph| because of
@@ -769,6 +776,7 @@ class AXPosition {
->AtStartOfParagraph();
}
}
+ return false;
}
bool AtStartOfPage() const {
@@ -795,6 +803,7 @@ class AXPosition {
return previous_text_position->IsNullPosition();
}
}
+ return false;
}
bool AtEndOfPage() const {
@@ -821,6 +830,7 @@ class AXPosition {
return next_text_position->IsNullPosition();
}
}
+ return false;
}
bool AtStartOfAXTree() const {
--- chromium-79.0.3945.16/chrome/browser/page_load_metrics/observers/ad_metrics/ads_page_load_metrics_observer.cc.gcc9 2019-10-29 23:01:55.000000000 +0100
+++ chromium-79.0.3945.16/chrome/browser/page_load_metrics/observers/ad_metrics/ads_page_load_metrics_observer.cc 2019-11-04 22:14:36.004309386 +0100
@@ -105,6 +105,7 @@ std::string GetHeavyAdReportMessage(cons
NOTREACHED();
return "";
}
+ return "";
}
const char kDisallowedByBlocklistHistogramName[] =
--- chromium-79.0.3945.16/third_party/blink/common/scheduler/web_scheduler_tracked_feature.cc.gcc9 2019-10-29 23:02:04.000000000 +0100
+++ chromium-79.0.3945.16/third_party/blink/common/scheduler/web_scheduler_tracked_feature.cc 2019-11-04 22:37:08.965446029 +0100
@@ -112,6 +112,7 @@ const char* FeatureToString(WebScheduler
case WebSchedulerTrackedFeature::kOutstandingNetworkRequestDirectSocket:
return "outstanding network request (direct socket)";
}
+ return "";
}
bool IsFeatureSticky(WebSchedulerTrackedFeature feature) {
--- chromium-79.0.3945.16/chrome/browser/sharing/click_to_call/click_to_call_ui_controller.cc.gcc9 2019-10-29 23:01:56.000000000 +0100
+++ chromium-79.0.3945.16/chrome/browser/sharing/click_to_call/click_to_call_ui_controller.cc 2019-11-04 23:47:30.242809733 +0100
@@ -81,6 +81,7 @@ base::string16 ClickToCallUiController::
return l10n_util::GetStringUTF16(
IDS_BROWSER_SHARING_CLICK_TO_CALL_DIALOG_TITLE_LABEL);
}
+ return base::string16();
}
PageActionIconType ClickToCallUiController::GetIconType() {
--- chromium-79.0.3945.16/chrome/browser/ui/views/location_bar/cookie_controls_bubble_view.cc.gcc9 2019-10-29 23:01:56.000000000 +0100
+++ chromium-79.0.3945.16/chrome/browser/ui/views/location_bar/cookie_controls_bubble_view.cc 2019-11-05 00:53:20.526290720 +0100
@@ -238,6 +238,7 @@ base::string16 CookieControlsBubbleView:
NOTREACHED();
return base::string16();
}
+ return base::string16();
}
bool CookieControlsBubbleView::ShouldShowWindowTitle() const {
--- chromium-79.0.3945.16/chrome/browser/web_applications/extensions/bookmark_app_registrar.cc.gcc9 2019-10-29 23:01:56.000000000 +0100
+++ chromium-79.0.3945.16/chrome/browser/web_applications/extensions/bookmark_app_registrar.cc 2019-11-05 01:20:11.075712043 +0100
@@ -188,6 +188,7 @@ DisplayMode BookmarkAppRegistrar::GetApp
NOTREACHED();
return DisplayMode::kUndefined;
}
+ return DisplayMode::kUndefined;
}
DisplayMode BookmarkAppRegistrar::GetAppUserDisplayModeForMigration(
--- chromium-79.0.3945.16/chrome/browser/web_applications/web_app_install_finalizer.cc.gcc9 2019-10-29 23:01:56.000000000 +0100
+++ chromium-79.0.3945.16/chrome/browser/web_applications/web_app_install_finalizer.cc 2019-11-05 01:31:12.254743550 +0100
@@ -66,6 +66,7 @@ Source::Type InferSourceFromMetricsInsta
NOTREACHED();
return Source::kSync;
}
+ return Source::kSync;
}
Source::Type InferSourceFromExternalInstallSource(
--- chromium-79.0.3945.16/chrome/browser/web_applications/web_app_database.cc.gcc9 2019-10-29 23:01:56.000000000 +0100
+++ chromium-79.0.3945.16/chrome/browser/web_applications/web_app_database.cc 2019-11-05 01:40:12.393622302 +0100
@@ -42,6 +42,7 @@ ShareTarget_Method MethodToProto(apps::S
case apps::ShareTarget::Method::kPost:
return ShareTarget_Method_POST;
}
+ return ShareTarget_Method_GET;
}
apps::ShareTarget::Method ProtoToMethod(ShareTarget_Method method) {
@@ -51,6 +52,7 @@ apps::ShareTarget::Method ProtoToMethod(
case ShareTarget_Method_POST:
return apps::ShareTarget::Method::kPost;
}
+ return apps::ShareTarget::Method::kGet;
}
ShareTarget_Enctype EnctypeToProto(apps::ShareTarget::Enctype enctype) {
@@ -60,6 +62,7 @@ ShareTarget_Enctype EnctypeToProto(apps:
case apps::ShareTarget::Enctype::kMultipartFormData:
return ShareTarget_Enctype_MULTIPART_FORM_DATA;
}
+ return ShareTarget_Enctype_FORM_URL_ENCODED;
}
apps::ShareTarget::Enctype ProtoToEnctype(ShareTarget_Enctype enctype) {
@@ -69,6 +72,7 @@ apps::ShareTarget::Enctype ProtoToEnctyp
case ShareTarget_Enctype_MULTIPART_FORM_DATA:
return apps::ShareTarget::Enctype::kMultipartFormData;
}
+ return apps::ShareTarget::Enctype::kFormUrlEncoded;
}
} // anonymous namespace
@@ -741,6 +745,7 @@ DisplayMode ToMojomDisplayMode(WebAppPro
case WebAppProto::WINDOW_CONTROLS_OVERLAY:
return DisplayMode::kWindowControlsOverlay;
}
+ return DisplayMode::kBrowser;
}
DisplayMode ToMojomDisplayMode(
@@ -755,6 +760,7 @@ DisplayMode ToMojomDisplayMode(
case ::sync_pb::WebAppSpecifics::STANDALONE:
return DisplayMode::kStandalone;
}
+ return DisplayMode::kBrowser;
}
WebAppProto::DisplayMode ToWebAppProtoDisplayMode(DisplayMode display_mode) {
@@ -773,6 +779,7 @@ WebAppProto::DisplayMode ToWebAppProtoDi
case DisplayMode::kWindowControlsOverlay:
return WebAppProto::WINDOW_CONTROLS_OVERLAY;
}
+ return WebAppProto::BROWSER;
}
} // namespace web_app
--- chromium-79.0.3945.16/components/password_manager/core/browser/password_feature_manager_impl.cc.gcc9 2019-10-29 23:01:59.000000000 +0100
+++ chromium-79.0.3945.16/components/password_manager/core/browser/password_feature_manager_impl.cc 2019-11-05 02:01:58.361167761 +0100
@@ -27,6 +27,7 @@ bool PasswordFeatureManagerImpl::IsGener
case ACCOUNT_PASSWORDS_ACTIVE_NORMAL_ENCRYPTION:
return true;
}
+ return false;
}
bool PasswordFeatureManagerImpl::IsOptedInForAccountStorage() const {
--- chromium-79.0.3945.16/content/browser/indexed_db/indexed_db_backing_store.cc.gcc9 2019-10-29 23:02:00.000000000 +0100
+++ chromium-79.0.3945.16/content/browser/indexed_db/indexed_db_backing_store.cc 2019-11-05 21:19:22.657576210 +0100
@@ -846,6 +846,7 @@ bool IndexedDBBackingStore::ShouldSyncOn
case blink::mojom::IDBTransactionDurability::Relaxed:
return false;
}
+ return false;
}
leveldb::Status IndexedDBBackingStore::GetCompleteMetadata(
--- chromium-79.0.3945.16/third_party/blink/renderer/modules/indexeddb/idb_transaction.cc.gcc9 2019-10-29 23:02:06.000000000 +0100
+++ chromium-79.0.3945.16/third_party/blink/renderer/modules/indexeddb/idb_transaction.cc 2019-11-05 23:14:21.428425109 +0100
@@ -513,6 +513,7 @@ const String& IDBTransaction::durability
}
NOTREACHED();
+ return indexed_db_names::kDefault;
}
DOMStringList* IDBTransaction::objectStoreNames() const {
--- chromium-79.0.3945.16/content/child/webthemeengine_impl_conversions.cc.gcc9 2019-10-29 23:02:00.000000000 +0100
+++ chromium-79.0.3945.16/content/child/webthemeengine_impl_conversions.cc 2019-11-05 23:32:33.586725953 +0100
@@ -91,6 +91,7 @@ ui::NativeTheme::ColorScheme NativeColor
case blink::mojom::ColorScheme::kDark:
return ui::NativeTheme::ColorScheme::kDark;
}
+ return ui::NativeTheme::ColorScheme::kLight;
}
ui::NativeTheme::SystemThemeColor NativeSystemThemeColor(
--- chromium-79.0.3945.16/third_party/blink/renderer/modules/wake_lock/wake_lock_sentinel.cc.gcc9 2019-10-29 23:02:06.000000000 +0100
+++ chromium-79.0.3945.16/third_party/blink/renderer/modules/wake_lock/wake_lock_sentinel.cc 2019-11-08 00:18:18.359267078 +0100
@@ -35,6 +35,7 @@ String WakeLockSentinel::type() const {
case WakeLockType::kSystem:
return "system";
}
+ return "";
}
ExecutionContext* WakeLockSentinel::GetExecutionContext() const {
--- chromium-79.0.3945.16/third_party/blink/renderer/modules/xr/xr_session.cc.gcc9 2019-10-29 23:02:06.000000000 +0100
+++ chromium-79.0.3945.16/third_party/blink/renderer/modules/xr/xr_session.cc 2019-11-08 00:25:44.561073654 +0100
@@ -405,6 +405,7 @@ const String XRSession::visibilityState(
case XRVisibilityState::HIDDEN:
return "hidden";
}
+ return String();
}
XRAnchorSet* XRSession::TrackedAnchors() const {
@@ -1931,6 +1931,7 @@ base::Optional<TransformationMatrix> XRS
// stage_parameters_). It probably should eventually move here.
return base::nullopt;
}
+ return base::nullopt;
}
XRFrame* XRSession::CreatePresentationFrame() {
--- chromium-79.0.3945.16/third_party/blink/renderer/platform/heap/impl/blink_gc_memory_dump_provider.cc.gcc9 2019-10-29 23:02:06.000000000 +0100
+++ chromium-79.0.3945.16/third_party/blink/renderer/platform/heap/impl/blink_gc_memory_dump_provider.cc 2019-11-08 00:51:01.491535923 +0100
@@ -28,6 +28,7 @@ constexpr const char* HeapTypeString(
case BlinkGCMemoryDumpProvider::HeapType::kBlinkWorkerThread:
return "workers";
}
+ return "";
}
} // namespace
--- chromium-79.0.3945.29/chrome/browser/ui/views/location_bar/cookie_controls_icon_view.cc.gcc9 2019-11-08 19:36:01.613354298 +0100
+++ chromium-79.0.3945.29/chrome/browser/ui/views/location_bar/cookie_controls_icon_view.cc 2019-11-08 22:52:20.116657238 +0100
@@ -80,6 +80,7 @@ bool CookieControlsIconView::ShouldBeVis
case CookieControlsStatus::kUninitialized:
return false;
}
+ return false;
}
bool CookieControlsIconView::HasAssociatedBubble() const {
--- chromium-79.0.3945.36/content/browser/renderer_host/navigation_request.cc.gcc9 2019-11-13 19:53:37.000000000 +0100
+++ chromium-79.0.3945.36/content/browser/renderer_host/navigation_request.cc 2019-11-15 08:33:10.622116669 +0100
@@ -609,6 +609,7 @@ mojom::NavigationType ConvertToCrossDocu
case mojom::NavigationType::DIFFERENT_DOCUMENT:
return type;
}
+ return type;
}
base::debug::CrashKeyString* GetNavigationRequestUrlCrashKey() {
--- chromium-79.0.3945.45/chrome/browser/ui/autofill/payments/save_card_bubble_controller_impl.cc.gcc9 2019-11-21 00:39:53.170468152 +0100
+++ chromium-79.0.3945.45/chrome/browser/ui/autofill/payments/save_card_bubble_controller_impl.cc 2019-11-21 08:42:22.100281384 +0100
@@ -246,9 +246,10 @@ base::string16 SaveCardBubbleControllerI
return l10n_util::GetStringUTF16(IDS_AUTOFILL_FAILURE_BUBBLE_TITLE);
case BubbleType::UPLOAD_IN_PROGRESS:
case BubbleType::INACTIVE:
- NOTREACHED();
- return base::string16();
+ break;
}
+ NOTREACHED();
+ return base::string16();
}
base::string16 SaveCardBubbleControllerImpl::GetExplanatoryMessage() const {
@@ -289,8 +290,9 @@ base::string16 SaveCardBubbleControllerI
case BubbleType::SIGN_IN_PROMO:
case BubbleType::FAILURE:
case BubbleType::INACTIVE:
- return base::string16();
+ break;
}
+ return base::string16();
}
base::string16 SaveCardBubbleControllerImpl::GetDeclineButtonText() const {
@@ -308,6 +310,7 @@ base::string16 SaveCardBubbleControllerI
case BubbleType::INACTIVE:
return base::string16();
}
+ return base::string16();
}
const AccountInfo& SaveCardBubbleControllerImpl::GetAccountInfo() const {
@@ -566,6 +569,7 @@ base::string16 SaveCardBubbleControllerI
case BubbleType::INACTIVE:
return base::string16();
}
+ return base::string16();
}
bool SaveCardBubbleControllerImpl::ShouldShowSavingCardAnimation() const {
--- chromium-80.0.3987.78/base/memory/discardable_memory.cc.gcc9 2020-01-29 22:38:48.000000000 +0100
+++ chromium-80.0.3987.78/base/memory/discardable_memory.cc 2020-02-01 23:16:42.725141320 +0100
@@ -60,6 +60,7 @@ DiscardableMemoryBacking GetBackingForFi
return DiscardableMemoryBacking::kMadvFree;
}
NOTREACHED();
+ return DiscardableMemoryBacking::kSharedMemory;
}
#endif // defined(OS_ANDROID) || defined(OS_LINUX) || defined(OS_CHROMEOS)
--- chromium-80.0.3987.78/components/system_media_controls/linux/system_media_controls_linux.cc.gcc9 2020-01-29 22:38:55.000000000 +0100
+++ chromium-80.0.3987.78/components/system_media_controls/linux/system_media_controls_linux.cc 2020-02-02 00:43:15.769009050 +0100
@@ -118,6 +118,7 @@ void SystemMediaControlsLinux::SetPlayba
case PlaybackStatus::kStopped:
return DbusString("Stopped");
}
+ return DbusString("");
};
properties_->SetProperty(kMprisAPIPlayerInterfaceName, "PlaybackStatus",
status());
--- chromium-80.0.3987.78/net/cert/internal/path_builder.cc.gcc9 2020-01-29 22:38:59.000000000 +0100
+++ chromium-80.0.3987.78/net/cert/internal/path_builder.cc 2020-02-02 01:14:53.981556139 +0100
@@ -155,6 +155,7 @@ int TrustAndKeyIdentifierMatchToOrder(co
return kDistrustedAndKeyIdMismatch;
}
}
+ return 9;
}
// CertIssuersIter iterates through the intermediates from |cert_issuer_sources|
--- chromium-80.0.3987.78/net/dns/host_resolver_proc.cc.gcc9 2020-01-29 22:38:59.000000000 +0100
+++ chromium-80.0.3987.78/net/dns/host_resolver_proc.cc 2020-02-02 02:43:17.849057864 +0100
@@ -97,6 +97,7 @@ int AddressFamilyToAF(AddressFamily addr
case ADDRESS_FAMILY_UNSPECIFIED:
return AF_UNSPEC;
}
+ return AF_UNSPEC;
}
} // namespace
--- chromium-80.0.3987.78/cc/animation/scroll_offset_animation_curve_factory.cc.gcc9 2020-01-29 22:39:33.000000000 +0100
+++ chromium-80.0.3987.78/cc/animation/scroll_offset_animation_curve_factory.cc 2020-02-02 02:49:24.284806946 +0100
@@ -22,6 +22,7 @@ ScrollOffsetAnimationCurve::DurationBeha
NOTREACHED();
return ScrollOffsetAnimationCurve::DurationBehavior::DELTA_BASED;
}
+ return ScrollOffsetAnimationCurve::DurationBehavior::DELTA_BASED;
}
} // namespace
--- chromium-80.0.3987.78/media/base/media_log_properties.cc.gcc9 2020-01-29 22:38:58.000000000 +0100
+++ chromium-80.0.3987.78/media/base/media_log_properties.cc 2020-02-02 03:18:46.507834819 +0100
@@ -38,6 +38,7 @@ std::string MediaLogPropertyKeyToString(
STRINGIFY(kVideoPlaybackFreezing);
}
#undef STRINGIFY
+ return "";
}
} // namespace media
--- chromium-80.0.3987.78/components/autofill/core/browser/form_types.cc.gcc9 2020-01-29 22:38:53.000000000 +0100
+++ chromium-80.0.3987.78/components/autofill/core/browser/form_types.cc 2020-02-02 03:27:09.365191470 +0100
@@ -29,5 +29,6 @@ FormType FormTypes::FieldTypeGroupToForm
case UNFILLABLE:
return UNKNOWN_FORM_TYPE;
}
+ return UNKNOWN_FORM_TYPE;
}
} // namespace autofill
--- chromium-80.0.3987.78/services/network/cors/cors_url_loader.cc.gcc9 2020-01-29 22:39:40.000000000 +0100
+++ chromium-80.0.3987.78/services/network/cors/cors_url_loader.cc 2020-02-02 03:36:54.802136733 +0100
@@ -567,6 +567,7 @@ bool CorsURLLoader::HasSpecialAccessToDe
return factory_bound_origin_access_list_->CheckAccessState(request_) ==
OriginAccessList::AccessState::kAllowed;
}
+ return false;
}
// Keep this in sync with the identical function
--- chromium-80.0.3987.78/services/network/public/cpp/content_security_policy/content_security_policy.cc.gcc9 2020-01-29 22:39:38.000000000 +0100
+++ chromium-80.0.3987.78/services/network/public/cpp/content_security_policy/content_security_policy.cc 2020-02-02 04:29:59.896347937 +0100
@@ -104,6 +104,7 @@ static CSPDirectiveName CSPFallback(CSPD
NOTREACHED();
return CSPDirectiveName::Unknown;
}
+ return CSPDirectiveName::Unknown;
}
std::string ElideURLForReportViolation(const GURL& url) {
@@ -151,7 +151,8 @@ bool SupportedInReportOnly(CSPDirectiveN
case CSPDirectiveName::Unknown:
case CSPDirectiveName::WorkerSrc:
return true;
- };
+ }
+ return true;
}
// Return the error message specific to one CSP |directive|.
@@ -158,7 +159,8 @@ const char* ErrorMessage(CSPDirectiveNam
case CSPDirectiveName::Unknown:
NOTREACHED();
return nullptr;
- };
+ }
+ return nullptr;
}
void ReportViolation(CSPContext* context,
--- chromium-80.0.3987.78/ui/accessibility/ax_position.h.gcc9 2020-02-02 04:34:28.882677459 +0100
+++ chromium-80.0.3987.78/ui/accessibility/ax_position.h 2020-02-02 12:14:58.230285841 +0100
@@ -333,6 +333,7 @@ class AXPosition {
return text_offset_ == 0 ||
(text_offset_ > 0 && text_offset_ <= MaxTextOffset());
}
+ return false;
}
// TODO(nektar): Update logic of AtStartOfAnchor() for text_offset_ == 0 and
--- chromium-80.0.3987.78/components/openscreen_platform/network_util.cc.gcc9 2020-01-29 22:39:35.000000000 +0100
+++ chromium-80.0.3987.78/components/openscreen_platform/network_util.cc 2020-02-02 12:21:26.318432199 +0100
@@ -26,6 +26,7 @@ const net::IPAddress ToNetAddress(const
return net::IPAddress(bytes_v6.data(), bytes_v6.size());
}
}
+ return net::IPAddress();
}
const net::IPEndPoint ToNetEndPoint(const openscreen::IPEndpoint& endpoint) {
@@ -44,6 +45,7 @@ openscreen::IPAddress::Version ToOpenScr
NOTREACHED();
return openscreen::IPAddress::Version::kV4;
}
+ return openscreen::IPAddress::Version::kV4;
}
const openscreen::IPEndpoint ToOpenScreenEndPoint(
--- chromium-80.0.3987.78/chrome/browser/optimization_guide/optimization_guide_keyed_service.cc.gcc9 2020-01-29 22:39:35.000000000 +0100
+++ chromium-80.0.3987.78/chrome/browser/optimization_guide/optimization_guide_keyed_service.cc 2020-02-02 12:25:26.380226957 +0100
@@ -68,6 +68,7 @@ GetOptimizationGuideDecisionFromOptimiza
case optimization_guide::OptimizationTargetDecision::kDeciderNotInitialized:
return optimization_guide::OptimizationGuideDecision::kUnknown;
}
+ return optimization_guide::OptimizationGuideDecision::kUnknown;
}
// Logs |optimization_target_decision| for |optimization_target| in a histogram
--- chromium-80.0.3987.78/chrome/browser/optimization_guide/prediction/prediction_manager.cc.gcc9 2020-01-29 22:39:35.000000000 +0100
+++ chromium-80.0.3987.78/chrome/browser/optimization_guide/prediction/prediction_manager.cc 2020-02-02 13:16:56.950241429 +0100
@@ -58,6 +58,7 @@ bool ShouldUseCurrentOptimizationTargetD
case optimization_guide::OptimizationTargetDecision::kDeciderNotInitialized:
return false;
}
+ return false;
}
// Delay between retries on failed fetch and store of prediction models and
--- chromium-80.0.3987.78/chrome/browser/devtools/protocol/security_handler.cc.gcc9 2020-01-29 22:38:49.000000000 +0100
+++ chromium-80.0.3987.78/chrome/browser/devtools/protocol/security_handler.cc 2020-02-02 13:38:49.173062959 +0100
@@ -179,6 +179,7 @@ std::unique_ptr<protocol::Security::Safe
case security_state::SafetyTipStatus::kUnknown:
return nullptr;
}
+ return nullptr;
}
std::unique_ptr<protocol::Security::VisibleSecurityState>
--- chromium-80.0.3987.78/chrome/browser/sharing/sharing_metrics.cc.gcc9 2020-02-02 04:34:28.687680843 +0100
+++ chromium-80.0.3987.78/chrome/browser/sharing/sharing_metrics.cc 2020-02-02 14:00:54.449881218 +0100
@@ -42,6 +42,7 @@ std::string SharingChannelTypeToString(S
case SharingChannelType::kWebRtc:
return "WebRTC";
}
+ return "";
}
// Maps SharingDevicePlatform enum values to strings used as histogram
@@ -63,6 +64,7 @@ std::string DevicePlatformToString(Shari
case SharingDevicePlatform::kUnknown:
return "Unknown";
}
+ return "";
}
// Maps pulse intervals to strings used as histogram suffixes. Keep in sync with
--- chromium-80.0.3987.78/chrome/browser/web_applications/components/web_app_constants.cc.gcc9 2020-01-29 22:39:36.000000000 +0100
+++ chromium-80.0.3987.78/chrome/browser/web_applications/components/web_app_constants.cc 2020-02-02 14:48:58.700046683 +0100
@@ -33,6 +33,7 @@ DisplayMode ResolveAppDisplayModeForStan
else
return DisplayMode::kStandalone;
}
+ return DisplayMode::kStandalone;
}
} // namespace
@@ -102,6 +103,7 @@ apps::mojom::LaunchContainer ConvertDisp
case DisplayMode::kUndefined:
return apps::mojom::LaunchContainer::kLaunchContainerNone;
}
+ return apps::mojom::LaunchContainer::kLaunchContainerNone;
}
std::string RunOnOsLoginModeToString(RunOnOsLoginMode mode) {
@@ -113,6 +115,7 @@ std::string RunOnOsLoginModeToString(Run
case RunOnOsLoginMode::kUndefined:
return "undefined";
}
+ return std::string();
}
} // namespace web_app
--- chromium-80.0.3987.78/chrome/browser/ui/global_media_controls/cast_media_notification_item.cc.gcc9 2020-01-29 22:39:35.000000000 +0100
+++ chromium-80.0.3987.78/chrome/browser/ui/global_media_controls/cast_media_notification_item.cc 2020-02-02 14:58:31.859477187 +0100
@@ -98,6 +98,7 @@ media_session::mojom::MediaPlaybackState
case media_router::mojom::MediaStatus::PlayState::BUFFERING:
return media_session::mojom::MediaPlaybackState::kPlaying;
}
+ return media_session::mojom::MediaPlaybackState::kPlaying;
}
media_session::mojom::MediaSessionInfo::SessionState ToSessionState(
@@ -110,6 +111,7 @@ media_session::mojom::MediaSessionInfo::
case media_router::mojom::MediaStatus::PlayState::BUFFERING:
return media_session::mojom::MediaSessionInfo::SessionState::kActive;
}
+ return media_session::mojom::MediaSessionInfo::SessionState::kActive;
}
base::string16 GetSourceTitle(const media_router::MediaRoute& route) {
--- chromium-80.0.3987.78/chrome/browser/ui/webui/ntp/cookie_controls_handler.cc.gcc9 2020-01-29 22:38:51.000000000 +0100
+++ chromium-80.0.3987.78/chrome/browser/ui/webui/ntp/cookie_controls_handler.cc 2020-02-02 15:40:17.129752061 +0100
@@ -74,6 +74,7 @@ const char* CookieControlsHandler::GetEn
case CookieControlsEnforcement::kNoEnforcement:
return "";
}
+ return "";
}
void CookieControlsHandler::OnThirdPartyCookieBlockingPrefChanged() {
--- chromium-80.0.3987.78/chrome/browser/web_applications/web_app_install_finalizer.cc.gcc9 2020-02-02 04:34:28.885677407 +0100
+++ chromium-80.0.3987.78/chrome/browser/web_applications/web_app_install_finalizer.cc 2020-02-02 16:27:53.337081391 +0100
@@ -96,6 +96,7 @@ Source::Type InferSourceFromExternalInst
case ExternalInstallSource::kArc:
return Source::kWebAppStore;
}
+ return Source::kDefault;
}
} // namespace
--- chromium-80.0.3987.78/components/password_manager/core/browser/import/password_importer.cc.gcc9 2020-01-29 22:38:54.000000000 +0100
+++ chromium-80.0.3987.78/components/password_manager/core/browser/import/password_importer.cc 2020-02-02 16:42:52.163389733 +0100
@@ -39,6 +39,7 @@ PasswordImporter::Result ToImporterError
case CSVPassword::Status::kSemanticError:
return PasswordImporter::SEMANTIC_ERROR;
}
+ return PasswordImporter::SYNTAX_ERROR;
}
// Parses passwords from |input| using |password_reader| and synchronously calls
--- chromium-80.0.3987.78/components/previews/content/previews_optimization_guide.cc.gcc9 2020-01-29 22:38:54.000000000 +0100
+++ chromium-80.0.3987.78/components/previews/content/previews_optimization_guide.cc 2020-02-02 16:55:05.196371986 +0100
@@ -35,6 +35,7 @@ bool ShouldApplyPreviewWithDecision(
? params::ApplyDeferWhenOptimizationGuideDecisionUnknown()
: false;
}
+ return false;
}
// The default max size of the cache holding resource loading hints by URL.
--- chromium-80.0.3987.78/content/browser/renderer_host/back_forward_cache_can_store_document_result.cc.gcc9 2020-01-29 22:39:38.000000000 +0100
+++ chromium-80.0.3987.78/content/browser/renderer_host/back_forward_cache_can_store_document_result.cc 2020-02-02 17:42:32.987449746 +0100
@@ -146,6 +146,7 @@ std::string BackForwardCacheCanStoreDocu
case Reason::kNetworkExceedsBufferLimit:
return "Network request reads too much data and exceeds buffer limit";
}
+ return "";
}
void BackForwardCacheCanStoreDocumentResult::No(
--- chromium-80.0.3987.78/content/browser/renderer_host/render_frame_host_impl.cc.gcc9 2020-01-29 22:39:38.000000000 +0100
+++ chromium-80.0.3987.78/content/browser/renderer_host/render_frame_host_impl.cc 2020-02-02 17:56:58.531106249 +0100
@@ -456,6 +456,7 @@ class BackForwardCacheMessageFilter : pu
base::debug::DumpWithoutCrashing();
return true;
}
+ return false;
}
void DidDispatchOrReject(mojo::Message* message, bool accepted) override {}
@@ -795,6 +796,7 @@ const char* LifecycleStateToString(Rende
case LifecycleState::kReadyToBeDeleted:
return "ReadyToDeleted";
}
+ return "";
}
} // namespace
@@ -4479,6 +4481,7 @@ bool RenderFrameHostImpl::IsInactiveAndD
case LifecycleState::kActive:
return false;
}
+ return false;
}
void RenderFrameHostImpl::EvictFromBackForwardCache(
@@ -4708,6 +4711,7 @@ bool RenderFrameHostImpl::GetSuddenTermi
case blink::mojom::SuddenTerminationDisablerType::kVisibilityChangeHandler:
return has_visibilitychange_handler_;
}
+ return false;
}
bool RenderFrameHostImpl::UnloadHandlerExistsInSameSiteInstanceSubtree() {
--- chromium-80.0.3987.78/extensions/renderer/api/automation/automation_internal_custom_bindings.cc.gcc9 2020-01-29 22:38:57.000000000 +0100
+++ chromium-80.0.3987.78/extensions/renderer/api/automation/automation_internal_custom_bindings.cc 2020-02-02 19:46:32.281949828 +0100
@@ -95,6 +95,7 @@ api::automation::MarkerType ConvertMarke
case ax::mojom::MarkerType::kSuggestion:
return api::automation::MARKER_TYPE_SUGGESTION;
}
+ return api::automation::MARKER_TYPE_NONE;
}
// Adjust the bounding box of a node from local to global coordinates,
--- chromium-80.0.3987.78/third_party/blink/renderer/core/layout/ng/ng_absolute_utils.cc.gcc9 2020-01-29 22:39:41.000000000 +0100
+++ chromium-80.0.3987.78/third_party/blink/renderer/core/layout/ng/ng_absolute_utils.cc 2020-02-03 20:39:40.941775772 +0100
@@ -69,6 +69,7 @@ inline StaticPositionEdge GetStaticPosit
case NGLogicalStaticPosition::InlineEdge::kInlineEnd:
return kEnd;
}
+ return kStart;
}
inline StaticPositionEdge GetStaticPositionEdge(
@@ -81,6 +82,7 @@ inline StaticPositionEdge GetStaticPosit
case NGLogicalStaticPosition::BlockEdge::kBlockEnd:
return kEnd;
}
+ return kStart;
}
inline LayoutUnit StaticPositionStartInset(StaticPositionEdge edge,
@@ -94,6 +96,7 @@ inline LayoutUnit StaticPositionStartIns
case kEnd:
return static_position_offset - size;
}
+ return static_position_offset;
}
inline LayoutUnit StaticPositionEndInset(StaticPositionEdge edge,
@@ -108,6 +111,7 @@ inline LayoutUnit StaticPositionEndInset
case kEnd:
return available_size - static_position_offset;
}
+ return static_position_offset;
}
LayoutUnit ComputeShrinkToFitSize(
--- chromium-80.0.3987.78/third_party/blink/renderer/core/layout/svg/svg_marker_data.cc.gcc9 2020-01-29 22:39:41.000000000 +0100
+++ chromium-80.0.3987.78/third_party/blink/renderer/core/layout/svg/svg_marker_data.cc 2020-02-03 21:43:00.898369708 +0100
@@ -58,6 +58,7 @@ double SVGMarkerDataBuilder::CurrentAngl
case kInbound:
return in_angle;
}
+ return 0.;
}
SVGMarkerDataBuilder::AngleType SVGMarkerDataBuilder::DetermineAngleType(
--- chromium-80.0.3987.78/third_party/blink/renderer/modules/serial/serial_port.cc.gcc9 2020-02-02 04:34:28.692680756 +0100
+++ chromium-80.0.3987.78/third_party/blink/renderer/modules/serial/serial_port.cc 2020-02-03 23:16:13.630209250 +0100
@@ -45,6 +45,7 @@ bool SendErrorIsFatal(SerialSendError er
case SerialSendError::DISCONNECTED:
return true;
}
+ return false;
}
DOMException* DOMExceptionFromSendError(SerialSendError error) {
@@ -78,6 +79,7 @@ bool ReceiveErrorIsFatal(SerialReceiveEr
case SerialReceiveError::DEVICE_LOST:
return true;
}
+ return false;
}
DOMException* DOMExceptionFromReceiveError(SerialReceiveError error) {
--- chromium-81.0.4044.43/components/optimization_guide/optimization_guide_util.cc.gcc 2020-03-04 22:52:09.000000000 +0100
+++ chromium-81.0.4044.43/components/optimization_guide/optimization_guide_util.cc 2020-03-09 17:12:33.232350590 +0100
@@ -56,6 +56,7 @@ GetOptimizationGuideDecisionFromOptimiza
kNotAllowedByOptimizationFilter:
return optimization_guide::OptimizationGuideDecision::kFalse;
}
+ return optimization_guide::OptimizationGuideDecision::kUnknown;
}
google::protobuf::RepeatedPtrField<proto::FieldTrial>
--- chromium-81.0.4044.43/sandbox/policy/linux/sandbox_seccomp_bpf_linux.cc.gcc9 2020-03-04 22:52:19.000000000 +0100
+++ chromium-81.0.4044.43/sandbox/policy/linux/sandbox_seccomp_bpf_linux.cc 2020-03-09 18:59:58.440910794 +0100
@@ -184,6 +184,7 @@ std::unique_ptr<BPFBasePolicy> SandboxSe
NOTREACHED();
return nullptr;
}
+ return nullptr;
}
// If a BPF policy is engaged for |process_type|, run a few sanity checks.
--- chromium-81.0.4044.43/sandbox/policy/sandbox_type.cc.gcc9 2020-03-04 22:52:59.000000000 +0100
+++ chromium-81.0.4044.43/sandbox/policy/sandbox_type.cc 2020-03-09 19:00:43.842151665 +0100
@@ -67,6 +67,7 @@ bool IsUnsandboxedSandboxType(SandboxTyp
case SandboxType::kSpeechRecognition:
return false;
}
+ return false;
}
void SetCommandLineFlagsForSandboxType(base::CommandLine* command_line,
@@ -260,6 +261,7 @@ std::string StringFromUtilitySandboxType
NOTREACHED();
return std::string();
}
+ return std::string();
}
SandboxType UtilitySandboxTypeFromString(const std::string& sandbox_string) {
--- chromium-81.0.4044.43/components/feed/core/common/refresh_throttler.cc.gcc9 2020-03-04 22:52:13.000000000 +0100
+++ chromium-81.0.4044.43/components/feed/core/common/refresh_throttler.cc 2020-03-09 20:33:49.236198263 +0100
@@ -43,6 +43,7 @@ std::pair<std::string, int> GetThrottler
case UserClass::kActiveSuggestionsConsumer:
return {"SuggestionFetcherActiveSuggestionsConsumer", 20};
}
+ return {"", 0};
}
} // namespace
--- chromium-81.0.4044.43/components/feed/core/common/user_classifier.cc.gcc9 2020-03-04 22:52:13.000000000 +0100
+++ chromium-81.0.4044.43/components/feed/core/common/user_classifier.cc 2020-03-09 20:35:43.164300556 +0100
@@ -68,6 +68,7 @@ const char* GetRateKey(UserClassifier::E
case UserClassifier::Event::kSuggestionsUsed:
return prefs::kUserClassifierAverageSuggestionsUsedPerHour;
}
+ return "";
}
const char* GetLastTimeKey(UserClassifier::Event event) {
@@ -77,6 +78,7 @@ const char* GetLastTimeKey(UserClassifie
case UserClassifier::Event::kSuggestionsUsed:
return prefs::kUserClassifierLastTimeToUseSuggestions;
}
+ return "";
}
double GetInitialHoursBetweenEvents(UserClassifier::Event event) {
@@ -86,6 +88,7 @@ double GetInitialHoursBetweenEvents(User
case UserClassifier::Event::kSuggestionsUsed:
return 120;
}
+ return 0.;
}
// Returns the new value of the rate using its |old_value|, assuming
--- chromium-81.0.4044.43/components/openscreen_platform/logging.cc.gcc9 2020-03-04 22:52:13.000000000 +0100
+++ chromium-81.0.4044.43/components/openscreen_platform/logging.cc 2020-03-09 20:48:41.430328956 +0100
@@ -28,6 +28,7 @@ namespace {
case LogLevel::kFatal:
return ::logging::LOG_FATAL;
}
+ return ::logging::LOG_VERBOSE;
}
} // namespace
--- chromium-81.0.4044.43/cc/animation/scroll_offset_animation_curve.cc.gcc9 2020-03-04 22:52:54.000000000 +0100
+++ chromium-81.0.4044.43/cc/animation/scroll_offset_animation_curve.cc 2020-03-09 21:14:49.760168453 +0100
@@ -233,6 +233,7 @@ base::TimeDelta ScrollOffsetAnimationCur
case AnimationType::kImpulse:
return ImpulseSegmentDuration(delta, delayed_by);
}
+ return base::TimeDelta();
}
// static
--- chromium-81.0.4044.43/components/viz/common/quads/render_pass_io.cc.gcc9 2020-03-04 22:52:58.000000000 +0100
+++ chromium-81.0.4044.43/components/viz/common/quads/render_pass_io.cc 2020-03-09 21:21:01.748962321 +0100
@@ -586,6 +586,7 @@ const char* ColorSpacePrimaryIdToString(
MATCH_ENUM_CASE(PrimaryID, WIDE_GAMUT_COLOR_SPIN)
MATCH_ENUM_CASE(PrimaryID, CUSTOM)
}
+ return "";
}
const char* ColorSpaceTransferIdToString(gfx::ColorSpace::TransferID id) {
@@ -616,6 +617,7 @@ const char* ColorSpaceTransferIdToString
MATCH_ENUM_CASE(TransferID, CUSTOM_HDR)
MATCH_ENUM_CASE(TransferID, PIECEWISE_HDR)
}
+ return "";
}
const char* ColorSpaceMatrixIdToString(gfx::ColorSpace::MatrixID id) {
@@ -633,6 +635,7 @@ const char* ColorSpaceMatrixIdToString(g
MATCH_ENUM_CASE(MatrixID, YDZDX)
MATCH_ENUM_CASE(MatrixID, GBR)
}
+ return "";
}
const char* ColorSpaceRangeIdToString(gfx::ColorSpace::RangeID id) {
@@ -642,6 +645,7 @@ const char* ColorSpaceRangeIdToString(gf
MATCH_ENUM_CASE(RangeID, FULL)
MATCH_ENUM_CASE(RangeID, DERIVED)
}
+ return "";
}
#undef MATCH_ENUM_CASE
--- chromium-81.0.4044.43/media/base/media_serializers.h.gcc9 2020-03-04 22:52:59.000000000 +0100
+++ chromium-81.0.4044.43/media/base/media_serializers.h 2020-03-09 21:31:53.823064450 +0100
@@ -317,6 +317,7 @@ struct MediaSerializer<media::BufferingS
case BUFFERING_CHANGE_REASON_UNKNOWN:
return base::Value("BUFFERING_CHANGE_REASON_UNKNOWN");
}
+ return base::Value();
}
};
--- chromium-81.0.4044.43/ui/accessibility/ax_position.h.gcc9 2020-03-09 18:39:43.583247676 +0100
+++ chromium-81.0.4044.43/ui/accessibility/ax_position.h 2020-03-09 23:45:23.866329758 +0100
@@ -382,6 +382,7 @@ class AXPosition {
return AsLeafTreePosition()->IsIgnored();
return false;
}
+ return false;
}
bool IsNullPosition() const {
@@ -3915,6 +3916,7 @@ class AXPosition {
case ax::mojom::MoveDirection::kForward:
return AXPositionAdjustmentBehavior::kMoveForward;
}
+ return AXPositionAdjustmentBehavior::kMoveForward;
}
static AXPositionAdjustmentBehavior OppositeAdjustmentBehavior(
@@ -3925,6 +3927,7 @@ class AXPosition {
case AXPositionAdjustmentBehavior::kMoveBackward:
return AXPositionAdjustmentBehavior::kMoveForward;
}
+ return AXPositionAdjustmentBehavior::kMoveForward;
}
static std::vector<int32_t> GetWordStartOffsetsFunc(
@@ -4039,6 +4042,7 @@ class AXPosition {
}
break;
}
+ return text_position;
}
// Returns the next leaf text position in the specified direction ensuring
--- chromium-81.0.4044.43/ui/accessibility/ax_node_data.cc.gcc9 2020-03-04 22:53:02.000000000 +0100
+++ chromium-81.0.4044.43/ui/accessibility/ax_node_data.cc 2020-03-09 23:47:14.170472810 +0100
@@ -929,6 +929,7 @@ bool AXNodeData::IsReadOnlyOrDisabled()
!IsReadOnlySupported(role);
}
}
+ return false;
}
bool AXNodeData::IsRangeValueSupported() const {
--- chromium-81.0.4044.43/ui/views/layout/normalized_geometry.cc.gcc9 2020-03-04 22:52:40.000000000 +0100
+++ chromium-81.0.4044.43/ui/views/layout/normalized_geometry.cc 2020-03-10 00:11:58.960491644 +0100
@@ -251,6 +251,7 @@ NormalizedPoint Normalize(LayoutOrientat
case LayoutOrientation::kVertical:
return NormalizedPoint(point.y(), point.x());
}
+ return NormalizedPoint();
}
gfx::Point Denormalize(LayoutOrientation orientation,
@@ -261,6 +262,7 @@ gfx::Point Denormalize(LayoutOrientation
case LayoutOrientation::kVertical:
return gfx::Point(point.cross(), point.main());
}
+ return gfx::Point();
}
NormalizedSize Normalize(LayoutOrientation orientation, const gfx::Size& size) {
@@ -270,6 +272,7 @@ NormalizedSize Normalize(LayoutOrientati
case LayoutOrientation::kVertical:
return NormalizedSize(size.height(), size.width());
}
+ return NormalizedSize();
}
gfx::Size Denormalize(LayoutOrientation orientation,
@@ -280,6 +283,7 @@ gfx::Size Denormalize(LayoutOrientation
case LayoutOrientation::kVertical:
return gfx::Size(size.cross(), size.main());
}
+ return gfx::Size();
}
NormalizedSizeBounds Normalize(LayoutOrientation orientation,
@@ -290,6 +294,7 @@ NormalizedSizeBounds Normalize(LayoutOri
case LayoutOrientation::kVertical:
return NormalizedSizeBounds(bounds.height(), bounds.width());
}
+ return NormalizedSizeBounds();
}
SizeBounds Denormalize(LayoutOrientation orientation,
@@ -300,6 +305,7 @@ SizeBounds Denormalize(LayoutOrientation
case LayoutOrientation::kVertical:
return SizeBounds(bounds.cross(), bounds.main());
}
+ return SizeBounds();
}
NormalizedInsets Normalize(LayoutOrientation orientation,
@@ -312,6 +318,7 @@ NormalizedInsets Normalize(LayoutOrienta
return NormalizedInsets(insets.top(), insets.left(), insets.bottom(),
insets.right());
}
+ return NormalizedInsets();
}
gfx::Insets Denormalize(LayoutOrientation orientation,
@@ -324,6 +331,7 @@ gfx::Insets Denormalize(LayoutOrientatio
return gfx::Insets(insets.main_leading(), insets.cross_leading(),
insets.main_trailing(), insets.cross_trailing());
}
+ return gfx::Insets();
}
NormalizedRect Normalize(LayoutOrientation orientation,
@@ -345,6 +353,7 @@ int GetMainAxis(LayoutOrientation orient
case LayoutOrientation::kVertical:
return size.height();
}
+ return 0;
}
int GetCrossAxis(LayoutOrientation orientation, const gfx::Size& size) {
@@ -354,6 +363,7 @@ int GetCrossAxis(LayoutOrientation orien
case LayoutOrientation::kVertical:
return size.width();
}
+ return 0;
}
SizeBound GetMainAxis(LayoutOrientation orientation, const SizeBounds& size) {
@@ -363,6 +373,7 @@ SizeBound GetMainAxis(LayoutOrientation
case LayoutOrientation::kVertical:
return size.height();
}
+ return SizeBound();
}
SizeBound GetCrossAxis(LayoutOrientation orientation, const SizeBounds& size) {
@@ -372,6 +383,7 @@ SizeBound GetCrossAxis(LayoutOrientation
case LayoutOrientation::kVertical:
return size.width();
}
+ return SizeBound();
}
void SetMainAxis(gfx::Size* size, LayoutOrientation orientation, int main) {
--- chromium-81.0.4044.43/ui/views/controls/slider.cc.gcc9 2020-03-04 22:53:03.000000000 +0100
+++ chromium-81.0.4044.43/ui/views/controls/slider.cc 2020-03-10 00:23:08.673255794 +0100
@@ -435,6 +435,7 @@ SkColor Slider::GetThumbColor() const {
return GetNativeTheme()->GetSystemColor(
ui::NativeTheme::kColorId_SliderThumbMinimal);
}
+ return SkColor(0);
}
SkColor Slider::GetTroughColor() const {
@@ -446,6 +447,7 @@ SkColor Slider::GetTroughColor() const {
return GetNativeTheme()->GetSystemColor(
ui::NativeTheme::kColorId_SliderTroughMinimal);
}
+ return SkColor(0);
}
int Slider::GetSliderExtraPadding() const {
@@ -457,6 +459,7 @@ int Slider::GetSliderExtraPadding() cons
case RenderingStyle::kMinimalStyle:
return kSliderPadding;
}
+ return 0;
}
BEGIN_METADATA(Slider, View)
--- chromium-81.0.4044.43/chrome/browser/sharing/sharing_device_source_sync.cc.gcc9 2020-03-04 22:52:57.000000000 +0100
+++ chromium-81.0.4044.43/chrome/browser/sharing/sharing_device_source_sync.cc 2020-03-11 02:54:30.545256000 +0100
@@ -38,6 +38,7 @@ bool IsDesktop(sync_pb::SyncEnums::Devic
case sync_pb::SyncEnums::DeviceType::SyncEnums_DeviceType_TYPE_OTHER:
return false;
}
+ return false;
}
bool IsStale(const syncer::DeviceInfo& device) {
--- chromium-81.0.4044.43/components/payments/content/payment_app.cc.gcc9 2020-03-04 22:52:13.000000000 +0100
+++ chromium-81.0.4044.43/components/payments/content/payment_app.cc 2020-03-11 03:04:55.137837842 +0100
@@ -38,6 +38,7 @@ int GetSortingGroup(const PaymentApp& ap
NOTREACHED();
return 99;
}
+ return 0;
}
} // namespace
--- chromium-81.0.4044.43/chrome/browser/sharing/sharing_metrics.cc.gcc9 2020-03-09 18:39:43.584247659 +0100
+++ chromium-81.0.4044.43/chrome/browser/sharing/sharing_metrics.cc 2020-03-11 21:59:44.904608891 +0100
@@ -109,6 +109,7 @@ std::string SharingSendMessageResultToSt
case SharingSendMessageResult::kCommitTimeout:
return "CommitTimeout";
}
+ return "";
}
chrome_browser_sharing::MessageType SharingPayloadCaseToMessageType(
--- chromium-81.0.4044.43/chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view.cc.gcc9 2020-03-04 22:52:10.000000000 +0100
+++ chromium-81.0.4044.43/chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view.cc 2020-03-12 11:54:03.930266414 +0100
@@ -49,6 +49,7 @@ int GetSafetyTipBannerId(security_state:
NOTREACHED();
return 0;
}
+ return 0;
}
} // namespace
--- chromium-81.0.4044.43/extensions/browser/url_loader_factory_manager.cc.gcc9 2020-03-04 22:52:58.000000000 +0100
+++ chromium-81.0.4044.43/extensions/browser/url_loader_factory_manager.cc 2020-03-12 16:04:00.912228569 +0100
@@ -332,6 +332,7 @@ bool ShouldDisableCorb(const Extension&
case FactoryUser::kExtensionProcess:
return true;
}
+ return false;
}
// Returns whether URLLoaderFactoryParams::ignore_isolated_world_origin should
@@ -353,6 +354,7 @@ bool ShouldInspectIsolatedWorldOrigin(co
case FactoryUser::kExtensionProcess:
return false;
}
+ return false;
}
bool ShouldCreateSeparateFactoryForContentScripts(const Extension& extension) {
--- chromium-81.0.4044.43/extensions/browser/api/declarative_net_request/ruleset_manager.cc.gcc9 2020-03-04 22:52:58.000000000 +0100
+++ chromium-81.0.4044.43/extensions/browser/api/declarative_net_request/ruleset_manager.cc 2020-03-12 16:20:01.985116614 +0100
@@ -257,6 +257,7 @@ base::Optional<RequestAction> RulesetMan
NOTREACHED();
return 0;
}
+ return 0;
};
base::Optional<RequestAction> action;
--- chromium-81.0.4044.43/third_party/blink/renderer/core/inspector/inspector_dom_agent.cc.gcc9 2020-03-04 22:52:59.000000000 +0100
+++ chromium-81.0.4044.43/third_party/blink/renderer/core/inspector/inspector_dom_agent.cc 2020-03-12 21:27:34.939950894 +0100
@@ -200,6 +200,7 @@ protocol::DOM::PseudoType InspectorDOMAg
CHECK(false);
return "";
}
+ return "";
}
// static
--- chromium-81.0.4044.43/third_party/blink/renderer/modules/xr/xr_target_ray_space.cc.gcc9 2020-03-04 22:53:00.000000000 +0100
+++ chromium-81.0.4044.43/third_party/blink/renderer/modules/xr/xr_target_ray_space.cc 2020-03-13 21:54:26.364818118 +0100
@@ -44,6 +44,7 @@ base::Optional<TransformationMatrix> XRT
*(input_source_->InputFromPointer());
}
}
+ return base::nullopt;
}
bool XRTargetRaySpace::EmulatedPosition() const {
--- chromium-81.0.4044.43/third_party/blink/renderer/modules/xr/xr_dom_overlay_state.cc.gcc9 2020-03-04 22:53:00.000000000 +0100
+++ chromium-81.0.4044.43/third_party/blink/renderer/modules/xr/xr_dom_overlay_state.cc 2020-03-13 22:31:13.607062313 +0100
@@ -17,6 +17,7 @@ const String MapOverlayType(XRDOMOverlay
case XRDOMOverlayState::DOMOverlayType::kFloating:
return "floating";
}
+ return "";
}
} // namespace
--- chromium-81.0.4044.43/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc.gcc9 2020-03-09 18:39:40.360301670 +0100
+++ chromium-81.0.4044.43/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc 2020-03-13 23:28:38.776721307 +0100
@@ -365,6 +365,7 @@ bool ResourceLoadScheduler::IsClientDela
case scheduler::SchedulingLifecycleState::kStopped:
return option != ThrottleOption::kCanNotBeStoppedOrThrottled;
}
+ return true;
}
void ResourceLoadScheduler::OnLifecycleStateChanged(
--- chromium-87.0.4280.27/components/viz/common/quads/quad_list.cc.gcc9 2020-10-30 21:09:35.215498785 +0100
+++ chromium-87.0.4280.27/components/viz/common/quads/quad_list.cc 2020-10-30 21:09:44.299333503 +0100
@@ -103,6 +103,7 @@ QuadList::Iterator QuadList::InsertCopyB
NOTREACHED(); // Invalid DrawQuad material.
return at;
}
+ return at;
}
} // namespace viz
--- chromium-83.0.4103.7/components/cbor/writer.cc.gcc 2020-04-09 00:27:56.000000000 +0200
+++ chromium-83.0.4103.7/components/cbor/writer.cc 2020-04-17 02:18:38.739987679 +0200
@@ -134,6 +134,7 @@ bool Writer::EncodeCBOR(const Value& nod
return true;
}
}
+ return false;
}
void Writer::StartItem(Value::Type type, uint64_t size) {
--- chromium-83.0.4103.7/components/profile_metrics/state.cc.gcc 2020-04-09 00:27:57.000000000 +0200
+++ chromium-83.0.4103.7/components/profile_metrics/state.cc 2020-04-17 02:20:41.139853993 +0200
@@ -27,6 +27,7 @@ std::string GetStateSuffix(StateSuffix s
case StateSuffix::kUponDeletion:
return "_UponDeletion";
}
+ return "";
}
// Context for profile deletion.
@@ -95,4 +96,4 @@ void LogProfileAllAccountsCategories(All
base::UmaHistogramEnumeration("Profile.AllAccounts.Categories", categories);
}
-} // namespace profile_metrics
\ No newline at end of file
+} // namespace profile_metrics
--- chromium-83.0.4103.7/components/variations/study_filtering.cc.gcc9 2020-04-09 00:27:57.000000000 +0200
+++ chromium-83.0.4103.7/components/variations/study_filtering.cc 2020-04-18 16:07:54.278411764 +0200
@@ -140,6 +140,7 @@ bool CheckStudyPolicyRestriction(const S
case RestrictionPolicy::ALL:
return false;
}
+ return false;
}
bool CheckStudyStartDate(const Study::Filter& filter,
--- chromium-83.0.4103.7/ui/gfx/display_color_spaces.cc.gcc9 2020-04-09 00:28:21.000000000 +0200
+++ chromium-83.0.4103.7/ui/gfx/display_color_spaces.cc 2020-04-18 16:31:42.516712560 +0200
@@ -23,6 +23,7 @@ size_t GetIndex(ContentColorUsage color_
case ContentColorUsage::kHDR:
return 4 + needs_alpha;
}
+ return 0;
}
} // namespace
--- chromium-83.0.4103.7/net/base/isolation_info.cc.gcc9 2020-04-09 00:28:01.000000000 +0200
+++ chromium-83.0.4103.7/net/base/isolation_info.cc 2020-04-18 16:41:03.108979045 +0200
@@ -82,6 +82,7 @@ bool IsConsistent(IsolationInfo::Redirec
// subresources.
return ValidateSameSite(*frame_origin, site_for_cookies);
}
+ return false;
}
} // namespace
--- chromium-83.0.4103.7/cc/metrics/compositor_frame_reporter.cc.gcc9 2020-04-09 00:28:31.000000000 +0200
+++ chromium-83.0.4103.7/cc/metrics/compositor_frame_reporter.cc 2020-04-18 17:14:35.441996397 +0200
@@ -58,6 +58,7 @@ constexpr const char* GetVizBreakdownNam
NOTREACHED();
return "";
}
+ return "";
}
// Names for CompositorFrameReporter::StageType, which should be updated in case
--- chromium-83.0.4103.14/cc/metrics/frame_sequence_tracker.cc.gcc9 2020-04-14 23:56:25.000000000 +0200
+++ chromium-83.0.4103.14/cc/metrics/frame_sequence_tracker.cc 2020-04-18 18:59:53.564664497 +0200
@@ -57,6 +57,7 @@ const char* FrameSequenceTracker::GetFra
case FrameSequenceTrackerType::kMaxType:
return "";
}
+ return "";
}
FrameSequenceTracker::FrameSequenceTracker(
--- chromium-83.0.4103.14/ui/native_theme/common_theme.cc.gcc9 2020-04-14 23:56:29.000000000 +0200
+++ chromium-83.0.4103.14/ui/native_theme/common_theme.cc 2020-04-18 19:14:30.368389284 +0200
@@ -529,6 +529,7 @@ SkColor GetDefaultColor(NativeTheme::Col
NOTREACHED();
return gfx::kPlaceholderColor;
}
+ return gfx::kPlaceholderColor;
}
} // namespace
--- chromium-83.0.4103.14/services/network/public/cpp/cross_origin_resource_policy.cc.gcc9 2020-04-14 23:55:31.000000000 +0200
+++ chromium-83.0.4103.14/services/network/public/cpp/cross_origin_resource_policy.cc 2020-04-18 19:21:44.115832424 +0200
@@ -52,6 +52,7 @@ CorpResult ToCorpResult(
case mojom::BlockedByResponseReason::kCorpNotSameSite:
return CorpResult::kNotSameSite;
}
+ return CorpResult::kSuccess;
}
// https://fetch.spec.whatwg.org/#cross-origin-resource-policy-header says:
--- chromium-83.0.4103.14/chrome/browser/notifications/scheduler/internal/proto_conversion.cc.gcc9 2020-04-18 17:47:03.510958003 +0200
+++ chromium-83.0.4103.14/chrome/browser/notifications/scheduler/internal/proto_conversion.cc 2020-04-18 19:49:25.464814344 +0200
@@ -61,6 +61,7 @@ proto::SchedulerClientType ToSchedulerCl
return proto::SchedulerClientType::READING_LIST;
}
NOTREACHED();
+ return proto::SchedulerClientType::UNKNOWN;
}
// Converts SchedulerClientType from its associated enum in proto buffer.
@@ -85,6 +86,7 @@ SchedulerClientType FromSchedulerClientT
return SchedulerClientType::kReadingList;
}
NOTREACHED();
+ return SchedulerClientType::kUnknown;
}
// Converts UserFeedback to its associated enum in proto buffer.
--- chromium-83.0.4103.14/components/policy/core/common/remote_commands/remote_commands_service.cc.gcc9 2020-04-14 23:55:23.000000000 +0200
+++ chromium-83.0.4103.14/components/policy/core/common/remote_commands/remote_commands_service.cc 2020-04-18 20:11:28.565656364 +0200
@@ -118,6 +118,7 @@ const char* RemoteCommandsService::GetMe
"device local account scope.";
return "";
}
+ return "";
}
// static
--- chromium-83.0.4103.14/printing/print_settings.cc.gcc9 2020-04-14 23:56:28.000000000 +0200
+++ chromium-83.0.4103.14/printing/print_settings.cc 2020-04-18 20:30:30.475698533 +0200
@@ -231,6 +231,7 @@ base::Optional<bool> IsColorModelSelecte
}
// The default case is excluded from the above switch statement to ensure that
// all ColorModel values are determinantly handled.
+ return base::nullopt;
}
// Global SequenceNumber used for generating unique cookie values.
--- chromium-83.0.4103.14/ui/base/x/x11_util.cc.gcc9 2020-04-14 23:56:15.000000000 +0200
+++ chromium-83.0.4103.14/ui/base/x/x11_util.cc 2020-04-18 20:45:01.832484412 +0200
@@ -1092,6 +1092,7 @@ bool IsWmTiling(WindowManagerName window
// Unknown. Assume stacking.
return false;
}
+ return false;
}
bool GetWindowDesktop(x11::Window window, int* desktop) {
--- chromium-83.0.4103.14/ui/accessibility/ax_enum_util.cc.gcc9 2020-04-14 23:56:15.000000000 +0200
+++ chromium-83.0.4103.14/ui/accessibility/ax_enum_util.cc 2020-04-18 20:49:01.607298369 +0200
@@ -673,6 +673,7 @@ const char* ToString(ax::mojom::ScrollAl
case ax::mojom::ScrollAlignment::kScrollAlignmentClosestEdge:
return "scrollAlignmentClosestEdge";
}
+ return "";
}
const char* ToString(ax::mojom::DefaultActionVerb default_action_verb) {
--- chromium-83.0.4103.14/third_party/blink/renderer/platform/widget/input/input_handler_proxy.cc.gcc9 2020-04-14 23:56:29.000000000 +0200
+++ chromium-83.0.4103.14/third_party/blink/renderer/platform/widget/input/input_handler_proxy.cc 2020-04-18 20:56:21.129623524 +0200
@@ -119,6 +119,7 @@ ui::ScrollInputType GestureScrollInputTy
NOTREACHED();
return ui::ScrollInputType::kMaxValue;
}
+ return ui::ScrollInputType::kMaxValue;
}
cc::SnapFlingController::GestureScrollType GestureScrollEventType(
--- chromium-83.0.4103.14/ui/views/animation/ink_drop_highlight.cc.gcc9 2020-04-14 23:56:16.000000000 +0200
+++ chromium-83.0.4103.14/ui/views/animation/ink_drop_highlight.cc 2020-04-18 21:05:31.034994755 +0200
@@ -37,6 +37,7 @@ std::string ToString(InkDropHighlight::A
case InkDropHighlight::AnimationType::kFadeOut:
return std::string("FADE_OUT");
}
+ return std::string();
}
InkDropHighlight::InkDropHighlight(
--- chromium-83.0.4103.14/chrome/browser/policy/cloud/remote_commands_invalidator_impl.cc.gcc9 2020-04-14 23:55:16.000000000 +0200
+++ chromium-83.0.4103.14/chrome/browser/policy/cloud/remote_commands_invalidator_impl.cc 2020-04-18 22:30:18.131559320 +0200
@@ -27,6 +27,7 @@ const char* GetInvalidationMetricName(Po
"device local account scope.";
return "";
}
+ return "";
}
} // namespace
--- chromium-83.0.4103.14/chrome/browser/policy/cloud/cloud_policy_invalidator.cc.gcc9 2020-04-14 23:55:16.000000000 +0200
+++ chromium-83.0.4103.14/chrome/browser/policy/cloud/cloud_policy_invalidator.cc 2020-04-18 22:31:58.533792642 +0200
@@ -125,6 +125,7 @@ const char* CloudPolicyInvalidator::GetP
case PolicyInvalidationScope::kCBCM:
return kMetricCBCMPolicyRefresh;
}
+ return kMetricUserPolicyRefresh;
}
// static
@@ -140,6 +141,7 @@ const char* CloudPolicyInvalidator::GetP
case PolicyInvalidationScope::kCBCM:
return kMetricCBCMPolicyRefreshFcm;
}
+ return kMetricUserPolicyRefreshFcm;
}
// static
@@ -155,6 +157,7 @@ const char* CloudPolicyInvalidator::GetP
case PolicyInvalidationScope::kCBCM:
return kMetricCBCMPolicyInvalidations;
}
+ return kMetricUserPolicyInvalidations;
}
// static
@@ -170,6 +173,7 @@ const char* CloudPolicyInvalidator::GetP
case PolicyInvalidationScope::kCBCM:
return kMetricCBCMPolicyInvalidationsFcm;
}
+ return kMetricUserPolicyInvalidationsFcm;
}
CloudPolicyInvalidator::CloudPolicyInvalidator(
--- chromium-83.0.4103.14/chrome/browser/profiles/profile_attributes_entry.cc.gcc9 2020-04-14 23:56:26.000000000 +0200
+++ chromium-83.0.4103.14/chrome/browser/profiles/profile_attributes_entry.cc 2020-04-19 01:35:38.662045344 +0200
@@ -235,6 +235,7 @@ base::string16 ProfileAttributesEntry::G
return GetGAIANameToDisplay() + base::UTF8ToUTF16(" (") +
GetLocalProfileName() + base::UTF8ToUTF16(")");
}
+ return base::string16();
}
base::string16 ProfileAttributesEntry::GetShortcutName() const {
--- chromium-83.0.4103.14/chrome/browser/profiles/profile_attributes_storage.cc.gcc9 2020-04-14 23:55:16.000000000 +0200
+++ chromium-83.0.4103.14/chrome/browser/profiles/profile_attributes_storage.cc 2020-04-19 01:48:41.510440965 +0200
@@ -190,6 +190,7 @@ profile_metrics::NameState GetNameState(
return has_default_name ? profile_metrics::NameState::kGaiaAndDefaultName
: profile_metrics::NameState::kGaiaAndCustomName;
}
+ return profile_metrics::NameState::kDefaultName;
}
profile_metrics::UnconsentedPrimaryAccountType GetUnconsentedPrimaryAccountType(
--- chromium-83.0.4103.14/chrome/browser/apps/app_service/launch_utils.cc.gcc9 2020-04-14 23:56:26.000000000 +0200
+++ chromium-83.0.4103.14/chrome/browser/apps/app_service/launch_utils.cc 2020-04-19 02:28:39.202683550 +0200
@@ -206,6 +206,7 @@ apps::mojom::AppLaunchSource GetAppLaunc
case apps::mojom::LaunchSource::kFromArc:
return apps::mojom::AppLaunchSource::kSourceArc;
}
+ return apps::mojom::AppLaunchSource::kSourceAppLauncher;
}
int GetEventFlags(apps::mojom::LaunchContainer container,
--- chromium-83.0.4103.14/chrome/browser/media/history/media_history_feed_items_table.cc.gcc9 2020-04-14 23:55:16.000000000 +0200
+++ chromium-83.0.4103.14/chrome/browser/media/history/media_history_feed_items_table.cc 2020-04-19 02:39:35.655223602 +0200
@@ -32,6 +32,7 @@ media_feeds::InteractionCounter_Type Con
case media_feeds::mojom::InteractionCounterType::kWatch:
return media_feeds::InteractionCounter_Type_WATCH;
}
+ return media_feeds::InteractionCounter_Type_LIKE;
}
base::Optional<media_feeds::mojom::InteractionCounterType> Convert(
@@ -50,6 +51,7 @@ base::Optional<media_feeds::mojom::Inter
NOTREACHED();
return base::nullopt;
}
+ return base::nullopt;
}
media_feeds::mojom::IdentifierPtr Convert(
--- chromium-83.0.4103.14/chrome/browser/themes/theme_helper.cc.gcc9 2020-04-14 23:55:17.000000000 +0200
+++ chromium-83.0.4103.14/chrome/browser/themes/theme_helper.cc 2020-04-19 03:05:52.247735390 +0200
@@ -150,6 +150,7 @@ bool ThemeHelper::IsDefaultTheme(const C
case Type::AUTOGENERATED:
return false;
}
+ return false;
}
// static
--- chromium-83.0.4103.14/chrome/browser/media/router/mojo/media_router_mojo_metrics.cc.gcc9 2020-04-14 23:55:16.000000000 +0200
+++ chromium-83.0.4103.14/chrome/browser/media/router/mojo/media_router_mojo_metrics.cc 2020-04-19 13:09:19.090508660 +0200
@@ -42,6 +42,7 @@ std::string GetHistogramNameForProvider(
case MediaRouteProviderId::UNKNOWN:
return base_name;
}
+ return std::string();
}
} // namespace
--- chromium-83.0.4103.14/chrome/browser/ui/passwords/settings/password_manager_presenter.cc.gcc9 2020-04-14 23:55:18.000000000 +0200
+++ chromium-83.0.4103.14/chrome/browser/ui/passwords/settings/password_manager_presenter.cc 2020-04-19 13:20:37.099355258 +0200
@@ -112,6 +112,7 @@ ConvertPlaintextReason(password_manager:
case password_manager::PlaintextReason::kEdit:
return password_manager::metrics_util::ACCESS_PASSWORD_EDITED;
}
+ return password_manager::metrics_util::ACCESS_PASSWORD_COPIED;
}
#endif
--- chromium-83.0.4103.14/chrome/browser/safe_browsing/cloud_content_scanning/binary_upload_service.cc.gcc9 2020-04-14 23:55:17.000000000 +0200
+++ chromium-83.0.4103.14/chrome/browser/safe_browsing/cloud_content_scanning/binary_upload_service.cc 2020-04-19 13:50:45.858206397 +0200
@@ -81,6 +81,7 @@ std::string ResultToString(BinaryUploadS
case BinaryUploadService::Result::DLP_SCAN_UNSUPPORTED_FILE_TYPE:
return "DLP_SCAN_UNSUPPORTED_FILE_TYPE";
}
+ return "";
}
constexpr char kBinaryUploadServiceUrlFlag[] = "binary-upload-service-url";
--- chromium-83.0.4103.14/chrome/browser/safe_browsing/cloud_content_scanning/deep_scanning_utils.cc.gcc9 2020-04-14 23:56:26.000000000 +0200
+++ chromium-83.0.4103.14/chrome/browser/safe_browsing/cloud_content_scanning/deep_scanning_utils.cc 2020-04-19 13:54:02.957734566 +0200
@@ -354,6 +354,7 @@ std::string BinaryUploadServiceResultToS
case BinaryUploadService::Result::DLP_SCAN_UNSUPPORTED_FILE_TYPE:
return "DlpScanUnsupportedFileType";
}
+ return "";
}
std::string GetProfileEmail(Profile* profile) {
--- chromium-83.0.4103.14/chrome/browser/ui/browser_window_state.cc.gcc9 2020-04-14 23:55:18.000000000 +0200
+++ chromium-83.0.4103.14/chrome/browser/ui/browser_window_state.cc 2020-04-19 14:22:23.589968372 +0200
@@ -90,6 +90,7 @@ std::string GetWindowName(const Browser*
case Browser::TYPE_APP_POPUP:
return browser->app_name() + "_popup";
}
+ return std::string();
}
std::unique_ptr<DictionaryPrefUpdate> GetWindowPlacementDictionaryReadWrite(
--- chromium-83.0.4103.14/chrome/browser/ui/webui/settings/safety_check_handler.cc.gcc9 2020-04-14 23:56:27.000000000 +0200
+++ chromium-83.0.4103.14/chrome/browser/ui/webui/settings/safety_check_handler.cc 2020-04-19 14:55:39.533064110 +0200
@@ -88,6 +88,7 @@ SafetyCheckHandler::UpdateStatus Convert
case VersionUpdater::FAILED_OFFLINE:
return SafetyCheckHandler::UpdateStatus::kFailedOffline;
}
+ return SafetyCheckHandler::UpdateStatus::kFailed;
}
#if defined(OS_WIN) && BUILDFLAG(GOOGLE_CHROME_BRANDING)
@@ -460,6 +461,7 @@ base::string16 SafetyCheckHandler::GetSt
return l10n_util::GetStringUTF16(
IDS_SETTINGS_SAFETY_CHECK_PARENT_PRIMARY_LABEL_AFTER);
}
+ return base::string16();
}
base::string16 SafetyCheckHandler::GetStringForUpdates(UpdateStatus status) {
@@ -502,6 +504,7 @@ base::string16 SafetyCheckHandler::GetSt
case UpdateStatus::kOutdated:
return base::UTF8ToUTF16("");
}
+ return base::string16();
}
base::string16 SafetyCheckHandler::GetStringForSafeBrowsing(
@@ -530,6 +533,7 @@ base::string16 SafetyCheckHandler::GetSt
return l10n_util::GetStringUTF16(
IDS_SETTINGS_SAFETY_CHECK_SAFE_BROWSING_ENABLED_STANDARD_AVAILABLE_ENHANCED);
}
+ return base::string16();
}
base::string16 SafetyCheckHandler::GetStringForPasswords(
@@ -680,6 +684,7 @@ base::string16 SafetyCheckHandler::GetSt
return l10n_util::GetPluralStringFUTF16(days_ago_message_id,
time_diff_in_days);
}
+ return base::string16();
}
base::string16 SafetyCheckHandler::GetStringForParentRan(
--- chromium-83.0.4103.14/chrome/browser/ui/views/native_file_system/native_file_system_permission_view.cc.gcc9 2020-04-14 23:55:18.000000000 +0200
+++ chromium-83.0.4103.14/chrome/browser/ui/views/native_file_system/native_file_system_permission_view.cc 2020-04-19 15:40:19.282255836 +0200
@@ -40,6 +40,7 @@ int GetMessageText(const NativeFileSyste
: IDS_NATIVE_FILE_SYSTEM_ORIGIN_SCOPED_WRITE_PERMISSION_FILE_TEXT;
}
NOTREACHED();
+ return 0;
}
int GetButtonLabel(const NativeFileSystemPermissionView::Request& request) {
@@ -56,6 +57,7 @@ int GetButtonLabel(const NativeFileSyste
: IDS_NATIVE_FILE_SYSTEM_EDIT_FILE_PERMISSION_ALLOW_TEXT;
}
NOTREACHED();
+ return 0;
}
} // namespace
@@ -137,6 +139,7 @@ base::string16 NativeFileSystemPermissio
}
}
NOTREACHED();
+ return base::string16();
}
views::View* NativeFileSystemPermissionView::GetInitiallyFocusedView() {
--- chromium-83.0.4103.14/components/payments/content/payment_event_response_util.cc.gcc9 2020-04-18 17:47:04.580939318 +0200
+++ chromium-83.0.4103.14/components/payments/content/payment_event_response_util.cc 2020-04-19 16:36:26.791863861 +0200
@@ -47,6 +47,7 @@ base::StringPiece ConvertCanMakePaymentE
case mojom::CanMakePaymentEventResponseType::SUCCESS:
return "";
}
+ return "";
}
base::StringPiece ConvertPaymentEventResponseTypeToErrorString(
--- chromium-83.0.4103.14/content/browser/download/save_package.cc.gcc9 2020-04-14 23:55:25.000000000 +0200
+++ chromium-83.0.4103.14/content/browser/download/save_package.cc 2020-04-19 16:59:03.953255442 +0200
@@ -144,6 +144,7 @@ const std::string GetMimeTypeForSaveType
return "";
}
NOTREACHED();
+ return "";
}
} // namespace
--- chromium-83.0.4103.14/content/browser/gpu/peak_gpu_memory_tracker_impl.cc.gcc9 2020-04-14 23:55:25.000000000 +0200
+++ chromium-83.0.4103.14/content/browser/gpu/peak_gpu_memory_tracker_impl.cc 2020-04-19 17:37:05.566729083 +0200
@@ -46,6 +46,7 @@ constexpr const char* GetUsageName(PeakG
case PeakGpuMemoryTracker::Usage::SCROLL:
return "Scroll";
}
+ return "";
}
constexpr const char* GetAllocationSourceName(
@@ -62,6 +63,7 @@ constexpr const char* GetAllocationSourc
case gpu::GpuPeakMemoryAllocationSource::SKIA:
return "Skia";
}
+ return "";
}
std::string GetPeakMemoryUsageUMAName(PeakGpuMemoryTracker::Usage usage) {
--- chromium-83.0.4103.14/third_party/blink/renderer/core/typed_arrays/dom_array_buffer_view.h.gcc9 2020-04-14 23:55:35.000000000 +0200
+++ chromium-83.0.4103.14/third_party/blink/renderer/core/typed_arrays/dom_array_buffer_view.h 2020-04-19 19:10:39.317990580 +0200
@@ -93,6 +93,7 @@ class CORE_EXPORT DOMArrayBufferView : p
return "DataView";
break;
}
+ return "";
}
void* BaseAddress() const {
--- chromium-83.0.4103.14/third_party/blink/renderer/core/animation/animation_timeline.cc.gcc9 2020-04-14 23:55:33.000000000 +0200
+++ chromium-83.0.4103.14/third_party/blink/renderer/core/animation/animation_timeline.cc 2020-04-19 20:43:20.277964886 +0200
@@ -74,6 +74,7 @@ String AnimationTimeline::phase() {
case TimelinePhase::kAfter:
return "after";
}
+ return "";
}
void AnimationTimeline::ClearOutdatedAnimation(Animation* animation) {
--- chromium-83.0.4103.14/third_party/blink/renderer/core/css/resolver/cascade_expansion.cc.gcc9 2020-04-14 23:55:34.000000000 +0200
+++ chromium-83.0.4103.14/third_party/blink/renderer/core/css/resolver/cascade_expansion.cc 2020-04-19 20:56:10.001232503 +0200
@@ -27,6 +27,7 @@ CascadeFilter AddValidPropertiesFilter(
case ValidPropertyFilter::kHighlight:
return filter.Add(CSSProperty::kValidForHighlight, false);
}
+ return filter;
}
CascadeFilter AddLinkFilter(CascadeFilter filter,
--- chromium-83.0.4103.14/third_party/blink/renderer/core/css/vision_deficiency.cc.gcc9 2020-04-14 23:55:34.000000000 +0200
+++ chromium-83.0.4103.14/third_party/blink/renderer/core/css/vision_deficiency.cc 2020-04-19 21:17:03.191898438 +0200
@@ -68,6 +68,7 @@ AtomicString CreateVisionDeficiencyFilte
NOTREACHED();
return "";
}
+ return "";
}
} // namespace blink
--- chromium-83.0.4103.14/third_party/blink/renderer/core/events/message_event.cc.gcc9 2020-04-14 23:55:34.000000000 +0200
+++ chromium-83.0.4103.14/third_party/blink/renderer/core/events/message_event.cc 2020-04-19 22:57:46.993722797 +0200
@@ -70,6 +70,7 @@ size_t MessageEvent::SizeOfExternalMemor
case kDataTypeArrayBuffer:
return data_as_array_buffer_->ByteLength();
}
+ return 0;
}
void MessageEvent::RegisterAmountOfExternallyAllocatedMemory() {
--- chromium-83.0.4103.14/third_party/blink/renderer/core/page/pointer_lock_controller.cc.gcc9 2020-04-14 23:56:28.000000000 +0200
+++ chromium-83.0.4103.14/third_party/blink/renderer/core/page/pointer_lock_controller.cc 2020-04-20 11:22:26.656777661 +0200
@@ -197,6 +197,7 @@ DOMException* PointerLockController::Con
"If you see this error we have a bug. Please report this bug to "
"chromium.");
}
+ return nullptr;
}
void PointerLockController::RejectIfPromiseEnabled(
--- chromium-83.0.4103.14/third_party/blink/renderer/modules/mediastream/webmediaplayer_ms.cc.gcc9 2020-04-14 23:56:28.000000000 +0200
+++ chromium-83.0.4103.14/third_party/blink/renderer/modules/mediastream/webmediaplayer_ms.cc 2020-04-20 12:42:46.264053410 +0200
@@ -88,6 +88,7 @@ const char* LoadTypeToString(WebMediaPla
case WebMediaPlayer::kLoadTypeMediaStream:
return "MediaStream";
}
+ return "";
}
const char* ReadyStateToString(WebMediaPlayer::ReadyState state) {
@@ -103,6 +104,7 @@ const char* ReadyStateToString(WebMediaP
case WebMediaPlayer::kReadyStateHaveEnoughData:
return "HaveEnoughData";
}
+ return "";
}
const char* NetworkStateToString(WebMediaPlayer::NetworkState state) {
@@ -122,6 +124,7 @@ const char* NetworkStateToString(WebMedi
case WebMediaPlayer::kNetworkStateDecodeError:
return "DecodeError";
}
+ return "";
}
constexpr base::TimeDelta kForceBeginFramesTimeout =
--- chromium-83.0.4103.14/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc.gcc9 2020-04-14 23:55:35.000000000 +0200
+++ chromium-83.0.4103.14/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc 2020-04-20 14:02:07.535385780 +0200
@@ -265,6 +265,7 @@ std::string PriorityFromEnum(webrtc::Pri
case webrtc::Priority::kHigh:
return "high";
}
+ return "";
}
webrtc::Priority PriorityToEnum(const WTF::String& priority) {
--- chromium-83.0.4103.14/third_party/blink/renderer/modules/webrtc/webrtc_audio_renderer.cc.gcc9 2020-04-14 23:55:35.000000000 +0200
+++ chromium-83.0.4103.14/third_party/blink/renderer/modules/webrtc/webrtc_audio_renderer.cc 2020-04-20 19:03:03.048280556 +0200
@@ -75,6 +75,7 @@ const char* OutputDeviceStatusToString(m
case media::OUTPUT_DEVICE_STATUS_ERROR_INTERNAL:
return "ERROR_INTERNAL";
}
+ return "";
}
const char* StateToString(WebRtcAudioRenderer::State state) {
@@ -86,6 +87,7 @@ const char* StateToString(WebRtcAudioRen
case WebRtcAudioRenderer::PAUSED:
return "PAUSED";
}
+ return "";
}
// This is a simple wrapper class that's handed out to users of a shared
--- chromium-84.0.4147.89/components/image_fetcher/core/cache/image_metadata_store_leveldb.cc.gcc10 2020-07-13 20:40:28.000000000 +0200
+++ chromium-84.0.4147.89/components/image_fetcher/core/cache/image_metadata_store_leveldb.cc 2020-07-23 23:41:36.999571290 +0200
@@ -41,6 +41,7 @@ CacheOption ToCacheOption(CacheStrategy
case CacheStrategy::HOLD_UNTIL_EXPIRED:
return CacheOption::kHoldUntilExpired;
}
+ return CacheOption::kBestEffort;
}
// The folder where the data will be stored on disk.
--- chromium-84.0.4147.89/components/sync/base/data_type_histogram.cc.gcc10 2020-07-13 20:40:29.000000000 +0200
+++ chromium-84.0.4147.89/components/sync/base/data_type_histogram.cc 2020-07-24 00:11:18.581365383 +0200
@@ -28,6 +28,7 @@ std::string GetHistogramSuffixForUpdateD
case UpdateDropReason::kFailedToDecrypt:
return "FailedToDecrypt";
}
+ return "";
}
} // namespace
--- chromium-84.0.4147.89/device/fido/make_credential_request_handler.cc.gcc10 2020-07-13 20:41:26.000000000 +0200
+++ chromium-84.0.4147.89/device/fido/make_credential_request_handler.cc 2020-07-24 00:28:49.202747177 +0200
@@ -176,6 +176,7 @@ CredProtect CredProtectForAuthenticator(
}
return CredProtect::kUVOrCredIDRequired;
}
+ return CredProtect::kUVRequired;
}
// ValidateResponseExtensions returns true iff |extensions| is valid as a
--- chromium-84.0.4147.89/services/network/trust_tokens/trust_token_operation_metrics_recorder.cc.gcc10 2020-07-13 20:40:40.000000000 +0200
+++ chromium-84.0.4147.89/services/network/trust_tokens/trust_token_operation_metrics_recorder.cc 2020-07-24 00:48:25.773735532 +0200
@@ -48,6 +48,7 @@ base::StringPiece TypeToString(mojom::Tr
case mojom::TrustTokenOperationType::kSigning:
return "Signing";
}
+ return "";
}
const char kHistogramPartsSeparator[] = ".";
--- chromium-84.0.4147.89/services/network/trust_tokens/trust_token_store.cc.gcc10 2020-07-13 20:41:27.000000000 +0200
+++ chromium-84.0.4147.89/services/network/trust_tokens/trust_token_store.cc 2020-07-24 01:17:51.661416318 +0200
@@ -304,6 +304,7 @@ bool TrustTokenStore::ClearDataForFilter
case mojom::ClearDataFilter::Type::DELETE_MATCHES:
return is_match;
}
+ return false;
},
*filter);
--- chromium-84.0.4147.89/third_party/blink/common/input/web_gesture_event.cc.gcc10 2020-07-13 20:40:40.000000000 +0200
+++ chromium-84.0.4147.89/third_party/blink/common/input/web_gesture_event.cc 2020-07-24 01:38:41.151863419 +0200
@@ -112,6 +112,7 @@ base::Optional<ui::ScrollInputType> WebG
case WebGestureDevice::kUninitialized:
return base::nullopt;
}
+ return base::nullopt;
}
float WebGestureEvent::DeltaXInRootFrame() const {
--- chromium-84.0.4147.89/ui/views/layout/animating_layout_manager.cc.gcc10 2020-07-23 21:47:49.614991600 +0200
+++ chromium-84.0.4147.89/ui/views/layout/animating_layout_manager.cc 2020-07-24 01:58:30.327349374 +0200
@@ -344,6 +344,7 @@ gfx::Size AnimatingLayoutManager::GetPre
case BoundsAnimationMode::kAnimateBothAxes:
return current_layout_.host_size;
}
+ return gfx::Size();
}
gfx::Size AnimatingLayoutManager::GetMinimumSize(const View* host) const {
--- chromium-84.0.4147.89/chrome/browser/web_applications/extensions/bookmark_app_util.cc.gcc10 2020-07-13 20:41:23.000000000 +0200
+++ chromium-84.0.4147.89/chrome/browser/web_applications/extensions/bookmark_app_util.cc 2020-07-24 02:14:43.871976975 +0200
@@ -123,6 +123,8 @@ LaunchContainerAndType GetLaunchContaine
: extensions::LaunchType::LAUNCH_TYPE_WINDOW};
}
NOTREACHED();
+ return {extensions::LaunchContainer::kLaunchContainerNone,
+ extensions::LaunchType::LAUNCH_TYPE_DEFAULT};
}
} // namespace extensions
--- chromium-84.0.4147.89/chrome/browser/metrics/process_memory_metrics_emitter.cc.gcc10 2020-07-13 20:41:22.000000000 +0200
+++ chromium-84.0.4147.89/chrome/browser/metrics/process_memory_metrics_emitter.cc 2020-07-24 10:02:55.136862422 +0200
@@ -410,6 +410,7 @@ const char* MetricSizeToVersionSuffix(Me
case MetricSize::kCustom:
return VERSION_SUFFIX_CUSTOM;
}
+ return VERSION_SUFFIX_NORMAL;
}
void EmitProcessUma(HistogramProcessType process_type,
--- chromium-84.0.4147.89/chrome/browser/net/secure_dns_config.cc.gcc10 2020-07-13 20:40:23.000000000 +0200
+++ chromium-84.0.4147.89/chrome/browser/net/secure_dns_config.cc 2020-07-24 10:16:32.893360378 +0200
@@ -43,4 +43,5 @@ const char* SecureDnsConfig::ModeToStrin
case net::SecureDnsMode::kOff:
return kModeOff;
}
+ return "";
}
--- chromium-84.0.4147.89/chrome/browser/sharing/sharing_utils.cc.gcc10 2020-07-13 20:41:22.000000000 +0200
+++ chromium-84.0.4147.89/chrome/browser/sharing/sharing_utils.cc 2020-07-24 10:29:41.342407617 +0200
@@ -124,4 +124,5 @@ SharingDevicePlatform GetDevicePlatform(
case sync_pb::SyncEnums::DeviceType::SyncEnums_DeviceType_TYPE_OTHER:
return SharingDevicePlatform::kUnknown;
}
+ return SharingDevicePlatform::kUnknown;
}
--- chromium-84.0.4147.89/chrome/browser/apps/app_service/web_apps_base.cc.gcc10 2020-07-13 20:41:21.000000000 +0200
+++ chromium-84.0.4147.89/chrome/browser/apps/app_service/web_apps_base.cc 2020-07-24 10:36:42.259415661 +0200
@@ -59,6 +59,7 @@ apps::mojom::InstallSource GetHighestPri
case web_app::Source::kDefault:
return apps::mojom::InstallSource::kDefault;
}
+ return apps::mojom::InstallSource::kDefault;
}
apps::mojom::IntentFilterPtr CreateShareFileFilter(
--- chromium-84.0.4147.89/chrome/browser/apps/app_service/extension_apps_base.cc.gcc10 2020-07-13 20:41:21.000000000 +0200
+++ chromium-84.0.4147.89/chrome/browser/apps/app_service/extension_apps_base.cc 2020-07-24 11:03:53.270477561 +0200
@@ -136,6 +136,7 @@ ash::ShelfLaunchSource ConvertLaunchSour
case apps::mojom::LaunchSource::kFromReleaseNotesNotification:
return ash::LAUNCH_FROM_UNKNOWN;
}
+ return ash::LAUNCH_FROM_UNKNOWN;
}
apps::mojom::InstallSource GetInstallSource(
--- chromium-84.0.4147.89/chrome/browser/enterprise/connectors/common.cc.gcc10 2020-07-13 20:41:22.000000000 +0200
+++ chromium-84.0.4147.89/chrome/browser/enterprise/connectors/common.cc 2020-07-24 11:27:32.006626858 +0200
@@ -32,6 +32,7 @@ const char* ConnectorPref(AnalysisConnec
NOTREACHED() << "Using unspecified analysis connector";
return "";
}
+ return "";
}
const char* ConnectorPref(ReportingConnector connector) {
--- chromium-84.0.4147.89/chrome/browser/media/feeds/media_feeds_utils.cc.gcc10 2020-07-13 20:40:23.000000000 +0200
+++ chromium-84.0.4147.89/chrome/browser/media/feeds/media_feeds_utils.cc 2020-07-24 12:05:59.372002200 +0200
@@ -44,6 +44,8 @@ Image::ContentAttribute MojoContentAttri
return Image::ContentAttribute::
Image_ContentAttribute_CONTENT_ATTRIBUTE_UNSPECIFIED;
}
+ return Image::ContentAttribute::
+ Image_ContentAttribute_CONTENT_ATTRIBUTE_UNSPECIFIED;
}
media_feeds::mojom::ContentAttribute ProtoContentAttributeToMojo(
@@ -84,6 +86,7 @@ media_feeds::mojom::ContentAttribute Pro
NOTREACHED();
return media_feeds::mojom::ContentAttribute::kUnknown;
}
+ return media_feeds::mojom::ContentAttribute::kUnknown;
}
void MediaImageToProto(Image* proto,
--- chromium-84.0.4147.89/chrome/browser/ui/webui/settings/safety_check_handler.cc.gcc10 2020-07-23 21:47:49.809987945 +0200
+++ chromium-84.0.4147.89/chrome/browser/ui/webui/settings/safety_check_handler.cc 2020-07-24 13:51:52.497461878 +0200
@@ -463,6 +463,7 @@ base::string16 SafetyCheckHandler::GetSt
return l10n_util::GetStringUTF16(
IDS_SETTINGS_SAFETY_CHECK_PASSWORDS_FEATURE_UNAVAILABLE);
}
+ return base::string16();
}
base::string16 SafetyCheckHandler::GetStringForExtensions(
--- chromium-84.0.4147.89/chrome/browser/ui/webui/tab_strip/tab_strip_ui_handler.cc.gcc10 2020-07-13 20:41:23.000000000 +0200
+++ chromium-84.0.4147.89/chrome/browser/ui/webui/tab_strip/tab_strip_ui_handler.cc 2020-07-24 14:48:19.489057094 +0200
@@ -69,6 +69,7 @@ std::string ConvertAlertStateToString(Ta
default:
NOTREACHED();
}
+ return "";
}
class WebUIBackgroundMenuModel : public ui::SimpleMenuModel {
--- chromium-84.0.4147.89/components/password_manager/core/browser/password_manager_features_util.cc.gcc10 2020-07-13 20:41:24.000000000 +0200
+++ chromium-84.0.4147.89/components/password_manager/core/browser/password_manager_features_util.cc 2020-07-24 15:15:24.757384286 +0200
@@ -447,6 +447,7 @@ PasswordAccountStorageUsageLevel Compute
case UserState::kSyncUser:
return UsageLevel::kSyncing;
}
+ return UsageLevel::kNotUsingAccountStorage;
}
void RecordMoveOfferedToNonOptedInUser(
--- chromium-84.0.4147.89/components/performance_manager/decorators/page_load_tracker_decorator.cc.gcc10 2020-07-13 20:40:28.000000000 +0200
+++ chromium-84.0.4147.89/components/performance_manager/decorators/page_load_tracker_decorator.cc 2020-07-24 15:56:47.682702378 +0200
@@ -60,6 +60,7 @@ const char* ToString(LoadIdleState state
case LoadIdleState::kLoadedAndIdle:
return "kLoadedAndIdle";
}
+ return "";
}
const char kDescriberName[] = "PageLoadTrackerDecorator";
--- chromium-84.0.4147.89/components/performance_manager/graph/worker_node_impl_describer.cc.gcc10 2020-07-13 20:40:28.000000000 +0200
+++ chromium-84.0.4147.89/components/performance_manager/graph/worker_node_impl_describer.cc 2020-07-24 16:23:42.016596237 +0200
@@ -21,6 +21,7 @@ const char* WorkerTypeToString(WorkerNod
case WorkerNode::WorkerType::kService:
return "kService";
}
+ return "";
}
} // namespace
--- chromium-84.0.4147.89/components/performance_manager/graph/graph_impl.cc.gcc10 2020-07-13 20:41:24.000000000 +0200
+++ chromium-84.0.4147.89/components/performance_manager/graph/graph_impl.cc 2020-07-24 17:07:47.102187946 +0200
@@ -142,6 +142,7 @@ base::Value NodeDataDescriberRegistryImp
return DescribeNodeImpl(&NodeDataDescriber::DescribeWorkerNodeData,
WorkerNodeImpl::FromNodeBase(node_base));
}
+ return base::Value();
}
} // namespace
--- chromium-84.0.4147.89/extensions/browser/api/declarative_net_request/request_action.cc.gcc10 2020-07-13 20:41:26.000000000 +0200
+++ chromium-84.0.4147.89/extensions/browser/api/declarative_net_request/request_action.cc 2020-07-24 19:17:42.474940133 +0200
@@ -23,6 +23,7 @@ dnr_api::HeaderOperation ConvertFlatHead
case flat::HeaderOperation_remove:
return dnr_api::HEADER_OPERATION_REMOVE;
}
+ return dnr_api::HeaderOperation();
}
} // namespace
--- chromium-84.0.4147.89/third_party/blink/renderer/core/animation/scroll_timeline.cc.gcc10 2020-07-13 20:41:27.000000000 +0200
+++ chromium-84.0.4147.89/third_party/blink/renderer/core/animation/scroll_timeline.cc 2020-07-24 23:30:16.491318968 +0200
@@ -74,6 +74,7 @@ ScrollOrientation ToPhysicalScrollOrient
case ScrollTimeline::Vertical:
return kVerticalScroll;
}
+ return kVerticalScroll;
}
// Note that the resolution process may trigger document lifecycle to clean
--- chromium-84.0.4147.89/third_party/blink/renderer/core/css/properties/computed_style_utils.cc.gcc10 2020-07-13 20:41:27.000000000 +0200
+++ chromium-84.0.4147.89/third_party/blink/renderer/core/css/properties/computed_style_utils.cc 2020-07-25 00:05:39.859031547 +0200
@@ -1907,6 +1907,7 @@ CSSFunctionValue* ComputedStyleUtils::Va
return ValueForTransformationMatrix(matrix, zoom,
/*force_matrix3d=*/false);
}
+ return nullptr;
}
CSSValue* ComputedStyleUtils::ValueForTransformList(
--- chromium-84.0.4147.89/third_party/blink/renderer/core/css/remote_font_face_source.cc.gcc10 2020-07-13 20:41:27.000000000 +0200
+++ chromium-84.0.4147.89/third_party/blink/renderer/core/css/remote_font_face_source.cc 2020-07-25 01:08:01.742050830 +0200
@@ -72,6 +72,7 @@ RemoteFontFaceSource::ComputeFontDisplay
case kLongLimitExceeded:
return kSwapPeriod;
}
+ return kFailurePeriod;
}
RemoteFontFaceSource::DisplayPeriod RemoteFontFaceSource::ComputePeriod()
--- chromium-84.0.4147.89/third_party/blink/renderer/core/css/resolver/style_cascade.cc.gcc10 2020-07-13 20:41:27.000000000 +0200
+++ chromium-84.0.4147.89/third_party/blink/renderer/core/css/resolver/style_cascade.cc 2020-07-25 01:23:28.099542334 +0200
@@ -116,6 +116,7 @@ CascadeOrigin TargetOriginForRevert(Casc
case CascadeOrigin::kAnimation:
return CascadeOrigin::kUser;
}
+ return CascadeOrigin::kNone;
}
CSSPropertyID UnvisitedID(CSSPropertyID id) {
@@ -146,6 +147,7 @@ bool IsInterpolation(CascadePriority pri
case CascadeOrigin::kAuthor:
return false;
}
+ return false;
}
} // namespace
@@ -885,6 +887,7 @@ const CSSValue* StyleCascade::ResolveRev
origin, resolver);
}
}
+ return nullptr;
}
scoped_refptr<CSSVariableData> StyleCascade::ResolveVariableData(
--- chromium-84.0.4147.89/third_party/blink/renderer/core/feature_policy/document_policy_parser.cc.gcc10 2020-07-13 20:41:27.000000000 +0200
+++ chromium-84.0.4147.89/third_party/blink/renderer/core/feature_policy/document_policy_parser.cc 2020-07-25 02:43:01.669088287 +0200
@@ -30,6 +30,7 @@ const char* ItemTypeToString(net::struct
case net::structured_headers::Item::ItemType::kTokenType:
return "Token";
}
+ return "";
}
const char* PolicyValueTypeToString(mojom::blink::PolicyValueType type) {
@@ -43,6 +44,7 @@ const char* PolicyValueTypeToString(mojo
case mojom::blink::PolicyValueType::kEnum:
return "Enum";
}
+ return "";
}
base::Optional<PolicyValue> ItemToPolicyValue(
--- chromium-84.0.4147.89/third_party/blink/renderer/core/inspector/inspector_media_agent.cc.gcc10 2020-07-13 20:41:28.000000000 +0200
+++ chromium-84.0.4147.89/third_party/blink/renderer/core/inspector/inspector_media_agent.cc 2020-07-25 03:43:44.478397024 +0200
@@ -24,6 +24,7 @@ const char* ConvertMessageLevelEnum(Insp
case InspectorPlayerMessage::Level::kDebug:
return protocol::Media::PlayerMessage::LevelEnum::Debug;
}
+ return protocol::Media::PlayerMessage::LevelEnum::Error;
}
const char* ConvertErrorTypeEnum(InspectorPlayerError::Type level) {
@@ -33,6 +34,7 @@ const char* ConvertErrorTypeEnum(Inspect
case InspectorPlayerError::Type::kMediaStatus:
return protocol::Media::PlayerError::TypeEnum::Media_error;
}
+ return protocol::Media::PlayerError::TypeEnum::Media_error;
}
std::unique_ptr<protocol::Media::PlayerEvent> ConvertToProtocolType(
--- chromium-84.0.4147.89/third_party/blink/renderer/core/inspector/inspector_audits_agent.cc.gcc10 2020-07-13 20:41:28.000000000 +0200
+++ chromium-84.0.4147.89/third_party/blink/renderer/core/inspector/inspector_audits_agent.cc 2020-07-25 14:14:28.796761557 +0200
@@ -193,6 +193,7 @@ blink::protocol::String InspectorIssueCo
return protocol::Audits::InspectorIssueCodeEnum::
ContentSecurityPolicyIssue;
}
+ return blink::protocol::String();
}
protocol::String BuildCookieExclusionReason(
@@ -215,6 +216,7 @@ protocol::String BuildCookieExclusionRea
return protocol::Audits::SameSiteCookieExclusionReasonEnum::
ExcludeSameSiteStrict;
}
+ return blink::protocol::String();
}
std::unique_ptr<std::vector<blink::protocol::String>>
@@ -265,6 +267,7 @@ protocol::String BuildCookieWarningReaso
return protocol::Audits::SameSiteCookieWarningReasonEnum::
WarnSameSiteLaxCrossDowngradeLax;
}
+ return protocol::String();
}
std::unique_ptr<std::vector<blink::protocol::String>> BuildCookieWarningReasons(
@@ -285,6 +288,7 @@ protocol::String BuildCookieOperation(
case blink::mojom::blink::SameSiteCookieOperation::kReadCookie:
return protocol::Audits::SameSiteCookieOperationEnum::ReadCookie;
}
+ return protocol::String();
}
protocol::String BuildMixedContentResolutionStatus(
@@ -303,6 +307,7 @@ protocol::String BuildMixedContentResolu
return protocol::Audits::MixedContentResolutionStatusEnum::
MixedContentWarning;
}
+ return protocol::String();
}
protocol::String BuildMixedContentResourceType(
@@ -377,6 +382,7 @@ protocol::String BuildMixedContentResour
case blink::mojom::blink::RequestContextType::XSLT:
return protocol::Audits::MixedContentResourceTypeEnum::XSLT;
}
+ return blink::protocol::String();
}
protocol::String BuildBlockedByResponseReason(
--- chromium-84.0.4147.89/third_party/blink/renderer/modules/encryptedmedia/encrypted_media_utils.cc.gcc10 2020-07-13 20:40:42.000000000 +0200
+++ chromium-84.0.4147.89/third_party/blink/renderer/modules/encryptedmedia/encrypted_media_utils.cc 2020-07-25 15:58:55.664078677 +0200
@@ -159,6 +159,7 @@ const char* EncryptedMediaUtils::GetInte
case EmeApiType::kRemove:
return "MediaKeySession";
}
+ return "";
}
// static
@@ -181,6 +182,7 @@ const char* EncryptedMediaUtils::GetProp
case EmeApiType::kRemove:
return "remove";
}
+ return "";
}
} // namespace blink
--- chromium-84.0.4147.89/third_party/blink/renderer/modules/xr/xr_reference_space.cc.gcc10 2020-07-13 20:41:28.000000000 +0200
+++ chromium-84.0.4147.89/third_party/blink/renderer/modules/xr/xr_reference_space.cc 2020-07-25 21:11:41.781090271 +0200
@@ -134,6 +134,7 @@ base::Optional<TransformationMatrix> XRR
return base::nullopt;
}
}
+ return base::nullopt;
}
base::Optional<TransformationMatrix> XRReferenceSpace::NativeFromViewer(
@@ -179,6 +180,7 @@ bool XRReferenceSpace::IsStationary() co
case ReferenceSpaceType::kViewer:
return false;
}
+ return false;
}
ReferenceSpaceType XRReferenceSpace::GetType() const {
--- chromium-84.0.4147.89/third_party/blink/renderer/modules/xr/xr_system.cc.gcc10 2020-07-23 21:47:48.291016420 +0200
+++ chromium-84.0.4147.89/third_party/blink/renderer/modules/xr/xr_system.cc 2020-07-25 22:10:40.918901568 +0200
@@ -254,6 +254,7 @@ const char* GetConsoleMessage(device::mo
case device::mojom::RequestSessionError::UNKNOWN_FAILURE:
return "An unknown error occurred";
}
+ return "";
}
bool IsFeatureRequested(
--- chromium-84.0.4147.89/third_party/blink/renderer/platform/image-decoders/avif/avif_image_decoder.cc.gcc10 2020-07-13 20:41:28.000000000 +0200
+++ chromium-84.0.4147.89/third_party/blink/renderer/platform/image-decoders/avif/avif_image_decoder.cc 2020-07-26 00:31:13.826083265 +0200
@@ -167,6 +167,7 @@ media::VideoPixelFormat AvifToVideoPixel
NOTREACHED();
return media::PIXEL_FORMAT_UNKNOWN;
}
+ return media::PIXEL_FORMAT_UNKNOWN;
}
// |y_size| is the width or height of the Y plane. Returns the width or height
--- chromium-84.0.4147.89/third_party/blink/renderer/platform/bindings/parkable_string.cc.gcc10 2020-07-13 20:41:28.000000000 +0200
+++ chromium-84.0.4147.89/third_party/blink/renderer/platform/bindings/parkable_string.cc 2020-07-26 01:22:12.308527010 +0200
@@ -40,6 +40,7 @@ ParkableStringImpl::Age MakeOlder(Parkab
case ParkableStringImpl::Age::kVeryOld:
return ParkableStringImpl::Age::kVeryOld;
}
+ return ParkableStringImpl::Age::kVeryOld;
}
enum class ParkingAction { kParked, kUnparked, kWritten, kRead };
--- chromium-85.0.4183.83/third_party/blink/renderer/platform/heap/impl/unsanitized_atomic.cc.gcc10 2020-08-24 23:40:44.000000000 +0200
+++ chromium-85.0.4183.83/third_party/blink/renderer/platform/heap/impl/unsanitized_atomic.cc 2020-08-31 02:48:54.702199554 +0200
@@ -31,6 +31,7 @@ constexpr int ToGCCMemoryOrder(std::memo
case std::memory_order_consume:
return __ATOMIC_CONSUME;
}
+ return __ATOMIC_SEQ_CST;
}
} // namespace
--- chromium-85.0.4183.83/ui/base/ime/mojom/ime_types_mojom_traits.cc.gcc10 2020-08-24 23:41:27.000000000 +0200
+++ chromium-85.0.4183.83/ui/base/ime/mojom/ime_types_mojom_traits.cc 2020-08-31 04:26:06.905587894 +0200
@@ -24,6 +24,7 @@ EnumTraits<ui::mojom::TextInputAction, u
UI_TO_MOJO_ACTION_CASE(kSearch);
UI_TO_MOJO_ACTION_CASE(kSend);
}
+ return ui::mojom::TextInputAction::kDefault;
}
#undef UI_TO_MOJO_ACTION_CASE
@@ -71,6 +72,7 @@ EnumTraits<ui::mojom::TextInputMode, ui:
UI_TO_MOJO_MODE_CASE(DECIMAL, kDecimal);
UI_TO_MOJO_MODE_CASE(SEARCH, kSearch);
}
+ return ui::mojom::TextInputMode::kNone;
}
#undef UI_TO_MOJO_MODE_CASE
@@ -95,6 +97,7 @@ bool EnumTraits<ui::mojom::TextInputMode
MOJO_TO_UI_MODE_CASE(DECIMAL, kDecimal);
MOJO_TO_UI_MODE_CASE(SEARCH, kSearch);
}
+ return false;
}
#undef MOJO_TO_UI_MODE_CASE
--- chromium-85.0.4183.83/components/previews/core/previews_block_list.cc.gcc10 2020-08-24 23:40:34.000000000 +0200
+++ chromium-85.0.4183.83/components/previews/core/previews_block_list.cc 2020-09-01 04:39:50.324809112 +0200
@@ -37,6 +37,7 @@ PreviewsEligibilityReason BlocklistReaso
case blocklist::BlocklistReason::kAllowed:
return PreviewsEligibilityReason::ALLOWED;
}
+ return PreviewsEligibilityReason::USER_BLOCKLISTED;
}
} // namespace
--- chromium-85.0.4183.83/cc/tiles/image_decode_cache.h.gcc10 2020-08-24 23:40:22.000000000 +0200
+++ chromium-85.0.4183.83/cc/tiles/image_decode_cache.h 2020-09-01 13:27:05.844285831 +0200
@@ -95,6 +95,7 @@ class CC_EXPORT ImageDecodeCache {
case ImageType::kInvalid:
return ScopedImageType::kOther;
}
+ return ScopedImageType::kOther;
}
virtual ~ImageDecodeCache() {}
--- chromium-85.0.4183.83/media/filters/dav1d_video_decoder.cc.gcc10 2020-08-24 23:40:38.000000000 +0200
+++ chromium-85.0.4183.83/media/filters/dav1d_video_decoder.cc 2020-09-01 18:44:22.703439249 +0200
@@ -93,6 +93,7 @@ static VideoPixelFormat Dav1dImgFmtToVid
return PIXEL_FORMAT_UNKNOWN;
}
}
+ return PIXEL_FORMAT_UNKNOWN;
}
static void ReleaseDecoderBuffer(const uint8_t* buffer, void* opaque) {
--- chromium-85.0.4183.83/ui/base/x/x11_window.cc.gcc10 2020-08-30 21:27:10.554514695 +0200
+++ chromium-85.0.4183.83/ui/base/x/x11_window.cc 2020-09-01 19:36:25.001157683 +0200
@@ -127,6 +127,7 @@ x11::NotifyDetail XI2DetailToXDetail(x11
case x11::Input::NotifyDetail::None:
return x11::NotifyDetail::None;
}
+ return x11::NotifyDetail::None;
}
void SyncSetCounter(x11::Connection* connection,
--- chromium-85.0.4183.83/services/network/public/cpp/trust_token_operation_authorization.h.gcc10 2020-08-24 23:40:41.000000000 +0200
+++ chromium-85.0.4183.83/services/network/public/cpp/trust_token_operation_authorization.h 2020-09-01 23:56:33.902828375 +0200
@@ -34,6 +34,7 @@ constexpr bool DoesTrustTokenOperationRe
case mojom::TrustTokenOperationType::kIssuance:
return false;
}
+ return false;
}
} // namespace network
--- chromium-85.0.4183.83/device/fido/cable/cable_discovery_data.cc.gcc10 2020-08-24 23:40:37.000000000 +0200
+++ chromium-85.0.4183.83/device/fido/cable/cable_discovery_data.cc 2020-09-02 02:07:13.535122897 +0200
@@ -58,6 +58,7 @@ bool CableDiscoveryData::operator==(cons
CHECK(false);
return false;
}
+ return false;
}
bool CableDiscoveryData::MatchV1(const CableEidArray& eid) const {
--- chromium-85.0.4183.83/components/browsing_data/core/counters/passwords_counter.cc.gcc10 2020-08-24 23:40:32.000000000 +0200
+++ chromium-85.0.4183.83/components/browsing_data/core/counters/passwords_counter.cc 2020-09-02 11:01:29.679068545 +0200
@@ -31,6 +31,7 @@ bool IsPasswordSyncEnabled(const syncer:
case password_manager::SYNCING_WITH_CUSTOM_PASSPHRASE:
return true;
}
+ return false;
}
// PasswordStoreFetcher ----------------------------------
--- chromium-85.0.4183.83/chrome/browser/extensions/api/identity/identity_get_auth_token_error.cc.gcc10 2020-08-24 23:40:27.000000000 +0200
+++ chromium-85.0.4183.83/chrome/browser/extensions/api/identity/identity_get_auth_token_error.cc 2020-09-02 12:04:04.222174528 +0200
@@ -103,6 +103,7 @@ std::string IdentityGetAuthTokenError::T
case State::kCanceled:
return identity_constants::kCanceled;
}
+ return std::string();
}
IdentityGetAuthTokenError::IdentityGetAuthTokenError(State state,
--- chromium-85.0.4183.83/components/media_router/browser/logger_impl.cc.gcc10 2020-08-24 23:40:27.000000000 +0200
+++ chromium-85.0.4183.83/components/media_router/browser/logger_impl.cc 2020-09-02 12:43:31.129376521 +0200
@@ -30,6 +30,7 @@ const char* AsString(LoggerImpl::Severit
case LoggerImpl::Severity::kError:
return "Error";
}
+ return "";
}
const char* AsString(mojom::LogCategory category) {
@@ -43,6 +44,7 @@ const char* AsString(mojom::LogCategory
case mojom::LogCategory::kUi:
return "UI";
}
+ return "";
}
base::StringPiece TruncateComponent(base::StringPiece component) {
--- chromium-85.0.4183.83/chrome/browser/vr/vr_tab_helper.cc.gcc10 2020-08-24 23:40:29.000000000 +0200
+++ chromium-85.0.4183.83/chrome/browser/vr/vr_tab_helper.cc 2020-09-02 17:24:13.929910405 +0200
@@ -135,6 +135,7 @@ bool VrTabHelper::IsUiSuppressedInVr(con
NOTREACHED();
return false;
}
+ return false;
}
WEB_CONTENTS_USER_DATA_KEY_IMPL(VrTabHelper)
--- chromium-85.0.4183.83/chrome/browser/enterprise/connectors/common.cc.gcc10 2020-08-30 21:27:13.295463211 +0200
+++ chromium-85.0.4183.83/chrome/browser/enterprise/connectors/common.cc 2020-09-02 19:06:25.714865375 +0200
@@ -40,6 +40,7 @@ const char* ConnectorPref(ReportingConne
case ReportingConnector::SECURITY_EVENT:
return kOnSecurityEventPref;
}
+ return "";
}
TriggeredRule::Action GetHighestPrecedenceAction(
--- chromium-85.0.4183.83/chrome/browser/installable/installable_metrics.cc.gcc10 2020-08-24 23:40:27.000000000 +0200
+++ chromium-85.0.4183.83/chrome/browser/installable/installable_metrics.cc 2020-09-02 22:29:37.383216250 +0200
@@ -92,6 +92,7 @@ ServiceWorkerOfflineCapability
return ServiceWorkerOfflineCapability::kNoServiceWorker;
}
NOTREACHED();
+ return ServiceWorkerOfflineCapability::kNoServiceWorker;
}
// static
@@ -104,4 +105,5 @@ ServiceWorkerOfflineCapability Installab
return ServiceWorkerOfflineCapability::kServiceWorkerNoOfflineSupport;
}
NOTREACHED();
+ return ServiceWorkerOfflineCapability::kNoServiceWorker;
}
--- chromium-85.0.4183.83/chrome/browser/page_load_metrics/observers/ad_metrics/ads_page_load_metrics_observer.cc.gcc10 2020-08-30 21:27:11.361499537 +0200
+++ chromium-85.0.4183.83/chrome/browser/page_load_metrics/observers/ad_metrics/ads_page_load_metrics_observer.cc 2020-09-03 00:38:18.946290730 +0200
@@ -155,6 +155,7 @@ blink::mojom::HeavyAdReason GetHeavyAdRe
NOTREACHED();
return blink::mojom::HeavyAdReason::kNetworkTotalLimit;
}
+ return blink::mojom::HeavyAdReason::kNetworkTotalLimit;
}
} // namespace
--- chromium-85.0.4183.83/chrome/browser/performance_hints/performance_hints_observer.cc.gcc10 2020-08-24 23:40:27.000000000 +0200
+++ chromium-85.0.4183.83/chrome/browser/performance_hints/performance_hints_observer.cc 2020-09-03 02:52:55.568425478 +0200
@@ -77,6 +77,7 @@ const char* ToString(HintLookupSource so
case HintLookupSource::kFastHostHint:
return "FastHostHint";
}
+ return "";
}
} // namespace
@@ -353,6 +354,7 @@ PerformanceHintsObserver::FastHostHintFo
case OptimizationGuideDecision::kUnknown:
return {SourceLookupStatus::kNotReady, base::nullopt};
}
+ return {SourceLookupStatus::kNotReady, base::nullopt};
}
void PerformanceHintsObserver::DidFinishNavigation(
--- chromium-85.0.4183.83/chrome/browser/ui/views/autofill/payments/payments_view_util.cc.gcc10 2020-08-24 23:40:29.000000000 +0200
+++ chromium-85.0.4183.83/chrome/browser/ui/views/autofill/payments/payments_view_util.cc 2020-09-03 03:33:06.813889494 +0200
@@ -190,6 +190,7 @@ PaymentsBubbleClosedReason GetPaymentsBu
case views::Widget::ClosedReason::kCancelButtonClicked:
return PaymentsBubbleClosedReason::kCancelled;
}
+ return PaymentsBubbleClosedReason::kNotInteracted;
}
} // namespace autofill
--- chromium-85.0.4183.83/chrome/browser/policy/cloud/remote_commands_invalidator_impl.cc.gcc10 2020-08-30 21:27:13.071467418 +0200
+++ chromium-85.0.4183.83/chrome/browser/policy/cloud/remote_commands_invalidator_impl.cc 2020-09-03 11:00:37.414067356 +0200
@@ -30,6 +30,7 @@ const char* GetInvalidationMetricName(Po
"device local account scope.";
return "";
}
+ return "";
}
std::string ComposeOwnerName(PolicyInvalidationScope scope) {
--- chromium-85.0.4183.83/chrome/browser/policy/cloud/cloud_policy_invalidator.cc.gcc10 2020-08-30 21:27:13.072467400 +0200
+++ chromium-85.0.4183.83/chrome/browser/policy/cloud/cloud_policy_invalidator.cc 2020-09-03 13:28:16.359285951 +0200
@@ -102,6 +102,7 @@ std::string ComposeOwnerName(PolicyInval
case PolicyInvalidationScope::kCBCM:
return "CloudPolicy.CBCM";
}
+ return "";
}
} // namespace
--- chromium-85.0.4183.83/chrome/browser/signin/signin_ui_util.cc.gcc10 2020-08-24 23:40:28.000000000 +0200
+++ chromium-85.0.4183.83/chrome/browser/signin/signin_ui_util.cc 2020-09-03 16:05:43.801568728 +0200
@@ -157,6 +157,7 @@ std::string GetReauthAccessPointHistogra
case signin_metrics::ReauthAccessPoint::kPasswordMoveBubble:
return "ToMovePassword";
}
+ return "";
}
} // namespace
--- chromium-85.0.4183.83/components/performance_manager/graph/page_node.cc.gcc10 2020-09-03 21:47:45.303509771 +0200
+++ chromium-85.0.4183.83/components/performance_manager/graph/page_node.cc 2020-09-03 22:20:44.990408232 +0200
@@ -21,6 +21,7 @@ const char* PageNode::ToString(PageNode:
return "kPortal";
}
NOTREACHED();
+ return "";
}
PageNode::PageNode() = default;
--- chromium-85.0.4183.83/components/safe_browsing/core/realtime/url_lookup_service_base.cc.gcc10 2020-08-24 23:40:34.000000000 +0200
+++ chromium-85.0.4183.83/components/safe_browsing/core/realtime/url_lookup_service_base.cc 2020-09-03 23:07:11.984144374 +0200
@@ -78,6 +78,7 @@ SBThreatType RealTimeUrlLookupServiceBas
NOTREACHED() << "Unexpected RTLookupResponse::ThreatType encountered";
return SB_THREAT_TYPE_SAFE;
}
+ return SB_THREAT_TYPE_SAFE;
}
// static
--- chromium-85.0.4183.83/components/sync/engine_impl/commit_processor.cc.gcc10 2020-08-24 23:40:34.000000000 +0200
+++ chromium-85.0.4183.83/components/sync/engine_impl/commit_processor.cc 2020-09-03 23:37:40.566816526 +0200
@@ -87,6 +87,7 @@ CommitProcessor::GatheringPhase CommitPr
NOTREACHED();
return GatheringPhase::kDone;
}
+ return GatheringPhase::kDone;
}
ModelTypeSet CommitProcessor::GetUserTypesForCurrentCommitPhase() const {
@@ -100,6 +101,7 @@ ModelTypeSet CommitProcessor::GetUserTyp
NOTREACHED();
return ModelTypeSet();
}
+ return ModelTypeSet();
}
size_t CommitProcessor::GatherCommitContributionsForType(
--- chromium-85.0.4183.83/content/browser/devtools/devtools_instrumentation.cc.gcc10 2020-08-24 23:40:35.000000000 +0200
+++ chromium-85.0.4183.83/content/browser/devtools/devtools_instrumentation.cc 2020-09-04 01:59:46.967726994 +0200
@@ -168,6 +168,7 @@ protocol::String BuildBlockedByResponseR
case network::mojom::BlockedByResponseReason::kCorpNotSameSite:
return protocol::Audits::BlockedByResponseReasonEnum::CorpNotSameSite;
}
+ return protocol::String();
}
} // namespace
@@ -813,6 +814,7 @@ protocol::String BuildCookieOperation(
case blink::mojom::SameSiteCookieOperation::kSetCookie:
return protocol::Audits::SameSiteCookieOperationEnum::SetCookie;
}
+ return protocol::String();
}
} // namespace
--- chromium-85.0.4183.83/content/browser/devtools/protocol/network_handler.cc.gcc10 2020-08-24 23:40:35.000000000 +0200
+++ chromium-85.0.4183.83/content/browser/devtools/protocol/network_handler.cc 2020-09-04 02:18:32.833477160 +0200
@@ -1504,6 +1504,7 @@ String BuildServiceWorkerResponseSource(
case network::mojom::FetchResponseSource::kUnspecified:
return protocol::Network::ServiceWorkerResponseSourceEnum::FallbackCode;
}
+ return String();
}
std::unique_ptr<Network::Response> BuildResponse(
@@ -1656,6 +1657,7 @@ String GetTrustTokenOperationType(
case network::mojom::TrustTokenOperationType::kSigning:
return protocol::Network::TrustTokenOperationTypeEnum::Signing;
}
+ return protocol::Network::TrustTokenOperationTypeEnum::Issuance;
}
String GetTrustTokenRefreshPolicy(
@@ -1666,6 +1668,7 @@ String GetTrustTokenRefreshPolicy(
case network::mojom::TrustTokenRefreshPolicy::kRefresh:
return protocol::Network::TrustTokenParams::RefreshPolicyEnum::Refresh;
}
+ return protocol::Network::TrustTokenParams::RefreshPolicyEnum::Refresh;
}
std::unique_ptr<protocol::Network::TrustTokenParams> BuildTrustTokenParams(
@@ -1900,6 +1903,7 @@ String BuildCorsError(network::mojom::Co
case network::mojom::CorsError::kInsecurePrivateNetwork:
return protocol::Network::CorsErrorEnum::InsecurePrivateNetwork;
}
+ return String();
}
std::unique_ptr<protocol::Network::CorsErrorStatus> BuildCorsErrorStatus(
@@ -2365,6 +2369,7 @@ makeCrossOriginOpenerPolicyValue(
return protocol::Network::CrossOriginOpenerPolicyValueEnum::
SameOriginPlusCoep;
}
+ return "";
}
protocol::Network::CrossOriginEmbedderPolicyValue
makeCrossOriginEmbedderPolicyValue(
@@ -2375,6 +2380,7 @@ makeCrossOriginEmbedderPolicyValue(
case network::mojom::CrossOriginEmbedderPolicyValue::kRequireCorp:
return protocol::Network::CrossOriginEmbedderPolicyValueEnum::RequireCorp;
}
+ return "";
}
std::unique_ptr<protocol::Network::CrossOriginOpenerPolicyStatus>
makeCrossOriginOpenerPolicyStatus(
--- chromium-85.0.4183.83/content/browser/renderer_host/ancestor_throttle.cc.gcc10 2020-08-24 23:40:35.000000000 +0200
+++ chromium-85.0.4183.83/content/browser/renderer_host/ancestor_throttle.cc 2020-09-04 03:34:20.546938902 +0200
@@ -344,6 +344,7 @@ AncestorThrottle::CheckResult AncestorTh
RecordXFrameOptionsUsage(XFrameOptionsHistogram::ALLOWALL);
return CheckResult::PROCEED;
}
+ return CheckResult::PROCEED;
}
AncestorThrottle::CheckResult AncestorThrottle::EvaluateFrameAncestors(
--- chromium-85.0.4183.83/content/public/browser/url_data_source.cc.gcc10 2020-08-24 23:40:35.000000000 +0200
+++ chromium-85.0.4183.83/content/public/browser/url_data_source.cc 2020-09-04 04:58:24.382061254 +0200
@@ -102,6 +102,7 @@ std::string URLDataSource::GetContentSec
case network::mojom::CSPDirectiveName::Unknown:
return std::string();
}
+ return std::string();
}
bool URLDataSource::ShouldDenyXFrameOptions() {
--- chromium-85.0.4183.83/content/browser/net/cross_origin_opener_policy_reporter.cc.gcc10 2020-08-24 23:40:35.000000000 +0200
+++ chromium-85.0.4183.83/content/browser/net/cross_origin_opener_policy_reporter.cc 2020-09-04 05:17:51.897978907 +0200
@@ -53,6 +53,7 @@ std::string ToString(network::mojom::Cro
case network::mojom::CrossOriginOpenerPolicyValue::kSameOriginPlusCoep:
return "same-origin-plus-coep";
}
+ return std::string();
}
base::Optional<base::UnguessableToken> GetFrameToken(
--- chromium-85.0.4183.83/extensions/browser/api/web_request/web_request_api_helpers.cc.gcc10 2020-08-24 23:40:37.000000000 +0200
+++ chromium-85.0.4183.83/extensions/browser/api/web_request/web_request_api_helpers.cc 2020-09-04 11:04:52.027713361 +0200
@@ -357,6 +357,7 @@ struct DNRHeaderAction {
NOTREACHED();
return true;
}
+ return true;
}
// Non-owning pointers to HeaderInfo and ExtensionId.
--- chromium-85.0.4183.83/components/printing/renderer/print_render_frame_helper.cc.gcc10 2020-08-24 23:40:34.000000000 +0200
+++ chromium-85.0.4183.83/components/printing/renderer/print_render_frame_helper.cc 2020-09-04 13:01:55.208932038 +0200
@@ -155,6 +155,7 @@ mojom::PageOrientation FromBlinkPageOrie
case blink::PageOrientation::kRotateRight:
return printing::mojom::PageOrientation::kRotateRight;
}
+ return printing::mojom::PageOrientation::kUpright;
}
mojom::PrintParamsPtr GetCssPrintParams(blink::WebLocalFrame* frame,
--- chromium-85.0.4183.83/third_party/blink/renderer/core/editing/ime/input_method_controller.cc.gcc10 2020-08-30 21:27:12.552477167 +0200
+++ chromium-85.0.4183.83/third_party/blink/renderer/core/editing/ime/input_method_controller.cc 2020-09-04 13:34:49.699893002 +0200
@@ -300,6 +300,7 @@ SuggestionMarker::SuggestionType Convert
case ImeTextSpan::Type::kSuggestion:
return SuggestionMarker::SuggestionType::kNotMisspelling;
}
+ return SuggestionMarker::SuggestionType::kNotMisspelling;
}
ImeTextSpan::Type ConvertSuggestionMarkerType(
@@ -312,6 +313,7 @@ ImeTextSpan::Type ConvertSuggestionMarke
case SuggestionMarker::SuggestionType::kNotMisspelling:
return ImeTextSpan::Type::kSuggestion;
}
+ return ImeTextSpan::Type::kSuggestion;
}
// ImeTextSpans types that need to be provided to TextInputInfo can be added
--- chromium-85.0.4183.83/third_party/blink/renderer/core/css/parser/at_rule_descriptor_parser.cc.gcc10 2020-08-24 23:40:43.000000000 +0200
+++ chromium-85.0.4183.83/third_party/blink/renderer/core/css/parser/at_rule_descriptor_parser.cc 2020-09-04 16:51:56.967221809 +0200
@@ -189,6 +189,7 @@ CSSValue* ConsumeDescriptor(StyleRule::R
NOTREACHED();
return nullptr;
}
+ return nullptr;
}
CSSValue* ConsumeFontMetricOverride(CSSParserTokenRange& range,
--- chromium-85.0.4183.83/third_party/blink/renderer/core/frame/local_frame.cc.gcc10 2020-08-30 21:27:10.582514169 +0200
+++ chromium-85.0.4183.83/third_party/blink/renderer/core/frame/local_frame.cc 2020-09-04 21:38:57.092593802 +0200
@@ -716,6 +716,7 @@ bool LocalFrame::CanAccessEvent(
case WebInputEventAttribution::kUnknown:
return false;
}
+ return false;
}
bool LocalFrame::IsTransientAllowFullscreenActive() const {
--- chromium-85.0.4183.83/third_party/blink/renderer/core/html/parser/html_parser_idioms.cc.gcc10 2020-08-24 23:40:43.000000000 +0200
+++ chromium-85.0.4183.83/third_party/blink/renderer/core/html/parser/html_parser_idioms.cc 2020-09-04 22:29:09.756310139 +0200
@@ -150,6 +150,7 @@ template <typename CharacterType>
static bool ParseHTMLIntegerInternal(const CharacterType* position,
const CharacterType* end,
int& value) {
+ return false;
}
// http://www.whatwg.org/specs/web-apps/current-work/#rules-for-parsing-integers
--- chromium-85.0.4183.83/third_party/blink/renderer/core/html/parser/html_document_parser.cc.gcc10 2020-08-24 23:40:43.000000000 +0200
+++ chromium-85.0.4183.83/third_party/blink/renderer/core/html/parser/html_document_parser.cc 2020-09-04 23:00:28.348895332 +0200
@@ -151,6 +151,7 @@ class HTMLDocumentParserState
case DeferredParserState::kScheduledWithEndIfDelayed:
return "scheduled_with_end_if_delayed";
}
+ return "";
}
bool ShouldEndIfDelayed() const { return end_if_delayed_forbidden_ == 0; }
--- chromium-85.0.4183.83/third_party/blink/renderer/core/inspector/inspector_audits_agent.cc.gcc10 2020-08-30 21:27:13.307462986 +0200
+++ chromium-85.0.4183.83/third_party/blink/renderer/core/inspector/inspector_audits_agent.cc 2020-09-05 00:24:04.162453219 +0200
@@ -405,6 +405,7 @@ protocol::String BuildBlockedByResponseR
case network::mojom::blink::BlockedByResponseReason::kCorpNotSameSite:
return protocol::Audits::BlockedByResponseReasonEnum::CorpNotSameSite;
}
+ return protocol::String();
}
protocol::String BuildViolationType(
--- chromium-85.0.4183.83/third_party/blink/renderer/core/inspector/inspector_network_agent.cc.gcc10 2020-08-24 23:40:43.000000000 +0200
+++ chromium-85.0.4183.83/third_party/blink/renderer/core/inspector/inspector_network_agent.cc 2020-09-05 01:13:41.592927801 +0200
@@ -479,6 +479,7 @@ String BuildCorsError(network::mojom::Co
case network::mojom::CorsError::kInsecurePrivateNetwork:
return protocol::Network::CorsErrorEnum::InsecurePrivateNetwork;
}
+ return String();
}
std::unique_ptr<protocol::Network::CorsErrorStatus> BuildCorsErrorStatus(
@@ -500,6 +501,7 @@ String BuildServiceWorkerResponseSource(
case network::mojom::FetchResponseSource::kUnspecified:
return protocol::Network::ServiceWorkerResponseSourceEnum::FallbackCode;
}
+ return String();
}
WebConnectionType ToWebConnectionType(const String& connection_type) {
@@ -586,6 +588,7 @@ String GetTrustTokenOperationType(
case network::mojom::TrustTokenOperationType::kSigning:
return protocol::Network::TrustTokenOperationTypeEnum::Signing;
}
+ return String();
}
String GetTrustTokenRefreshPolicy(
@@ -596,6 +599,7 @@ String GetTrustTokenRefreshPolicy(
case network::mojom::TrustTokenRefreshPolicy::kRefresh:
return protocol::Network::TrustTokenParams::RefreshPolicyEnum::Refresh;
}
+ return String();
}
std::unique_ptr<protocol::Network::TrustTokenParams> BuildTrustTokenParams(
--- chromium-85.0.4183.83/third_party/blink/renderer/core/timing/measure_memory/measure_memory_delegate.cc.gcc10 2020-08-24 23:40:44.000000000 +0200
+++ chromium-85.0.4183.83/third_party/blink/renderer/core/timing/measure_memory/measure_memory_delegate.cc 2020-09-05 04:24:46.382762171 +0200
@@ -146,6 +146,7 @@ String GetUrl(const WebFrame* main_frame
NOTREACHED();
return {};
}
+ return {};
}
// To avoid information leaks cross-origin iframes are considered opaque for
--- chromium-85.0.4183.83/third_party/blink/renderer/modules/payments/goods/digital_goods_type_converters.cc.gcc10 2020-08-24 23:40:44.000000000 +0200
+++ chromium-85.0.4183.83/third_party/blink/renderer/modules/payments/goods/digital_goods_type_converters.cc 2020-09-05 08:00:56.577275269 +0200
@@ -27,6 +27,7 @@ WTF::String TypeConverter<WTF::String, C
return "unsupportedContext";
}
NOTREACHED();
+ return WTF::String();
}
blink::ItemDetails* TypeConverter<blink::ItemDetails*, ItemDetailsPtr>::Convert(
@@ -75,6 +75,7 @@ WTF::String TypeConverter<WTF::String, B
return "clientAppError";
}
NOTREACHED();
+ return "";
}
blink::PurchaseDetails*
--- chromium-85.0.4183.83/third_party/blink/renderer/platform/graphics/canvas_color_params.cc.gcc10 2020-08-24 23:40:44.000000000 +0200
+++ chromium-85.0.4183.83/third_party/blink/renderer/platform/graphics/canvas_color_params.cc 2020-09-05 14:52:06.610955302 +0200
@@ -33,6 +33,7 @@ gfx::ColorSpace CanvasColorSpaceToGfxCol
break;
}
NOTREACHED();
+ return gfx::ColorSpace();
}
} // namespace
--- chromium-85.0.4183.83/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc.gcc10 2020-08-30 21:27:08.978544296 +0200
+++ chromium-85.0.4183.83/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc 2020-09-05 16:01:34.705611339 +0200
@@ -603,6 +603,7 @@ WakeUpBudgetPool* PageSchedulerImpl::Get
NOTREACHED();
return nullptr;
}
+ return nullptr;
}
CPUTimeBudgetPool* PageSchedulerImpl::background_cpu_time_budget_pool() {
--- chromium-85.0.4183.83/third_party/blink/renderer/platform/loader/fetch/bytes_consumer.cc.gcc10 2020-08-24 23:40:44.000000000 +0200
+++ chromium-85.0.4183.83/third_party/blink/renderer/platform/loader/fetch/bytes_consumer.cc 2020-09-05 17:27:04.793093470 +0200
@@ -77,6 +77,7 @@ std::ostream& operator<<(std::ostream& o
return out << "kErrored";
}
NOTREACHED();
+ return out;
}
std::ostream& operator<<(std::ostream& out,
@@ -92,6 +93,7 @@ std::ostream& operator<<(std::ostream& o
return out << "kError";
}
NOTREACHED();
+ return out;
}
} // namespace blink
--- chromium-87.0.4280.40/third_party/pdfium/xfa/fgas/crt/cfgas_stringformatter.cpp.gcc10 2020-10-29 23:31:59.000000000 +0100
+++ chromium-87.0.4280.40/third_party/pdfium/xfa/fgas/crt/cfgas_stringformatter.cpp 2020-10-31 13:22:13.198188801 +0100
@@ -733,6 +733,7 @@ CFGAS_StringFormatter::DateTimeType AddD
NOTREACHED();
return type;
}
+ return type;
}
CFGAS_StringFormatter::DateTimeType AddTimeToTimelessType(
@@ -748,6 +749,7 @@ CFGAS_StringFormatter::DateTimeType AddT
NOTREACHED();
return type;
}
+ return type;
}
} // namespace
--- chromium-87.0.4280.40/components/services/app_service/public/cpp/share_target.cc.gcc10 2020-10-29 23:25:35.000000000 +0100
+++ chromium-87.0.4280.40/components/services/app_service/public/cpp/share_target.cc 2020-10-31 20:51:51.258483916 +0100
@@ -58,6 +58,7 @@ const char* ShareTarget::MethodToString(
case Method::kPost:
return "POST";
}
+ return "";
}
// static
@@ -68,6 +69,7 @@ const char* ShareTarget::EnctypeToString
case Enctype::kMultipartFormData:
return "multipart/form-data";
}
+ return "";
}
std::ostream& operator<<(std::ostream& out, const ShareTarget& share_target) {
--- chromium-87.0.4280.40/services/network/public/cpp/cross_origin_opener_policy.cc.gcc10 2020-10-29 23:25:42.000000000 +0100
+++ chromium-87.0.4280.40/services/network/public/cpp/cross_origin_opener_policy.cc 2020-10-31 23:46:43.166508861 +0100
@@ -36,6 +36,7 @@ bool IsAccessFromCoopPage(mojom::CoopAcc
case mojom::CoopAccessReportType::kAccessToCoopPageFromOther:
return false;
}
+ return false;
}
const char* CoopAccessReportTypeToString(mojom::CoopAccessReportType type) {
@@ -53,6 +54,7 @@ const char* CoopAccessReportTypeToString
case network::mojom::CoopAccessReportType::kAccessToCoopPageFromOther:
return "access-to-coop-page-from-other";
}
+ return "";
}
} // namespace network
--- chromium-87.0.4280.40/services/resource_coordinator/memory_instrumentation/global_dump_graph_converter.cc.gcc10 2020-10-29 23:25:42.000000000 +0100
+++ chromium-87.0.4280.40/services/resource_coordinator/memory_instrumentation/global_dump_graph_converter.cc 2020-10-31 23:54:18.950050569 +0100
@@ -153,6 +153,7 @@ GlobalDumpGraphConverter::ConvertScalarU
}
NOTREACHED();
+ return ChromeScalarUnits::kObjects;
}
} // namespace memory_instrumentation
--- chromium-87.0.4280.40/chrome/services/sharing/public/cpp/conversions.cc.gcc10 2020-10-29 23:25:31.000000000 +0100
+++ chromium-87.0.4280.40/chrome/services/sharing/public/cpp/conversions.cc 2020-11-01 00:08:29.230292408 +0100
@@ -20,6 +20,7 @@ nearby::FileMetadata_Type ConvertFileMet
case mojom::FileMetadata::Type::kUnknown:
return nearby::FileMetadata_Type_UNKNOWN;
}
+ return nearby::FileMetadata_Type_UNKNOWN;
}
nearby::TextMetadata_Type ConvertTextMetadataType(
@@ -36,6 +37,7 @@ nearby::TextMetadata_Type ConvertTextMet
case mojom::TextMetadata::Type::kUnknown:
return nearby::TextMetadata_Type_UNKNOWN;
}
+ return nearby::TextMetadata_Type_UNKNOWN;
}
nearby::WifiCredentialsMetadata_SecurityType ConvertWifiCredentialsMetadataType(
@@ -50,6 +52,7 @@ nearby::WifiCredentialsMetadata_Security
case mojom::WifiCredentialsMetadata::SecurityType::kUnknownSecurityType:
return nearby::WifiCredentialsMetadata_SecurityType_UNKNOWN_SECURITY_TYPE;
}
+ return nearby::WifiCredentialsMetadata_SecurityType_UNKNOWN_SECURITY_TYPE;
}
} // namespace sharing
--- chromium-87.0.4280.40/services/network/trust_tokens/trust_token_request_helper_factory.cc.gcc10 2020-10-29 23:25:42.000000000 +0100
+++ chromium-87.0.4280.40/services/network/trust_tokens/trust_token_request_helper_factory.cc 2020-11-01 00:16:43.185165703 +0100
@@ -56,6 +56,7 @@ base::StringPiece OutcomeToString(Outcom
case Outcome::kRejectedByAuthorizer:
return "Rejected by authorizer (check cookie settings?)";
}
+ return "";
}
void LogOutcome(const net::NetLogWithSource& log,
--- chromium-87.0.4280.40/services/network/trust_tokens/types.cc.gcc10 2020-10-29 23:25:42.000000000 +0100
+++ chromium-87.0.4280.40/services/network/trust_tokens/types.cc 2020-11-01 00:36:27.722518759 +0100
@@ -31,6 +31,7 @@ base::StringPiece TrustTokenOperationTyp
case mojom::TrustTokenOperationType::kSigning:
return "Signing";
}
+ return "";
}
std::string ProtocolVersionToString(
@@ -42,6 +42,7 @@ std::string ProtocolVersionToString(
case mojom::TrustTokenProtocolVersion::kTrustTokenV2Voprf:
return "TrustTokenV2VOPRF";
}
+ return std::string();
}
} // namespace internal
--- chromium-87.0.4280.40/components/offline_pages/core/background/request_coordinator.cc.gcc10 2020-10-29 23:25:34.000000000 +0100
+++ chromium-87.0.4280.40/components/offline_pages/core/background/request_coordinator.cc 2020-11-01 00:57:38.527358487 +0100
@@ -252,6 +252,7 @@ base::Optional<RequestNotifier::Backgrou
DCHECK(false) << "Received invalid status: " << static_cast<int>(status);
return base::nullopt;
}
+ return base::nullopt;
}
} // namespace
@@ -1104,6 +1105,7 @@ bool RequestCoordinator::ShouldTryNextRe
NOTREACHED();
return false;
}
+ return false;
}
void RequestCoordinator::EnableForOffliner(int64_t request_id,
--- chromium-87.0.4280.40/services/network/sct_auditing_cache.cc.gcc10 2020-10-29 23:25:42.000000000 +0100
+++ chromium-87.0.4280.40/services/network/sct_auditing_cache.cc 2020-11-01 01:10:07.221834653 +0100
@@ -61,6 +61,8 @@ MapSCTVerifyStatusToProtoStatus(net::ct:
return sct_auditing::SCTWithSourceAndVerifyStatus::SctVerifyStatus::
SCTWithSourceAndVerifyStatus_SctVerifyStatus_INVALID_TIMESTAMP;
}
+ return sct_auditing::SCTWithSourceAndVerifyStatus::SctVerifyStatus::
+ SCTWithSourceAndVerifyStatus_SctVerifyStatus_NONE;
}
sct_auditing::SCTWithSourceAndVerifyStatus::Source MapSCTOriginToSource(
--- chromium-87.0.4280.40/ui/ozone/platform/wayland/host/xdg_popup_wrapper_impl.cc.gcc10 2020-10-29 23:26:28.000000000 +0100
+++ chromium-87.0.4280.40/ui/ozone/platform/wayland/host/xdg_popup_wrapper_impl.cc 2020-11-01 01:23:15.967672787 +0100
@@ -48,6 +48,7 @@ uint32_t TranslateAnchorStable(WlAnchor
case WlAnchor::BottomRight:
return XDG_POSITIONER_ANCHOR_BOTTOM_RIGHT;
}
+ return XDG_POSITIONER_ANCHOR_NONE;
}
uint32_t TranslateGravityStable(WlGravity gravity) {
@@ -71,6 +72,7 @@ uint32_t TranslateGravityStable(WlGravit
case WlGravity::BottomRight:
return XDG_POSITIONER_GRAVITY_BOTTOM_RIGHT;
}
+ return XDG_POSITIONER_GRAVITY_NONE;
}
uint32_t TranslateContraintAdjustmentStable(
@@ -118,6 +120,7 @@ uint32_t TranslateAnchorV6(WlAnchor anch
case WlAnchor::BottomRight:
return ZXDG_POSITIONER_V6_ANCHOR_BOTTOM | ZXDG_POSITIONER_V6_ANCHOR_RIGHT;
}
+ return ZXDG_POSITIONER_V6_ANCHOR_NONE;
}
uint32_t TranslateGravityV6(WlGravity gravity) {
@@ -143,6 +146,7 @@ uint32_t TranslateGravityV6(WlGravity gr
return ZXDG_POSITIONER_V6_GRAVITY_BOTTOM |
ZXDG_POSITIONER_V6_GRAVITY_RIGHT;
}
+ return ZXDG_POSITIONER_V6_GRAVITY_NONE;
}
uint32_t TranslateContraintAdjustmentV6(
--- chromium-87.0.4280.40/services/device/public/cpp/bluetooth/bluetooth_utils.cc.gcc10 2020-10-29 23:25:41.000000000 +0100
+++ chromium-87.0.4280.40/services/device/public/cpp/bluetooth/bluetooth_utils.cc 2020-11-01 02:54:45.834737748 +0100
@@ -83,6 +83,7 @@ base::string16 GetBluetoothDeviceNameFor
address_utf16);
}
NOTREACHED();
+ return base::string16();
}
namespace {
@@ -119,6 +120,7 @@ int GetBluetoothDeviceTypeAccessibilityL
return IDS_BLUETOOTH_ACCESSIBILITY_DEVICE_TYPE_UNKNOWN;
}
NOTREACHED();
+ return 0;
}
} // namespace
--- chromium-87.0.4280.40/device/fido/cable/fido_cable_discovery.cc.gcc10 2020-10-29 23:25:37.000000000 +0100
+++ chromium-87.0.4280.40/device/fido/cable/fido_cable_discovery.cc 2020-11-01 02:59:45.328618596 +0100
@@ -192,6 +192,7 @@ FidoCableDiscovery::CreateV1HandshakeHan
CHECK(false);
return nullptr;
}
+ return nullptr;
}
// static
--- chromium-87.0.4280.40/cc/input/threaded_input_handler.cc.gcc10 2020-10-29 23:25:25.000000000 +0100
+++ chromium-87.0.4280.40/cc/input/threaded_input_handler.cc 2020-11-01 03:01:23.265918125 +0100
@@ -1137,6 +1137,7 @@ FrameSequenceTrackerType ThreadedInputHa
case ui::ScrollInputType::kAutoscroll:
return FrameSequenceTrackerType::kMaxType;
}
+ return FrameSequenceTrackerType::kMaxType;
}
bool ThreadedInputHandler::IsMainThreadScrolling(
--- chromium-87.0.4280.40/components/viz/service/display_embedder/skia_output_device_buffer_queue.cc.gcc10 2020-10-29 23:25:35.000000000 +0100
+++ chromium-87.0.4280.40/components/viz/service/display_embedder/skia_output_device_buffer_queue.cc 2020-11-01 03:13:48.258161696 +0100
@@ -419,6 +419,7 @@ gfx::Size SkiaOutputDeviceBufferQueue::G
case gfx::OVERLAY_TRANSFORM_ROTATE_180:
return image_size_;
}
+ return image_size_;
}
bool SkiaOutputDeviceBufferQueue::Reshape(const gfx::Size& size,
--- chromium-87.0.4280.40/components/viz/service/display_embedder/skia_output_surface_impl.cc.gcc10 2020-10-29 23:25:35.000000000 +0100
+++ chromium-87.0.4280.40/components/viz/service/display_embedder/skia_output_surface_impl.cc 2020-11-01 03:16:22.573545006 +0100
@@ -274,6 +274,7 @@ gfx::OverlayTransform SkiaOutputSurfaceI
case OutputSurface::OrientationMode::kHardware:
return display_transform_;
}
+ return gfx::OverlayTransform::OVERLAY_TRANSFORM_NONE;
}
SkCanvas* SkiaOutputSurfaceImpl::BeginPaintCurrentFrame() {
--- chromium-87.0.4280.40/third_party/blink/common/tokens/tokens_mojom_traits.cc.gcc10 2020-10-29 23:25:42.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/common/tokens/tokens_mojom_traits.cc 2020-11-01 03:24:41.694973255 +0100
@@ -33,6 +33,7 @@ bool UnionTraits<blink::mojom::FrameToke
return ret;
}
}
+ return false;
}
// static
--- chromium-87.0.4280.40/ui/accessibility/ax_node_position.cc.gcc10 2020-10-31 11:39:33.320868742 +0100
+++ chromium-87.0.4280.40/ui/accessibility/ax_node_position.cc 2020-11-01 03:26:17.121276656 +0100
@@ -262,6 +262,7 @@ bool AXNodePosition::IsEmbeddedObjectInP
!GetAnchor()->IsDescendantOfPlainTextField() &&
GetAnchor()->IsChildOfLeaf();
}
+ return false;
}
bool AXNodePosition::IsInLineBreakingObject() const {
--- chromium-87.0.4280.40/chrome/browser/media/router/providers/cast/cast_session_client_impl.cc.gcc10 2020-10-29 23:25:28.000000000 +0100
+++ chromium-87.0.4280.40/chrome/browser/media/router/providers/cast/cast_session_client_impl.cc 2020-11-01 03:50:40.019491703 +0100
@@ -108,6 +108,7 @@ bool CastSessionClientImpl::MatchesAutoJ
case AutoJoinPolicy::kOriginScoped:
return other_origin == origin();
}
+ return false;
}
void CastSessionClientImpl::OnMessage(
--- chromium-87.0.4280.40/chrome/browser/ui/webui/settings/safety_check_handler.cc.gcc10 2020-10-31 11:39:35.863822722 +0100
+++ chromium-87.0.4280.40/chrome/browser/ui/webui/settings/safety_check_handler.cc 2020-11-01 12:40:30.138019380 +0100
@@ -627,6 +627,7 @@ base::string16 SafetyCheckHandler::GetSt
IDS_SETTINGS_SAFETY_CHECK_EXTENSIONS_BLOCKLISTED_ON_ADMIN,
reenabled_admin.value());
}
+ return base::string16();
}
#if defined(OS_WIN) && BUILDFLAG(GOOGLE_CHROME_BRANDING)
--- chromium-87.0.4280.40/chrome/browser/ui/webui/settings/site_settings_handler.cc.gcc10 2020-10-29 23:25:30.000000000 +0100
+++ chromium-87.0.4280.40/chrome/browser/ui/webui/settings/site_settings_handler.cc 2020-11-01 12:41:34.104890962 +0100
@@ -382,6 +382,7 @@ std::string GetCookieSettingDescription(
map, {ContentSetting::CONTENT_SETTING_BLOCK}));
}
NOTREACHED();
+ return std::string();
}
} // namespace
--- chromium-87.0.4280.40/chrome/browser/ui/views/profiles/profile_picker_view.cc.gcc10 2020-10-29 23:25:30.000000000 +0100
+++ chromium-87.0.4280.40/chrome/browser/ui/views/profiles/profile_picker_view.cc 2020-11-01 12:42:59.213389265 +0100
@@ -60,6 +60,7 @@ GURL CreateURLForEntryPoint(ProfilePicke
case ProfilePicker::EntryPoint::kProfileMenuAddNewProfile:
return base_url.Resolve("new-profile");
}
+ return base_url;
}
} // namespace
--- chromium-87.0.4280.40/chrome/browser/ui/webui/signin/dice_web_signin_intercept_handler.cc.gcc10 2020-10-29 23:25:30.000000000 +0100
+++ chromium-87.0.4280.40/chrome/browser/ui/webui/signin/dice_web_signin_intercept_handler.cc 2020-11-01 12:51:18.134653408 +0100
@@ -195,6 +195,7 @@ std::string DiceWebSigninInterceptHandle
case DiceWebSigninInterceptor::SigninInterceptionType::kProfileSwitch:
return intercepted_account().given_name;
}
+ return std::string();
}
std::string DiceWebSigninInterceptHandler::GetBodyTitle() {
@@ -212,6 +213,7 @@ std::string DiceWebSigninInterceptHandle
return l10n_util::GetStringUTF8(
IDS_SIGNIN_DICE_WEB_INTERCEPT_SWITCH_BUBBLE_TITLE);
}
+ return std::string();
}
std::string DiceWebSigninInterceptHandler::GetBodyText() {
@@ -242,4 +244,5 @@ std::string DiceWebSigninInterceptHandle
base::UTF8ToUTF16(intercepted_account().email),
base::UTF8ToUTF16(intercepted_account().given_name));
}
+ return std::string();
}
--- chromium-87.0.4280.40/chrome/browser/ui/passwords/bubble_controllers/post_save_compromised_bubble_controller.cc.gcc10 2020-10-29 23:25:30.000000000 +0100
+++ chromium-87.0.4280.40/chrome/browser/ui/passwords/bubble_controllers/post_save_compromised_bubble_controller.cc 2020-11-01 13:05:49.003582638 +0100
@@ -61,6 +61,7 @@ base::string16 PostSaveCompromisedBubble
IDS_PASSWORD_MANAGER_UNSAFE_STATE_BODY_MESSAGE,
delegate_->GetTotalNumberCompromisedPasswords());
}
+ return base::string16();
}
gfx::Range PostSaveCompromisedBubbleController::GetSettingLinkRange() const {
@@ -77,6 +78,7 @@ base::string16 PostSaveCompromisedBubble
case BubbleType::kUnsafeState:
return l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_CHECK_BUTTON);
}
+ return base::string16();
}
int PostSaveCompromisedBubbleController::GetImageID(bool dark) const {
@@ -91,6 +93,7 @@ int PostSaveCompromisedBubbleController:
return dark ? IDR_SAVED_PASSWORDS_WARNING_STATE_DARK
: IDR_SAVED_PASSWORDS_WARNING_STATE;
}
+ return 0;
}
void PostSaveCompromisedBubbleController::OnAccepted() {
@@ -129,6 +132,7 @@ base::string16 PostSaveCompromisedBubble
IDS_PASSWORD_MANAGER_COMPROMISED_REMINDER_TITLE,
delegate_->GetTotalNumberCompromisedPasswords());
}
+ return base::string16();
}
void PostSaveCompromisedBubbleController::ReportInteractions() {
--- chromium-87.0.4280.40/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc.gcc10 2020-10-29 23:25:30.000000000 +0100
+++ chromium-87.0.4280.40/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc 2020-11-01 13:58:44.852344352 +0100
@@ -132,4 +132,5 @@ PermissionPromptImpl::GetPromptDispositi
LOCATION_BAR_RIGHT_ANIMATED_ICON;
}
}
+ return permissions::PermissionPromptDisposition::NOT_APPLICABLE;
}
--- chromium-87.0.4280.40/chrome/browser/ui/views/frame/webui_tab_strip_container_view.cc.gcc10 2020-10-29 23:25:30.000000000 +0100
+++ chromium-87.0.4280.40/chrome/browser/ui/views/frame/webui_tab_strip_container_view.cc 2020-11-01 14:18:10.976783833 +0100
@@ -107,6 +107,7 @@ gfx::Tween::Type GetTweenTypeForTabstrip
case WebUITabStripOpenCloseReason::kFling:
return gfx::Tween::LINEAR_OUT_SLOW_IN;
}
+ return gfx::Tween::ZERO;
}
// Returns the base duration of the animation used to open or close the
@@ -127,6 +128,7 @@ base::TimeDelta GetBaseTabstripOpenClose
case WebUITabStripDragDirection::kDown:
return kShowAnimationDuration;
}
+ return base::TimeDelta();
}
// Returns the actual duration of the animation used to open or close the
--- chromium-87.0.4280.40/chrome/browser/web_applications/web_app.cc.gcc10 2020-10-29 23:25:30.000000000 +0100
+++ chromium-87.0.4280.40/chrome/browser/web_applications/web_app.cc 2020-11-01 14:19:34.084296407 +0100
@@ -54,6 +54,7 @@ const SortedSizesPx& WebApp::downloaded_
case IconPurpose::MASKABLE:
return downloaded_icon_sizes_maskable_;
}
+ return *(SortedSizesPx *)nullptr;
}
void WebApp::AddSource(Source::Type source) {
--- chromium-87.0.4280.40/chrome/browser/predictors/loading_predictor_tab_helper.cc.gcc10 2020-10-31 11:39:33.353868145 +0100
+++ chromium-87.0.4280.40/chrome/browser/predictors/loading_predictor_tab_helper.cc 2020-11-01 15:09:01.354828737 +0100
@@ -95,6 +95,7 @@ network::mojom::RequestDestination GetDe
case optimization_guide::proto::RESOURCE_TYPE_SCRIPT:
return network::mojom::RequestDestination::kScript;
}
+ return network::mojom::RequestDestination::kEmpty;
}
bool ShouldPrefetchDestination(network::mojom::RequestDestination destination) {
--- chromium-87.0.4280.40/chrome/browser/download/download_ui_model.cc.gcc10 2020-10-29 23:25:28.000000000 +0100
+++ chromium-87.0.4280.40/chrome/browser/download/download_ui_model.cc 2020-11-01 15:24:38.870539109 +0100
@@ -222,6 +222,7 @@ base::string16 DownloadUIModel::GetStatu
NOTREACHED();
return base::string16();
}
+ return base::string16();
}
base::string16 DownloadUIModel::GetTooltipText() const {
--- chromium-87.0.4280.40/chrome/browser/banners/app_banner_manager.cc.gcc10 2020-10-31 11:39:32.505883491 +0100
+++ chromium-87.0.4280.40/chrome/browser/banners/app_banner_manager.cc 2020-11-01 15:25:33.902526781 +0100
@@ -326,6 +326,7 @@ bool AppBannerManager::DidRetryInstallab
NOTREACHED();
return false;
}
+ return false;
}
void AppBannerManager::OnDidGetManifest(const InstallableData& data) {
--- chromium-87.0.4280.40/chrome/browser/apps/app_service/extension_apps_base.cc.gcc10 2020-10-31 11:39:35.862822740 +0100
+++ chromium-87.0.4280.40/chrome/browser/apps/app_service/extension_apps_base.cc 2020-11-01 15:28:47.802961990 +0100
@@ -105,6 +105,7 @@ extensions::UninstallReason GetUninstall
case apps::mojom::UninstallSource::kMigration:
return extensions::UNINSTALL_REASON_MIGRATED;
}
+ return extensions::UNINSTALL_REASON_FOR_TESTING;
}
ash::ShelfLaunchSource ConvertLaunchSource(
--- chromium-87.0.4280.40/chrome/browser/content_settings/generated_cookie_prefs.cc.gcc10 2020-10-29 23:25:28.000000000 +0100
+++ chromium-87.0.4280.40/chrome/browser/content_settings/generated_cookie_prefs.cc 2020-11-01 15:35:18.475788859 +0100
@@ -72,6 +72,7 @@ CookiePrimarySetting ToCookiePrimarySett
return CookiePrimarySetting::ALLOW_ALL;
}
NOTREACHED();
+ return CookiePrimarySetting::BLOCK_ALL;
}
} // namespace
--- chromium-87.0.4280.40/chrome/browser/media/kaleidoscope/kaleidoscope_metrics_recorder.cc.gcc10 2020-10-29 23:25:28.000000000 +0100
+++ chromium-87.0.4280.40/chrome/browser/media/kaleidoscope/kaleidoscope_metrics_recorder.cc 2020-11-01 15:38:23.753391043 +0100
@@ -19,6 +19,7 @@ KaleidoscopeMetricsRecorder::FirstRunPro
return KaleidoscopeMetricsRecorder::FirstRunProgress::kMediaFeedsConsent;
}
NOTREACHED();
+ return KaleidoscopeMetricsRecorder::FirstRunProgress::kCompleted;
}
} // namespace
--- chromium-87.0.4280.40/chrome/browser/media/kaleidoscope/kaleidoscope_data_provider_impl.cc.gcc10 2020-10-29 23:25:28.000000000 +0100
+++ chromium-87.0.4280.40/chrome/browser/media/kaleidoscope/kaleidoscope_data_provider_impl.cc 2020-11-01 15:43:59.906171074 +0100
@@ -64,6 +64,7 @@ base::Optional<media_feeds::mojom::Media
case media::mojom::KaleidoscopeTab::kTVShows:
return media_feeds::mojom::MediaFeedItemType::kTVSeries;
}
+ return base::nullopt;
}
} // namespace
--- chromium-87.0.4280.40/chrome/browser/web_applications/web_app_icon_manager.cc.gcc10 2020-10-29 23:25:30.000000000 +0100
+++ chromium-87.0.4280.40/chrome/browser/web_applications/web_app_icon_manager.cc 2020-11-01 16:41:03.087294889 +0100
@@ -88,6 +88,7 @@ base::FilePath GetAppIconsDirectory(
return app_manifest_resources_directory.Append(
kIconsMaskableDirectoryName);
}
+ return base::FilePath();
}
// This is a private implementation detail of WebAppIconManager, where and how
--- chromium-87.0.4280.40/chrome/browser/web_applications/components/web_app_install_utils.cc.gcc10 2020-10-31 11:39:33.354868127 +0100
+++ chromium-87.0.4280.40/chrome/browser/web_applications/components/web_app_install_utils.cc 2020-11-01 16:46:54.900865341 +0100
@@ -135,6 +135,7 @@ apps::ShareTarget::Method ToAppsShareTar
return apps::ShareTarget::Method::kPost;
}
NOTREACHED();
+ return apps::ShareTarget::Method::kGet;
}
apps::ShareTarget::Enctype ToAppsShareTargetEnctype(
@@ -146,6 +147,7 @@ apps::ShareTarget::Enctype ToAppsShareTa
return apps::ShareTarget::Enctype::kMultipartFormData;
}
NOTREACHED();
+ return apps::ShareTarget::Enctype::kFormUrlEncoded;
}
base::Optional<apps::ShareTarget> ToWebAppShareTarget(
--- chromium-87.0.4280.40/chrome/browser/web_applications/web_app_proto_utils.cc.gcc10 2020-10-29 23:25:30.000000000 +0100
+++ chromium-87.0.4280.40/chrome/browser/web_applications/web_app_proto_utils.cc 2020-11-01 16:49:04.227502154 +0100
@@ -21,6 +21,7 @@ SyncPurposeToBlinkPurpose(sync_pb::WebAp
case sync_pb::WebAppIconInfo_Purpose_MASKABLE:
return blink::mojom::ManifestImageResource_Purpose::MASKABLE;
}
+ return base::nullopt;
}
sync_pb::WebAppIconInfo_Purpose BlinkPurposeToSyncPurpose(
@@ -35,6 +36,7 @@ sync_pb::WebAppIconInfo_Purpose BlinkPur
case blink::mojom::ManifestImageResource_Purpose::MASKABLE:
return sync_pb::WebAppIconInfo_Purpose_MASKABLE;
}
+ return sync_pb::WebAppIconInfo_Purpose_UNSPECIFIED;
}
} // namespace
@@ -154,6 +156,7 @@ base::Optional<WebApp::SyncFallbackData>
case DisplayMode::kStandalone:
return ::sync_pb::WebAppSpecifics::STANDALONE;
}
+ return ::sync_pb::WebAppSpecifics::STANDALONE;
}
RunOnOsLoginMode ToRunOnOsLoginMode(WebAppProto::RunOnOsLoginMode mode) {
@@ -177,6 +180,7 @@ WebAppProto::RunOnOsLoginMode ToWebAppPr
case RunOnOsLoginMode::kWindowed:
return WebAppProto::WINDOWED;
}
+ return WebAppProto::WINDOWED;
}
} // namespace web_app
--- chromium-87.0.4280.40/components/permissions/notification_permission_ui_selector.cc.gcc10 2020-10-29 23:25:34.000000000 +0100
+++ chromium-87.0.4280.40/components/permissions/notification_permission_ui_selector.cc 2020-11-01 16:49:53.396603729 +0100
@@ -17,6 +17,7 @@ bool NotificationPermissionUiSelector::S
case QuietUiReason::kTriggeredDueToAbusiveContent:
return true;
}
+ return true;
}
NotificationPermissionUiSelector::Decision::Decision(
--- chromium-87.0.4280.40/components/autofill/core/browser/data_model/autofill_structured_address_regex_provider.cc.gcc10 2020-10-29 23:25:33.000000000 +0100
+++ chromium-87.0.4280.40/components/autofill/core/browser/data_model/autofill_structured_address_regex_provider.cc 2020-11-01 16:50:56.091458192 +0100
@@ -479,6 +479,7 @@ std::string StructuredAddressesRegExProv
return ParseStreetNameHouseNumberExpression();
}
NOTREACHED();
+ return std::string();
}
const RE2* StructuredAddressesRegExProvider::GetRegEx(
--- chromium-87.0.4280.40/components/autofill/core/browser/autofill_profile_sync_util.cc.gcc10 2020-10-29 23:25:33.000000000 +0100
+++ chromium-87.0.4280.40/components/autofill/core/browser/autofill_profile_sync_util.cc 2020-11-01 16:52:55.787271257 +0100
@@ -51,6 +51,7 @@ VerificationStatus ConvertSpecificsToPro
case sync_pb::AutofillProfileSpecifics_VerificationStatus_SERVER_PARSED:
return VerificationStatus::kServerParsed;
}
+ return VerificationStatus::kNoStatus;
}
// Converts the verification status representation used AutofillProfiles to the
@@ -72,6 +73,8 @@ ConvertProfileToSpecificsVerificationSta
case (VerificationStatus::kServerParsed):
return sync_pb::AutofillProfileSpecifics_VerificationStatus_SERVER_PARSED;
}
+ return sync_pb::
+ AutofillProfileSpecifics_VerificationStatus_VERIFICATION_STATUS_UNSPECIFIED;
}
bool IsAutofillProfileSpecificsValid(
--- chromium-87.0.4280.40/components/feed/core/v2/request_throttler.cc.gcc10 2020-10-29 23:25:34.000000000 +0100
+++ chromium-87.0.4280.40/components/feed/core/v2/request_throttler.cc 2020-11-01 16:58:48.825821713 +0100
@@ -20,6 +20,7 @@ int GetMaxRequestsPerDay(NetworkRequestT
case NetworkRequestType::kUploadActions:
return GetFeedConfig().max_action_upload_requests_per_day;
}
+ return 0;
}
int DaysSinceOrigin(const base::Time& time_value) {
--- chromium-87.0.4280.40/components/feed/core/v2/tasks/load_stream_task.cc.gcc10 2020-10-29 23:25:34.000000000 +0100
+++ chromium-87.0.4280.40/components/feed/core/v2/tasks/load_stream_task.cc 2020-11-01 17:15:45.907316287 +0100
@@ -36,6 +36,7 @@ feedwire::FeedQuery::RequestReason GetRe
case LoadType::kBackgroundRefresh:
return feedwire::FeedQuery::SCHEDULED_REFRESH;
}
+ return feedwire::FeedQuery::UNKNOWN_REQUEST_REASON;
}
} // namespace
--- chromium-87.0.4280.40/components/feed/core/v2/metrics_reporter.cc.gcc10 2020-10-29 23:25:34.000000000 +0100
+++ chromium-87.0.4280.40/components/feed/core/v2/metrics_reporter.cc 2020-11-01 17:17:14.654705992 +0100
@@ -60,6 +60,7 @@ std::string LoadLatencyStepName(LoadLate
case LoadLatencyTimes::kStreamViewed:
return "StreamView";
}
+ return std::string();
}
void ReportLoadLatencies(std::unique_ptr<LoadLatencyTimes> latencies) {
--- chromium-87.0.4280.40/components/lookalikes/core/lookalike_url_util.cc.gcc10 2020-10-29 23:25:34.000000000 +0100
+++ chromium-87.0.4280.40/components/lookalikes/core/lookalike_url_util.cc 2020-11-01 17:18:45.473058011 +0100
@@ -755,6 +755,7 @@ bool ShouldBlockBySpoofCheckResult(const
case url_formatter::IDNSpoofChecker::Result::kDangerousPattern:
return true;
}
+ return false;
}
bool IsAllowedByEnterprisePolicy(const PrefService* pref_service,
--- chromium-87.0.4280.40/components/password_manager/core/browser/ui/insecure_credentials_manager.cc.gcc10 2020-10-29 23:25:34.000000000 +0100
+++ chromium-87.0.4280.40/components/password_manager/core/browser/ui/insecure_credentials_manager.cc 2020-11-01 18:12:40.914827316 +0100
@@ -67,6 +67,7 @@ InsecureCredentialTypeFlags ConvertCompr
return InsecureCredentialTypeFlags::kCredentialPhished;
}
NOTREACHED();
+ return InsecureCredentialTypeFlags::kSecure;
}
// This function takes three lists of compromised credentials, weak passwords
--- chromium-87.0.4280.40/content/browser/renderer_host/media/render_frame_audio_output_stream_factory.cc.gcc10 2020-10-29 23:25:36.000000000 +0100
+++ chromium-87.0.4280.40/content/browser/renderer_host/media/render_frame_audio_output_stream_factory.cc 2020-11-01 18:58:12.019142759 +0100
@@ -50,6 +50,7 @@ const char* OutputDeviceStatusToString(m
case media::OUTPUT_DEVICE_STATUS_ERROR_INTERNAL:
return "ERROR_INTERNAL";
}
+ return "";
}
} // namespace
--- chromium-87.0.4280.40/content/browser/file_system_access/native_file_system_manager_impl.cc.gcc10 2020-10-29 23:25:36.000000000 +0100
+++ chromium-87.0.4280.40/content/browser/file_system_access/native_file_system_manager_impl.cc 2020-11-01 19:44:25.767537817 +0100
@@ -1048,6 +1048,8 @@ NativeFileSystemManagerImpl::CreateFileS
return result;
}
}
+ FileSystemURLAndFSHandle result;
+ return result;
}
NativeFileSystemManagerImpl::SharedHandleState
--- chromium-87.0.4280.40/chrome/renderer/extensions/chrome_extensions_renderer_client.cc.gcc10 2020-10-29 23:25:31.000000000 +0100
+++ chromium-87.0.4280.40/chrome/renderer/extensions/chrome_extensions_renderer_client.cc 2020-11-01 20:57:58.900077136 +0100
@@ -212,6 +212,7 @@ bool ChromeExtensionsRendererClient::All
case extensions::Feature::BLESSED_WEB_PAGE_CONTEXT:
return !current_context->web_frame()->Parent();
}
+ return false;
}
blink::ProtocolHandlerSecurityLevel
@@ -237,6 +237,7 @@ ChromeExtensionsRendererClient::GetProto
case extensions::Feature::BLESSED_EXTENSION_CONTEXT:
return blink::ProtocolHandlerSecurityLevel::kUntrustedOrigins;
}
+ return blink::ProtocolHandlerSecurityLevel::kStrict;
}
void ChromeExtensionsRendererClient::WillSendRequest(
--- chromium-87.0.4280.40/components/content_settings/renderer/content_settings_agent_impl.cc.gcc10 2020-10-29 23:25:33.000000000 +0100
+++ chromium-87.0.4280.40/components/content_settings/renderer/content_settings_agent_impl.cc 2020-11-01 21:03:41.179986103 +0100
@@ -271,6 +271,7 @@ ContentSettingsAgentImpl::ConvertToMojoS
case StorageType::kSessionStorage:
return mojom::ContentSettingsManager::StorageType::SESSION_STORAGE;
}
+ return mojom::ContentSettingsManager::StorageType::DATABASE;
}
void ContentSettingsAgentImpl::AllowStorageAccess(
--- chromium-87.0.4280.40/pdf/out_of_process_instance.cc.gcc10 2020-10-29 23:25:41.000000000 +0100
+++ chromium-87.0.4280.40/pdf/out_of_process_instance.cc 2020-11-01 21:04:41.299916103 +0100
@@ -2344,6 +2344,7 @@ bool OutOfProcessInstance::SendInputEven
case PP_INPUTEVENT_TYPE_UNDEFINED:
return false;
}
+ return false;
}
template <typename T>
--- chromium-87.0.4280.40/pdf/ppapi_migration/value_conversions.cc.gcc10 2020-10-29 23:25:41.000000000 +0100
+++ chromium-87.0.4280.40/pdf/ppapi_migration/value_conversions.cc 2020-11-01 21:06:47.306673340 +0100
@@ -55,6 +55,7 @@ pp::Var VarFromValue(const base::Value&
CHECK(false);
return pp::Var();
}
+ return pp::Var();
}
base::Value ValueFromVar(const pp::Var& var) {
@@ -108,6 +109,7 @@ base::Value ValueFromVar(const pp::Var&
NOTREACHED();
return base::Value();
}
+ return base::Value();
}
} // namespace chrome_pdf
--- chromium-87.0.4280.40/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc.gcc10 2020-10-31 11:39:34.958839099 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc 2020-11-01 21:16:16.226535637 +0100
@@ -551,6 +551,7 @@ ResourceLoadPriority ResourceLoadSchedul
}
NOTREACHED();
}
+ return default_value;
}
mojom::blink::DelayCompetingLowPriorityRequestsDelayType
@@ -579,6 +580,7 @@ ResourceLoadScheduler::ComputeDelayMiles
return MojomDelayType::kUnknown;
return optimization_hints_->delay_type;
}
+ return MojomDelayType::kUnknown;
}
} // namespace blink
--- chromium-87.0.4280.40/third_party/blink/renderer/platform/network/http_parsers.cc.gcc10 2020-10-29 23:25:44.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/platform/network/http_parsers.cc 2020-11-01 21:17:32.568172953 +0100
@@ -161,6 +161,7 @@ blink::AllowCSPFromHeaderValuePtr Conver
return blink::AllowCSPFromHeaderValue::NewErrorMessage(
String::FromUTF8(allow_csp_from->get_error_message()));
}
+ return nullptr;
}
WTF::Vector<network::mojom::blink::WebClientHintsType> ConvertToBlink(
--- chromium-87.0.4280.40/third_party/blink/renderer/core/inspector/inspector_page_agent.cc.gcc10 2020-10-29 23:25:43.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/core/inspector/inspector_page_agent.cc 2020-11-01 22:31:03.460938999 +0100
@@ -1075,6 +1075,7 @@ protocol::Page::SecureContextType Create
case SecureContextModeExplanation::kSecureLocalhost:
return protocol::Page::SecureContextTypeEnum::SecureLocalhost;
}
+ return protocol::Page::SecureContextTypeEnum::Secure;
}
protocol::Page::CrossOriginIsolatedContextType
CreateProtocolCrossOriginIsolatedContextType(ExecutionContext* context) {
--- chromium-87.0.4280.40/third_party/blink/renderer/core/inspector/inspector_audits_agent.cc.gcc10 2020-10-31 11:39:36.710807393 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/core/inspector/inspector_audits_agent.cc 2020-11-01 22:36:13.434288949 +0100
@@ -431,6 +431,7 @@ protocol::String BuildViolationType(
return protocol::Audits::ContentSecurityPolicyViolationTypeEnum::
KTrustedTypesPolicyViolation;
}
+ return protocol::String();
}
} // namespace
--- chromium-87.0.4280.40/extensions/renderer/script_context.cc.gcc10 2020-10-29 23:25:38.000000000 +0100
+++ chromium-87.0.4280.40/extensions/renderer/script_context.cc 2020-11-01 23:05:19.053525690 +0100
@@ -51,6 +51,7 @@ GURL GetEffectiveDocumentURL(
}
NOTREACHED();
+ return false;
};
// If we don't need to consider the origin, we're done.
--- chromium-87.0.4280.40/media/base/media_serializers.h.gcc10 2020-10-31 11:39:34.909839986 +0100
+++ chromium-87.0.4280.40/media/base/media_serializers.h 2020-11-01 23:07:22.747281068 +0100
@@ -326,6 +326,7 @@ struct MediaSerializer<TextKind> {
case kTextNone:
return base::Value("None");
}
+ return base::Value("None");
}
};
--- chromium-87.0.4280.40/third_party/blink/renderer/bindings/core/v8/script_evaluation_result.cc.gcc10 2020-10-29 23:25:43.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/bindings/core/v8/script_evaluation_result.cc 2020-11-01 23:42:18.077042542 +0100
@@ -122,6 +122,8 @@ ScriptPromise ScriptEvaluationResult::Ge
NOTREACHED();
return ScriptPromise::Reject(script_state, v8::Local<v8::Value>());
}
+
+ return ScriptPromise();
}
} // namespace blink
--- chromium-87.0.4280.40/third_party/blink/renderer/core/editing/ime/ime_text_span.cc.gcc10 2020-10-29 23:25:43.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/core/editing/ime/ime_text_span.cc 2020-11-02 00:48:19.480922693 +0100
@@ -113,6 +113,7 @@ ui::ImeTextSpan::Type ConvertImeTextSpan
case ImeTextSpan::Type::kSuggestion:
return ui::ImeTextSpan::Type::kSuggestion;
}
+ return ui::ImeTextSpan::Type::kComposition;
}
} // namespace
--- chromium-87.0.4280.40/third_party/blink/renderer/controller/performance_manager/v8_detailed_memory_reporter_impl.cc.gcc10 2020-10-29 23:25:43.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/controller/performance_manager/v8_detailed_memory_reporter_impl.cc 2020-11-02 00:49:28.015679396 +0100
@@ -104,6 +104,7 @@ v8::MeasureMemoryExecution ToV8MeasureMe
return v8::MeasureMemoryExecution::kLazy;
}
NOTREACHED();
+ return v8::MeasureMemoryExecution::kDefault;
}
ExecutionContextToken ToExecutionContextToken(WorkerToken token) {
--- chromium-87.0.4280.40/third_party/blink/renderer/core/content_capture/content_capture_task.cc.gcc10 2020-10-29 23:25:43.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/core/content_capture/content_capture_task.cc 2020-11-02 00:50:59.180025551 +0100
@@ -253,6 +253,7 @@ base::TimeDelta ContentCaptureTask::GetA
return user_activated_delay_enabled ? task_delay_->GetNextTaskDelay()
: task_delay_->task_long_delay();
}
+ return base::TimeDelta();
}
void ContentCaptureTask::ScheduleInternal(ScheduleReason reason) {
--- chromium-87.0.4280.40/third_party/blink/renderer/core/layout/ng/grid/ng_grid_placement.cc.gcc10 2020-10-29 23:25:43.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/core/layout/ng/grid/ng_grid_placement.cc 2020-11-02 01:50:41.027936179 +0100
@@ -269,6 +269,7 @@ wtf_size_t NGGridPlacement::AutoRepeat(G
case kForColumns:
return column_auto_repeat_;
}
+ return 0;
}
wtf_size_t NGGridPlacement::ExplicitStart(GridTrackSizingDirection direction) {
@@ -278,6 +279,7 @@ wtf_size_t NGGridPlacement::ExplicitStar
case kForColumns:
return column_explicit_start_;
}
+ return 0;
}
NGGridBlockTrackCollection& NGGridPlacement::BlockCollection(
@@ -288,6 +290,7 @@ NGGridBlockTrackCollection& NGGridPlacem
case kForColumns:
return column_collection_;
}
+ return *(NGGridBlockTrackCollection *)nullptr;
}
} // namespace blink
--- chromium-87.0.4280.40/third_party/blink/renderer/core/layout/ng/ng_ink_overflow.cc.gcc10 2020-10-29 23:25:43.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/core/layout/ng/ng_ink_overflow.cc 2020-11-02 12:42:12.469301797 +0100
@@ -242,6 +242,7 @@ NGInkOverflow::Type NGInkOverflow::SetSi
return SetType(new_type);
}
NOTREACHED();
+ return type;
}
NGInkOverflow::Type NGInkOverflow::SetSelf(Type type,
@@ -294,6 +295,7 @@ NGInkOverflow::Type NGInkOverflow::Set(T
return kSelfAndContents;
}
NOTREACHED();
+ return type;
}
NGInkOverflow::Type NGInkOverflow::SetTextInkOverflow(
--- chromium-87.0.4280.40/third_party/blink/renderer/core/layout/ng/table/ng_table_borders.h.gcc10 2020-10-29 23:25:43.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/core/layout/ng/table/ng_table_borders.h 2020-11-02 13:00:37.610476455 +0100
@@ -103,13 +103,14 @@ class NGTableBorders : public RefCounted
case EdgeSide::kDoNotFill:
return LayoutUnit();
}
+ return LayoutUnit();
}
static EBorderStyle BorderStyle(const ComputedStyle* style,
EdgeSide edge_side) {
+ EBorderStyle border_style = EBorderStyle::kNone;
if (!style)
- return EBorderStyle::kNone;
- EBorderStyle border_style;
+ return border_style;
switch (edge_side) {
case EdgeSide::kLeft:
border_style = style->BorderLeftStyle();
@@ -152,6 +152,7 @@ class NGTableBorders : public RefCounted
NOTREACHED();
return style->VisitedDependentColor(GetCSSPropertyBorderBottomColor());
}
+ return style->VisitedDependentColor(GetCSSPropertyBorderBottomColor());
}
static bool HasBorder(const ComputedStyle* style) {
--- chromium-87.0.4280.40/third_party/blink/renderer/core/layout/ng/table/ng_table_borders.cc.gcc10 2020-10-29 23:25:43.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/core/layout/ng/table/ng_table_borders.cc 2020-11-02 13:01:54.095096388 +0100
@@ -108,6 +108,7 @@ NGTableBorders::EdgeSide LogicalEdgeToPh
return NGTableBorders::EdgeSide::kLeft;
}
}
+ return NGTableBorders::EdgeSide::kLeft;
}
class ColBordersMarker {
--- chromium-87.0.4280.40/third_party/blink/renderer/core/loader/address_space_feature.cc.gcc10 2020-10-29 23:25:43.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/core/loader/address_space_feature.cc 2020-11-02 13:17:34.139337528 +0100
@@ -56,6 +56,7 @@ base::Optional<Feature> AddressSpaceLoca
case AddressSpace::kLocal:
return base::nullopt; // Local to local is fine, we do not track it.
}
+ return base::nullopt;
}
// Returns the kAddressSpacePrivate* WebFeature enum value corresponding to the
@@ -79,6 +80,7 @@ base::Optional<Feature> AddressSpacePriv
// Private or local to local is fine, we do not track it.
return base::nullopt;
}
+ return base::nullopt;
}
base::Optional<Feature> AddressSpaceFeature(
@@ -96,6 +98,7 @@ base::Optional<Feature> AddressSpaceFeat
return AddressSpaceLocalFeature(client_address_space,
client_is_secure_context);
}
+ return base::nullopt;
}
} // namespace blink
--- chromium-87.0.4280.40/third_party/blink/renderer/modules/accessibility/ax_node_object.cc.gcc10 2020-10-29 23:25:44.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/modules/accessibility/ax_node_object.cc 2020-11-02 14:12:56.801143764 +0100
@@ -1864,6 +1864,7 @@ ax::mojom::blink::TextAlign AXNodeObject
case ETextAlign::kJustify:
return ax::mojom::blink::TextAlign::kJustify;
}
+ return ax::mojom::blink::TextAlign::kNone;
}
float AXNodeObject::GetTextIndent() const {
--- chromium-87.0.4280.40/third_party/blink/renderer/modules/imagecapture/image_capture.cc.gcc10 2020-10-29 23:25:44.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/modules/imagecapture/image_capture.cc 2020-11-02 14:14:51.281100433 +0100
@@ -84,6 +84,7 @@ WebString ToString(MeteringMode value) {
case MeteringMode::CONTINUOUS:
return WebString::FromUTF8("continuous");
}
+ return WebString();
}
#ifdef USE_BLINK_V8_BINDING_NEW_IDL_DICTIONARY
@@ -107,6 +108,7 @@ String ToV8FillLightMode(FillLightMode v
case FillLightMode::FLASH:
return String::FromUTF8("flash");
}
+ return String();
}
#endif
@@ -119,6 +121,7 @@ WebString ToString(RedEyeReduction value
case RedEyeReduction::CONTROLLABLE:
return WebString::FromUTF8("controllable");
}
+ return WebString();
}
MediaSettingsRange* ToMediaSettingsRange(
--- chromium-87.0.4280.40/third_party/blink/renderer/modules/xr/xr_system.cc.gcc10 2020-10-31 11:39:35.891822215 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/modules/xr/xr_system.cc 2020-11-02 14:17:00.207793960 +0100
@@ -267,6 +267,7 @@ bool IsFeatureRequested(
case device::mojom::XRSessionFeatureRequestStatus::kOptionalRejected:
return false;
}
+ return false;
}
} // namespace
--- chromium-87.0.4280.40/third_party/blink/renderer/platform/image-decoders/avif/avif_image_decoder.cc.gcc10 2020-10-31 11:39:35.891822215 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/platform/image-decoders/avif/avif_image_decoder.cc 2020-11-02 14:58:39.433191031 +0100
@@ -293,6 +293,7 @@ cc::YUVSubsampling AVIFImageDecoder::Get
NOTREACHED();
return cc::YUVSubsampling::kUnknown;
}
+ return cc::YUVSubsampling::kUnknown;
}
IntSize AVIFImageDecoder::DecodedYUVSize(cc::YUVIndex index) const {
--- chromium-88.0.4324.41/third_party/webrtc/api/video/video_frame_buffer.cc.gcc10 2020-12-10 13:06:01.000000000 +0100
+++ chromium-88.0.4324.41/third_party/webrtc/api/video/video_frame_buffer.cc 2020-12-12 23:47:57.384948245 +0100
@@ -82,6 +82,7 @@ const char* VideoFrameBufferTypeToString
default:
RTC_NOTREACHED();
}
+ return "";
}
int I420BufferInterface::ChromaWidth() const {
--- chromium-88.0.4324.41/third_party/webrtc/modules/video_coding/svc/scalability_structure_full_svc.cc.gcc10 2020-12-10 13:06:02.000000000 +0100
+++ chromium-88.0.4324.41/third_party/webrtc/modules/video_coding/svc/scalability_structure_full_svc.cc 2020-12-13 00:04:29.532881929 +0100
@@ -119,6 +119,7 @@ ScalabilityStructureFullSvc::NextPattern
}
return kDeltaT0;
}
+ return kDeltaT0;
}
std::vector<ScalableVideoController::LayerFrameConfig>
--- chromium-88.0.4324.41/ui/gfx/render_text_harfbuzz.cc.gcc10 2020-12-10 13:03:49.000000000 +0100
+++ chromium-88.0.4324.41/ui/gfx/render_text_harfbuzz.cc 2020-12-13 00:16:34.382659814 +0100
@@ -2257,6 +2257,7 @@ bool RenderTextHarfBuzz::IsValidDisplayR
case ELIDE_EMAIL:
return !text_elided();
}
+ return false;
}
bool RenderTextHarfBuzz::GetDecoratedTextForRange(
--- chromium-88.0.4324.41/media/base/video_codecs.cc.gcc10 2020-12-12 20:54:55.214838272 +0100
+++ chromium-88.0.4324.41/media/base/video_codecs.cc 2020-12-13 01:03:07.765442054 +0100
@@ -1037,5 +1037,6 @@ VideoCodec VideoCodecProfileToVideoCodec
case AV1PROFILE_PROFILE_PRO:
return kCodecAV1;
}
+ return kUnknownVideoCodec;
}
} // namespace media
--- chromium-88.0.4324.41/media/gpu/vaapi/vaapi_wrapper.cc.gcc10 2020-12-10 13:02:58.000000000 +0100
+++ chromium-88.0.4324.41/media/gpu/vaapi/vaapi_wrapper.cc 2020-12-13 01:31:50.194894949 +0100
@@ -1564,6 +1564,7 @@ VAEntrypoint VaapiWrapper::GetDefaultVaE
NOTREACHED();
return VAEntrypointVLD;
}
+ return VAEntrypointVLD;
}
// static
--- chromium-88.0.4324.41/components/signin/internal/identity_manager/primary_account_manager.cc.gcc10 2020-12-10 13:02:53.000000000 +0100
+++ chromium-88.0.4324.41/components/signin/internal/identity_manager/primary_account_manager.cc 2020-12-13 08:52:58.433983324 +0100
@@ -230,6 +230,7 @@ bool PrimaryAccountManager::HasPrimaryAc
case signin::ConsentLevel::kSync:
return consented_pref;
}
+ return false;
}
void PrimaryAccountManager::SignIn(const std::string& username) {
--- chromium-88.0.4324.41/services/network/trust_tokens/trust_token_parameterization.cc.gcc10 2020-12-10 13:03:01.000000000 +0100
+++ chromium-88.0.4324.41/services/network/trust_tokens/trust_token_parameterization.cc 2020-12-13 09:04:18.745509475 +0100
@@ -15,6 +15,7 @@ size_t TrustTokenMaxKeysForVersion(mojom
case mojom::TrustTokenProtocolVersion::kTrustTokenV2Voprf:
return 6;
}
+ return 0;
}
} // namespace network
--- chromium-88.0.4324.41/media/gpu/chromeos/fourcc.cc.gcc10 2020-12-10 13:02:58.000000000 +0100
+++ chromium-88.0.4324.41/media/gpu/chromeos/fourcc.cc 2020-12-13 09:27:30.925014372 +0100
@@ -311,6 +311,7 @@ base::Optional<Fourcc> Fourcc::ToSingleP
case MM21:
return base::nullopt;
}
+ return base::nullopt;
}
bool operator!=(const Fourcc& lhs, const Fourcc& rhs) {
@@ -340,6 +341,7 @@ bool Fourcc::IsMultiPlanar() const {
case MM21:
return true;
}
+ return false;
}
std::string Fourcc::ToString() const {
--- chromium-88.0.4324.41/ui/ozone/platform/wayland/host/wayland_zcr_cursor_shapes.cc.gcc10 2020-12-10 13:03:49.000000000 +0100
+++ chromium-88.0.4324.41/ui/ozone/platform/wayland/host/wayland_zcr_cursor_shapes.cc 2020-12-13 09:36:09.797516226 +0100
@@ -135,6 +135,7 @@ base::Optional<int32_t> WaylandZcrCursor
// NOTE: If you add a new cursor shape, please also update
// UseDefaultCursorForType() in bitmap_cursor_factory_ozone.cc.
}
+ return base::nullopt;
}
void WaylandZcrCursorShapes::SetCursorShape(int32_t shape) {
--- chromium-88.0.4324.41/device/fido/pin_internal.cc.gcc10 2020-12-10 13:02:56.000000000 +0100
+++ chromium-88.0.4324.41/device/fido/pin_internal.cc 2020-12-13 09:52:31.034573073 +0100
@@ -316,6 +316,7 @@ const Protocol& ProtocolVersion(PINUVAut
case PINUVAuthProtocol::kV2:
return *kProtocolV2;
}
+ return *(Protocol const *)nullptr;
}
} // namespace pin
--- chromium-88.0.4324.41/ui/views/controls/scroll_view.cc.gcc10 2020-12-10 13:03:49.000000000 +0100
+++ chromium-88.0.4324.41/ui/views/controls/scroll_view.cc 2020-12-13 10:16:53.452761300 +0100
@@ -1025,6 +1025,7 @@ bool ScrollView::IsHorizontalScrollEnabl
case ScrollBarMode::kEnabled:
return horiz_sb_ && horiz_sb_->GetVisible();
}
+ return true;
}
bool ScrollView::IsVerticalScrollEnabled() const {
@@ -1036,6 +1037,7 @@ bool ScrollView::IsVerticalScrollEnabled
case ScrollBarMode::kEnabled:
return vert_sb_ && vert_sb_->GetVisible();
}
+ return true;
}
void ScrollView::EnableViewportLayer() {
--- chromium-88.0.4324.41/ui/accessibility/ax_node_position.cc.gcc10 2020-12-13 06:30:18.010395114 +0100
+++ chromium-88.0.4324.41/ui/accessibility/ax_node_position.cc 2020-12-13 10:18:08.241387582 +0100
@@ -197,6 +197,7 @@ base::string16 AXNodePosition::GetText()
case AXEmbeddedObjectBehavior::kExposeCharacter:
return base::UTF8ToUTF16(anchor->GetHypertext());
}
+ return base::string16();
}
bool AXNodePosition::IsInLineBreak() const {
--- chromium-88.0.4324.41/chrome/browser/ui/browser.cc.gcc10 2020-12-13 06:30:17.174410248 +0100
+++ chromium-88.0.4324.41/chrome/browser/ui/browser.cc 2020-12-13 10:54:58.490790839 +0100
@@ -1971,6 +1971,7 @@ blink::ProtocolHandlerSecurityLevel Brow
case extensions::Feature::BLESSED_EXTENSION_CONTEXT:
return blink::ProtocolHandlerSecurityLevel::kUntrustedOrigins;
}
+ return blink::ProtocolHandlerSecurityLevel::kStrict;
}
void Browser::RegisterProtocolHandler(
--- chromium-88.0.4324.41/chrome/browser/safe_browsing/download_protection/deep_scanning_request.cc.gcc10 2020-12-10 13:02:47.000000000 +0100
+++ chromium-88.0.4324.41/chrome/browser/safe_browsing/download_protection/deep_scanning_request.cc 2020-12-13 11:54:25.781048242 +0100
@@ -160,6 +160,7 @@ std::string GetTriggerName(DeepScanningR
case DeepScanningRequest::DeepScanTrigger::TRIGGER_POLICY:
return "Policy";
}
+ return std::string();
}
} // namespace
--- chromium-88.0.4324.41/extensions/common/manifest_handlers/content_scripts_handler.cc.gcc10 2020-12-10 13:02:56.000000000 +0100
+++ chromium-88.0.4324.41/extensions/common/manifest_handlers/content_scripts_handler.cc 2020-12-13 12:57:28.936630400 +0100
@@ -52,6 +52,7 @@ UserScript::RunLocation ConvertRunLocati
NOTREACHED();
return UserScript::DOCUMENT_IDLE;
}
+ return UserScript::DOCUMENT_IDLE;
}
// Helper method that converts a parsed ContentScript object into a UserScript
--- chromium-88.0.4324.41/chrome/browser/performance_hints/performance_hints_observer.cc.gcc10 2020-12-13 06:30:18.384388344 +0100
+++ chromium-88.0.4324.41/chrome/browser/performance_hints/performance_hints_observer.cc 2020-12-13 13:00:16.593507847 +0100
@@ -366,6 +366,7 @@ PerformanceHintsObserver::LinkHintForURL
return {SourceLookupStatus::kNoMatch, base::nullopt};
}
}
+ return {SourceLookupStatus::kNotReady, base::nullopt};
}
std::tuple<PerformanceHintsObserver::SourceLookupStatus,
--- chromium-88.0.4324.41/chrome/browser/performance_manager/decorators/execution_context_priority_decorator.cc.gcc10 2020-12-10 13:02:46.000000000 +0100
+++ chromium-88.0.4324.41/chrome/browser/performance_manager/decorators/execution_context_priority_decorator.cc 2020-12-13 13:06:57.800037682 +0100
@@ -25,6 +25,7 @@ class ExecutionContextPriorityAccess {
return &WorkerNodeImpl::FromNode(execution_context->GetWorkerNode())
->accepted_vote_;
}
+ return nullptr;
}
};
--- chromium-88.0.4324.41/chrome/browser/enterprise/connectors/content_analysis_dialog.cc.gcc10 2020-12-10 13:02:46.000000000 +0100
+++ chromium-88.0.4324.41/chrome/browser/enterprise/connectors/content_analysis_dialog.cc 2020-12-13 13:38:38.733072225 +0100
@@ -474,10 +474,11 @@ base::string16 ContentAnalysisDialog::Ge
case DeepScanningDialogStatus::WARNING:
return GetWarningMessage();
}
+ return base::string16();
}
base::string16 ContentAnalysisDialog::GetCancelButtonText() const {
- int text_id;
+ int text_id = 0;
switch (dialog_status_) {
case DeepScanningDialogStatus::SUCCESS:
NOTREACHED();
@@ -639,6 +640,7 @@ SkColor ContentAnalysisDialog::GetSideIm
// logo should have the same color as the background.
return GetBackgroundColor(widget);
}
+ return SkColor(0);
}
// static
--- chromium-88.0.4324.41/chrome/browser/enterprise/connectors/content_analysis_delegate.cc.gcc10 2020-12-10 13:02:46.000000000 +0100
+++ chromium-88.0.4324.41/chrome/browser/enterprise/connectors/content_analysis_delegate.cc 2020-12-13 14:31:24.185573752 +0100
@@ -115,6 +115,7 @@ bool ContentAnalysisActionAllowsDataUse(
case enterprise_connectors::TriggeredRule::BLOCK:
return false;
}
+ return false;
}
std::string GetFileMimeType(base::FilePath path) {
@@ -256,6 +257,7 @@ bool ContentAnalysisDelegate::ResultShou
case BinaryUploadService::Result::DLP_SCAN_UNSUPPORTED_FILE_TYPE:
return !settings.block_unsupported_file_types;
}
+ return false;
}
// static
--- chromium-88.0.4324.41/chrome/browser/notifications/screen_capture_notification_blocker.cc.gcc10 2020-12-10 13:02:46.000000000 +0100
+++ chromium-88.0.4324.41/chrome/browser/notifications/screen_capture_notification_blocker.cc 2020-12-13 14:33:26.536369526 +0100
@@ -32,6 +32,7 @@ std::string MutedActionSuffix(MutedNotif
case MutedNotificationHandler::Action::kShowClick:
return "Show";
}
+ return std::string();
}
void RecordScreenCaptureCount(const std::string& suffix, int count) {
--- chromium-88.0.4324.41/chrome/browser/chrome_content_browser_client.cc.gcc10 2020-12-10 13:02:45.000000000 +0100
+++ chromium-88.0.4324.41/chrome/browser/chrome_content_browser_client.cc 2020-12-13 14:34:33.919155095 +0100
@@ -2953,6 +2953,7 @@ blink::mojom::PreferredColorScheme ToBli
}
NOTREACHED();
+ return blink::mojom::PreferredColorScheme::kLight;
}
#endif // !defined(OS_ANDROID)
--- chromium-88.0.4324.41/chrome/browser/prefetch/prefetch_proxy/prefetch_proxy_tab_helper.cc.gcc10 2020-12-10 13:02:46.000000000 +0100
+++ chromium-88.0.4324.41/chrome/browser/prefetch/prefetch_proxy/prefetch_proxy_tab_helper.cc 2020-12-13 14:35:18.897344270 +0100
@@ -1295,6 +1295,7 @@ bool PrefetchProxyTabHelper::IsWaitingFo
case CookieCopyStatus::kWaitingForCopy:
return true;
}
+ return false;
}
void PrefetchProxyTabHelper::SetOnAfterSRPCookieCopyCompleteCallback(
--- chromium-88.0.4324.41/chrome/browser/search/task_module/task_module_handler.cc.gcc10 2020-12-10 13:02:47.000000000 +0100
+++ chromium-88.0.4324.41/chrome/browser/search/task_module/task_module_handler.cc 2020-12-13 14:36:22.223204851 +0100
@@ -20,6 +20,7 @@ const char* GetModuleName(task_module::m
default:
NOTREACHED();
}
+ return "";
}
} // namespace
--- chromium-88.0.4324.41/chrome/browser/search/task_module/task_module_service.cc.gcc10 2020-12-10 13:02:47.000000000 +0100
+++ chromium-88.0.4324.41/chrome/browser/search/task_module/task_module_service.cc 2020-12-13 14:48:34.145044878 +0100
@@ -30,6 +30,7 @@ const char* GetPath(task_module::mojom::
case task_module::mojom::TaskModuleType::kShopping:
return "/async/newtab_shopping_tasks";
}
+ return "";
}
// We return a reference so that base::FeatureList::CheckFeatureIdentity
@@ -42,6 +43,7 @@ const base::Feature& GetFeature(
case task_module::mojom::TaskModuleType::kShopping:
return ntp_features::kNtpShoppingTasksModule;
}
+ return *(base::Feature const *)nullptr;
}
GURL GetApiUrl(task_module::mojom::TaskModuleType task_module_type,
@@ -68,6 +70,7 @@ const char* GetTasksKey(task_module::moj
case task_module::mojom::TaskModuleType::kShopping:
return "shopping_tasks";
}
+ return "";
}
const char* GetTaskItemsKey(
@@ -78,6 +81,7 @@ const char* GetTaskItemsKey(
case task_module::mojom::TaskModuleType::kShopping:
return "products";
}
+ return "";
}
const char* GetTaskItemsName(
@@ -88,6 +92,7 @@ const char* GetTaskItemsName(
case task_module::mojom::TaskModuleType::kShopping:
return "Products";
}
+ return "";
}
const char* GetDismissedTasksPrefName(
@@ -98,6 +103,7 @@ const char* GetDismissedTasksPrefName(
case task_module::mojom::TaskModuleType::kShopping:
return "NewTabPage.DismissedShoppingTasks";
}
+ return "";
}
const char* GetModuleName(task_module::mojom::TaskModuleType task_module_type) {
@@ -107,6 +113,7 @@ const char* GetModuleName(task_module::m
case task_module::mojom::TaskModuleType::kShopping:
return "ShoppingTasks";
}
+ return "";
}
} // namespace
--- chromium-88.0.4324.41/components/enterprise/browser/reporting/report_scheduler.cc.gcc10 2020-12-10 13:02:52.000000000 +0100
+++ chromium-88.0.4324.41/components/enterprise/browser/reporting/report_scheduler.cc 2020-12-13 14:50:02.572452005 +0100
@@ -40,6 +40,7 @@ bool IsBrowserVersionUploaded(ReportSche
case ReportScheduler::kTriggerExtensionRequest:
return false;
}
+ return false;
}
bool IsExtensionRequestUploaded(ReportScheduler::ReportTrigger trigger) {
@@ -52,6 +53,7 @@ bool IsExtensionRequestUploaded(ReportSc
case ReportScheduler::kTriggerNewVersion:
return false;
}
+ return false;
}
} // namespace
--- chromium-88.0.4324.41/components/metrics/demographics/demographic_metrics_provider.cc.gcc10 2020-12-10 13:02:52.000000000 +0100
+++ chromium-88.0.4324.41/components/metrics/demographics/demographic_metrics_provider.cc 2020-12-13 14:50:57.989453459 +0100
@@ -32,6 +32,7 @@ bool CanUploadDemographicsToGoogle(synce
case syncer::UploadState::ACTIVE:
return true;
}
+ return false;
}
} // namespace
--- chromium-88.0.4324.41/components/performance_manager/graph/frame_node_impl_describer.cc.gcc10 2020-12-10 13:02:52.000000000 +0100
+++ chromium-88.0.4324.41/components/performance_manager/graph/frame_node_impl_describer.cc 2020-12-13 14:51:54.517434659 +0100
@@ -38,6 +38,7 @@ std::string FrameNodeVisibilityToString(
case FrameNode::Visibility::kNotVisible:
return "Not visible";
}
+ return "";
}
} // namespace
--- chromium-88.0.4324.41/components/performance_manager/v8_memory/web_memory_aggregator.cc.gcc10 2020-12-10 13:02:52.000000000 +0100
+++ chromium-88.0.4324.41/components/performance_manager/v8_memory/web_memory_aggregator.cc 2020-12-13 14:53:01.195232629 +0100
@@ -74,6 +74,7 @@ WebMeasurementModeToRequestMeasurementMo
return v8_memory::V8DetailedMemoryRequest::MeasurementMode::
kEagerForTesting;
}
+ return v8_memory::V8DetailedMemoryRequest::MeasurementMode::kDefault;
}
} // anonymous namespace
--- chromium-88.0.4324.41/components/performance_manager/v8_memory/v8_detailed_memory.cc.gcc10 2020-12-13 06:30:18.392388199 +0100
+++ chromium-88.0.4324.41/components/performance_manager/v8_memory/v8_detailed_memory.cc 2020-12-13 14:54:01.171151143 +0100
@@ -103,6 +103,7 @@ bool IsMeasurementBounded(MeasurementMod
case MeasurementMode::kEagerForTesting:
return true;
}
+ return false;
}
// Returns the higher priority request of |a| and |b|, either of which can be
--- chromium-88.0.4324.41/components/permissions/permission_request_manager.cc.gcc10 2020-12-10 13:02:52.000000000 +0100
+++ chromium-88.0.4324.41/components/permissions/permission_request_manager.cc 2020-12-13 14:55:00.251085562 +0100
@@ -854,6 +854,7 @@ PermissionRequestManager::DetermineCurre
case QuietUiReason::kPredictedVeryUnlikelyGrant:
return PermissionPromptDispositionReason::PREDICTION_SERVICE;
}
+ return PermissionPromptDispositionReason::DEFAULT_FALLBACK;
}
void PermissionRequestManager::LogWarningToConsole(const char* message) {
--- chromium-88.0.4324.41/gin/v8_platform.cc.gcc10 2020-12-10 13:02:57.000000000 +0100
+++ chromium-88.0.4324.41/gin/v8_platform.cc 2020-12-13 22:18:42.579576846 +0100
@@ -329,6 +329,7 @@ class JobHandleImpl : public v8::JobHand
case v8::TaskPriority::kUserBlocking:
return base::TaskPriority::USER_BLOCKING;
}
+ return base::TaskPriority::BEST_EFFORT;
}
base::JobHandle handle_;
--- chromium-88.0.4324.41/content/renderer/accessibility/render_accessibility_impl.cc.gcc10 2020-12-10 13:02:55.000000000 +0100
+++ chromium-88.0.4324.41/content/renderer/accessibility/render_accessibility_impl.cc 2020-12-14 01:05:30.903184482 +0100
@@ -689,6 +689,7 @@ bool RenderAccessibilityImpl::IsImmediat
NOTREACHED() << "Event not expected from Blink: " << event.event_type;
return false;
}
+ return false;
}
bool RenderAccessibilityImpl::ShouldSerializeNodeForEvent(
--- chromium-88.0.4324.41/third_party/blink/renderer/core/fetch/fetch_manager.cc.gcc10 2020-12-10 13:03:03.000000000 +0100
+++ chromium-88.0.4324.41/third_party/blink/renderer/core/fetch/fetch_manager.cc 2020-12-14 02:44:31.170414937 +0100
@@ -172,6 +172,7 @@ FailedReason ResourceRequestBlockedReaso
return FailedReason::
kBlockedBecauseBlockedByExtensionCrbug1128174Investigation;
}
+ return FailedReason::kBlockedBecauseOther;
}
const char* SerializeTrustTokenOperationType(
@@ -184,6 +185,7 @@ const char* SerializeTrustTokenOperation
case network::mojom::blink::TrustTokenOperationType::kSigning:
return "Signing";
}
+ return "";
}
// Logs a more descriptive reason why a fetch with Trust Tokens parameters
--- chromium-88.0.4324.41/third_party/blink/renderer/core/frame/coop_access_violation_report_body.cc.gcc10 2020-12-10 13:03:03.000000000 +0100
+++ chromium-88.0.4324.41/third_party/blink/renderer/core/frame/coop_access_violation_report_body.cc 2020-12-14 02:45:27.978364806 +0100
@@ -35,6 +35,7 @@ String CoopAccessViolationReportBody::op
case network::mojom::CoopAccessReportType::kAccessFromCoopPageToOther:
return String();
}
+ return String();
}
String CoopAccessViolationReportBody::openerURL() const {
@@ -51,6 +52,7 @@ String CoopAccessViolationReportBody::op
case network::mojom::CoopAccessReportType::kAccessFromCoopPageToOther:
return String();
}
+ return String();
}
String CoopAccessViolationReportBody::otherDocumentURL() const {
@@ -67,6 +69,7 @@ String CoopAccessViolationReportBody::ot
case network::mojom::CoopAccessReportType::kAccessFromCoopPageToOpener:
return String();
}
+ return String();
}
void CoopAccessViolationReportBody::BuildJSONValue(
--- chromium-88.0.4324.41/third_party/blink/renderer/core/layout/ng/grid/ng_grid_layout_algorithm.cc.gcc10 2020-12-10 13:03:03.000000000 +0100
+++ chromium-88.0.4324.41/third_party/blink/renderer/core/layout/ng/grid/ng_grid_layout_algorithm.cc 2020-12-14 13:41:14.020075483 +0100
@@ -689,6 +689,7 @@ static LayoutUnit AffectedSizeForContrib
return set.BaseSize();
return growth_limit;
}
+ return LayoutUnit(0);
}
static void GrowAffectedSizeByPlannedIncrease(
@@ -733,6 +734,7 @@ static bool IsContributionAppliedToSet(
case NGGridItemContributionType::kForMaxContentMaximums:
return set.TrackSize().HasMaxContentOrAutoMaxTrackBreadth();
}
+ return false;
}
// https://drafts.csswg.org/css-grid-1/#extra-space
@@ -757,6 +759,7 @@ static bool ShouldUsedSizeGrowBeyondLimi
case NGGridItemContributionType::kForMaxContentMaximums:
return false;
}
+ return false;
}
static bool IsDistributionForGrowthLimits(
@@ -770,6 +773,7 @@ static bool IsDistributionForGrowthLimit
case NGGridItemContributionType::kForMaxContentMaximums:
return true;
}
+ return false;
}
enum class InfinitelyGrowableBehavior { kEnforce, kIgnore };
@@ -819,6 +823,7 @@ static LayoutUnit GrowthPotentialForSet(
return kIndefiniteSize;
}
}
+ return LayoutUnit(0);
}
} // namespace
--- chromium-88.0.4324.41/third_party/blink/renderer/core/inspector/inspector_page_agent.cc.gcc10 2020-12-13 06:30:18.024394861 +0100
+++ chromium-88.0.4324.41/third_party/blink/renderer/core/inspector/inspector_page_agent.cc 2020-12-14 13:42:17.426914042 +0100
@@ -146,6 +146,7 @@ String FrameDetachTypeToProtocol(FrameDe
case FrameDetachType::kSwap:
return ReasonEnum::Swap;
}
+ return String();
}
Resource* CachedResource(LocalFrame* frame,
--- chromium-88.0.4324.41/third_party/blink/renderer/core/resize_observer/resize_observer_utilities.cc.gcc10 2020-12-10 13:03:04.000000000 +0100
+++ chromium-88.0.4324.41/third_party/blink/renderer/core/resize_observer/resize_observer_utilities.cc 2020-12-14 16:46:17.120628900 +0100
@@ -61,6 +61,7 @@ FloatSize ResizeObserverUtilities::Compu
default:
NOTREACHED();
}
+ return FloatSize();
}
FloatSize ResizeObserverUtilities::ComputeSnappedDevicePixelContentBox(
--- chromium-88.0.4324.41/third_party/blink/renderer/core/streams/readable_stream_default_reader.cc.gcc10 2020-12-10 13:03:04.000000000 +0100
+++ chromium-88.0.4324.41/third_party/blink/renderer/core/streams/readable_stream_default_reader.cc 2020-12-14 16:47:39.788118815 +0100
@@ -90,6 +90,7 @@ StreamPromiseResolver* ReadableStreamDef
// 7. Return ! stream.[[readableStreamController]].[[PullSteps]]().
return stream->GetController()->PullSteps(script_state);
}
+ return nullptr;
}
void ReadableStreamDefaultReader::releaseLock(ScriptState* script_state,
