--- chromium-62.0.3192.0/extensions/common/permissions/settings_override_permission.cc.gcc7 2017-08-22 21:04:44.000000000 +0200
+++ chromium-62.0.3192.0/extensions/common/permissions/settings_override_permission.cc 2017-09-09 00:43:40.708568094 +0200
@@ -43,7 +43,9 @@
bool SettingsOverrideAPIPermission::Equal(const APIPermission* rhs) const {
if (this != rhs)
+ {
CHECK_EQ(info(), rhs->info());
+ }
return true;
}
--- chromium-62.0.3192.0/extensions/common/permissions/api_permission.cc.gcc7 2017-08-22 21:04:44.000000000 +0200
+++ chromium-62.0.3192.0/extensions/common/permissions/api_permission.cc 2017-09-09 01:26:10.983202025 +0200
@@ -36,7 +36,9 @@
bool Equal(const APIPermission* rhs) const override {
if (this != rhs)
+ {
CHECK_EQ(info(), rhs->info());
+ }
return true;
}
--- chromium-62.0.3192.0/content/browser/renderer_host/navigation_controller_impl.cc.gcc7 2017-08-22 21:04:43.000000000 +0200
+++ chromium-62.0.3192.0/content/browser/renderer_host/navigation_controller_impl.cc 2017-09-09 01:53:03.860647419 +0200
@@ -1198,8 +1198,9 @@ bool NavigationControllerImpl::RendererD
// The active entry's SiteInstance should match our SiteInstance.
// TODO(creis): This check won't pass for subframes until we create entries
// for subframe navigations.
- if (!rfh->GetParent())
+ if (!rfh->GetParent()) {
CHECK_EQ(active_entry->site_instance(), rfh->GetSiteInstance());
+ }
// Now prep the rest of the details for the notification and broadcast.
details->entry = active_entry;
--- chromium-62.0.3192.0/content/browser/renderer_host/navigator.cc.gcc7 2017-08-22 21:04:43.000000000 +0200
+++ chromium-62.0.3192.0/content/browser/renderer_host/navigator.cc 2017-09-09 02:05:15.758922091 +0200
@@ -411,7 +411,9 @@
// Make sure no code called via RFH::Navigate clears the pending entry.
if (is_pending_entry)
+ {
CHECK_EQ(nav_entry_id, controller_->GetPendingEntry()->GetUniqueID());
+ }
}
void Navigator::RequestOpenURL(
--- chromium-62.0.3192.0/content/browser/renderer_host/render_frame_host_manager.cc.gcc7 2017-08-22 21:04:43.000000000 +0200
+++ chromium-62.0.3192.0/content/browser/renderer_host/render_frame_host_manager.cc 2017-09-09 02:07:40.371353881 +0200
@@ -1515,7 +1515,9 @@ RenderFrameHostManager::GetSiteInstanceF
// SiteInstance and the same frame, breaking lookup of RenderFrameHosts by
// SiteInstance.
if (should_swap)
+ {
CHECK_NE(new_instance, current_instance);
+ }
if (new_instance == current_instance) {
// If we're navigating to the same site instance, we won't need to use the
--- chromium-62.0.3192.0/media/cast/receiver/video_decoder.cc.gcc7 2017-08-22 21:04:45.000000000 +0200
+++ chromium-62.0.3192.0/media/cast/receiver/video_decoder.cc 2017-09-09 05:02:17.907818439 +0200
@@ -133,7 +133,9 @@
private:
~Vp8Impl() final {
if (ImplBase::operational_status_ == STATUS_INITIALIZED)
+ {
CHECK_EQ(VPX_CODEC_OK, vpx_codec_destroy(&context_));
+ }
}
scoped_refptr<VideoFrame> Decode(uint8_t* data, int len) final {
--- chromium-64.0.3282.71/extensions/renderer/runtime_custom_bindings.cc.gcc7 2018-01-04 00:06:04.000000000 +0100
+++ chromium-64.0.3282.71/extensions/renderer/runtime_custom_bindings.cc 2018-01-08 01:59:41.213107482 +0100
@@ -61,11 +61,15 @@
ViewType view_type = VIEW_TYPE_INVALID;
bool parsed_view_type = GetViewTypeFromString(view_type_string, &view_type);
if (!parsed_view_type)
+ {
CHECK_EQ("ALL", view_type_string);
+ }
const std::string& extension_id = context()->GetExtensionID();
if (extension_id.empty())
+ {
return;
+ }
// We ignore iframes here. (Returning subframes can cause broken behavior by
// treating an app window's iframe as its main frame, and maybe other
--- chromium-67.0.3396.10/third_party/blink/renderer/core/frame/local_frame_view.cc.gcc7 2018-04-18 21:05:39.000000000 +0200
+++ chromium-67.0.3396.10/third_party/blink/renderer/core/frame/local_frame_view.cc 2018-04-22 21:37:37.030626382 +0200
@@ -3396,7 +3396,9 @@
void LocalFrameView::AttachToLayout() {
CHECK(!IsAttached());
if (frame_->GetDocument())
+ {
CHECK_NE(Lifecycle().GetState(), DocumentLifecycle::kStopping);
+ }
SetAttached(true);
LocalFrameView* parent_view = ParentFrameView();
CHECK(parent_view);
--- chromium-69.0.3472.3/base/callback_helpers.h.gcc7 2018-06-26 06:32:56.000000000 +0200
+++ chromium-69.0.3472.3/base/callback_helpers.h 2018-07-07 16:00:33.724127746 +0200
@@ -91,7 +91,7 @@
void ReplaceClosure(OnceClosure closure);
// Releases the Closure without calling.
- OnceClosure Release() WARN_UNUSED_RESULT;
+ OnceClosure Release();
private:
OnceClosure closure_;
--- chromium-69.0.3497.4/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc.gcc7 2018-07-21 09:13:41.000000000 +0200
+++ chromium-69.0.3497.4/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc 2018-07-22 12:12:33.199377829 +0200
@@ -1800,9 +1800,6 @@ void XMLHttpRequest::DidSendData(uint64_
void XMLHttpRequest::DidReceiveResponse(uint64_t identifier,
const ResourceResponse& response) {
- // TODO(yhirano): Remove this CHECK: see https://crbug.com/570946.
- CHECK(&response);
-
NETWORK_DVLOG(1) << this << " didReceiveResponse(" << identifier << ")";
ScopedEventDispatchProtect protect(&event_dispatch_recursion_level_);
--- chromium-86.0.4240.53/components/performance_manager/decorators/site_data_recorder.cc.gcc7 2020-09-24 07:33:21.000000000 +0200
+++ chromium-86.0.4240.53/components/performance_manager/decorators/site_data_recorder.cc 2020-10-27 02:37:19.575803148 +0100
@@ -243,7 +243,9 @@ void SiteDataNodeData::MaybeNotifyBackgr
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
if (ShouldIgnoreFeatureUsageEvent(feature_type))
+ {
return;
+ }
(writer_.get()->*method)();
}
--- chromium-72.0.3626.81/chrome/browser/navigation_predictor/navigation_predictor.cc.gcc8 2019-01-30 02:17:46.000000000 +0100
+++ chromium-72.0.3626.81/chrome/browser/navigation_predictor/navigation_predictor.cc 2019-02-03 12:00:26.128679087 +0100
@@ -874,18 +874,6 @@ double NavigationPredictor::CalculateAnc
DCHECK_LE(0, metrics.ratio_visible_area);
DCHECK_GE(1, metrics.ratio_visible_area);
- DCHECK_LE(0, metrics.is_in_iframe);
- DCHECK_GE(1, metrics.is_in_iframe);
-
- DCHECK_LE(0, metrics.is_same_host);
- DCHECK_GE(1, metrics.is_same_host);
-
- DCHECK_LE(0, metrics.contains_image);
- DCHECK_GE(1, metrics.contains_image);
-
- DCHECK_LE(0, metrics.is_url_incremented_by_one);
- DCHECK_GE(1, metrics.is_url_incremented_by_one);
-
DCHECK_LE(0, area_rank_score);
DCHECK_GE(1, area_rank_score);
--- chromium-76.0.3809.46/components/prefs/scoped_user_pref_update.cc.gcc8 2019-06-27 23:59:19.000000000 +0200
+++ chromium-76.0.3809.46/components/prefs/scoped_user_pref_update.cc 2019-07-01 01:26:56.050011380 +0200
@@ -30,7 +30,9 @@ base::Value* ScopedUserPrefUpdateBase::G
// side-stepping CHECKs built into base::Value. Thus we need to be certain
// that the type matches.
if (value_)
+ {
CHECK_EQ(value_->type(), type);
+ }
return value_;
}
--- chromium-77.0.3865.10/ui/gfx/geometry/cubic_bezier.cc.gcc9 2019-08-06 13:57:24.000000000 +0200
+++ chromium-77.0.3865.10/ui/gfx/geometry/cubic_bezier.cc 2019-08-17 22:59:59.207421178 +0200
@@ -191,6 +191,9 @@ double CubicBezier::SolveCurveX(double x
break;
}
}
+ if (i == CUBIC_BEZIER_SPLINE_SAMPLES) {
+ return t2;
+ }
// Perform a few iterations of Newton's method -- normally very fast.
// See https://en.wikipedia.org/wiki/Newton%27s_method.
--- chromium-77.0.3865.35/net/base/address_tracker_linux.cc.gcc9 2019-08-15 00:02:09.000000000 +0200
+++ chromium-77.0.3865.35/net/base/address_tracker_linux.cc 2019-08-18 02:40:46.959280055 +0200
@@ -109,7 +109,7 @@ char* AddressTrackerLinux::GetInterfaceN
ifr.ifr_ifindex = interface_index;
if (ioctl(ioctl_socket.get(), SIOCGIFNAME, &ifr) == 0)
- strncpy(buf, ifr.ifr_name, IFNAMSIZ - 1);
+ strncpy(buf, ifr.ifr_name, IFNAMSIZ);
return buf;
}
--- chromium-77.0.3865.35/ui/aura/window.h.gcc9 2019-08-15 00:02:31.000000000 +0200
+++ chromium-77.0.3865.35/ui/aura/window.h 2019-08-18 06:28:00.859724168 +0200
@@ -41,7 +41,7 @@
#include "ui/gfx/native_widget_types.h"
#if defined(OS_APPLE)
-#error This file must not be included on macOS; Chromium Mac doesn't use Aura.
+#error "This file must not be included on macOS; Chromium Mac doesn't use Aura."
#endif
namespace cc {
--- chromium-77.0.3865.35/ui/views/widget/native_widget_aura.h.gcc9 2019-08-15 00:02:32.000000000 +0200
+++ chromium-77.0.3865.35/ui/views/widget/native_widget_aura.h 2019-08-19 04:51:03.906955149 +0200
@@ -23,7 +23,7 @@
#include "ui/wm/public/activation_delegate.h"
#if defined(OS_APPLE)
-#error This file must not be included on macOS; Chromium Mac doesn't use Aura.
+#error "This file must not be included on macOS; Chromium Mac doesn't use Aura."
#endif
namespace aura {
--- chromium-77.0.3865.35/mojo/public/cpp/bindings/interface_ptr.h.gcc9 2019-08-15 00:02:09.000000000 +0200
+++ chromium-77.0.3865.35/mojo/public/cpp/bindings/interface_ptr.h 2019-08-19 17:50:50.761940919 +0200
@@ -234,7 +234,7 @@ InterfacePtr<Interface> MakeProxy(
InterfacePtr<Interface> ptr;
if (info.is_valid())
ptr.Bind(std::move(info), std::move(runner));
- return std::move(ptr);
+ return ptr;
}
} // namespace mojo
--- chromium-77.0.3865.35/extensions/browser/api/declarative/declarative_rule.h.gcc9 2019-08-15 00:02:07.000000000 +0200
+++ chromium-77.0.3865.35/extensions/browser/api/declarative/declarative_rule.h 2019-08-19 21:09:58.931468347 +0200
@@ -454,7 +454,7 @@ DeclarativeRule<ConditionT, ActionT>::Cr
std::unique_ptr<ConditionSet> conditions = ConditionSet::Create(
extension, url_matcher_condition_factory, rule.conditions, error);
if (!error->empty())
- return std::move(error_result);
+ return error_result;
CHECK(conditions.get());
bool bad_message = false;
@@ -465,16 +465,16 @@ DeclarativeRule<ConditionT, ActionT>::Cr
// should be killed in case it is true.
*error = "An action of a rule set had an invalid "
"structure that should have been caught by the JSON validator.";
- return std::move(error_result);
+ return error_result;
}
if (!error->empty() || bad_message)
- return std::move(error_result);
+ return error_result;
CHECK(actions.get());
if (!check_consistency.is_null() &&
!check_consistency.Run(conditions.get(), actions.get(), error)) {
DCHECK(!error->empty());
- return std::move(error_result);
+ return error_result;
}
CHECK(rule.priority.get());
--- chromium-77.0.3865.35/ui/accessibility/ax_range.h.gcc9 2019-08-15 00:02:31.000000000 +0200
+++ chromium-77.0.3865.35/ui/accessibility/ax_range.h 2019-08-19 21:16:26.972767645 +0200
@@ -199,7 +199,7 @@ class AXRange {
AXRange current_leaf_text_range(current_start_->AsTextPosition(),
current_end->AsTextPosition());
DCHECK(current_leaf_text_range.IsLeafTextRange());
- return std::move(current_leaf_text_range);
+ return current_leaf_text_range;
}
private:
--- chromium-77.0.3865.35/third_party/blink/renderer/platform/wtf/hash_table.h.gcc9 2019-08-20 01:13:49.676102112 +0200
+++ chromium-77.0.3865.35/third_party/blink/renderer/platform/wtf/hash_table.h 2019-08-20 01:14:19.562593807 +0200
@@ -354,7 +354,7 @@ class HashTableConstIterator final {
}
public:
- HashTableConstIterator() = default;
+ HashTableConstIterator() : position_(0), end_position_(0) {}
GetType Get() const {
CheckModifications();
--- chromium-70.0.3528.4/v8/src/codegen/interface-descriptors.h.gcc8 2018-08-24 20:21:09.588641771 +0200
+++ chromium-70.0.3528.4/v8/src/codegen/interface-descriptors.h 2018-08-24 20:24:49.422023115 +0200
@@ -442,8 +442,8 @@ STATIC_ASSERT(kMaxTFSBuiltinRegisterPara
static constexpr int kReturnCount = return_count; \
static constexpr StackArgumentOrder kStackArgumentOrder = stack_order; \
enum ParameterIndices { \
- __dummy = -1, /* to be able to pass zero arguments */ \
- ##__VA_ARGS__, \
+ __dummy = -1 __VA_OPT__(,) /* to be able to pass zero arguments */ \
+ __VA_ARGS__, \
\
kParameterCount, \
kContext = kParameterCount /* implicit parameter */ \
@@ -464,8 +464,8 @@ STATIC_ASSERT(kMaxTFSBuiltinRegisterPara
StackArgumentOrder::kDefault; \
static constexpr int kReturnCount = 1; \
enum ParameterIndices { \
- __dummy = -1, /* to be able to pass zero arguments */ \
- ##__VA_ARGS__, \
+ __dummy = -1 __VA_OPT__(,) /* to be able to pass zero arguments */ \
+ __VA_ARGS__, \
\
kParameterCount \
};
@@ -514,8 +514,8 @@ STATIC_ASSERT(kMaxTFSBuiltinRegisterPara
enum ParameterIndices { \
kTarget, \
kNewTarget, \
- kActualArgumentsCount, \
- ##__VA_ARGS__, \
+ kActualArgumentsCount __VA_OPT__(,) \
+ __VA_ARGS__, \
\
kParameterCount, \
kContext = kParameterCount /* implicit parameter */ \
--- chromium-78.0.3904.21/chrome/browser/resource_coordinator/tab_ranker/pairwise_inference.cc.gcc9 2019-09-19 20:50:27.000000000 +0200
+++ chromium-78.0.3904.21/chrome/browser/resource_coordinator/tab_ranker/pairwise_inference.cc 2019-09-22 16:25:52.738825612 +0200
@@ -58,12 +58,11 @@ void FullyConnected(const int32_t* __res
template <typename T>
void Relu(const int32_t rank,
const int32_t* __restrict input_shape,
- const T* __restrict input_values,
- T* __restrict output_values) {
+ T* __restrict values) {
const int32_t size = ShapeSize(rank, input_shape);
for (int32_t i = 0; i < size; ++i) {
- const T value = input_values[i];
- output_values[i] = std::max(value, static_cast<T>(0));
+ const T value = values[i];
+ values[i] = std::max(value, static_cast<T>(0));
}
}
@@ -1980,7 +1979,7 @@ void Inference(const float* __restrict f
// dnn/hiddenlayer_0/hiddenlayer_0/Relu
Relu<float>(2, // rank
- fixed->shape0, fixed->alloc1, fixed->alloc1);
+ fixed->shape0, fixed->alloc1);
// dnn/logits/MatMul_merged_with_dnn/logits/BiasAdd
FullyConnected<float>(
--- chromium-78.0.3904.70/sandbox/linux/seccomp-bpf/syscall.cc.gcc9 2019-10-21 21:06:39.000000000 +0200
+++ chromium-78.0.3904.70/sandbox/linux/seccomp-bpf/syscall.cc 2019-10-28 21:14:17.697737345 +0100
@@ -371,7 +371,7 @@ intptr_t Syscall::Call(int nr,
// N.B. These are not the calling conventions normally used by the ABI.
: "=a"(ret)
: "0"(ret), "D"(args)
- : "cc", "esp", "memory", "ecx", "edx");
+ : "cc", "memory", "ecx", "edx");
#elif defined(__x86_64__)
intptr_t ret = SyscallAsm(nr, args);
#elif defined(__arm__)
--- chromium-78.0.3904.70/third_party/tcmalloc/vendor/src/base/linux_syscall_support.h.gcc9 2019-10-21 21:07:26.000000000 +0200
+++ chromium-78.0.3904.70/third_party/tcmalloc/vendor/src/base/linux_syscall_support.h 2019-10-28 22:00:44.319641968 +0100
@@ -1066,7 +1066,7 @@ struct kernel_stat {
"pop %%ebx\n" \
CFI_ADJUST_CFA_OFFSET(-4) \
args \
- : "esp", "memory"); \
+ : "memory"); \
LSS_RETURN(type,__res)
#undef _syscall0
#define _syscall0(type,name) \
@@ -1123,7 +1123,7 @@ struct kernel_stat {
: "i" (__NR_##name), "ri" ((long)(arg1)), \
"c" ((long)(arg2)), "d" ((long)(arg3)), \
"S" ((long)(arg4)), "D" ((long)(arg5)) \
- : "esp", "memory"); \
+ : "memory"); \
LSS_RETURN(type,__res); \
}
#undef _syscall6
@@ -1145,7 +1145,7 @@ struct kernel_stat {
: "i" (__NR_##name), "0" ((long)(&__s)), \
"c" ((long)(arg2)), "d" ((long)(arg3)), \
"S" ((long)(arg4)), "D" ((long)(arg5)) \
- : "esp", "memory"); \
+ : "memory"); \
LSS_RETURN(type,__res); \
}
LSS_INLINE int LSS_NAME(clone)(int (*fn)(void *), void *child_stack,
@@ -1231,7 +1231,7 @@ struct kernel_stat {
: "0"(-EINVAL), "i"(__NR_clone),
"m"(fn), "m"(child_stack), "m"(flags), "m"(arg),
"m"(parent_tidptr), "m"(newtls), "m"(child_tidptr)
- : "esp", "memory", "ecx", "edx", "esi", "edi");
+ : "memory", "ecx", "edx", "esi", "edi");
LSS_RETURN(int, __res);
}
--- chromium-78.0.3904.70/third_party/tcmalloc/chromium/src/base/linux_syscall_support.h.gcc9 2019-10-21 21:07:26.000000000 +0200
+++ chromium-78.0.3904.70/third_party/tcmalloc/chromium/src/base/linux_syscall_support.h 2019-10-28 22:01:10.371213784 +0100
@@ -1067,7 +1067,7 @@ struct kernel_stat {
"pop %%ebx\n" \
CFI_ADJUST_CFA_OFFSET(-4) \
args \
- : "esp", "memory"); \
+ : "memory"); \
LSS_RETURN(type,__res)
#undef _syscall0
#define _syscall0(type,name) \
@@ -1124,7 +1124,7 @@ struct kernel_stat {
: "i" (__NR_##name), "ri" ((long)(arg1)), \
"c" ((long)(arg2)), "d" ((long)(arg3)), \
"S" ((long)(arg4)), "D" ((long)(arg5)) \
- : "esp", "memory"); \
+ : "memory"); \
LSS_RETURN(type,__res); \
}
#undef _syscall6
@@ -1146,7 +1146,7 @@ struct kernel_stat {
: "i" (__NR_##name), "0" ((long)(&__s)), \
"c" ((long)(arg2)), "d" ((long)(arg3)), \
"S" ((long)(arg4)), "D" ((long)(arg5)) \
- : "esp", "memory"); \
+ : "memory"); \
LSS_RETURN(type,__res); \
}
LSS_INLINE int LSS_NAME(clone)(int (*fn)(void *), void *child_stack,
@@ -1232,7 +1232,7 @@ struct kernel_stat {
: "0"(-EINVAL), "i"(__NR_clone),
"m"(fn), "m"(child_stack), "m"(flags), "m"(arg),
"m"(parent_tidptr), "m"(newtls), "m"(child_tidptr)
- : "esp", "memory", "ecx", "edx", "esi", "edi");
+ : "memory", "ecx", "edx", "esi", "edi");
LSS_RETURN(int, __res);
}
--- chromium-78.0.3904.70/v8/src/diagnostics/ia32/disasm-ia32.cc.gcc9 2019-10-21 21:09:21.000000000 +0200
+++ chromium-78.0.3904.70/v8/src/diagnostics/ia32/disasm-ia32.cc 2019-10-29 20:20:31.149741601 +0100
@@ -543,7 +543,7 @@ int DisassemblerIA32::F7Instruction(byte
byte modrm = *++data;
int mod, regop, rm;
get_modrm(modrm, &mod, ®op, &rm);
- const char* mnem = nullptr;
+ const char* mnem = "???";
switch (regop) {
case 0:
mnem = "test";
--- chromium-79.0.3945.16/chrome/browser/previews/resource_loading_hints/resource_loading_hints_web_contents_observer.cc.gcc9 2019-10-29 23:01:56.000000000 +0100
+++ chromium-79.0.3945.16/chrome/browser/previews/resource_loading_hints/resource_loading_hints_web_contents_observer.cc 2019-11-04 23:16:03.781667391 +0100
@@ -119,7 +119,9 @@ void ResourceLoadingHintsWebContentsObse
hints_ptr->ukm_source_id = ukm::ConvertToSourceId(
navigation_handle->GetNavigationId(), ukm::SourceIdType::NAVIGATION_ID);
for (const std::string& hint : hints)
+ {
hints_ptr->subresources_to_block.push_back(hint);
+ }
auto hints_receiver_associated =
GetResourceLoadingHintsReceiver(navigation_handle);
--- chromium-80.0.3987.78/third_party/webrtc/api/function_view.h.gcc9 2020-01-29 22:41:12.000000000 +0100
+++ chromium-80.0.3987.78/third_party/webrtc/api/function_view.h 2020-02-02 00:35:42.969510416 +0100
@@ -76,7 +76,7 @@ class FunctionView<RetT(ArgT...)> final
typename std::remove_reference<F>::type>::type>::value>::type* =
nullptr>
FunctionView(F&& f)
- : call_(f ? CallFunPtr<typename std::remove_pointer<F>::type> : nullptr) {
+ : call_(CallFunPtr<typename std::remove_pointer<F>::type>) {
f_.fun_ptr = reinterpret_cast<void (*)()>(f);
}
--- chromium-80.0.3987.78/content/browser/renderer_host/render_frame_host_impl.cc.gcc9 2020-01-29 22:39:38.000000000 +0100
+++ chromium-80.0.3987.78/content/browser/renderer_host/render_frame_host_impl.cc 2020-02-02 17:56:58.531106249 +0100
@@ -3592,8 +3592,9 @@ void RenderFrameHostImpl::AllowBindings(
// The bindings being granted here should not differ from the bindings that
// the associated WebUI requires.
- if (web_ui_)
+ if (web_ui_) {
CHECK_EQ(web_ui_->GetBindings(), webui_bindings);
+ }
// Ensure we aren't granting WebUI bindings to a process that has already
// been used for non-privileged views.
--- chromium-80.0.3987.78/third_party/blink/renderer/core/editing/commands/delete_selection_command.cc.gcc9 2020-01-29 22:39:40.000000000 +0100
+++ chromium-80.0.3987.78/third_party/blink/renderer/core/editing/commands/delete_selection_command.cc 2020-02-03 06:16:46.601992850 +0100
@@ -226,15 +226,6 @@ static Position TrailingWhitespacePositi
return Position();
}
-// Workaround: GCC fails to resolve overloaded template functions, passed as
-// parameters of EnclosingNodeType. But it works wrapping that in a utility
-// function.
-#if defined(COMPILER_GCC)
-static bool IsHTMLTableRowElement(const blink::Node* node) {
- return IsA<HTMLTableRowElement>(node);
-}
-#endif
-
void DeleteSelectionCommand::InitializePositionData(
EditingState* editing_state) {
DCHECK(!GetDocument().NeedsLayoutTreeUpdate());
@@ -262,19 +253,10 @@ void DeleteSelectionCommand::InitializeP
start_root_ = RootEditableElementOf(start);
end_root_ = RootEditableElementOf(end);
-
-#if defined(COMPILER_GCC)
- // Workaround. See declaration of IsHTMLTableRowElement
- start_table_row_ = To<HTMLTableRowElement>(
- EnclosingNodeOfType(start, &IsHTMLTableRowElement));
- end_table_row_ =
- To<HTMLTableRowElement>(EnclosingNodeOfType(end, &IsHTMLTableRowElement));
-#else
start_table_row_ = To<HTMLTableRowElement>(
- EnclosingNodeOfType(start, &IsA<HTMLTableRowElement>));
+ EnclosingNodeOfType(start, &IsA<HTMLTableRowElement, blink::Node>));
end_table_row_ = To<HTMLTableRowElement>(
- EnclosingNodeOfType(end, &IsA<HTMLTableRowElement>));
-#endif
+ EnclosingNodeOfType(end, &IsA<HTMLTableRowElement, blink::Node>));
// Don't move content out of a table cell.
// If the cell is non-editable, enclosingNodeOfType won't return it by
--- chromium-81.0.4044.43/third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.cc.gcc9 2020-03-04 22:53:00.000000000 +0100
+++ chromium-81.0.4044.43/third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.cc 2020-03-14 00:56:23.225915248 +0100
@@ -201,7 +201,9 @@ PaintImage AcceleratedStaticBitmapImage:
// https://crbug.com/672306
DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
if (!IsValid())
+ {
return PaintImage();
+ }
CreateImageFromMailboxIfNeeded();
@@ -221,8 +223,9 @@ void AcceleratedStaticBitmapImage::Draw(
ImageDecodingMode decode_mode) {
DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
auto paint_image = PaintImageForCurrentFrame();
- if (!paint_image)
+ if (!paint_image) {
return;
+ }
auto paint_image_decoding_mode = ToPaintImageDecodingMode(decode_mode);
if (paint_image.decoding_mode() != paint_image_decoding_mode) {
paint_image = PaintImageBuilder::WithCopy(std::move(paint_image))
--- chromium-83.0.4103.7/components/metrics/call_stack_profile_metadata.cc.gcc9 2020-04-09 00:27:56.000000000 +0200
+++ chromium-83.0.4103.7/components/metrics/call_stack_profile_metadata.cc 2020-04-18 16:16:42.963270266 +0200
@@ -20,8 +20,9 @@ class MatchesNameHashIndexAndKey {
bool operator()(const CallStackProfile::MetadataItem& item) const {
base::Optional<int64_t> item_key_as_optional =
item.has_key() ? item.key() : base::Optional<int64_t>();
- return item.name_hash_index() == name_hash_index_ &&
- key_ == item_key_as_optional;
+ bool a = item.name_hash_index() == name_hash_index_;
+ bool b = key_ == item_key_as_optional;
+ return a && b;
}
private:
--- chromium-83.0.4103.14/content/common/user_agent.cc.gcc9 2020-04-14 23:55:25.000000000 +0200
+++ chromium-83.0.4103.14/content/common/user_agent.cc 2020-04-19 01:31:33.960311497 +0200
@@ -122,7 +122,7 @@ std::string GetOSVersion(bool include_an
"%s%s", android_version_str.c_str(),
android_info_str.c_str()
#else
- ""
+ "%s", ""
#endif
);
return os_version;
--- chromium-83.0.4103.56/third_party/crashpad/crashpad/client/annotation.h.gcc10 2020-05-14 17:55:53.898057027 +0200
+++ chromium-83.0.4103.56/third_party/crashpad/crashpad/client/annotation.h 2020-05-14 17:56:14.374688872 +0200
@@ -241,7 +241,7 @@ class StringAnnotation : public Annotati
void Set(base::StringPiece string) {
Annotation::ValueSizeType size =
std::min(MaxSize, base::saturated_cast<ValueSizeType>(string.size()));
- memcpy(value_, string.data(), size);
+ memcpy(&value_[0], string.data(), size);
// Check for no embedded `NUL` characters.
DCHECK(!memchr(value_, '\0', size)) << "embedded NUL";
SetSize(size);
--- chromium-83.0.4103.56/v8/src/base/ieee754.cc.gcc10 2020-05-13 20:41:59.000000000 +0200
+++ chromium-83.0.4103.56/v8/src/base/ieee754.cc 2020-05-14 22:46:53.395984542 +0200
@@ -614,7 +614,7 @@ recompute:
fw = 0.0;
for (i = jz; i >= 0; i--) fw += fq[i];
y[0] = (ih == 0) ? fw : -fw;
- fw = fq[0] - fw;
+ fw = (jz >= 0) ? fq[0] - fw : 0;
for (i = 1; i <= jz; i++) fw += fq[i];
y[1] = (ih == 0) ? fw : -fw;
break;
--- chromium-84.0.4147.89/third_party/vulkan_memory_allocator/src/vk_mem_alloc.h.gcc10 2020-07-13 20:43:47.000000000 +0200
+++ chromium-84.0.4147.89/third_party/vulkan_memory_allocator/src/vk_mem_alloc.h 2020-07-18 17:06:26.013970016 +0200
@@ -11290,8 +11290,10 @@ void VmaBlockMetadata_Linear::Alloc(
{
SuballocationVectorType& suballocations1st = AccessSuballocations1st();
// New allocation at the end of 2-part ring buffer, so before first allocation from 1st vector.
- VMA_ASSERT(!suballocations1st.empty() &&
- request.offset + allocSize <= suballocations1st[m_1stNullItemsBeginCount].offset);
+ if(suballocations1st.empty() ||
+ request.offset + allocSize > suballocations1st[m_1stNullItemsBeginCount].offset) {
+ VMA_ASSERT(true);
+ }
SuballocationVectorType& suballocations2nd = AccessSuballocations2nd();
switch(m_2ndVectorMode)
@@ -12885,7 +12887,9 @@ VkResult VmaBlockVector::AllocatePage(
if(IsCorruptionDetectionEnabled())
{
VkResult res = pBestRequestBlock->WriteMagicValueAroundAllocation(m_hAllocator, bestRequest.offset, size);
- VMA_ASSERT(res == VK_SUCCESS && "Couldn't map block memory to write magic value.");
+ if (res != VK_SUCCESS) {
+ VMA_ASSERT("Couldn't map block memory to write magic value.");
+ }
}
return VK_SUCCESS;
}
@@ -12931,7 +12935,9 @@ void VmaBlockVector::Free(
if(IsCorruptionDetectionEnabled())
{
VkResult res = pBlock->ValidateMagicValueAroundAllocation(m_hAllocator, hAllocation->GetOffset(), hAllocation->GetSize());
- VMA_ASSERT(res == VK_SUCCESS && "Couldn't map block memory to validate magic value.");
+ if (res != VK_SUCCESS) {
+ VMA_ASSERT("Couldn't map block memory to validate magic value.");
+ }
}
if(hAllocation->IsPersistentMap())
@@ -13088,7 +13094,9 @@ VkResult VmaBlockVector::AllocateFromBlo
if(IsCorruptionDetectionEnabled())
{
VkResult res = pBlock->WriteMagicValueAroundAllocation(m_hAllocator, currRequest.offset, size);
- VMA_ASSERT(res == VK_SUCCESS && "Couldn't map block memory to write magic value.");
+ if (res != VK_SUCCESS) {
+ VMA_ASSERT("Couldn't map block memory to write magic value.");
+ }
}
return VK_SUCCESS;
}
@@ -16801,7 +16809,9 @@ void VmaAllocator_T::DestroyPool(VmaPool
{
VmaMutexLockWrite lock(m_PoolsMutex, m_UseMutex);
bool success = VmaVectorRemoveSorted<VmaPointerLess>(m_Pools, pool);
- VMA_ASSERT(success && "Pool not found in Allocator.");
+ if (!success) {
+ VMA_ASSERT("Pool not found in Allocator.");
+ }
}
vma_delete(this, pool);
@@ -17195,7 +17205,9 @@ void VmaAllocator_T::FreeDedicatedMemory
AllocationVectorType* const pDedicatedAllocations = m_pDedicatedAllocations[memTypeIndex];
VMA_ASSERT(pDedicatedAllocations);
bool success = VmaVectorRemoveSorted<VmaPointerLess>(*pDedicatedAllocations, allocation);
- VMA_ASSERT(success);
+ if (!success) {
+ VMA_ASSERT(success);
+ }
}
VkDeviceMemory hMemory = allocation->GetMemory();
--- chromium-87.0.4280.40/third_party/crashpad/crashpad/client/crashpad_client_linux.cc.gcc10 2020-10-29 23:26:23.000000000 +0100
+++ chromium-87.0.4280.40/third_party/crashpad/crashpad/client/crashpad_client_linux.cc 2020-10-31 21:52:40.400501538 +0100
@@ -455,8 +455,10 @@ bool CrashpadClient::InitializeSignalSta
const size_t kStackAllocSize = kStackSize + 2 * kGuardPageSize;
stack_t stack;
+ stack_t stack2;
stack.ss_flags = SS_DISABLE;
- if (sigaltstack(&stack, &stack) != 0) {
+ stack2.ss_flags = SS_DISABLE;
+ if (sigaltstack(&stack2, &stack) != 0) {
PLOG(ERROR) << "sigaltstack";
} else if (stack.ss_sp !=
static_cast<char*>(stack_mem) + kGuardPageSize) {
--- chromium-87.0.4280.40/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc.gcc10 2020-10-29 23:26:28.000000000 +0100
+++ chromium-87.0.4280.40/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc 2020-10-31 23:23:45.016173466 +0100
@@ -839,7 +839,9 @@ void XkbKeyboardLayoutEngine::SetKeymap(
{ui::EF_NUM_LOCK_ON, XKB_MOD_NAME_NUM}};
xkb_flag_map_.clear();
xkb_flag_map_.reserve(base::size(flags));
+#if defined(OS_CHROMEOS)
xkb_mod_mask_t num_lock_mask = 0;
+#endif
for (size_t i = 0; i < base::size(flags); ++i) {
xkb_mod_index_t index = xkb_keymap_mod_get_index(keymap, flags[i].xkb_name);
if (index == XKB_MOD_INVALID) {
@@ -848,8 +850,10 @@ void XkbKeyboardLayoutEngine::SetKeymap(
xkb_mod_mask_t flag = static_cast<xkb_mod_mask_t>(1) << index;
XkbFlagMapEntry e = {flags[i].ui_flag, flag, index};
xkb_flag_map_.push_back(e);
+#if defined(OS_CHROMEOS)
if (flags[i].ui_flag == EF_NUM_LOCK_ON)
num_lock_mask = flag;
+#endif
}
}
--- chromium-87.0.4280.40/cc/trees/layer_tree_host_impl.cc.gcc10 2020-10-31 11:39:32.501883564 +0100
+++ chromium-87.0.4280.40/cc/trees/layer_tree_host_impl.cc 2020-11-01 03:15:02.320905832 +0100
@@ -2307,8 +2307,10 @@ bool LayerTreeHostImpl::DrawLayers(Frame
auto compositor_frame = GenerateCompositorFrame(frame);
const auto frame_token = compositor_frame.metadata.frame_token;
frame->frame_token = frame_token;
+#if DCHECK_IS_ON()
const viz::BeginFrameId begin_frame_ack_frame_id =
compositor_frame.metadata.begin_frame_ack.frame_id;
+#endif
// Collect |latency_info| information for tracking
lag_tracking_manager_.CollectScrollEventsFromFrame(
--- chromium-87.0.4280.40/third_party/blink/renderer/bindings/core/v8/generated_code_helper.h.gcc10 2020-10-29 23:25:43.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/bindings/core/v8/generated_code_helper.h 2020-11-01 23:08:24.891153676 +0100
@@ -130,7 +130,7 @@ typename IDLSequence<T>::ImplType Variad
if (exception_state.HadException())
return VectorType();
}
- return std::move(result);
+ return result;
}
CORE_EXPORT base::Optional<size_t> FindIndexInEnumStringTable(
--- chromium-88.0.4324.41/media/gpu/vaapi/vaapi_wrapper.h.gcc10 2020-12-10 13:02:58.000000000 +0100
+++ chromium-88.0.4324.41/media/gpu/vaapi/vaapi_wrapper.h 2020-12-13 01:30:51.922961553 +0100
@@ -318,8 +318,8 @@ class MEDIA_GPU_EXPORT VaapiWrapper
// Convenient templatized version of SubmitBuffer() where |size| is deduced to
// be the size of the type of |*data|.
template <typename T>
- bool SubmitBuffer(VABufferType va_buffer_type,
- const T* data) WARN_UNUSED_RESULT {
+ WARN_UNUSED_RESULT bool SubmitBuffer(VABufferType va_buffer_type,
+ const T* data) {
return SubmitBuffer(va_buffer_type, sizeof(T), data);
}
// Batch-version of SubmitBuffer(), where the lock for accessing libva is
--- chromium-88.0.4324.41/content/browser/renderer_host/render_frame_host_manager.cc.gcc10 2020-12-13 06:30:18.410387873 +0100
+++ chromium-88.0.4324.41/content/browser/renderer_host/render_frame_host_manager.cc 2020-12-13 22:16:44.589698544 +0100
@@ -2463,8 +2463,9 @@ void RenderFrameHostManager::CreateRende
// TODO(fergal): We cannot put a CHECK in the else of this if because we do
// not have enough information about who is calling this. If we knew it was
// navigating then we could CHECK_EQ and CHECK_NE otherwise.
- if (!render_frame_host_->must_be_replaced())
+ if (!render_frame_host_->must_be_replaced()) {
CHECK_NE(instance, render_frame_host_->GetSiteInstance());
+ }
} else {
// If policy allows early commit, a RenderFrameProxyHost should never be
// created in the same SiteInstance as the current RFH.
--- chromium-88.0.4324.79/ui/gfx/image/image_skia_rep_default.cc.gcc10 2021-01-08 07:59:05.000000000 +0100
+++ chromium-88.0.4324.79/ui/gfx/image/image_skia_rep_default.cc 2021-01-11 18:24:41.627044461 +0100
@@ -35,8 +35,9 @@ ImageSkiaRep::ImageSkiaRep(const SkBitma
scale_(scale) {
// If the bitmap has been initialized then it must be in N32 format.
if (!(bitmap_.isNull() && bitmap_.colorType() == kUnknown_SkColorType &&
- bitmap_.alphaType() == kUnknown_SkAlphaType))
+ bitmap_.alphaType() == kUnknown_SkAlphaType)) {
CHECK_EQ(bitmap_.colorType(), kN32_SkColorType);
+ }
bitmap_.setImmutable();
paint_image_ = cc::PaintImage::CreateFromBitmap(src);
}
