--- chromium-64.0.3282.71/third_party/blink/renderer/platform/graphics/darkmode/darkmode_classifier.cc.gcc7 2018-01-04 00:06:32.000000000 +0100
+++ chromium-64.0.3282.71/third_party/blink/renderer/platform/graphics/darkmode/darkmode_classifier.cc 2018-01-07 22:06:16.757401299 +0100
@@ -1127,7 +1127,6 @@
,
FixedAllocations* __restrict fixed) {
const int32_t input0_shape[] = {1, 4};
- int32_t logits_MatMul_merged_with_dnn_logits_BiasAdd0_shape[2];
// dnn/hiddenlayer_0/MatMul_merged_with_dnn/hiddenlayer_0/BiasAdd
FullyConnected<float>(input0_shape, input0,
@@ -1150,8 +1149,6 @@
dnn_logits_weights_part_0.values, dnn_logits_biases_part_0_shape,
dnn_logits_biases_part_0.values,
logits_MatMul_merged_with_dnn_logits_BiasAdd0);
- logits_MatMul_merged_with_dnn_logits_BiasAdd0_shape[0] = 1;
- logits_MatMul_merged_with_dnn_logits_BiasAdd0_shape[1] = 1;
}
} // namespace darkmode_tfnative_model
--- chromium-67.0.3396.10/third_party/blink/renderer/core/page/focus_controller.cc.gcc7 2018-04-18 21:05:40.000000000 +0200
+++ chromium-67.0.3396.10/third_party/blink/renderer/core/page/focus_controller.cc 2018-04-22 23:10:03.717765400 +0200
@@ -201,9 +201,6 @@ class ScopedFocusNavigation {
static ScopedFocusNavigation OwnedByIFrame(const HTMLFrameOwnerElement&,
FocusController::OwnerMap&);
static HTMLSlotElement* FindFallbackScopeOwnerSlot(const Element&);
- static bool IsSlotFallbackScoped(const Element&);
- static bool IsSlotFallbackScopedForThisSlot(const HTMLSlotElement&,
- const Element&);
private:
ScopedFocusNavigation(ContainerNode& scoping_root_node,
@@ -334,25 +331,6 @@ HTMLSlotElement* ScopedFocusNavigation::
return nullptr;
}
-bool ScopedFocusNavigation::IsSlotFallbackScoped(const Element& element) {
- return ScopedFocusNavigation::FindFallbackScopeOwnerSlot(element);
-}
-
-bool ScopedFocusNavigation::IsSlotFallbackScopedForThisSlot(
- const HTMLSlotElement& slot,
- const Element& current) {
- Element* parent = current.parentElement();
- while (parent) {
- auto* html_slot_element = DynamicTo<HTMLSlotElement>(parent);
- if (html_slot_element && html_slot_element->AssignedNodes().IsEmpty()) {
- return !SlotScopedTraversal::IsSlotScoped(current) &&
- html_slot_element == slot;
- }
- parent = parent->parentElement();
- }
- return false;
-}
-
inline void DispatchBlurEvent(const Document& document,
Element& focused_element) {
focused_element.DispatchBlurEvent(nullptr, mojom::blink::FocusType::kPage);
--- chromium-69.0.3497.4/content/browser/renderer_host/input/mouse_wheel_event_queue.cc.gcc7 2018-07-21 09:13:03.000000000 +0200
+++ chromium-69.0.3497.4/content/browser/renderer_host/input/mouse_wheel_event_queue.cc 2018-07-21 23:53:41.085484269 +0200
@@ -178,13 +178,11 @@
bool current_phase_ended = false;
bool scroll_phase_ended = false;
bool momentum_phase_ended = false;
- bool has_phase_info = false;
if (event_sent_for_gesture_ack_->event.phase !=
blink::WebMouseWheelEvent::kPhaseNone ||
event_sent_for_gesture_ack_->event.momentum_phase !=
blink::WebMouseWheelEvent::kPhaseNone) {
- has_phase_info = true;
scroll_phase_ended = event_sent_for_gesture_ack_->event.phase ==
blink::WebMouseWheelEvent::kPhaseEnded ||
event_sent_for_gesture_ack_->event.phase ==
--- chromium-70.0.3528.4/content/browser/media/capture/mouse_cursor_overlay_controller_aura.cc.gcc8 2018-08-21 11:49:37.000000000 +0200
+++ chromium-70.0.3528.4/content/browser/media/capture/mouse_cursor_overlay_controller_aura.cc 2018-08-28 16:24:08.166914370 +0200
@@ -178,7 +178,7 @@ gfx::RectF MouseCursorOverlayController:
if (auto* window = Observer::GetTargetWindow(observer_)) {
const gfx::Size window_size = window->bounds().size();
if (!window_size.IsEmpty()) {
- if (auto* root_window = window->GetRootWindow()) {
+ if (window->GetRootWindow()) {
// Compute the cursor size in terms of DIP coordinates.
const SkBitmap& bitmap = GetCursorBitmap(cursor);
const float scale_factor = cursor.image_scale_factor();
--- chromium-70.0.3538.22/components/viz/host/gpu_host_impl.cc.gcc8 2018-09-19 21:10:42.000000000 +0200
+++ chromium-70.0.3538.22/components/viz/host/gpu_host_impl.cc 2018-09-23 22:14:53.434515786 +0200
@@ -46,7 +46,6 @@ class FontRenderParams {
friend class base::NoDestructor<FontRenderParams>;
FontRenderParams();
- ~FontRenderParams();
THREAD_CHECKER(thread_checker_);
base::Optional<gfx::FontRenderParams> params_;
@@ -66,10 +65,6 @@ const base::Optional<gfx::FontRenderPara
FontRenderParams::FontRenderParams() = default;
-FontRenderParams::~FontRenderParams() {
- NOTREACHED();
-}
-
FontRenderParams& GetFontRenderParams() {
static base::NoDestructor<FontRenderParams> instance;
return *instance;
--- chromium-70.0.3538.22/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc.gcc8 2018-09-19 21:11:35.000000000 +0200
+++ chromium-70.0.3538.22/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc 2018-09-24 22:40:30.244928180 +0200
@@ -5141,10 +5141,6 @@ void WebGLRenderingContextBase::TexImage
possible_direct_copy = Extensions3DUtil::CanUseCopyTextureCHROMIUM(target);
}
- GLint copy_x_offset = xoffset;
- GLint copy_y_offset = yoffset;
- GLenum copy_target = target;
-
// if direct copy is not possible, create a temporary texture and then copy
// from canvas to temporary texture to target texture.
if (!possible_direct_copy) {
@@ -5160,9 +5156,6 @@ void WebGLRenderingContextBase::TexImage
GL_CLAMP_TO_EDGE);
ContextGL()->TexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, width, height, 0,
GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
- copy_x_offset = 0;
- copy_y_offset = 0;
- copy_target = GL_TEXTURE_2D;
}
{
--- chromium-72.0.3626.81/third_party/blink/renderer/core/editing/element_inner_text.cc.gcc8 2019-01-30 02:18:14.000000000 +0100
+++ chromium-72.0.3626.81/third_party/blink/renderer/core/editing/element_inner_text.cc 2019-02-03 17:03:47.484469962 +0100
@@ -52,7 +52,6 @@ class ElementInnerTextCollector final {
public:
Result() = default;
- void EmitChar16(UChar code_point);
void EmitNewline();
void EmitRequiredLineBreak(int count);
void EmitTab();
@@ -420,12 +405,6 @@ void ElementInnerTextCollector::ProcessT
// ----
-void ElementInnerTextCollector::Result::EmitChar16(UChar code_point) {
- FlushRequiredLineBreak();
- DCHECK_EQ(required_line_break_count_, 0);
- builder_.Append(code_point);
-}
-
void ElementInnerTextCollector::Result::EmitNewline() {
FlushRequiredLineBreak();
builder_.Append(kNewlineCharacter);
--- chromium-73.0.3683.75/cc/trees/layer_tree_host.cc.gcc8 2019-03-11 23:00:52.000000000 +0100
+++ chromium-73.0.3683.75/cc/trees/layer_tree_host.cc 2019-03-17 19:34:15.025887235 +0100
@@ -1246,8 +1246,6 @@ void LayerTreeHost::SetViewportRectAndSc
const gfx::Rect& device_viewport_rect,
float device_scale_factor,
const viz::LocalSurfaceId& local_surface_id_from_parent) {
- const viz::LocalSurfaceId previous_local_surface_id =
- local_surface_id_from_parent_;
SetLocalSurfaceIdFromParent(local_surface_id_from_parent);
bool device_viewport_rect_changed = false;
--- chromium-73.0.3683.75/chrome/browser/apps/platform_apps/audio_focus_web_contents_observer.h.gcc8 2019-03-11 23:00:53.000000000 +0100
+++ chromium-73.0.3683.75/chrome/browser/apps/platform_apps/audio_focus_web_contents_observer.h 2019-03-17 21:44:42.711684224 +0100
@@ -22,7 +22,6 @@ class AudioFocusWebContentsObserver
private:
friend class content::WebContentsUserData<AudioFocusWebContentsObserver>;
- friend class AudioFocusWebContentsObserver;
friend class AudioFocusWebContentsObserverBrowserTest;
explicit AudioFocusWebContentsObserver(content::WebContents*);
--- chromium-74.0.3729.40/third_party/glslang/src/SPIRV/SpvPostProcess.cpp.gcc8 2019-03-27 19:52:46.000000000 +0100
+++ chromium-74.0.3729.40/third_party/glslang/src/SPIRV/SpvPostProcess.cpp 2019-03-30 19:37:45.068435622 +0100
@@ -256,9 +256,7 @@ void Builder::postProcess(Instruction& i
}
}
assert(inst.getNumOperands() >= 3);
- unsigned int memoryAccess = inst.getImmediateOperand((inst.getOpCode() == OpStore) ? 2 : 1);
- assert(memoryAccess & MemoryAccessAlignedMask);
- static_cast<void>(memoryAccess);
+ assert(inst.getImmediateOperand((inst.getOpCode() == OpStore) ? 2 : 1) & MemoryAccessAlignedMask);
// Compute the index of the alignment operand.
int alignmentIdx = 2;
if (inst.getOpCode() == OpStore)
--- chromium-74.0.3729.40/third_party/nasm/asm/nasm.c.gcc8 2019-03-27 19:52:48.000000000 +0100
+++ chromium-74.0.3729.40/third_party/nasm/asm/nasm.c 2019-03-30 19:45:26.195518119 +0100
@@ -421,26 +421,6 @@ static void emit_dependencies(struct str
fclose(deps);
}
-/* Convert a struct tm to a POSIX-style time constant */
-static int64_t make_posix_time(const struct tm *tm)
-{
- int64_t t;
- int64_t y = tm->tm_year;
-
- /* See IEEE 1003.1:2004, section 4.14 */
-
- t = (y-70)*365 + (y-69)/4 - (y-1)/100 + (y+299)/400;
- t += tm->tm_yday;
- t *= 24;
- t += tm->tm_hour;
- t *= 60;
- t += tm->tm_min;
- t *= 60;
- t += tm->tm_sec;
-
- return t;
-}
-
/*
* Quote a filename string if and only if it is necessary.
* It is considered necessary if any one of these is true:
--- chromium-75.0.3766.2/mojo/core/channel.cc.gcc8 2019-04-16 03:14:06.000000000 +0200
+++ chromium-75.0.3766.2/mojo/core/channel.cc 2019-04-21 07:15:42.489256150 +0200
@@ -706,7 +706,6 @@ bool Channel::OnReadComplete(size_t byte
Channel::DispatchResult Channel::TryDispatchMessage(
base::span<const char> buffer,
size_t* size_hint) {
- bool did_consume_message = false;
// We have at least enough data available for a LegacyHeader.
const Message::LegacyHeader* legacy_header =
@@ -784,12 +783,9 @@ Channel::DispatchResult Channel::TryDisp
std::move(handles))) {
return DispatchResult::kError;
}
- did_consume_message = true;
} else if (deferred) {
- did_consume_message = true;
} else if (delegate_) {
delegate_->OnChannelMessage(payload, payload_size, std::move(handles));
- did_consume_message = true;
}
*size_hint = legacy_header->num_bytes;
--- chromium-75.0.3766.2/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc.gcc8 2019-04-16 03:14:09.000000000 +0200
+++ chromium-75.0.3766.2/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc 2019-04-22 13:54:48.119685210 +0200
@@ -529,13 +529,10 @@ void ResourceLoadScheduler::ShowConsoleM
return;
const base::Time limit = clock_->Now() - base::TimeDelta::FromSeconds(60);
- ThrottleOption target_option;
if (pending_queue_update_times_[ThrottleOption::kThrottleable] < limit &&
!IsPendingRequestEffectivelyEmpty(ThrottleOption::kThrottleable)) {
- target_option = ThrottleOption::kThrottleable;
} else if (pending_queue_update_times_[ThrottleOption::kStoppable] < limit &&
!IsPendingRequestEffectivelyEmpty(ThrottleOption::kStoppable)) {
- target_option = ThrottleOption::kStoppable;
} else {
// At least, one of the top requests in pending queues was handled in the
// last 1 minutes, or there is no pending requests in the inactive queue.
--- chromium-76.0.3809.46/media/filters/source_buffer_stream.cc.gcc8 2019-06-27 23:59:29.000000000 +0200
+++ chromium-76.0.3809.46/media/filters/source_buffer_stream.cc 2019-07-02 03:30:58.185802349 +0200
@@ -670,7 +670,6 @@ bool SourceBufferStream::IsDtsMonotonica
const BufferQueue& buffers) {
DCHECK(!buffers.empty());
DecodeTimestamp prev_dts = last_appended_buffer_decode_timestamp_;
- bool prev_is_keyframe = last_appended_buffer_is_keyframe_;
for (BufferQueue::const_iterator itr = buffers.begin();
itr != buffers.end(); ++itr) {
DecodeTimestamp current_dts = (*itr)->GetDecodeTimestamp();
@@ -701,7 +700,6 @@ bool SourceBufferStream::IsDtsMonotonica
}
prev_dts = current_dts;
- prev_is_keyframe = current_is_keyframe;
}
return true;
}
--- chromium-76.0.3809.46/third_party/blink/renderer/core/editing/commands/insert_paragraph_separator_command.cc.gcc8 2019-06-27 23:59:38.000000000 +0200
+++ chromium-76.0.3809.46/third_party/blink/renderer/core/editing/commands/insert_paragraph_separator_command.cc 2019-07-02 23:33:01.266250287 +0200
@@ -596,8 +596,7 @@ void InsertParagraphSeparatorCommand::Do
->CollapseWhiteSpace())
<< position_after_split;
DeleteInsignificantTextDownstream(position_after_split);
- if (auto* is_text_node =
- DynamicTo<Text>(position_after_split.AnchorNode())) {
+ if (DynamicTo<Text>(position_after_split.AnchorNode())) {
InsertTextIntoNode(
To<Text>(position_after_split.ComputeContainerNode()), 0,
NonBreakingSpaceString());
--- chromium-76.0.3809.46/third_party/blink/renderer/core/layout/layout_text.cc.gcc8 2019-06-27 23:59:38.000000000 +0200
+++ chromium-76.0.3809.46/third_party/blink/renderer/core/layout/layout_text.cc 2019-07-03 00:37:29.459935571 +0200
@@ -611,9 +611,6 @@ void LayoutText::AbsoluteQuadsForRange(V
// Find fragments that have text for the specified range.
DCHECK_LE(start, end);
- const LayoutBlock* block_for_flipping = nullptr;
- if (UNLIKELY(HasFlippedBlocksWritingMode()))
- block_for_flipping = ContainingBlock();
NGInlineCursor cursor;
for (cursor.MoveTo(*this); cursor; cursor.MoveToNextForSameLayoutObject()) {
const NGTextOffset offset = cursor.Current().TextOffset();
--- chromium-76.0.3809.46/ui/accessibility/ax_node_position.cc.gcc8 2019-06-28 00:00:16.000000000 +0200
+++ chromium-76.0.3809.46/ui/accessibility/ax_node_position.cc 2019-07-06 19:01:14.266430629 +0200
@@ -102,7 +102,6 @@ base::stack<AXNode*> AXNodePosition::Get
base::stack<AXNode*> anchors;
AXNode* current_anchor = GetAnchor();
- AXNode::AXID current_anchor_id = GetAnchor()->id();
AXTreeID current_tree_id = tree_id();
AXNode::AXID parent_anchor_id = AXNode::kInvalidAXID;
@@ -114,7 +113,6 @@ base::stack<AXNode*> AXNodePosition::Get
current_anchor /*child*/, current_tree_id /*child_tree_id*/,
&parent_tree_id /*parent_tree_id*/, &parent_anchor_id /*parent_id*/);
- current_anchor_id = parent_anchor_id;
current_tree_id = parent_tree_id;
}
return anchors;
--- chromium-77.0.3865.10/base/task/sequence_manager/task_queue_impl.cc.gcc9 2019-08-06 13:56:01.000000000 +0200
+++ chromium-77.0.3865.10/base/task/sequence_manager/task_queue_impl.cc 2019-08-17 21:00:20.384139512 +0200
@@ -1298,11 +1298,9 @@ void TaskQueueImpl::MaybeReportIpcTaskQu
return;
base::TimeDelta time_since_disabled;
- bool should_report = false;
{
base::internal::CheckedAutoLock lock(any_thread_lock_);
- should_report =
- ShouldReportIpcTaskQueuedFromAnyThreadLocked(&time_since_disabled);
+ (void)ShouldReportIpcTaskQueuedFromAnyThreadLocked(&time_since_disabled);
}
ReportIpcTaskQueued(pending_task, task_queue_name, time_since_disabled);
--- chromium-77.0.3865.10/third_party/webrtc/test/fake_encoder.cc.gcc9 2019-08-06 13:58:31.000000000 +0200
+++ chromium-77.0.3865.10/third_party/webrtc/test/fake_encoder.cc 2019-08-17 23:14:49.202586641 +0200
@@ -95,7 +95,6 @@ int32_t FakeEncoder::Encode(const VideoF
SpatialLayer simulcast_streams[kMaxSimulcastStreams];
EncodedImageCallback* callback;
RateControlParameters rates;
- VideoCodecMode mode;
bool keyframe;
uint32_t counter;
absl::optional<int> qp;
@@ -108,7 +107,6 @@ int32_t FakeEncoder::Encode(const VideoF
}
callback = callback_;
rates = current_rate_settings_;
- mode = config_.mode;
if (rates.framerate_fps <= 0.0) {
rates.framerate_fps = max_framerate;
}
--- chromium-77.0.3865.35/net/http/http_auth_cache.cc.gcc9 2019-08-15 00:02:10.000000000 +0200
+++ chromium-77.0.3865.35/net/http/http_auth_cache.cc 2019-08-18 02:50:38.419252330 +0200
@@ -166,7 +166,6 @@ HttpAuthCache::Entry* HttpAuthCache::Add
HttpAuthCache::Entry* entry =
Lookup(origin, target, realm, scheme, network_isolation_key);
if (!entry) {
- bool evicted = false;
// Failsafe to prevent unbounded memory growth of the cache.
//
// Data was collected in June of 2019, before entries were keyed on either
@@ -178,7 +177,6 @@ HttpAuthCache::Entry* HttpAuthCache::Add
if (entries_.size() >= kMaxNumRealmEntries) {
DLOG(WARNING) << "Num auth cache entries reached limit -- evicting";
EvictLeastRecentlyUsedEntry();
- evicted = true;
}
entry = &(entries_
.emplace(std::make_pair(
@@ -244,7 +242,6 @@ void HttpAuthCache::Entry::AddPath(const
// Remove any entries that have been subsumed by the new entry.
base::EraseIf(paths_, IsEnclosedBy(parent_dir));
- bool evicted = false;
// Failsafe to prevent unbounded memory growth of the cache.
//
// Data collected on June of 2019 indicate that when we get here, the list
@@ -253,7 +250,6 @@ void HttpAuthCache::Entry::AddPath(const
DLOG(WARNING) << "Num path entries for " << origin()
<< " has grown too large -- evicting";
paths_.pop_back();
- evicted = true;
}
// Add new path.
--- chromium-77.0.3865.35/services/network/network_context.cc.gcc9 2019-08-15 00:02:11.000000000 +0200
+++ chromium-77.0.3865.35/services/network/network_context.cc 2019-08-18 05:56:17.662933747 +0200
@@ -531,9 +531,6 @@ void NetworkContext::GetRestrictedCookie
const net::SiteForCookies& site_for_cookies,
const url::Origin& top_frame_origin,
mojo::PendingRemote<mojom::CookieAccessObserver> cookie_observer) {
- mojom::NetworkServiceClient* network_service_client = nullptr;
- if (network_service())
- network_service_client = network_service()->client();
restricted_cookie_manager_receivers_.Add(
std::make_unique<RestrictedCookieManager>(
--- chromium-77.0.3865.35/chrome/browser/download/download_offline_content_provider.cc.gcc9 2019-08-15 00:02:00.000000000 +0200
+++ chromium-77.0.3865.35/chrome/browser/download/download_offline_content_provider.cc 2019-08-18 20:59:18.412269604 +0200
@@ -92,10 +92,6 @@ class AllDownloadObserver
DISALLOW_COPY_AND_ASSIGN(AllDownloadObserver);
};
-AllDownloadObserver::AllDownloadObserver(
- DownloadOfflineContentProvider* provider)
- : provider_(provider) {}
-
AllDownloadObserver::~AllDownloadObserver() {}
void AllDownloadObserver::OnDownloadUpdated(
--- chromium-77.0.3865.35/third_party/blink/renderer/core/input/event_handler.cc.gcc7 2019-08-15 00:02:12.000000000 +0200
+++ chromium-77.0.3865.35/third_party/blink/renderer/core/input/event_handler.cc 2019-08-20 04:02:47.873682429 +0200
@@ -1387,13 +1387,6 @@ void EventHandler::ReleasePointerCapture
LocalFrame* frame = frame_;
LocalFrame* parent = DynamicTo<LocalFrame>(frame_->Tree().Parent());
while (parent) {
- Element* subframe_element = nullptr;
- if (frame->OwnerLayoutObject() &&
- frame->OwnerLayoutObject()->GetNode()) {
- subframe_element =
- DynamicTo<Element>(frame->OwnerLayoutObject()->GetNode());
- }
-
parent->GetEventHandler().capturing_subframe_element_ = nullptr;
frame = parent;
parent = DynamicTo<LocalFrame>(parent->Tree().Parent());
--- chromium-77.0.3865.35/third_party/blink/renderer/core/input/event_handler.cc.gcc9 2019-08-20 04:02:47.873682429 +0200
+++ chromium-77.0.3865.35/third_party/blink/renderer/core/input/event_handler.cc 2019-08-20 04:46:11.073469964 +0200
@@ -1384,11 +1384,9 @@ void EventHandler::ReleasePointerCapture
// approach for removing mouse subframe capture. It must be re-write
// before enable the flag.
if (RuntimeEnabledFeatures::MouseSubframeNoImplicitCaptureEnabled()) {
- LocalFrame* frame = frame_;
LocalFrame* parent = DynamicTo<LocalFrame>(frame_->Tree().Parent());
while (parent) {
parent->GetEventHandler().capturing_subframe_element_ = nullptr;
- frame = parent;
parent = DynamicTo<LocalFrame>(parent->Tree().Parent());
}
}
--- chromium-77.0.3865.35/third_party/blink/renderer/core/layout/layout_text.cc.gcc9 2019-08-19 00:48:55.796873598 +0200
+++ chromium-77.0.3865.35/third_party/blink/renderer/core/layout/layout_text.cc 2019-08-20 05:21:48.068556342 +0200
@@ -266,7 +266,7 @@ void LayoutText::RemoveAndDestroyTextBox
DetachAbstractInlineTextBoxesIfNeeded();
ClearFirstInlineFragmentItemIndex();
}
- } else if (NGPaintFragment* first_inline_fragment = FirstInlineFragment()) {
+ } else if (FirstInlineFragment()) {
// Still do this to clear the global hash map in NGAbstractInlineTextBox.
SetFirstInlineFragment(nullptr);
}
--- chromium-77.0.3865.35/third_party/blink/renderer/core/frame/local_frame.cc.gcc9 2019-08-15 00:02:12.000000000 +0200
+++ chromium-77.0.3865.35/third_party/blink/renderer/core/frame/local_frame.cc 2019-08-20 14:58:44.486992693 +0200
@@ -1129,7 +1129,7 @@ ContentCaptureManager* LocalFrame::GetCo
if (!IsLocalRoot())
return nullptr;
- if (auto* content_capture_client = Client()->GetWebContentCaptureClient()) {
+ if (Client()->GetWebContentCaptureClient()) {
if (!content_capture_manager_) {
content_capture_manager_ =
MakeGarbageCollected<ContentCaptureManager>(*this);
--- chromium-78.0.3904.9/base/containers/intrusive_heap.h.gcc9 2019-09-12 05:02:49.000000000 +0200
+++ chromium-78.0.3904.9/base/containers/intrusive_heap.h 2019-09-13 06:34:33.055830792 +0200
@@ -458,7 +458,6 @@ class IntrusiveHeap {
// General operations.
void swap(IntrusiveHeap& other) noexcept;
- friend void swap(IntrusiveHeap& lhs, IntrusiveHeap& rhs) { lhs.swap(rhs); }
// Comparison operators. These check for exact equality. Two heaps that are
// semantically equivalent (contain the same elements, but in different
--- chromium-78.0.3904.9/third_party/blink/renderer/core/paint/ng/ng_paint_fragment_traversal.cc.gcc9 2019-09-12 05:03:05.000000000 +0200
+++ chromium-78.0.3904.9/third_party/blink/renderer/core/paint/ng/ng_paint_fragment_traversal.cc 2019-09-15 11:37:07.874597294 +0200
@@ -86,7 +86,7 @@ void NGPaintFragmentTraversal::MoveToNex
if (IsAtEnd())
return;
- if (const NGPaintFragment* first_child = current_->FirstChild())
+ if (current_->FirstChild())
return MoveToFirstChild();
MoveToNextSiblingOrAncestor();
}
--- chromium-79.0.3945.16/third_party/angle/src/libANGLE/renderer/vulkan/RenderbufferVk.cpp.gcc9 2019-10-29 23:03:40.000000000 +0100
+++ chromium-79.0.3945.16/third_party/angle/src/libANGLE/renderer/vulkan/RenderbufferVk.cpp 2019-11-03 19:12:07.291357114 +0100
@@ -173,14 +173,6 @@ angle::Result RenderbufferVk::setStorage
rendererQueueFamilyIndex, &commandBuffer);
}
- gl::TextureType viewType = imageVk->getImageTextureType();
-
- if (imageVk->getImageTextureType() == gl::TextureType::CubeMap)
- {
- viewType = vk::Get2DTextureType(imageVk->getImage()->getLayerCount(),
- imageVk->getImage()->getSamples());
- }
-
mRenderTarget.init(mImage, &mImageViews, nullptr, nullptr, imageVk->getImageLevel(),
imageVk->getImageLayer(), RenderTargetTransience::Default);
--- chromium-79.0.3945.16/third_party/blink/renderer/core/css/style_engine.cc.gcc9 2019-10-29 23:02:05.000000000 +0100
+++ chromium-79.0.3945.16/third_party/blink/renderer/core/css/style_engine.cc 2019-11-06 22:56:38.979966457 +0100
@@ -1832,7 +1832,7 @@ void StyleEngine::UpdateStyleAndLayoutTr
UpdateViewportStyle();
- if (Element* document_element = GetDocument().documentElement()) {
+ if (GetDocument().documentElement()) {
NthIndexCache nth_index_cache(GetDocument());
if (NeedsStyleRecalc()) {
TRACE_EVENT0("blink,blink_style", "Document::recalcStyle");
--- chromium-79.0.3945.16/third_party/blink/renderer/core/svg/svg_animate_element.cc.gcc9 2019-10-29 23:02:06.000000000 +0100
+++ chromium-79.0.3945.16/third_party/blink/renderer/core/svg/svg_animate_element.cc 2019-11-07 23:43:50.755662393 +0100
@@ -204,7 +204,7 @@ void SVGAnimateElement::ClearTargetPrope
}
void SVGAnimateElement::UpdateTargetProperty() {
- if (SVGElement* target = targetElement())
+ if (targetElement())
ResolveTargetProperty();
else
ClearTargetProperty();
--- chromium-80.0.3987.78/third_party/webrtc/modules/audio_processing/agc/legacy/digital_agc.cc.gcc9 2020-01-29 22:41:13.000000000 +0100
+++ chromium-80.0.3987.78/third_party/webrtc/modules/audio_processing/agc/legacy/digital_agc.cc 2020-02-02 00:30:40.476523534 +0100
@@ -288,15 +288,12 @@ int32_t WebRtcAgc_ComputeDigitalGains(Di
int16_t gate, gain_adj;
int16_t k;
size_t n, L;
- int16_t L2; // samples/subframe
// determine number of samples per ms
if (FS == 8000) {
L = 8;
- L2 = 3;
} else if (FS == 16000 || FS == 32000 || FS == 48000) {
L = 16;
- L2 = 4;
} else {
return -1;
}
--- chromium-80.0.3987.78/components/sync/engine_impl/net/sync_server_connection_manager.cc.gcc9 2020-01-29 22:39:37.000000000 +0100
+++ chromium-80.0.3987.78/components/sync/engine_impl/net/sync_server_connection_manager.cc 2020-02-02 03:58:04.935282175 +0100
@@ -176,20 +176,6 @@ bool Connection::ReadBufferResponse(std:
return true;
}
-bool Connection::ReadDownloadResponse(HttpResponse* response,
- std::string* buffer_out) {
- const int64_t bytes_read =
- ReadResponse(buffer_out, static_cast<int>(response->content_length));
-
- if (bytes_read != response->content_length) {
- LOG(ERROR) << "Mismatched content lengths, server claimed "
- << response->content_length << ", but sent " << bytes_read;
- response->server_status = HttpResponse::IO_ERROR;
- return false;
- }
- return true;
-}
-
int Connection::ReadResponse(std::string* out_buffer, int length) const {
int bytes_read = buffer_.length();
CHECK_LE(length, bytes_read);
--- chromium-80.0.3987.78/chrome/browser/ui/search/search_tab_helper.cc.gcc9 2020-01-29 22:39:35.000000000 +0100
+++ chromium-80.0.3987.78/chrome/browser/ui/search/search_tab_helper.cc 2020-02-02 15:08:20.559684360 +0100
@@ -721,14 +721,12 @@ void SearchTabHelper::OnDeleteAutocomple
bool accepted) {
DCHECK(autocomplete_controller_);
- bool success = false;
std::vector<search::mojom::AutocompleteMatchPtr> matches;
if (accepted && search::DefaultSearchProviderIsGoogle(profile()) &&
autocomplete_controller_->result().size() > line) {
const auto& match = autocomplete_controller_->result().match_at(line);
if (match.SupportsDeletion()) {
- success = true;
autocomplete_controller_->Stop(false);
autocomplete_controller_->DeleteMatch(match);
matches = omnibox::CreateAutocompleteMatches(
--- chromium-81.0.4044.43/third_party/angle/src/libANGLE/renderer/vulkan/vk_cache_utils.cpp.gcc9 2020-03-09 18:39:40.384301268 +0100
+++ chromium-81.0.4044.43/third_party/angle/src/libANGLE/renderer/vulkan/vk_cache_utils.cpp 2020-03-09 19:23:20.074519726 +0100
@@ -847,11 +847,8 @@ angle::Result GraphicsPipelineDesc::init
*pNextPtr = &provokingVertexState;
pNextPtr = &provokingVertexState.pNext;
}
- VkPipelineRasterizationStateStreamCreateInfoEXT rasterStreamState = {};
- rasterStreamState.sType = VK_STRUCTURE_TYPE_PIPELINE_RASTERIZATION_STATE_STREAM_CREATE_INFO_EXT;
if (contextVk->getFeatures().supportsTransformFeedbackExtension.enabled)
{
- rasterStreamState.rasterizationStream = 0;
rasterState.pNext = &rasterLineState;
}
--- chromium-83.0.4103.14/third_party/blink/renderer/core/display_lock/display_lock_context.cc.gcc9 2020-04-14 23:56:28.000000000 +0200
+++ chromium-83.0.4103.14/third_party/blink/renderer/core/display_lock/display_lock_context.cc 2020-04-19 21:30:04.769999443 +0200
@@ -890,7 +890,7 @@ bool DisplayLockContext::ForceUnlockIfNe
// TODO(rakina): If this is after acquire's promise is resolved and update()
// commit() isn't in progress, the web author won't know that the element
// got unlocked. Figure out how to notify the author.
- if (auto* reason = ShouldForceUnlock()) {
+ if (ShouldForceUnlock()) {
if (IsLocked())
Unlock();
return true;
--- chromium-84.0.4147.89/ui/latency/latency_info.cc.gcc9 2020-07-13 20:41:37.000000000 +0200
+++ chromium-84.0.4147.89/ui/latency/latency_info.cc 2020-07-18 21:26:25.902621301 +0200
@@ -60,13 +60,9 @@ bool IsInputLatencyBeginComponent(ui::La
class LatencyInfoTracedValue
: public base::trace_event::ConvertableToTraceFormat {
public:
- static std::unique_ptr<ConvertableToTraceFormat> FromValue(
- std::unique_ptr<base::Value> value);
-
void AppendAsTraceFormat(std::string* out) const override;
private:
- explicit LatencyInfoTracedValue(base::Value* value);
~LatencyInfoTracedValue() override;
std::unique_ptr<base::Value> value_;
@@ -74,12 +70,6 @@ class LatencyInfoTracedValue
DISALLOW_COPY_AND_ASSIGN(LatencyInfoTracedValue);
};
-std::unique_ptr<base::trace_event::ConvertableToTraceFormat>
-LatencyInfoTracedValue::FromValue(std::unique_ptr<base::Value> value) {
- return std::unique_ptr<base::trace_event::ConvertableToTraceFormat>(
- new LatencyInfoTracedValue(value.release()));
-}
-
LatencyInfoTracedValue::~LatencyInfoTracedValue() {
}
@@ -89,10 +79,6 @@ void LatencyInfoTracedValue::AppendAsTra
*out += tmp;
}
-LatencyInfoTracedValue::LatencyInfoTracedValue(base::Value* value)
- : value_(value) {
-}
-
constexpr const char kTraceCategoriesForAsyncEvents[] =
"benchmark,latencyInfo,rail";
--- chromium-84.0.4147.89/chrome/browser/previews/previews_content_util.cc.gcc10 2020-07-13 20:40:23.000000000 +0200
+++ chromium-84.0.4147.89/chrome/browser/previews/previews_content_util.cc 2020-07-19 18:31:11.669266875 +0200
@@ -93,24 +93,20 @@ blink::PreviewsState DetermineAllowedCli
}
// Check commit-time preview types first.
- bool allow_commit_time_previews = false;
if (previews_decider->ShouldAllowPreviewAtNavigationStart(
previews_data, navigation_handle, is_reload,
previews::PreviewsType::DEFER_ALL_SCRIPT)) {
previews_state |= blink::PreviewsTypes::DEFER_ALL_SCRIPT_ON;
- allow_commit_time_previews = true;
}
if (previews_decider->ShouldAllowPreviewAtNavigationStart(
previews_data, navigation_handle, is_reload,
previews::PreviewsType::RESOURCE_LOADING_HINTS)) {
previews_state |= blink::PreviewsTypes::RESOURCE_LOADING_HINTS_ON;
- allow_commit_time_previews = true;
}
if (previews_decider->ShouldAllowPreviewAtNavigationStart(
previews_data, navigation_handle, is_reload,
previews::PreviewsType::NOSCRIPT)) {
previews_state |= blink::PreviewsTypes::NOSCRIPT_ON;
- allow_commit_time_previews = true;
}
return previews_state;
--- chromium-84.0.4147.89/content/browser/download/download_item_utils.cc.gcc10 2020-07-13 20:40:30.000000000 +0200
+++ chromium-84.0.4147.89/content/browser/download/download_item_utils.cc 2020-07-20 02:45:23.642661960 +0200
@@ -24,7 +24,6 @@ class DownloadItemData : public base::Su
BrowserContext* browser_context,
WebContents* web_contents);
static DownloadItemData* Get(const download::DownloadItem* download_item);
- static void Detach(download::DownloadItem* download_item);
BrowserContext* browser_context() const { return browser_context_; }
@@ -58,11 +57,6 @@ DownloadItemData* DownloadItemData::Get(
return static_cast<DownloadItemData*>(download_item->GetUserData(&kKey));
}
-// static
-void DownloadItemData::Detach(download::DownloadItem* download_item) {
- download_item->RemoveUserData(&kKey);
-}
-
void DownloadItemData::WebContentsDestroyed() {
Observe(nullptr);
}
--- chromium-84.0.4147.89/third_party/blink/renderer/core/frame/local_frame_view.cc.gcc10 2020-07-18 05:58:51.507446199 +0200
+++ chromium-84.0.4147.89/third_party/blink/renderer/core/frame/local_frame_view.cc 2020-07-21 15:57:00.021529569 +0200
@@ -653,8 +653,7 @@ bool LocalFrameView::LayoutFromRootObjec
if (!root.NeedsLayout())
return false;
- if (auto* locked_ancestor =
- DisplayLockUtilities::LockedAncestorPreventingLayout(root)) {
+ if (DisplayLockUtilities::LockedAncestorPreventingLayout(root)) {
// Note that since we're preventing the layout on a layout root, we have to
// mark its ancestor chain for layout. The reason for this is that we will
// clear the layout roots whether or not we have finished laying them out,
--- chromium-84.0.4147.89/third_party/blink/renderer/modules/webtransport/quic_transport.cc.gcc10 2020-07-13 20:41:28.000000000 +0200
+++ chromium-84.0.4147.89/third_party/blink/renderer/modules/webtransport/quic_transport.cc 2020-07-21 23:32:00.149340678 +0200
@@ -405,13 +405,6 @@ ScriptPromise QuicTransport::createBidir
return ScriptPromise();
}
- MojoCreateDataPipeOptions options;
- options.struct_size = sizeof(MojoCreateDataPipeOptions);
- options.flags = MOJO_CREATE_DATA_PIPE_FLAG_NONE;
- options.element_num_bytes = 1;
- // TODO(ricea): Find an appropriate value for capacity_num_bytes.
- options.capacity_num_bytes = 0;
-
mojo::ScopedDataPipeProducerHandle outgoing_producer;
mojo::ScopedDataPipeConsumerHandle outgoing_consumer;
if (!CreateStreamDataPipe(&outgoing_producer, &outgoing_consumer,
--- chromium-85.0.4183.83/third_party/angle/src/libANGLE/renderer/vulkan/ContextVk.cpp.gcc10 2020-08-30 21:27:12.520477768 +0200
+++ chromium-85.0.4183.83/third_party/angle/src/libANGLE/renderer/vulkan/ContextVk.cpp 2020-08-30 22:22:25.365489825 +0200
@@ -4011,15 +4011,6 @@ angle::Result ContextVk::getTimestamp(ui
ANGLE_VK_TRY(this, fence.get().init(device, fenceInfo));
// Submit the command buffer
- VkSubmitInfo submitInfo = {};
- submitInfo.sType = VK_STRUCTURE_TYPE_SUBMIT_INFO;
- submitInfo.waitSemaphoreCount = 0;
- submitInfo.pWaitSemaphores = nullptr;
- submitInfo.pWaitDstStageMask = nullptr;
- submitInfo.commandBufferCount = 1;
- submitInfo.pCommandBuffers = commandBuffer.ptr();
- submitInfo.signalSemaphoreCount = 0;
- submitInfo.pSignalSemaphores = nullptr;
Serial throwAwaySerial;
ANGLE_TRY(mRenderer->queueSubmitOneOff(this, std::move(commandBuffer), mContextPriority,
--- chromium-85.0.4183.83/third_party/webrtc/video/video_stream_encoder.cc.gcc10 2020-08-30 21:27:11.384499105 +0200
+++ chromium-85.0.4183.83/third_party/webrtc/video/video_stream_encoder.cc 2020-08-31 03:32:30.910644231 +0200
@@ -1400,14 +1400,8 @@ void VideoStreamEncoder::EncodeVideoFram
rtc::scoped_refptr<VideoFrameBuffer> buffer =
out_frame.video_frame_buffer()->GetMappedFrameBuffer(
info.preferred_pixel_formats);
- bool buffer_was_converted = false;
if (!buffer) {
buffer = out_frame.video_frame_buffer()->ToI420();
- // TODO(https://crbug.com/webrtc/12021): Once GetI420 is pure virtual,
- // this just true as an I420 buffer would return from
- // GetMappedFrameBuffer.
- buffer_was_converted =
- (out_frame.video_frame_buffer()->GetI420() == nullptr);
}
if (!buffer) {
RTC_LOG(LS_ERROR) << "Frame conversion failed, dropping frame.";
@@ -1586,18 +1586,6 @@ EncodedImageCallback::Result VideoStream
// running in parallel on different threads.
encoder_stats_observer_->OnSendEncodedImage(image_copy, codec_specific_info);
- // The simulcast id is signaled in the SpatialIndex. This makes it impossible
- // to do simulcast for codecs that actually support spatial layers since we
- // can't distinguish between an actual spatial layer and a simulcast stream.
- // TODO(bugs.webrtc.org/10520): Signal the simulcast id explicitly.
- int simulcast_id = 0;
- if (codec_specific_info &&
- (codec_specific_info->codecType == kVideoCodecVP8 ||
- codec_specific_info->codecType == kVideoCodecH264 ||
- codec_specific_info->codecType == kVideoCodecGeneric)) {
- simulcast_id = encoded_image.SpatialIndex().value_or(0);
- }
-
EncodedImageCallback::Result result =
sink_->OnEncodedImage(image_copy, codec_specific_info);
--- chromium-85.0.4183.83/gpu/ipc/service/gpu_init.cc.gcc10 2020-08-24 23:40:37.000000000 +0200
+++ chromium-85.0.4183.83/gpu/ipc/service/gpu_init.cc 2020-09-01 18:48:46.475436526 +0200
@@ -745,16 +745,6 @@ bool GpuInit::InitializeVulkan() {
// Histogram GPU.SupportsVulkan and GPU.VulkanVersion were marked as expired.
// TODO(magchen): Add back these two histograms here and re-enable them in
// histograms.xml when we start Vulkan finch on Windows.
- if (!vulkan_use_swiftshader) {
- const bool supports_vulkan = !!vulkan_implementation_;
- uint32_t vulkan_version = 0;
- if (supports_vulkan) {
- const auto& vulkan_info =
- vulkan_implementation_->GetVulkanInstance()->vulkan_info();
- vulkan_version = vulkan_info.used_api_version;
- }
- }
-
if (!vulkan_implementation_)
return false;
--- chromium-85.0.4183.83/ui/base/x/x11_window.cc.gcc10 2020-08-30 21:27:10.554514695 +0200
+++ chromium-85.0.4183.83/ui/base/x/x11_window.cc 2020-09-01 19:36:25.001157683 +0200
@@ -1183,7 +1184,7 @@ void XWindow::ProcessEvent(x11::Event* x
OnFrameExtentsUpdated();
else if (changed_atom == gfx::GetAtom("_NET_WM_DESKTOP"))
OnWorkspaceUpdated();
- } else if (auto* selection = xev->As<x11::SelectionNotifyEvent>()) {
+ } else if (xev->As<x11::SelectionNotifyEvent>()) {
OnXWindowSelectionEvent(xev);
}
}
--- chromium-85.0.4183.83/services/network/public/cpp/cert_verifier/cert_verifier_creation.cc.gcc10 2020-08-24 23:40:41.000000000 +0200
+++ chromium-85.0.4183.83/services/network/public/cpp/cert_verifier/cert_verifier_creation.cc 2020-09-02 01:03:55.310781093 +0200
@@ -87,15 +87,12 @@ std::unique_ptr<net::CertVerifier> Creat
std::unique_ptr<net::CertVerifier> cert_verifier;
- bool use_builtin_cert_verifier;
#if BUILDFLAG(BUILTIN_CERT_VERIFIER_FEATURE_SUPPORTED)
- use_builtin_cert_verifier =
+ bool use_builtin_cert_verifier =
creation_params
? UsingBuiltinCertVerifier(creation_params->use_builtin_cert_verifier)
: UsingBuiltinCertVerifier(
mojom::CertVerifierCreationParams::CertVerifierImpl::kDefault);
-#else
- use_builtin_cert_verifier = false;
#endif
#if BUILDFLAG(IS_ASH)
--- chromium-85.0.4183.83/third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc.gcc10 2020-08-24 23:40:43.000000000 +0200
+++ chromium-85.0.4183.83/third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc 2020-09-04 17:42:23.272705235 +0200
@@ -1510,7 +1510,7 @@ void Color::ApplyValue(StyleResolverStat
ApplyInherit(state);
return;
}
- if (auto* initial_color_value = DynamicTo<CSSInitialColorValue>(value)) {
+ if (DynamicTo<CSSInitialColorValue>(value)) {
DCHECK_EQ(state.GetElement(), state.GetDocument().documentElement());
state.Style()->SetColor(state.Style()->InitialColorForColorScheme());
return;
@@ -3005,7 +3005,7 @@ void InternalVisitedColor::ApplyValue(St
ApplyInherit(state);
return;
}
- if (auto* initial_color_value = DynamicTo<CSSInitialColorValue>(value)) {
+ if (DynamicTo<CSSInitialColorValue>(value)) {
DCHECK_EQ(state.GetElement(), state.GetDocument().documentElement());
state.Style()->SetInternalVisitedColor(
state.Style()->InitialColorForColorScheme());
--- chromium-85.0.4183.83/third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc.gcc10 2020-08-24 23:40:44.000000000 +0200
+++ chromium-85.0.4183.83/third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc 2020-09-05 03:16:00.449449299 +0200
@@ -313,14 +313,6 @@ void PaintLayerCompositor::UpdateAssignm
update_type = std::max(update_type, kCompositingUpdateRebuildTree);
}
- GraphicsLayer* current_parent = nullptr;
- // Save off our current parent. We need this in subframes, because our
- // parent attached us to itself via AttachFrameContentLayersToIframeLayer().
- if (!IsMainFrame() && update_root->GetCompositedLayerMapping()) {
- current_parent =
- update_root->GetCompositedLayerMapping()->MainGraphicsLayer()->Parent();
- }
-
#if DCHECK_IS_ON()
if (update_root->GetCompositingState() != kPaintsIntoOwnBacking) {
AssertWholeTreeNotComposited(*update_root);
--- chromium-87.0.4280.40/gpu/command_buffer/service/shared_image_backing_gl_image.cc.gcc10 2020-10-29 23:25:38.000000000 +0100
+++ chromium-87.0.4280.40/gpu/command_buffer/service/shared_image_backing_gl_image.cc 2020-11-01 01:28:46.681727224 +0100
@@ -394,7 +394,7 @@ void SharedImageBackingGLImage::OnMemory
// Add a |service_guid| which expresses shared ownership between the
// various GPU dumps.
auto client_guid = GetSharedImageGUIDForTracing(mailbox());
- if (auto service_id = GetGLServiceId()) {
+ if (GetGLServiceId()) {
auto service_guid = gl::GetGLTextureServiceGUIDForTracing(GetGLServiceId());
pmd->CreateSharedGlobalAllocatorDump(service_guid);
// TODO(piman): coalesce constant with TextureManager::DumpTextureRef.
--- chromium-87.0.4280.40/ui/base/clipboard/clipboard_x11.cc.gcc10 2020-10-29 23:26:28.000000000 +0100
+++ chromium-87.0.4280.40/ui/base/clipboard/clipboard_x11.cc 2020-11-01 03:25:29.400128325 +0100
@@ -461,7 +461,7 @@ bool ClipboardX11::X11Details::DispatchX
DCHECK_EQ(GetCopyPasteSelection(), clear->selection);
clipboard_owner_.OnSelectionClear(*xev);
}
- } else if (auto* prop = xev->As<x11::PropertyNotifyEvent>()) {
+ } else if (xev->As<x11::PropertyNotifyEvent>()) {
if (primary_owner_.CanDispatchPropertyEvent(*xev))
primary_owner_.OnPropertyEvent(*xev);
if (clipboard_owner_.CanDispatchPropertyEvent(*xev))
--- chromium-87.0.4280.40/chrome/browser/page_load_metrics/observers/core/ukm_page_load_metrics_observer.cc.gcc10 2020-10-31 11:39:32.369885952 +0100
+++ chromium-87.0.4280.40/chrome/browser/page_load_metrics/observers/core/ukm_page_load_metrics_observer.cc 2020-11-01 15:08:08.722802044 +0100
@@ -657,7 +657,6 @@ void UkmPageLoadMetricsObserver::RecordI
debug_builder.SetPaintTiming_LargestContentfulPaint_TerminationState(
static_cast<int>(lcp_state));
- LargestContentState experimental_lcp_state = LargestContentState::kNotFound;
if (all_frames_experimental_largest_contentful_paint.ContainsValidTime()) {
if (WasStartedInForegroundOptionalEventInForeground(
all_frames_experimental_largest_contentful_paint.Time(),
@@ -666,19 +665,15 @@ void UkmPageLoadMetricsObserver::RecordI
.SetPaintTiming_ExperimentalLargestContentfulPaint_ContentType(
static_cast<int>(
all_frames_experimental_largest_contentful_paint.Type()));
- experimental_lcp_state = LargestContentState::kReported;
} else {
// TODO(npm): figure out why this code can be reached given that
// RecordTimingMetrics() is only called when was_hidden_ is set to false.
- experimental_lcp_state = LargestContentState::kFoundButNotReported;
}
} else if (all_frames_experimental_largest_contentful_paint.Time()
.has_value()) {
DCHECK(all_frames_experimental_largest_contentful_paint.Size());
- experimental_lcp_state = LargestContentState::kLargestImageLoading;
} else {
DCHECK(all_frames_experimental_largest_contentful_paint.Empty());
- experimental_lcp_state = LargestContentState::kNotFound;
}
debug_builder
.SetPaintTiming_ExperimentalLargestContentfulPaint_TerminationState(
--- chromium-87.0.4280.40/third_party/blink/renderer/core/frame/remote_frame.cc.gcc10 2020-10-29 23:25:43.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/core/frame/remote_frame.cc 2020-11-01 21:07:48.931576432 +0100
@@ -692,7 +692,7 @@ void RemoteFrame::DidUpdateFramePolicy(c
void RemoteFrame::UpdateOpener(
const base::Optional<base::UnguessableToken>& opener_frame_token) {
- if (auto* web_frame = WebFrame::FromFrame(this)) {
+ if (WebFrame::FromFrame(this)) {
Frame* opener_frame = nullptr;
if (opener_frame_token)
opener_frame = Frame::ResolveFrame(opener_frame_token.value());
--- chromium-87.0.4280.40/third_party/blink/renderer/core/frame/local_frame.cc.gcc10 2020-10-31 11:39:36.707807448 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/core/frame/local_frame.cc 2020-11-01 22:28:16.884978321 +0100
@@ -3107,7 +3107,7 @@ void LocalFrame::BindReportingObserver(
void LocalFrame::UpdateOpener(
const base::Optional<base::UnguessableToken>& opener_frame_token) {
- if (auto* web_frame = WebFrame::FromFrame(this)) {
+ if (WebFrame::FromFrame(this)) {
Frame* opener_frame = nullptr;
if (opener_frame_token)
opener_frame = Frame::ResolveFrame(opener_frame_token.value());
--- chromium-87.0.4280.40/third_party/blink/renderer/core/inspector/request_debug_header_scope.cc.gcc10 2020-10-29 23:25:43.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/core/inspector/request_debug_header_scope.cc 2020-11-01 22:32:20.723530015 +0100
@@ -25,7 +25,7 @@ String RequestDebugHeaderScope::CaptureH
ThreadDebugger* debugger = nullptr;
if (auto* scope = DynamicTo<WorkerGlobalScope>(context))
debugger = WorkerThreadDebugger::From(scope->GetThread()->GetIsolate());
- else if (LocalDOMWindow* dom_window = DynamicTo<LocalDOMWindow>(context))
+ else if (DynamicTo<LocalDOMWindow>(context))
debugger = MainThreadDebugger::Instance();
if (!debugger)
return String();
@@ -43,7 +43,7 @@ RequestDebugHeaderScope::RequestDebugHea
return;
if (auto* scope = DynamicTo<WorkerGlobalScope>(context))
debugger_ = WorkerThreadDebugger::From(scope->GetThread()->GetIsolate());
- else if (auto* window = DynamicTo<LocalDOMWindow>(context))
+ else if (DynamicTo<LocalDOMWindow>(context))
debugger_ = MainThreadDebugger::Instance();
if (debugger_)
debugger_->ExternalAsyncTaskStarted(stack_trace_id_);
--- chromium-87.0.4280.40/third_party/blink/renderer/core/inspector/inspector_highlight.cc.gcc10 2020-10-29 23:25:43.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/core/inspector/inspector_highlight.cc 2020-11-01 22:37:13.538194222 +0100
@@ -769,8 +769,7 @@ Vector<String> GetAuthoredGridTrackSizes
return result;
for (auto list_value : *value_list) {
- if (auto* grid_auto_repeat_value =
- DynamicTo<cssvalue::CSSGridAutoRepeatValue>(list_value.Get())) {
+ if (DynamicTo<cssvalue::CSSGridAutoRepeatValue>(list_value.Get())) {
Vector<String> repeated_track_sizes;
for (auto auto_repeat_value : To<CSSValueList>(*list_value)) {
if (!auto_repeat_value->IsGridLineNamesValue())
--- chromium-87.0.4280.40/third_party/blink/renderer/platform/loader/child_url_loader_factory_bundle.cc.gcc10 2020-10-29 23:25:37.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/platform/loader/child_url_loader_factory_bundle.cc 2020-11-01 22:51:44.855322756 +0100
@@ -135,26 +135,6 @@ class ScopedRequestCrashKeys {
url::debug::ScopedOriginCrashKey request_initiator_;
};
-base::debug::CrashKeyString* GetRequestUrlCrashKey() {
- static auto* crash_key = base::debug::AllocateCrashKeyString(
- "request_url", base::debug::CrashKeySize::Size256);
- return crash_key;
-}
-
-base::debug::CrashKeyString* GetRequestInitiatorCrashKey() {
- static auto* crash_key = base::debug::AllocateCrashKeyString(
- "request_initiator", base::debug::CrashKeySize::Size64);
- return crash_key;
-}
-
-ScopedRequestCrashKeys::ScopedRequestCrashKeys(
- const network::ResourceRequest& request)
- : url_(GetRequestUrlCrashKey(), request.url.possibly_invalid_spec()),
- request_initiator_(GetRequestInitiatorCrashKey(),
- base::OptionalOrNullptr(request.request_initiator)) {}
-
-ScopedRequestCrashKeys::~ScopedRequestCrashKeys() = default;
-
} // namespace
ChildPendingURLLoaderFactoryBundle::ChildPendingURLLoaderFactoryBundle() =
--- chromium-87.0.4280.40/content/renderer/render_frame_impl.cc.gcc10 2020-10-29 23:25:37.000000000 +0100
+++ chromium-87.0.4280.40/content/renderer/render_frame_impl.cc 2020-11-01 22:53:00.955937974 +0100
@@ -2061,10 +2061,6 @@ RenderFrameImpl::~RenderFrameImpl() {
void RenderFrameImpl::Initialize(blink::WebFrame* parent) {
is_main_frame_ = !parent;
- WebFrame* local_root = frame_;
- if (parent && parent->IsWebLocalFrame()) {
- local_root = parent->ToWebLocalFrame()->LocalRoot();
- }
bool is_tracing_rail = false;
bool is_tracing_navigation = false;
TRACE_EVENT_CATEGORY_GROUP_ENABLED("navigation", &is_tracing_navigation);
--- chromium-87.0.4280.40/third_party/blink/renderer/core/layout/ng/ng_block_node.cc.gcc10 2020-10-29 23:25:43.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/core/layout/ng/ng_block_node.cc 2020-11-02 01:51:56.433564524 +0100
@@ -1142,7 +1142,6 @@ void NGBlockNode::CopyFragmentDataToLayo
void NGBlockNode::PlaceChildrenInLayoutBox(
const NGPhysicalBoxFragment& physical_fragment,
const NGBlockBreakToken* previous_break_token) const {
- LayoutBox* rendered_legend = nullptr;
for (const auto& child_fragment : physical_fragment.Children()) {
// Skip any line-boxes we have as children, this is handled within
// NGInlineNode at the moment.
@@ -1151,8 +1150,6 @@ void NGBlockNode::PlaceChildrenInLayoutB
const auto& box_fragment = *To<NGPhysicalBoxFragment>(child_fragment.get());
if (box_fragment.IsFirstForNode()) {
- if (box_fragment.IsRenderedLegend())
- rendered_legend = To<LayoutBox>(box_fragment.GetMutableLayoutObject());
CopyChildFragmentPosition(box_fragment, child_fragment.offset,
physical_fragment, previous_break_token);
}
--- chromium-87.0.4280.40/third_party/blink/renderer/core/layout/ng/ng_fieldset_layout_algorithm.cc.gcc10 2020-10-29 23:25:43.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/core/layout/ng/ng_fieldset_layout_algorithm.cc 2020-11-02 01:52:49.818593448 +0100
@@ -151,7 +151,7 @@ NGBreakStatus NGFieldsetLayoutAlgorithm:
bool has_seen_all_children = false;
if (const auto* token = BreakToken()) {
const auto child_tokens = token->ChildBreakTokens();
- if (wtf_size_t break_token_count = child_tokens.size()) {
+ if (child_tokens.size()) {
scoped_refptr<const NGBlockBreakToken> child_token =
To<NGBlockBreakToken>(child_tokens[0]);
if (child_token) {
--- chromium-87.0.4280.40/third_party/blink/renderer/core/paint/paint_timing_detector.cc.gcc10 2020-10-29 23:25:44.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/core/paint/paint_timing_detector.cc 2020-11-02 13:18:28.091382914 +0100
@@ -377,7 +377,7 @@ void PaintTimingDetector::UpdateLargestC
}
void PaintTimingDetector::ReportIgnoredContent() {
- if (auto* text_timing_detector = GetTextPaintTimingDetector()) {
+ if (GetTextPaintTimingDetector()) {
text_paint_timing_detector_->ReportLargestIgnoredText();
}
if (auto* image_timing_detector = GetImagePaintTimingDetector()) {
--- chromium-87.0.4280.40/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc.gcc10 2020-10-29 23:25:44.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc 2020-11-02 13:39:27.971953973 +0100
@@ -984,7 +984,7 @@ void CompositedLayerMapping::UpdateDraws
CanvasRenderingContext* context =
To<HTMLCanvasElement>(GetLayoutObject().GetNode())->RenderingContext();
// Content layer may be null if context is lost.
- if (cc::Layer* content_layer = context->CcLayer()) {
+ if (context->CcLayer()) {
if (ContentLayerSupportsDirectBackgroundComposition(GetLayoutObject())) {
has_painted_content = false;
draws_background_onto_content_layer_ = true;
--- chromium-87.0.4280.40/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc.gcc10 2020-10-29 23:25:44.000000000 +0100
+++ chromium-87.0.4280.40/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc 2020-11-02 14:13:48.450225395 +0100
@@ -1221,7 +1221,7 @@ void AXObjectCacheImpl::DidInsertChildre
// changed.
DCHECK(node);
while (node) {
- if (AXObject* obj = GetIfExists(node)) {
+ if (GetIfExists(node)) {
TextChanged(node);
return;
}
--- chromium-88.0.4324.41/base/allocator/partition_allocator/partition_oom.h.gcc10 2020-12-10 13:02:40.000000000 +0100
+++ chromium-88.0.4324.41/base/allocator/partition_allocator/partition_oom.h 2020-12-12 21:53:54.965565983 +0100
@@ -21,7 +21,7 @@ typedef void (*OomFunction)(size_t);
namespace internal {
// g_oom_handling_function is invoked when PartitionAlloc hits OutOfMemory.
-static OomFunction g_oom_handling_function = nullptr;
+extern OomFunction g_oom_handling_function;
BASE_EXPORT NOINLINE void PartitionExcessiveAllocationSize(size_t size);
--- chromium-88.0.4324.41/base/allocator/partition_allocator/partition_oom.cc.gcc10 2020-12-10 13:02:40.000000000 +0100
+++ chromium-88.0.4324.41/base/allocator/partition_allocator/partition_oom.cc 2020-12-12 21:54:45.301665676 +0100
@@ -10,6 +10,8 @@
namespace base {
namespace internal {
+OomFunction g_oom_handling_function = nullptr;
+
void NOINLINE PartitionExcessiveAllocationSize(size_t size) {
OOM_CRASH(size);
}
--- chromium-88.0.4324.41/ui/base/x/x11_user_input_monitor.cc.gcc10 2020-12-10 13:03:49.000000000 +0100
+++ chromium-88.0.4324.41/ui/base/x/x11_user_input_monitor.cc 2020-12-13 08:38:56.376451573 +0100
@@ -63,7 +63,7 @@ void XUserInputMonitor::StartMonitor(Wri
if (!connection_) {
// TODO(jamiewalch): We should pass the connection in.
- if (auto* connection = x11::Connection::Get()) {
+ if (x11::Connection::Get()) {
connection_ = x11::Connection::Get()->Clone();
} else {
LOG(ERROR) << "Couldn't open X connection";
--- chromium-88.0.4324.41/chrome/browser/ui/views/profiles/profile_menu_view_base.cc.gcc10 2020-12-13 06:30:18.366388670 +0100
+++ chromium-88.0.4324.41/chrome/browser/ui/views/profiles/profile_menu_view_base.cc 2020-12-13 11:56:29.596759569 +0100
@@ -766,16 +766,15 @@ void ProfileMenuViewBase::AddFeatureButt
views::BoxLayout::Orientation::kVertical));
}
- views::View* button;
if (&icon == &gfx::kNoneIcon) {
- button = features_container_->AddChildView(std::make_unique<HoverButton>(
+ (void)features_container_->AddChildView(std::make_unique<HoverButton>(
base::BindRepeating(&ProfileMenuViewBase::ButtonPressed,
base::Unretained(this), std::move(action)),
text));
} else {
auto icon_view =
std::make_unique<FeatureButtonIconView>(icon, icon_to_image_ratio);
- button = features_container_->AddChildView(std::make_unique<HoverButton>(
+ (void)features_container_->AddChildView(std::make_unique<HoverButton>(
base::BindRepeating(&ProfileMenuViewBase::ButtonPressed,
base::Unretained(this), std::move(action)),
std::move(icon_view), text));
--- chromium-88.0.4324.41/third_party/blink/renderer/platform/heap/impl/persistent.h.gcc10 2020-12-10 13:03:05.000000000 +0100
+++ chromium-88.0.4324.41/third_party/blink/renderer/platform/heap/impl/persistent.h 2020-12-13 22:31:21.449926394 +0100
@@ -291,6 +291,7 @@ class PersistentBase {
void AssignSafe(T* ptr) {
typename PersistentMutexTraits<crossThreadnessConfiguration>::Locker lock;
AssignUnsafe(ptr);
+ (void)lock;
}
NO_SANITIZE_ADDRESS
@@ -332,6 +333,7 @@ class PersistentBase {
&PersistentBase::TracePersistent>::Trampoline;
typename PersistentMutexTraits<crossThreadnessConfiguration>::Locker lock;
persistent_node_.Initialize(this, trace_callback);
+ (void)lock;
}
NO_SANITIZE_ADDRESS
@@ -350,6 +352,7 @@ class PersistentBase {
if (persistent_node_.IsInitialized()) {
typename PersistentMutexTraits<crossThreadnessConfiguration>::Locker lock;
persistent_node_.Uninitialize();
+ (void)lock;
}
}
--- chromium-88.0.4324.41/third_party/blink/renderer/core/animation/document_animations.cc.gcc10 2020-12-10 13:03:03.000000000 +0100
+++ chromium-88.0.4324.41/third_party/blink/renderer/core/animation/document_animations.cc 2020-12-14 13:35:41.882160594 +0100
@@ -125,8 +125,7 @@ void DocumentAnimations::UpdateAnimation
size_t DocumentAnimations::GetAnimationsCount() {
wtf_size_t total_animations_count = 0;
if (document_->View()) {
- if (cc::AnimationHost* host =
- document_->View()->GetCompositorAnimationHost()) {
+ if (document_->View()->GetCompositorAnimationHost()) {
for (auto& timeline : timelines_) {
if (timeline->HasAnimations())
total_animations_count += timeline->AnimationsNeedingUpdateCount();
--- chromium-88.0.4324.41/third_party/blink/renderer/core/frame/event_handler_registry.cc.gcc10 2020-12-10 13:03:03.000000000 +0100
+++ chromium-88.0.4324.41/third_party/blink/renderer/core/frame/event_handler_registry.cc 2020-12-14 13:36:40.274090638 +0100
@@ -202,14 +202,10 @@ void EventHandlerRegistry::DidMoveOutOfP
void EventHandlerRegistry::DidRemoveAllEventHandlers(EventTarget& target) {
bool handlers_changed[kEventHandlerClassCount];
- bool target_set_changed[kEventHandlerClassCount];
for (int i = 0; i < kEventHandlerClassCount; ++i) {
EventHandlerClass handler_class = static_cast<EventHandlerClass>(i);
- EventTargetSet* targets = &targets_[handler_class];
- target_set_changed[i] = targets->Contains(&target);
-
handlers_changed[i] =
UpdateEventHandlerInternal(kRemoveAll, handler_class, &target);
}
--- chromium-88.0.4324.41/content/browser/bluetooth/bluetooth_blocklist.cc.gcc10 2020-12-10 13:02:54.000000000 +0100
+++ chromium-88.0.4324.41/content/browser/bluetooth/bluetooth_blocklist.cc 2020-12-14 14:50:46.327799260 +0100
@@ -44,8 +44,6 @@ void BluetoothBlocklist::Add(base::Strin
if (blocklist_string.empty())
return;
base::StringPairs kv_pairs;
- bool parsed_values = false;
- bool invalid_values = false;
SplitStringIntoKeyValuePairs(blocklist_string,
':', // Key-value delimiter
',', // Key-value pair delimiter
@@ -56,19 +54,15 @@ void BluetoothBlocklist::Add(base::Strin
switch (pair.second[0]) {
case 'e':
Add(uuid, Value::EXCLUDE);
- parsed_values = true;
continue;
case 'r':
Add(uuid, Value::EXCLUDE_READS);
- parsed_values = true;
continue;
case 'w':
Add(uuid, Value::EXCLUDE_WRITES);
- parsed_values = true;
continue;
}
}
- invalid_values = true;
}
}
--- chromium-88.0.4324.41/third_party/blink/renderer/core/layout/ng/table/ng_table_layout_algorithm_utils.cc.gcc10 2020-12-10 13:03:04.000000000 +0100
+++ chromium-88.0.4324.41/third_party/blink/renderer/core/layout/ng/table/ng_table_layout_algorithm_utils.cc 2020-12-14 16:05:33.424042657 +0100
@@ -121,7 +121,6 @@ NGTableTypes::Row ComputeMinimumRowBlock
LayoutUnit max_cell_block_size;
base::Optional<float> row_percent;
bool is_constrained = false;
- bool is_empty = true;
bool has_rowspan_start = false;
wtf_size_t start_cell_index = cell_block_constraints->size();
NGRowBaselineTabulator row_baseline_tabulator;
@@ -129,7 +128,6 @@ NGTableTypes::Row ComputeMinimumRowBlock
// Gather block sizes of all cells.
for (NGBlockNode cell = To<NGBlockNode>(row.FirstChild()); cell;
cell = To<NGBlockNode>(cell.NextSibling())) {
- is_empty = false;
colspan_cell_tabulator->FindNextFreeColumn();
const ComputedStyle& cell_style = cell.Style();
const NGBoxStrut cell_borders = table_borders.CellBorder(
--- chromium-88.0.4324.41/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc.gcc10 2020-12-10 13:03:04.000000000 +0100
+++ chromium-88.0.4324.41/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc 2020-12-14 17:51:16.331173704 +0100
@@ -1150,7 +1150,6 @@ void PaintArtifactCompositor::Update(
// See if we can de-composite any transforms.
DecompositeTransforms();
- const PendingLayer* previous_pending_layer = nullptr;
for (auto& pending_layer : pending_layers_) {
const auto& property_state = pending_layer.property_tree_state;
const auto& transform = property_state.Transform();
@@ -1229,8 +1228,6 @@ void PaintArtifactCompositor::Update(
layer->SetSubtreePropertyChanged();
root_layer_->SetNeedsCommit();
}
-
- previous_pending_layer = &pending_layer;
}
property_tree_manager.Finalize();
