diff -Naur Modem-Vgetty-0.03/ChangeLog Modem-Vgetty-0.04/ChangeLog --- Modem-Vgetty-0.03/ChangeLog 1998-09-08 14:22:41.000000000 +0200 +++ Modem-Vgetty-0.04/ChangeLog 2003-02-05 07:29:46.000000000 +0100 @@ -1,7 +1,9 @@ -$Id: ChangeLog,v 1.4 1998/09/08 12:22:41 kas Exp $ +$Id: ChangeLog,v 1.2 2003/02/05 06:29:46 ceezed Exp $ This is a ChangeLog file for the Modem::Vgetty Perl module. + + Tue Sep 8 12:07:03 MET DST 1998 by kas Added the description of the callme.pl script to the manpage. diff -Naur Modem-Vgetty-0.03/Makefile.PL Modem-Vgetty-0.04/Makefile.PL --- Modem-Vgetty-0.03/Makefile.PL 1998-07-10 20:41:51.000000000 +0200 +++ Modem-Vgetty-0.04/Makefile.PL 2003-02-04 00:12:52.000000000 +0100 @@ -1,5 +1,5 @@ # -# $Id: Makefile.PL,v 1.1 1998/07/10 18:41:51 kas Exp $ +# $Id: Makefile.PL,v 1.1 2003/02/03 21:25:43 ceezed Exp $ # # Copyright (c) 1998 Jan "Yenya" Kasprzak <kas@fi.muni.cz>. All rights # reserved. This package is free software; you can redistribute it and/or diff -Naur Modem-Vgetty-0.03/README Modem-Vgetty-0.04/README --- Modem-Vgetty-0.03/README 1998-09-08 14:22:41.000000000 +0200 +++ Modem-Vgetty-0.04/README 2003-02-04 00:12:52.000000000 +0100 @@ -1,4 +1,11 @@ -$Id: README,v 1.4 1998/09/08 12:22:41 kas Exp $ +$Id: README,v 1.2 2003/02/03 21:26:16 ceezed Exp $ + +This version of Modem::Vgetty has been modified to fix certain issues with +logging to an unopened filehandle and shutting down needlessly on DESTROY. +The author has been notified on a few occasions but a response has yet to +arrive. +Modifications by Patrick Deegan, Psychogenic.com. + The Modem::Vgetty module is a Perl interface to the vgetty program, which can be used for communication with the voice modems. Vgetty diff -Naur Modem-Vgetty-0.03/Vgetty.pm Modem-Vgetty-0.04/Vgetty.pm --- Modem-Vgetty-0.03/Vgetty.pm 1998-09-08 14:22:42.000000000 +0200 +++ Modem-Vgetty-0.04/Vgetty.pm 2003-02-04 00:12:52.000000000 +0100 @@ -1,5 +1,5 @@ # -# $Id: Vgetty.pm,v 1.13 1998/09/08 12:22:42 kas Exp $ +# $Id: Vgetty.pm,v 1.1 2003/02/03 21:25:43 ceezed Exp $ # # Copyright (c) 1998 Jan "Yenya" Kasprzak <kas@fi.muni.cz>. All rights # reserved. This package is free software; you can redistribute it and/or @@ -16,7 +16,7 @@ use vars qw($testing $log_file $VERSION); -$VERSION='0.03'; +$VERSION='0.04'; $testing = 0; $log_file = '/var/log/voicelog'; @@ -99,7 +99,7 @@ sub expect { my $self = shift; - $self->{LOG}->print("expecting: ", (join '|', @_), "\n"); + $self->{LOG}->print("expecting: ", (join '|', @_), "\n") if ($testing > 0); my $received = $self->receive || return undef; for my $expected (@_) { return $received if $received eq $expected; @@ -151,6 +151,7 @@ sub shutdown { my $self = shift; + $self->{'_shutdownDone'} = 1; $self->chat ('', 'GOODBYE', 'GOODBYE SHELL'); $self->{IN}->close; $self->{OUT}->close; @@ -159,7 +160,7 @@ sub DESTROY { my $self = shift; - $self->shutdown; + $self->shutdown unless ($self->{'_shutdownDone'}); } sub enable_events { @@ -174,8 +175,8 @@ sub beep { my $self = shift; - my $freq = shift; - my $len = shift; + my $freq = shift || ''; # optional + my $len = shift || ''; # optional $self->chat ('', "BEEP $freq $len", 'BEEPING'); } @@ -281,7 +282,7 @@ if ($dtmf eq '#') { # Stop the reading now. $_readnum_in_timeout = 0; $self->stop; - $self->{LOG}->print("_readnum_event(): Got #; stopping\n"); + $self->{LOG}->print("_readnum_event(): Got #; stopping\n") if $testing; return; } $_readnum_number .= $dtmf;